From 7d626df079196780635068ae13de2fdadccdfa2c Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 19 Feb 2016 10:33:01 -0800 Subject: Fix minui cleanup path on error. bootable/recovery/minui/resources.cpp:321:21: warning: Branch condition evaluates to a garbage value if (surface[i]) free(surface[i]); ^~~~~~~~~~ bootable/recovery/minui/resources.cpp:424:13: warning: Value stored to 'len' during its initialization is never read int len = row[4]; ^~~ ~~~~~~ Bug: http://b/27264652 Change-Id: Icc1a914c59d6a89dab1b752b2cd2b40549566481 --- minui/resources.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/minui/resources.cpp b/minui/resources.cpp index fdbe554fe..8489d60ef 100644 --- a/minui/resources.cpp +++ b/minui/resources.cpp @@ -283,7 +283,7 @@ int res_create_multi_display_surface(const char* name, int* frames, int* fps, goto exit; } - surface = reinterpret_cast(malloc(*frames * sizeof(GRSurface*))); + surface = reinterpret_cast(calloc(*frames, sizeof(GRSurface*))); if (surface == NULL) { result = -8; goto exit; @@ -318,7 +318,7 @@ exit: if (result < 0) { if (surface) { for (int i = 0; i < *frames; ++i) { - if (surface[i]) free(surface[i]); + free(surface[i]); } free(surface); } @@ -421,7 +421,7 @@ int res_create_localized_alpha_surface(const char* name, png_read_row(png_ptr, row.data(), NULL); int w = (row[1] << 8) | row[0]; int h = (row[3] << 8) | row[2]; - int len = row[4]; + __unused int len = row[4]; char* loc = reinterpret_cast(&row[5]); if (y+1+h >= height || matches_locale(loc, locale)) { -- cgit v1.2.3