From 8620f6a13ef6db5c13989a4f1ec4d4304c8128c6 Mon Sep 17 00:00:00 2001 From: Tiger Wang Date: Fri, 21 Aug 2020 18:15:34 +0100 Subject: StatSerializer: use std::move --- src/WorldStorage/StatSerializer.cpp | 10 +++++----- src/WorldStorage/StatSerializer.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/WorldStorage/StatSerializer.cpp b/src/WorldStorage/StatSerializer.cpp index eff80149e..66be4fc7f 100644 --- a/src/WorldStorage/StatSerializer.cpp +++ b/src/WorldStorage/StatSerializer.cpp @@ -106,7 +106,7 @@ static const std::unordered_map LegacyMapping namespace StatSerializer { - auto MakeStatisticsDirectory(const std::string & WorldPath, std::string FileName) + auto MakeStatisticsDirectory(const std::string & WorldPath, std::string && FileName) { // Even though stats are shared between worlds, they are (usually) saved // inside the folder of the default world. @@ -196,10 +196,10 @@ namespace StatSerializer - void Load(cStatManager & Manager, const std::string & WorldPath, std::string FileName) + void Load(cStatManager & Manager, const std::string & WorldPath, std::string && FileName) { Json::Value Root; - InputFileStream(MakeStatisticsDirectory(WorldPath, FileName)) >> Root; + InputFileStream(MakeStatisticsDirectory(WorldPath, std::move(FileName))) >> Root; LoadLegacyFromJSON(Manager, Root); LoadCustomStatFromJSON(Manager, Root["stats"]["custom"]); @@ -209,13 +209,13 @@ namespace StatSerializer - void Save(const cStatManager & Manager, const std::string & WorldPath, std::string FileName) + void Save(const cStatManager & Manager, const std::string & WorldPath, std::string && FileName) { Json::Value Root; SaveStatToJSON(Manager, Root["stats"]); Root["DataVersion"] = NamespaceSerializer::DataVersion(); - OutputFileStream(MakeStatisticsDirectory(WorldPath, FileName)) << Root; + OutputFileStream(MakeStatisticsDirectory(WorldPath, std::move(FileName))) << Root; } } diff --git a/src/WorldStorage/StatSerializer.h b/src/WorldStorage/StatSerializer.h index 59b502425..1a52b55b7 100644 --- a/src/WorldStorage/StatSerializer.h +++ b/src/WorldStorage/StatSerializer.h @@ -24,8 +24,8 @@ namespace Json { class Value; } namespace StatSerializer { /* Try to load the player statistics. */ - void Load(cStatManager & Manager, const std::string & WorldPath, std::string FileName); + void Load(cStatManager & Manager, const std::string & WorldPath, std::string && FileName); /* Try to save the player statistics. */ - void Save(const cStatManager & Manager, const std::string & WorldPath, std::string FileName); + void Save(const cStatManager & Manager, const std::string & WorldPath, std::string && FileName); } -- cgit v1.2.3