From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/BlockTypeRegistry.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'src/BlockTypeRegistry.cpp') diff --git a/src/BlockTypeRegistry.cpp b/src/BlockTypeRegistry.cpp index 1b77fdd4d..491e03593 100644 --- a/src/BlockTypeRegistry.cpp +++ b/src/BlockTypeRegistry.cpp @@ -17,7 +17,7 @@ BlockInfo::BlockInfo( ): m_PluginName(aPluginName), m_BlockTypeName(aBlockTypeName), - m_Handler(aHandler), + m_Handler(std::move(aHandler)), m_Hints(aHints), m_HintCallbacks(aHintCallbacks) { @@ -94,7 +94,9 @@ void BlockTypeRegistry::registerBlockType( const std::map & aHintCallbacks ) { - auto blockInfo = std::make_shared(aPluginName, aBlockTypeName, aHandler, aHints, aHintCallbacks); + auto blockInfo = std::make_shared( + aPluginName, aBlockTypeName, std::move(aHandler), aHints, aHintCallbacks + ); // Check previous registrations: cCSLock lock(m_CSRegistry); @@ -191,8 +193,8 @@ void BlockTypeRegistry::removeBlockTypeHint( // BlockTypeRegistry::AlreadyRegisteredException: BlockTypeRegistry::AlreadyRegisteredException::AlreadyRegisteredException( - std::shared_ptr aPreviousRegistration, - std::shared_ptr aNewRegistration + const std::shared_ptr & aPreviousRegistration, + const std::shared_ptr & aNewRegistration ) : Super(message(aPreviousRegistration, aNewRegistration)), m_PreviousRegistration(aPreviousRegistration), @@ -205,8 +207,8 @@ BlockTypeRegistry::AlreadyRegisteredException::AlreadyRegisteredException( AString BlockTypeRegistry::AlreadyRegisteredException::message( - std::shared_ptr aPreviousRegistration, - std::shared_ptr aNewRegistration + const std::shared_ptr & aPreviousRegistration, + const std::shared_ptr & aNewRegistration ) { return Printf("Attempting to register BlockTypeName %s from plugin %s, while it is already registered in plugin %s", -- cgit v1.2.3