From fe983a1a45b23c67cf6c758a4f0ffe6a8ba764d6 Mon Sep 17 00:00:00 2001
From: x12xx12x <44411062+12xx12@users.noreply.github.com>
Date: Wed, 20 Apr 2022 00:10:35 +0200
Subject: Valid Height is now checked by vector.

---
 src/ChunkDef.h | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

(limited to 'src/ChunkDef.h')

diff --git a/src/ChunkDef.h b/src/ChunkDef.h
index 2f619f83b..11ef96e81 100644
--- a/src/ChunkDef.h
+++ b/src/ChunkDef.h
@@ -164,15 +164,10 @@ public:
 	}
 
 
-	/** Validates a height-coordinate. Returns false if height-coordiante is out of height bounds */
-	inline static bool IsValidHeight(int a_Height)
-	{
-		return ((a_Height >= 0) && (a_Height < Height));
-	}
-
+	/** Validates a height-coordinate. Returns false if height-coordinate is out of height bounds */
 	inline static bool IsValidHeight(Vector3i a_BlockPosition)
 	{
-		return IsValidHeight(a_BlockPosition.y);
+		return ((a_BlockPosition.y >= 0) && (a_BlockPosition.y < Height));
 	}
 
 
@@ -188,7 +183,7 @@ public:
 	{
 		return (
 			IsValidWidth(a_RelPos.x) &&
-			IsValidHeight(a_RelPos.y) &&
+			IsValidHeight(a_RelPos) &&
 			IsValidWidth(a_RelPos.z)
 		);
 	}
-- 
cgit v1.2.3