From 53549a1a4ce320c1e3f449165c290c74d3de54d4 Mon Sep 17 00:00:00 2001 From: 12xx12 <44411062+12xx12@users.noreply.github.com> Date: Thu, 17 Sep 2020 00:01:20 +0200 Subject: Add some const qualifiers to functions (#4874) * add some const qualifiers to functions * added changes suggested by @tigerw Co-authored-by: 12xx12 <12xx12100@gmail.com> --- src/Enchantments.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/Enchantments.cpp') diff --git a/src/Enchantments.cpp b/src/Enchantments.cpp index 52ebc5e3e..8eda97eba 100644 --- a/src/Enchantments.cpp +++ b/src/Enchantments.cpp @@ -1170,20 +1170,20 @@ void cEnchantments::CheckEnchantmentConflictsFromVector( -cEnchantments cEnchantments::GetRandomEnchantmentFromVector(cWeightedEnchantments & a_Enchantments) +cEnchantments cEnchantments::GetRandomEnchantmentFromVector(const cWeightedEnchantments & a_Enchantments) { int AllWeights = 0; - for (cWeightedEnchantments::iterator it = a_Enchantments.begin(); it != a_Enchantments.end(); ++it) + for (const auto & Enchantment: a_Enchantments) { - AllWeights += (*it).m_Weight; + AllWeights += Enchantment.m_Weight; } int RandomNumber = GetRandomProvider().RandInt(AllWeights - 1); - for (cWeightedEnchantments::iterator it = a_Enchantments.begin(); it != a_Enchantments.end(); ++it) + for (const auto & Enchantment: a_Enchantments) { - RandomNumber -= (*it).m_Weight; + RandomNumber -= Enchantment.m_Weight; if (RandomNumber < 0) { - return (*it).m_Enchantments; + return Enchantment.m_Enchantments; } } -- cgit v1.2.3