From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/Mobs/Path.cpp | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'src/Mobs/Path.cpp') diff --git a/src/Mobs/Path.cpp b/src/Mobs/Path.cpp index a2a5cf51c..378051163 100644 --- a/src/Mobs/Path.cpp +++ b/src/Mobs/Path.cpp @@ -639,15 +639,8 @@ bool cPath::SpecialIsSolidFromThisDirection(BLOCKTYPE a_Type, NIBBLETYPE a_Meta, // If there is a nonsolid above a fence if (!cBlockInfo::IsSolid(a_Type)) { - // If we're coming from below - if (a_Direction.y > 0) - { - return true; // treat the nonsolid as solid - } - else - { - return false; // Treat it as a nonsolid because we are not coming from below - } + // Only treat as solid when we're coming from below + return (a_Direction.y > 0); } /* switch (a_Type) -- cgit v1.2.3