From a4dbb5c58270959884c17d720185da06464fa256 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Wed, 2 May 2018 08:50:36 +0100 Subject: Prefer static_cast to reinterpret_cast (#4223) * Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there. --- src/OSSupport/File.cpp | 2 +- src/OSSupport/NetworkSingleton.cpp | 2 +- src/OSSupport/ServerHandleImpl.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/OSSupport') diff --git a/src/OSSupport/File.cpp b/src/OSSupport/File.cpp index 8b91cc2a4..bb33dc732 100644 --- a/src/OSSupport/File.cpp +++ b/src/OSSupport/File.cpp @@ -285,7 +285,7 @@ int cFile::ReadRestOfFile(AString & a_Contents) // HACK: This depends on the internal knowledge that AString's data() function returns the internal buffer directly a_Contents.assign(DataSize, '\0'); - return Read(reinterpret_cast(const_cast(a_Contents.data())), DataSize); + return Read(static_cast(const_cast(a_Contents.data())), DataSize); } diff --git a/src/OSSupport/NetworkSingleton.cpp b/src/OSSupport/NetworkSingleton.cpp index 2f7ed3802..f855acdc1 100644 --- a/src/OSSupport/NetworkSingleton.cpp +++ b/src/OSSupport/NetworkSingleton.cpp @@ -173,7 +173,7 @@ void cNetworkSingleton::RunEventLoop(cNetworkSingleton * a_Self) void cNetworkSingleton::SignalizeStartup(evutil_socket_t a_Socket, short a_Events, void * a_Self) { - auto self = reinterpret_cast(a_Self); + auto self = static_cast(a_Self); ASSERT(self != nullptr); self->m_StartupEvent.Set(); } diff --git a/src/OSSupport/ServerHandleImpl.cpp b/src/OSSupport/ServerHandleImpl.cpp index d1443757a..562b2f902 100644 --- a/src/OSSupport/ServerHandleImpl.cpp +++ b/src/OSSupport/ServerHandleImpl.cpp @@ -284,7 +284,7 @@ bool cServerHandleImpl::Listen(UInt16 a_Port) void cServerHandleImpl::Callback(evconnlistener * a_Listener, evutil_socket_t a_Socket, sockaddr * a_Addr, int a_Len, void * a_Self) { // Cast to true self: - cServerHandleImpl * Self = reinterpret_cast(a_Self); + cServerHandleImpl * Self = static_cast(a_Self); ASSERT(Self != nullptr); ASSERT(Self->m_SelfPtr != nullptr); -- cgit v1.2.3