From 7f42432f4205185f474733335c8a4eef26992454 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 28 Nov 2022 09:11:56 -0500 Subject: common/input: Pass ParamPackage by const reference in CreateDevice This was previously being passed by value, which was unnecessary and created more allocations than necessary. --- src/common/input.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common/input.h b/src/common/input.h index cb30b7254..4030ad2e5 100644 --- a/src/common/input.h +++ b/src/common/input.h @@ -417,12 +417,12 @@ std::unique_ptr CreateDeviceFromString(const std::string& param } /** - * Create an input device from given paramters. + * Create an input device from given parameters. * @tparam InputDeviceType the type of input devices to create - * @param A ParamPackage that contains all parameters for creating the device + * @param package A ParamPackage that contains all parameters for creating the device */ template -std::unique_ptr CreateDevice(const Common::ParamPackage package) { +std::unique_ptr CreateDevice(const ParamPackage& package) { const std::string engine = package.Get("engine", "null"); const auto& factory_list = Impl::FactoryList::list; const auto pair = factory_list.find(engine); -- cgit v1.2.3