From b560ade663e396dbd65c259d144ea0df6dc53eee Mon Sep 17 00:00:00 2001 From: Liam Date: Tue, 12 Dec 2023 19:02:43 -0500 Subject: renderer_vulkan: bound async presentation queue growth --- src/video_core/renderer_vulkan/vk_present_manager.cpp | 13 ++++++++++--- src/video_core/renderer_vulkan/vk_present_manager.h | 2 ++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_present_manager.cpp b/src/video_core/renderer_vulkan/vk_present_manager.cpp index 8e4c74b5c..a59e2d2d1 100644 --- a/src/video_core/renderer_vulkan/vk_present_manager.cpp +++ b/src/video_core/renderer_vulkan/vk_present_manager.cpp @@ -102,8 +102,8 @@ PresentManager::PresentManager(const vk::Instance& instance_, memory_allocator{memory_allocator_}, scheduler{scheduler_}, swapchain{swapchain_}, surface{surface_}, blit_supported{CanBlitToSwapchain(device.GetPhysical(), swapchain.GetImageViewFormat())}, - use_present_thread{Settings::values.async_presentation.GetValue()}, - image_count{swapchain.GetImageCount()} { + use_present_thread{Settings::values.async_presentation.GetValue()} { + SetImageCount(); auto& dld = device.GetLogical(); cmdpool = dld.CreateCommandPool({ @@ -289,7 +289,14 @@ void PresentManager::PresentThread(std::stop_token token) { void PresentManager::RecreateSwapchain(Frame* frame) { swapchain.Create(*surface, frame->width, frame->height); - image_count = swapchain.GetImageCount(); + SetImageCount(); +} + +void PresentManager::SetImageCount() { + // We cannot have more than 5 images in flight at any given time. + // FRAMES_IN_FLIGHT is 7, and the cache TICKS_TO_DESTROY is 6. + // Mali drivers will give us 6. + image_count = std::min(swapchain.GetImageCount(), 5); } void PresentManager::CopyToSwapchain(Frame* frame) { diff --git a/src/video_core/renderer_vulkan/vk_present_manager.h b/src/video_core/renderer_vulkan/vk_present_manager.h index 337171a09..23ee61c8c 100644 --- a/src/video_core/renderer_vulkan/vk_present_manager.h +++ b/src/video_core/renderer_vulkan/vk_present_manager.h @@ -62,6 +62,8 @@ private: void RecreateSwapchain(Frame* frame); + void SetImageCount(); + private: const vk::Instance& instance; Core::Frontend::EmuWindow& render_window; -- cgit v1.2.3