From c19058659770fe4b235859aa4c617ae56947051d Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Sat, 9 Jan 2021 03:14:18 -0300 Subject: common/div_ceil: Return numerator type Fixes instances where DivCeil(u32, u64) would surprisingly return u64, instead of the more natural u32. --- src/common/div_ceil.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/common') diff --git a/src/common/div_ceil.h b/src/common/div_ceil.h index 6b2c48f91..95e1489a9 100644 --- a/src/common/div_ceil.h +++ b/src/common/div_ceil.h @@ -11,16 +11,16 @@ namespace Common { /// Ceiled integer division. template -requires std::is_integral_v&& std::is_unsigned_v[[nodiscard]] constexpr auto DivCeil( - N number, D divisor) { - return (static_cast(number) + divisor - 1) / divisor; +requires std::is_integral_v&& std::is_unsigned_v[[nodiscard]] constexpr N DivCeil(N number, + D divisor) { + return static_cast((static_cast(number) + divisor - 1) / divisor); } /// Ceiled integer division with logarithmic divisor in base 2 template -requires std::is_integral_v&& std::is_unsigned_v[[nodiscard]] constexpr auto DivCeilLog2( +requires std::is_integral_v&& std::is_unsigned_v[[nodiscard]] constexpr N DivCeilLog2( N value, D alignment_log2) { - return (static_cast(value) + (D(1) << alignment_log2) - 1) >> alignment_log2; + return static_cast((static_cast(value) + (D(1) << alignment_log2) - 1) >> alignment_log2); } } // namespace Common -- cgit v1.2.3