From 9f3641755e9a49c5869582f4be4a45a93c4ab247 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 3 May 2018 07:53:05 -0400 Subject: core_timing: Don't include the log header in core timing's header Avoids propagating logging macros and facilities to files that may not need them. This also allows hiding an internal constant. --- src/core/core_timing.h | 51 ++++---------------------------------------------- 1 file changed, 4 insertions(+), 47 deletions(-) (limited to 'src/core/core_timing.h') diff --git a/src/core/core_timing.h b/src/core/core_timing.h index 9d3c1d05c..dc31124a8 100644 --- a/src/core/core_timing.h +++ b/src/core/core_timing.h @@ -18,17 +18,14 @@ */ #include -#include #include #include "common/common_types.h" -#include "common/logging/log.h" namespace CoreTiming { // The below clock rate is based on Switch's clockspeed being widely known as 1.020GHz // The exact value used is of course unverified. constexpr u64 BASE_CLOCK_RATE = 1019215872; // Switch clock speed is 1020MHz un/docked -constexpr u64 MAX_VALUE_TO_MULTIPLY = std::numeric_limits::max() / BASE_CLOCK_RATE; inline s64 msToCycles(int ms) { // since ms is int there is no way to overflow @@ -51,29 +48,9 @@ inline s64 usToCycles(int us) { return (BASE_CLOCK_RATE * static_cast(us) / 1000000); } -inline s64 usToCycles(s64 us) { - if (us / 1000000 > MAX_VALUE_TO_MULTIPLY) { - NGLOG_ERROR(Core_Timing, "Integer overflow, use max value"); - return std::numeric_limits::max(); - } - if (us > MAX_VALUE_TO_MULTIPLY) { - NGLOG_DEBUG(Core_Timing, "Time very big, do rounding"); - return BASE_CLOCK_RATE * (us / 1000000); - } - return (BASE_CLOCK_RATE * us) / 1000000; -} +s64 usToCycles(s64 us); -inline s64 usToCycles(u64 us) { - if (us / 1000000 > MAX_VALUE_TO_MULTIPLY) { - NGLOG_ERROR(Core_Timing, "Integer overflow, use max value"); - return std::numeric_limits::max(); - } - if (us > MAX_VALUE_TO_MULTIPLY) { - NGLOG_DEBUG(Core_Timing, "Time very big, do rounding"); - return BASE_CLOCK_RATE * static_cast(us / 1000000); - } - return (BASE_CLOCK_RATE * static_cast(us)) / 1000000; -} +s64 usToCycles(u64 us); inline s64 nsToCycles(float ns) { return static_cast(BASE_CLOCK_RATE * (0.000000001f) * ns); @@ -83,29 +60,9 @@ inline s64 nsToCycles(int ns) { return BASE_CLOCK_RATE * static_cast(ns) / 1000000000; } -inline s64 nsToCycles(s64 ns) { - if (ns / 1000000000 > MAX_VALUE_TO_MULTIPLY) { - NGLOG_ERROR(Core_Timing, "Integer overflow, use max value"); - return std::numeric_limits::max(); - } - if (ns > MAX_VALUE_TO_MULTIPLY) { - NGLOG_DEBUG(Core_Timing, "Time very big, do rounding"); - return BASE_CLOCK_RATE * (ns / 1000000000); - } - return (BASE_CLOCK_RATE * ns) / 1000000000; -} +s64 nsToCycles(s64 ns); -inline s64 nsToCycles(u64 ns) { - if (ns / 1000000000 > MAX_VALUE_TO_MULTIPLY) { - NGLOG_ERROR(Core_Timing, "Integer overflow, use max value"); - return std::numeric_limits::max(); - } - if (ns > MAX_VALUE_TO_MULTIPLY) { - NGLOG_DEBUG(Core_Timing, "Time very big, do rounding"); - return BASE_CLOCK_RATE * (static_cast(ns) / 1000000000); - } - return (BASE_CLOCK_RATE * static_cast(ns)) / 1000000000; -} +s64 nsToCycles(u64 ns); inline u64 cyclesToNs(s64 cycles) { return cycles * 1000000000 / BASE_CLOCK_RATE; -- cgit v1.2.3