From 6daebaaa5798ec7e104ac7a2221b1310a0ba0116 Mon Sep 17 00:00:00 2001 From: James Rowe Date: Sat, 14 Jul 2018 11:57:13 -0600 Subject: Logging: Don't lock the queue for the duration of the write --- src/common/logging/backend.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index 242914c6a..5313b8510 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -83,8 +83,10 @@ private: } }; while (true) { - std::unique_lock lock(message_mutex); - message_cv.wait(lock, [&] { return !running || message_queue.Pop(entry); }); + { + std::unique_lock lock(message_mutex); + message_cv.wait(lock, [&] { return !running || message_queue.Pop(entry); }); + } if (!running) { break; } @@ -282,4 +284,4 @@ void FmtLogMessageImpl(Class log_class, Level log_level, const char* filename, Impl::Instance().PushEntry(std::move(entry)); } -} // namespace Log \ No newline at end of file +} // namespace Log -- cgit v1.2.3