From d0082de82a094c98a5ef8907583415daef91604a Mon Sep 17 00:00:00 2001 From: Fernando Sahmkow Date: Tue, 16 Apr 2019 15:45:24 -0400 Subject: Implement IsBlockContinous This detects when a GPU Memory Block is not continous within host cpu memory. --- src/video_core/memory_manager.cpp | 8 ++++++++ src/video_core/memory_manager.h | 7 +++++-- 2 files changed, 13 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 18a8d2684..095a7e5a4 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp @@ -199,6 +199,14 @@ const u8* MemoryManager::GetPointer(GPUVAddr addr) const { return {}; } +bool MemoryManager::IsBlockContinous(const GPUVAddr start, const std::size_t size) { + const GPUVAddr end = start + size; + const auto host_ptr_start = reinterpret_cast(GetPointer(start)); + const auto host_ptr_end = reinterpret_cast(GetPointer(end)); + const std::size_t range = static_cast(host_ptr_end - host_ptr_start); + return range == size; +} + void MemoryManager::ReadBlock(GPUVAddr src_addr, void* dest_buffer, const std::size_t size) const { std::size_t remaining_size{size}; std::size_t page_index{src_addr >> page_bits}; diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index 017b051cf..e4f0c4bd6 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h @@ -65,7 +65,10 @@ public: u8* GetPointer(GPUVAddr addr); const u8* GetPointer(GPUVAddr addr) const; - /* + // Returns true if the block is continous in host memory, false otherwise + bool IsBlockContinous(const GPUVAddr start, const std::size_t size); + + /** * ReadBlock and WriteBlock are full read and write operations over virtual * GPU Memory. It's important to use these when GPU memory may not be continous * in the Host Memory counterpart. Note: This functions cause Host GPU Memory @@ -75,7 +78,7 @@ public: void WriteBlock(GPUVAddr dest_addr, const void* src_buffer, const std::size_t size); void CopyBlock(GPUVAddr dest_addr, GPUVAddr src_addr, const std::size_t size); - /* + /** * ReadBlockUnsafe and WriteBlockUnsafe are special versions of ReadBlock and * WriteBlock respectively. In this versions, no flushing or invalidation is actually * done and their performance is similar to a memcpy. This functions can be used -- cgit v1.2.3