summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDees_Troy <dees_troy@teamw.in>2013-03-11 21:41:08 +0100
committerGerrit Code Review <gerrit@5.9.244.119>2013-03-11 21:41:08 +0100
commit5a1ef678e74b20b53179df1e20ebe82458d96db6 (patch)
treee294a5ad534de0b93a88a7755482c65e4f886f6e
parentUpdate exfat to newest commits (diff)
parentRemove mutex from file seselector (diff)
downloadandroid_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar.gz
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar.bz2
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar.lz
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar.xz
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.tar.zst
android_bootable_recovery-5a1ef678e74b20b53179df1e20ebe82458d96db6.zip
Diffstat (limited to '')
-rw-r--r--gui/fileselector.cpp16
-rw-r--r--gui/objects.hpp1
2 files changed, 4 insertions, 13 deletions
diff --git a/gui/fileselector.cpp b/gui/fileselector.cpp
index 37eeed2ca..8b5804494 100644
--- a/gui/fileselector.cpp
+++ b/gui/fileselector.cpp
@@ -391,20 +391,14 @@ int GUIFileSelector::Render(void)
}
// Update the file list if needed
- pthread_mutex_lock(&updateFileListmutex);
if (updateFileList) {
- pthread_mutex_unlock(&updateFileListmutex);
string value;
DataManager::GetValue(mPathVar, value);
if (GetFileList(value) == 0) {
- pthread_mutex_lock(&updateFileListmutex);
updateFileList = false;
- pthread_mutex_unlock(&updateFileListmutex);
} else {
return 0;
}
- } else {
- pthread_mutex_unlock(&updateFileListmutex);
}
// This tells us how many lines we can actually render
@@ -562,11 +556,9 @@ int GUIFileSelector::Render(void)
}
// If a change came in during the render then we need to do another redraw so leave mUpdate alone if updateFileList is true.
- pthread_mutex_lock(&updateFileListmutex);
if (!updateFileList) {
mUpdate = 0;
}
- pthread_mutex_unlock(&updateFileListmutex);
return 0;
}
@@ -846,6 +838,10 @@ int GUIFileSelector::NotifyTouch(TOUCH_STATE state, int x, int y)
int GUIFileSelector::NotifyVarChange(std::string varName, std::string value)
{
+ if (varName.empty()) {
+ // Always clear the data variable so we know to use it
+ DataManager::SetValue(mVariable, "");
+ }
if (!mHeaderIsStatic) {
std::string newValue = gui_parse_text(mHeaderText);
if (mLastValue != newValue) {
@@ -861,9 +857,7 @@ int GUIFileSelector::NotifyVarChange(std::string varName, std::string value)
if (varName == mSortVariable) {
DataManager::GetValue(mSortVariable, mSortOrder);
}
- pthread_mutex_lock(&updateFileListmutex);
updateFileList = true;
- pthread_mutex_unlock(&updateFileListmutex);
mStart = 0;
scrollingY = 0;
scrollingSpeed = 0;
@@ -1004,9 +998,7 @@ void GUIFileSelector::SetPageFocus(int inFocus)
{
if (inFocus)
{
- pthread_mutex_lock(&updateFileListmutex);
updateFileList = true;
- pthread_mutex_unlock(&updateFileListmutex);
scrollingY = 0;
scrollingSpeed = 0;
mUpdate = 1;
diff --git a/gui/objects.hpp b/gui/objects.hpp
index 047b66b63..3a39fe565 100644
--- a/gui/objects.hpp
+++ b/gui/objects.hpp
@@ -496,7 +496,6 @@ protected:
COLOR mFontHighlightColor;
int startSelection;
bool updateFileList;
- pthread_mutex_t updateFileListmutex;
};
class GUIListBox : public RenderObject, public ActionObject