diff options
author | Tao Bao <tbao@google.com> | 2017-04-05 17:40:58 +0200 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2017-04-05 17:40:59 +0200 |
commit | 3cd630a5a8d5a19dda9429af5494f19625bc2fa0 (patch) | |
tree | 4ace1cad9d4d12c35e9c3cb69ee24060c7740e74 | |
parent | Merge "Boot control HAL based on the A/B headers." (diff) | |
parent | tests: Use get_bootloader_message_blk_device() to find /misc. (diff) | |
download | android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar.gz android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar.bz2 android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar.lz android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar.xz android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.tar.zst android_bootable_recovery-3cd630a5a8d5a19dda9429af5494f19625bc2fa0.zip |
-rw-r--r-- | tests/common/component_test_util.h | 43 | ||||
-rw-r--r-- | tests/component/bootloader_message_test.cpp | 5 | ||||
-rw-r--r-- | tests/component/uncrypt_test.cpp | 5 |
3 files changed, 4 insertions, 49 deletions
diff --git a/tests/common/component_test_util.h b/tests/common/component_test_util.h deleted file mode 100644 index 3fee32d62..000000000 --- a/tests/common/component_test_util.h +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agree to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef _COMPONENT_TEST_UTIL_H -#define _COMPONENT_TEST_UTIL_H - -#include <string> - -#include <android-base/properties.h> -#include <fs_mgr.h> - -// Check if the /misc entry exists in the fstab. -static bool parse_misc() { - std::unique_ptr<fstab, decltype(&fs_mgr_free_fstab)> fstab(fs_mgr_read_fstab_default(), - fs_mgr_free_fstab); - if (!fstab) { - GTEST_LOG_(INFO) << "Failed to read default fstab"; - return false; - } - - fstab_rec* record = fs_mgr_get_entry_for_mount_point(fstab.get(), "/misc"); - if (record == nullptr) { - GTEST_LOG_(INFO) << "Failed to find /misc in fstab."; - return false; - } - return true; -} - -#endif //_COMPONENT_TEST_UTIL_H - diff --git a/tests/component/bootloader_message_test.cpp b/tests/component/bootloader_message_test.cpp index 0357accfe..b38bc7134 100644 --- a/tests/component/bootloader_message_test.cpp +++ b/tests/component/bootloader_message_test.cpp @@ -21,14 +21,13 @@ #include <bootloader_message/bootloader_message.h> #include <gtest/gtest.h> -#include "common/component_test_util.h" - class BootloaderMessageTest : public ::testing::Test { protected: BootloaderMessageTest() : has_misc(true) {} virtual void SetUp() override { - has_misc = parse_misc(); + std::string err; + has_misc = !get_bootloader_message_blk_device(&err).empty(); } virtual void TearDown() override { diff --git a/tests/component/uncrypt_test.cpp b/tests/component/uncrypt_test.cpp index 5e057e129..3925236a5 100644 --- a/tests/component/uncrypt_test.cpp +++ b/tests/component/uncrypt_test.cpp @@ -30,8 +30,6 @@ #include <bootloader_message/bootloader_message.h> #include <gtest/gtest.h> -#include "common/component_test_util.h" - using namespace std::string_literals; static const std::string UNCRYPT_SOCKET = "/dev/socket/uncrypt"; @@ -65,7 +63,8 @@ class UncryptTest : public ::testing::Test { ASSERT_TRUE(success) << "uncrypt service is not available."; - has_misc = parse_misc(); + std::string err; + has_misc = !get_bootloader_message_blk_device(&err).empty(); } void SetupOrClearBcb(bool isSetup, const std::string& message, |