diff options
author | Tao Bao <tbao@google.com> | 2018-11-02 03:11:10 +0100 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-11-02 03:11:10 +0100 |
commit | 948790fa4c01c6f21005e09e85e24d3d66299de8 (patch) | |
tree | ab4b045819468d3ea82af956c27a1e2892260d45 | |
parent | Merge changes I69ce001a,I14514017,I8e67cda7 (diff) | |
parent | minui: Add GRSurface::Clone(). (diff) | |
download | android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar.gz android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar.bz2 android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar.lz android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar.xz android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.tar.zst android_bootable_recovery-948790fa4c01c6f21005e09e85e24d3d66299de8.zip |
-rw-r--r-- | minui/include/minui/minui.h | 4 | ||||
-rw-r--r-- | minui/resources.cpp | 10 | ||||
-rw-r--r-- | tests/unit/minui_test.cpp | 14 |
3 files changed, 25 insertions, 3 deletions
diff --git a/minui/include/minui/minui.h b/minui/include/minui/minui.h index d6881e9a0..0b499e621 100644 --- a/minui/include/minui/minui.h +++ b/minui/include/minui/minui.h @@ -40,6 +40,9 @@ class GRSurface { static std::unique_ptr<GRSurface> Create(int width, int height, int row_bytes, int pixel_bytes, size_t data_size); + // Clones the current GRSurface instance (i.e. an image). + std::unique_ptr<GRSurface> Clone() const; + virtual uint8_t* data() { return data_; } @@ -59,6 +62,7 @@ class GRSurface { private: uint8_t* data_{ nullptr }; + size_t data_size_; DISALLOW_COPY_AND_ASSIGN(GRSurface); }; diff --git a/minui/resources.cpp b/minui/resources.cpp index 9c9af0242..9027bc668 100644 --- a/minui/resources.cpp +++ b/minui/resources.cpp @@ -44,13 +44,19 @@ std::unique_ptr<GRSurface> GRSurface::Create(int width, int height, int row_byte static constexpr size_t kSurfaceDataAlignment = 8; // Cannot use std::make_unique to access non-public ctor. auto result = std::unique_ptr<GRSurface>(new GRSurface(width, height, row_bytes, pixel_bytes)); - size_t aligned_size = + result->data_size_ = (data_size + kSurfaceDataAlignment - 1) / kSurfaceDataAlignment * kSurfaceDataAlignment; - result->data_ = static_cast<uint8_t*>(aligned_alloc(kSurfaceDataAlignment, aligned_size)); + result->data_ = static_cast<uint8_t*>(aligned_alloc(kSurfaceDataAlignment, result->data_size_)); if (result->data_ == nullptr) return nullptr; return result; } +std::unique_ptr<GRSurface> GRSurface::Clone() const { + auto result = GRSurface::Create(width, height, row_bytes, pixel_bytes, data_size_); + memcpy(result->data_, data_, data_size_); + return result; +} + GRSurface::~GRSurface() { if (data_ != nullptr) { free(data_); diff --git a/tests/unit/minui_test.cpp b/tests/unit/minui_test.cpp index b188b5992..d68e5e3a1 100644 --- a/tests/unit/minui_test.cpp +++ b/tests/unit/minui_test.cpp @@ -15,8 +15,9 @@ */ #include <stdint.h> +#include <stdlib.h> -#include <memory> +#include <vector> #include <gtest/gtest.h> @@ -30,3 +31,14 @@ TEST(GRSurfaceTest, Create_aligned) { ASSERT_EQ(0, reinterpret_cast<uintptr_t>(surface->data()) % kSurfaceDataAlignment); } } + +TEST(GRSurfaceTest, Clone) { + static constexpr size_t kImageSize = 10 * 50; + auto image = GRSurface::Create(50, 10, 50, 1, kImageSize); + for (auto i = 0; i < kImageSize; i++) { + image->data()[i] = rand() % 128; + } + auto image_copy = image->Clone(); + ASSERT_EQ(std::vector(image->data(), image->data() + kImageSize), + std::vector(image_copy->data(), image_copy->data() + kImageSize)); +} |