summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2017-09-17 23:48:24 +0200
committerandroid-build-merger <android-build-merger@google.com>2017-09-17 23:48:24 +0200
commitf358a7d12b8e02b6df24924b7e2ee4896bcb9f0c (patch)
treec6b1c35ab3212b52fd48bbe258ca96e4eb24f943
parentImport translations. DO NOT MERGE (diff)
parentMerge "Fix the dangling pointer when setting up arguments of imgdiff" am: ca5a071307 (diff)
downloadandroid_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar.gz
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar.bz2
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar.lz
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar.xz
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.tar.zst
android_bootable_recovery-f358a7d12b8e02b6df24924b7e2ee4896bcb9f0c.zip
-rw-r--r--tests/component/imgdiff_test.cpp15
1 files changed, 9 insertions, 6 deletions
diff --git a/tests/component/imgdiff_test.cpp b/tests/component/imgdiff_test.cpp
index 3163a57cf..73516050b 100644
--- a/tests/component/imgdiff_test.cpp
+++ b/tests/component/imgdiff_test.cpp
@@ -779,9 +779,10 @@ TEST(ImgdiffTest, zip_mode_store_large_apk) {
// Compute patch.
TemporaryFile patch_file;
TemporaryDir debug_dir;
+ std::string debug_dir_arg = android::base::StringPrintf("--debug-dir=%s", debug_dir.path);
std::vector<const char*> args = {
- "imgdiff", "-z", "--block-limit=10", android::base::StringPrintf(
- "--debug-dir=%s", debug_dir.path).c_str(), src_file.path, tgt_file.path, patch_file.path,
+ "imgdiff", "-z", "--block-limit=10", debug_dir_arg.c_str(), src_file.path, tgt_file.path,
+ patch_file.path,
};
ASSERT_EQ(0, imgdiff(args.size(), args.data()));
@@ -901,9 +902,10 @@ TEST(ImgdiffTest, zip_mode_no_match_source) {
// Compute patch.
TemporaryFile patch_file;
TemporaryDir debug_dir;
+ std::string debug_dir_arg = android::base::StringPrintf("--debug-dir=%s", debug_dir.path);
std::vector<const char*> args = {
- "imgdiff", "-z", "--block-limit=10", android::base::StringPrintf(
- "--debug-dir=%s", debug_dir.path).c_str(), src_file.path, tgt_file.path, patch_file.path,
+ "imgdiff", "-z", "--block-limit=10", debug_dir_arg.c_str(), src_file.path, tgt_file.path,
+ patch_file.path,
};
ASSERT_EQ(0, imgdiff(args.size(), args.data()));
@@ -940,9 +942,10 @@ TEST(ImgdiffTest, zip_mode_large_enough_limit) {
// Compute patch with a limit of 20 blocks.
TemporaryFile patch_file;
TemporaryDir debug_dir;
+ std::string debug_dir_arg = android::base::StringPrintf("--debug-dir=%s", debug_dir.path);
std::vector<const char*> args = {
- "imgdiff", "-z", "--block-limit=20", android::base::StringPrintf(
- "--debug-dir=%s", debug_dir.path).c_str(), src_file.path, tgt_file.path, patch_file.path,
+ "imgdiff", "-z", "--block-limit=20", debug_dir_arg.c_str(), src_file.path, tgt_file.path,
+ patch_file.path,
};
ASSERT_EQ(0, imgdiff(args.size(), args.data()));