summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2017-01-18 23:34:18 +0100
committerandroid-build-merger <android-build-merger@google.com>2017-01-18 23:34:18 +0100
commitca50d7b66a187855d5ff53e95ec5286701f29d80 (patch)
tree7e1ccedcc9c9bab2038cd5e4bf88f2402554756d
parentDO NOT MERGE ANYWHERE init: move healthd to late-init am: 195ff7f79e -s ours (diff)
parentAdd a checker for signature boundary in verifier am: 54ea136fde am: 0a34b17c8b am: fb80b4f72d am: d3d5e54a45 am: 6ea9888d51 (diff)
downloadandroid_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar.gz
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar.bz2
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar.lz
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar.xz
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.tar.zst
android_bootable_recovery-ca50d7b66a187855d5ff53e95ec5286701f29d80.zip
-rw-r--r--verifier.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/verifier.cpp b/verifier.cpp
index 16cc7cf03..2d1b0e74f 100644
--- a/verifier.cpp
+++ b/verifier.cpp
@@ -146,6 +146,12 @@ int verify_file(unsigned char* addr, size_t length,
LOGI("comment is %zu bytes; signature %zu bytes from end\n",
comment_size, signature_start);
+ if (signature_start > comment_size) {
+ LOGE("signature start: %zu is larger than comment size: %zu\n", signature_start,
+ comment_size);
+ return VERIFY_FAILURE;
+ }
+
if (signature_start <= FOOTER_SIZE) {
LOGE("Signature start is in the footer");
return VERIFY_FAILURE;