diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2019-03-14 12:00:30 +0100 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-03-14 12:00:30 +0100 |
commit | 2e6fbfc31e225932fdb9ad7edab8762bf3ef3670 (patch) | |
tree | 5fff518c791b8a97932cb75eaaa38b3798b33cf6 /update_verifier | |
parent | Merge "update_verifier: Add some missing #include's." (diff) | |
parent | Update_verifier: Remove the support for legacy text format CareMap (diff) | |
download | android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar.gz android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar.bz2 android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar.lz android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar.xz android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.tar.zst android_bootable_recovery-2e6fbfc31e225932fdb9ad7edab8762bf3ef3670.zip |
Diffstat (limited to 'update_verifier')
-rw-r--r-- | update_verifier/include/update_verifier/update_verifier.h | 3 | ||||
-rw-r--r-- | update_verifier/update_verifier.cpp | 47 |
2 files changed, 3 insertions, 47 deletions
diff --git a/update_verifier/include/update_verifier/update_verifier.h b/update_verifier/include/update_verifier/update_verifier.h index b00890e82..4c64b1ea1 100644 --- a/update_verifier/include/update_verifier/update_verifier.h +++ b/update_verifier/include/update_verifier/update_verifier.h @@ -50,9 +50,6 @@ class UpdateVerifier { private: friend class UpdateVerifierTest; - // Parses the legacy care_map.txt in plain text format. - bool ParseCareMapPlainText(const std::string& content); - // Finds all the dm-enabled partitions, and returns a map of <partition_name, block_device>. std::map<std::string, std::string> FindDmPartitions(); diff --git a/update_verifier/update_verifier.cpp b/update_verifier/update_verifier.cpp index ce93a4675..0cf536ce6 100644 --- a/update_verifier/update_verifier.cpp +++ b/update_verifier/update_verifier.cpp @@ -71,6 +71,7 @@ using android::hardware::boot::V1_0::IBootControl; using android::hardware::boot::V1_0::BoolResult; using android::hardware::boot::V1_0::CommandResult; +// TODO(xunchang) remove the prefix and use a default path instead. constexpr const char* kDefaultCareMapPrefix = "/data/ota_package/care_map"; // Find directories in format of "/sys/block/dm-X". @@ -199,51 +200,13 @@ bool UpdateVerifier::VerifyPartitions() { return true; } -bool UpdateVerifier::ParseCareMapPlainText(const std::string& content) { - // care_map file has up to six lines, where every two lines make a pair. Within each pair, the - // first line has the partition name (e.g. "system"), while the second line holds the ranges of - // all the blocks to verify. - auto lines = android::base::Split(android::base::Trim(content), "\n"); - if (lines.size() != 2 && lines.size() != 4 && lines.size() != 6) { - LOG(WARNING) << "Invalid lines in care_map: found " << lines.size() - << " lines, expecting 2 or 4 or 6 lines."; - return false; - } - - for (size_t i = 0; i < lines.size(); i += 2) { - const std::string& partition_name = lines[i]; - const std::string& range_str = lines[i + 1]; - // We're seeing an N care_map.txt. Skip the verification since it's not compatible with O - // update_verifier (the last few metadata blocks can't be read via device mapper). - if (android::base::StartsWith(partition_name, "/dev/block/")) { - LOG(WARNING) << "Found legacy care_map.txt; skipped."; - return false; - } - - // For block range string, first integer 'count' equals 2 * total number of valid ranges, - // followed by 'count' number comma separated integers. Every two integers reprensent a - // block range with the first number included in range but second number not included. - // For example '4,64536,65343,74149,74150' represents: [64536,65343) and [74149,74150). - RangeSet ranges = RangeSet::Parse(range_str); - if (!ranges) { - LOG(WARNING) << "Error parsing RangeSet string " << range_str; - return false; - } - - partition_map_.emplace(partition_name, ranges); - } - - return true; -} - bool UpdateVerifier::ParseCareMap() { partition_map_.clear(); std::string care_map_name = care_map_prefix_ + ".pb"; if (access(care_map_name.c_str(), R_OK) == -1) { - LOG(WARNING) << care_map_name - << " doesn't exist, falling back to read the care_map in plain text format."; - care_map_name = care_map_prefix_ + ".txt"; + LOG(ERROR) << care_map_name << " doesn't exist"; + return false; } android::base::unique_fd care_map_fd(TEMP_FAILURE_RETRY(open(care_map_name.c_str(), O_RDONLY))); @@ -266,10 +229,6 @@ bool UpdateVerifier::ParseCareMap() { return false; } - if (android::base::EndsWith(care_map_name, ".txt")) { - return ParseCareMapPlainText(file_content); - } - recovery_update_verifier::CareMap care_map; if (!care_map.ParseFromString(file_content)) { LOG(WARNING) << "Failed to parse " << care_map_name << " in protobuf format."; |