diff options
| -rw-r--r-- | minui/minui.h | 2 | ||||
| -rw-r--r-- | minui/resources.cpp | 21 | ||||
| -rw-r--r-- | tests/Android.mk | 6 | ||||
| -rw-r--r-- | tests/unit/locale_test.cpp | 29 | ||||
| -rw-r--r-- | tools/recovery_l10n/res/values/strings.xml | 8 | ||||
| -rw-r--r-- | verifier.cpp | 8 |
6 files changed, 52 insertions, 22 deletions
diff --git a/minui/minui.h b/minui/minui.h index e3bc00548..fb0bbe10c 100644 --- a/minui/minui.h +++ b/minui/minui.h @@ -84,6 +84,8 @@ int ev_get_epollfd(); // Resources // +bool matches_locale(const char* prefix, const char* locale); + // res_create_*_surface() functions return 0 if no error, else // negative. // diff --git a/minui/resources.cpp b/minui/resources.cpp index 5d69ea2d0..40d3c2c88 100644 --- a/minui/resources.cpp +++ b/minui/resources.cpp @@ -370,21 +370,16 @@ int res_create_alpha_surface(const char* name, GRSurface** pSurface) { return result; } -static int matches_locale(const char* loc, const char* locale) { - if (locale == NULL) return 0; +// This function tests if a locale string stored in PNG (prefix) matches +// the locale string provided by the system (locale). +bool matches_locale(const char* prefix, const char* locale) { + if (locale == NULL) return false; - if (strcmp(loc, locale) == 0) return 1; + // Return true if the whole string of prefix matches the top part of + // locale. For instance, prefix == "en" matches locale == "en_US"; + // and prefix == "zh_CN" matches locale == "zh_CN_#Hans". - // if loc does *not* have an underscore, and it matches the start - // of locale, and the next character in locale *is* an underscore, - // that's a match. For instance, loc == "en" matches locale == - // "en_US". - - int i; - for (i = 0; loc[i] != 0 && loc[i] != '_'; ++i); - if (loc[i] == '_') return 0; - - return (strncmp(locale, loc, i) == 0 && locale[i] == '_'); + return (strncmp(prefix, locale, strlen(prefix)) == 0); } int res_create_localized_alpha_surface(const char* name, diff --git a/tests/Android.mk b/tests/Android.mk index 2da19d7a6..a66991b21 100644 --- a/tests/Android.mk +++ b/tests/Android.mk @@ -21,9 +21,13 @@ include $(CLEAR_VARS) LOCAL_CLANG := true LOCAL_MODULE := recovery_unit_test LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/Android.mk -LOCAL_STATIC_LIBRARIES := libverifier +LOCAL_STATIC_LIBRARIES := \ + libverifier \ + libminui + LOCAL_SRC_FILES := unit/asn1_decoder_test.cpp LOCAL_SRC_FILES += unit/recovery_test.cpp +LOCAL_SRC_FILES += unit/locale_test.cpp LOCAL_C_INCLUDES := bootable/recovery LOCAL_SHARED_LIBRARIES := liblog include $(BUILD_NATIVE_TEST) diff --git a/tests/unit/locale_test.cpp b/tests/unit/locale_test.cpp new file mode 100644 index 000000000..0e515f8c1 --- /dev/null +++ b/tests/unit/locale_test.cpp @@ -0,0 +1,29 @@ +/* + * Copyright (C) 2016 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <gtest/gtest.h> + +#include "minui/minui.h" + +TEST(LocaleTest, Misc) { + EXPECT_TRUE(matches_locale("zh_CN", "zh_CN_#Hans")); + EXPECT_TRUE(matches_locale("zh", "zh_CN_#Hans")); + EXPECT_FALSE(matches_locale("zh_HK", "zh_CN_#Hans")); + EXPECT_TRUE(matches_locale("en_GB", "en_GB")); + EXPECT_TRUE(matches_locale("en", "en_GB")); + EXPECT_FALSE(matches_locale("en_GB", "en")); + EXPECT_FALSE(matches_locale("en_GB", "en_US")); +} diff --git a/tools/recovery_l10n/res/values/strings.xml b/tools/recovery_l10n/res/values/strings.xml index f6193ab17..971e038d3 100644 --- a/tools/recovery_l10n/res/values/strings.xml +++ b/tools/recovery_l10n/res/values/strings.xml @@ -13,18 +13,18 @@ <!-- Displayed on the screen beneath the animated android while the system is installing an update. [CHAR LIMIT=60] --> - <string name="recovery_installing">Installing system update\u2026</string> + <string name="recovery_installing">Installing system update</string> <!-- Displayed on the screen beneath the animated android while the system is erasing a partition (either a data wipe aka "factory reset", or a cache wipe). [CHAR LIMIT=60] --> - <string name="recovery_erasing">Erasing\u2026</string> + <string name="recovery_erasing">Erasing</string> <!-- Displayed on the screen when the user has gotten into recovery mode without a command to run. Will not normally happen, but users (especially developers) may boot into recovery mode manually via special key combinations. [CHAR LIMIT=60] --> - <string name="recovery_no_command">No command.</string> + <string name="recovery_no_command">No command</string> <!-- Displayed on the triangle-! screen when a system update installation or data wipe procedure encounters an error. [CHAR @@ -33,6 +33,6 @@ <!-- Displayed on the screen beneath the animation while the system is installing a security update. [CHAR LIMIT=60] --> - <string name="recovery_installing_security">Installing security update\u2026</string> + <string name="recovery_installing_security">Installing security update</string> </resources> diff --git a/verifier.cpp b/verifier.cpp index 4004b0228..f5299b4a2 100644 --- a/verifier.cpp +++ b/verifier.cpp @@ -206,10 +206,10 @@ int verify_file(unsigned char* addr, size_t length, double frac = -1.0; size_t so_far = 0; while (so_far < signed_len) { - // On a Nexus 9, experiment didn't show any performance improvement with - // larger sizes past 1MiB, and they reduce the granularity of the progress - // bar. http://b/28135231. - size_t size = std::min(signed_len - so_far, 1 * MiB); + // On a Nexus 5X, experiment showed 16MiB beat 1MiB by 6% faster for a + // 1196MiB full OTA and 60% for an 89MiB incremental OTA. + // http://b/28135231. + size_t size = std::min(signed_len - so_far, 16 * MiB); if (need_sha1) SHA1_Update(&sha1_ctx, addr + so_far, size); if (need_sha256) SHA256_Update(&sha256_ctx, addr + so_far, size); |