diff options
Diffstat (limited to 'src/core/debugger')
-rw-r--r-- | src/core/debugger/debugger.cpp | 2 | ||||
-rw-r--r-- | src/core/debugger/debugger_interface.h | 4 | ||||
-rw-r--r-- | src/core/debugger/gdbstub.cpp | 4 | ||||
-rw-r--r-- | src/core/debugger/gdbstub.h | 2 |
4 files changed, 8 insertions, 4 deletions
diff --git a/src/core/debugger/debugger.cpp b/src/core/debugger/debugger.cpp index a73f2279d..68ab33e46 100644 --- a/src/core/debugger/debugger.cpp +++ b/src/core/debugger/debugger.cpp @@ -51,7 +51,7 @@ public: InitializeServer(port); } - ~DebuggerImpl() { + ~DebuggerImpl() override { ShutdownServer(); } diff --git a/src/core/debugger/debugger_interface.h b/src/core/debugger/debugger_interface.h index 6ae3dc091..35ba0bc61 100644 --- a/src/core/debugger/debugger_interface.h +++ b/src/core/debugger/debugger_interface.h @@ -25,6 +25,8 @@ enum class DebuggerAction { class DebuggerBackend { public: + virtual ~DebuggerBackend() = default; + /** * Can be invoked from a callback to synchronously wait for more data. * Will return as soon as least one byte is received. Reads up to 4096 bytes. @@ -52,6 +54,8 @@ class DebuggerFrontend { public: explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {} + virtual ~DebuggerFrontend() = default; + /** * Called after the client has successfully connected to the port. */ diff --git a/src/core/debugger/gdbstub.cpp b/src/core/debugger/gdbstub.cpp index 44ebbe3e0..0c36069a6 100644 --- a/src/core/debugger/gdbstub.cpp +++ b/src/core/debugger/gdbstub.cpp @@ -439,8 +439,8 @@ std::optional<std::string> GDBStub::DetachCommand() { } u8 GDBStub::CalculateChecksum(std::string_view data) { - return static_cast<u8>( - std::accumulate(data.begin(), data.end(), u8{0}, [](u8 lhs, u8 rhs) { return lhs + rhs; })); + return std::accumulate(data.begin(), data.end(), u8{0}, + [](u8 lhs, u8 rhs) { return static_cast<u8>(lhs + rhs); }); } void GDBStub::SendReply(std::string_view data) { diff --git a/src/core/debugger/gdbstub.h b/src/core/debugger/gdbstub.h index 6f8ac2263..aa1f7de6c 100644 --- a/src/core/debugger/gdbstub.h +++ b/src/core/debugger/gdbstub.h @@ -19,7 +19,7 @@ class System; class GDBStub : public DebuggerFrontend { public: explicit GDBStub(DebuggerBackend& backend, Core::System& system); - ~GDBStub(); + ~GDBStub() override; void Connected() override; void Stopped(Kernel::KThread* thread) override; |