From ed8072b48bf6eacb0eea161f87746086401b5c08 Mon Sep 17 00:00:00 2001 From: Dwayne Slater Date: Sat, 20 Feb 2016 19:03:14 -0500 Subject: Fix out of bounds array access when loading a component >= 12 --- src/video_core/command_processor.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/video_core/command_processor.cpp b/src/video_core/command_processor.cpp index 51abeeaba..9d8c86236 100644 --- a/src/video_core/command_processor.cpp +++ b/src/video_core/command_processor.cpp @@ -157,8 +157,11 @@ static void WritePicaReg(u32 id, u32 value, u32 mask) { // TODO: What happens if a loader overwrites a previous one's data? for (unsigned component = 0; component < loader_config.component_count; ++component) { - if (component >= 12) + if (component >= 12) { LOG_ERROR(HW_GPU, "Overflow in the vertex attribute loader %u trying to load component %u", loader, component); + continue; + } + u32 attribute_index = loader_config.GetComponent(component); if (attribute_index < 12) { vertex_attribute_sources[attribute_index] = load_address; -- cgit v1.2.3