summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2017-08-29 19:34:28 +0200
committerandroid-build-merger <android-build-merger@google.com>2017-08-29 19:34:28 +0200
commit44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91 (patch)
treee2b79f11b73bdb1b593076a25025b6c355a64559 /tests
parentMerge "Add libasyncio." (diff)
parentMerge "Turn on -Wall for recovery modules" (diff)
downloadandroid_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar.gz
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar.bz2
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar.lz
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar.xz
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.tar.zst
android_bootable_recovery-44d0b008c6b2c0a9f4ededcb58aa4d27f8adec91.zip
Diffstat (limited to 'tests')
-rw-r--r--tests/Android.mk7
-rw-r--r--tests/component/applypatch_test.cpp8
2 files changed, 4 insertions, 11 deletions
diff --git a/tests/Android.mk b/tests/Android.mk
index f2497b8b3..748d9c87b 100644
--- a/tests/Android.mk
+++ b/tests/Android.mk
@@ -18,7 +18,7 @@ LOCAL_PATH := $(call my-dir)
# Unit tests
include $(CLEAR_VARS)
-LOCAL_CFLAGS := -Werror
+LOCAL_CFLAGS := -Wall -Werror
LOCAL_MODULE := recovery_unit_test
LOCAL_COMPATIBILITY_SUITE := device-tests
LOCAL_STATIC_LIBRARIES := \
@@ -46,7 +46,7 @@ include $(BUILD_NATIVE_TEST)
# Manual tests
include $(CLEAR_VARS)
-LOCAL_CFLAGS := -Werror
+LOCAL_CFLAGS := -Wall -Werror
LOCAL_MODULE := recovery_manual_test
LOCAL_STATIC_LIBRARIES := \
libminui \
@@ -81,6 +81,7 @@ include $(BUILD_NATIVE_TEST)
# Component tests
include $(CLEAR_VARS)
LOCAL_CFLAGS := \
+ -Wall \
-Werror \
-D_FILE_OFFSET_BITS=64
@@ -191,7 +192,7 @@ include $(BUILD_NATIVE_TEST)
# Host tests
include $(CLEAR_VARS)
-LOCAL_CFLAGS := -Werror
+LOCAL_CFLAGS := -Wall -Werror
LOCAL_MODULE := recovery_host_test
LOCAL_MODULE_HOST_OS := linux
LOCAL_C_INCLUDES := bootable/recovery
diff --git a/tests/component/applypatch_test.cpp b/tests/component/applypatch_test.cpp
index 016fed9b1..42542898b 100644
--- a/tests/component/applypatch_test.cpp
+++ b/tests/component/applypatch_test.cpp
@@ -61,14 +61,6 @@ static void mangle_file(const std::string& fname) {
ASSERT_TRUE(android::base::WriteStringToFile(content, fname));
}
-static bool file_cmp(const std::string& f1, const std::string& f2) {
- std::string c1;
- android::base::ReadFileToString(f1, &c1);
- std::string c2;
- android::base::ReadFileToString(f2, &c2);
- return c1 == c2;
-}
-
class ApplyPatchTest : public ::testing::Test {
public:
static void SetUpTestCase() {