diff options
author | Elliott Hughes <enh@google.com> | 2016-09-26 21:32:48 +0200 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2016-09-26 21:32:48 +0200 |
commit | cc02f9652f7994c835c7073d13b30f60ff1134af (patch) | |
tree | 034b34abded47d933f5e4f84b8f92936fb74bd47 /updater | |
parent | Merge "Check corruption when reading uncrypt_status file" (diff) | |
parent | Switch to <android-base/properties.h>. (diff) | |
download | android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar.gz android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar.bz2 android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar.lz android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar.xz android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.tar.zst android_bootable_recovery-cc02f9652f7994c835c7073d13b30f60ff1134af.zip |
Diffstat (limited to 'updater')
-rw-r--r-- | updater/install.cpp | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/updater/install.cpp b/updater/install.cpp index 4c4886d51..8c33c2bf3 100644 --- a/updater/install.cpp +++ b/updater/install.cpp @@ -37,6 +37,7 @@ #include <vector> #include <android-base/parseint.h> +#include <android-base/properties.h> #include <android-base/strings.h> #include <android-base/stringprintf.h> #include <selinux/label.h> @@ -46,7 +47,6 @@ #include "applypatch/applypatch.h" #include "cutils/android_reboot.h" #include "cutils/misc.h" -#include "cutils/properties.h" #include "edify/expr.h" #include "error_code.h" #include "minzip/DirUtil.h" @@ -906,11 +906,10 @@ Value* GetPropFn(const char* name, State* state, int argc, Expr* argv[]) { char* key = Evaluate(state, argv[0]); if (key == NULL) return NULL; - char value[PROPERTY_VALUE_MAX]; - property_get(key, value, ""); + std::string value = android::base::GetProperty(key, ""); free(key); - return StringValue(strdup(value)); + return StringValue(strdup(value.c_str())); } @@ -1301,9 +1300,8 @@ Value* RebootNowFn(const char* name, State* state, int argc, Expr* argv[]) { char* property; if (ReadArgs(state, argv, 2, &filename, &property) < 0) return NULL; - char buffer[80]; - // zero out the 'command' field of the bootloader message. + char buffer[80]; memset(buffer, 0, sizeof(((struct bootloader_message*)0)->command)); FILE* f = ota_fopen(filename, "r+b"); fseek(f, offsetof(struct bootloader_message, command), SEEK_SET); @@ -1311,12 +1309,9 @@ Value* RebootNowFn(const char* name, State* state, int argc, Expr* argv[]) { ota_fclose(f); free(filename); - strcpy(buffer, "reboot,"); - if (property != NULL) { - strncat(buffer, property, sizeof(buffer)-10); - } - - property_set(ANDROID_RB_PROPERTY, buffer); + std::string reboot_cmd = "reboot,"; + if (property != nullptr) reboot_cmd += property; + android::base::SetProperty(ANDROID_RB_PROPERTY, reboot_cmd); sleep(5); free(property); |