summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTiger Wang <ziwei.tiger@outlook.com>2020-07-29 19:51:39 +0200
committerTiger Wang <ziwei.tiger@outlook.com>2020-08-02 16:52:06 +0200
commitb205d233bdd34e26d6bde31879c10b6cabf820b6 (patch)
tree29919857422e924139e4345ebe029f06740e043a
parentRemove unused block tick related cChunk functions (diff)
downloadcuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar.gz
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar.bz2
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar.lz
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar.xz
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.tar.zst
cuberite-b205d233bdd34e26d6bde31879c10b6cabf820b6.zip
Diffstat (limited to '')
-rw-r--r--src/Chunk.cpp18
-rw-r--r--src/Chunk.h2
2 files changed, 9 insertions, 11 deletions
diff --git a/src/Chunk.cpp b/src/Chunk.cpp
index e4a4dd661..2140bf7f1 100644
--- a/src/Chunk.cpp
+++ b/src/Chunk.cpp
@@ -812,23 +812,21 @@ void cChunk::BroadcastPendingBlockChanges(void)
void cChunk::CheckBlocks()
{
- if (m_ToTickBlocks.empty())
- {
- return;
- }
- std::vector<Vector3i> ToTickBlocks;
- std::swap(m_ToTickBlocks, ToTickBlocks);
-
cChunkInterface ChunkInterface(m_World->GetChunkMap());
cBlockInServerPluginInterface PluginInterface(*m_World);
- for (std::vector<Vector3i>::const_iterator itr = ToTickBlocks.begin(), end = ToTickBlocks.end(); itr != end; ++itr)
+ // Process a limited number of blocks since cBlockHandler::Check may queue more to tick
+ auto Count = m_ToTickBlocks.size();
+
+ while (Count != 0)
{
- Vector3i Pos = (*itr);
+ Vector3i Pos = m_ToTickBlocks.front();
+ m_ToTickBlocks.pop();
+ Count--;
cBlockHandler * Handler = BlockHandler(GetBlock(Pos));
Handler->Check(ChunkInterface, PluginInterface, Pos, *this);
- } // for itr - ToTickBlocks[]
+ }
}
diff --git a/src/Chunk.h b/src/Chunk.h
index 0965f1997..7e09ce8b6 100644
--- a/src/Chunk.h
+++ b/src/Chunk.h
@@ -594,7 +594,7 @@ private:
bool m_IsSaving; // True if the chunk is being saved
bool m_HasLoadFailed; // True if chunk failed to load and hasn't been generated yet since then
- std::vector<Vector3i> m_ToTickBlocks;
+ std::queue<Vector3i> m_ToTickBlocks;
sSetBlockVector m_PendingSendBlocks; ///< Blocks that have changed and need to be sent to all clients
// A critical section is not needed, because all chunk access is protected by its parent ChunkMap's csLayers