diff options
author | Mattes D <github@xoft.cz> | 2015-09-16 09:12:56 +0200 |
---|---|---|
committer | Mattes D <github@xoft.cz> | 2015-09-16 09:12:56 +0200 |
commit | d041057da239d6dca02306849bd62973f3a51c62 (patch) | |
tree | 82d3aaa2905d360779ea472bc3baf91f8539758b /src/Logger.cpp | |
parent | Merge pull request #2473 from cuberite/APIDumpRename (diff) | |
parent | Increase robustness of the logging subsystem (diff) | |
download | cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar.gz cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar.bz2 cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar.lz cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar.xz cuberite-d041057da239d6dca02306849bd62973f3a51c62.tar.zst cuberite-d041057da239d6dca02306849bd62973f3a51c62.zip |
Diffstat (limited to 'src/Logger.cpp')
-rw-r--r-- | src/Logger.cpp | 24 |
1 files changed, 19 insertions, 5 deletions
diff --git a/src/Logger.cpp b/src/Logger.cpp index 292622a46..60f5a88d2 100644 --- a/src/Logger.cpp +++ b/src/Logger.cpp @@ -1,5 +1,6 @@ #include "Globals.h" // NOTE: MSVC stupidness requires this to be the same across all modules +#include "Logger.h" #include "OSSupport/IsThread.h" #ifdef _WIN32 @@ -73,10 +74,14 @@ void cLogger::Log(const char * a_Format, eLogLevel a_LogLevel, va_list a_ArgList -void cLogger::AttachListener(cListener * a_Listener) +cLogger::cAttachment cLogger::AttachListener(std::unique_ptr<cListener> a_Listener) { - cCSLock Lock(m_CriticalSection); - m_LogListeners.push_back(a_Listener); + auto nonOwning = a_Listener.get(); + { + cCSLock Lock(m_CriticalSection); + m_LogListeners.push_back(std::move(a_Listener)); + } + return cAttachment{nonOwning}; } @@ -86,7 +91,16 @@ void cLogger::AttachListener(cListener * a_Listener) void cLogger::DetachListener(cListener * a_Listener) { cCSLock Lock(m_CriticalSection); - m_LogListeners.erase(std::remove(m_LogListeners.begin(), m_LogListeners.end(), a_Listener)); + m_LogListeners.erase( + std::remove_if( + m_LogListeners.begin(), + m_LogListeners.end(), + [=](std::unique_ptr<cListener> & a_OtherListener) -> bool + { + return a_OtherListener.get() == a_Listener; + } + ) + ); } @@ -120,7 +134,7 @@ void LOGINFO(const char * a_Format, ...) -void LOGWARN(const char * a_Format, ...) +void LOGWARNING(const char * a_Format, ...) { va_list argList; va_start(argList, a_Format); |