summaryrefslogtreecommitdiffstats
path: root/src/ByteBuffer.cpp (unfollow)
Commit message (Collapse)AuthorFilesLines
2 daysOverhaul endian handling in ByteBuffer and FastNBT (#5543)Ash1-38/+40
* Overhaul endian handling in ByteBuffer and FastNBT Rather than juggling "swapped" and "unswapped" versions of integers, different library functions, #defines, etc., simply always read everything byte-by-byte. This works regardless of host CPU endian, got optimised down to either a normal load or a byteswap on every compiler I tested - only 1 instruction on most CPU architectures. This commit introduces a "Bytes" array type to keep endian-sensitive data seperate from host data, alongside the needed C++ template machinery for it to work seamlessly. This approach is a little bit safer as well since you get length- and type-checking for most callsites. * Remove remaining references to old-style endianness conversion, remove functions themselves. --------- Co-authored-by: Alexander Harkness <me@bearbin.net>
2022-11-08Protocol: Use correct calculation for delta movements (#5455)Tiger Wang1-0/+18
* Protocol: Use correct calculation for delta movements
2022-06-02Remove redundant initialisationsTiger Wang1-1/+1
The static buffers here are immediately passed in to be overwritten.
2022-04-20Updated protocol functions to Vector3xx12xx12x1-0/+18
also added support in included functions
2022-04-12fix various compiler warnings (and some unwanted case statement fallthroughs)hle01-1/+1
2022-01-16ByteBuffer: fully defined Position handlingTiger Wang1-12/+12
Cast input ints into unsigned to make them 2s complement guaranā˜•d.
2022-01-14Fix WriteXZYPosition64 and add testsBond_0091-1/+1
2022-01-13Fix compilation with Clang 13.0.0Bond_0091-3/+7
Clang 13 changes: * `-Wreserved-identifier` and `-Wunused-but-set-variable` got added * the `-Wreturn-std-move-in-c++11` option was removed Builds still fail when native optimizations are enabled
2021-03-05Prepare ChunkData for BlockState storage (#5105)Tiger Wang1-0/+28
* Rename ChunkData Creatable test * Add missing Y-check in RedstoneWireHandler * Remove ChunkDef.h dependency in Scoreboard * Prepare ChunkData for BlockState storage + Split chunk block, meta, block & sky light storage + Load the height map from disk - Reduce duplicated code in ChunkData - Remove saving MCSBiomes, there aren't any - Remove the allocation pool, ref #4315, #3864 * fixed build * fixed test * fixed the debug compile Co-authored-by: 12xx12 <44411062+12xx12@users.noreply.github.com>
2021-01-26Fix debug macro situation (#5114)Tiger Wang1-1/+1
Use the standard NDEBUG.
2021-01-11zlib -> libdeflate (#5085)Tiger Wang1-11/+26
+ Use libdeflate + Use std::byte * Fix passing temporary to string_view + Emulate make_unique_for_overwrite
2020-07-261.14 connection supportTiger Wang1-3/+43
2019-08-11Fix building with clang 8.0 (#4346)Bond-0091-2/+2
2018-07-26CheckBasicStyle: Check number of empty lines between functions (#4267)peterbell101-1/+0
Add check for number of empty lines between functions and fix the corresponding failures
2018-05-02Prefer static_cast to reinterpret_cast (#4223)peterbell101-3/+3
* Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there.
2017-08-25Add cUUID class (#3871)peterbell101-19/+5
2016-12-12Use CMake's Android generators to crosscompileTiger Wang1-37/+0
2016-10-12Spectators added (#2852)bibo381-0/+33
2016-08-04Fixed RasPi builds of unit tests.Mattes D1-1/+3
On RasPi with gcc 4.8.2, the asserts wouldn't compile when tests were enabled. Enforced the assumption that ASSERT code is generated only in Debug builds.
2016-07-20Fix endianness issue with ODROID-C2 Boards (#3268)Alexander Harkness1-1/+1
2016-06-18SelfTests: Moved ByteBuffer test to a separate project.Mattes D1-66/+0
2016-05-141.9 / 1.9.2 / 1.9.3 / 1.9.4 protocol support (#3135)Pokechu221-0/+18
* Semistable update to 15w31a I'm going through snapshots in a sequential order since it should make things easier, and since protocol version history is written. * Update to 15w34b protocol Also, fix an issue with the Entity Equipment packet from the past version. Clients are able to connect and do stuff! * Partially update to 15w35e Chunk data doesn't work, but the client joins. I'm waiting to do chunk data because chunk data has an incomplete format until 15w36d. * Add '/blk' debug command This command lets one see what block they are looking at, and makes figuring out what's supposed to be where in a highly broken chunk possible. * Fix CRLF normalization in CheckBasicStyle.lua Normally, this doesn't cause an issue, but when running from cygwin, it detects the CR as whitespace and creates thousands of violations for every single line. Lua, when run on windows, will normalize automatically, but when run via cygwin, it won't. The bug was simply that gsub was returning a replaced version, but not changing the parameter, so the replaced version was ignored. * Update to 15w40b This includes chunk serialization. Fully functional chunk serialization for 1.9. I'm not completely happy with the chunk serialization as-is (correct use of palettes would be great), but cuberite also doesn't skip sending empty chunks so this performance optimization should probably come later. The creation of a full buffer is suboptimal, but it's the easiest way to implement this code. * Write long-by-long rather than creating a buffer This is a bit faster and should be equivalent. However, the code still doesn't look too good. * Update to 15w41a protocol This includes the new set passengers packet, which works off of the ridden entity, not the rider. That means, among other things, that information about the previously ridden vehicle is needed when detaching. So a new method with that info was added. * Update to 15w45a * 15w51b protocol * Update to 1.9.0 protocol Closes #3067. There are still a few things that need to be worked out (picking up items, effects, particles, and most importantly inventory), but in general this should work. I'll make a few more changes tomorrow to get the rest of the protocol set up, along with 1.9.1/1.9.2 (which did make a few changes). Chunks, however, _are_ working, along with most other parts of the game (placing/breaking blocks). * Fix item pickup packet not working That was a silly mistake, but at least it was an easy one. * 1.9.2 protocol support * Fix version info found in server list ping Thus, the client reports that it can connect rather than saying that the server is out of date. This required creating separate classes for 1.9.1 and 1.9.2, unfortunately. * Fix build errors generated by clang These didn't happen in MSVC. * Add protocol19x.cpp and protocol19x.h to CMakeLists * Ignore warnings in protocol19x that are ignored in protocol18x * Document BLOCK_FACE and DIG_STATUS constants * Fix BLOCK_FACE links and add separate section for DIG_STATUS * Fix bat animation and object spawning The causes of both of these are explained in #3135, but the gist is that both were typos. * Implement Use Item packet This means that buckets, bows, fishing rods, and several other similar items now work when not looking at a block. * Handle DIG_STATUS_SWAP_ITEM_IN_HAND * Add support for spawn eggs and potions The items are transformed from the 1.9 version to the 1.8 version when reading and transformed back when sending. * Remove spammy potion debug logging * Fix wolf collar color metadata The wrong type was being used, causing several clientside issues (including the screen going black). * Fix 1.9 chunk sending in the nether The nether and the end don't send skylight. * Fix clang build errors * Fix water bottles becoming mundane potions This happened because the can become splash potion bit got set incorrectly. Water bottles and mundane potions are only differentiated by the fact that water bottles have a metadata of 0, so setting that bit made it a mundane potion. Also add missing break statements to the read item NBT switch, which would otherwise break items with custom names and also cause incorrect "Unimplemented NBT data when parsing!" logging. * Copy Protocol18x as Protocol19x Aditionally, method and class names have been swapped to clean up other diffs. This commit is only added to make the following diffs more readable; it doesn't make any other changes (beyond class names). * Make thrown potions use the correct appearence This was caused by potions now using metadata. * Add missing api doc for cSplashPotionEntity::GetItem * Fix compile error in SplashPotionEntity.cpp * Fix fix of cSplashPotionEntity API doc * Temporarilly disable fall damage particles These were causing issues in 1.9 due to the changed effect ID. * Properly send a kick packet when connecting with an invalid version This means that the client no longer waits on the server screen with no indication whatsoever. However, right now the server list ping isn't implemented for unknown versions, so it'll only load "Old" on the ping. I also added a GetVarIntSize method to cByteBuffer. This helps clean up part of the code here (and I think it could clean up other parts), but it may make sense for it to be moved elsewhere (or declared in a different way). * Handle server list pings from unrecognized versions This isn't the cleanest way of writing it (it feels odd to use ProtocolRecognizer to send packets, and the addition of m_InPingForUnrecognizedVersion feels like the wrong technique), but it works and I can't think of a better way (apart from creating a full separate protocol class to handle only the ping... which would be worse). * Use cPacketizer for the disconnect packet This also should fix clang build errors. * Add 1.9.3 / 1.9.4 support * Fix incorrect indentation in APIDesc
2016-02-05Bulk clearing of whitespaceLogicParrot1-14/+14
2015-10-02Remove a pair of unused broken functionstycho1-34/+0
2015-07-31Unified the doxy-comment format.Mattes D1-2/+0
2015-07-29Silenced and fixed many warning messages across multiple files.Samuel Barney1-7/+7
2015-06-11SelfTests are registered and executed after logging framework init.Mattes D1-7/+8
Fixes #2228.
2015-03-22Added VarInt64, normalized cPacketizer datatype names.Mattes D1-8/+53
2015-03-22Unified cPacketizer across all protocols.Mattes D1-4/+8
2015-03-21Unified cByteBuffer types.Mattes D1-31/+72
cByteBuffer now reads and writes any of the [U]Int<N> types.
2015-01-21ByteBuffer: Added support for reading unsigned shorts and ints.Matyas Dolak1-1/+31
2015-01-03cByteBuffer: Improved SingleThreadAccessChecker performance.Mattes D1-1/+6
But it's still poor and unusable for regular testing.
2014-12-24ByteBuffer: SingleThreadAccessChecker is request-only.Mattes D1-1/+10
It slows the server down way too much, so it can't be turned on by default.
2014-12-03Fixed indent.Mattes D1-2/+2
2014-12-03ByteBuffer: Re-added Single-thread access checker.Mattes D1-0/+84
2014-10-23En masse NULL -> nullptr replaceTiger Wang1-1/+1
2014-10-20En masse NULL -> nullptr replaceTiger Wang1-1/+1
2014-10-19Use std::threadTiger Wang1-74/+0
2014-09-27Bug fixTiger Wang1-17/+0
2014-09-25cByteBuffer: Simplified ReadPosition().madmaxoft1-6/+9
Also, by popular demand, added more comments to the code.
2014-09-25cByteBuffer: Fixed position reading.madmaxoft1-3/+3
2014-09-25Added cByteBuffer::WriteBEUShort().madmaxoft1-0/+13
2014-09-181.8: Simplified item metadata reading.Howaner1-17/+0
2014-09-17Use xofts ReadPosition() code.Howaner1-3/+6
2014-09-121.8: Fixed ReadItem()Howaner1-1/+1
2014-09-08Fixed more 1.8 packets.Howaner1-0/+44
2014-08-23Assume POWER is big-endian, so it compiles.Alexander Harkness1-1/+1
[reference](http://nadeausoftware.com/articles/2012/02/c_c_tip_how_detect_processor_type_using_compiler_predefined_macros#POWER) We may want to come back and figure out if the processor is running in little-endian mode, but for now assume they're big-endian.
2014-07-17Normalized comments.madmaxoft1-1/+1
This was mostly done automatically and then visually inspected for obvious errors. All //-style comments should have a 2-space separation from the code, and 1 space after the comment sign.
2014-06-19Nullify deleted pointers.archshift1-0/+1
2014-06-11Removed assert that is now informed by type systemworktycho1-1/+0
2014-05-01Fixed warnings in cByteBuffer.madmaxoft1-13/+13
2014-04-27Removed Old AssertsTycho1-2/+0
Removed asserts about non-negative numbers on what are now unsigned types Fixes CID 43608
2014-04-25Small changes; warning fixing.archshift1-1/+1
2014-04-24cByteBuffer uses void * instead of char * in data interface.madmaxoft1-4/+5
This makes it compatible with any pointer type.
2014-04-24Changed cByteBuffer constructor to take a size_t instead of int.madmaxoft1-1/+1
2014-03-14Fixed xofts issuesTycho1-1/+1
2014-03-11Fixed more Format issuesTycho1-1/+1
2014-03-10Fixed test assertsTycho1-3/+0
2014-03-10Fixed assertTycho1-14/+17
2014-03-10Fixed Alignment issue in ByteBufferTycho1-1/+1
2014-03-09FIxed int in testTycho1-1/+1
2014-03-08Added staticTycho1-1/+1
2014-03-08Added tons more asserts to bytebufferTycho1-7/+17
2014-03-08Enabled self test of bytebufferTycho1-1/+1
2014-03-08Fixed issues with int vs size_t and a few other warningsTycho1-10/+10
2014-03-08Actually Fixed ByteBufferTycho1-3/+3
2014-03-07WarningsTycho1-5/+5
2014-01-26cByteBuffer has more self-tests.madmaxoft1-6/+29
2013-12-31removed unneccisary castTycho Bickerstaff1-1/+2
2013-12-31fixed warnings in bytebuffer.cppTycho Bickerstaff1-3/+3
2013-12-13Fixed threading issues affecting cProtocol172.madmaxoft1-0/+22
2013-12-04Hopefully fixed the sparc not being detectedAlexander Harkness1-1/+3
2013-11-29Fixed an off-by-one error in cByteBuffer.madmaxoft1-1/+1
Could have caused random protocol errors and maybe even crashes.
2013-11-24Moved source to srcAlexander Harkness1-0/+0
2013-11-24RCONClient: Initial implementation.madmaxoft1-0/+54
Fix #79.
2013-11-03cByteBuffer: Fixed GetUsedSpace() off-by-one error.madmaxoft1-1/+1
2013-10-31ByteBuffer: Writing a string doesn't modify it (missing const).madmaxoft1-1/+1
2013-10-28MC uses VarInts only up to 32-bits.madmaxoft1-9/+9
2013-10-28cByteBuffer: Added the VarInt and VarUTF8String type reading and writing.madmaxoft1-2/+128
This implements #296.
2013-07-29Changed everyting to Unix line endings.Alexander Harkness1-661/+661
2012-12-27ProtoProxy: Fixed 1.4.6 compatibility with vehicles, logging for entity metadata.madmaxoft@gmail.com1-0/+5
Also removed logging to console, it was slowing the program too much. git-svn-id: http://mc-server.googlecode.com/svn/trunk@1108 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-11-22ByteBuffer: Fixed buffer overrun possibility.madmaxoft@gmail.com1-1/+3
http://forum.mc-server.org/showthread.php?tid=633&pid=5473#pid5473 git-svn-id: http://mc-server.googlecode.com/svn/trunk@1063 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-11-22More ByteBuffer checks: Is it used from a single thread only?madmaxoft@gmail.com1-0/+69
git-svn-id: http://mc-server.googlecode.com/svn/trunk@1062 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-11-20Aggressive debug mode cByteBuffer validity checking.madmaxoft@gmail.com1-21/+88
Hopefully fixed the "BytesToEndOfBuffer" assert. git-svn-id: http://mc-server.googlecode.com/svn/trunk@1057 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-11-10Fixed a bug introduced in rev 1023 (ThuGie's crash)madmaxoft@gmail.com1-4/+7
git-svn-id: http://mc-server.googlecode.com/svn/trunk@1029 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-11-07Hotfix for ThuGie's crash, with a sanity check in debug mode.madmaxoft1-1/+2
git-svn-id: http://mc-server.googlecode.com/svn/trunk@1023 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-10-25Fixed up a few valgrind warningsmadmaxoft@gmail.com1-1/+1
( http://forum.mc-server.org/showthread.php?tid=598&pid=5071#pid5071 ) git-svn-id: http://mc-server.googlecode.com/svn/trunk@1010 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-09-06Fixed slot parsing in 1.2.5 causing weird behavior ( http://forum.mc-server.org/showthread.php?tid=551&pid=4413#pid4413 )madmaxoft@gmail.com1-0/+5
Also added some asserts into ByteBuffer so that this won't happen again. git-svn-id: http://mc-server.googlecode.com/svn/trunk@842 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-09-04Debugging in cByteBuffer::Write(); added the ReadAgain() method to allow ProtoProxy re-send the data it has parsed.madmaxoft@gmail.com1-0/+28
git-svn-id: http://mc-server.googlecode.com/svn/trunk@833 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-09-02Added writing support to cByteBuffer (will be used by ProtoProxy)madmaxoft@gmail.com1-3/+137
git-svn-id: http://mc-server.googlecode.com/svn/trunk@825 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-08-27Cut out all packet handling to a separate cProtocol descendantmadmaxoft@gmail.com1-0/+9
git-svn-id: http://mc-server.googlecode.com/svn/trunk@796 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-08-18Packet refactoring, phase two, partial. Rewritten a few packet handling functions not to use cPacket-descendant objects.madmaxoft@gmail.com1-0/+14
This breaks plugin API! Plugins need to modify their hook functions to match those used in the Core plugin git-svn-id: http://mc-server.googlecode.com/svn/trunk@750 0a769ca7-a7f5-676a-18bf-c427514a06d6
2012-08-17Packets now parse themselves from a cByteBuffer object (1st part of packeting rewrite, http://forum.mc-server.org/showthread.php?tid=524 )madmaxoft@gmail.com1-0/+324
git-svn-id: http://mc-server.googlecode.com/svn/trunk@744 0a769ca7-a7f5-676a-18bf-c427514a06d6
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 22:14:06 +0100