diff options
author | bunnei <bunneidev@gmail.com> | 2018-08-13 07:41:23 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-08-13 07:41:23 +0200 |
commit | 2e89719d3ee1f79df81b1fb596f3a41c1a125e8e (patch) | |
tree | 7dd4cd757ce279eb8cfe8a2b6bc17c4b865832e0 /src | |
parent | Merge pull request #1047 from bunnei/rgba16-uint (diff) | |
parent | kernel/object: Tighten object against data races (diff) | |
download | yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar.gz yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar.bz2 yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar.lz yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar.xz yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.tar.zst yuzu-2e89719d3ee1f79df81b1fb596f3a41c1a125e8e.zip |
Diffstat (limited to '')
-rw-r--r-- | src/core/hle/kernel/kernel.cpp | 2 | ||||
-rw-r--r-- | src/core/hle/kernel/object.h | 15 |
2 files changed, 9 insertions, 8 deletions
diff --git a/src/core/hle/kernel/kernel.cpp b/src/core/hle/kernel/kernel.cpp index 1b0cd0abf..8c19e86d3 100644 --- a/src/core/hle/kernel/kernel.cpp +++ b/src/core/hle/kernel/kernel.cpp @@ -11,7 +11,7 @@ namespace Kernel { -unsigned int Object::next_object_id; +std::atomic<u32> Object::next_object_id{0}; /// Initialize the kernel void Init() { diff --git a/src/core/hle/kernel/object.h b/src/core/hle/kernel/object.h index 83df68dfd..526ac9cc3 100644 --- a/src/core/hle/kernel/object.h +++ b/src/core/hle/kernel/object.h @@ -4,6 +4,7 @@ #pragma once +#include <atomic> #include <string> #include <utility> @@ -42,8 +43,8 @@ public: virtual ~Object(); /// Returns a unique identifier for the object. For debugging purposes only. - unsigned int GetObjectId() const { - return object_id; + u32 GetObjectId() const { + return object_id.load(std::memory_order_relaxed); } virtual std::string GetTypeName() const { @@ -61,23 +62,23 @@ public: bool IsWaitable() const; public: - static unsigned int next_object_id; + static std::atomic<u32> next_object_id; private: friend void intrusive_ptr_add_ref(Object*); friend void intrusive_ptr_release(Object*); - unsigned int ref_count = 0; - unsigned int object_id = next_object_id++; + std::atomic<u32> ref_count{0}; + std::atomic<u32> object_id{next_object_id++}; }; // Special functions used by boost::instrusive_ptr to do automatic ref-counting inline void intrusive_ptr_add_ref(Object* object) { - ++object->ref_count; + object->ref_count.fetch_add(1, std::memory_order_relaxed); } inline void intrusive_ptr_release(Object* object) { - if (--object->ref_count == 0) { + if (object->ref_count.fetch_sub(1, std::memory_order_acq_rel) == 1) { delete object; } } |