summaryrefslogtreecommitdiffstats
path: root/src/common/ring_buffer.h (follow)
Commit message (Collapse)AuthorAgeFilesLines
* common: Reduce unused includesameerj2022-03-191-1/+0
|
* ring_buffer: Remove granularity template argumentMerryMage2021-02-061-11/+10
| | | | | | Non-obvious bug in RingBuffer::Push(std::vector<T>&) when granularity != 1 Just remove it altogether because we do not have a use for granularity != 1
* common: Make use of [[nodiscard]] where applicableLioncash2020-08-151-2/+2
| | | | | | Now that clang-format makes [[nodiscard]] attributes format sensibly, we can apply them to several functions within the common library to allow the compiler to complain about any misuses of the functions.
* ring_buffer: Use std::atomic_size_t in a static assertLioncash2018-09-191-1/+1
| | | | Avoids the need to repeat "std::" twice
* ring_buffer: Use std::hardware_destructive_interference_size to determine alignment size for avoiding false sharingLioncash2018-09-191-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | MSVC 19.11 (A.K.A. VS 15.3)'s C++ standard library implements P0154R1 (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0154r1.html) which defines two new constants within the <new> header, std::hardware_destructive_interference_size and std::hardware_constructive_interference_size. std::hardware_destructive_interference_size defines the minimum recommended offset between two concurrently-accessed objects to avoid performance degradation due to contention introduced by the implementation (with the lower-bound being at least alignof(max_align_t)). In other words, the minimum offset between objects necessary to avoid false-sharing. std::hardware_constructive_interference_size on the other hand defines the maximum recommended size of contiguous memory occupied by two objects accessed wth temporal locality by concurrent threads (also defined to be at least alignof(max_align_t)). In other words the maximum size to promote true-sharing. So we can simply use this facility to determine the ideal alignment size. Unfortunately, only MSVC supports this right now, so we need to enclose it within an ifdef for the time being.
* Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi2018-09-151-25/+25
|
* common: Implement a ring bufferMerryMage2018-09-081-0/+111