| Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
This formats all copyright comments according to SPDX formatting guidelines.
Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
|
|
Brings us closer to enabling -Wshadow as an error in the core code.
|
|
|
|
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
|
|
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.
This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
|
|
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key.
This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
|
|
The given string instance doesn't need to be copied entirely, we can
just use a view instead.
|
|
|
|
|
|
Avoids making copies of large std::vector instances where it's trivially
avoidable to do so.
|
|
Theres no need to do explicit bitwise arithmetic here, when we have a
function that does this with a more descriptive name.
|
|
Cast where explicitly necessary and in other cases we can simply modify
the algorithm to accomodate larger data.
|
|
There's no need to duplicate in-class initializers with a constructor
initializer list. std::strings also initialize to empty by default.
|
|
The std::vector instances are already initially allocated with all
entries having these values, there's no need to loop through and fill
them with it again when they aren't modified.
|
|
auto x = 0;
auto-deduces x to be an int. This is undesirable when working with
unsigned values. It also causes sign conversion warnings. Instead, we
can make it a proper unsigned value with the correct width that the
following expressions operate on.
|
|
Given we just recently had a patch backport this from citra, let's try
and keep the convention uniform.
|
|
|
|
|