| Commit message (Collapse) | Author | Files | Lines |
|
Also inverts if statements where applicable to allow unindenting code a
little bit.
|
|
These parameters don't need to utilize a shared lifecycle directly in
the interface. Instead, the caller should provide a regular reference
for the function to use. This also allows the type system to flag
attempts to pass nullptr and makes it more generic, since it can now be
used in contexts where a shared_ptr isn't being used (in other words, we
don't constrain the usage of the interface to a particular mode of
memory management).
|
|
Creates a single KeyManager for the entire container and then passes it into the NCA constructor, eliminating several unnecessary KeyManager reads.
|
|
* get rid of boost::optional
* Remove optional references
* Use std::reference_wrapper for optional references
* Fix clang format
* Fix clang format part 2
* Adressed feedback
* Fix clang format and MacOS build
|
|
|
|
Prevents a Entry from appearing in the list twice if the user has it installed in two places (e.g. User NAND and SDMC)
|
|
The data retrieved in these cases are ultimately chiefly owned by either
the RegisteredCache instance itself, or the filesystem factories. Both
these should live throughout the use of their contained data. If they
don't, it should be considered an interface/design issue, and using
shared_ptr instances here would mask that, as the data would always be
prolonged after the main owner's lifetime ended.
This makes the lifetime of the data explicit and makes it harder to
accidentally create cyclic references. It also makes the interface
slightly more flexible than the previous API, as a shared_ptr can be
created from a unique_ptr, but not the other way around, so this allows
for that use-case if it ever becomes necessary in some form.
|
|
Given these are only added to the class to allow those functions to
access the private constructor, it's a better approach to just make them
static functions in the interface, to make the dependency explicit.
|
|
|
|
|
|
|
|
|
|
Aggregates multiple caches into one interface
|
|
|
|
|
|
Cuts down on include dependencies, resulting in less files that need to
be rebuilt when certain things are changed.
|
|
Eliminates the need to rebuild some source files if the file_util header
ever changes. This also uncovered some indirect inclusions, which have
also been fixed.
|
|
Prevents compiler warnings.
|
|
|
|
Returns the file before calling parser on it.
|
|
|
|
|
|
It's in the common code, so it should be under the Common namespace like
everything else.
|
|
Fix logic in RealVfsFilesystem Create methods
Remove magic numbers
Fix regex errors
|
|
|
|
|
|
Instead of defaulting to VfsRawCopy
|
|
|
|
|
|
Prompts for title type on NCA files.
|
|
Manages NAND NCA get and install.
|