summaryrefslogtreecommitdiffstats
path: root/src/input_common/sdl (follow)
Commit message (Collapse)AuthorAgeFilesLines
* sdl_impl: Fix controller reconnection issuesMorph2020-10-211-85/+84
| | | | | | | It turns out that after a controller is disconnected, there is a chance that events from the previous controller are sent/processed after it has been disconnected. This causes the previously disconnected controller to reappear as connected due to GetSDLJoystickBySDLID() emplacing this controller back to the map. Fix this by only returning an SDLJoystick if and only if it exists in the map.
* sdl_impl: Erase the SDLJoystick entry after removing a controllerMorph2020-10-161-15/+13
| | | | | | | Previously, disconnecting a controller still leaves a null SDLJoystick entry within the vector of SDLJoysticks mapped by GUID. When a DirectInput device of the same GUID is reconnected, it adds that device to a new port causing non-detectable input. Furthermore, opening the "Configure" menu would cause yuzu to crash since it first tries to resolve the name of a null SDLJoystick entry that was not removed. Resolve this by properly erasing the SDLJoystick entry from the vector.
* input_common/CMakeLists: Make some warnings errorsLioncash2020-10-161-37/+40
| | | | | Makes the input_common code warnings consistent with the rest of the codebase.
* Merge pull request #4677 from german77/ShakeFromButtonbunnei2020-10-082-0/+192
|\ | | | | InputCommon: Add random motion input for buttons
| * Add random motion input to SDLgerman2020-09-262-0/+192
| |
* | First implementation of controller rumblegerman2020-09-291-1/+38
|/
* sdl_impl: Reduce allocations in GetButtonMappingForDevice()Lioncash2020-08-291-31/+37
| | | | These maps can be constexpr arrays of std::pair.
* sdl_impl: Make use of std::move on std::string where applicableLioncash2020-08-291-3/+3
| | | | Avoids redundant copies.
* sdl_impl: Make use of insert_or_assign() where applicableLioncash2020-08-291-14/+18
| | | | Avoids churning ParamPackage instances.
* sdl_impl: Prevent type truncation in BuildAnalogParamPackageForButton() default argumentsLioncash2020-08-291-1/+1
| | | | | We need to add the 'f' suffix to make the right hand side a float and not a double.
* sdl_impl: Simplify make_tuple callLioncash2020-08-291-1/+1
| | | | | | | The purpose of make_tuple is that you don't need to explicitly type out the types of the things that comprise said tuple. Given this just returns default values, we can simplify this a bit.
* sdl_impl: Mark FromEvent() as a const member functionLioncash2020-08-291-2/+2
| | | | This doesn't modify internal member state, so it can be marked as const.
* input_common/main: Remove unnecessary headersLioncash2020-08-291-1/+1
|
* input_common: Fix directional deadzone valuesMorph2020-08-261-1/+1
| | | | The hardware tested value is 0.5 which translates to SHRT_MAX / 2
* Address feedbackMorph2020-08-261-32/+20
|
* Project Mjölnir: Part 1Morph2020-08-263-94/+336
| | | | | Co-authored-by: James Rowe <jroweboy@gmail.com> Co-authored-by: Its-Rei <kupfel@gmail.com>
* Remove UI changesameerj2020-08-101-1/+1
| | | | This PR is now only the Analog devices handling the range value defaulting at 100%
* undo unnecessary newlines, slider range 50-150Ameer2020-08-101-1/+1
|
* Add range slider for analog sticksAmeer2020-08-101-11/+14
|
* CMakeLists: Specify -Wextra on linux buildsLioncash2020-04-161-0/+1
| | | | | | | | | | | Allows reporting more cases where logic errors may exist, such as implicit fallthrough cases, etc. We currently ignore unused parameters, since we currently have many cases where this is intentional (virtual interfaces). While we're at it, we can also tidy up any existing code that causes warnings. This also uncovered a few bugs as well.
* Moved analog direction logic to sdl_implCJBok2020-01-151-0/+16
|
* input_common/sdl/sdl_impl: Correct logging string in SDLState constructorLioncash2019-06-031-1/+1
| | | | | | If this path was ever taken, a runtime exception would occur due to the lack of a formatting specifier to insert the error code into the format string.
* input_common/sdl/sdl_impl: Move documentation comments to header where applicableLioncash2019-06-032-7/+6
| | | | | Places the documentation comments with the rest of SDLState's member function documentation.
* input_common/sdl/sdl_impl: Amend names for axes for SDLAnalogPollerLioncash2019-06-031-13/+13
| | | | Adds another underscore to clearly indicate the axis names.
* input_common/sdl/sdl_impl: Mark variables const where applicableLioncash2019-06-031-10/+11
| | | | | Make it explicit that these aren't modified elsewhere (either through functions by reference, or by other operations).
* input_common/sdl/sdl_impl: Mark SDLEventToButtonParamPackage() as staticLioncash2019-06-031-1/+1
| | | | | | Its prototype declared at the top of the translation unit contains the static qualifier, so the function itself should also contain it to make it a proper internally linked function.
* input_common/sdl/sdl_impl: Convert reinterpret_cast into a static_castLioncash2019-06-031-2/+4
| | | | It's valid to static_cast a void pointer back into its proper type.
* input_common/sdl/sdl_impl: Use insert_or_assign() where applicableLioncash2019-06-031-3/+3
| | | | | Same behavior, but without a potential need to unnecessarily default construct a value.
* input_common/sdl/sdl_impl: Simplify SDL_Joystick deleter handlingLioncash2019-06-031-15/+14
| | | | | | | | | The deleter can just be set in the constructor and maintained throughout the lifetime of the object. If a contained pointer is null, then the deleter won't execute, so this is safe to do. We don't need to swap it out with a version of a deleter that does nothing.
* input_common/sdl/sdl_impl: Resolve two sign conversion warningsLioncash2019-06-031-10/+16
| | | | Silences the final two warnings in SDL code.
* input_common/sdl: Remove unused header includes and forward declarationsLioncash2019-06-033-11/+5
| | | | | Gets rid of a few unnecessary inclusion dependencies. It also uncovered a few indirect inclusion dependencies being relied upon.
* input_common/sdl/sdl_impl: Use nested namespace specifiers where applicableLioncash2019-06-031-5/+2
|
* input_common/sdl/sdl_impl: Silence sign conversion warningsLioncash2019-05-311-3/+3
| | | | Makes the conversions explicit, as opposed to implicit.
* general: Use deducation guides for std::lock_guard and std::unique_lockLioncash2019-04-011-12/+14
| | | | | | | Since C++17, the introduction of deduction guides for locking facilities means that we no longer need to hardcode the mutex type into the locks themselves, making it easier to switch mutex types, should it ever be necessary in the future.
* input_common/sdl: Correct return values within implementations of GetPollers()Lioncash2019-03-182-2/+6
| | | | | In both cases, we weren't actually returning anything, which is undefined behavior.
* input_common/sdl: Use a type alias to shorten declaration of GetPollersLioncash2019-03-183-11/+9
| | | | Just makes the definitions a little bit more tidy.
* input_common/sdl_impl: Make lambda capture more specific in SDLState constructorLioncash2019-03-171-1/+1
| | | | | We don't need to universally capture by reference. We specifically just need to capture the this pointer.
* input_common/sdl_impl: Remove unnecessary std::chrono::duration constructionLioncash2019-03-171-1/+1
| | | | Specifying the time unit itself is sufficient here.
* input_common/sdl_impl: Remove unused variable in SDLState constructorLioncash2019-03-171-1/+0
|
* fixup! Joystick: Allow for background events; Add deadzone to SDLAnalogB3n302019-03-021-6/+17
|
* input/sdl: lock map mutex after SDL callWeiyi Wang2019-03-021-11/+17
| | | | Any SDL invocation can call the even callback on the same thread, which can call GetSDLJoystickBySDLID and eventually cause double lock on joystick_map_mutex. To avoid this, lock guard should be placed as closer as possible to the object accessing code, so that any SDL invocation is with the mutex unlocked
* Input: Remove global variables from SDL InputJames Rowe2019-03-024-773/+188
| | | | | | | | | Changes the interface as well to remove any unique methods that frontends needed to call such as StartJoystickEventHandler by conditionally starting the polling thread only if the frontend hasn't started it already. Additionally, moves all global state into a single SDLState class in order to guarantee that the destructors are called in the proper order
* Input: Copy current SDL.h/cpp files to implJames Rowe2019-03-022-0/+680
| | | | | This should make reviewing much easier as you can then see what changed happened between the old file and the new one
* Port #4141 from citra: Joystick hotplug support (#1275)Tobias2018-09-112-88/+308
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Joystick hotplug support (#4141) * use SDL_PollEvent instead of SDL_JoystickUpdate Register hot plugged controller by GUID if they were configured in a previous session * Move SDL_PollEvent into its own thread * Don't store SDLJoystick pointer in Input Device; Get pointer on each GetStatus call * Fix that joystick_list gets cleared after SDL_Quit * Add VirtualJoystick for InputDevices thats never nullptr * fixup! Add VirtualJoystick for InputDevices thats never nullptr * fixup! fixup! Add VirtualJoystick for InputDevices thats never nullptr * Remove SDL_GameController, make SDL_Joystick* unique_ptr * fixup! Remove SDL_GameController, make SDL_Joystick* unique_ptr * Adressed feedback; fixed handling of same guid reconnects * fixup! Adressed feedback; fixed handling of same guid reconnects * merge the two joystick_lists into one * make SDLJoystick a member of VirtualJoystick * fixup! make SDLJoystick a member of VirtualJoystick * fixup! make SDLJoystick a member of VirtualJoystick * fixup! fixup! make SDLJoystick a member of VirtualJoystick * SDLJoystick: Addressed review comments * Address one missed review comment
* input_common: Use std::move where applicableLioncash2018-08-031-4/+4
| | | | Avoids unnecessary atomic reference count increments and decrements
* input_common: Add missing override specifiersLioncash2018-08-031-12/+0
|
* Rename logging macro back to LOG_*James Rowe2018-07-031-3/+3
|
* input_common: Move old logging macros over to fmt-capable onesLioncash2018-04-271-3/+3
|
* input_common/sdl: Silence a -Wpessimizing-move warningLioncash2018-01-181-1/+1
|
* Adding meumart's Citra SDL Joystick support. Citra PR #3116muemart2018-01-162-1/+205
|
* Fix some spelling mistakesdanzel2017-08-111-1/+1
|
* input_common/sdl: add support for binding button to axiswwylele2017-04-171-4/+53
|
* InputCommon: add SDL joystick supportwwylele2017-03-012-0/+221
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 16:09:33 +0100