summaryrefslogtreecommitdiffstats
path: root/src/video_core/renderer_opengl/gl_buffer_cache.cpp (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-11-04video_core: Fix SNORM texture buffer emulating error (#9001)Feng Chen1-9/+6
2022-09-10Align index buffe size when vertex_buffer_unified_memory enableFengChen1-1/+1
2022-04-23general: Convert source file copyright comments over to SPDXMorph1-3/+2
This formats all copyright comments according to SPDX formatting guidelines. Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
2022-03-25GC: Address Feedback.Fernando Sahmkow1-9/+5
2022-03-25Garbage Collection: Final tuning.Fernando Sahmkow1-1/+1
2022-03-25Buffer Cache: Tune to the levels of the new GC.Fernando Sahmkow1-0/+18
2021-11-16shader: Properly scale image reads and add GL SPIR-V supportReinUsesLisp1-4/+9
Thanks for everything!
2021-09-20buffer_cache: Minor fixesameerj1-2/+1
Loop through the tmp_intervals by reference, rather than by copy, and fix gl clear buffer size calculation.
2021-07-23 gl_buffer_cache: Use unorm internal formats for snorm texture buffer viewsameerj1-1/+24
Fixes black textures in UE4 games
2021-07-23glasm: Use storage buffers instead of global memory when possibleReinUsesLisp1-12/+14
2021-07-23shader: Initial OpenGL implementationReinUsesLisp1-2/+35
2021-07-20gl_buffer_cache: Use glClearNamedBufferSubData:GL_RED instead of GL_RGBAReinUsesLisp1-1/+1
Avoids reading out of bounds from the stack.
2021-07-13DMAEngine: Accelerate BufferClearFernando Sahmkow1-0/+6
2021-03-02buffer_cache: Heuristically decide to skip cache on uniform buffersReinUsesLisp1-1/+2
Some games benefit from skipping caches (Pokémon Sword), and others don't (Animal Crossing: New Horizons). Add an heuristic to decide this at runtime. The cache hit ratio has to be ~98% or better to not skip the cache. There are 16 frames of buffer.
2021-02-13renderer_opengl: Remove interopReinUsesLisp1-9/+2
Remove unused interop code from the OpenGL backend.
2021-02-13gl_buffer_cache: Drop interop based parameter buffer workaroundsReinUsesLisp1-53/+33
Sacrify runtime performance to avoid generating kernel exceptions on Windows due to our abusive aliasing of interop buffer objects.
2021-02-13video_core: Reimplement the buffer cacheReinUsesLisp1-60/+197
Reimplement the buffer cache using cached bindings and page level granularity for modification tracking. This also drops the usage of shared pointers and virtual functions from the cache. - Bindings are cached, allowing to skip work when the game changes few bits between draws. - OpenGL Assembly shaders no longer copy when a region has been modified from the GPU to emulate constant buffers, instead GL_EXT_memory_object is used to alias sub-buffers within the same allocation. - OpenGL Assembly shaders stream constant buffer data using glProgramBufferParametersIuivNV, from NV_parameter_buffer_object. In theory this should save one hash table resolve inside the driver compared to glBufferSubData. - A new OpenGL stream buffer is implemented based on fences for drivers that are not Nvidia's proprietary, due to their low performance on partial glBufferSubData calls synchronized with 3D rendering (that some games use a lot). - Most optimizations are shared between APIs now, allowing Vulkan to cache more bindings than before, skipping unnecesarry work. This commit adds the necessary infrastructure to use Vulkan object from OpenGL. Overall, it improves performance and fixes some bugs present on the old cache. There are still some edge cases hit by some games that harm performance on some vendors, this are planned to be fixed in later commits.
2020-12-30video_core: Rewrite the texture cacheReinUsesLisp1-4/+3
The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage.The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage. This commit aims to address those issues.
2020-12-05video_core: Resolve more variable shadowing scenarios pt.3Lioncash1-16/+16
Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.
2020-09-06video_core: Remove all Core::System references in rendererReinUsesLisp1-2/+3
Now that the GPU is initialized when video backends are initialized, it's no longer needed to query components once the game is running: it can be done when yuzu is booting. This allows us to pass components between constructors and in the process remove all Core::System references in the video backend.
2020-07-18gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shadersReinUsesLisp1-1/+1
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications to use what in Vulkan is known as physical pointers, this is basically C pointers. On GLASM these is exposed through the LOAD/STORE/ATOM instructions. Up until now, assembly shaders were using NV_shader_storage_buffer_object. These work fine, but have a (probably unintended) limitation that forces us to have the limit of a single stage for all shader stages. In contrast, with NV_shader_buffer_{load,store} we can pass GPU addresses to the shader through local parameters (GLASM equivalent uniform constants, or push constants on Vulkan). Local parameters have the advantage of being per stage, allowing us to generate code without worrying about binding overlaps.
2020-06-26gl_buffer_cache: Copy to buffers created as STREAM_READ before downloadingReinUsesLisp1-5/+12
After marking buffers as resident, Nvidia's driver seems to take a slow path. To workaround this issue, copy to a STREAM_READ buffer and then call GetNamedBufferSubData on it. This is a temporary solution until we have asynchronous flushing.
2020-06-24buffer_cache: Use buffer methods instead of cache virtual methodsReinUsesLisp1-20/+18
2020-06-24gl_buffer_cache: Mark buffers as residentReinUsesLisp1-8/+16
Make stream buffer and cached buffers as resident and query their address. This allows us to use GPU addresses for several proprietary Nvidia extensions.
2020-06-09buffer_cache: Avoid passing references of shared pointers and misc style changesReinUsesLisp1-13/+8
Instead of using as template argument a shared pointer, use the underlying type and manage shared pointers explicitly. This can make removing shared pointers from the cache more easy. While we are at it, make some misc style changes and general improvements (like insert_or_assign instead of operator[] + operator=).
2020-05-21buffer_cache: Use boost::intrusive::set for cachingReinUsesLisp1-0/+1
Instead of using boost::icl::interval_map for caching, use boost::intrusive::set. interval_map is intended as a container where the keys can overlap with one another; we don't need this for caching buffers and a std::set-like data structure that allows us to search with lower_bound is enough.
2020-04-28{maxwell_3d,buffer_cache}: Implement memory barriers using 3D registersReinUsesLisp1-4/+0
Drop MemoryBarrier from the buffer cache and use Maxwell3D's register WaitForIdle. To implement this on OpenGL we just call glMemoryBarrier with the necessary bits. Vulkan lacks this synchronization primitive, so we set an event and immediately wait for it. This is not a pretty solution, but it's what Vulkan can do without submitting the current command buffer to the queue (which ends up being more expensive on the CPU).
2020-04-22OpenGL: Guarantee writes to Buffers.Fernando Sahmkow1-1/+2
2020-04-16buffer_cache: Return handles instead of pointer to handlesReinUsesLisp1-10/+8
The original idea of returning pointers is that handles can be moved. The problem is that the implementation didn't take that in mind and made everything harder to work with. This commit drops pointer to handles and returns the handles themselves. While it is still true that handles can be invalidated, this way we get an old handle instead of a dangling pointer. This problem can be solved in the future with sparse buffers.
2020-04-06Buffer Cache: Use vAddr instead of physical memory.Fernando Sahmkow1-4/+4
2019-11-02gl_rasterizer: Upload constant buffers with glNamedBufferSubDataReinUsesLisp1-4/+27
Nvidia's OpenGL driver maps gl(Named)BufferSubData with some requirements to a fast. This path has an extra memcpy but updates the buffer without orphaning or waiting for previous calls. It can be seen as a better model for "push constants" that can upload a whole UBO instead of 256 bytes. This path has some requirements established here: http://on-demand.gputechconf.com/gtc/2014/presentations/S4379-opengl-44-scene-rendering-techniques.pdf#page=24 Instead of using the stream buffer, this commits moves constant buffers uploads to calls of glNamedBufferSubData and from my testing it brings a performance improvement. This is disabled when the vendor is not Nvidia since it brings performance regressions.
2019-08-30gl_buffer_cache: Add missing includeReinUsesLisp1-0/+1
RasterizerInterface was considered an incomplete object by clang.
2019-08-21Buffer_Cache: Implement flushing.Fernando Sahmkow1-0/+4
2019-08-21Video_Core: Implement a new Buffer CacheFernando Sahmkow1-19/+28
2019-07-06gl_buffer_cache: Implement with generic buffer cacheReinUsesLisp1-162/+27
2019-07-06gl_buffer_cache: Remove global system gettersReinUsesLisp1-5/+5
2019-07-06gl_buffer_cache: Implement flushingReinUsesLisp1-1/+5
2019-07-06gl_rasterizer: Drop gl_global_cache in favor of gl_buffer_cacheReinUsesLisp1-6/+16
2019-07-06gl_buffer_cache: Rework to support internalized buffersReinUsesLisp1-46/+121
2019-07-06gl_buffer_cache: Store in CachedBufferEntry the used buffer handleReinUsesLisp1-16/+17
2019-07-06gl_buffer_cache: Return used buffer from Upload functionReinUsesLisp1-12/+11
2019-07-01rasterizer_cache: Protect inherited caches from submission levelFernando Sahmkow1-0/+2
2019-05-30gl_buffer_cache: Remove unused ReserveMemory methodReinUsesLisp1-10/+0
2019-04-06video_core/texures/texture: Remove unnecessary includesLioncash1-0/+1
Nothing in this header relies on common_funcs or the memory manager. This gets rid of reliance on indirect inclusions in the OpenGL caches.
2019-04-04video_core/renderer_opengl: Remove unnecessary includesLioncash1-1/+0
Quite a few unused includes have built up over time, particularly on core/memory.h. Removing these includes means the source files including those files will no longer need to be rebuilt if they're changed, making compilation slightly faster in this scenario.
2019-03-27video_core: Amend constructor initializer list order where applicableLioncash1-2/+2
Specifies the members in the same order that initialization would take place in. This also silences -Wreorder warnings.
2019-03-21gpu: Move GPUVAddr definition to common_types.bunnei1-2/+2
2019-03-16video_core: Refactor to use MemoryManager interface for all memory access.bunnei1-5/+3
# Conflicts: # src/video_core/engines/kepler_memory.cpp # src/video_core/engines/maxwell_3d.cpp # src/video_core/morton.cpp # src/video_core/morton.h # src/video_core/renderer_opengl/gl_global_cache.cpp # src/video_core/renderer_opengl/gl_global_cache.h # src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
2019-03-15gpu: Use host address for caching instead of guest address.bunnei1-9/+15
2019-02-03video_core: Assert on invalid GPU to CPU address queriesReinUsesLisp1-1/+2
2019-01-06gl_stream_buffer: Use DSA for buffer managementReinUsesLisp1-1/+1
2018-11-17gl_rasterizer: Skip VB upload if the state is clean.Markus Wick1-1/+2
2018-11-08rasterizer_cache: Remove reliance on the System singletonLioncash1-1/+3
Rather than have a transparent dependency, we can make it explicit in the interface. This also gets rid of the need to put the core include in a header.
2018-10-30global: Use std::optional instead of boost::optional (#1578)Frederic L1-1/+1
* get rid of boost::optional * Remove optional references * Use std::reference_wrapper for optional references * Fix clang format * Fix clang format part 2 * Adressed feedback * Fix clang format and MacOS build
2018-10-04gl_rasterizer: Implement quads topologyReinUsesLisp1-3/+14
2018-09-15Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi1-7/+8
2018-09-06gl_buffer_cache: Make GetHandle() a const member functionLioncash1-1/+1
GetHandle() internally calls GetHandle() on the stream_buffer instance, which is a const member function, so this can be made const as well.
2018-09-06gl_buffer_cache: Remove unnecessary includesLioncash1-1/+3
2018-09-05renderer_opengl: Implement a buffer cache.Markus Wick1-0/+90
The idea of this cache is to avoid redundant uploads. So we are going to cache the uploaded buffers within the stream_buffer and just reuse the old pointers. The next step is to implement a VBO cache on GPU memory, but for now, I want to check the overhead of the cache management. Fetching the buffer over PCI-E should be quite fast.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 11:09:13 +0200