| Commit message (Collapse) | Author | Files | Lines |
|---|
|
The X11 libraries don't need to be specified when doing dynamic linking
|
|
|
|
|
|
Fixes #277
|
|
|
|
|
|
Same semantics, idea by @yuriks
|
|
|
|
|
|
|
|
|
|
This behavior was tested on hardware, however i'm still not sure what use the "initial_count" parameter has
|
|
ToDo: Implement svcReleaseSemaphore
* Some testing against hardware needed
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- Linear simply indicates that the mapped physical address is always MappedVAddr+0x0C000000, thus this memory can be used for hardware devices' DMA (such as the GPU).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The affected code is no longer limited by compiler support on that platform.
|
|
This better reflects that no commands are supposed to show up until you hit the button a second time.
|
|
|
|
|
|
|
|
Double-clicking a texture parameter command in the pica command lists will spawn these as a new tab in the pica command list dock area.
|
|
The texture viewer is enabled when selecting a write command to one of the texture config registers.
|
|
|
|
|
|
Changed start/stop button to reflect current tracing status.
Properly labeled column headers.
|
|
This class has a few advantages over the regular QSpinBox:
- QSpinBox stores its as signed 32 bit integers, which for instance is unsuitable for representing memory addresses. CSpinBox uses 64 bit integers instead.
- QSpinBox does not provide an easy way to handle number input from bases different than 10.
- QSpinBox is quite inflexible in general and almost any sort of customization requires reimplementing it anyway.
|
|
|
|
|
|
|
|
The 3DS allows the user to read from files opened with the Write access modifier, even if he did not specify the Read access modifier.
Open the files in binary mode so that we can prevent CR/LF problems in Windows, where a line-end is replaced by these two bytes instead of just 0xA, this was causing problems with the GetSize test
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This is in line with what the hardware itself does.
It does this by splitting the initial directory opening into Directory.Open(), which will return false if a stat fails.
Then, Archive::OpenDirectory will return nullptr, and archive.cpp will return an error code .
|
|
Moved Mutex::WaitSynchronization to the end of the file.
|
|
|
|
Also resume only the next immediate thread waiting for the mutex when it is released, instead of resuming them all.
|
|
Use the next_thread_id variable directly.
|
|
|
|
|
|
For now threads are using their Handle value as their Id, it should not really cause any problems because Handle values are unique in Citra, but it should be changed. I left a ToDo there because this is not correct behavior as per hardware.
|
|
|
|
Should theoretically push retail stuff further along
|
|
|
|
|
|
|
|
|
|
|
|
- More readable, a little less error prone.
Conflicts:
src/core/mem_map.h
src/core/mem_map_funcs.cpp
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It will print a message to know what happened in case something went wrong in a GLFW call.
Also replace every printf() in the glfw emu-window by ERROR_LOG().
|
|
Seems (probably just placebo/wishful thinking) to make it slightly
faster. Also reduces memory usage and makes shutdown when debugging from
MSVC fast.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
All service calls in the CTR OS return result codes indicating the
success or failure of the call. Previous to this commit, Citra's HLE
emulation of services and the kernel universally either ignored errors
or returned dummy -1 error codes.
This commit makes an initial effort to provide an infrastructure for
error reporting and propagation which can be use going forward to make
HLE calls accurately return errors as the original system. A few parts
of the code have been updated to use the new system where applicable.
One part of this effort is the definition of the `ResultCode` type,
which provides facilities for constructing and parsing error codes in
the structured format used by the CTR.
The `ResultVal` type builds on `ResultCode` by providing a container for
values returned by function that can report errors. It enforces that
correct error checking will be done on function returns by preventing
the use of the return value if the function returned an error code.
Currently this change is mostly internal since errors are still
suppressed on the ARM<->HLE border, as a temporary compatibility hack.
As functionality is implemented and tested this hack can be eventually
removed.
|
|
This prevents them from interfering with other constants defined in
different namespaces.
|
|
|
|
in the service's headers
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
GLFW provides no proper support for this, hence we just allow any window size to be used.
|
|
|
|
|
|
Implementing this function currently is not critical, as we don't perform any configuration changes, yet.
However, the interface is a good starting point for adding this functionality.
|
|
|
|
|
|
|
|
The window title is none of the emulation core's business. The GUI code is free to put whatever it wants there.
Providing properly thread-safe window title getters and setters is a mess anyway.
|
|
|
|
|
|
|
|
The view is scaled to be as large as possible, without changing the aspect, within the bounds of the window.
On "retina" displays, or other displays where window units != pixels, the view should no longer draw incorrectly.
|
|
Replace asserts with _dbg_assert_.
|
|
These functions are not referred to by their linkage name outside of the translation unit, so they can be marked as static.
|
|
|
|
|
|
added a todo to kernel archive
|
|
|
|
|
|
|
|
Gets rid of a warning on OSX.
|
|
|
|
|
|
Fixes some warnings on OSX.
|
|
|
|
|
|
|
|
- Also Clarified GlanceParameter/ReceiveParameter documentation.
|
|
|
|
- Also added comment to GetLockHandle function.
|
|
- Fixes single stepping in debugger.
|
|
|
|
|
|
|
|
- Fixed NZCVT flags to properly save state when function returns.
- Fixed counter to keep track of the actual number of instructions executed.
- Fixed single-step mode to only execute one instruction at a time.
- DefaultIni: Removed comment that no longer applied to dyncom.
|
|
|
|
|
|
Also moves system initialization to when the game is booted.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This was automated using `clang-modernize`.
|
|
|
|
|
|
Added license header back in. I originally removed this because I mostly rewrote the file, but meh
|
|
|
|
|
|
Fixed typo (make protected member public)
Added license header back in. I originally removed this because I mostly rewrote the file, but meh
ARM: Fixed a type error in dyncom interpreter.
ARM: Updated dyncom to use unique_ptr for internal ARM state.
|
|
Removed s_ prefix
|
|
|
|
|
|
|
|
|
|
Before, it used to use whether the directory actually existed. As a result, .citra-emu/sdmc was never auto-created (something quite confusing to me until I read through the logs).
|
|
This prevents a crash when the buffer size returned by the driver is 0,
in which case no space is allocated to store even the NULL byte and
glGetShaderInfoLog errors out.
Thanks to @Relys for the bug report.
|
|
In PR #143, the name of the function IsOpen was originally ShouldClose, but was changed. The function's caller was changed to reflect this, but the return value wasn't.
|
|
|
|
Fixes #137
|
|
This should fix context creation on OS X. Also requests a core context on all platforms in Citra-GLFW, for consistency.
|
|
The OpenGL renderer has been revised, with the following changes:
- Initialization and rendering have been refactored to reduce the number of
redundant objects used.
- Framebuffer rotation is now done directly, using texture mapping.
- Vertex coordinates are now given in pixels, and the projection matrix
isn't hardcoded anymore.
|
|
This name better represents what the enum does, and is less overloaded
in the context. (The whole register the enum is part of is also called
'format'.)
|
|
|
|
Also make destructor virtual so that instances are properly destructed.
|
|
|
|
|
|
Uses QSettings on citra-qt, and inih on citra-cli.
|
|
Core: Fix the SDMC Directory implementation to make blargSnes work.
|
|
|
|
Kernel: Return an invalid handle to OpenFile when it failed to open.
|
|
|
|
|
|
Added "SetApplicationCpuTimeLimit" and "GetApplicationCpuTimeLimit" to apt.cpp
|
|
seems simple enough
|
|
|
|
- Remove unnecessary ifdefs
- Remove commented out code. Can be retrieved later if needed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It's unused and doesn't look like it compiles anyway :/
|
|
|
|
|
|
|
|
|
|
Instead of forcibly taking the last 4 characters, it now finds the last extension separator (the period) and takes a substr of its location.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In C++ you can simply just declare it as is.
|
|
|
|
|
|
|
|
|
|
|
|
Several cleanups to the buildsystem:
- Do better factoring of common libs between platforms.
- Add support to building on Windows.
- Remove Qt4 support.
- Re-sort file lists and add missing headers.
|
|
This should fix the GL loading errors that occur in some drivers due to
the use of deprecated functions by GLEW. Side benefits are more accurate
auto-completion (deprecated function and symbols don't exist) and faster
pointer loading (less entrypoints to load). In addition it removes an
external library depency, simplifying the build system a bit and
eliminating one set of binary libraries for Windows.
|
|
|
|
Core: Cleaned up comment to be more readable.
Citra: Changed loop to be more readable.
|
|
- Useful for debugging homebrew
Qt: Updated GUI to support loading .bin files.
|
|
|
|
|
|
|
|
- Useful for debugging homebrew
Qt: Updated GUI to support loading .bin files.
|
|
|
|
|
|
|
|
|
|
Screen contents are now displayed using textured quads. This can be updated to expose an FBO once an OpenGL backend for when Pica rendering is being worked on. That FBO's texture can then be applied to the quads.
Previously, FBO blitting was used in order to display screen contents, which did not work on OS X. The new textured quad approach is less of a compatibility risk.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- Swizzlers now return const objects so that things like "first_vec4.xyz() = some_vec3" now will fail to compile (ideally we should support some vector holding references to make this actually work).
- The methods "InsertBeforeX/Y/Z" and "Append" have been replaced by more versions of MakeVec, which now also supports building new vectors from vectors.
- Vector library now follows C++ type promotion rules (hence, the result of Vec2<u8> with another Vec2<u8> is now a Vec2<int>).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Note: There is a pre-existing issue with booting a new game in that it keeps the old EmuThread.
The GL code now supports this but the Core still doesn't.
|
|
Connect the emu_thread start/finish to a moveContext slot.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
These avoid relying on memset for clearing the arrays.
|
|
Changed HLE function return methods to be static inline functions.
|
|
|
|
Returning a copy of the string is what was likely meant to be done.
|
|
|
|
Most functions already operate on std::strings. This also removes the need to manually null terminate thread names.
|
|
entry_point would not be added to the string. Also used StringFromFormat
so that the buffer is unnecessary.
|
|
|
|
On POSIX systems mmap will return MAP_FAILED ((void*)-1) instead of a null pointer.
|
|
|
|
Also replaced C headers with the C++ equivalent ones
|
|
|
|
|
|
|
|
Fixes building with clang.
|
|
HID: Fix typo with DisableGyroscopeLow command.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
24-bit floating points are used internally for calculations on the GPU, however the current code will still emulate that with 32-bit floating points.
In the future we might want to accurately perform the calculations with correct bitness in the future, but for now we just wrap the calculations around this class.
|
|
I wrote most of this for ppsspp, so I hold full copyright over it.
In addition to the original release in ppsspp, this provides functionality to easily extend e.g. two-dimensional vectors to three-dimensional vectors.
|
|
This cleans up the mess that address reading/writing had become and makes the code a *lot* more sensible.
This adds a physical<->virtual address converter to mem_map.h. For further accuracy, we will want to properly extend this to support a wider range of address regions. For now, this makes simply homebrew applications work in a good manner though.
|
|
|
|
|
|
|
|
|
|
While it was some nice and fancy template usage, it ultimately had many practical issues regarding length of involved expressions under regular usage as well as common code completion tools not being able to handle the structures.
Instead, we now use a more conventional approach which is a lot more clean to use.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
GSP: Cleaned up code and added additional comments.
GSP: Removed unnecessary TODO comment.
GSP: Changed u32 iterators in TriggerCmdReqQueue to unsigned.
|
|
|
|
- Various other cleanups.
|
|
|
|
Core: Added a comment to explain the logic for the RunLoop iterations.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- Unused code
- Was not correct for unaligned memory reads
|
|
|
|
MemMap: Cleaned up Read32 unaligned memory access.
|
|
|
|
|
|
|
|
|
|
Templates shouldn't be marked as inline if they aren't defined in the header.
|
|
Also makes the illogical component order more obvious.
|
|
|
|
|
|
Anonymous structs are not standard C++, hence don't use them.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The Git for Windows installer doesn't add the Git binaries to the path
by default. (Due to risk of conflicts with built-in windows commands.)
Unless you have configured your system specially this causes the
scm_rev_gen.js script to fail to find Git. Added more paths to the
script so that it searches in the default msysgit installation
directory, eliminating the need to set the PATH for most environments.
|
|
|
|
Being able to store BitField within unions requires BitField to be of standard layout, which in turn is only given if the underlying type is also has standard layout.
|
|
Cf. https://github.com/dolphin-emu/dolphin/pull/483
|
|
Sometimes it can be beneficial to use this in places where an explicit cast needs to happen otherwise. By using the evaluation method, it's not necessary anymore to explicitly write the underlying type in this case.
|
|
AddressArbiter: Added documentation comment, fixed whitespace issue.
AddressArbiter: Fixed incorrect comment, reordered if-statement to be more clear.
SVC: Removed trailing whitespace.
|
|
Thread: Cleaned up arbitrate address functions.
Thread: Cleaned up ArbitrateAllThreads function.
|
|
|
|
- Also added some safety checks to MapSharedMemory.
|
|
|
|
- Previously, used a hard-coded shared memory handle of 0x10002000 (as used by libctru homebrew)
GSP: Added name for shared memory.
GSP: Cleaned up assertion message.
|
|
SharedMemory: Added optional name field for tracking known objects.
|
|
|
|
|
|
|
|
|
|
|
|
- Required "file" handle to be made local and explicitly opened/closed as needed
|
|
|
|
Archive: Fixed brace ugliness for neobrain :)
FS: Commented out unused local variables to prevent warnings.
...But keeping them here for future use.
archive_romfs: Removed unused #include.
|
|
APT: More cleanups.
APT: Changed SignalType to be type u32.
|
|
|
|
NCCH: Removed extra qualification ‘Loader::AppLoader_NCCH::’.
|
|
FS: Added to CMakeLists.txt
|
|
|
|
Core: Updated CMakeLists.txt to remove directory_file_system and meta_file_system modules.
|
|
NCCH: Updated LoadExec to use Memory::WriteBlock function to load binary code.
|
|
|
|
|
|
|
|
|
|
Loader: Added ErrorNotUsed ReturnStatus type to specify when something is not used.
|
|
- Various cleanups/refactorings to Loader, ELF, and NCCH modules.
- Added AppLoader interface to ELF and NCCH.
- Updated Qt/GLFW frontends to check AppLoader ResultStatus.
NCCH: Removed extra qualification typos.
Loader: Removed unnecessary #include's.
NCCH: Improved readability of memcmp statements.
NCCH: Added missing space.
Elf: Removed unnecessary usage of unique_ptr.
Loader: Removed unnecessary usage of unique_ptr.
|
|
|
|
|
|
|
|
|
|
|
|
NCCH: Fixed typo in printing NCCH filename.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- SVC: Added ExitThread support
- SVC: Added SignalEvent support
- Thread: Added WAITTYPE_EVENT for waiting threads for event signals
- Thread: Added support for blocking on other threads to finish (e.g. Thread::Join)
- Thread: Added debug function for printing current threads ready for execution
- Thread: Removed hack/broken thread ready state code from Kernel::Reschedule
- Mutex: Moved WaitCurrentThread from SVC to Mutex::WaitSynchronization
- Event: Added support for blocking threads on event signalling
Kernel: Added missing algorithm #include for use of std::find on non-Windows platforms.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- force kernel reschedule after svcWaitSynchronization
- fixed some bugs with passing in pointer arguments
- cleaned up some comments and log messages
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- cleaned up Kernel code a bit (moved stuff into namespace, fixed whitespace issues)
- added handle types for all different CTROS handles
|
|
|
|
|
|
|
|
Only Rect is in the namespace for now; the rest of common should be added in the future
|
|
Changed QGL version to 3,2 in order to be less restrictive, yet it should still change up to 4,1 on OSX on Qt5.
|
|
Changes for clarity of comments, removed redundant compiler flags.
|
|
|
|
|
|
- updated CreateHandle/DeleteHandle to use KernelObject's
|
|
|
|
- various cleanups
|
|
|
|
- added ResetType enum
|
|
- changed some stubbed SVCs to return unique handle names for debugging purposes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- reorganized some kernel thread functions
- added placeholder __KernelWaitThread_Synchronization function
|
|
|
|
- added KERNEL_DEFAULT_STACK_SIZE definition (0x4000)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- removed HLE::CallMCR function (was pointless)
|
|
- fixed some compiler issues with xscale_copro when porting code to Windows
- fixed some #include's
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added initial VFP code from skyeye
|
|
- added SVC structs MemoryInfo and PageInfo
|
|
|
|
|
|
|
|
|
|
- cleaned up CreateThread svc
|
|
|
|
- added __KernelSwitchToThread for enabling a thread
- added __KernelRotateThreadReadyQueue
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- fixed some logging
|
|
|
|
|
|
|
|
|
|
|
|
Less calculations + fix
|
|
|
|
|
|
|
|
- added a helper function for getting command buffer for services
- fixed bug where GSP DMA was incorrectly being done in DataSynchronizationBarrier (instead of gsp_TriggerCmdReqQueue)
|
|
|
|
|
|
|
|
- added stubbed HLE syscall functions for svc_GetResourceLimit and svc_GetResourceLimitCurrentValues
|
|
|
|
|
|
- handle RD in STREX/STREXB
|
|
- added stubs for GetResourceLimit and GetResourceLimitCurrentValues SVCs
|
|
|
|
|
|
|
|
- moved instruction decoding to coprocessor HLE module
|
|
|
|
|
|
- added stub for SVC CreateAddressArbiter
- added OutputDebugString SVC
|
|
|
|
|
|
- updated load launcher.dat function to use ARM11 format hack
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Somewhere along the line an OSX header had already taken the name Rect.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added hooks to catch LCD IO read/writes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added shared memory region
- moarrrr cleanups to memory_map
|
|
|
|
|
|
- added option to create/delete service handles
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- fixed log message wording in hle.cpp
- added syscall stubs for CloseHandle and WaitSynchronization1
|
|
- various cleanups/refactors to HLE services
|
|
|
|
|
|
|
|
- added function tables for service calls
- lots of refactoring
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added a manager for keeping track of services/ports
- added a memory mapped region for memory accessed by HLE
- added HLE for GetThreadCommandBuffer function
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added service.h as an initial service interface
|
|
|
|
|
|
Doing this from work via GitHub - Sorry for not combining with previous commits
|
|
Doing this from work via GitHub - Sorry for not combining with previous commits
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- added hle.cpp and module registration
- removed unused code
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- cleaned up window title
- cleaned up emu_window_glfw/emu_window
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- updated code style/naming conventions
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
- cleaned up core.cpp a bit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
-moved scratchpad memory out of MemArena
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
