summaryrefslogtreecommitdiffstats
path: root/src (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-01-11core: hle: Integrate new KConditionVariable and KAddressArbiter implementations.bunnei15-1182/+508
2021-01-11core: hle: kernel: Update KAddressArbiter.bunnei3-0/+437
2021-01-11core: hle: kernel: Update KConditionVariable.bunnei4-0/+413
2021-01-11core: hle: kernel: Begin moving common SVC defintions to its own header.bunnei2-0/+14
2021-01-11hle: kernel: Remove unnecessary AddressArbiter definition.bunnei1-1/+0
2021-01-11common: common_funcs: Add R_UNLESS macro.bunnei1-0/+8
2021-01-11hle: kernel: k_scheduler: Cleanup OnThreadPriorityChanged.bunnei2-6/+3
2021-01-11hle: kernel: Rename thread "status" to "state".bunnei1-2/+2
2021-01-11hle: kernel: thread: Replace ThreadStatus/ThreadSchedStatus with a single ThreadState.bunnei12-172/+111
- This is how the real kernel works, and is more accurate and simpler.
2021-01-11core: hle: kernel: Add some useful functions for checking kernel addresses.bunnei1-0/+19
2021-01-11core: hle: kernel: svc_types: Add type definitions for KAddressArbiter.bunnei1-0/+12
2021-01-11common: Introduce useful tree structures.bunnei4-0/+1641
2021-01-11core: hle: kernel: Update KSynchronizationObject.bunnei33-621/+397
2021-01-11core: hle: kernel: Begin moving common SVC results to its own header.bunnei2-0/+21
2021-01-11hle: service: nfp: Remove incorrect signaling behavior in GetDeviceState.bunnei1-6/+0
2021-01-10config: Enable docked mode by defaultMorph5-6/+6
2021-01-10cmake: Enforce C4101Morph1-0/+1
This matches GCC's -Wunused-variable
2021-01-10yuzu_cmd: Silence unreferenced local variable warningMorph1-2/+0
2021-01-09general: Resolve C4062 warnings on MSVCMorph2-0/+4
2021-01-09common/div_ceil: Return numerator typeReinUsesLisp1-5/+5
Fixes instances where DivCeil(u32, u64) would surprisingly return u64, instead of the more natural u32.
2021-01-09cmake: Enforce C4062, C4265, C4388, and C5038ReinUsesLisp1-0/+4
This should match some warnings we treat as errors on gcc and clang, caching bugs early and reducing the number of instances where we have to edit commits to make CI happy when developing from Windows.
2021-01-09file_sys/registered_cache: Silence virtual functions without override warningsReinUsesLisp1-4/+4
2021-01-09core: Silence unhandled enum in switch warningsReinUsesLisp2-10/+5
2021-01-09tests/ring_buffer: Silence signed/unsigned mismatch warningsReinUsesLisp1-15/+15
2021-01-08Stub IsCpuOverclockEnabledgerman2-1/+10
2021-01-07remove inaccurate referenceAmeer J1-1/+1
Co-authored-by: LC <mathew1800@gmail.com>
2021-01-07fix for nvdec disabled, cleanup host1xameerj3-72/+23
2021-01-07nvdec syncpt incorporationameerj11-37/+59
laying the groundwork for async gpu, although this does not fully implement async nvdec operations
2021-01-07vulkan_library: Common::DynamicLibrary::Open is [[nodiscard]]MerryMage1-1/+1
Ignore the return value on __APPLE__ systems as well
2021-01-07texture_cache: Replace PAGE_SHIFT with PAGE_BITSMerryMage1-6/+6
PAGE_SHIFT is a #define in system headers that leaks into user code on some systems
2021-01-05core: Enforce C4715 (not all control paths return a value)ReinUsesLisp1-0/+2
2021-01-05core: Silence warnings when compiling without assertsReinUsesLisp5-8/+11
2021-01-04vk_rasterizer: Skip binding empty descriptor sets on computeReinUsesLisp1-2/+4
Fixes unit tests where compute shaders had no descriptors in the set, making Vulkan drivers crash when binding an empty set.
2021-01-04buffer_queue: Protect queue_sequence list access with a mutexameerj2-13/+21
fixes a data race as this is an unprotected variable manipulated by multiple threads
2021-01-04vulkan_device: Allow creating a device without surfaceReinUsesLisp1-3/+3
2021-01-04renderer_vulkan/nsight_aftermath_tracker: Move to vulkan_commonReinUsesLisp5-30/+21
2021-01-04renderer_vulkan: Move device abstraction to vulkan_commonReinUsesLisp29-29/+31
2021-01-04gl_texture_cache: Avoid format views on Intel and AMDReinUsesLisp11-21/+48
Intel and AMD proprietary drivers are incapable of rendering to texture views of different formats than the original texture. Avoid creating these at a cache level. This will consume more memory, emulating them with copies.
2021-01-04gl_texture_cache: Create base images with sRGBReinUsesLisp2-99/+100
This breaks accelerated decoders trying to imageStore into images with sRGB. The decoders are currently disabled so this won't cause issues at runtime.
2021-01-03renderer_vulkan: Rename VKDevice to DeviceReinUsesLisp52-169/+166
The "VK" prefix predates the "Vulkan" namespace. It was carried around the codebase for consistency. "VKDevice" currently is a bad alias with "VkDevice" (only an upcase character of difference) that can cause confusion. Rename all instances of it.
2021-01-03main: Resolve error string not displayingLioncash3-2/+8
During the transition to make the error dialog translatable, I accidentally got rid of the conversion to ResultStatus, which prevented operator<< from being invoked during formatting. This adds a function to directly retrieve the result status string instead so that it displays again.
2021-01-03hle: service: nvflinger: buffer_queue: Do not reset id/layer_id on Connect.bunnei1-2/+0
- This behavior is a mistake, fixes Katana Zero.
2021-01-02dynarmic: Add Unsafe_InaccurateNaN optimizationMerryMage6-0/+26
2021-01-02general: Fix various spelling errorsMorph20-43/+43
2021-01-01typo fixTimotej Leginus1-1/+1
typo fix
2021-01-01configure_input: Modify controller connection delayMorph4-12/+47
Increases the controller connection delay to 60ms and refactors it to attempt to disconnect all controllers prior to connecting all controllers in HID.
2021-01-01memory: Remove MemoryHookMerryMage9-382/+0
2020-12-31yuzu/main: fix mouse not showing on move and port citra-emu/citra#5476gal204-19/+24
2020-12-31main: Make the loader error dialog fully translatableLioncash1-8/+12
Makes the dialog fully localizable and also adds disambiguation comments to help translators understand what the formatting specifiers indicate.
2020-12-31main: Tidy up enum comparisonLioncash1-2/+1
enum classes are comparable with one another, so these casts aren't necessary.
2020-12-31vulkan_instance: Allow different Vulkan versions and enforce 1.1ReinUsesLisp7-41/+39
For listing the available physical devices we can use Vulkan 1.0. Now that MoltenVK supports 1.1 we can require it for running games. Add missing documentation.
2020-12-31vk_device: Use an array to report lacking device limitsReinUsesLisp1-13/+17
This makes easier to add and tune the required device limits.
2020-12-31vk_device: Stop initialization when device is not suitableReinUsesLisp2-61/+39
VKDevice::IsSuitable was not being called. To address this issue, check suitability before initialization and throw an exception if it fails. By doing this, we can deduplicate some code on queue searches. Previosuly we would first search if a present and graphics queue existed, then on initialization we would search again to find the index.
2020-12-31renderer_vulkan: Remove two step initialization on VKDeviceReinUsesLisp6-31/+10
The Vulkan device abstraction either initializes successfully on the constructor or throws a Vulkan exception.
2020-12-31renderer_vulkan: Throw when enumerating devices failsReinUsesLisp5-33/+21
Report device enumeration errors with exceptions to be consistent with other initialization related function calls. Reduces the amount of code to maintain.
2020-12-31renderer_vulkan: Initialize surface in separate fileReinUsesLisp6-73/+109
Move surface initialization code to a separate file. It's unlikely to use this code outside of Vulkan, but keeping platform-specific code (Win32, Xlib, Wayland) in its own translation unit keeps things cleaner.
2020-12-31renderer_vulkan: Catch and report exceptionsReinUsesLisp1-2/+5
Move more Vulkan code to report errors with exceptions and report them through a log before notifying it with an error boolean for backwards compatibility. In the future we can replace the rasterizer two-step initialization to always use exceptions.
2020-12-31renderer_vulkan: Create debug callback on separate file and throwReinUsesLisp8-79/+88
Initialize debug callbacks (messenger) from a separate file. This allows sharing code with different backends. Change our Vulkan error handling to use exceptions instead of error codes, simplifying the initialization process.
2020-12-31renderer_vulkan: Move instance initialization to a separate fileReinUsesLisp4-111/+176
Simplify Vulkan's backend initialization code by moving it to a separate file, allowing us to initialize a Vulkan instance from different backends.
2020-12-31vulkan_common: Rename renderer_vulkan/wrapper.h to vulkan_common/vulkan_wrapper.hReinUsesLisp51-51/+51
Allows sharing Vulkan wrapper code between different rendering backends.
2020-12-31vulkan_common: Move dynamic library load to a separate fileReinUsesLisp4-31/+59
Allows us to initialize a Vulkan dynamic library from different backends without duplicating code.
2020-12-31Port citra-emu/citra#5509german1-2/+45
2020-12-31Make the coding conventions more consistant16-Bit-Dog1-1/+1
lut_index had 0 added when nothing was supposed to be added despite this, index was not added to 0 when nothing was supposed to be added...
2020-12-30half_set: Resolve -Wmaybe-uninitialized warningsLioncash1-7/+7
2020-12-30maxwell_to_vk: Initialize usage variable in SurfaceFormat()Lioncash1-1/+1
Silences a -Wmaybe-uninitialized warning
2020-12-30video_core: Rewrite the texture cacheReinUsesLisp152-8101/+10359
The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage.The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage. This commit aims to address those issues.
2020-12-30cmake: Enforce -WuninitializedReinUsesLisp1-0/+1
2020-12-30service/pcie: Fix invalid initialization argumentReinUsesLisp1-1/+1
2020-12-30video_core: Add a delayed destruction ring abstractionReinUsesLisp2-0/+33
2020-12-30host_shaders: Add Vulkan assembler compute shadersReinUsesLisp4-0/+96
2020-12-30host_shaders: Add helper to blit depth stencil fragment shaderReinUsesLisp2-0/+17
2020-12-30host_shaders: Add texture color blit fragment shaderReinUsesLisp2-0/+15
2020-12-30host_shaders: Add shaders to present to the swapchainReinUsesLisp3-0/+36
2020-12-30host_shaders: Add shaders to convert between depth and color imagesReinUsesLisp3-0/+28
2020-12-30host_shaders: Add compute shader to copy BC4 as RG32UI to RGBA8ReinUsesLisp2-0/+71
2020-12-30host_shaders: Add shader to render a full screen triangleReinUsesLisp2-0/+30
2020-12-30host_shaders: Add pitch linear upload compute shaderReinUsesLisp2-0/+87
2020-12-30host_shaders: Add block linear upload compute shadersReinUsesLisp3-0/+249
2020-12-30host_shaders: Add copyright headers to OpenGL present shadersReinUsesLisp2-0/+8
2020-12-30video_core/host_shaders: Add support for prebuilt SPIR-V shadersReinUsesLisp1-16/+37
Add support for building SPIR-V shaders from GLSL and generating headers to include the text of those same GLSL shaders to consume from OpenGL.
2020-12-30core/memory: Read and write page table atomicallyReinUsesLisp7-147/+132
Squash attributes into the pointer's integer, making them an uintptr_t pair containing 2 bits at the bottom and then the pointer. These bits are currently unused thanks to alignment requirements. Configure Dynarmic to mask out these bits on pointer reads. While we are at it, remove some unused attributes carried over from Citra. Read/Write and other hot functions use a two step unpacking process that is less readable to stop MSVC from emitting an extra AND instruction in the hot path: mov rdi,rcx shr rdx,0Ch mov r8,qword ptr [rax+8] mov rax,qword ptr [r8+rdx*8] mov rdx,rax -and al,3 and rdx,0FFFFFFFFFFFFFFFCh je Core::Memory::Memory::Impl::Read<unsigned char> mov rax,qword ptr [vaddr] movzx eax,byte ptr [rdx+rax]
2020-12-30hle: kernel: service_thread: Make thread naming more consistent.bunnei1-1/+1
2020-12-30hle: kernel: Manage service threads on another thread.bunnei1-9/+20
- This is to allow service threads to defer destruction of themselves.
2020-12-30common: ThreadWorker: Add class to help do asynchronous work.bunnei3-0/+90
2020-12-30hle: kernel: Manage host thread IDs using TLS.bunnei1-46/+31
- Avoids the need to have a large map of host to guest thread IDs.
2020-12-29k_priority_queue: Fix concepts usecomex2-3/+9
- For `std::same_as`, add missing include of `<concepts>`. - For `std::convertible_to`, create a replacement in `common/concepts.h` and use that instead. This would also be found in `<concepts>`, but unlike `std::same_as`, `std::convertible_to` is not yet implemented in libc++, LLVM's STL implementation - not even in master. (In fact, `std::same_as` is the *only* concept currently implemented. For some reason.)
2020-12-29Add missing include of "core/hle/kernel/kernel.h"comex1-0/+1
This is needed as the header invokes methods on KernelCore.
2020-12-29svc: demote SleepThread log to LOG_TRACEameerj1-1/+1
This log is called often, and introduces a lot of noise when debug logging is enabled, making it difficult to see other debug logs.
2020-12-29hle: kernel: Move ServiceThread ownership to KernelCore.bunnei4-5/+48
- Fixes a circular dependency which prevented threads from being released on shutdown.
2020-12-29hle: kernel: service_thread: Add thread name and take weak_ptr of ServerSession.bunnei3-11/+22
2020-12-29hle: service: Acquire and release a lock on requests.bunnei7-40/+41
- This makes it such that we can safely access service members from CoreTiming thread.
2020-12-29audio_core: stream: Ensure buffer is valid before release.bunnei1-2/+10
2020-12-29core: Do not reset device_memory on shutdown.bunnei1-1/+0
- This will be reset on initialization.
2020-12-29core: hle: kernel: Clear process list on boot.bunnei1-2/+2
2020-12-29gpu: gpu_thread: Ensure MicroProfile is shutdown on exit.bunnei1-0/+3
2020-12-29hle: service: vi: Refactor to grab buffer only once.bunnei1-15/+4
2020-12-29service: nvflinger: Improve synchronization for BufferQueue.bunnei5-19/+72
- Use proper mechanisms for blocking on DequeueBuffer. - Ensure service thread terminates on emulation Shutdown.
2020-12-29hle: service: Ensure system is powered on before writing IPC result.bunnei1-1/+5
2020-12-29core: kernel: Clear process list earlier.bunnei1-2/+2
2020-12-29video_core: gpu_thread: Do not wait when system is powered down.bunnei1-1/+2
2020-12-29core: settings: Untangle multicore from asynchronous GPU.bunnei5-21/+4
- Now that GPU is always threaded, we can support multicore with synchronous GPU.
2020-12-29video_core: gpu: Implement synchronous mode using threaded GPU.bunnei4-12/+34
2020-12-29video_core: gpu: Refactor out synchronous/asynchronous GPU implementations.bunnei10-289/+130
- We must always use a GPU thread now, even with synchronous GPU.
2020-12-29hle: kernel: hle_ipc: Remove SleepClientThread.bunnei2-54/+0
- This was kind of hacky, and no longer is necessary with service threads.
2020-12-29hle: service: bsd: Update to work with service threads, removing SleepClientThread.bunnei4-250/+45
2020-12-29hle: service: nvdrv: Revert #4981 to remove usage of SleepClientThread.bunnei23-211/+83
- Note, this always processes the ioctl right away, which fixes BotW 1.0.0 issues.
2020-12-29hle: kernel: service_thread: Add parameter for thread pool size.bunnei3-7/+7
2020-12-29hle: service: nvflinger: Refactor locking and interfaces.bunnei3-45/+31
2020-12-29hle: service: vi: Remove usage of SleepClientThread.bunnei1-34/+43
2020-12-29core: hle: server_session: Use separate threads for each service connection.bunnei6-23/+140
2020-12-27udp client: process packets only for the correct padgal201-0/+5
2020-12-27Allow to invert analog axis with right clickgerman4-65/+99
2020-12-26renderer_vulkan/fixed_pipeline_state: Move enabled bindings to static stateReinUsesLisp3-26/+12
Without using VK_EXT_robustness2, we can't consider the 'enabled' (not null) vertex buffers as dynamic state, as this leads to invalid Vulkan state. Move this to static state that is always hashed and compared in the pipeline key. The bits for enabled vertex buffers are moved into the attribute state bitfield. This is not 'correct' as it's not an attribute state, but that struct has bits to spare, and it's used in an array of 32 elements (the exact same number of vertex buffer bindings).
2020-12-25yuzu/main: Add basic command line argumentsMorph1-3/+39
The following command line arguments are supported: yuzu.exe "path_to_game" - Launches a game at "path_to_game" yuzu.exe -f - Launches the next game in fullscreen yuzu.exe -g "path_to_game" - Launches a game at "path_to_game" yuzu.exe -f -g "path_to_game" - Launches a game at "path_to_game" in fullscreen
2020-12-25core: memory: Ensure thread safe access when pages are rasterizer cached (#5206)bunnei1-12/+40
* core: memory: Ensure thread safe access when pages are rasterizer cached.
2020-12-25cmake: Always enable VulkanReinUsesLisp8-133/+75
Removes the unnecesary burden of maintaining separate #ifdef paths and allows us sharing generic Vulkan code across APIs.
2020-12-25video_core: Enforce C4715 (not all control paths return a value)ReinUsesLisp1-0/+1
Most of the time people write code that always returns a value, terminates execution, throws an exception, or uses an unconventional jump primitive. This is not always true when we build without asserts on mainline builds. To avoid introducing undefined behavior on our most used builds, enforce this warning signalling an error and stopping the build from shipping.
2020-12-25vk_shader_decompiler: Silence warning when compiling without assertsReinUsesLisp1-0/+1
2020-12-23yuzu/main: Improve menubar access keyslat9nq4-38/+38
Adds a unique access key to each action within each menu. A few actions already had their own access key, so those were untouched.
2020-12-23Add option to reset window size to 1080pgerman3-6/+30
2020-12-22yuzu/main: Save settings when starting guestlat9nq2-16/+25
Saves UISettings and Settings when booting a guest. Moves updating UISettings::values from GMainWindow::closeEvent into its own function, then reuses it in GMainWindow::BootGame.
2020-12-19yuzu: Remove gdbstub configurationFearlessTobi9-110/+7
The gdbstub itself was removed with https://github.com/yuzu-emu/yuzu/pull/5028. This PR just removes the remaining gdb configuration code from the emulator and the UI.
2020-12-18applets/web: Implement the online web browser appletMorph8-64/+167
2020-12-18applets/web: Fix keyboard to emulated controller inputMorph3-4/+30
2020-12-18main: Add the ability to disable the web appletMorph2-0/+27
This should only be used for Super Mario 3D All-Stars. This is a temporary solution until it can be implemented properly.
2020-12-18main, applets/web: Re-add progress dialog for RomFS extractionMorph8-68/+125
2020-12-18applets/web: Implement the Qt web browser applet frontendMorph4-5/+600
2020-12-18web_browser_scripts: Add injection scripts for the web browserMorph1-0/+193
2020-12-18pl_u, applets/web: Decrypt shared fonts to TTF filesMorph3-18/+117
2020-12-18ns_vm: Stub NeedsUpdateVulnerabilityMorph1-1/+10
This is used to force system updates on launching the web browser. We do not care about system updates so this can be set to false.
2020-12-18frontend/input_interpreter: Add InputInterpreter APIMorph3-0/+167
The InputInterpreter class interfaces with HID to retrieve button press states. Input is intended to be polled every 50ms so that a button is considered to be held down after 400ms has elapsed since the initial button press and subsequent repeated presses occur every 50ms. Co-authored-by: Chloe <25727384+ogniK5377@users.noreply.github.com>
2020-12-18controllers/npad: Make press_state atomicMorph2-2/+3
2020-12-18util: Add URL Request Interceptor for QWebEngineMorph3-0/+64
2020-12-18bootmanager: Add a check whether loading is completeMorph2-0/+6
2020-12-18applets/web: Implement the default web browser applet frontendMorph3-1/+24
2020-12-18applets/web: Implement the offline browser applet backendMorph2-13/+143
2020-12-18applets/web: Initial implementation of the web browser appletMorph3-2/+428
2020-12-18applets: Remove the previous web browser applet implementationMorph12-1039/+40
2020-12-18system_archive: Add + and - buttons to the Nintendo Extended OSS fontMorph2-315/+343
2020-12-18buffer_queue: better use of std::arrayameerj1-59/+46
2020-12-17Overwrite slots instead of queuing them, add disconnect signalameerj3-27/+33
Fix for Katana Zero and Yoshi's Crafted World
2020-12-17system_archive: Update Nintendo Extended OSS fontMorph2-182/+347
Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-12-13cmake: Fix generating CMake configs and linking with Boostlat9nq1-1/+1
Fixes regression by 761206cf81b271f7f4dd6a167a120325b760dbf3, causing yuzu to not build on Linux with any version of Boost except a cached 1.73 Conan version from before about a day ago. Moves the Boost requirement out of the `REQUIRED_LIBS` psuedo-2D-array for Conan to instead be manually configured, using Conan as a fallback solution if the system does not meet our requirements. Requires any update from the linux-fresh container in order to build. **DO NOT MERGE** until someone with the MSVC toolchain can verify this works there, too.
2020-12-12common: Update CMakeList to fix build issue with Boost.bunnei1-2/+1
2020-12-12controllers/npad: Validate device handles before useMorph2-0/+45
Some games such as NEKOPARA Vol. 3 send invalid device handles when calling InitializeVibrationDevice. Introduce a check to validate the device handle before use.
2020-12-12Revert "Merge pull request #5173 from lioncash/common-fs"Morph2-112/+396
This reverts commit ce5fcb6bb2c358b0251a2ce87945bda52789a76d, reversing changes made to 6f41763061082d5fa2ab039c554427152243cb46.
2020-12-12Revert "Merge pull request #5174 from ReinUsesLisp/fs-fix"Morph2-36/+4
This reverts commit 5fe55b16a11d9ec607fb8a3fdddc77a4393cd96a, reversing changes made to e94dd7e2c4fc3f7ca2c15c01bdc301be2b8a4c1b.
2020-12-12Revert "Merge pull request #5176 from Morph1984/fix-createfile"Morph1-6/+2
This reverts commit 6d6115475b4edccdf1bb4e96ecc3d3b1be319e76, reversing changes made to 5fe55b16a11d9ec607fb8a3fdddc77a4393cd96a.
2020-12-12Revert "Merge pull request #5179 from ReinUsesLisp/fs-path"Morph1-1/+1
This reverts commit 4e94d0d53af2cdb7b03ef9de23cc29f3565df97a, reversing changes made to 6d6115475b4edccdf1bb4e96ecc3d3b1be319e76.
2020-12-12Revert "Merge pull request #5181 from Morph1984/5174-review"Morph1-3/+9
This reverts commit cdb36aef9ec9d30bdef1953f9ed46776ae2f12af, reversing changes made to 5e9b77129f2cf8c039a8d98033cae4ac0f93f515.
2020-12-10vfs: Use existing type aliases consistentlyLioncash28-136/+142
Makes use of the VirtualDir and VirtualFile aliases across the board instead of having a few isolated places that don't use it.
2020-12-10common/file_util: Simplify the behavior of CreateFullPathMorph1-9/+3
2020-12-09common/file_util: Let std::filesystem cast from UTF16 to std::stringReinUsesLisp1-1/+1
Fix invalid encoding paths when iterating over a directory on Windows.
2020-12-09vfs_real: Fix CreateFile for files without a file extensionMorph1-2/+6
2020-12-09common/file_util: Fix and deprecate CreateFullPath, add CreateDirsReinUsesLisp2-4/+31
Fix CreateFullPath to have its intended previous behavior (whatever that was), and deprecate it in favor of the new CreateDirs function. Unlike CreateDir, CreateDirs is marked as [[nodiscard]] to avoid new code ignoring its result value.
2020-12-09common/file_util: Succeed on CreateDir when the directory existsReinUsesLisp1-0/+5
2020-12-09file_util: Migrate remaining file handling functions over to std::filesystemLioncash2-340/+100
Converts creation and deletion functions over to std::filesystem, simplifying our file-handling code. Notably with this, CopyDir will now function on Windows.
2020-12-09file_util: Migrate Exists() and IsDirectory() over to std::filesystemLioncash2-57/+13
Greatly simplifies our file-handling code for these functions.
2020-12-08svc: Remove unnecessary castsLioncash1-35/+25
Simplifies and removes some casts. In all cases, these were generally widening from a 32-bit unsigned type to a 64-bit unsigned type, so no information would be lost from the conversion.
2020-12-08IPurchaseEventManager: Implement GetPurchasedEventReadableHandleMorph1-1/+14
- Used by Pokémon Café Mix - Used by DOOM: Eternal
2020-12-08IPurchaseEventManager: Stub Set(Default)DeliveryTargetMorph1-2/+27
- Used by Pokémon Café Mix - Used by DOOM: Eternal
2020-12-08aoc_u: Stub Create(Permanent)EcPurchasedEventManagerMorph2-2/+38
- Used by Pokémon Café Mix - Used by DOOM: Eternal
2020-12-08memory: Resolve -Wdocumentation warning for Write()Lioncash1-2/+0
Write() doesn't return anything, so the @returns tag shouldn't be present.
2020-12-08fsp_srv: Implement OpenDataStorageWithProgramIndexMorph6-1/+83
- Used by RollerCoaster Tycoon 3: Complete Edition
2020-12-08file_sys: Consolidate common Title ID operationsMorph5-13/+67
2020-12-08core: Remove unnecessary enum casts in log callsLioncash25-96/+90
Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
2020-12-08controller: Use std::move within ConvertToFrontendParameters()Lioncash1-3/+3
Avoids unnecessary copies.
2020-12-08controller: Avoid unnecessary copies in ConfigurationComplete()Lioncash1-9/+8
Avoids unnecessary 1072 byte copies when querying info about controllers.
2020-12-08Disable analog joystick from buttons by defaultgerman5-10/+52
2020-12-07video_core: Make use of ordered container contains() where applicableLioncash8-16/+13
With C++20, we can use the more concise contains() member function instead of comparing the result of the find() call with the end iterator.
2020-12-07ast: Improve string concat readability in operator()Lioncash1-5/+4
Provides an in-place format string to make it more pleasant to read.
2020-12-07gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()Lioncash1-1/+1
Resolves a -Wrange-loop-analysis warning.
2020-12-07buffer_block: Mark interface as nodiscard where applicableLioncash1-7/+7
Prevents logic errors from occurring from unused values.
2020-12-07buffer_block: Remove unnecessary includesLioncash1-5/+0
Reduces the amount of dependencies the header pulls in.
2020-12-07shader_ir: std::move node within DeclareAmend()Lioncash1-2/+2
Same behavior, but elides an unnecessary atomic reference count increment and decrement.
2020-12-07video_core: Remove unnecessary enum class casting in logging messagesLioncash33-148/+125
fmt now automatically prints the numeric value of an enum class member by default, so we don't need to use casts any more. Reduces the line noise a bit.
2020-12-07maxwell_3d: Move member variables to end of classLioncash1-31/+32
Follows our established coding style.
2020-12-07maxwell_3d: Resolve -Wdocumentation warningLioncash1-1/+1
Removes a documentation comment for a non-existent member.
2020-12-07maxwell_3d: Remove unused dirty_pointer arrayLioncash1-2/+0
This is unused and removing it shrinks the structure by 3584 bytes.
2020-12-07configure_motion_touch: Fix unescaped backslash in regexcomex1-2/+2
Since this is inside a string literal, backslashes that are part of regex syntax have to be escaped. But that's ugly, so convert to a raw string instead.
2020-12-07network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`comex6-71/+82
Actually, two enum classes, since for some reason there are two separate yet identical `PollFD` types used in the codebase. I get that one is ABI-compatible with the Switch while the other is an abstract type used for the host, but why not use `WSAPOLLFD` directly for the latter? Anyway, why make this change? Because on Apple platforms, `POLL_IN`, `POLL_OUT`, etc. (with an underscore) are defined as macros in <sys/signal.h>. (This is inherited from FreeBSD.) So defining a variable with the same name causes a compile error. I could just rename the variables, but while I was at it I thought I might as well switch to an enum for stronger typing. Also, change the type used for values copied directly to/from the `events` and `revents` fields of the host *native* `pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct canonical type on both Unix and Windows.
2020-12-07Fix "explicitly defaulted but implicitly deleted" warningcomex1-1/+1
`PhysicalCore`'s move assignment operator was declared as `= default`, but was implicitly deleted because `PhysicalCore` has fields of reference type. Switch to explicitly deleting it to avoid a Clang warning. The move *constructor* is still defaulted, and is required to exist due to the use of `std::vector<PhysicalCore>`.
2020-12-07hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cppcomex2-34/+37
- Add a type check so that calling Push with an invalid type produces a compile error rather than a linker error. - vi.cpp was calling Push with a variable of type `std::size_t`. There's no explicit overload for `size_t`, but there is one for `u64`, which on most platforms is the same type as `size_t`. On macOS, however, it isn't: both types are 64 bits, but `size_t` is `unsigned long` and `u64` is `unsigned long long`. Regardless, it makes more sense to explicitly use `u64` here instead of `size_t`.
2020-12-07CMakeLists,network: Create YUZU_UNIX macro to replace __unix__comex2-5/+5
__unix__ is not predefined on Apple platforms even though they are Unix.
2020-12-07renderer_vulkan: Add missing `override` specifiercomex1-1/+1
2020-12-07map_interval: Change field order to address uninitialized field warningcomex1-1/+2
Clang complains about `new_chunk`'s constructor using the then-uninitialized `first_chunk` (even though it's just to get a pointer into it).
2020-12-07core: Mark unused fields as [[maybe_unused]]comex2-3/+3
2020-12-07boxcat: Avoid unnecessary object copycomex1-1/+1
2020-12-07nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclasscomex1-33/+0
2020-12-07video_core: Adjust `NUM` macro to avoid Clang warningcomex3-3/+3
The previous definition was: #define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32)) In cases where `field_name` happens to refer to an array, Clang thinks `sizeof(an array value) / sizeof(a type)` is an instance of the idiom where `sizeof` is used to compute an array length. So it thinks the type in the denominator ought to be the array element type, and warns if it isn't, assuming this is a mistake. In reality, `NUM` is not used to get array lengths at all, so there is no mistake. Silence the warning by applying Clang's suggested workaround of parenthesizing the denominator.
2020-12-06hle: kernel: Process: Various style fixes based on code review feedback.bunnei1-2/+2
2020-12-06core: cpu_manager: Fix a typo in PreemptSingleCore, which broke many games.bunnei1-21/+26
- We were reload'ing the old current scheduler, which may have changed.
2020-12-06hle: kernel: Thread: Various style fixes based on code review feedback.bunnei1-22/+25
2020-12-06hle: kernel: KScopedSchedulerLockAndSleep: Various style fixes based on code review feedback.bunnei1-6/+6
2020-12-06hle: kernel: KScopedLock: Various style fixes based on code review feedback.bunnei1-6/+8
2020-12-06hle: kernel: KAbstractSchedulerLock: Various style fixes based on code review feedback.bunnei1-9/+7
2020-12-06hle: kernel: KScheduler: Various style fixes based on code review feedback.bunnei2-50/+41
2020-12-06hle: kernel: KPriorityQueue: Various style fixes based on code review feedback.bunnei1-29/+36
2020-12-06hle: kernel: KAffinityMask: Various style fixes based on code review feedback.bunnei1-17/+13
2020-12-06hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback.bunnei2-5/+10
2020-12-06common: BitSet: Various style fixes based on code review feedback.bunnei1-23/+22
2020-12-06hle: kernel: Use C++ style comments in KScheduler, etc.bunnei4-152/+136
2020-12-06kernel: KScopedSchedulerLockAndSleep: Remove unused ctor.bunnei1-13/+7
2020-12-06kernel: time_manager: Add missing lock guards.bunnei1-3/+10
2020-12-06hle: kernel: Migrate to KScopedSchedulerLock.bunnei15-48/+92
2020-12-06hle: kernel: Separate KScopedSchedulerLockAndSleep from k_scheduler.bunnei11-69/+72
2020-12-06hle: kernel: Separate KScheduler from GlobalSchedulerContext class.bunnei9-520/+140
2020-12-06hle: kernel: Rewrite scheduler implementation based on Mesopshere.bunnei26-1223/+1215
2020-12-06hle: kernel: physical_core: Clear exclusive state after each run.bunnei3-0/+7
- This is closer to pre-multicore behavior, and works a bit better.
2020-12-06hle: kernel: Port KAbstractSchedulerLock from Mesosphere.bunnei2-0/+77
2020-12-06hle: kernel: svc: Remove reschedule on svcBreak.bunnei1-5/+0
- This breaks things, and is unnecessary, since emulation will be done at this point.
2020-12-06hle: kernel: process: Add schedule count tracking, to be used for yield impl.bunnei1-0/+13
2020-12-06hle: kernel: svc: Remove unnecessary hack in svcSleep.bunnei1-7/+0
2020-12-06common: Port KPriorityQueue from Mesosphere.bunnei2-0/+444
2020-12-06common: Port BitSet from Mesosphere.bunnei2-0/+101
2020-12-06hle: kernel: Port KAffinityMask from Mesosphere.bunnei7-16/+80
2020-12-05maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflictcomex1-5/+7
On Apple platforms, FALSE and TRUE are defined as macros by <mach/boolean.h>, which is included by various system headers. Note that there appear to be no actual users of the names to fix up.
2020-12-05yuzu_cmd: Remove 'users_size'comex1-1/+0
Specifically: const auto size = sdl2_config->GetInteger("System", "users_size", 0); The variable is never used, producing a warning. I wondered if this ought to be assigning something to in `Settings`, but nothing else in the codebase ever mentions a setting called "users_size", so I guess it's safe to remove...
2020-12-05Update cubeb and request a persistent stream sessionVitor Kiguchi1-0/+1
2020-12-05video_core: Resolve more variable shadowing scenarios pt.3Lioncash49-292/+305
Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.
2020-12-05game_list_p: Resolve deprecated usage of QVariant operator<Lioncash1-1/+2
This is designated as obsolete in Qt's docs (see: https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt)
2020-12-05applets: Resolve variable shadowingMorph10-19/+19
2020-12-05video_core: Resolve more variable shadowing scenarios pt.2Lioncash39-296/+305
Migrates the video core code closer to enabling variable shadowing warnings as errors. This primarily sorts out shadowing occurrences within the Vulkan code.
2020-12-05xbyak_abi: Shorten std::size_t to size_tLioncash1-8/+8
Makes for less reading.
2020-12-05xbyak_abi: Avoid implicit sign conversionsLioncash1-2/+2
2020-12-05system_version: Update to 11.0.0Chloe Marcec1-6/+6
2020-12-05Fix telemetry-related exit crash from use-after-freeFearlessTobi1-3/+3
Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>
2020-12-04codec: Remove deprecated usage of AVCodecContext::refcounted_framesLioncash1-1/+0
This was only necessary for use with the avcodec_decode_video2/avcoded_decode_audio4 APIs which are also deprecated. Given we use avcodec_send_packet/avcodec_receive_frame, this isn't necessary, this is even indicated directly within the FFmpeg API changes document here on 2017-09-26: https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410 This prevents our code from breaking whenever we update to a newer version of FFmpeg in the future if they ever decide to fully remove this API member.
2020-12-04video_core: Resolve more variable shadowing scenariosLioncash42-206/+219
Resolves variable shadowing scenarios up to the end of the OpenGL code to make it nicer to review. The rest will be resolved in a following commit.
2020-12-04nim: Stub IsLargeResourceAvailableMorph1-1/+13
- Used by Immortals Fenyx Rising
2020-12-03node: Mark member functions as [[nodiscard]] where applicableLioncash1-29/+29
Prevents logic bugs from accidentally ignoring the return value.
2020-12-03node: Eliminate variable shadowingLioncash1-47/+49
2020-12-03vp9/vic: Resolve pessimizing movesLioncash2-11/+11
Removes the usage of moves that don't result in behavior different from a copy, or otherwise would prevent copy elision from occurring.
2020-12-03mouse_poller: Remove unused includesLioncash1-3/+1
2020-12-03mouse_input: Invert conditional in UpdateYuzuSettings()Lioncash1-4/+6
Allows the struct to be constructed in place.
2020-12-03mouse_input: Remove two casts and amend some formattingLioncash1-11/+14
Removes the use of two static casts and improves the readability of some vectors slightly.
2020-12-03mouse_input: Resolve a -Wdocumentation warningLioncash1-1/+1
2020-12-03mouse_input: Remove unused includesLioncash2-7/+3
2020-12-03audio_core: Make shadowing and unused parameters errorsLioncash29-154/+163
Moves the audio code closer to enabling warnings as errors in general.
2020-12-01Fix implicit conversion in mouse inputgerman1-6/+8
2020-11-30Disable web applet and warning when compiling for Linux on CIlat9nq1-0/+2
yuzu's web applet does not or barely reacts to user input while open in Linux. It can be closed via 'Exit Web Applet' on the menubar, however if yuzu is in fullscreen, this is effectively a softlock as the menubar cannot be accessed. This disables building yuzu with the web applet on the Linux CI target. In addition, this disables the QMessageBox warning about not having compiled yuzu with the web applet.
2020-11-29kernel: scheduler: Minor cleanup to remove duplicated code.bunnei2-46/+14
2020-11-29kernel: time_manager: Protect access with a mutex.bunnei2-1/+5
2020-11-29common: fiber: Use VirtualBuffer for stack memory.bunnei1-2/+5
- This will be aligned by default, and helps memory usage.
2020-11-29hle: kernel: thread: Remove unused "Running" state.bunnei3-21/+9
2020-11-29core: arm: Implement InvalidateCacheRange for CPU cache invalidation.bunnei12-16/+56
2020-11-29hle: kernel: time_manager: Avoid a crash on process exit.bunnei1-1/+4
2020-11-29hle: kernel: AddressArbiter: Remove unused code.bunnei2-9/+0
2020-11-29hle: kernel: SynchronizationObject: Use atomic_bool for is_signaled.bunnei1-1/+2
2020-11-29common: fiber: Use boost::context instead of native fibers on Windows.bunnei3-116/+9
2020-11-29hle: kernel: multicore: Replace n-JITs impl. with 4 JITs.bunnei15-72/+124
2020-11-29Add missing types to NpadCommunicationModegerman1-0/+2
2020-11-28audio_core: Remove temp_mix_bufferChloe Marcec2-3/+1
It's unused and doesn't need to be initialized
2020-11-27CMakeLists: disable -Winvalid-offsetofcomex1-0/+1
This Clang warning complains when offsetof is used on a non-standard-layout type (i.e. any class using various C++ features), even though it works fine (and is not undefined behavior as of C++17).
2020-11-27tests: Fix warning about comparison between signed and unsignedcomex1-2/+2
2020-11-27core: Eliminate remaining usages of the global system instanceLioncash21-1593/+58
Removes all remaining usages of the global system instance. After this, migration can begin to migrate to being constructed and managed entirely by the various frontends.
2020-11-27savedata_factory: Eliminate usage of the global system instanceLioncash4-14/+22
Now there's only two meaningful instances left in core.
2020-11-27Stub set and get NpadCommunicationModegerman4-2/+50
2020-11-27service: Eliminate usages of the global system instanceLioncash222-907/+1221
Completely removes all usages of the global system instance within the services code by passing in the using system instance to the services.
2020-11-26codec: Fix `pragma GCC diagnostic pop` missing corresponding pushcomex1-0/+1
2020-11-26vk_shader_decompiler: Implement force early fragment testsReinUsesLisp6-11/+19
Force early fragment tests when the 3D method is enabled. The established pipeline cache takes care of recompiling if needed. This is implemented only on Vulkan to avoid invalidating the shader cache on OpenGL.
2020-11-26core: Reduce string copies in GetGameFileFromPath()Lioncash1-12/+22
Eliminates some minor string churn where applicable. Also eliminates an unnecessary vector copy.
2020-11-26Limit queue size to 10 framesameerj1-0/+4
Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.
2020-11-26Implement full mouse supportgerman14-277/+793
2020-11-26Add multiple udp server supportgerman10-267/+420
2020-11-26Address PR feedbackameerj4-32/+33
remove some redundant moves, make deleter match naming guidelines. Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>
2020-11-26common: Add Common::DivCeil and Common::DivCeilLog2ReinUsesLisp2-0/+27
Add an equivalent to 'Common::AlignUp(n, d) / d' and a log2 alternative.
2020-11-26input_common: ignore some Clang warnings after 5c4774e8ce1dJan Beich1-2/+2
error: unknown warning option '-Werror=unused-but-set-parameter'; did you mean '-Werror=unused-parameter'? [-Werror,-Wunknown-warning-option] error: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Werror,-Wunknown-warning-option]
2020-11-25Queue decoded frames, cleanup decodersameerj10-338/+227
2020-11-25cleanup unneeded comments and newlinesameerj1-6/+0
2020-11-25hid: Check if applet_resource exists in InitializeVibrationDeviceMorph1-2/+4
2020-11-25Refactor MaxwellToSpirvComparison. Use Common::BitCastameerj3-31/+34
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
2020-11-25Address PR feedback from Reinameerj5-40/+31
2020-11-25vulkan_renderer: Alpha Test Culling Implementationameerj5-2/+76
Used by various textures in many titles, e.g. SSBU menu.
2020-11-25core: cpu_manager: Fix shutdown crash when closing before emulation starts.bunnei1-7/+17
2020-11-25frontend: yuzu (qt): Register a callback for ExecuteProgram.bunnei4-7/+38
2020-11-25service: am: Implement ExecuteProgram and required stubs.bunnei2-3/+34
- This is used by Super Mario 3D All-Stars.
2020-11-25core: loader: Implement support for loading indexed programs.bunnei12-26/+74
2020-11-24hle: services: Fix a crash with improper NVFlinger lifetime management. (#4977)bunnei17-100/+104
* hle: services: Fix a crash with improper NVFlinger lifetime management. - This crash would happen when attempting to shutdown yuzu early on in boot.
2020-11-24nvdrv, video_core: Don't index out of bounds when given invalid syncpoint IDcomex2-13/+20
- Use .at() instead of raw indexing when dealing with untrusted indices. - For the special case of WaitFence with syncpoint id UINT32_MAX, instead of crashing, log an error and ignore. This is what I get when running Super Mario Maker 2.
2020-11-24input_common: Fix typo in gc_poller.cpp with [[maybe_unused]].bunnei1-2/+2
2020-11-24nvservices: Reintroducee IoctlCtrlChloe Marcec24-91/+214
Fixes regression caused by #4907 which caused games like Breath of the Wild 1.0.0 not to boot.
2020-11-24input_common: Add more missing [[maybe_unused]] from #4927.bunnei3-4/+6
2020-11-24Fix warnings in core/frontend/input.h with [[maybe_unused]]bunnei1-1/+3
Fixes build break due to #4927
2020-11-23Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main threadcomex10-73/+68
EmuWindow::PollEvents was called from the GPU thread (or the CPU thread in sync-GPU mode) when swapping buffers. It had three implementations: - In GRenderWindow, it didn't actually poll events, just set a flag and emit a signal to indicate that a frame was displayed. - In EmuWindow_SDL2_Hide, it did nothing. - In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong because SDL_PollEvents is supposed to be called on the thread that set up video - in this case, the main thread, which was sleeping in a busyloop (regardless of whether sync-GPU was enabled). On macOS this causes a crash. To fix this: - Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a default implementation that does nothing. - In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have the main thread call SDL_WaitEvent in a loop.
2020-11-23svc: Remove unnecessary [[maybe_unused]] tagLioncash1-1/+1
The parameter is used in this function, so this suppression isn't necessary.
2020-11-22input_common: Treat warnings as errorsLioncash8-10/+23
Migrates over warnings as errors for input common to match how the common library treats warnings as errors.
2020-11-21applets/controller: Use a pair of emulated controller index to controller typeMorph2-44/+96
2020-11-21configure_input_player: Use the npad style set to show the available controllersMorph2-55/+96
This will reduce the likelihood of an invalid controller type to be set within a game
2020-11-21gl_rasterizer: Remove warning of untested alpha testReinUsesLisp1-4/+0
Alpha test has been proven to only affect the first render target.
2020-11-20olsc: Move member initialization to after member functions.bunnei1-2/+2
2020-11-20async_shaders: emplace threads into the worker thread vectorLioncash1-2/+2
Same behavior, but constructs the threads in place instead of moving them.
2020-11-20async_shaders: Simplify implementation of GetCompletedWork()Lioncash1-2/+1
This is equivalent to moving all the contents and then clearing the vector. This avoids a redundant allocation.
2020-11-20async_shaders: Simplify moving data into the pending queueLioncash1-13/+8
2020-11-20async_shaders: std::move data within QueueVulkanShader()Lioncash1-2/+2
Same behavior, but avoids redundant copies. While we're at it, we can simplify the pushing of the parameters into the pending queue.
2020-11-20gl_rasterizer: Make floating-point literal a floatLioncash1-1/+1
Gets rid of an unnecessary expansion from float to double.
2020-11-20shader_bytecode: Make use of [[nodiscard]] where applicableLioncash1-73/+79
Ensures that all queried values are made use of.
2020-11-20shader_bytecode: Eliminate variable shadowingLioncash1-15/+17
2020-11-20common/bit_cast: Add function matching std::bit_cast without constexprReinUsesLisp2-0/+23
Add a std::bit_cast-like function archiving the same runtime results as the standard function, without compile time support. This allows us to use bit_cast while we wait for compiler support, it can be trivially replaced in the future.
2020-11-19hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled functions.bunnei6-0/+91
- Used by Animal Cross: New Horizons v1.6.0 update, minimal stub gets this update working.
2020-11-19Modify rumble amplificationgerman772-4/+3
2020-11-19virtual_buffer: Do nothing on resize() calls with same sizesLioncash1-1/+6
Prevents us from churning memory by freeing and reallocating a memory block that would have already been adequate as is.
2020-11-18patch_manager: Remove usages of the global system instanceLioncash26-157/+259
With this, only 19 usages of the global system instance remain within the core library. We're almost there.
2020-11-18core: Remove unused private Init function for the System classLioncash2-16/+4
This isn't used, so it can be removed.
2020-11-18core: Make use of [[nodiscard]] with the System classLioncash4-85/+82
Given this is a central class, we should flag cases where the return value of some functions not being used is likely a bug.
2020-11-18configure_input_player: Use static qualifier for IsProfileNameValid()Lioncash1-1/+1
This is a static member function, so we don't need use an existing instance to call this function.
2020-11-18virtual_buffer: Add compile-time type-safety guarantees with VirtualBufferLioncash1-0/+6
VirtualBuffer makes use of VirtualAlloc (on Windows) and mmap() (on other platforms). Neither of these ensure that non-trivial objects are properly constructed in the allocated memory. To prevent potential undefined behavior occurring due to that, we can add a static assert to loudly complain about cases where that is done.
2020-11-18page_table: Allow page tables to be movedLioncash4-9/+30
Makes page tables and virtual buffers able to be moved, but not copied, making the interface more flexible. Previously, with the destructor specified, but no move assignment or constructor specified, they wouldn't be implicitly generated.
2020-11-18page_table: Add missing doxygen parameters to Resize()Lioncash1-0/+2
Resolves two -Wdocumentation warnings.
2020-11-18page_table: Remove unnecessary header inclusionsLioncash1-4/+0
Prevents indirect inclusions for these headers.
2020-11-17rasterizer_interface: Make use of [[nodiscard]] where applicableLioncash1-8/+9
2020-11-17render_base: Make use of [[nodiscard]] where applicableLioncash1-11/+11
2020-11-17gpu: Make use of [[nodiscard]] where applicableLioncash1-31/+35
2020-11-17Addressed changesChloe Marcec4-10/+13
2020-11-17audren: Make use of nodiscard, rework downmixing, release all buffersChloe Marcec13-102/+194
Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented. Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
2020-11-16sdl_impl: Pump SDL Events at 1000 HzMorph1-1/+1
2020-11-16configure_input: Accommodate for the mouse input device engineMorph2-2/+18
2020-11-16hid: Reimplement Begin/EndPermitVibrationSessionMorph3-5/+17
Upon further investigation, these commands allow temporary vibrations even when the "Controller Vibration" system setting is disabled. As a result, vibrations are allowed when either the system setting or this flag is set to true. Therefore, we can only block vibrations when both flags are set to false.
2020-11-16controllers/npad: Load input devices on initMorph1-0/+2
2020-11-16configure_input: Update the input profiles for other player tabsMorph4-11/+38
2020-11-16general: Fix compiler warnings on linux and miscellaneous changesMorph12-22/+31
2020-11-16sdl_impl: Revert to the "old" method of mapping sticksMorph3-33/+29
Not all controllers have a SDL_GameController binding. This caused controllers not present in the SDL GameController database to have buttons mapped instead of axes. Furthermore, it was not possible to invert the axes when it could be useful such as emulating a horizontal single joycon or other potential cases. This allows us to invert the axes by reversing the order of mapping (vertical, then horizontal).
2020-11-16applets/controller: Change the input button to create input profilesMorph10-100/+117
Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-11-16controllers/npad: Remove the old vibration filterMorph4-65/+64
Previously we used a vibration filter that filters out amplitudes close to each other. It turns out there are cases where this results into vibrations that are too inaccurate. Remove this and move the 100Hz vibration filter (Only allowing a maximum of 100 vibrations per second) from sdl_impl to npad when enable_accurate_vibrations is set to false.
2020-11-16input: Disconnect a controller prior to connecting a new oneMorph2-50/+73
Some games do not respond to a change in controller type if 1) The controller is not disconnected prior to being reconnected and/or 2) The controller is reconnected instantly after being disconnected. Since it is not possible to change controllers instantly on hardware and requiring a disconnect prior to connecting a new one, we should emulate this as well with a small delay, fixing the aforementioned issue.
2020-11-16hid: Implement InitializeVibrationDevice and IsVibrationDeviceMountedMorph3-12/+66
2020-11-16input_common: Add VibrationDevice and VibrationDeviceFactoryMorph19-101/+327
A vibration device is an input device that returns an unsigned byte as status. It represents whether the vibration device supports vibration or not. If the status returns 1, it supports vibration. Otherwise, it does not support vibration.
2020-11-16configure_input: Add per-player vibrationMorph16-28/+730
Allows for enabling and modifying vibration and vibration strength per player. Also adds a toggle for enabling/disabling accurate vibrations. Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-11-16settings: Remove global vibration strength modifierMorph9-19/+1
This will be replaced in favor of per-player vibration strength modifiers.
2020-11-16hid: Mark Begin/EndPermitVibrationSession as stubsMorph3-18/+4
The implementation of these commands seem incomplete and causes rumble in Super Mario Party to stop working since only EndPermitVibrationSession is called. Thus, these are better off being marked as a stub until this can be investigated more thoroughly.
2020-11-16controllers/npad: Send an empty vibration on destruction/deactivationMorph3-22/+38
This stops all controllers from continuously vibrating when emulation is stopped.
2020-11-16hid: Stub IsVibrationDeviceMountedMorph2-1/+23
- Used in Super Mario Odyssey
2020-11-16controllers/npad: Add heuristics to reduce rumble state changesMorph3-35/+72
Sending too many state changes in a short period of time can cause massive performance issues. As a result, we have to use several heuristics to reduce the number of state changes to minimize/eliminate this performance impact while maintaining the quality of these vibrations as much as possible.
2020-11-16configure_input: Hook up the vibration percentage spinboxMorph11-3/+26
This allows setting the vibration strength percentage anywhere from 1% to 100%. Also hooks up the remaining motion button and checkbox in the Controller Applet.
2020-11-16controllers/npad: Stop games from vibrating incorrect controllersMorph1-0/+10
Fixes vibration in 1-2 Switch and potentially other games where they would vibrate both players' joycons at the same time.
2020-11-16hid: Fix controller rumble based on new researchMorph3-43/+69
This fixes the issue where rumble is only sent to the first controller. Now, individual controllers can receive their own rumble commands.
2020-11-16hid: Pop a struct of parameters instead of popping individual parametersMorph1-103/+237
Some parameters need to be doubleword aligned due to the presence of the applet_resource_user_id. Previously, this value was invalid in many commands where it was not doubleword aligned when popped.
2020-11-16hid: Reorder all HID commandsMorph5-217/+232
Reorders all HID commands in command id order.
2020-11-16hid: Implement GetVibrationDeviceInfoMorph2-3/+39
The first u32 describes the vibration device type which is a Linear Resonant Actuator used in Nintendo Switch controller hardware. The second u32 describes the vibration device position, in this case distinguishing between left and right vibration actuators. Pro Controllers have 2 LRAs each that can vibrate independently of each other, which means they have 2 distinct vibration device handles to distinguish between the two actuators. Similarly for joycons, the left joycon can be distinguished from the right joycon through the vibration device handle since each joycon has 1 LRA.
2020-11-16hid: Stub InitializeVibrationDeviceMorph1-3/+11
2020-11-16controllers/npad: Rename NPadType to NpadStyleSetMorph3-9/+9
This more accurately represents the underlying type and avoids confusion with NpadType
2020-11-16controllers/npad: Add DeviceHandle structMorph1-27/+50
A DeviceHandle describes a vibration device or six-axis sensor based on the npad type, npad id, and device index/position
2020-11-16configure_input_player: Change "Defaults" button behaviorMorph2-35/+30
RestoreDefaults() now restores the selected devices' mappings using UpdateMappingWithDefaults(). This allows us to move the keyboard mapping from RestoreDefaults() to UpdateMappingWithDefaults().
2020-11-16settings: Preparation for per-game input settingsMorph19-115/+167
2020-11-16udp/client: Reduce testing period to 5 secondsMorph1-1/+1
2020-11-16config: Migrate config files into config/customMorph4-21/+61
Co-authored-by: lat9nq <lat9nq@virginia.edu>
2020-11-16controllers/npad: Connect a controller on init if none are connectedMorph2-1/+15
2020-11-16applets/controller: Auto accept a valid single player configurationMorph3-14/+24
2020-11-16bootmanager: Allow mouse clicks only if touch is disabledMorph1-3/+13
Previously mouse clicks will not register when touch is disabled. This rectifies that and allows mouse clicks to be mapped to other buttons if the touchscreen is disabled.
2020-11-16input_profiles: Implement input profilesMorph13-130/+509
2020-11-16configure_input_player: Implement input exclusivity and persistenceMorph4-138/+205
With this, the "Input Devices" combobox should accurately reflect the input device being used and disallows inputs from other input devices unless the input device is set to "Any".
2020-11-16ui/themes: Cleanup UIMorph13-397/+263
2020-11-15motion_input: Mark constructor as explicitLioncash1-1/+1
2020-11-15motion_input: Mark member functions as [[nodiscard]] where applicableLioncash1-10/+11
2020-11-11maxwell_3d: Use insert instead of loop push_backReinUsesLisp1-3/+1
This reduces the overhead of bounds checking on each element. It won't reduce the cost of allocation because usually this vector's capacity is usually large enough to hold whatever we push to it.
2020-11-11maxwell_3d: Move code to separate functionsReinUsesLisp2-151/+124
Deduplicate some code and put it in separate functions so it's easier to understand and profile.
2020-11-10fix minor clang errorgerman1-1/+1
2020-11-10Addressed issuesChloe Marcec10-17/+86
2020-11-10core: Make nvservices more standardizedChloe Marcec26-903/+1156
2020-11-10bootmanager: Address review commentslat9nq1-12/+16
Changes QMessageBox usages to warnings, as the problems they bring to light are being safely handled by the application and do not warrant something of the "critical" level. Changes LOG_CRITICAL to LOG_ERROR for the same reason. Preferring ERROR to WARNING as yuzu is denying loading of any guest applications after checking for these conditions. Moved logging the GL_RENDERER string into GetUnsupportedGLExtensions() to make more clear that unsupported extensions were already being logged. Makes placement of the logs easier to understand later, as well.
2020-11-10bootmanager: Log and show GL_RENDERER string when GPU is insufficientlat9nq1-3/+19
Changes the first message to not include the OpenGL version, as the error is caused by OpenGL failing to load. Adds a new check for OpenGL version 4.3. This will display a message with a similar error as well as the GL_RENDERER string. Adds a CRITICAL log message when triggered. This prevents a crash with yuzu trying to use older OpenGL versions. Modifies the unsupported extension message to output the GL_RENDERER string in the message, as well as logging the string.
2020-11-08ipc_helpers: Remove usage of the global system instanceLioncash16-7/+23
Resolves numerous deprecation warnings throughout the codebase due to inclusion of this header. Now building core should be significantly less noisy (and also relying on less global state). This also uncovered quite a few modules that were relying on indirect includes, which have also been fixed.
2020-11-08cpu_interrupt_handler: Mark move contructor/assignment as deletedLioncash1-2/+2
The interrupt handler contains a std::atomic_bool, which isn't copyable or movable, so the special move member functions will always be deleted, despite being defaulted. This can resolve warnings on clang and GCC.
2020-11-08Allow to dial any angle with digital joystickgerman1-19/+103
2020-11-08applets: Rename LibraryAppletVersion to ControllerAppletVersionMorph2-15/+15
2020-11-08applets/controller: Pop normal data for StrapGuide and FirmwareUpdateMorph2-6/+19
2020-11-08applets/controller: Introduce additional checks for mode and callerMorph2-5/+39
Some games like Cave Story+ set invalid values in the ControllerPrivateArg's mode and caller fields. Use other fields to determine the appropriate mode and caller should either or both fields be invalid.
2020-11-08applets/controller: Add ControllerUpdateFirmwareArg structMorph1-0/+7
2020-11-07settings: log value of CPU_Accuracylat9nq1-0/+1
2020-11-07video_core: dma_pusher: Remove integrity check on command lists.bunnei3-29/+1
- This seems to cause softlocks in Breath of the Wild.
2020-11-07hle: service: caps_u: Stub GetAlbumFileList3AaeAruid.bunnei2-9/+17
- This works similiar to GetAlbumContentsFileListForApplication. - Since we do not implement the album, this should be safe to stub for now. - Used by Super Smash Bros. Ultimate (newer updates) in World of Light.
2020-11-07common/fiber: Move all member variables into impl classLioncash2-89/+86
Hides all of the implementation details for users of the class. This has the benefit of reducing includes and also making the fiber classes movable again.
2020-11-06settings: Simplify initializer of resolution factorLioncash1-1/+1
This can use a braced initializer to accomplish the same thing with less code.
2020-11-05General: Fix clang buildLioncash4-7/+14
Allows building on clang to work again
2020-11-04core/settings: Move configuring_global behind an APILioncash9-39/+50
Rather than have directly modified global state here, we can make it an implementation detail and have an interface that changes are queried through.
2020-11-04core: Remove usage of unicornLioncash11-418/+15
Unicorn long-since lost most of its use, due to dynarmic gaining support for handling most instructions. At this point any further issues encountered should be used to make dynarmic better. This also allows us to remove our dependency on Python.
2020-11-02common: Enable warnings as errorsLioncash9-31/+49
Cleans up common so that we can enable warnings as errors.
2020-11-02nvdec: Make use of [[nodiscard]] where applicableLioncash7-16/+16
Prevents bugs from occurring where the results of a function are accidentally discarded
2020-11-01fixup! hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements.bunnei2-3/+11
2020-11-01core: Initialize GPU before services.bunnei1-4/+6
2020-11-01 hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements.bunnei3-46/+106
- Refactor so that SubmitGPFIFO and KickoffPB use shared functionality. - Implement add_wait and add_increment flags.
2020-11-01video_core: dma_pusher: Add support for integrity checks.bunnei2-0/+27
- Log corrupted command lists, rather than crash.
2020-11-01video_core: dma_pusher: Add support for prefetched command lists.bunnei2-25/+52
2020-11-01service: hle: nvflinger: Fix potential shutdown crash when GPU is destroyed.bunnei1-0/+4
2020-11-01video_core: gpu: Implement WaitFence and IncrementSyncPoint.bunnei3-28/+70
2020-11-01hle service: nvdrv: nvhost_ctrl: Update to use SyncpointManager.bunnei3-9/+31
2020-11-01hle service: nvdrv: Update to instantiate SyncpointManager.bunnei2-5/+18
2020-11-01hle: service: nvdrv: Implement SyncpointManager, to manage syncpoints.bunnei4-1/+127
2020-11-01Rename to align with switchbrew and remove gpu function (#4714)Levi Behunin2-16/+10
* Rename to align with switchbrew * Rename to align with switchbrew and remove gpu function that checks if clearing should be done.
2020-10-31hle: service: ldr: Implement UnloadNrr.bunnei1-1/+15
- Used by Final Fantasy X/X-2 HD Remaster.
2020-10-30CMakeLists: Resolve MSVC build failuresLioncash1-1/+0
Prevents the compiler tripping up about Windows headers.
2020-10-30video_core: unbreak -Werror in NVDEC with ClangJan Beich1-1/+1
src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.cpp:41:15: error: unused variable 'OutOfMemory' [-Werror,-Wunused-const-variable] constexpr u32 OutOfMemory{static_cast<u32>(-12)}; ^
2020-10-30General: Catch more expressions with no effect on MSVCLioncash1-0/+4
MSVC lets us fine-tune catching expressions with no side-effects a little more.
2020-10-30General: Make ignoring a discarded return value an errorLioncash3-6/+17
Allows our CI to catch more potential bugs. This also removes the [[nodiscard]] attribute of IOFile's Open member function. There are cases where a file may want to be opened, but have the status of it checked at a later time.
2020-10-30common/stream: Be explicit with copy and move operatorsLioncash1-3/+9
2020-10-30vp9: Be explicit with copy and move operatorsLioncash1-0/+18
It's deprecated in the language to autogenerate these if the destructor for a type is specified, so we can explicitly specify how we want these to be generated.
2020-10-30vp9: Mark functions with [[nodiscard]] where applicableLioncash2-13/+13
Prevents values from mistakenly being discarded in cases where it's a bug to do so.
2020-10-30vp9: Provide a default initializer for "hidden" memberLioncash1-1/+1
The API of VP9 exposes a WasFrameHidden() function which accesses this member. Given the constructor previously didn't initialize this member, it's a potential vector for an uninitialized read. Instead, we can initialize this to a deterministic value to prevent that from occurring.
2020-10-30vp9: Make some member functions internally linkedLioncash2-58/+54
These helper functions don't directly modify any member state and can be hidden from view.
2020-10-30General: Resolve a few missing initializer warningsLioncash5-4/+24
Resolves a few -Wmissing-initializer warnings.
2020-10-29async_shaders: Increase Async worker thread count for 8+ thread cpusameerj1-8/+9
Adds 1 async worker thread for every 2 available threads above 8
2020-10-29kernel/process: Add missing <ctime> includeMorph1-0/+1
Fixes compilation on MSVC
2020-10-29web_service: follow-up fix to #4842 ...liushuyu1-5/+0
* The web_service http request is now fixed on Windows (R) platform. * The issue is due to a complicated race-condition in `httplib`, a detailed explanation is available at https://github.com/yhirose/cpp-httplib/pull/701 * A pending Pull Request on `httplib` has been applied to remedy the said race-condition. * The socket availability check is removed due to a behavioral chice of `httplib` that a socket will not be created before any actual request is sent.
2020-10-29Add hotplug, rumble and fix 3rd party adapters for the GC adaptergerman3-303/+433
2020-10-29web_service: web_backend: Handle socket errors with GenericRequest.bunnei1-0/+11
- Fixes a shutdown crash when we try to submit telemetry if there is a service issue.
2020-10-29video_core: cdma_pusher: Add missing LOG_DEBUG field in ExecuteCommand.bunnei1-1/+1
2020-10-28shader: Partially implement texture cube array shadowReinUsesLisp3-25/+37
This implements texture cube arrays with shadow comparisons but doesn't fix the asserts related to it. Fixes out of bounds reads on swizzle constructors and makes them use bounds checked ::at instead of the unsafe operator[].
2020-10-28shader/arithmetic: Implement FCMP immediate + register variantReinUsesLisp2-1/+4
Trivially add the encoding for this.
2020-10-28video_core: Enforce -Wredundant-move and -Wpessimizing-moveReinUsesLisp4-4/+5
Silence three warnings and make them errors to avoid introducing more in the future.
2020-10-28video_core: Enforce -Werror=type-limitsReinUsesLisp2-1/+2
Silences one warning and avoids introducing more in the future.
2020-10-28common/fiber: Take shared_ptr<Fiber> by copy in YieldToReinUsesLisp2-3/+3
YieldTo does not intend to modify the passed shared_ptrs. Pass it by copy to keep a reference count while this function executes.
2020-10-28tests: Fix data race in fibers testReinUsesLisp1-31/+40
Previous to this commit, the tests were using operator[] from unordered_map to query elements but this silently inserts empty elements when they don't exist. If all threads were executed without concurrency, this wouldn't be an issue, but the same unordered_map could be written from two threads at the same time. This is a data race and makes some previously inserted elements invisible for a short period of time, causing them to insert and return an empty element. This default constructed element (a zero) was used to index an array of fibers that asserted when one of them was nullptr, shutting the test session off. To address this issue, lock on thread id reads and writes. This could be a shared mutex to allow concurrent reads, but the definition of std::this_thread::get_id is fuzzy when using non-standard techniques like fibers. I opted to use a standard mutex. While we are at it, fix the included headers.
2020-10-28service: Update function tablesLioncash5-1/+7
Updates function tables according to info on SwitchBrew.
2020-10-27web_backend: fix a regression introduced in 39c8d18liushuyu2-20/+2
* A regression was in 39c8d18 and token verification function was broken. * The reason being `httplib` now requires OpenSSL 1.1+ API while LibreSSL 2.x provided OpenSSL 1.0 compatible API. * The bundled LibreSSL has been updated to 3.2.2 so it now provides OpenSSL 1.1 compatible API now. * Also the path hint has been added so that it will find the correct path to the CA certs on *nix systems. * An option is provided so that *nix system distributions/providers can use their own SSL implementations when compiling Yuzu/Citra to (hopefully) complies with their maintenance guidelines. * LURLParse is also removed since `httplib` can handle `scheme:host:port` string itself now.
2020-10-27sync_manager: Amend parameter order of calls to SyncptIncr constructorLioncash2-9/+9
Corrects some cases where the arguments would be incorrectly swapped.
2020-10-27h264: Make WriteUe take a u32Lioncash2-7/+8
Enforces the type of the desired value in calling code.
2020-10-27vp9: std::move buffer within ComposeFrameHeader()Lioncash1-1/+1
We can move the buffer here to avoid a heap reallocation
2020-10-27vp9: Remove dead codeLioncash1-6/+0
2020-10-27vp9: Join declarations with assignmentsLioncash1-7/+8
2020-10-27vp9: Remove pessimizing movesLioncash1-2/+2
The move will already occur without std::move.
2020-10-27vp9: Resolve variable shadowingLioncash1-4/+4
2020-10-27nvdec: Tidy up header includesLioncash13-62/+59
Prevents a few unnecessary inclusions.
2020-10-27yuzu: settings: Enable multicore, asynch GPU, and assembly shaders by default.bunnei3-11/+11
- In general, this is now the preferred settings for most games. # Conflicts: # src/yuzu/configuration/config.cpp
2020-10-27hle/kernel: Remove unused registered_core_threads to fix data racesReinUsesLisp1-5/+0
This member was only used on asserts and it triggered data races. Remove it to fix them.
2020-10-27video_core: NVDEC Implementationameerj50-310/+3909
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library. The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data. To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library. Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header. Async GPU is not properly implemented at the moment. Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
2020-10-27kernel: Use the current time as the default RNG seedlat9nq1-1/+1
Use the current time, not zero, as the default RNG seed.
2020-10-27controller: Pass ControllerParameters by reference in ReconfigureControllers()Lioncash4-7/+9
Prevents unnecessary copies and heap reallocations from occurring.
2020-10-27hle: services: TimeZoneContentManager: This can be made explicit.bunnei1-1/+1
2020-10-27core: cpu_manager: Add missing call to MicroProfileOnThreadExit().bunnei1-0/+2
- Fixes an occasional crash when trying to launch subsequent games.
2020-10-25general: Use template deduction guides for lock_guardLioncash2-2/+2
Same behavior, less code.
2020-10-25controller: Convert led_patterns integer literals to bool literalsLioncash1-9/+9
'bool' isn't always guaranteed to be the same size as an int, so this can technically cause truncation warnings if we support other platforms.
2020-10-25applets/profile_select: Resolve a warning in exec()Morph1-1/+1
Resolves a warning where not all control paths return a value.
2020-10-22Don't ask for profile when there's only one.Kewlan3-16/+20
2020-10-22core: Fix clang build pt.3Lioncash4-16/+6
Should finally resolve building with clang.
2020-10-21sdl_impl: Fix controller reconnection issuesMorph1-85/+84
It turns out that after a controller is disconnected, there is a chance that events from the previous controller are sent/processed after it has been disconnected. This causes the previously disconnected controller to reappear as connected due to GetSDLJoystickBySDLID() emplacing this controller back to the map. Fix this by only returning an SDLJoystick if and only if it exists in the map.
2020-10-21core: Fix clang build pt.2Lioncash2-4/+10
Resolves the clang build issue in a more unintrusive way.
2020-10-21Revert "core: Fix clang build"bunnei104-904/+665
2020-10-21video_core: Conditially activate relevant compiler warningsLioncash1-2/+4
These compiler flags aren't shared with clang, so specifying these flags unconditionally can lead to a bit of warning spam. While we're in the area, we can also enable -Wunused-but-set-parameter given this is almost always a bug.
2020-10-21kernel: Fix build with recent compiler flag changesLioncash1-4/+8
This slipped through the cracks due to another change being merged before the compiler flag changes.
2020-10-20configure_input_player: Fix modifier buttonsMorph3-25/+23
Fix them for real this time, now they finally work.
2020-10-20gl_arb_decompiler: Implement robust buffer operationsReinUsesLisp3-33/+54
This emulates the behavior we get on GLSL with regular SSBOs with a pointer + length pair. It aims to be consistent with the crashes we might get. Out of bounds stores are ignored. Atomics are ignored and return zero. Reads return zero.
2020-10-20Added remaining paramsDavid Marcec1-1/+4
2020-10-20nifm: GetAppletInfo stubDavid Marcec1-1/+8
Fixes crash for Catherine Full Body
2020-10-18core: Add boxcat sources with target_sourcesLioncash1-7/+7
Same behavior, minus a script variable.
2020-10-18core: Fix clang buildLioncash104-665/+904
Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
2020-10-17mii/manager: Make use of unused lower bound in GetRandomValue()Lioncash1-1/+1
Previously, the lower bound wasn't being used and zero was being used as the lower bound every time this function was called. This affects the outcome of some of the randomized entries a little bit, for example, the lower-bound for beard and mustache flags was supposed to be 1, not 0. Aside from these cases, the bug didn't affect anything else.
2020-10-17service: bcat: Check client connection before interacting with socket.bunnei1-0/+10
- Fixes a crash when BCAT service is offline.
2020-10-16udp/client: Make use of designated initializers in TestCommunication()Lioncash1-2/+5
Same behavior, but makes the callback list nicer to look at.
2020-10-16udp/client: Take std::function by const reference with TestCommunication()Lioncash2-5/+5
Avoids redundant copies.
2020-10-16sdl_impl: Erase the SDLJoystick entry after removing a controllerMorph1-15/+13
Previously, disconnecting a controller still leaves a null SDLJoystick entry within the vector of SDLJoysticks mapped by GUID. When a DirectInput device of the same GUID is reconnected, it adds that device to a new port causing non-detectable input. Furthermore, opening the "Configure" menu would cause yuzu to crash since it first tries to resolve the name of a null SDLJoystick entry that was not removed. Resolve this by properly erasing the SDLJoystick entry from the vector.
2020-10-16input_common/CMakeLists: Make some warnings errorsLioncash19-203/+306
Makes the input_common code warnings consistent with the rest of the codebase.
2020-10-15service: acc: Stub IManagerForApplication::StoreOpenContext.bunnei1-1/+7
- Used by Super Mario 3D All-Stars.
2020-10-14hle: service: vi: Implement BufferQueue::CancelBuffer.bunnei3-14/+53
- This is used by Super Mario 3D All-Stars.
2020-10-13kernel: Implement host thread register methods without lockingReinUsesLisp1-28/+38
Locks on GetCurrentHostThreadID were causing performance issues according to Visual Studio's profiler. It was consuming twice the time as arm_interface.Run(). The cost was not in the function itself but in the lockinig it required. Reimplement these functions using atomics and static storage instead of an unordered_map. This is a side effect to avoid locking and using linked lists for reads. Replace unordered_map with a linear search.
2020-10-13audio_core/CMakeLists: Make warnings consistent with coreLioncash6-8/+17
Normalizes the warnings shared between audio_core and core.
2020-10-13core/CMakeLists: Make some warnings errorsLioncash30-146/+144
Makes our error coverage a little more consistent across the board by applying it to Linux side of things as well. This also makes it more consistent with the warning settings in other libraries in the project. This also updates httplib to 0.7.9, as there are several warning cleanups made that allow us to enable several warnings as errors.
2020-10-13vk_graphics_pipeline: Manage primitive topology as fixed stateReinUsesLisp6-26/+7
Vulkan has requirements for primitive topologies that don't play nicely with yuzu's. Since it's only 4 bits, we can move it to fixed state without changing the size of the pipeline key. - Fixes a regression on recent Nvidia drivers on Fire Emblem: Three Houses.
2020-10-13filesystem: Fix CreateDirectory and DeleteFileMorph1-2/+3
Add a check if dir is nullptr (does not exist) Fixes save game creation in Hades
2020-10-13service: time: Update current time with changes to RTC setting.bunnei9-198/+341
- This can be used to advance time, e.g. for Pokemon Sword/Shield pokejobs.
2020-10-13hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace.bunnei2-0/+25
- This is used by Super Mario 3D All-Stars.
2020-10-09video_core: Enforce -Wclass-memaccessReinUsesLisp2-7/+7
2020-10-09vk_device: Block VK_EXT_extended_dynamic_state for RDNA devicesgoldenx861-0/+24
RDNA devices seem to crash when using VK_EXT_extended_dynamic_state in the latest 20.9.2 proprietary Windows drivers. As a workaround, for now we block device names corresponding to current RDNA released products.
2020-10-08shader/texture: Implement CUBE texture type for TMML and fix arraysReinUsesLisp1-19/+22
TMML takes an array argument that has no known meaning, this one appears as the first component in gpr8 followed by s, t and r. Skip this component when arrays are being used. Also implement CUBE texture types. - Used by Pikmin 3: Deluxe Demo.
2020-10-07renderer_vulkan/wrapper: Fix physical device sortingReinUsesLisp1-13/+35
The old code had a sort function that was invalid and it didn't work as expected when the base vector had a different order (e.g. renderdoc was attached). This sorts devices as expected and fixes a debug assert on MSVC.
2020-10-05Address commentsgerman2-40/+40
2020-10-04Add compatibility with only accelerometer and auto calibrate for driftgerman2-12/+106
2020-10-03video_core: Enforce -Wunused-variable and -Wunused-but-set-variableReinUsesLisp3-4/+7
2020-10-02Only use inputs corresponding to controller typegerman1-49/+58
2020-09-30Stubbed EnableSixAxisSensorFusiongerman2-1/+15
2020-09-30caps_c: Stub SetShimLibraryVersionMorph2-1/+18
- Used by caps_su SetShimLibraryVersion
2020-09-30caps_u: Stub SetShimLibraryVersionMorph2-2/+14
- Used in Super Smash Bros. Ultimate
2020-09-30caps_su: Properly stub SetShimLibraryVersionMorph1-1/+6
2020-09-30hid: Stub HomeButtonInputProtection service commandsMorph4-2/+50
- Used in 1-2 Switch. Given that we do not emulate the functionality of the home button yet, we can stub this for now.
2020-09-30Reduce the "shake" requirements when configuring UDP.Lukas Senionis1-2/+6
2020-09-30Remove ext_extended_dynamic_state blacklistMatías Locatti1-8/+0
Latest AMD 20.9.2 driver fixed this, there's no reason to keep it blocked, as the previous stable signed driver release doesn't include the extension.
2020-09-30common/wall_clock: Add virtual destructorsReinUsesLisp3-2/+4
From -fsanitize=address, this code wasn't calling the proper destructor. Adding virtual destructors for each inherited class and the base class fixes this bug. While we are at it, mark the functions as final.
2020-09-29qt/game_list: Give GameListSearchField::KeyReleaseEater a parentReinUsesLisp2-3/+4
This fixes a memory leak as KeyReleaseEater's destructor was never called.
2020-09-29First implementation of controller rumblegerman5-14/+63
2020-09-29CMakeLists: use system zstd on Linuxlat9nq1-1/+6
From what I understand, this tells CMake to use the system, not conan, version of zstd. Required to build on the coming MinGW Docker container.
2020-09-29CMakeLists: fix for finding zstd on linux-mingwlat9nq1-1/+1
2020-09-26main: Allow applets to display on top while fullscreenMorph1-6/+8
Using the Qt::WindowStaysOnTopHint flag allows these dialogs to show up on top while running in fullscreen. However, if yuzu goes out of focus (by alt-tabbing or otherwise), this flag does not seem to have an effect.
2020-09-26core: Mark GetInstance() as deprecatedLioncash1-1/+1
This way it's obvious that this function shouldn't be used in any future code.
2020-09-26frontend/controller: Eliminate dependency on the global system instanceLioncash3-5/+14
2020-09-26Add random motion input to keyboardgerman4-0/+65
2020-09-26Add random motion input to SDLgerman5-5/+230
2020-09-26command_generator: Make lookup table static constexprLioncash1-2/+3
Allows compilers to elide needing to push these values on the stack every time the function is called.
2020-09-25vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linuxlat9nq1-1/+2
The previous fix only partially solved the issue, as only certain GPUs that needed 9 or less MiB subtracted would work (i.e. GTX 980 Ti, GT 730). This takes from DXVK's example to divide `heap_size` by 2 to determine `allocable_size`. Additionally tested on my Quadro K4200, which previously required setting it to 12 to boot.
2020-09-25behavior_info: Fix typo Renerer -> RendererLioncash2-6/+6
2020-09-25cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()Lioncash1-2/+2
Conversions from void* to the proper data type are well-defined and supported by static_cast. We don't need to use reinterpret_cast here.
2020-09-25codec: Make lookup table static constexprLioncash2-3/+4
Allows compilers to elide needing to push these values on the stack every time the function is called.
2020-09-25audio_core: Remove unnecessary inclusionsLioncash5-7/+2
Same behavior, but removes header dependencies where they don't need to be.
2020-09-25audio_core: Resolve sign conversion warningsLioncash8-25/+34
While were at it, we can also enable sign conversion warnings and other common warnings as errors to prevent these from creeping back into the codebase.
2020-09-25effect_context: Make use of explicit where applicableLioncash1-13/+12
While we're at it we can make the destructor of the base class virtual to ensure that any polymorphism issues never occur.
2020-09-25vk_command_pool: Move definition of Pool into the cpp fileLioncash2-4/+6
Allows the implementation details to be changed without recompiling any files that include this header.
2020-09-25vk_command_pool: Make use of override on destructorLioncash1-1/+1
2020-09-25vk_command_pool: Add missing header guardLioncash1-0/+2
2020-09-25service: Restore "unused" functionLioncash1-0/+17
Turns out this function is actually used, but within a trace log.
2020-09-24submission_package: Fix updates integrated into cartridge images.Morph1-3/+22
2020-09-24arithmetic_integer_immediate: Make use of std::move where applicableLioncash1-16/+19
Same behavior, minus any redundant atomic reference count increments and decrements.
2020-09-24video_core: Fix instances where msbuild always regenerated host shadersReinUsesLisp2-12/+7
When HEADER_GENERATOR was included in the DEPENDS section of custom commands, msbuild assumed this was always modified. Changing this file is not common so we can remove it from there.
2020-09-24Use different timing for motiongerman5-76/+157
2020-09-23shader/registry: Silence a -Wshadow warningLioncash2-5/+5
2020-09-23shader/registry: Remove unnecessary namespace qualifiersLioncash1-5/+3
Using statements already make these unnecessary.
2020-09-23shader/registry: Make use of designated initializers where applicableLioncash1-17/+19
Same behavior, less repetition.
2020-09-23memory: Resolve a -Wdocumentation warningLioncash1-1/+1
memory doesn't exist as a parameter any more.
2020-09-23install_dialog: Make use of [[nodiscard]] where applicableLioncash1-2/+2
Allows the compiler to warn against cases where the return value isn't used (which would be a bug).
2020-09-23install_dialog: Remove unused function prototypeLioncash1-1/+0
This function doesn't have an implementation, so it can be removed to prevent others from unintentionally using it.
2020-09-23game_list: Make game list function naming consistentLioncash3-36/+45
Makes the naming consistent with the rest of the functions that are present.
2020-09-23game_list: Eliminate redundant argument copiesLioncash2-16/+22
Several functions can be taken by const reference to avoid copies
2020-09-23control_flow: emplace elements in place within TryQuery()Lioncash1-6/+6
Places data structures where they'll eventually be moved to to avoid needing to even move them in the first place.
2020-09-23control_flow: Make use of std::move in InsertBranch()Lioncash1-7/+8
Avoids unnecessary atomic increments and decrements.
2020-09-22General: Make use of std::nullopt where applicableLioncash17-59/+60
Allows some implementations to avoid completely zeroing out the internal buffer of the optional, and instead only set the validity byte within the structure. This also makes it consistent how we return empty optionals.
2020-09-22ips_layer: Eliminate a redundant copy in Parse()Lioncash1-2/+4
Prevents unnecessary copying of the line being parsed.
2020-09-21acc: Stub LoadOpenContextMorph3-1/+13
This is used in multiple games such as: - Clubhouse Games: 51 Worldwide Classics - Grandia HD Collection - XCOM 2 Collection - Baldur's Gate 1/2 - Dr Kawashima's Brain Training - Super Mario 3D All-Stars
2020-09-20renderer_opengl: Remove emulated mailbox presentationReinUsesLisp13-360/+35
Emulated mailbox presentation was causing performance issues on Nvidia's OpenGL driver. Remove it.
2020-09-19vk_query_cache: Hack counter destructor to avoid reserving queriesReinUsesLisp1-1/+10
This is a hack to destroy all HostCounter instances before the base class destructor is called. The query cache should be redesigned to have a proper ownership model instead of using shared pointers. For now, destroy the host counter hierarchy from the derived class destructor.
2020-09-19renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphoreReinUsesLisp42-814/+638
This reworks how host<->device synchronization works on the Vulkan backend. Instead of "protecting" resources with a fence and signalling these as free when the fence is known to be signalled by the host GPU, use timeline semaphores. Vulkan timeline semaphores allow use to work on a subset of D3D12 fences. As far as we are concerned, timeline semaphores are a value set by the host or the device that can be waited by either of them. Taking advantange of this, we can have a monolithically increasing atomic value for each submission to the graphics queue. Instead of protecting resources with a fence, we simply store the current logical tick (the atomic value stored in CPU memory). When we want to know if a resource is free, it can be compared to the current GPU tick. This greatly simplifies resource management code and the free status of resources should have less false negatives. To workaround bugs in validation layers, when these are attached there's a thread waiting for timeline semaphores.
2020-09-18Add automap feature for GC adaptergerman3-1/+103
2020-09-18fermi_2d: Make use of designated initializersLioncash2-8/+8
Same behavior, less repetition. We can also ensure all members of Config are initialized.
2020-09-18hid: Implement Get/SetNpadHandheldActivationModeMorph3-5/+28
- Used in Clubhouse Games: 51 Worldwide Classics
2020-09-18configure_input_player: Fixes motion mapping using ConfigureButtonClickMorph1-5/+8
2020-09-18am: Stub GetPreviousProgramIndexMorph2-1/+11
- Used in Super Mario 3D All-Stars
2020-09-18configure_input_player: Re-add "Clear" context menu optionMorph2-31/+66
The context menu was removed in Mjölnir Part 1 as part of the input rewrite as we were unaware of it's usage statistics. However, as this was the only way to clear the inputs of individual buttons, this PR will re-add it back in.
2020-09-18submission_package: Account for multi-content NSPsMorph1-5/+5
Previously we assumed a submission package can only contain one Program NCA with a single TitleID. However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs. This accounts for the existence of multi-content games such as this one. - Fixes booting Super Mario 3D All-Stars from the games list.
2020-09-17decode/image: Eliminate switch fallthrough in DecodeImage()Lioncash1-0/+1
Fortunately this didn't result in any issues, given the block that code was falling through to would immediately break.
2020-09-17decoder/texture: Eliminate narrowing conversion in GetTldCode()Lioncash1-1/+1
The assignment was previously truncating a u64 value to a bool.
2020-09-17audio_core/command_generator: Use const references where applicableLioncash1-10/+11
In a lot of cases, we can make use of const references rather than non-const references. While we're in the area we can silence some truncation and sign conversion warnings.
2020-09-17audio_core/command_generator: Avoid an unnecessary copy in GenerateFinalMixCommand()Lioncash1-1/+1
2020-09-17nfp: Eliminate two unnecessary copiesLioncash1-10/+13
GetAmiiboBuffer() returns by const reference, so we can use a reference instead of taking the returned buffer by value.
2020-09-17arm_dynarmic_cp15: Initialize member variablesLioncash1-2/+2
Ensures that the member variables are always initialized to a deterministic value on creation.
2020-09-17control_metadata: Resolve typo in Portuguese language nameLioncash1-1/+1
This isn't used anywhere, so this is a trivial fix.
2020-09-17service: Remove unused funcationLioncash1-22/+0
This is now completely unused, so it can be removed.
2020-09-17service/sm: Slightly more efficient string name validationLioncash1-2/+2
We can check the end of the string first for null-termination, rather than the beginning of the string.
2020-09-17service/sm: Eliminate dependency on the global system instanceLioncash3-7/+9
2020-09-17file_sys/romfs_factory: Eliminate usage of the global system accessorLioncash5-34/+49
2020-09-17file_sys/bis_factory: Eliminate usage of the global system accessorLioncash5-11/+11
2020-09-17loader/nso: Remove unnecessary [[maybe_unused]]Lioncash1-2/+1
2020-09-16video_core: Enforce -Werror=switchReinUsesLisp7-10/+59
This forces us to fix all -Wswitch warnings in video_core.
2020-09-16core/loader: Remove dependencies on the global system instanceLioncash20-45/+85
Now all that remains is: 18 instances in file_sys code 14 instances in GDB stub code (this can be tossed wholesale) 4 instances in HLE code 2 instances in settings code.
2020-09-15nca_patch: Significantly reduce the stack usage size within SearchBucketEntry()Lioncash1-4/+4
Previously this function was using ~16KB of stack (16528 bytes), which was caused by the function arguments being taken by value rather than by reference. We can make this significantly lighter on the stack by taking them by reference.
2020-09-15nca_patch: Make SearchBucketEntry() internally linkedLioncash2-44/+43
This is only used internally and doesn't depend on any class state, so we can make it fully internal.
2020-09-15cheat_engine: Convert ExtractName into a non-template functionLioncash1-19/+17
We don't need to create two separate instantiations of the same code, we can simply make the character template argument a regular function parameter.
2020-09-15cheat_engine: Remove unnecessary system argument to CheatParser's Parse functionLioncash3-15/+9
This isn't used within the function at all in any implementations, so we can remove it entirely.
2020-09-15patch_manager: Resolve implicit truncations in FormatTitleVersion()Lioncash1-3/+4
We make it explicit that we're truncating arithmetic here to resolve compiler warnings (even if the sizes weren't u32/u64 arithmetic generally promotes to int :<)
2020-09-15patch_manager: Make use of type aliasesLioncash2-69/+79
We can use these to avoid typing the same type redundantly. This way, if these ever change, only a single location needs to be modified.
2020-09-15patch_manager: Make a few functions internally linkedLioncash2-15/+12
These functions are only used within this translation unit, so we can make them internally linked.
2020-09-15gc_adapter: Disable MSVC nonstandard extension warning on libusb.hReinUsesLisp1-0/+9
Pragma disable zero-sized array nonstandard extension warning on MSVC.
2020-09-14crypto/key_manager: Remove dependency on the global system accessorLioncash3-7/+12
We can supply the content provider as an argument instead of hardcoding a global accessor in the implementation.
2020-09-14kernel: Remove all dependencies on the global system instanceLioncash5-11/+20
With this, the kernel finally doesn't depend directly on the global system instance anymore.
2020-09-10Test: Decrease pad_update_nsFearlessTobi1-1/+1
There have been reports of quite heavy input lag in the past. Compared to Citra for example, our pad_update_ns value is very high. So let's decrease it and see if it helps with this problem.
2020-09-07service: Remove two usages of the global system accessorLioncash3-7/+5
Removes more instances of reliance on global state.
2020-09-07gc_adapter: Make DeviceConnected() a const member functionLioncash3-9/+9
This doesn't modify instance state, so it can be made const.
2020-09-07bsd: Resolve unused value within SendToImplLioncash1-0/+1
Previously the address provided to SendToImpl would never be propagated to SendTo(). This fixes that.
2020-09-07bsd: Resolve sign comparison warningsLioncash1-3/+3
2020-09-07sockets_translate: Make use of designated initializersLioncash1-12/+12
Same behavior, less typing.
2020-09-07blocking_worker: Make use of templated lambdaLioncash1-3/+2
We can simplify this a little by explicitly specifying the typename for the lambda function.
2020-09-07blocking_worker: Resolve -Wdocumentation warningLioncash1-1/+1
2020-09-06video_core: Remove all Core::System references in rendererReinUsesLisp53-633/+573
Now that the GPU is initialized when video backends are initialized, it's no longer needed to query components once the game is running: it can be done when yuzu is booting. This allows us to pass components between constructors and in the process remove all Core::System references in the video backend.
2020-09-05configure_input: Hook up the motion button and checkboxMorph7-7/+19
This allows toggling motion on or off, and allows access to the motion configuration. Also changes the [waiting] text for motion buttons to Shake! as this is how motion is connected to a player.
2020-09-05Minor cleanupgerman1-19/+16
2020-09-05Add cemu hook changes related to PR #4609german8-139/+449
2020-09-05Remove RealMotionDevicegerman7-35/+41
2020-09-05configure_input_player: Show/hide motion buttons based on the controllerMorph3-103/+141
2020-09-05controllers/npad: Simplify motion entry assignmentMorph1-29/+18
Simplifies the motion assignment in the Dual Joycon entry and assigns index 1 of the motion entry (Motion 2) for the right joycon.
2020-09-05Include HID and configuration changes related to motiongerman13-16/+448
2020-09-04hid: Implement MergeSingleJoyasDualJoyMorph3-5/+24
- Used in multiple games such as Super Mario Odyssey.
2020-09-04applets/controller: Resolve several compiler warningsMorph2-7/+8
Resolves -Wsign-compare and -Wunused-variable
2020-09-04Address feedbackMorph4-2/+12
2020-09-04clang-formatMorph2-2/+4
2020-09-04applets/controller: Set min_players to have a minimum value of 1.Morph1-1/+1
- Some games like Shipped have a minimum requirement of 0 connected players and is undesired behavior. We must require a minimum of 1 player connected regardless of what games may ask.
2020-09-04applets/controller: Modify heuristic to account for certain gamesMorph1-7/+12
Now left and right joycons have the same priority (meaning both needs to be supported by the game). Explanation of the new heuristic: Assign left joycons to even player indices and right joycons to odd player indices. We do this since Captain Toad Treasure Tracker expects a left joycon for Player 1 and a right Joycon for Player 2 in 2 Player Assist mode.
2020-09-04main: Apply settings after applet configuration is complete.Morph1-0/+4
2020-09-04applets/controller: Implement fallback applet for the SDL frontendMorph3-90/+34
Implement the fallback applet for the SDL frontend, connecting only the minimum amount of players required.
2020-09-04applets/controller: Load configuration prior to setting up connectionsMorph2-23/+29
This avoids unintentionally changing the states of elements while loading them in.
2020-09-04applets/controller: Make 8 a static constexpr value of NUM_PLAYERSMorph2-15/+22
Avoids repetitive usages of the int literal '8' or calls to player_widgets.size()
2020-09-04applets/controller: Implement "Explain Text"Morph6-25/+304
"Explain Text" is additional text that is shown for each player in the controller applet.
2020-09-04Project Mjölnir: Part 2 - Controller AppletMorph20-59/+3803
Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-09-03file_sys/patch_manager: Add missing includeReinUsesLisp1-0/+1
Fixes build issues
2020-09-02main: Use three dots to complete the ellipsislat9nq1-1/+1
Fixes a typo in the UI file. An ellipsis has 3 dots.
2020-09-02input_common/motion_input: Make use of Common::PI constantMorph3-5/+10
Also amend the copyright notice to yuzu's instead of Dolphin's, which was mistakenly copy-pasted from another file.
2020-08-31vk_device: Fix driver id check on AMD for VK_EXT_extended_dynamic_stateReinUsesLisp1-6/+9
'driver_id' can only be known on Vulkan 1.1 after creating a logical device. Move the driver id check to disable VK_EXT_extended_dynamic_state after the logical device is successfully initialized. The Vulkan device will have the extension enabled but it will not be used.
2020-08-30externals: Update Xbyak to 5.96Lioncash2-21/+21
I made a request on the Xbyak issue tracker to allow some constructors to be constexpr in order to avoid static constructors from needing to execute for some of our register constants. This request was implemented, so this updates Xbyak so that we can make use of it.
2020-08-30Address second batch of reviewsFearlessTobi9-30/+27
2020-08-29configure_input_player: Resolve sign conversion warnings in UpdateMappingWithDefaults()Lioncash1-2/+2
Prevents sign mismatch warnings in the loop conditionals.
2020-08-29Reolve reorder warningFearlessTobi2-3/+3
2020-08-29Address review comments and fix code compilationFearlessTobi13-155/+218
2020-08-29bootmanager: Prevent unnecessary copies in TouchUpdateEvent()Lioncash1-1/+1
The list of points is returned by const reference, so we don't need to make a copy of every element in the list.
2020-08-29game_list_p: Avoid string churn in GameListItemPath data()Lioncash1-4/+8
2020-08-29game_list_p: Mark some constants as constexprLioncash1-10/+10
Consistency change with how we mark constants in the rest of the codebase.
2020-08-29yuzu: Add motion and touch configurationFearlessTobi18-3/+1889
2020-08-29yuzu/main: Amend lifetime issues with InputSubsystemLioncash4-7/+8
Due to the way Qt performs destruction of parent/child widgets, we need to make the lifetime of the input subsystem shared across the main window and the render window.
2020-08-29yuzu/configuration: Fix index out of bounds for default_analogsMorph3-12/+13
2020-08-29sdl_impl: Reduce allocations in GetButtonMappingForDevice()Lioncash1-31/+37
These maps can be constexpr arrays of std::pair.
2020-08-29sdl_impl: Make use of std::move on std::string where applicableLioncash1-3/+3
Avoids redundant copies.
2020-08-29sdl_impl: Make use of insert_or_assign() where applicableLioncash1-14/+18
Avoids churning ParamPackage instances.
2020-08-29sdl_impl: Prevent type truncation in BuildAnalogParamPackageForButton() default argumentsLioncash1-1/+1
We need to add the 'f' suffix to make the right hand side a float and not a double.
2020-08-29sdl_impl: Simplify make_tuple callLioncash1-1/+1
The purpose of make_tuple is that you don't need to explicitly type out the types of the things that comprise said tuple. Given this just returns default values, we can simplify this a bit.
2020-08-29sdl_impl: Mark FromEvent() as a const member functionLioncash1-2/+2
This doesn't modify internal member state, so it can be marked as const.
2020-08-29input_common/main: Remove unnecessary headersLioncash3-5/+11
2020-08-29input_common/main: Remove unimplemented prototypeLioncash1-3/+0
I forgot to remove this in the rebase when removing most of the global variables within the input common codebase.
2020-08-29vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_stateReinUsesLisp1-1/+6
Vertex binding's <stride> is bugged on AMD's proprietary drivers when using VK_EXT_extended_dynamic_state. Blacklist it for now while we investigate how to report this issue to AMD.
2020-08-28Fix orientation errors and improve drift correctiongerman2-14/+31
2020-08-28Address commentsgerman2-85/+65
2020-08-28Implement a basic class for motion devicesgerman4-0/+279
2020-08-27input_common: Eliminate most global stateLioncash25-242/+396
Abstracts most of the input mechanisms under an InputSubsystem class that is managed by the frontends, eliminating any static constructors and destructors. This gets rid of global accessor functions and also allows the frontends to have a more fine-grained control over the lifecycle of the input subsystem. This also makes it explicit which interfaces rely on the input subsystem instead of making it opaque in the interface functions. All that remains to migrate over is the factories, which can be done in a separate change.
2020-08-27input_common/main: Add "/Mouse" to the display nameMorph1-1/+1
2020-08-27memory_manager: Make use of [[nodiscard]] in the interfaceLioncash1-17/+17
2020-08-27memory_manager: Make operator+ const qualifiedLioncash1-1/+1
This doesn't modify member state, so it can be marked as const.
2020-08-26configure_input_player: Fix modifier scale button mappingMorph2-20/+19
2020-08-26configuration/input: Add support for mouse button clicksMorph5-11/+82
Supports the Left, Right, Middle, Backward and Forward mouse buttons.
2020-08-26controllers/npad: Fix inconsistencies with controller connection statusesMorph1-1/+7
2020-08-26controllers/npad: Fix LibNX controller connection statusesMorph1-1/+9
This allows homebrew applications to be able to properly detect connected controllers.
2020-08-26controllers/npad: Fix LedPattern for P1-4Morph1-3/+3
2020-08-26input_common: Fix directional deadzone valuesMorph2-2/+2
The hardware tested value is 0.5 which translates to SHRT_MAX / 2
2020-08-26Address feedbackMorph13-96/+77
2020-08-26Project Mjölnir: Part 1Morph43-3177/+8306
Co-authored-by: James Rowe <jroweboy@gmail.com> Co-authored-by: Its-Rei <kupfel@gmail.com>
2020-08-26gc_poller: Resolve compilation warnings on MSVCLioncash1-3/+5
We just need to make our intentional implicit truncations explicit.
2020-08-26hle/scheduler: Fix data race in is_context_switch_pendingReinUsesLisp1-2/+6
As reported by tsan, SelectThreads could write to is_context_switch_pending holding a mutex while SwitchToCurrent reads it without holding any. It is assumed that the author didn't want an atomic here, so the code is reordered so that whenever is_context_switch_pending is read inside SwitchToContext, the mutex is locked.
2020-08-26hle/kernel: Fix data race in GetCurrentHostThreadIDReinUsesLisp1-1/+2
As reported by tsan, host_thread_ids could be read while any of the RegisterHostThread variants were called. To fix this, lock the register mutex when yuzu is running in multicore mode and GetCurrentHostThreadID is called.
2020-08-26common/thread: Fix data race in is_setReinUsesLisp1-4/+5
As report by tsan, Event::Set can write is_set while WaitFor and friends are reading from it. To address this issue, make is_set an atomic.
2020-08-26cpu_interrupt_handler: Misc style changesReinUsesLisp2-5/+3
2020-08-26cpu_interrupt_handler: Make is_interrupted an atomicReinUsesLisp2-2/+3
Fixes a race condition detected from tsan
2020-08-25logging/settings: Increase maximum log size to 100 MB and add extended logging optionM&M5-11/+54
The extended logging option is automatically disabled on boot but can be enabled afterwards, allowing the log file to go up to 1 GB during that session. This commit also fixes a few errors that are present in the general debug menu.
2020-08-24common_funcs: Add missing XOR operators to DECLARE_ENUM_FLAG_OPERATORSLioncash1-4/+10
Ensures that the full set of bitwise operators are available for types that make use of this macro.
2020-08-24common/assert: Make use of C++ attribute syntaxLioncash1-3/+4
Normalizes the syntax used for attributes
2020-08-24async_shaders: Mark getters as const member functionsLioncash2-17/+15
While we're at it, we can also mark them as nodiscard.
2020-08-24memory_manager: Mark IsGranularRange() as a const member functionLioncash2-3/+3
This doesn't modify internal member state, so it can be marked as const.
2020-08-24gl_texture_cache: Take std::string by reference in DecorateViewName()Lioncash2-2/+2
LabelGLObject takes a string_view, so we don't need to make copies of the std::string.
2020-08-24video_core/fence_manager: Remove unnecessary includesLioncash3-9/+4
Avoids pulling in unnecessary things that can cause rebuilds when they aren't required.
2020-08-24video_core/host_shaders: Add CMake integration for string shadersReinUsesLisp7-42/+106
Add the necessary CMake code to copy the contents in a string source shader (GLSL or GLASM) to a header file then consumed by video_core files. This allows editting GLSL in its own files without having to maintain them in source files. For now, only OpenGL presentation shaders are moved, but we can add GLASM presentation shaders and static SPIR-V generation through glslangValidator in the future.
2020-08-24gl_shader_util: Use std::string_view instead of star pointerReinUsesLisp5-9/+21
This allows us passing any type of string and hinting the length of the string to the OpenGL driver.
2020-08-23fsp_srv: Resolve -Wunused-but-set-variable warningLioncash1-1/+8
We can just log out the parameters in the meantime.
2020-08-23file_sys: Replace inclusions with forward declarations where applicableLioncash27-37/+66
Same behavior, minus unnecessary inclusions where not necessary.
2020-08-23fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()Lioncash1-2/+5
Initialize id to a deterministic value and also mark the unreachable cases in the switch with UNREACHABLE().
2020-08-23registered_cache: Make use of ends_with for string suffix checkingLioncash1-2/+1
Simplifies code.
2020-08-23registered_cache: Make use of designated initializersLioncash1-15/+15
Removes the need for comments to indicate the fields being assigned.
2020-08-23key_manager: Make data arrays constexprLioncash2-75/+82
We can convert these maps into constexpr arrays to eliminate some runtime static constructors.
2020-08-23cpu_manager: Make use of ranged for where applicableLioncash1-16/+13
We can simplify a few loops by making use of ranged for.
2020-08-23core_timing: Remove unused headerLioncash3-2/+2
2020-08-23core_timing: Move clock initializer into constructor initializer listLioncash1-4/+2
Same behavior, minus unnecessary zeroing out of the pointer.
2020-08-23core_timing: Resolve sign conversion warningLioncash1-2/+2
This constant is only ever assigned to downcount, which is a s64, not a u64.
2020-08-23web_service: Move web_result.h into web_serviceLioncash7-47/+41
This is the only place it's actively used. It's also more appropriate for web-related structures to be within the web service target. Especially given this one doesn't rely on anything in the common library.
2020-08-22video_core: Initialize renderer with a GPUReinUsesLisp22-119/+172
Add an extra step in GPU initialization to be able to initialize render backends with a valid GPU instance.
2020-08-21vk_state_tracker: Fix primitive topologyReinUsesLisp3-13/+14
State track the current primitive topology with a regular comparison instead of using dirty flags. This fixes a bug in dirty flags for this particular state and it also avoids unnecessary state changes as this property is stored in a frequently changed bit field.
2020-08-20vk_device: Use Vulkan 1.0 properlyReinUsesLisp5-52/+66
Enable the required capabilities to use Vulkan 1.0 without validation errors and disable those that are not compatible with it.
2020-08-20renderer_vulkan: Create a Vulkan 1.0 instance when 1.1 is not availableReinUsesLisp3-6/+26
This commit doesn't make yuzu compatible with Vulkan 1.0 yet, it only creates an 1.0 instance.
2020-08-20Revert "common/time_zone: Simplify GetOsTimeZoneOffset()"bunnei1-5/+9
2020-08-18common/telemetry: Migrate namespace into the Common namespaceLioncash13-35/+43
Migrates the Telemetry namespace into the Common namespace to make the code consistent with the rest of our common code.
2020-08-18vfs_real: Resolve sign conversion warningsLioncash1-2/+2
2020-08-18vfs_real: Avoid redundant map lookupsLioncash1-30/+46
Avoids some trivially avoidable map lookups by keeping the result of find operations around and querying them.
2020-08-18common/color: Migrate code over to the Common namespaceLioncash1-2/+2
No external code makes use of this header, so we can freely change the namespace.
2020-08-18common/concepts: Move <type_traits> include out of the Common namespaceLioncash1-2/+2
This is a compiler/linker error waiting to happen.
2020-08-16Remove unneeded newlines, optional Registry in shader paramsameerj5-14/+9
Addressing feedback from Rodrigo
2020-08-16Morph: Update worker allocation commentAmeer J1-1/+1
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2020-08-16move thread 1/4 count computation into allocate workers methodameerj4-23/+14
2020-08-16Address feedback, add shader compile notifier, update setting textameerj9-162/+117
2020-08-16Vk Async Worker directly emplace in cacheameerj3-58/+41
2020-08-16Address feedback. Bruteforce delete duplicatesameerj7-80/+116
2020-08-16Vk Async pipeline compilationameerj13-20/+182
2020-08-16Preliminary effectsDavid Marcec10-35/+731
2020-08-16dynarmic: Add unsafe optimizationsMerryMage7-4/+108
2020-08-16configure_hotkeys: Don't translate empty stringsLioncash1-2/+2
There's no need to translate an empty string. This just gives translators unnecessary work.
2020-08-16common/fileutil: Convert namespace to Common::FSLioncash40-547/+639
Migrates a remaining common file over to the Common namespace, making it consistent with the rest of common files. This also allows for high-traffic FS related code to alias the filesystem function namespace as namespace FS = Common::FS; for more concise typing.
2020-08-16common: Silence two discarded result warningsLioncash2-3/+3
These are intentionally discarded internally, since the rest of the public API allows querying success. We want all non-internal uses of these functions to be explicitly checked, so we can signify that we intentionally want to discard the return values here.
2020-08-16common/time_zone: Simplify GetOsTimeZoneOffset()Lioncash1-9/+5
We can simplify this function down into a single line with the use of fmt. A benefit with the fmt approach is that the fmt variant of localtime is thread-safe as well, making GetOsTimeZoneOffset() thread-safe as well.
2020-08-16yuzu: Resolve -Wextra-semi warningsLioncash3-6/+6
While we're in the same area, we can ensure GameDir member variables are always initialized to consistent values.
2020-08-16main: Add an option to modify the currrent game's configurationlat9nq3-20/+46
Creates a new entry in the Emulation menu called "Configure Current Game..." that is only available if a game is currently being executed in yuzu. When selected, it opens the game properties dialog for the current game. Thanks to @BSoDGamingYT for reminding me to do this.
2020-08-15common/compression: Roll back std::span changesLioncash5-38/+45
Seems like all compilers don't support std::span yet.
2020-08-15common: Make use of [[nodiscard]] where applicableLioncash34-358/+343
Now that clang-format makes [[nodiscard]] attributes format sensibly, we can apply them to several functions within the common library to allow the compiler to complain about any misuses of the functions.
2020-08-14configuration_shared: Simplify name lookup in highlighting functionsLioncash7-90/+74
We can query the given object name directly from the widget itself. This removes any potential for forgetting to change the name if the widget gets renamed and makes the API much simpler (just pass in the widget, and not worry about its name).
2020-08-14yuzu: Make use of qOverload where applicableLioncash1-2/+1
Eliminates a verbose function cast.
2020-08-14time_zone_content_manager: Collapse auto and default caseLioncash1-3/+1
Prevents a useless self-assignment from occurring.
2020-08-14Disable biquad filterDavid Marcec1-8/+9
2020-08-14software_keyboard: Resolve a pessimizing move warningLioncash1-2/+1
A std::vector created in place like this is already an rvalue and doesn't need to be moved.
2020-08-14core: Resolve several -Wextra-semi warningsLioncash3-7/+12
We can amend one of the cascade macros to require semicolons in order to compile. In other cases, we can just remove the superfluous semicolons.
2020-08-14shader/memory: Amend UNIMPLEMENTED_IF_MSG without a messageLioncash1-1/+2
We need to provide a message for this variant of the macro, so we can simply log out the type being used.
2020-08-14macro-interpreter: Resolve -Wself-assign-field warningLioncash1-1/+0
This was assigning the field to itself, which is a no-op. The size doesn't change between its initial assignment and this one, so this is a safe change to make.
2020-08-14vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()Lioncash1-1/+1
Given this is implicitly creating a std::optional, we can move the vector into it.
2020-08-14gl_shader_disk_cache: Make use of std::nullopt where applicableLioncash1-11/+12
Allows the compiler to avoid unnecessarily zeroing out the internal buffer of std::optional on some implementations.
2020-08-14async_shaders: Resolve -Wpessimizing-move warningLioncash1-2/+2
Prevents pessimization of the move constructor (which thankfully didn't actually happen in practice here, given std::thread isn't copyable).
2020-08-14maxwell_3d: Resolve -Wextra-semi warningLioncash1-1/+1
Semicolons after a function definition aren't necessary.
2020-08-14Reworked ADPCM decoder to allow better streamingDavid Marcec2-33/+95
2020-08-14emu_window: Mark Scoped constructor and Acquire() as nodiscardLioncash1-2/+2
Ensures that callers make use of the constructor, preventing bugs from silently occurring.
2020-08-14kernel/scheduler: Mark SchedulerLock constructor as nodiscardLioncash1-1/+1
Allows the compiler to warn about cases where the constructor is used but then immediately discarded, which is a potential cause of locking/unlocking bugs.
2020-08-13General: Tidy up clang-format warnings part 2Lioncash17-117/+129
2020-08-12gl_shader_cache: Use std::max() for determining num_workersMorph1-1/+1
Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.
2020-08-11textures/decoders: Fix block linear to pitch copiesReinUsesLisp3-34/+34
There were two issues with block linear copies. First the swizzling was wrong and this commit reimplements them. The other issue was that these copies are generally used to download render targets from the GPU and yuzu was not downloading them from host GPU memory unless the extreme GPU accuracy setting was selected. This commit enables cached memory reads for all accuracy levels. - Fixes level thumbnails in Super Mario Maker 2.
2020-08-10Remove UI changesameerj5-86/+5
This PR is now only the Analog devices handling the range value defaulting at 100%
2020-08-10Add range slider functionality for gc adapterameerj1-7/+7
2020-08-10undo unnecessary newlines, slider range 50-150Ameer3-6/+5
2020-08-10Address c++20 warning, fix inaccurate range text display when slide == 0Ameer1-2/+2
2020-08-10Add range slider for analog sticksAmeer4-14/+99
2020-08-09General: Tidy up clang-format warningsLioncash1-1/+1
2020-08-07common/concepts: Rename IsBaseOf to DerivedFromLioncash3-6/+8
This makes it more inline with its currently unavailable standardized analogue std::derived_from. While we're at it, we can also make the template match the requirements of the standardized variant as well.
2020-08-06freezer: Move entry finding to its own functionLioncash2-12/+21
Cleans up the callsites in other functions.
2020-08-06freezer: Take address values by valueLioncash1-3/+3
VAddr will always be 64-bit, so there's no need to take a trivial primitive alias by reference.
2020-08-06freezer: Make use of std::erase_ifLioncash1-4/+1
With C++20 we can simplify the erasing idiom.
2020-08-06cheat_engine: Resolve implicit bool->u64 conversionLioncash1-1/+1
We can just return zero here.
2020-08-06cheat_engine: Make use of designated initializersLioncash1-6/+18
Same behavior, but makes the member being assigned obvious.
2020-08-06partition_data_manager: Update master key hashesLioncash1-5/+5
Fills in some hashes that were previously unhandled.
2020-08-06partition_data_manager: Make data arrays constexprLioncash4-138/+141
Previously the constructor for all of these would run at program startup, consuming time before the application can enter main(). This is also particularly dangerous, given the logging system wouldn't have been initialized properly yet, yet the program would use the logs to signify an error. To rectify this, we can replace the literals with constexpr functions that perform the conversion at compile-time, completely eliminating the runtime cost of initializing these arrays.
2020-08-06partition_data_manager: Eliminate magic valueLioncash1-2/+2
We can use sizeof to make it obvious at the call site where the value is coming from.
2020-08-06aes_util: Make use of non-template variant of TranscodeLioncash1-1/+1
Same behavior, less template instantiations.
2020-08-06Fix thread naming on Linux, which limits names to 15 bytes.comex2-1/+13
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and do nothing. - Also, add logging in case `pthread_set_name_np` returns an error anyway. This is Linux-specific, as the Apple and BSD versions of `pthread_set_name_np return `void`. - Change the name for CPU threads in multi-core mode from "yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it fits into the Linux limit. Some other thread names are also cut off, but I didn't bother addressing them as you can guess them from the truncated versions. For a CPU thread, truncation means you can't see which core it is!
2020-08-05common/virtual_buffer: drop unused includesJan Beich1-9/+0
On DragonFly and NetBSD build fails with src/common/virtual_buffer.cpp src/common/virtual_buffer.cpp:16:10: fatal error: sys/sysinfo.h: No such file or directory #include <sys/sysinfo.h> ^~~~~~~~~~~~~~~
2020-08-05system_control: Make functions internally linked where applicableLioncash2-15/+11
These functions are only ever used internally as implementation details for GenerateRandomRange(), so these can be given internal linkage.
2020-08-05kernel: Remove unused variablesLioncash2-18/+11
Resolves a few compiler warnings.
2020-08-05scheduler: Resolve sign conversion warningLioncash1-1/+2
2020-08-05address_arbiter: Resolve sign conversion warningLioncash1-1/+1
Makes our type conversion explicit.
2020-08-05ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()Lioncash1-0/+4
It's undefined behavior to use non-trivially copyable objects with std::memcpy, so we can add asserts to catch usages of these at compile-time.
2020-08-05vfs_vector: Make creation of array vfs files less verboseLioncash4-41/+41
We can add a helper function to make creation of these files nicer. While we're at it, we can eliminate an unnecessary std::array copy in the constructor. This makes the overhead on some of these functions way less intensive, given some arrays were quite large. e.g. The timezone location names are 9633 bytes in size.
2020-08-05main: Fallback to loader if no control nca is found with patch managerMorph1-6/+17
In some rare instances, the patch manager is not able to find a control nca, fallback to the previous method of parsing a control nca through the loader if this occurs.
2020-08-05main: Fix Open Save/Mod Locations for installed titlesMorph4-12/+12
Previously NAND/SDMC installed titles would open device saves when they are supposed to be user saves. This is due to the control nca not being read and thus returns 0 for both GetDefaultNormalSaveSize() and GetDeviceSaveDataSize(). Fix this by utilizing the patch manager to read the control nca.
2020-08-05game_list_worker: Do not clear entries when > 1 gamedir is presentMorph1-1/+1
Previously the map of entries was being cleared while looping through each game directory, this resulted into all game directories except the last game dir to lose content metadata information. Fix this by clearing the entries only once.
2020-08-03aes_util: Allow SetIV to be non-allocatingLioncash7-27/+36
In a few places, the data to be set as the IV is already within an array. We shouldn't require this data to be heap-allocated if it doesn't need to be. This allows certain callers to reduce heap churn.
2020-08-03perf_stats: Make use of designated initializersLioncash1-6/+7
Same behavior, but allows us to avoid a now-unnecessary zero initialization.
2020-08-03perf_stats: Mark GetMeanFrametime() as constLioncash2-9/+9
The general pattern is to mark mutexes as mutable when it comes to matters of constness, given the mutex acts as a transient member of a data structure.
2020-08-03vulkan: Silence more -Wmissing-field-initializer warningsLioncash6-3/+18
2020-08-03yuzu: Resolve C++20 deprecation warnings related to lambda capturesLioncash9-81/+88
C++20 deprecates capturing the this pointer via the '=' capture. Instead, we replace it or extend the capture specification.
2020-08-03service/ldr: Resolve sign mismatch warningsLioncash1-3/+2
We were performing an int < size_t comparison. We can just correct the type of the induction variable.
2020-08-03CMakeLists: Resolve #4478Lioncash1-1/+6
This switch is enabled by default in all recent versions of GCC and Clang.
2020-08-03tests/core_timing: Remove pragma optimize(off)Lioncash1-9/+5
I made a review comment about this in the PR that this was introduced in (#3955, commit 71c4779211dc081a3b2dd4af52edad5748e7a7f5), but it seems to have been missed. We shouldn't be using this pragma here because it's MSVC specific. This causes warnings on other compilers. The test it's surrounding is *extremely* dubious, but for the sake of silencing warnings on other compilers, we can mark "placebo" as volatile and be on with it.
2020-08-03time_zone_binary: Make use of designated initializersLioncash1-17/+25
2020-08-03logging/backend: Make use of designated initializersLioncash2-21/+15
Same behavior, less code.
2020-08-03buffer_queue: Make use of std::nulloptLioncash1-5/+6
Allows compilers to eliminate unnecessary zeroing out of the optional's buffer.
2020-08-03buffer_queue: Make use of designated initializersLioncash1-5/+5
2020-08-03profile_manager: Make use of std::nulloptLioncash1-4/+4
Allows some implementations to completely avoid unnecessarily zeroing out the internal buffer.
2020-08-03profile_manager: Make use of designated initializersLioncash1-13/+22
More compact code.
2020-08-03dmnt_cheat_vm: Make use of designated initializersLioncash1-105/+121
Allows for more compact code.
2020-08-03file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with ModeLioncash2-18/+21
Same behavior, minus a hand-rolled operator.
2020-08-03sm: Make use of IsBaseOf for GetServiceDavid Marcec1-3/+2
2020-08-03patch_manager: Resolve -Wignored-qualifier warningsLioncash1-2/+2
Top level const will always be ignored in this case, so it can be removed.
2020-08-03registered_cache: Resolve -Wmaybe_uninitialized warningsLioncash1-10/+15
While we're at it, we can avoid a redundant map lookup.
2020-08-03Place in anonymous namespaceDavid Marcec1-0/+4
2020-08-03loader: Make IdentifyFile typesafeDavid Marcec1-20/+32
Relies on #4465 for concept.h Common::IsBaseOf
2020-08-03ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465)David12-30/+64
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer With the support of C++20, we can use concepts to deduce if a type is an STL container or not. * More agressive concept for stl containers * Add -fconcepts * Move to common namespace * Add Common::IsBaseOf
2020-08-01mix buffer depoppingDavid Marcec2-30/+101
2020-07-31minor nitsMorph1-1/+3
2020-07-31am: Unstub SetScreenShotPermissionDavid Marcec2-1/+12
2020-07-30fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttributeMorph2-23/+56
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
2020-07-30fs: Rename SaveDataDescriptor to SaveDataAttributeMorph5-41/+63
2020-07-30adpcm streamingDavid Marcec4-27/+32
2020-07-29game_list_worker: Fix game list subdirectory scanningMorph1-2/+2
Oddly enough the scan that feeds the manual content provider is hardcoded to scan 2 nested directories deep. This effectively rendered the scan subdirectories setting useless as the manual content provider cannot find any games located more than 2 nested directories deep. Furthermore, this behavior causes game files to be picked up by the manual content provider even if scan subdirectories is disabled. FIx this by utilizing the behavior described when populating the game list for populating the content provider.
2020-07-29main: Add support for removing SDMC installed titlesMorph1-14/+13
2020-07-29xts_archive: Check if the file is nullptr prior to parsingMorph1-5/+9
Fixes an access violation where the file no longer exists at the specified path while being parsed.
2020-07-29registered_cache: Add support for removing folder ncasMorph2-53/+54
2020-07-29game_list: Limit context menu options for homebrewMorph1-1/+7
Hides the following options when the title id is 0: - Open Save Location - Open Mod Data Location - Open Transferable Shader Cache - All removal options except Remove Custom Configuration
2020-07-29main: Remove assert for opening savedata when program_id = 0Morph1-1/+0
2020-07-29main: Silence [[fallthrough]] warningMorph1-3/+2
2020-07-29main: Split removal cases into their individual functions and address feedbackMorph2-113/+131
2020-07-29main: Connect game list remove signals to removal functionsMorph2-5/+167
2020-07-29game_list: Add "Remove" context menuMorph2-4/+37
Adds the following actions: - Remove Installed Update - Remove All Installed DLC - Remove Shader Cache - Remove Custom Configuration - Remove All Installed Contents
2020-07-28configure_graphics: Remove Force 30 FPS modeMorph6-25/+0
The introduction of multicore rendered this setting non-functional as timing code was changed. This removes the setting entirely.
2020-07-28renderer_opengl: Use 1/4 of all threads for async shader compilationMorph1-9/+4
2020-07-28common/atomic_ops: Don't cast away volatile from pointersLioncash3-27/+30
Preserves the volatility of the pointers being casted.
2020-07-28service/bsd: Handle Poll with no entries accuratelyReinUsesLisp1-0/+5
Testing shows that Poll called with zero entries returns -1 and signals an errno of zero.
2020-07-28services/bsd: Implement most of bsd:sReinUsesLisp5-55/+911
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName, GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom, Send, SendTo, Write, and Close The implementation was done referencing: SwIPC, switchbrew, testing with libnx and inspecting its code, general information about bsd sockets online, and analysing official software. Not everything from these service calls is implemented, but everything that is not implemented will be logged in some way.
2020-07-28service/sockets: Add worker pool abstractionReinUsesLisp1-0/+30
Manage worker threads with an easy to use abstraction. We can expand this to support thread deletion in the future.
2020-07-28service/sockets: Add worker abstraction to execute blocking calls asynchronouslyReinUsesLisp2-0/+133
This abstraction allows executing blocking functions (like recvfrom on a socket configured for blocking) without blocking the service thread. It is intended to be used with SleepClientThread.
2020-07-28service/sockets: Add translate functionsReinUsesLisp3-0/+215
These functions translate from Network enumerations/structures to guest enumerations/structures and viceversa.
2020-07-28service/sockets: Add enumerations and structuresReinUsesLisp2-0/+81
Add guest enumerations and structures used in socket services
2020-07-28services/nifm: Implement GetCurrentIpAddressReinUsesLisp1-1/+12
This is trivially implemented using the Network abstraction - Used by ftpd
2020-07-28device_memory: Remove unused system memberLioncash3-11/+4
This isn't used by anything in particular, so it can be removed.
2020-07-28cpu_manager: Remove redundant std::function declarationsLioncash1-3/+3
We can just return the function directly. Making for less reading.
2020-07-28Update src/core/hle/service/nvdrv/devices/nvmap.cppbunnei1-1/+1
Co-authored-by: LC <mathew1800@gmail.com>
2020-07-28core_timing: Make use of uintptr_t to represent user_dataLioncash15-43/+52
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
2020-07-28yuzu/main: Remove redundant usages of QStringLiteral("")Lioncash1-6/+5
An empty QStringLiteral can more efficiently be replaced with an empty QString.
2020-07-27remove unused variable;CrazyMax1-1/+0
2020-07-26GCAdapter: only join worker thread if running & joinableBrian J. Tarricone1-1/+3
2020-07-26video_core/gpu: Correct the size of the puller registersBilly Laws1-2/+2
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
2020-07-26config: Make the save-as identifier more consistentlat9nq1-2/+2
Solves an issue with restoring the value upon reloading program.
2020-07-26hle: nvdrv: Rewrite of GPU memory management.bunnei6-593/+431
2020-07-26yuzu/configure_debug: Remove duplicated checkboxesFearlessTobi1-22/+0
Those are already found in the Filesystem tab. They were added back to the Debug tab by mistake in the Vulkan PR.
2020-07-26nvflinger: Mark interface functions with return values as [[nodiscard]]Lioncash1-16/+14
Not using the return value of these functions are undeniably the source of a bug. This way we allow compilers to loudly make any future misuses evident.
2020-07-26nvflinger: Use return value of Lock()Lioncash3-4/+4
comex reported in #4424 that we were incorrectly discarding the return value of Lock() which is correct.
2020-07-25common/string_util: Remove unimplemented function prototype (#4414)LC1-12/+0
This function was relocated to log.h as a constexpr function, so this can be removed.
2020-07-25Fix perf regressionDavid Marcec1-1/+2
2020-07-25vulkan: Resolve -Wmissing-field-initializer warningsLioncash2-0/+4
2020-07-25udp/client: Remove unused boost includeLioncash1-1/+0
Also silences a deprecation warning from boost on Clang/GCC.
2020-07-25gc_adapter: Resolve C++20 deprecation warningLioncash1-1/+1
2020-07-25gc_poller: Resolve -Wsign-compare warningLioncash1-1/+2
2020-07-25gc_poller: Resolve -Wredundant-move warningLioncash1-2/+1
2020-07-25lz4_compression: Make use of std::span in interfacesLioncash2-17/+14
Allows compressing the data and size parameters into one.
2020-07-25zstd_compression: Make use of std::span in interfacesLioncash3-13/+10
Allows condensing the data and size parameters into a single argument.
2020-07-25virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]Lioncash1-1/+1
This isn't used on Windows, but is used on non-Windows operating systems.
2020-07-25Fix stream channel count when outputting to stereoDavid Marcec1-1/+1
2020-07-25Address issuesDavid Marcec8-101/+104
2020-07-25Queue extra mix bufferDavid Marcec1-0/+1
2020-07-25Disable time stretcher for time beingDavid Marcec2-6/+4
2020-07-25audio_core: Apollo Part 1, AudioRenderer refactorDavid Marcec26-713/+4204
2020-07-23network: add missing include for BSDsJan Beich1-0/+2
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD' constexpr int SD_RECEIVE = SHUT_RD; ^ src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR' constexpr int SD_SEND = SHUT_WR; ^ src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR' constexpr int SD_BOTH = SHUT_RDWR; ^ src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'? constexpr IPv4Address TranslateIPv4(in_addr addr) { ^~~~~~~ in_addr_t /usr/include/netdb.h:66:20: note: 'in_addr_t' declared here typedef __uint32_t in_addr_t; ^ src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union const u32 bytes = addr.s_addr; ~~~~^~~~~~~ src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized const u32 bytes = addr.s_addr; ^ src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition sockaddr TranslateFromSockAddrIn(SockAddrIn input) { ^ /usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr' struct sockaddr *ai_addr; /* binary address */ ^ src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'? sockaddr_in result; ^~~~~~~~~~~ sockaddr /usr/include/netdb.h:142:9: note: 'sockaddr' declared here struct sockaddr *ai_addr; /* binary address */ ^ src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr' sockaddr_in result; ^ /usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr' struct sockaddr *ai_addr; /* binary address */ ^ src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET' result.sin_family = AF_INET; ^ src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET' result.sin_family = AF_INET; ^ src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons' result.sin_port = htons(input.portno); ^ src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr' sockaddr addr; ^ /usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr' struct sockaddr *ai_addr; /* binary address */ ^ src/core/network/network.cpp:156:1: error: unknown type name 'linger' linger MakeLinger(bool enable, u32 linger_value) { ^ src/core/network/network.cpp:157:5: error: unknown type name 'linger' linger value; ^ src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET' return AF_INET; ^ src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM' return SOCK_STREAM; ^ src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM' return SOCK_DGRAM; ^ src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP' return IPPROTO_TCP; ^ fatal error: too many errors emitted, stopping now [-ferror-limit=]
2020-07-21vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfoDavid Marcec1-1/+19
Needed for dark souls and monster hunter
2020-07-21surface_params: Make use of designated initializers where applicableLioncash1-38/+46
Provides a convenient way to avoid unnecessary zero initializing.
2020-07-21surface_params: Remove redundant assignmentLioncash1-1/+0
This is a redundant assignment that can be removed.
2020-07-21surface_params: Replace questionable usages of the comma operator with semicolonsLioncash1-9/+9
These are bugs waiting to happen.
2020-07-21video_core: Remove unused variablesLioncash8-33/+5
Silences several compiler warnings about unused variables.
2020-07-21vk_rasterizer: Remove unused variable in Clear()Lioncash1-4/+0
The relevant values are already assigned further down in the lambda, so this can be removed entirely.
2020-07-21compatible_formats: Add missing header guardLioncash1-0/+2
Prevents potential inclusion issues from occurring.
2020-07-21video_core: Allow copy elision to take place where applicableLioncash7-26/+26
Removes const from some variables that are returned from functions, as this allows the move assignment/constructors to execute for them.
2020-07-21configure_ui: Ensure a separator follows the returned pathlat9nq1-3/+5
2020-07-21configure_ui: don't use an empty stringlat9nq1-1/+3
If the user had cancelled, it would clear the text box. That behavior was sanitized underneath, but may anyways cause inconveniences.
2020-07-21main: Don't use as many string copieslat9nq1-6/+8
Co-Authored-By: LC <lioncash@users.noreply.github.com>
2020-07-21main: rewrite (save as) screenshot savinglat9nq1-9/+18
This picks a default directory and file name. If on Windows and save-as screenshot saving is enabled, it asks the user, first defaulting to the default screenshot path, and with a default filename in the format `[title_id]_[year-mt-dy_hr-mn-sc-msc].png`. Otherwise, or on Linux for now, it simply saves a file in that directory with that file name.
2020-07-21configuration: Setup UI to config screenshot path and savinglat9nq5-5/+93
This adds two options to the General -> UI tab. The first disables picking a place to save the file. The second chooses a default directory for saving screenshots.
2020-07-21common: Add a screenshots directorylat9nq3-0/+3
Adds a screenshots directory as a path managed by FileUtil.
2020-07-21video_core: Remove redundant pixel format typeDavid Marcec1-1/+0
We already get the format type before converting shadow formats and during shadow formats.
2020-07-20buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()Lioncash1-6/+3
We can make use of emplace()'s return value to determine whether or not we need to perform an increment. emplace() performs no insertion if an element already exist, so this can eliminate a find() call.
2020-07-20wait_tree: Include Midnight Blue dark themesMorph1-1/+4
2020-07-20qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)James Rowe2-1/+3
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2020-07-20Address issuesDavid Marcec1-2/+2
2020-07-19configure_graphics_advnaced: clang-format mk iilat9nq1-3/+3
2020-07-19configure_graphics_advanced: Fix oversight from rebaselat9nq1-1/+1
2020-07-19configuration_shared: Remove unused functionslat9nq2-18/+0
These were only kept for compatibility with old code during testing.
2020-07-19configuration: Use forward declares and remove extraneous structslat9nq10-63/+59
2020-07-19configuration_shared: Make CheckState strongly typedlat9nq2-24/+23
Also gets rid of unnecessary explicit namespace usage.
2020-07-19clang-formatlat9nq5-38/+32
2020-07-19configuration_shared: Break up tracker structs to respective classeslat9nq12-49/+58
One less global variable.
2020-07-19configure_system: break instead of semicolonlat9nq1-2/+4
Makes the code more readable Co-Authored-By: LC <lioncash@users.noreply.github.com>
2020-07-19clang-formatlat9nq3-8/+11
2020-07-19configure_system: Highlight labels on startuplat9nq1-0/+5
whoops
2020-07-19configure_graphics: Fix layout in global configlat9nq1-1/+1
Fixes a regression where the global config takes up a lot of extra space.
2020-07-19configure_per_game: Improve style consistencylat9nq3-54/+43
The way the configurations are set up, it is not trivial to do this. I'll leave it as is, but the API selection, and the background color and volume slider selectors are kind of not following the style.
2020-07-19configure_system: Implement highlighted overrideslat9nq3-539/+544
2020-07-19configuration_shared: Add default combobox setup functionlat9nq3-21/+52
Not a catch-all, but helps clean up the code for when I do this a lot. Also fixes some bugs caught in configure_graphics.
2020-07-19configuration_shared: Use an int instead of a QStringlat9nq4-22/+28
I noticed some of the code could be reduced to just passing the function an int, since I was doing the same thing over and over. Also clang-formats configure_graphics
2020-07-19configure_graphics_advanced: Implement highlighted overrideslat9nq3-96/+146
2020-07-19configuration_shared: Switch back to background colorslat9nq1-2/+2
Let's see if I make up my mind.
2020-07-19configuration_shared: Better use global textlat9nq2-0/+15
Also adds trackers for graphics and advanced graphics
2020-07-19configure_audio: fix UI marginslat9nq1-1/+10
2020-07-19configure_graphics: Implement highlighted overrideslat9nq2-134/+200
2020-07-19configure_audio: Implement highlighted overrideslat9nq2-80/+87
2020-07-19configuration_shared: Require name of the widget for highlightinglat9nq3-16/+27
Prevents mass-coloring of elements later on
2020-07-19configuration_shared: Use a highlight instead of background colorlat9nq2-6/+6
Fixes visibility in the built-in dark theme
2020-07-19configure_general: Implement manual tristate buttonslat9nq2-17/+27
2020-07-19configuration_shared: Initial functions and data for manual tristatelat9nq2-0/+58
Sets up initial support for implementing colored tristate functions. These functions color a QWidget blue when it's overriding a global setting, and discolor it when not. The lack of color indicates it uses the global state, replacing the Qt::CheckState::PartiallyChecked state with the global state.
2020-07-19Fix axis thresholding while pollingameerj1-5/+2
axes were very sensitive when mapping controls.
2020-07-19swkbd: Return result for Calc request for inlined swkbdDavid Marcec2-13/+49
Fixes random swkbd popups in monster hunter
2020-07-19core/network: Add network abstractionReinUsesLisp5-0/+840
This commit adds a network abstraction designed to implement bsd:s but at the same time work as a generic abstraction to implement any networking code we have to use from core. This is implemented on top of BSD sockets on Unix systems and winsock on Windows. The code is designed around winsocks having compatibility definitions to support both BSD and Windows sockets.
2020-07-19alignment: explicitly include <new> after 723edb4c0659Jan Beich1-0/+1
In file included from src/core/hle/kernel/memory/page_table.cpp:5: src/./common/alignment.h:67:68: error: no member named 'align_val_t' in namespace 'std' return static_cast<T*>(::operator new (n * sizeof(T), std::align_val_t{Align})); ~~~~~^ src/./common/alignment.h:71:51: error: no member named 'align_val_t' in namespace 'std' ::operator delete (p, n * sizeof(T), std::align_val_t{Align}); ~~~~~^
2020-07-18Address issuesDavid Marcec1-6/+3
2020-07-18Address trivial review comments.FearlessTobi1-1/+1
2020-07-18configure_ui: Address some review comments from the previous PRFearlessTobi2-16/+21
2020-07-18yuzu: Port translation support from CitraFearlessTobi10-84/+235
Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
2020-07-18frontend: Improve wait tree readability for dark themesDavid Marcec1-11/+44
2020-07-18gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shadersReinUsesLisp7-110/+173
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications to use what in Vulkan is known as physical pointers, this is basically C pointers. On GLASM these is exposed through the LOAD/STORE/ATOM instructions. Up until now, assembly shaders were using NV_shader_storage_buffer_object. These work fine, but have a (probably unintended) limitation that forces us to have the limit of a single stage for all shader stages. In contrast, with NV_shader_buffer_{load,store} we can pass GPU addresses to the shader through local parameters (GLASM equivalent uniform constants, or push constants on Vulkan). Local parameters have the advantage of being per stage, allowing us to generate code without worrying about binding overlaps.
2020-07-18Fix style issuesDavid Marcec2-7/+13
2020-07-18file_sys/nsp: Make SetTicketKeys actually do somethingFearlessTobi2-32/+30
Previously, the method wasn't modifying any class state and therefore not having any effects when called. Since this has been the case for a very long time now, I'm not sure if we couldn't just remove this method altogether.
2020-07-18vk_device: Fix build error on old MSVC versionsReinUsesLisp1-3/+3
Designated initializers on old MSVC versions fail to build when they take the address of a constant.
2020-07-17std::size_t where appropriate, make error message more clear if can't readameerj1-3/+4
2020-07-17alignment: Simplify AlignmentAllocator implementationLioncash1-43/+4
With C++20, much of the allocator interface has been simplified, so we can make the same adjustments.
2020-07-17Drop settings namespaceDavid Marcec1-2/+1
2020-07-17Remove duplicate configDavid Marcec2-2/+1
2020-07-17Use conditional varDavid Marcec2-9/+15
2020-07-17Drop max workers from 8->2 for testingDavid Marcec1-1/+1
2020-07-17Rebase for per game settingsDavid Marcec9-1/+53
2020-07-17async shadersDavid Marcec16-64/+598
2020-07-17macro_hle: Remove unnecessary static keywordsLioncash1-7/+4
These functions are already in an anonymous namespace which makes the functions internally linked.
2020-07-17core/CMakeLists: Add missing physical_memory.h header fileLioncash1-0/+1
Allows this header file to show up in IDE CMake generators.
2020-07-17macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()Lioncash1-2/+1
Given the expression involves a 32-bit value, this simplifies down to just: 0x3ffffff. This is likely a remnant from testing that was never cleaned up. Resolves a -Wshift-overflow warning.
2020-07-17macro_hle: Remove unnecessary std::make_pair callsLioncash1-3/+3
The purpose of make_pair is generally to deduce the types within the pair without explicitly specifying the types, so these usages were generally unnecessary, particularly when the type is enforced by the array declaration.
2020-07-17macro: Resolve missing parameter in doxygen commentLioncash1-1/+2
Resolves a -Wdocumentation warning.
2020-07-17constants: Add missing <array> includeLioncash1-0/+1
Eliminates reliance on an indirect include.
2020-07-17mii/manager: Resolve sign mismatch warningsLioncash1-3/+3
Previously the loop termination condition was testing variables of different signedness.
2020-07-17mii/manager: Make use of designated initializersLioncash1-53/+54
Allows returning the structure in a more concise manner.
2020-07-17wrapper: Make use of designated initializers where applicableLioncash1-56/+64
2020-07-17vk_texture_cache: Make use of designated initializers where applicableLioncash1-96/+135
2020-07-17vk_texture_cache: Amend mismatched access masks and indices in UploadBufferLioncash1-6/+4
Discovered while converting relevant parts of the codebase over to designated initializers.
2020-07-17vk_swapchain: Make use of designated initializers where applicableLioncash1-43/+51
2020-07-17vk_stream_buffer: Make use of designated initializers where applicableLioncash1-19/+16
2020-07-17vk_staging_buffer_pool: Make use of designated initializers where applicableLioncash1-13/+12
2020-07-17vk_shader_util: Make use of designated initializers where applicableLioncash1-7/+7
2020-07-17vk_scheduler: Make use of designated initializers where applicableLioncash1-27/+30
2020-07-17vk_sampler_cache: Make use of designated initializers where applicableLioncash1-24/+27
2020-07-17vk_resource_manager: Make use of designated initializers where applicableLioncash1-15/+14
2020-07-17vk_renderpass_cache: Make use of designated initializers where applicableLioncash1-59/+70
2020-07-17vk_rasterizer: Make use of designated initializers where applicableLioncash1-41/+47
2020-07-17vk_query_cache: Make use of designated initializers where applicableLioncash1-8/+8
2020-07-17vk_pipeline_cache: Make use of designated initializers where applicableLioncash1-31/+35
2020-07-17vk_memory_manager: Make use of designated initializers where applicableLioncash1-7/+6
2020-07-17vk_image: Make use of designated initializers where applicableLioncash1-15/+23
2020-07-17vk_descriptor_pool: Make use of designated initializers where applicableLioncash1-15/+18
2020-07-17vk_graphics_pipeline: Resolve narrowing warningsLioncash1-2/+4
For whatever reason, VK_TRUE and VK_FALSE aren't defined as having a VkBool32 type, so we need to cast to it explicitly.
2020-07-16vk_compute_pipeline: Make use of designated initializers where applicableLioncash1-63/+68
2020-07-16vk_compute_pass: Make use of designated initializers where applicableLioncash1-95/+99
Note: Some barriers can't be converted over yet, as they ICE MSVC.
2020-07-16vk_buffer_cache: Make use of designated initializers where applicableLioncash1-30/+33
Note: An array within CopyFrom() cannot be converted over yet, as it ICEs MSVC when converted over.
2020-07-16decode/other: Implement S2R.LaneIdReinUsesLisp1-2/+1
This maps to host's thread id. - Fixes graphical issues on Paper Mario.
2020-07-16gl_arb_decompiler: Execute BAR even when inside control flowReinUsesLisp1-4/+0
Unlike GLSL, GLASM allows us to call BAR inside control flow. - Fixes graphical artifacts in Paper Mario.
2020-07-16renderer_{opengl,vulkan}: Clamp shared memory to host's limitReinUsesLisp6-9/+42
This stops shaders from failing to build when the exceed host's shared memory size limit. An error is logged.
2020-07-16kernel/thread: Remove unimplemented function prototypeLioncash1-2/+0
This isn't used, so it can be removed.
2020-07-16kernel: Remove unused variablesLioncash3-7/+2
Resolves some compiler warnings in the Linux build.
2020-07-16kernel: Add missing includeLioncash1-0/+1
2020-07-16cpu_manager: Mark function getters as staticLioncash4-10/+11
All these do are return std::function instances of static functions, so these can be used without an instance of the CPU manager.
2020-07-16cpu_manager: Remove unused preemption_count variableLioncash1-1/+0
Shrinks the data structure by 8 bytes.
2020-07-16cpu_manager: Add missing includesLioncash1-0/+3
Previously this header was relying on indirect inclusions that are no longer satisfied.
2020-07-16Refactor adapter codeAmeer2-179/+44
2020-07-16hid: Only update keyboard & debug pad inputs if enabledDavid Marcec2-33/+37
Previously we would ignore this setting and would update the states regardless of the user setting
2020-07-16Check for empty section0 and CNMT prior to installMorph1-3/+19
2020-07-16Add comment to clarify the nullptr checkMorph1-0/+1
2020-07-16filesystem: Create subdirectories prior to creating a fileMorph1-0/+3
If subdirectories exist in the given path parameter and don't exist in the real filesystem create them prior to creating the files within. This fixes the softlocks upon save creation in The Legend of Zelda: Breath of the Wild
2020-07-16core_timing: Remove unused data memberLioncash1-2/+0
Shrinks the size of the CoreTiming class by 8 bytes.
2020-07-16core_timing: Make TimedCallback take std::chrono::nanosecondsLioncash16-58/+62
Enforces our desired time units directly with a concrete type.
2020-07-16core_timing: Make use of std::chrono with ScheduleEventLioncash13-49/+58
2020-07-15settings: Resolve a sign conversion warning within GetTimeZoneString()Lioncash1-5/+5
A sign conversion warning was occurring due to an int < size_t comparison.
2020-07-15kernel/process: Move name and system context to the bottom of the member listLioncash1-6/+6
These aren't directly important or commonly used within the process, so we can move these to the bottom to allow everything else to be more likely to be within a cache line.
2020-07-15kernel/handle_table: Remove usages of the global system instanceLioncash4-8/+15
Removes even more usages of the global system instance, trimming away more dependencies on global variables and making them explicit in the interface.
2020-07-15settings: Make use of std::string_view over std::string for loggingLioncash1-33/+34
In all usages of LogSetting(), string literals are provided. std::string_view is better suited here, as we won't churn a bunch of string allocations every time the settings are logged out. While we're at it, we can fold LogSetting() into LogSettings(), given it's only ever used there.
2020-07-15kernel/thread: Remove global GetCurrentThread()Lioncash3-23/+7
This is only used in one place, so we can fold it into the calling code, eliminating a place for the global system instance to be used.
2020-07-15clang formatMorph1-3/+3
2020-07-15Use proper install result when overwriting filesMorph2-3/+3
2020-07-15Remove global system instance and address feedbackMorph2-14/+10
2020-07-15registered_cache: Remove previous update/dlc if it exists on installMorph2-13/+83
- This checks for and removes old updates or dlc based on title id. If a content meta nca exists within the registered cache, it will attempt to remove all the ncas associated with the content meta before installing a new update/dlc
2020-07-15clang-formatVolcaEM1-1/+2
2020-07-15dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)VolcaEM2-1/+41
This was based on Atmosphére's DMNT Cheat VM: - https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.hpp - https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.cpp From Atmosphére's documentation: "Code type 0xC3 reads or writes a static register with a given register" There are now only two remaining opcodes to implement (PauseProcess and BreakProcess) This is untested because I don't have any experience in testing cheats on yuzu
2020-07-14common/swap: Make use of std::endianLioncash1-42/+4
Allows removing a bunch of defines in favor of a two liner.
2020-07-14shader_cache: Make use of std::erase_ifLioncash1-2/+2
Now that we use C++20, we can also make use of std::erase_if instead of needing to do the erase-remove idiom.
2020-07-14clang-formatlat9nq1-2/+1
2020-07-14settings: Move settings sanitization to its own functionlat9nq4-4/+11
Creates a new function that can be expanded later to fix other settings that are known to cause emulation errors across executables.
2020-07-14Fix crash if gc configured but adapter not connectedAmeer2-15/+25
2020-07-14main: Set async gpu properly after loading per-game settinglat9nq1-0/+4
Another error that got pass me and only noticed when I was doing the per-game settings UI rework. This prevents asynchronous GPU emulation from being disabled while multi core is enabled as a result of a poorly put together per-game config.
2020-07-14configure_general: Explicitly guard use_multi_core when applying settingslat9nq1-0/+2
This is likely an oversight during a rebase. Guards use_multi_core to be only set when the global value is in use. It should not make a difference given the current code base, but makes the code sensible.
2020-07-14vk_device: Make use of designated initializers where applicableLioncash1-124/+152
Avoids redundant repetitions of variable names, and allows assignment all in one statement.
2020-07-14input_common: drop unused libusb.h includeAmeer1-1/+0
Remnant of an early implementation.
2020-07-14vk_graphics_pipeline: Make use of designated initializers where applicableLioncash1-198/+223
Avoids redundant variable name repetitions.
2020-07-13input_common: make libusb private to gc_adapterJan Beich3-3/+7
2020-07-13memory_layout: Remove unused data memberLioncash1-2/+0
This isn't used, so it can be removed entirely, shrinking the structure size by 8 bytes.
2020-07-13address_space_info: Use type alias to simplify codeLioncash1-14/+13
We can define an alias for the index arrays and then just reuse it to make the code nicer to read.
2020-07-13address_space_info: Make use of designated initializersLioncash2-46/+27
We can alter the structure so that we can use designated initializers in the array, eliminating the comments that indicate their field names.
2020-07-13video_core: Rearrange pixel format namesReinUsesLisp19-1179/+1077
Normalizes pixel format names to match Vulkan names. Previous to this commit pixel formats had no convention, leading to confusion and potential bugs.
2020-07-13video_core: Fix DXT4 and RGB565ReinUsesLisp7-37/+31
2020-07-13video_core/format_lookup_table: Add formats with existing PixelFormatReinUsesLisp1-1/+9
2020-07-13video_core: Fix B5G6R5_UNORM render target formatReinUsesLisp5-1/+10
2020-07-13video_core: Fix B5G6R5UReinUsesLisp2-2/+2
2020-07-13video_core: Implement RGBA32_SINT render targetReinUsesLisp7-58/+71
2020-07-13video_core: Implement RGBA32_SINT render targetReinUsesLisp7-0/+13
2020-07-13video_core: Implement RGBA16_SINT render targetReinUsesLisp7-0/+13
2020-07-13video_core: Implement RGBA8_SINT render targetReinUsesLisp7-0/+13
2020-07-13video_core: Implement RG32_SINT render targetReinUsesLisp7-0/+13
2020-07-13video_core: Implement RG8_SINT render target and fix RG8_UINTReinUsesLisp7-1/+14
2020-07-13video_core: Implement R8_SINT render targetReinUsesLisp7-0/+13
2020-07-13video_core: Implement R8_SNORM render targetReinUsesLisp7-0/+13
2020-07-13video_core/surface: Remove explicit values on PixelFormat's definitionReinUsesLisp1-80/+80
2020-07-13video_core/surface: Reorder render target to pixel format switchReinUsesLisp1-53/+51
2020-07-13kernel/scheduler: Use std::mutex instead of spin lockReinUsesLisp1-1/+1
Profiling shows that this is a highly contested mutex, causing dimishing results compared to a OS lock. std::mutex implementations can spin for a while before falling back to an OS lock. This avoids wasting precious CPU cycles in a no-op.
2020-07-13vk_blit_screen: Make use of designated initializers where applicableLioncash1-334/+384
Now that we make use of C++20, we can use designated initializers to make things a little nicer to read.
2020-07-13vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_stateReinUsesLisp1-0/+1
Fixes a regression on any game using stencil on devices with VK_EXT_extended_dynamic_state.
2020-07-12udp: Silence a C++20 deprecation warningLioncash1-1/+1
C++20 deprecates using the = lambda capture to implicitly capture the this pointer. Instead, we must specify it explicitly.
2020-07-12gc_poller: Mark GCButtonFactory::GetNextInput() as constLioncash2-2/+2
This doesn't modify class instance state.
2020-07-12gc_poller: Get rid of undefined behavior in Create()Lioncash1-0/+4
Ensures that the function always has returns in all control paths.
2020-07-12gc_poller: Silence sign conversion warningsLioncash1-1/+1
2020-07-12gc_adapter: Remove deprecated usage of = in lambda capturesLioncash1-1/+1
It's deprecated in C++20 to use = to capture the this pointer. Instead, we can simply pass this as an argument to the thread constructor.
2020-07-12gc_adapter: Silence sign conversion warningsLioncash2-7/+7
2020-07-12configure_cpu: Split optimization settings off into Debug tabMerryMage9-163/+302
2020-07-12common/alignment: Fix compilation errors (#4303)Tobias1-1/+3
2020-07-12fs: Fix RomFS building when zero byte files are presentMorph4-10/+10
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key. This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
2020-07-12hle: service: mii: Rewrite service to properly support creation of random and default miis.bunnei9-914/+3270
2020-07-12Revert "Port citra-emu/citra#5441: "Common: remove a mod from AlignUp""bunnei1-3/+1
2020-07-11Common: remove a mod from AlignUp (#5441)Marshall Mohror1-1/+3
In cases where the size is not a known constant when inlining, AlignUp<std::size_t> currently generates two 64-bit div instructions. This generates one div and a cmov which is significantly cheaper.
2020-07-11configure_cpu: Add tooltipsMerryMage1-1/+54
2020-07-11configure_cpu: Show/Hide debugging optionsMerryMage7-46/+135
2020-07-11main/profile_select: Don't prompt for profile selection when only one is availableFearlessTobi1-9/+13
2020-07-11configuration: Add settings to enable/disable specific CPU optimizationsMerryMage16-29/+404
2020-07-11CMakeLists: Make use of /std:c++latest on MSVCLioncash1-2/+2
Provides the buildbot with one builder that is always tracking the latest version of the C++ standard, allowing us to progressively rectify our code and amend any differences between standards over time instead of waiting for a complete standard change, potentially breaking a lot of code all at once.
2020-07-10vk_rasterizer: Pass <pSizes> to CmdBindVertexBuffers2EXTReinUsesLisp1-6/+6
This has been fixed in Nvidia's public beta driver 451.74. The previous beta driver will be broken, people using these will have to update.
2020-07-10Break out of scan loop if can't find adapter on first runAmeer1-0/+3
2020-07-10video_core/textures: Add and use SwizzleSliceToVoxel, and minor style changesReinUsesLisp5-84/+125
Change GOB sizes from free-functions to constexpr constants. Add SwizzleSliceToVoxel, a function that swizzles a 2D array of pixels into a 3D texture and use it for 3D copies.
2020-07-10vfs_real: Fix MoveFileMorph1-10/+17
The file wasn't closed prior to being renamed / moved, throwing an error that states "The process cannot access the file because it is being used by another process." Fix this by closing the file prior to a rename / move operation. Fixes saving in Luigi's Mansion 3 and KATANA KAMI: A Way of the Samurai Story.
2020-07-10KeyManager: Prevent writing of invalid keysMorph1-4/+8
If the keys are zero, don't write them to the autogenerated file.
2020-07-10Add additional empty check for the QStringList returned by the InstallDialogMorph1-0/+4
2020-07-10Update the install and progress dialogsMorph4-80/+65
- Remove the overwrite files checkbox, it will always overwrite - The progressbar now reflects the progress in terms of data transferred.
2020-07-10Refactor batch installing filesMorph4-196/+238
Key issues fixed: - Progress dialog showing up as white/hanging/getting stuck/unresponsive. Key changes: - Progress dialog now shows progress as a function of all files instead of per nca within a file. - Overwrite existing files will overwrite all files in the selection.
2020-07-10Add support for batch install to NANDMorph6-124/+290
This adds support to batch install files to NAND
2020-07-10bis_factory: Set User NAND free space to be 1 MiB less than total.Morph1-1/+3
2020-07-10sdmc_factory: Set the SDMC total size to 1 TiBMorph1-1/+3
We should not be limited by the SDMC's partition size, set this to 1 TiB. Hardware is limited to the max allowed by the MBR partition table which is 2 TiB.
2020-07-10bis_factory: Use hardware default NAND partition sizesMorph1-10/+11
Sets the total space of user and system partitions to their hardware defaults. Furthermore, return the total space as free space for the user partition to prevent it from reaching zero. Some games like Bioshock 2 check for the available free space prior to save creation, and we should not be limited by arbitrary limits.
2020-07-10settings: Remove storage size optionsMorph5-214/+1
2020-07-10cmake: Fix libfmt linking errorsDavid Marcec1-5/+1
2020-07-10configuration: implement per-game configurations (#4098)lat9nq57-835/+1942
* Switch game settings to use a pointer In order to add full per-game settings, we need to be able to tell yuzu to switch to using either the global or game configuration. Using a pointer makes it easier to switch. * configuration: add new UI without changing existing funcitonality The new UI also adds General, System, Graphics, Advanced Graphics, and Audio tabs, but as yet they do nothing. This commit keeps yuzu to the same functionality as originally branched. * configuration: Rename files These weren't included in the last commit. Now they are. * configuration: setup global configuration checkbox Global config checkbox now enables/disables the appropriate tabs in the game properties dialog. The use global configuration setting is now saved to the config, defaulting to true. This also addresses some changes requested in the PR. * configuration: swap to per-game config memory for properties dialog Does not set memory going in-game. Swaps to game values when opening the properties dialog, then swaps back when closing it. Uses a `memcpy` to swap. Also implements saving config files, limited to certain groups of configurations so as to not risk setting unsafe configurations. * configuration: change config interfaces to use config-specific pointers When a game is booted, we need to be able to open the configuration dialogs without changing the settings pointer in the game's emualtion. A new pointer specific to just the configuration dialogs can be used to separate changes to just those config dialogs without affecting the emulation. * configuration: boot a game using per-game settings Swaps values where needed to boot a game. * configuration: user correct config during emulation Creates a new pointer specifically for modifying the configuration while emulation is in progress. Both the regular configuration dialog and the game properties dialog now use the pointer Settings::config_values to focus edits to the correct struct. * settings: split Settings::values into two different structs By splitting the settings into two mutually exclusive structs, it becomes easier, as a developer, to determine how to use the Settings structs after per-game configurations is merged. Other benefits include only duplicating the required settings in memory. * settings: move use_docked_mode to Controls group `use_docked_mode` is set in the input settings and cannot be accessed from the system settings. Grouping it with system settings causes it to be saved with per-game settings, which may make transferring configs more difficult later on, especially since docked mode cannot be set from within the game properties dialog. * configuration: Fix the other yuzu executables and a regression In main.cpp, we have to get the title ID before the ROM is loaded, else the renderer will reflect only the global settings and now the user's game specific settings. * settings: use a template to duplicate memory for each setting Replaces the type of each variable in the Settings::Values struct with a new class that allows basic data reading and writing. The new struct Settings::Setting duplicates the data in memory and can manage global overrides per each setting. * configuration: correct add-ons config and swap settings when apropriate Any add-ons interaction happens directly through the global values struct. Swapping bewteen structs now also includes copying the necessary global configs that cannot be changed nor saved in per-game settings. General and System config menus now update based on whether it is viewing the global or per-game settings. * settings: restore old values struct No longer needed with the Settings::Setting class template. * configuration: implement hierarchical game properties dialog This sets the apropriate global or local data in each setting. * clang format * clang format take 2 can the docker container save this? * address comments and style issues * config: read and write settings with global awareness Adds new functions to read and write settings while keeping the global state in focus. Files now generated per-game are much smaller since often they only need address the global state. * settings: restore global state when necessary Upon closing a game or the game properties dialog, we need to restore all global settings to the original global state so that we can properly open the configuration dialog or boot a different game. * configuration: guard setting values incorrectly This disables setting values while a game is running if the setting is overwritten by a per game setting. * config: don't write local settings in the global config Simple guards to prevent writing the wrong settings in the wrong files. * configuration: add comments, assume less, and clang format No longer assumes that a disabled UI element means the global state is turned off, instead opting to directly answer that question. Still however assumes a game is running if it is in that state. * configuration: fix a logic error Should not be negated * restore settings' global state regardless of accept/cancel Fixes loading a properties dialog and causing the global config dialog to show local settings. * fix more logic errors Fixed the frame limit would set the global setting from the game properties dialog. Also strengthened the Settings::Setting member variables and simplified the logic in config reading (ReadSettingGlobal). * fix another logic error In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered condition. * configure_audio: set toggle_stretched_audio to tristate * fixed custom rtc and rng seed overwriting the global value * clang format * rebased * clang format take 4 * address my own review Basically revert unintended changes * settings: literal instead of casting "No need to cast, use 1U instead" Thanks, Morph! Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> * Revert "settings: literal instead of casting " This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f. * main: fix status buttons reporting wrong settings after stop emulation * settings: Log UseDockedMode in the Controls group This should have happened when use_docked_mode was moved over to the controls group internally. This just reflects this in the log. * main: load settings if the file has a title id In other words, don't exit if the loader has trouble getting a title id. * use a zero * settings: initalize resolution factor with constructor instead of casting * Revert "settings: initalize resolution factor with constructor instead of casting" This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8. * configure_graphics: guard device selector when Vulkan is global Prevents the user from editing the device selector if Vulkan is the global renderer backend. Also resets the vulkan_device variable when the users switches back-and-forth between global and Vulkan. * address reviewer concerns Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static. Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com> * main: load per-game settings after LoadROM This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug. * Revert "main: load per-game settings after LoadROM" This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804. * main: only restore global settings when necessary Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug. * configuration_shared: address reviewer concerns except operator overrides Dropping operator override usage in next commit. Co-Authored-By: LC <lioncash@users.noreply.github.com> * settings: Drop operator overrides from Setting template Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog. * complete rebase * configuration_shared: translate "Use global configuration" Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared. * configure_per_game: address reviewer concern As far as I understand, it prevents the program from unnecessarily copying strings. Co-Authored-By: LC <lioncash@users.noreply.github.com> Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> Co-authored-by: VolcaEM <volcaem@users.noreply.github.com> Co-authored-by: LC <lioncash@users.noreply.github.com>
2020-07-10vk_stream_buffer: set allocable_size to 9 MiBlat9nq1-1/+1
This solves the crash on Linux systems running the current Linux Long Lived branch nVidia driver.
2020-07-09cmake: fix fmt linking when foundJohn Galt1-1/+5
This is a new attempt at #4206 that shouldn't break windows builds. If someone else could test on windows, it would be much appreciated. Previously, the build bot passed but the actual builds failed.
2020-07-09cmake: pass libusb include directory as wellJan Beich1-0/+1
In file included from src/input_common/gcadapter/gc_adapter.cpp:8: src/./input_common/gcadapter/gc_adapter.h:11:10: fatal error: 'libusb.h' file not found #include <libusb.h> ^~~~~~~~~~
2020-07-08Address comments for better clarity/signed dev countAmeer1-11/+15
2020-07-08Add more libusb error checksAmeer1-3/+18
2020-07-08AM: fix GetDesiredLanguage:CrazyMax1-1/+13
try to get a control metadata from application update when is failed to get from the basic version. Tested on Kirby Star Allies
2020-07-08maxwell_dma: Rename registers to match official docs and reorderReinUsesLisp2-287/+355
Rename registers in the MaxwellDMA class to match Nvidia's official documentation. This one can be found here: https://github.com/NVIDIA/open-gpu-doc/blob/master/classes/dma-copy/clb0b5.h While we are at it, reorganize the code in MaxwellDMA to be separated in different functions.
2020-07-07cpu_interrupt_handler: Remove #pragma once from .cpp fileMerryMage1-2/+0
2020-07-07Address PR feedback, fix axis button thresholdingAmeer3-58/+22
2020-07-07input_common/gcadapter: add missing C++11 header required by libc++Jan Beich1-0/+1
In file included from src/input_common/gcadapter/gc_adapter.cpp:8: src/./input_common/gcadapter/gc_adapter.h:77:10: error: no template named 'unordered_map' in namespace 'std' std::unordered_map<int, bool> buttons; ~~~~~^ src/./input_common/gcadapter/gc_adapter.h:78:10: error: no template named 'unordered_map' in namespace 'std' std::unordered_map<int, u16> axes; ~~~~~^
2020-07-07Brace the code! Fix compile error due to class member construction orderAmeer2-15/+31
2020-07-07Recalibrate reconnected controllersAmeer1-0/+5
2020-07-07Save origin state of GC controller analog features, compare against origin for input detectionAmeer3-28/+72
2020-07-07change shortcut context for other hotkeys with file open dialogAmeer1-4/+4
2020-07-07GetDisplayVersion should return a null-terminated version string.CrazyMax1-4/+16
also, in case of failed to get of the basic version, we will try get it from application update.
2020-07-06Fix ss crash on game menu, fix ss on windowed modeAmeer2-4/+6
2020-07-06configure_graphics: Make use of qOverload in signals/slotsLioncash1-2/+2
While we're in the same area, we can make use of qOverload to tidy up some function pointer casts.
2020-07-06configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox()Lioncash1-1/+1
Unlikely to impact performance at all, but this is essentially a "free" transformation, so why not?
2020-07-05memory: Set page-table pointers before setting attribute = MemoryMerryMage1-2/+5
2020-07-05AM/ISelfController: Stub CreateManagedDisplaySeparableLayerMorph2-1/+20
Stub this by sending 1 layer id instead of 2 as yuzu does not support multiple layers per display. No adverse side effects have been observed. - Used by Animal Crossing: New Horizons Update 1.3.0
2020-07-04Fix for always firing triggers on some controllers, trigger threshold more universalAmeer2-5/+5
2020-07-03Address lioncash feedback: Log formatting, extern const PadButtonArray, little touch upsAmeer3-24/+32
2020-07-03Revert "cmake: fix fmt linking"bunnei1-1/+1
2020-07-02Fix unnecessary diffsAmeer4-29/+27
2020-07-02Add LR triggers as axes, half press to initiate a press, add GC axis id in config, clarify some code blocks for better readabilityAmeer3-35/+80
2020-07-02Rename two functions in NSVolcaEM1-2/+2
- Rename "GetShellEvent" to "GetShellEventHandle" - Rename "LaunchApplicationFromHost" to "LaunchApplication"
2020-07-02Rename GetApplicationArea2 to GetApplicationAreaSizeVolcaEM1-2/+2
2020-07-02cmake: stop linking against QGL after c6a0ab979239Jan Beich1-1/+1
2020-07-01shader_cache: Fix use-after-free and orphan invalidation cache entriesReinUsesLisp1-29/+41
This fixes some cases where entries could have been removed multiple times reading freed memory. To address this issue this commit removes duplicates from entries marked for removal and sorts out the removal process to fix another use-after-free situation. Another issue fixed in this commit is orphan invalidation cache entries. Previously only the entries that were invalidated in the current operations had its entries removed. This led to more use-after-free situations when these entries were actually invalidated but referenced an object that didn't exist.
2020-07-01Reset adapter state on init, fixes errors relating driver hang from unexpected unplugAmeer2-0/+9
2020-07-01Don't handle cycles late if stretcher is activeDavid Marcec1-1/+3
Timestretcher seems to be broken
2020-07-01audio: Improving audio timing for multicore/single coreDavid Marcec2-20/+7
Fixes the issue with needing the timestretcher for multicore.
2020-07-01externals: Track opus as submodule instead of using conanDavid Marcec1-1/+1
Supersedes #4068 see for details.
2020-07-01key_manager: Correct casing of instance()Lioncash10-10/+10
Our codebase uppercases member function names.
2020-07-01key_manager: Delete move operationsLioncash1-0/+3
Prevents the singleton from being moved from.
2020-07-01key_manager: Make use of canonical deleted operator=Lioncash1-2/+2
operator= typically returns a reference, it's not void. While we're at it, we can correct the parameter formatting to adhere to the codebase.
2020-07-01common: switch to nullptr for sysctl's empty new valueJan Beich1-4/+4
2020-06-30Address feedback regarding increments, const vars, and general cleanupAmeer2-24/+21
2020-06-30fix implicit conversion of size_t type to intAmeer1-1/+1
2020-06-30maxwell_to_gl: Implement MirrorOnceClampOGL using GL_MIRROR_CLAMP_EXTMorph1-0/+6
Like MirrorOnceBorder, this requires the GL_EXT_texture_mirror_clamp extension. This extension is unfortunately not available on Intel's drivers (both Windows proprietary and Linux Mesa). Use GL_MIRROR_CLAMP_TO_EDGE as a fallback if the extension is unavailable.
2020-06-30macro: Add support for "middle methods" on the code cache (#4112)David1-8/+27
Macro code is just uploaded sequentially from a starting address, however that does not mean the entry point for the macro is at that address. This PR adds preliminary support for executing macros in the middle of our cached code.
2020-06-30common: add sysconf() fallbackJan Beich1-3/+16
src/common/memory_detect.cpp:15:10: fatal error: 'sys/sysinfo.h' file not found #include <sys/sysinfo.h> ^~~~~~~~~~~~~~~
2020-06-29maxwell_to_gl: Rename VertexType() to VertexFormat()Morph2-4/+5
2020-06-29cmake: fix fmt linkingJohn Galt1-1/+1
On gcc/ld, and clang/lld, fmt::v6 symbols are excluded, so linking fails. This fixes the issue. Note: This was included in the FindBoost changes I shared with BlinkHawk, however only they were merged. I'm not sure if it was missed, or if there was an issue with this part of the change.
2020-06-29Remove duplicate functionsVolcaEM1-2/+0
2020-06-29Use decimal instead of hexadecimalVolcaEM1-3/+5
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
2020-06-29Fix typoVolcaEM1-1/+1
2020-06-29Clang-formatVolcaEM1-1/+1
2020-06-29service: Update function tablesVolcaEM27-157/+285
2020-06-29core_timing,scheduler: Use std::scoped_lock when possibleReinUsesLisp2-15/+12
Simplifies the cognitive load of procedures using locks and makes locks safe against exceptions.
2020-06-28ldr: Cleanup NRO & NRR structsDavid Marcec1-8/+8
2020-06-28maxwell_to_vk: Reorder vertex formats and add A2B10G10R10 for all types except floatMorph1-75/+69
2020-06-28am: Stub GetIndirectLayerConsumerHandleDavid Marcec1-1/+13
Needed by Monster Hunter Generations Ultimate
2020-06-28maxwell_to_gl: Add 32 bit component sizes to (un)signed scaled formatsMorph1-30/+4
Add 32 bit component sizes to (un)signed scaled formats and group (un)signed normalized, scaled, and integer formats together.
2020-06-28acc: ListOpenContextStoredUsers partial stubDavid Marcec5-4/+14
Needed by Baldur's Gate 1/2
2020-06-28Core/Common: Address Feedback.Fernando Sahmkow21-58/+58
2020-06-27NvFlinger: Clang Format.Fernando Sahmkow1-1/+1
2020-06-27Build System: Fix GCC & MINGW Build.Fernando Sahmkow1-0/+4
2020-06-27SVC: Implement 32-bits wrappers and update Dynarmic.Fernando Sahmkow4-34/+282
2020-06-27SVC: Add GetCurrentProcessorNumber32, CreateTransferMemory32, SetMemoryAttribute32Fernando Sahmkow2-6/+39
2020-06-27ARM: Update Dynarmic and Setup A32 according to latest interface.Fernando Sahmkow8-93/+174
2020-06-27SVC: Add GetThreadPriority32 & SetThreadPriority32Fernando Sahmkow2-2/+30
2020-06-27ArmDynarmic32: Setup CNTPCT correctlyFernando Sahmkow1-1/+1
2020-06-27Audio: Correct buffer release for host timing.Fernando Sahmkow3-1/+22
2020-06-27Common/Kernel: Corrections and small bug fixing.Fernando Sahmkow2-8/+3
2020-06-27Services/NvFlinger: Do vSync in a sepparate thread on Multicore.Fernando Sahmkow4-5/+69
2020-06-27Common/NativeClockx86: Reduce native clock accuracy further.Fernando Sahmkow1-1/+1
2020-06-27Tests/CoreTiming: Correct host timing tests.Fernando Sahmkow2-157/+14
2020-06-27ARMDynarmicInterface: Correct GCC Build Errors.Fernando Sahmkow2-6/+6
2020-06-27Common/AtomicOps: Correct GCC Intrinsic argument ordering.Fernando Sahmkow1-5/+5
2020-06-27Kernel: Correct Host Context on Threads and Scheduler.Fernando Sahmkow4-11/+11
2020-06-27YuzuQT: Hide Speed UI on Multicore.Fernando Sahmkow1-1/+1
2020-06-27Clang Format.Fernando Sahmkow14-48/+49
2020-06-27ARMInterface/Externals: Update dynarmic and fit to latest version.Fernando Sahmkow1-7/+7
2020-06-27ARMInterface: Correct rebase errors.Fernando Sahmkow3-5/+5
2020-06-27CoreTiming: Correct rebase bugs and other miscellaneous things.Fernando Sahmkow2-4/+8
2020-06-27Core: Split Microprofile Dynarmic timing per CoreFernando Sahmkow1-3/+12
2020-06-27General: Tune the priority of main emulation threads so they have higher priority than less important helper threads.Fernando Sahmkow6-0/+60
2020-06-27Dynarmic Interface: don't clear cache if JIT has not been created.Fernando Sahmkow2-0/+6
2020-06-27General: Correct rebase, sync gpu and context management.Fernando Sahmkow9-32/+45
2020-06-27CoreTiming/CycleTimer: Correct Idling.Fernando Sahmkow1-2/+5
2020-06-27SingleCore: Correct ticks reset to be on preemption.Fernando Sahmkow1-1/+1
2020-06-27General: Cleanup legacy code.Fernando Sahmkow19-740/+8
2020-06-27Kernel/svcBreak: Implement CacheInvalidation for Singlecore and correct svcBreak.Fernando Sahmkow2-3/+13
2020-06-27Bootmanager/CPU_Manager: Correct shader caches and sync GPU on OpenGL.Fernando Sahmkow2-6/+13
2020-06-27HLE_IPC: Correct HLE Event behavior on timeout.Fernando Sahmkow3-1/+19
2020-06-27SingleCore: Improve Cycle timing Behavior and replace mutex in global scheduler for spinlock.Fernando Sahmkow3-2/+4
2020-06-27FrameLimiting: Enable frame limiting for single core.Fernando Sahmkow2-1/+2
2020-06-27SingleCore: Use Cycle Timing instead of Host Timing.Fernando Sahmkow15-80/+152
2020-06-27Scheduler: Correct Reload/UnloadFernando Sahmkow2-3/+5
2020-06-27Thread: Release the ARM Interface on exitting.Fernando Sahmkow3-1/+8
2020-06-27General: Move ARM_Interface into Threads.Fernando Sahmkow18-170/+136
2020-06-27Core: Refactor ARM Interface.Fernando Sahmkow10-42/+69
2020-06-27X64 Clock: Reduce accuracy to be less or equal to guest accuracy.Fernando Sahmkow3-1/+10
2020-06-27ARM/WaitTree: Better track the CallStack for each thread.Fernando Sahmkow3-11/+74
2020-06-27SVC/ARM: Correct svcSendSyncRequest and cache ticks on arm interface.Fernando Sahmkow3-5/+20
2020-06-27SingleCore: Move Host Timing from a sepparate thread to main cpu thread.Fernando Sahmkow7-10/+48
2020-06-27GUI: Make multicore only work with Async and add GUI for multicore.Fernando Sahmkow6-5/+63
2020-06-27ARM: Addapt to new Exclusive Monitor Interface.Fernando Sahmkow5-31/+24
2020-06-27CPU_Manager: Correct stopping on SingleCore.Fernando Sahmkow1-3/+8
2020-06-27Scheduler: Correct yielding interaction with SetThreadActivity.Fernando Sahmkow1-0/+15
2020-06-27General: Fix microprofile on dynarmic/svc, fix wait tree showing which threads were running.Fernando Sahmkow11-13/+87
2020-06-27General: Fix Stop functionFernando Sahmkow4-5/+25
2020-06-27Kernel: Rewind on SVC change.Fernando Sahmkow3-5/+16
2020-06-27Kernel: Preempt Single core on redudant yields.Fernando Sahmkow6-21/+42
2020-06-27CPU_Manager: Unload/Reload threads on preemption on SingleCoreFernando Sahmkow4-7/+64
2020-06-27Synchronization: Correct wide Assertion.Fernando Sahmkow1-2/+4
2020-06-27General: Initial Setup for Single Core.Fernando Sahmkow8-34/+228
2020-06-27Scheduler: Set last running time on thread.Fernando Sahmkow2-4/+2
2020-06-27Kernel: Corrections to TimeManager, Scheduler and Mutex.Fernando Sahmkow3-5/+5
2020-06-27Kernel: Fixes, corrections and asserts to scheduler and different svcs.Fernando Sahmkow8-38/+38
2020-06-27Scheduler: Correct yields.Fernando Sahmkow2-7/+25
2020-06-27Mutex: Revert workaround due to poor exclusive memory.Fernando Sahmkow1-9/+2
2020-06-27ARM/Memory: Correct Exclusive Monitor and Implement Exclusive Memory Writes.Fernando Sahmkow12-24/+325
2020-06-27SVC: WaitSynchronization add Termination Pending Result.Fernando Sahmkow2-1/+5
2020-06-27Scheduler: Remove arm_interface lock and a few corrections.Fernando Sahmkow2-17/+3
2020-06-27Yuzu/Debuggers: Correct Wait Tree for Paused threads.Fernando Sahmkow1-2/+10
2020-06-27SVC: Correct SetThreadActivity.Fernando Sahmkow4-38/+59
2020-06-27SCC: Small corrections to CancelSynchronizationFernando Sahmkow3-2/+14
2020-06-27Scheduler: Correct locking for hle threads.Fernando Sahmkow1-1/+2
2020-06-27Scheduler: Fix HLE Threads on guardFernando Sahmkow1-4/+6
2020-06-27Scheduler: Protect on closed threads.Fernando Sahmkow1-7/+17
2020-06-27Scheduler: Correct assert.Fernando Sahmkow1-4/+2
2020-06-27Core: Correct rebase.Fernando Sahmkow2-18/+11
2020-06-27Scheduler: Release old thread fiber before trying to switch to the next thread fiber.Fernando Sahmkow2-11/+35
2020-06-27NVDRV: Remove frame limiting as Host Timing already takes care.Fernando Sahmkow1-1/+0
2020-06-27Mutex: Correct Result writting to clear exclusivity.Fernando Sahmkow1-3/+11
2020-06-27SVC: Correct svcWaitForAddress and svcSignalToAddress.Fernando Sahmkow4-68/+161
2020-06-27Scheduler: Correct Select Threads Step 2.Fernando Sahmkow1-0/+1
2020-06-27Kernel: Corrections to Scheduling.Fernando Sahmkow5-19/+23
2020-06-27Kernel: Correct Signal on Thread Death and Setup Sync Objects on Thread for DebuggingFernando Sahmkow3-15/+17
2020-06-27Core: Correct HLE Event Callbacks and other issues.Fernando Sahmkow5-37/+39
2020-06-27Process: Protect TLS region and Modules.Fernando Sahmkow1-0/+4
2020-06-27General: Add AssertsFernando Sahmkow4-0/+24
2020-06-27General: Add better safety for JIT use.Fernando Sahmkow5-7/+39
2020-06-27SVC: Correct races on physical core switching.Fernando Sahmkow2-10/+10
2020-06-27NVFlinger: Lock race condition between CPU, Host Timing, VSync.Fernando Sahmkow3-0/+11
2020-06-27SVC: Add locks to the memory management.Fernando Sahmkow1-0/+21
2020-06-27SVC: Correct WaitSynchronization, WaitProcessWideKey, SignalProcessWideKey.Fernando Sahmkow9-33/+84
2020-06-27SVC: Cleanup old methods.Fernando Sahmkow1-13/+9
2020-06-27CPU_Manager: Reconfigre guest threads for dynamrmic downsidesFernando Sahmkow3-1/+7
2020-06-27SVC: Correct SendSyncRequest.Fernando Sahmkow8-54/+116
2020-06-27SVC: Correct ArbitrateUnlockFernando Sahmkow3-33/+37
2020-06-27SVC: Correct SignalEvent, ClearEvent, ResetSignal, WaitSynchronization, CancelSynchronization, ArbitrateLockFernando Sahmkow8-90/+134
2020-06-27SVC: Remove global HLE Lock.Fernando Sahmkow1-3/+0
2020-06-27SVC: Correct GetThreadPriority, SetThreadPriority, GetThreadCoreMask, SetThreadCoreMask, GetCurrentProcessorNumberFernando Sahmkow5-15/+26
2020-06-27SVC: Correct CreateThread, StartThread, ExitThread, SleepThread.Fernando Sahmkow3-37/+31
2020-06-27HostTiming: Pause the hardware clock on pause.Fernando Sahmkow7-1/+23
2020-06-27AudioCore: Use nanoseconds instead of cycles for buffer time.Fernando Sahmkow2-6/+6
2020-06-27General: Setup yuzu threads' microprofile, naming and registry.Fernando Sahmkow7-9/+25
2020-06-27CPU_Manager: remove debugging code.Fernando Sahmkow1-8/+4
2020-06-27YuzuCMD/Tester: Correct executionFernando Sahmkow2-6/+8
2020-06-27General: Recover Prometheus project from harddrive failure Fernando Sahmkow57-816/+1341
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host Timing, Reworks the Kernel's Scheduler, Introduce Idle State and Suspended State, Recreates the bootmanager, Initializes Multicore system.
2020-06-27nfc: Update function tableVolcaEM1-3/+3
This was based on Switchbrew page: https://switchbrew.org/wiki/NFC_services
2020-06-27ncm: Update function tableVolcaEM1-10/+10
This was based on Switchbrew page: https://switchbrew.org/wiki/NCM_services ILocationResolver's 16, 17, 18 and 19 have unofficial names
2020-06-27mm: Update function tableVolcaEM1-16/+16
This was based on Switchbrew page: https://switchbrew.org/wiki/Display_services
2020-06-27mig: Update function tableVolcaEM1-0/+6
This was based on Switchbrew page: https://switchbrew.org/wiki/Migration_services
2020-06-27ldn: Update function tableVolcaEM1-0/+1
This was based on Switchbrew page: https://switchbrew.org/wiki/LDN_services
2020-06-27Oops (fix typo)VolcaEM1-1/+1
2020-06-27lbl: Update function tableVolcaEM1-0/+1
This was based on Switchbrew page: https://switchbrew.org/wiki/Backlight_services
2020-06-27grc: Update function tableVolcaEM1-0/+3
This was based on Switchbrew page: https://switchbrew.org/wiki/GRC_services
2020-06-27friend: Update function tableVolcaEM1-0/+6
2020-06-27Fix issues caused when changing the fullscreen hotkeyKewlan1-4/+5
2020-06-27left const auto&, comment punctuation.Ameer J1-2/+2
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
2020-06-27Use better names for "Unknown"sVolcaEM1-39/+39
2020-06-27Update function namesVolcaEM1-4/+4
2020-06-27btm: Give better names for unknown functionsDavid Marcec1-5/+5
2020-06-27btdrv: Update function table (#4174)VolcaEM1-83/+84
* btdrv: Update function table
2020-06-27bpc: Update function tables (#4173)VolcaEM1-7/+13
* bpc: Update function tables This was based on Switchbrew page: https://switchbrew.org/wiki/PCV_services
2020-06-27bcat: Update function tables and add missing classes (#4172)VolcaEM2-0/+5
* bcat: Update function tables and add missing classes
2020-06-27am: Update function tables and add missing classes (#4169)VolcaEM3-17/+19
* am: Update function tables and add missing classes * Remove comments (1/5) * Remove comments (2/5) * Remove comments (3/5) * Remove comments (4/5) * Remove comments (5/5) * Remove unused classes (1/2) * Remove unused classes (2/2)
2020-06-27aoc: Update function table (#4170)VolcaEM1-0/+1
* aoc: Update function table * Remove comments
2020-06-27eupld: Update function tableVolcaEM1-0/+1
This was based on Switchbrew page: https://switchbrew.org/wiki/Error_Upload_services
2020-06-27es: Update function tableVolcaEM1-2/+41
This was based on Switchbrew page: https://switchbrew.org/wiki/ETicket_services
2020-06-27Update FAQ function name (2/2)VolcaEM1-2/+2
2020-06-27Update FAQ function name (1/2)VolcaEM1-1/+1
2020-06-27btm: Update function tablesVolcaEM1-71/+76
This was based on Switchbrew page: https://switchbrew.org/wiki/BTM_services "No comment" edition
2020-06-27vk_rasterizer: Use nullptr for <pSizes> in CmdBindVertexBuffers2EXTReinUsesLisp1-6/+6
Disable this temporarily.
2020-06-27vk_pipeline_cache: Avoid hashing and comparing dynamic state when possibleReinUsesLisp6-23/+51
With extended dynamic states, some bytes don't have to be collected from the pipeline key, hence we can avoid hashing and comparing them on lookups.
2020-06-27vulkan/fixed_pipeline_state: Move state out of individual structuresReinUsesLisp4-121/+84
2020-06-27vk_rasterizer: Use VK_EXT_extended_dynamic_stateReinUsesLisp5-46/+356
2020-06-27renderer_vulkan/wrapper: Add VK_EXT_extended_dynamic_state functionsReinUsesLisp2-0/+64
2020-06-27fixed_pipeline_state: Add requirements for VK_EXT_extended_dynamic_stateReinUsesLisp7-155/+143
This moves dynamic state present in VK_EXT_extended_dynamic_state to a separate structure in FixedPipelineState. This is structure is at the bottom allowing us to hash and memcmp only when the extension is not supported.
2020-06-27vk_device: Enable VK_EXT_extended_dynamic_state when availableReinUsesLisp2-0/+32
2020-06-27texture_cache: Test format compatibility before copyingReinUsesLisp2-6/+21
Avoid illegal copies. This intercepts the last step of a copy to avoid generating validation errors or corrupting the driver on some instances. We can create views and emit copies accordingly in future commits and remove this last-step validation.
2020-06-27video_core/compatible_formats: Table to test if two formats are legal to view or copyReinUsesLisp3-0/+196
Add a flat table to test if it's legal to create a texture view between two formats or copy betweem them. This table is based on ARB_copy_image and ARB_texture_view. Copies are more permissive than views.
2020-06-26gl_buffer_cache: Copy to buffers created as STREAM_READ before downloadingReinUsesLisp5-18/+24
After marking buffers as resident, Nvidia's driver seems to take a slow path. To workaround this issue, copy to a STREAM_READ buffer and then call GetNamedBufferSubData on it. This is a temporary solution until we have asynchronous flushing.
2020-06-26Update function name againVolcaEM1-1/+1
2020-06-26Update function name (2/2)VolcaEM1-1/+1
2020-06-26Update function name (1/2)VolcaEM1-1/+1
2020-06-26Common: Fix non-conan buildFernando Sahmkow1-1/+2
2020-06-26caps_u: Fix GetAlbumContentsFileListForApplication stubMorph1-9/+15
2020-06-26caps: Use enum classes and check struct sizes on compile timeMorph1-34/+40
2020-06-26caps: Update copyright headersMorph14-14/+14
Updated to "yuzu Emulator Project"
2020-06-26Add a "Mute Audio" hotkeyKewlan6-3/+17
2020-06-26const& to button in button arrayAmeer J1-2/+2
Co-authored-by: VolcaEM <63682805+VolcaEM@users.noreply.github.com>
2020-06-26Stop reading loop if error is encounteredAmeer1-4/+4
2020-06-25Clang-format againVolcaEM1-1/+1
2020-06-25Clang-formatVolcaEM1-1/+2
2020-06-25Remove unnecessary newlineVolcaEM1-1/+0
2020-06-25Fix typo 2: electric boogalooVolcaEM1-1/+1
2020-06-25Use QUrl (2/2)VolcaEM1-6/+5
2020-06-25Use QUrl (1/2)VolcaEM1-1/+1
2020-06-25Fix formattingVolcaEM1-2/+2
2020-06-25Fix typoVolcaEM1-1/+1
2020-06-25Add "Open Quickstart Guide" and "FAQ" buttons to the Help menuVolcaEM3-0/+48
While we're at it, also refactor the function used by OnOpenModsPage to be compatible with other URLs
2020-06-25gl_device: Fix IsASTCSupportedDavid Marcec1-1/+1
Other targets were never actually checked
2020-06-25memory_manager: Remove useless assertionDavid Marcec1-1/+0
num_pages is an std::size_t. It will always be >= 0
2020-06-25gl_device: Enable NV_vertex_buffer_unified_memory on Turing devicesReinUsesLisp1-19/+1
Once we make sure not to corrupt Nvidia's driver, we can safely use resident buffers on Turing devices. See GitHub pull request #4156
2020-06-24hid: Stub a series of "SevenSixAxisSensor" service commandsMorph2-21/+85
- Used by Captain Toad: Treasure Tracker Update 1.3.0 While we're at it, fix the input parameters for SetIsPalmaAllConnectable and SetPalmaBoostMode
2020-06-24padbutton enum class and struct initiailizationAmeer3-36/+32
2020-06-24Prevent nullptr dereference on swkbd error caseDavid Marcec1-1/+1
2020-06-24prepo: : Don't read extra buffer from report unless passedDavid Marcec1-1/+6
Prepo doesn't always pass a secondary buffer, we assume it always does which leads to a bad read.
2020-06-24Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSGDavid Marcec1-25/+22
Previously if applications would send faulty buffers(example homebrew) it would lead to us returning uninitalized data. Switching from ASSERT_MSG to ASSERT_OR_EXECUTE_MSG allows us to have a fail safe to prevent crashes but also continue execution without introducing undefined behavior
2020-06-24buffer_cache: Use buffer methods instead of cache virtual methodsReinUsesLisp5-99/+90
2020-06-24gl_stream_buffer: Use InvalidateBufferData instead unmap and mapReinUsesLisp2-15/+5
Making the stream buffer resident increases GPU usage significantly on some games. This seems to be addressed invalidating the stream buffer with InvalidateBufferData instead of using a Unmap + Map (with invalidation flags).
2020-06-24gl_rasterizer: Use NV_vertex_buffer_unified_memory for vertex buffer robustnessReinUsesLisp3-9/+39
Switch games are allowed to bind less data than what they use in a vertex buffer, the expected behavior here is that these values are read as zero. At the moment of writing this only D3D12, OpenGL and NVN through NV_vertex_buffer_unified_memory support vertex buffer with a size limit. In theory this could be emulated on Vulkan creating a new VkBuffer for each (handle, offset, length) tuple and binding the expected data to it. This is likely going to be slow and memory expensive when used on the vertex buffer and we have to do it on all draws because we can't know without analyzing indices when a game is going to read vertex data out of bounds. This is not a problem on OpenGL's BufferAddressRangeNV because it takes a length parameter, unlike Vulkan's CmdBindVertexBuffers that only takes buffers and offsets (the length is implicit in VkBuffer). It isn't a problem on D3D12 either, because D3D12_VERTEX_BUFFER_VIEW on IASetVertexBuffers takes SizeInBytes as a parameter (although I am not familiar with robustness on D3D12). Currently this only implements buffer ranges for vertex buffers, although indices can also be affected. A KHR_robustness profile is not created, but Nvidia's driver reads out of bound vertex data as zero anyway, this might have to be changed in the future. - Fixes SMO random triangles when capturing an enemy, getting hit, or looking at the environment on certain maps.
2020-06-24gl_buffer_cache: Mark buffers as residentReinUsesLisp10-67/+111
Make stream buffer and cached buffers as resident and query their address. This allows us to use GPU addresses for several proprietary Nvidia extensions.
2020-06-24gl_device: Expose NV_vertex_buffer_unified_memory except on TuringReinUsesLisp2-1/+30
Expose NV_vertex_buffer_unified_memory when the driver supports it. This commit adds a function the determine if a GL_RENDERER is a Turing GPU. This is required because on Turing GPUs Nvidia's driver crashes when the buffer is marked as resident or on DeleteBuffers. Without a synchronous debug output (single threaded driver), it's likely that the driver will crash in the first blocking call.
2020-06-24gl_stream_buffer: Always use a non-coherent bufferReinUsesLisp2-14/+10
2020-06-24gl_stream_buffer: Always use persistent memory mapsReinUsesLisp2-30/+14
yuzu no longer supports platforms without persistent maps.
2020-06-24Move GetKeyCodeMapImpl to an anonymous namespaceDavid Marcec1-19/+19
2020-06-24addressed issuesDavid Marcec2-4/+7
2020-06-24clear mme draw modeDavid Marcec1-0/+3
We already draw, so we can clear it
2020-06-24Addressed issuesDavid Marcec5-13/+17
2020-06-24Fix constbuffer for 0217920100488FF7David Marcec1-6/+6
2020-06-24Macro HLE supportDavid Marcec9-10/+209
2020-06-24Fixed logging outputDavid Marcec1-1/+1
2020-06-24Implement GetKeyCodeMap & GetKeyCodeMap2David Marcec2-2/+72
Closes #3919
2020-06-24gl_shader_cache: Avoid use after move for program sizeReinUsesLisp2-6/+7
All programs had a size of zero due to this bug, skipping invalidations. While we are at it, remove some unused forward declarations.
2020-06-23cleanup check access, read, and factory GetNextInput funcs. Use size rather than magic numberAmeer4-151/+101
2020-06-23Fix deallocation of GC AdapterAmeer3-4/+10
2020-06-23yuzu_tester: Silence type conversion warningMorph1-1/+1
2020-06-23lm: Silence no return value warningMorph1-1/+2
2020-06-23Small quality of life indication that mapped button is GCAmeer1-2/+2
2020-06-23shader/half_set: Implement HSET2_IMMReinUsesLisp2-21/+75
Add HSET2_IMM. Due to the complexity of the encoding avoid using BitField unions and read the relevant bits from the code itself. This is less error prone.
2020-06-23std::array and const reference passing of non-trivial objectsAmeer2-14/+13
2020-06-22Update src/input_common/main.cppameerj1-1/+1
Co-authored-by: LC <mathew1800@gmail.com> update libusb submodule (hopefully windows build error fixed)
2020-06-22account: Update function tables and add missing classes (#4145)VolcaEM5-42/+384
* account: Update function tables and add missing classes * clang-format * Add missing "public" * Add missing public again * Add missing final
2020-06-22TextureCache: Fix case where layer goes off bound.Fernando Sahmkow1-0/+3
The returned layer is expected to be between 0 and the depth of the surface, anything larger is off bounds.
2020-06-22Reorder variables to comply with the Auzure build pipelineunknown1-2/+2
2020-06-22arm_dynarmic_64: Log the instruction when an exception is raisedMorph1-2/+2
2020-06-22arm_dynarmic_32: Log under Core_ARM instead of HW_GPUMorph1-1/+1
2020-06-22renderer_vulkan: Update validation layer name and test before enablingReinUsesLisp3-5/+43
Update validation layer string to VK_LAYER_KHRONOS_validation. While we are at it, properly check for available validation layers before enabling them.
2020-06-22Tidy up the pointers, use pair over tuple where appropriateAmeer4-24/+22
2020-06-22fix for sleep using stlAmeer1-1/+3
2020-06-22shared_ptr for the GC adapter class, constexpr constantsAmeer5-66/+52
2020-06-22std::arrays where appropriate, clear q in adapter class, other touch upsAmeer5-27/+15
2020-06-22fix include threadAmeer1-0/+1
2020-06-22Singleton GC Adapter class, remove globals, fix naming conventionAmeer8-228/+283
Fix clang formatting Manual fix for configure_input_player formatting Add missing lib usb cmake command
2020-06-21hid: Implement Get/ResetGyroscopeZeroDriftModeMorph4-6/+56
- Used by Captain Toad Treasure Tracker
2020-06-21Clang FormattingAmeer9-182/+184
2020-06-21Cleanup after linterAmeer9-167/+98
2020-06-21GC Adapter ImplementationAmeer18-161/+1159
2020-06-21Correct function name (2/2)VolcaEM1-2/+2
2020-06-21Correct function name (1/2)VolcaEM1-1/+1
2020-06-21Clang-formatVolcaEM1-1/+1
2020-06-21Remove unnecessary conversionVolcaEM1-3/+2
2020-06-21Address review comment by LioncashVolcaEM1-1/+1
Co-authored-by: LC <mathew1800@gmail.com>
2020-06-21Add a "Open Mods Page" button to the GUIVolcaEM3-0/+20
2020-06-21gl_shader_decompiler: Enable GL_EXT_texture_shadow_lod if availableMorph1-7/+43
Enable GL_EXT_texture_shadow_lod if available. If this extension is not available, such as on Intel/AMD proprietary drivers, use textureGrad as a workaround.
2020-06-21gl_device: Check for GL_EXT_texture_shadow_lodMorph2-0/+7
2020-06-21Fix: fatal error CVT1100 when compiling manifest fileFearlessTobi3-3/+3
Occurs when doing a local compile in MSVC build. The compiler I'm using is as below: Microsoft Visual Studio Community 2019 Preview Version 16.6.0 Preview 5.0 Fixes this error: CVTRES : fatal error CVT1100: duplicate resource. type:MANIFEST, name:1, language:0x0409 LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt I have put 0 since previous name was 1. If have other names in mind, please let me know. Co-Authored-By: dragios <dragios@users.noreply.github.com>
2020-06-20macro_jit_x64: Use ecx for shift registerMerryMage1-2/+2
shl/shr only accept cl as their second argument
2020-06-20texture_cache: Fix incorrect address used in a DeduceSurface() callLioncash1-1/+1
Previously the source was being deduced twice in a row.
2020-06-20software_keyboard: Eliminate trivial redundant copiesLioncash1-2/+2
We can just make use of moves here to get rid of two redundant copies
2020-06-20main: Append AVX and FMA instructions to cpu stringMorph1-1/+14
Append AVX and FMA instructions to cpu string if the host cpu supports them
2020-06-20common/telemetry: Add AVX512 to telemetryMorph1-0/+1
2020-06-20common/cpu_detect: Add AVX512 detectionMorph2-0/+6
2020-06-20decode/image: Implement B10G11R11FMorph1-9/+17
- Used by Kirby Star Allies
2020-06-20gl_arb_decompiler: Avoid several string copiesLioncash1-32/+31
Variables that are marked as const cannot have the move constructor invoked when returning from a function (the move constructor requires a non-const variable so it can "steal" the resources from it.
2020-06-20vulkan/wrapper: Remove noexcept from GetSurfaceCapabilitiesKHR()Lioncash2-3/+2
Check() can throw an exception if the Vulkan result isn't successful. We remove the check so that std::terminate isn't outright called and allows for better debugging (should it ever actually fail).
2020-06-20macro_jit_x64: Correct readability of Compile_ExtractShiftLeftImmediate()Lioncash1-3/+3
Previously dst wasn't being used.
2020-06-20macro_jit_x64: Correct readability of Compile_ExtractShiftLeftRegister()Lioncash1-3/+4
Previously dst wasn't being used.
2020-06-20macro_jit_x64: Remove unused variableLioncash1-2/+1
Removes a completely unused label and marks another variable as unused, given it seems like it has potential uses in the future.
2020-06-20memory_manager: Eliminate variable shadowingLioncash2-24/+28
Renames some variables to prevent ones in inner scopes from shadowing outer-scoped variables. The Copy* functions have no shadowing, but we rename them anyways to remain consistent with the other functions.
2020-06-20Add translation of "Current Boxcat Events"David Marcec1-3/+2
2020-06-20macro_jit_x64: Eliminate variable shadowing in Compile_ProcessResult()Lioncash1-2/+2
We can reduce the capture scope so that it's not possible for both "reg" variables to clash with one another. While we're at it, we can prevent unnecessary copies while we're at it.
2020-06-20buffer_cache: Eliminate local variable shadowingLioncash1-2/+1
We can just make use of the instance in the scope above this one.
2020-06-19input_common/motion_emu: Remove redundant moveMerryMage1-1/+1
Named return value optimization automatically applies here.
2020-06-19input_common/keyboard: Remove redundant moveMerryMage1-1/+1
Named return value optimization automatically applies here.
2020-06-19mii_model: Remove redundant std::moveMerryMage1-1/+1
Named return value optimization automatically applies here.
2020-06-19Fix compilation when not building with boxcatDavid Marcec2-2/+7
Fixes compilation when trying to build without boxcat enabled
2020-06-19macro_jit_x64: Remove unused function ReadMerryMage1-8/+4
2020-06-18vk_rasterizer: Don't preserve contents on full screen clearsReinUsesLisp2-7/+58
There's no need to load contents from the CPU when a clear resets all the contents of the underlying memory. This is already implemented on OpenGL and the texture cache.
2020-06-18vk_update_descriptor: Upload descriptor sets data directlyReinUsesLisp3-42/+30
Instead of copying to a temporary payload before sending the update task to the worker thread, insert elements to the payload directly.
2020-06-18Tests/HostTiming: Correct GCC Compile error.Fernando Sahmkow1-15/+14
2020-06-18Common/Fiber: Address Feedback and Correct Memory leaks.Fernando Sahmkow2-34/+41
2020-06-18Common/Fiber: Implement Rewind on Boost Context.Fernando Sahmkow2-2/+39
2020-06-18Common/uint128: Correct MSVC Compilation in old versions.Fernando Sahmkow1-0/+4
2020-06-18Common/Fiber: Document fiber interexchange.Fernando Sahmkow1-1/+4
2020-06-18Common/Fiber: Implement Rewinding.Fernando Sahmkow3-2/+84
2020-06-18Common/Fiber: Additional corrections to f_context.Fernando Sahmkow1-4/+4
2020-06-18Common/Fiber: Correct f_context based Fibers.Fernando Sahmkow1-6/+8
2020-06-18Host Timing: Correct clang format.Fernando Sahmkow1-1/+0
2020-06-18HostTiming: Correct rebase and implement AddTicks.Fernando Sahmkow2-1/+19
2020-06-18Core/HostTiming: Allow events to be advanced manually.Fernando Sahmkow4-31/+47
2020-06-18Common/Tests: Address FeedbackFernando Sahmkow9-39/+51
2020-06-18Common: Make MinGW build use Windows Fibers instead of fcontext_tFernando Sahmkow2-4/+4
2020-06-18Common/Tests: Clang Format.Fernando Sahmkow7-31/+41
2020-06-18Common: Correct fcontext fibers.Fernando Sahmkow1-5/+4
2020-06-18Common: Refactor & Document Wall clock.Fernando Sahmkow6-51/+50
2020-06-18Common: Implement WallClock Interface and implement a native clock for x64Fernando Sahmkow10-40/+378
2020-06-18Tests: Add base tests to host timingFernando Sahmkow5-43/+243
2020-06-18Core: Implement a Host Timer.Fernando Sahmkow5-0/+295
2020-06-18Common: Polish Fiber class, add comments, asserts and more tests.Fernando Sahmkow5-25/+147
2020-06-18Tests: Add tests for fibers and refactor/fix Fiber classFernando Sahmkow4-19/+247
2020-06-18Common: Implement a basic Fiber class.Fernando Sahmkow3-0/+204
2020-06-18Common: Implement a basic SpinLock classFernando Sahmkow3-0/+68
2020-06-18arm_dynarmic_32: Fix implicit conversion error in SetTPIDR_EL0ReinUsesLisp1-1/+1
On MSVC builds we treat conversion warnings as errors.
2020-06-18bootmanager: Remove references to OpenGL for macOSMerryMage2-2/+19
OpenGL macOS headers definitions clash heavily with each other
2020-06-18memory_manager: Explicitly specifcy std::min<size_t>MerryMage1-2/+2
2020-06-18shared_font: Service::NS::EncryptSharedFont takes a size_t&MerryMage1-1/+1
2020-06-18vk_rasterizer: BindTransformFeedbackBuffersEXT accepts a size of type VkDeviceSizeMerryMage1-1/+1
2020-06-18renderer_vulkan: Fix macOS GetBundleDirectory referenceMerryMage1-1/+3
2020-06-18memory_util: boost hashes are size_tMerryMage1-2/+2
* boost::hash_value returns a size_t * boost::hash_combine takes a size_t& argument
2020-06-18Rename PAGE_SHIFT to PAGE_BITSMerryMage2-10/+10
macOS header files #define PAGE_SHIFT
2020-06-18Move SHA256Hash to its original positionVolcaEM1-2/+2
It's not needed to have it in its previous position anymore
2020-06-18vk_sampler_cache: Emulate GL_LINEAR/NEAREST minification filtersMorph1-2/+4
Emulate GL_LINEAR/NEAREST minification filters using minLod = 0 and maxLod = 0.25 during sampler creation
2020-06-18maxwell_to_vk: Reorder filter cases and correct mipmap_filter=NoneMorph1-17/+15
maxwell_to_vk: Reorder filtering modes to start with None, then Nearest, then Linear. maxwell_to_vk: Logs filter modes under UNREACHABLE_MSG instead of UNIMPLEMENTED_MSG, since any unknown filter modes are invalid and not unimplemented. maxwell_to_vk: Return VK_SAMPLER_MIPMAP_MODE_NEAREST instead of VK_SAMPLER_MIPMAP_MODE_LINEAR when mipmap_filter is None with the description from the VkSamplerCreateInfo(3) man page.
2020-06-18maxwell_to_gl: Miscellaneous changesMorph1-48/+34
maxwell_to_gl: Log unimplemented features under UNIMPLEMENTED_MSG instead of LOG_ERROR to bring into parity with maxwell_to_vk maxwell_to_gl: Deduplicate logging in VertexType(), merging them into one. maxwell_to_gl: Return GL_NEAREST instead of GL_LINEAR if an unknown texture filter mode is encountered. maxwell_to_gl: Log the mipmap filter mode if an unknown value is passed in. maxwell_to_gl: Reorder filtering modes to start with None, then Nearest, then Linear.
2020-06-17macro_jit_x64: Inline Engines::Maxwell3D::GetRegisterValueMerryMage2-6/+18
2020-06-17arm_dynarmic_cp15: Implement CNTPCTMerryMage1-0/+13
2020-06-17arm_dynarmic_cp15: Update CP15MerryMage4-142/+73
2020-06-17arm_dynarmic_32: InterpreterFallback should never happenMerryMage1-2/+3
2020-06-17macro_jit_x64: Optimization implicitly assumes same destinationMerryMage1-1/+2
2020-06-17macro_jit_x64: Should not skip zero registers for certain ALU opsMerryMage1-1/+3
The code generated for these ALU ops assume src_a and src_b are always valid.
2020-06-17Fix framebuffer size on fractional scaling display.Kaiwen Xu1-1/+1
2020-06-16Remove unnecessary pragmasVolcaEM1-8/+0
2020-06-16Revert IsValidNRO refactor but make it more readableVolcaEM1-26/+13
2020-06-16Update assert stringVolcaEM1-1/+1
2020-06-16gl_device: Reserve at least 4 image bindings for fragment stageMorph1-6/+14
Due to the limitation of GL_MAX_IMAGE_UNITS being low (8) on Intel's and Nvidia's proprietary drivers, we have to reserve an appropriate amount of image bindings for each of the stages. So far games have been observed to use 4 image bindings on the fragment stage (Kirby Star Allies) and 1 on the vertex stage (TWD series). No games thus far in my limited testing used more than 4 images concurrently and across all currently active programs. This fixes shader compilation errors on Kirby Star Allies on OpenGL (GLSL/GLASM)
2020-06-15macro_jit_x64: Remove NEXT_PARAMETERMerryMage1-5/+2
Not required, as PARAMETERS can just be incremented directly.
2020-06-15macro_jit_x64: Remove unused function Compile_WriteCarryMerryMage2-9/+0
2020-06-15macro_jit_x64: Select better registersMerryMage1-8/+8
All registers are now callee-save registers. RBX and RBP selected for STATE and RESULT because these are most commonly accessed; this is to avoid the REX prefix. RBP not used for STATE because there are some SIB restrictions, RBX emits smaller code.
2020-06-15macro_jit_x64: Remove REGISTERSMerryMage1-7/+3
Unnecessary since this is just an offset from STATE.
2020-06-15macro_jit_x64: Remove JITState::parametersMerryMage2-6/+3
This can be passed in as an argument instead.
2020-06-15macro_jit_x64: Remove METHOD_ADDRESS_64MerryMage1-2/+1
Unnecessary variable.
2020-06-15macro_jit_x64: Remove RESULT_64MerryMage2-16/+3
This Reg64 codepath has the exact same behaviour as the Reg32 one.
2020-06-15xbyak_abi: Prefer returning a struct to using out parameters in ABI_CalculateFrameSizeMerryMage1-17/+19
2020-06-15xbyak_abi: Register indexes should be unsignedMerryMage1-11/+12
2020-06-15xbyak_abi: Remove *GPS variants of stack manipulation functionsMerryMage2-42/+6
2020-06-15xbyak_abi: Fix ABI_PushRegistersAndAdjustStackMerryMage1-6/+2
Pushing GPRs twice.
2020-06-15video_core/macro_jit_x64: Remove initializer in member variableReinUsesLisp1-2/+2
Fix build time issues on gcc. Confirmed through asan that avoiding this initialization is safe.
2020-06-14Clang-format againVolcaEM1-2/+2
2020-06-14Use consistent variable namesVolcaEM1-4/+4
2020-06-14Clang-formatVolcaEM1-1/+2
2020-06-14Make assert strings consistentVolcaEM1-3/+3
2020-06-14Attempt to fix crashes in SSBU and refactor IsValidNROVolcaEM1-36/+59
2020-06-13audren: Implement RendererInfoDavid Marcec2-6/+26
Fixes ZLA softlock
2020-06-12gl_arb_decompiler: Implement FSwizzleAddReinUsesLisp1-4/+27
2020-06-12gl_arb_decompiler: Implement an assembly shader decompilerReinUsesLisp7-1/+2093
Emit code compatible with NV_gpu_program5. This should emit code compatible with Fermi, but it wasn't tested on that architecture. Pascal has some issues not present on Turing GPUs.
2020-06-11yuzu/configuration: Show assembly shaders check boxReinUsesLisp1-3/+0
2020-06-10nvdrv: Fix GetTPCMasks for ioctl3David Marcec2-21/+22
Fixes animal crossing svcBreak on launch
2020-06-10kernel: Account for system resource size for memory usageDavid Marcec1-2/+4
GetTotalPhysicalMemoryAvailableWithoutSystemResource & GetTotalPhysicalMemoryUsedWithoutSystemResource seem to subtract the resource size from the usage.
2020-06-09buffer_cache: Avoid passing references of shared pointers and misc style changesReinUsesLisp9-174/+150
Instead of using as template argument a shared pointer, use the underlying type and manage shared pointers explicitly. This can make removing shared pointers from the cache more easy. While we are at it, make some misc style changes and general improvements (like insert_or_assign instead of operator[] + operator=).
2020-06-09gl_rasterizer: Mark vertex buffers as dirty after buffer cache invalidationReinUsesLisp1-1/+10
Vertex buffers bindings become invalid after the stream buffer is invalidated. We were originally doing this, but it got lost at some point. - Fixes Animal Crossing: New Horizons, but it affects everything.
2020-06-09buffer_cache: Return stream buffer invalidation in Map instead of UnmapReinUsesLisp1-7/+9
We have to invalidate whatever cache is being used before uploading the data, hence it makes more sense to return this on Map instead of Unmap.
2020-06-08Add game versio to title barunknown2-13/+17
2020-06-08texture_cache: Port original code management for 2D vs 3D texturesReinUsesLisp2-16/+35
Handle blits to images as 2D, even when they have block depth. - Fixes rendering issues on Luigi's Mansion 3
2020-06-08texture_cache: Simplify blit codeReinUsesLisp1-9/+7
2020-06-08texture_cache: Handle 3D texture blits with one layerReinUsesLisp3-5/+10
2020-06-08texture_cache: Implement rendering to 3D texturesReinUsesLisp10-139/+191
This allows rendering to 3D textures with more than one slice. Applications are allowed to render to more than one slice of a texture using gl_Layer from a VTG shader. This also requires reworking how 3D texture collisions are handled, for now, this commit allows rendering to slices but not to miplevels. When a render target attempts to write to a mipmap, we fallback to the previous implementation (copying or flushing as needed). - Fixes color correction 3D textures on UE4 games (rainbow effects). - Allows Xenoblade games to render to 3D textures directly.
2020-06-07rasterizer_cache: Remove files and includesReinUsesLisp7-269/+3
The rasterizer cache is no longer used. Each cache has its own generic implementation optimized for the cached data.
2020-06-07vk_pipeline_cache: Use generic shader cacheReinUsesLisp5-58/+55
Trivial port the generic shader cache to Vulkan.
2020-06-07gl_shader_cache: Use generic shader cacheReinUsesLisp4-93/+80
Trivially port the generic shader cache to OpenGL.
2020-06-07shader_cache: Implement a generic shader cacheReinUsesLisp2-0/+229
Implement a generic shader cache for fast lookups and invalidations. Invalidations are cheap but expensive when a shader is invalidated. Use two mutexes instead of one to avoid locking invalidations for lookups and vice versa. When a shader has to be removed, lookups are locked as expected.
2020-06-06yuzu/frontend: Remove internal resolution optionMorph9-113/+3
2020-06-06gl_device: Black list NVIDIA 443.24 for fast buffer uploadsReinUsesLisp1-2/+10
Skip fast buffer uploads on Nvidia 443.24 Vulkan beta driver on OpenGL. This driver throws the following error when calling BufferSubData or BufferData on buffers that are candidates for fast constant buffer uploads. This is the equivalens to push constants on Vulkan, except that they can access the full buffer. The error: Unknown internal debug message. The NVIDIA OpenGL driver has encountered an out of memory error. This application might behave inconsistently and fail. If this error persists on future drivers, we might have to look deeper into this issue. For now, we can black list it and log it as a temporary solution.
2020-06-06renderer_opengl: Only enable DEBUG_OUTPUT when graphics debugging is enabledReinUsesLisp1-4/+2
Avoids logging when it's not relevant. This can potentially reduce driver's internal thread overhead.
2020-06-05shader/texture: Join separate image and sampler pairs offlineReinUsesLisp16-88/+234
Games using D3D idioms can join images and samplers when a shader executes, instead of baking them into a combined sampler image. This is also possible on Vulkan. One approach to this solution would be to use separate samplers on Vulkan and leave this unimplemented on OpenGL, but we can't do this because there's no consistent way of determining which constant buffer holds a sampler and which one an image. We could in theory find the first bit and if it's in the TIC area, it's an image; but this falls apart when an image or sampler handle use an index of zero. The used approach is to track for a LOP.OR operation (this is done at an IR level, not at an ISA level), track again the constant buffers used as source and store this pair. Then, outside of shader execution, join the sample and image pair with a bitwise or operation. This approach won't work on games that truly use separate samplers in a meaningful way. For example, pooling textures in a 2D array and determining at runtime what sampler to use. This invalidates OpenGL's disk shader cache :) - Used mostly by D3D ports to Switch
2020-06-05service: nvhost_vic: Ignore Submit commands.bunnei2-1/+18
2020-06-05nvdrv: Stub nvdec/vic ioctls to bypass nvdec moviesZach Hilman4-3/+239
2020-06-05shader/track: Move bindless tracking to a separate functionReinUsesLisp2-25/+39
2020-06-04Downgrade "handle not signaled" error to traceDavid Marcec1-1/+1
clogs logs quite a bit
2020-06-04Default init labels and use initializer list for macro engineDavid Marcec2-2/+2
2020-06-04gl_rasterizer: Use NV_transform_feedback for XFB on assembly shadersReinUsesLisp3-1/+96
NV_transform_feedback, NV_transform_feedback2 and ARB_transform_feedback3 with NV_transform_feedback interactions allows implementing transform feedbacks as dynamic state. Maxwell implements transform feedbacks as dynamic state, so using these extensions with TransformFeedbackStreamAttribsNV allows us to properly emulate transform feedbacks without having to recompile shaders when the state changes.
2020-06-03Mark parameters as constDavid Marcec8-11/+11
2020-06-03Actually save the input when clearing/resetting to defaultFearlessTobi1-0/+3
Co-Authored-By: xperia64 <xperiancedapps@gmail.com>
2020-06-02Address review commentsVolcaEM1-4/+4
2020-06-02Pass by reference instead of copying parametersDavid Marcec4-7/+9
2020-06-02vk_shader_decompiler: Implement atomic image operationsReinUsesLisp1-40/+24
Implement atomic operations on images. On GLSL these are atomicImage* functions (e.g. atomicImageAdd).
2020-06-02vk_rasterizer: Implement storage texelsReinUsesLisp8-52/+120
This is the equivalent of an image buffer on OpenGL. - Used by Octopath Traveler
2020-06-02maxwell_to_vk: Add R16UI image formatReinUsesLisp2-71/+74
- Used by Octopath Traveler
2020-06-01gl_shader_decompiler: Declare gl_Layer and gl_ViewportIndex within gl_PerVertex for vertex and tessellation shadersMorph1-6/+16
2020-06-01gl_shader_decompiler: Fix geometry shader outputs for Intel driversMorph1-13/+15
On Intel's proprietary drivers, gl_Layer and gl_ViewportIndex are not allowed members of gl_PerVertex block, causing the shader to fail to compile. Fix this by declaring these variables outside of gl_PerVertex.
2020-06-01Clang-formatVolcaEM1-2/+1
2020-06-01hid: Stub GetXpadIDsVolcaEM2-1/+14
Allows Minecraft: Nintendo Switch Edition (a.k.a. old Minecraft) to boot and go ingame
2020-06-01gl_device: Avoid devices with CAVEAT_SUPPORT on ASTCReinUsesLisp2-8/+19
This avoids using Nvidia's ASTC decoder on OpenGL. The last time it was profiled, it was slower than yuzu's decoder. While we are at it, fix a bug in the texture cache when native ASTC is not supported.
2020-06-01glsl: Squash constant buffers into a single SSBO when we hit the limitReinUsesLisp7-79/+173
Avoids compilation errors at the cost of shader build times and runtime performance when a game hits the limit of uniform buffers we can use.
2020-05-31Add comment to nrr_kindVolcaEM1-1/+1
According to Atmosphére (https://github.com/Atmosphere-NX/Atmosphere/blob/c7026b90940a1d88f9c10a6d98263bf22e654fa5/libraries/libstratosphere/include/stratosphere/ro/ro_types.hpp), nrr_kind (Atmosphére calls it "type") is 7.0.0+
2020-05-31ldr: Update NRR/NRO structs VolcaEM1-40/+72
This was based on Switchbrew pages: https://switchbrew.org/wiki/NRR https://switchbrew.org/wiki/NRO
2020-05-31gl_device: Enable compute shaders for Intel proprietary driversMorph3-13/+0
Previously we were disabling compute shaders on Intel's proprietary driver due to broken compute. This has been fixed in the latest Intel drivers. Re-enable compute for Intel proprietary drivers and remove the check for broken compute.
2020-05-30shader/other: Fix hardcoded value in S2R INVOCATION_INFOReinUsesLisp1-1/+1
Geometry shaders built from Nvidia's compiler check for bits[16:23] to be less than or equal to 0 with VSETP to default to a "safe" value of 0x8000'0000 (safe from hardware's perspective). To avoid hitting this path in the shader, return 0x00ff'0000 from S2R INVOCATION_INFO. This seems to be the maximum number of vertices a geometry shader can emit in a primitive.
2020-05-30texture_cache: More relaxed reconstructionReinUsesLisp1-13/+9
Only reupload textures when they've not been modified from the GPU.
2020-05-30Favor switch case over jump tableDavid Marcec2-18/+26
Easier to read and will emit a jump table automatically.
2020-05-30Implement macro JITDavid Marcec15-189/+1034
2020-05-30Add xbyak externalDavid Marcec4-2/+317
2020-05-30texture_cache: Only copy textures that were modified from hostReinUsesLisp1-2/+6
2020-05-30texture_cache: Reload textures when number of resources mismatchReinUsesLisp1-0/+9
2020-05-29vk_rasterizer: Skip transform feedbacks when extension is unavailableReinUsesLisp1-0/+7
Avoids calling transform feedback procedures when VK_EXT_transform_feedback is not available.
2020-05-29texture_cache: Handle overlaps with multiple subresourcesReinUsesLisp1-27/+33
Implement more surface reconstruct cases. Allow overlaps with more than one layer and mipmap and copies all of them to the new texture. - Fixes textures moving around objects on Xenoblade games
2020-05-29kernel: ResourceLimit::Reserve remove useless while loopDavid Marcec1-5/+1
Timeout is a u64, it will always be >= 0
2020-05-28maxwell_3d: Reduce severity of logs that can be spammedReinUsesLisp1-6/+7
These logs were killing performance on some games when they were spammed. Reduce them to Debug severity.
2020-05-28format_lookup_table: Implement G24S8 format as S8Z24ReinUsesLisp1-1/+2
2020-05-28Make copying directory string more conciselat9nq1-2/+1
2020-05-28Address requested changeslat9nq2-4/+4
2020-05-28*nix systems can read any-case patch directorieslat9nq2-8/+32
Changes many patch_manager functions to use a case-less variant of GetSubdirectory. Fixes patches not showing up on *nix systems when patch directories are named with odd cases, i.e. `exeFS'.
2020-05-28buffer_cache: Avoid copying twice on certain casesReinUsesLisp1-17/+23
Avoid copying to a staging buffer on non-granular memory addresses. Add a callable argument to StreamBufferUpload to be able to copy to the staging buffer directly from ReadBlockUnsafe.
2020-05-27texture_cache: Use unordered_map::find instead of operator[] on hot codeReinUsesLisp1-15/+19
2020-05-27texture_cache: Use small vector for surface vectorsReinUsesLisp1-9/+10
This avoids most heap allocations when collecting surfaces into a vector.
2020-05-27maxwell_3d: Initialize line widthsReinUsesLisp1-0/+2
Initialize line widths to avoid setting a line width of zero.
2020-05-27maxwell_3d: Initialize polygon modesReinUsesLisp1-0/+2
NVN expects this to be initialized as Fill, otherwise games that never bind a rasterizer state will log an invalid polygon mode.
2020-05-27Fix macOS code and change "Swapfile" to "Swap"Morph2-3/+6
2020-05-27shader/other: Implement MEMBAR.CTSReinUsesLisp4-9/+27
This silences an assertion we were hitting and uses workgroup memory barriers when the game requests it.
2020-05-26texture_cache: Fix layered null surfacesReinUsesLisp1-1/+3
Null texture cubes were not considered arrays, causing issues on Vulkan and OpenGL when creating views.
2020-05-26gl_texture_cache: Implement small texture view cache for swizzlesReinUsesLisp3-37/+44
This fixes cases where the texture swizzle was applied twice on the same draw to a texture bound to two different slots.
2020-05-26texture_cache: Implement depth stencil texture swizzlesReinUsesLisp3-36/+42
Stop ignoring image swizzles on depth and stencil images. This doesn't fix a known issue on Xenoblade Chronicles 2 where an OpenGL texture changes swizzles twice before being used. A proper fix would be having a small texture view cache for this like we do on Vulkan.
2020-05-26gl_rasterizer: Port front face flip check from VulkanReinUsesLisp1-5/+20
While Vulkan was assuming we had no negative viewports, OpenGL code was assuming we had them. Port the old code from Vulkan to OpenGL, checking if the first viewport is negative before flipping faces. This is not a complete implementation since we only check for the first viewport to be negative. That said, unless a game is using Vulkan, OpenGL and NVN games should be fine here, and we can always compare with our Vulkan backend to see if there's a difference.
2020-05-26fixed_pipeline_state: Remove unnecessary check for front faces flipReinUsesLisp1-2/+1
The check to flip faces when viewports are negative were a left over from the old OpenGL code. This is not required on Vulkan where we have negative viewports.
2020-05-26gl_shader_manager: Unbind GLSL program when binding a host pipelineReinUsesLisp1-0/+4
Fixes regression in Link's Awakening caused by 420cc13248350ef5c2d19e0b961cb4185cd16a8a
2020-05-22yuzu/discord_impl: Update the applicationID (#3977)Tobias1-1/+1
2020-05-22shader/other: Implement BAR.SYNC 0x0ReinUsesLisp4-0/+33
Trivially implement this particular case of BAR. Unless games use OpenCL or CUDA barriers, we shouldn't hit any other case here.
2020-05-22shader/memory: Implement non-addition operations in REDReinUsesLisp1-2/+1
Trivially implement these instructions. They are used in Astral Chain.
2020-05-22shader/other: Implement thread comparisons (NV_shader_thread_group)ReinUsesLisp4-0/+72
Hardware S2R special registers match gl_Thread*MaskNV. We can trivially implement these using Nvidia's extension on OpenGL or naively stubbing them with the ARB instructions to match. This might cause issues if the host device warp size doesn't match Nvidia's. That said, this is unlikely on proper shaders. Refer to the attached url for more documentation about these flags. https://www.khronos.org/registry/OpenGL/extensions/NV/NV_shader_thread_group.txt
2020-05-22shader_decompiler: Visit source nodes even when they assign to RZReinUsesLisp2-2/+6
Some operations like atomicMin were ignored because they returned were being stored to RZ. This operations have a side effect and it was being ignored.
2020-05-22vk_shader_decompiler: Don't assert for void returnsReinUsesLisp1-2/+1
Atomic instructions can be used without returning anything and this is valid code. Remove the assert.
2020-05-21buffer_cache: Remove unused boost headersReinUsesLisp1-2/+0
2020-05-21map_interval: Add interval allocator and drop hackReinUsesLisp4-3/+79
Drop the std::list hack to allocate memory indefinitely. Instead use a custom allocator that keeps references valid until destruction. This allocates fixed chunks of memory and puts pointers in a free list. When an allocation is no longer used put it back to the free list, this doesn't heap allocate because std::vector doesn't change the capacity. If the free list is empty, allocate a new chunk.
2020-05-21buffer_cache: Use boost::container::small_vector for maps in rangeReinUsesLisp1-13/+15
Most overlaps in the buffer cache only contain one mapped address. We can avoid close to all heap allocations once the buffer cache is warmed up by using a small_vector with a stack size of one.
2020-05-21buffer_cache: Use boost::intrusive::set for cachingReinUsesLisp6-30/+48
Instead of using boost::icl::interval_map for caching, use boost::intrusive::set. interval_map is intended as a container where the keys can overlap with one another; we don't need this for caching buffers and a std::set-like data structure that allows us to search with lower_bound is enough.
2020-05-21buffer_cache: Remove shared pointersReinUsesLisp2-70/+72
Removing shared pointers is a first step to be able to use intrusive objects and keep allocations close to one another in memory.
2020-05-21buffer_cache: Minor style changesReinUsesLisp2-129/+65
Minor style changes. Mostly done so I avoid editing it while doing other changes.
2020-05-21clang-formatVolcaEM1-1/+2
2020-05-21nifm: correct assert in CreateTemporaryNetworkProfileVolcaEM1-1/+1
This has been wrong since https://github.com/yuzu-emu/yuzu/commit/0432af5ad1ec34f02071f6fdc5fc78149b059f18 I haven't found a game that called this function (and I haven't tried this on a real Switch), and because of this I haven't been able to check if the number in assert OR the string in the assert is wrong, but one of the two is wrong: NetworkProfileData is 0x18E, while SfNetworkProfileData is 0x17C, according to Switchbrew Switchbrew doesn't officially say that NetworkProfileData's size is 0x18E but it's possible to calculate its size since Switchbrew provides the size and the offset of all the components of NetworkProfileData (which isn't currently implemented in yuzu, alongside SfNetworkProfileData) NetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#NetworkProfileData SfNetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#SfNetworkProfileData Since I trust ogniK's work on reversing NIFM, I'd assume this was just a typo in the string
2020-05-20crypto: Make KeyManager a singleton classFearlessTobi13-21/+27
Previously, we were reading the keys everytime a KeyManager object was created, causing yuzu to reread the keys file multiple hundreds of times when loading the game list. With this change, it is only loaded once. On my system, this decreased game list loading times by a factor of 20.
2020-05-19renderer_opengl: Add assembly program code pathsReinUsesLisp12-109/+339
Add code required to use OpenGL assembly programs based on NV_gpu_program5. Decompilation for ARB programs is intended to be added in a follow up commit. This does **not** include ARB decompilation and it's not in an usable state. The intention behind assembly programs is to reduce shader stutter significantly on drivers supporting NV_gpu_program5 (and other required extensions). Currently only Nvidia's proprietary driver supports these extensions. Add a UI option hidden for now to avoid people enabling this option accidentally. This code path has some limitations that OpenGL compatibility doesn't have: - NV_shader_storage_buffer_object is limited to 16 entries for a single OpenGL context state (I don't know if this is an intended limitation, an specification issue or I am missing something). Currently causes issues on The Legend of Zelda: Link's Awakening. - NV_parameter_buffer_object can't bind buffers using an offset different to zero. The used workaround is to copy to a temporary buffer (this doesn't happen often so it's not an issue). On the other hand, it has the following advantages: - Shaders build a lot faster. - We have control over how floating point rounding is done over individual instructions (SPIR-V on Vulkan can't do this). - Operations on shared memory can be unsigned and signed. - Transform feedbacks are dynamic state (not yet implemented). - Parameter buffers (uniform buffers) are per stage, matching NVN and hardware's behavior. - The API to bind and create assembly programs makes sense, unlike ARB_separate_shader_objects.
2020-05-19yuzu: Add frontend settings for assembly shadersReinUsesLisp8-0/+29
Add settings for assembly shaders. Currently hidden to avoid users from accidentally enabled them.
2020-05-18maxwell_to_vk: Add format B8G8R8A8_SRGBMorph2-2/+3
Add format B8G8R8A8_SRGB and add Attachable capability for B8G8R8A8_UNORM Used by Bravely Default II
2020-05-18OpenGL: Enable Debug Context and Synchronous debugging when graphics debugging is enabled.Fernando Sahmkow3-0/+9
This commit aims to help easing debugging of driver crashes without having to modify existing code.
2020-05-17main: Log host system memory parametersMorph4-0/+86
Logs both physical memory and swapfile sizes, this is useful for support.
2020-05-16file_sys: Update SystemVersion archive to version 10.0.2David Marcec1-7/+7
2020-05-16nv_flinger: Use enum for pixel format instead of u32David Marcec2-3/+11
2020-05-16DmaPusher: Remove dead code in stepDavid Marcec2-9/+1
2020-05-16vk_rasterizer: Match OpenGL's FlushAndInvalidate behaviorReinUsesLisp1-1/+3
Match OpenGL's behavior. This can fix or simplify bisecting issues on Vulkan.
2020-05-15frontend: Set minimum window size to 640x360 instead of 1280x720 (#3413)Morph6-8/+36
2020-05-13vk_rasterizer: Implement constant attributesReinUsesLisp4-13/+26
Constant attributes (in OpenGL known disabled attributes) are not supported on Vulkan, even with extensions. To emulate this behavior we return zero on reads from disabled vertex attributes in shader code. This has no caching cost because attribute formats are not dynamic state on Vulkan and we have to store it in the pipeline cache anyway. - Fixes Animal Crossing: New Horizons terrain borders
2020-05-13vk_rasterizer: Remove buffer check in attribute selectionReinUsesLisp1-4/+0
This was a left over from OpenGL when disabled buffers where not properly emulated. We no longer have to assert this as it is checked in vertex buffer initialization.
2020-05-13time_zone: Use std::chrono::seconds for strong typing.bunnei3-4/+5
2020-05-12Frontend: Remove tracking for context wrapperJames Rowe1-8/+8
2020-05-12hid: Clear keyboard states & fix logic issueDavid Marcec1-3/+4
Previously we never cleared the states of the entries and the key would stay held down, also looping over the key bytes for each key lead to setting every bit for the key state instead of the key we wanted
2020-05-11hle: service: time_zone_manager: Use current time zone setting.bunnei2-3/+32
2020-05-11common: Add module to get the current time zone.bunnei3-0/+68
2020-05-11core: settings: Add a setting for time zone.bunnei8-10/+282
2020-05-11fix logic error & scale sample volume based on voice volumeDavid Marcec1-7/+9
2020-05-11pass by const ref insteadDavid Marcec1-8/+7
2020-05-11audio_renderer: Better voice mixing and 6 channel downmixingDavid Marcec3-11/+96
Supersedes #3738 and #3321
2020-05-11service: fsp_srv: Stub implementation of OpenMultiCommitManager.bunnei2-1/+38
2020-05-11yuzu: game_list: Fix 'Open Save Data Location' for device saves.bunnei4-27/+49
2020-05-11file_sys: savefata_factory: Update to support DeviceSaveData.bunnei1-3/+6
2020-05-11file_sys: control_metadata: Expose device_save_data_size.bunnei2-0/+5
2020-05-11Stub SendKeyboardLockKeyEventDavid Marcec2-1/+11
Needed for Puchikon 4 SmileBASIC 1.0.0
2020-05-10gl_shader_decompiler: Properly emulate NaN behaviour on NEReinUsesLisp1-0/+9
"Not equal" operators on GLSL seem to behave as unordered when we expect an ordered comparison. Manually emulate this checking for LGE values (numbers, not-NaNs).
2020-05-10RasterizerCache: Correct documentation.Fernando Sahmkow1-2/+2
2020-05-10VkPipelineCache: Use a null shader on invalid address.Fernando Sahmkow1-2/+1
2020-05-10VideoCore: Use SyncGuestMemory mechanism for Shader/Pipeline Cache invalidation.Fernando Sahmkow3-5/+61
2020-05-09shader_ir: Separate float-point comparisons in ordered and unorderedReinUsesLisp7-135/+163
This allows us to use native SPIR-V instructions without having to manually check for NAN.
2020-05-08Replace externals with Conan (#3735)James Rowe7-9/+10
* Remove git submodules that will be loaded through conan * Move custom Find modules to their own folder * Use conan for downloading missing external dependencies * CI: Change the yuzu source folder user to the user that the containers run on * Attempt to remove dirty mingw build hack * Install conan on the msvc build * Only set release build type when using not using multi config generator * Re-add qt bundled to workaround an issue with conan qt not downloading prebuilt binaries * Add workaround for submodules that use legacy CMAKE variables * Re-add USE_BUNDLED_QT on the msvc build bot
2020-05-06Menubar: fix mouse tracking bugFearlessTobi1-4/+0
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2020-05-05Update src/video_core/gpu.cppbunnei1-1/+1
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
2020-05-05Update src/video_core/gpu.cppbunnei1-1/+1
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
2020-05-05vk_sampler_cache: Use VK_EXT_custom_border_color when availableReinUsesLisp3-2/+44
This should fix grass interactions on Breath of the Wild on Vulkan. It is currently untested against validation layers. Nvidia's Windows 443.09 beta driver or Linux 440.66.12 is required for now.
2020-05-04vk_graphics_pipeline: Implement viewport swizzles with NV_viewport_swizzleReinUsesLisp8-0/+84
2020-05-04gl_rasterizer: Implement viewport swizzles with NV_viewport_swizzleReinUsesLisp2-0/+13
2020-05-04maxwell_3d: Add viewport swizzlesReinUsesLisp2-1/+24
2020-05-03kernel/memory: Remove #pragma once within cpp fileLioncash1-2/+0
This isn't necessary in a cpp file and will cause warnings on clang.
2020-05-03kernel/memory: Remove unused includesLioncash7-8/+1
Prevents header churn and needing to recompile these files if these headers are ever changed in the future.
2020-05-03kernel/memory: Remove unused variables in memory_block_managerLioncash1-3/+0
Prevents unused variable warnings.
2020-05-03kernel/memory: Make use of std::array consistently in address_space_infoLioncash1-6/+6
This allows tuning standard library implementations to enable or disable range checks at runtime, which is nicer for debugging.
2020-05-03kernel/memory: Resolve -Wshadow warningsLioncash1-4/+4
Prevents variable name clashing.
2020-05-03kernel/memory: Amend potential encoding warningsLioncash6-12/+12
While èis generally representable in some language encodings, in some it isn't and will result in compilation warnings occurring. To remain friendly with other language's codepages on Windows, we normalize it to an ASCII e.
2020-05-03hle_ipc: Eliminate core memory globalsLioncash3-10/+16
We can just pass the required instances into the constructor of the request, eliminating all usages of the global system accessor.
2020-05-03settings: Add anisotropic filtering level to the yuzu configuration log (#3875)Morph1-0/+1
2020-05-03Update src/core/hle/service/am/am.cppbunnei1-1/+1
Co-authored-by: Mat M. <mathew1800@gmail.com>
2020-05-02input_common: fix build when SDL2 is disabledFearlessTobi1-0/+6
2020-05-02readable_event: Remove unnecessary semicolon in Signal()Lioncash1-4/+6
Resolves a -Wextra-semi warning. While we're at it, we can invert the branch to form a guard clause, unindenting all of the contained code.
2020-05-02vk_graphics_pipeline: Implement rasterizer_enable on VulkanReinUsesLisp3-1/+3
We can simply enable rasterizer discard matching the current pipeline key.
2020-05-02fixed_pipeline_state: explicitly use template keyword after 1f345ebe3a55Jan Beich1-2/+4
In file included from src/video_core/renderer_opengl/renderer_opengl.cpp:25: In file included from src/./video_core/renderer_opengl/gl_rasterizer.h:26: In file included from src/./video_core/renderer_opengl/gl_fence_manager.h:11: src/./video_core/fence_manager.h:91:32: error: use 'template' keyword to treat 'Write' as a dependent template name memory_manager.Write<u32>(current_fence->GetAddress(), current_fence->GetPayload()); ^ template src/./video_core/fence_manager.h:137:32: error: use 'template' keyword to treat 'Write' as a dependent template name memory_manager.Write<u32>(current_fence->GetAddress(), current_fence->GetPayload()); ^ template
2020-05-01nvdrv: Fix GetGpuTime stack corruptionDavid Marcec1-2/+3
IoctlGetGpuTime should be 16 bytes, not 8.
2020-05-01am: IHomeMenuFunctions:GetPopFromGeneralChannelEventDavid Marcec3-4/+20
QLaunch 1.0.0
2020-04-30maxwell_to_vk: implement missing signed int formatsDan1-2/+14
2020-04-30caps:su Stub out SetShimLibraryVersionJason Parker2-1/+13
Used by Animal Crossing: New Horizons when trying to take a picture.
2020-04-30texture: Implement R8G8UIMorph8-38/+52
- Used by The Walking Dead: The Final Season
2020-04-30fs-srv: GetFreeSpaceSize & GetTotalSpaceSizeDavid Marcec1-2/+2
Closes #3533 Turns out the functions were already implemented but just never added
2020-04-30nim: CreateServerInterface, CreateAccessorInterface, CreateAsyncInterfaceDavid Marcec1-1/+69
Closes #3026
2020-04-30caps: Add missing service names to caps:suDavid Marcec1-0/+3
SetShimLibraryVersion, SaveScreenShotEx1 & SaveScreenShotEx2 were missing
2020-04-30am: GetFriendInvitationStorageChannelEventDavid Marcec2-1/+14
Closes #3829
2020-04-29psm: Mark as debug instead of warningDavid Marcec1-7/+14
No point to emulate battery life. However options are broken out if we ever want to add a setting for it
2020-04-29am: Properly implement GetDisplayVersionDavid Marcec1-3/+14
Properly implement IApplicationFunctions::GetDisplayVersion
2020-04-29am: IsVrModeEnabled & SetVrModeEnabled fixesDavid Marcec2-16/+6
Return the proper state of vr mode for IsVrModeEnabled We should not return an error for SetVrModeEnabled. When VR Mode is turned on, it signals to lbl to turn vr mode on, not return an error code
2020-04-29acc: Return a unique value per account for GetAccountIdDavid Marcec2-5/+13
2020-04-29acc: Fix InitializeApplicationInfoDavid Marcec2-22/+15
We're not suppose to pop a u64, should just read the sent pid and check that
2020-04-29kernel: Don't fail silentlyDavid Marcec7-0/+51
2020-04-29vulkan: Remove unnecessary includesLioncash31-59/+3
Reduces some header churn and reduces rebuilds when some header internals change. While we're at it we can also resolve a missing include in buffer_cache.
2020-04-29Don't fail silently for vi, sm, set and ns servicesDavid Marcec4-3/+27
2020-04-28shader/arithmetic_integer: Fix tracking issue in temporaryReinUsesLisp1-4/+0
This temporary is not needed as we mark Rd.CC + IADD.X as unimplemented. It caused issues when tracking global buffers.
2020-04-28Clang Format and Documentation.Fernando Sahmkow10-10/+20
2020-04-28MaxwellDMA: Optimize micro copies.Fernando Sahmkow3-0/+57
2020-04-28kernel: Bad GetInfo ids should not be marked as stubsDavid Marcec1-2/+2
As we currently match hardware and don't return a successful result, these should be marked as errors instead of warnings and as stubs.
2020-04-28Updated comment to reflect ListQualifiedUsers betterDavid Marcec1-1/+3
2020-04-28style: Change AMs & Glues error codes to be dec instead of hexDavid Marcec2-7/+7
Consistency for the rest of the error codes in the codebase
2020-04-28marked stubsDavid Marcec1-4/+5
2020-04-28account: ListQualifiedUsersDavid Marcec5-3/+13
Closes #2844
2020-04-28Audin:u ListAudioIns, OpenAudioIn, ListAudioInsAuto, OpenAudioInAuto, ListAudioInsAutoFiltered, OpenAudioInProtocolSpecifiedDavid Marcec2-5/+93
Closes #2874
2020-04-28vk_rasterizer: Skip index buffer setup when vertices are zeroReinUsesLisp1-0/+3
Xenoblade 2 invokes a draw call with zero vertices. This is likely due to indirect drawing (glDrawArraysIndirect). This causes a crash in the staging buffer pool when trying to create a buffer with a size of zero. To workaround this, skip index buffer setup entirely when the number of indices is zero.
2020-04-28{maxwell_3d,buffer_cache}: Implement memory barriers using 3D registersReinUsesLisp13-16/+57
Drop MemoryBarrier from the buffer cache and use Maxwell3D's register WaitForIdle. To implement this on OpenGL we just call glMemoryBarrier with the necessary bits. Vulkan lacks this synchronization primitive, so we set an event and immediately wait for it. This is not a pretty solution, but it's what Vulkan can do without submitting the current command buffer to the queue (which ends up being more expensive on the CPU).
2020-04-28VideoCore/GPU: Delegate subchannel engines to the dma pusher.Fernando Sahmkow3-4/+49
2020-04-28VideoCore/Engines: Refactor Engines CallMethod.Fernando Sahmkow13-62/+82
2020-04-28maxwell_3d: Fix depth clamping registerReinUsesLisp5-8/+5
Using deko3d as reference: https://github.com/devkitPro/deko3d/blob/4e47ba0013552e592a86ab7a2510d1e7dadf236a/source/maxwell/gpu_3d_state.cpp#L42 We were using bits 3 and 4 to determine depth clamping, but these are the same both enabled and disabled: state->depthClampEnable ? 0x101A : 0x181D The same happens on Nvidia's OpenGL driver, where they do something like this (default capabilities, GL 4.5 compatibility): (state & DEPTH_CLAMP) != 0 ? 0x201a : 0x281c There's always a difference between the first bits in this register, but bit 11 is consistently disabled on both deko3d/NVN and OpenGL. This commit changes yuzu's behaviour to use bit 11 to determine depth clamping. - Fixes depth issues on Super Mario Odyssey's intro.
2020-04-27texture_cache: Reintroduce preserve_contents accuratelyReinUsesLisp4-41/+81
This reverts commit 94b0e2e5dae4e0bd0021ac2d8fe1ff904a93ee69. preserve_contents proved to be a meaningful optimization. This commit reintroduces it but properly implemented on OpenGL. We have to make sure the clear removes all the previous contents of the image. It's not currently implemented on Vulkan because we can do smart things there that's preferred to be introduced in a separate commit.
2020-04-26shader/memory_util: Deduplicate codeReinUsesLisp9-159/+153
Deduplicate code shared between vk_pipeline_cache and gl_shader_cache as well as shader decoder code. While we are at it, fix a bug in gl_shader_cache where compute shaders had an start offset of a stage shader.
2020-04-26shader/arithmetic_integer: Fix edge case and mark IADD.X Rd.CC as unimplementedReinUsesLisp1-1/+6
IADD.X Rd.CC requires some extra logic that is not currently implemented. Abort when this is hit.
2020-04-26shader/arithmetic_integer: Change IAdd to UAdd to avoid signed overflowReinUsesLisp1-2/+2
Signed integer addition overflow might be undefined behavior. It's free to change operations to UAdd and use unsigned integers to avoid potential bugs.
2020-04-26shader/arithmetic_integer: Implement IADD.XReinUsesLisp2-0/+10
IADD.X takes the carry flag and adds it to the result. This is generally used to emulate 64-bit operations with 32-bit registers.
2020-04-26shader/arithmetic_integer: Implement CC for IADDReinUsesLisp4-3/+42
2020-04-26decode/register_set_predicate: Implement CCReinUsesLisp1-9/+14
P2R CC takes the state of condition codes and puts them into a register. We already have this implemented for PR (predicates). This commit implements CC over that.
2020-04-26decode/register_set_predicate: Use move for shared pointersReinUsesLisp1-16/+17
Avoid atomic counters used by shared pointers.
2020-04-26services: hid: Stub StopSevenSixAxisSensor.M&M2-1/+13
- Used by The Legend of Zelda: Breath of the Wild v1.6.0
2020-04-25Fix the mistake in the port and update the comment for clarityVitor Kiguchi1-7/+7
2020-04-25vk_rasterizer: Pack texceptions and color formats on invalid formatsReinUsesLisp2-5/+19
Sometimes for unknown reasons NVN games can bind a render target format of 0. This may be a yuzu bug. With the commits before this the formats were specified without being "packed", assuming all formats and texceptions will be written like in the color_attachments vector. To address this issue, iterate all render targets and pack them as they are valid. This way they will match color_attachments. - Fixes validation errors and graphical issues on Breath of the Wild.
2020-04-24Add Restore Defaults and Clear options to hotkeysKewlan5-18/+116
2020-04-24Revert: shader_decode: Fix LD, LDG when track constant buffer.Fernando Sahmkow1-14/+6
2020-04-24Fix -Wdeprecated-copy warning.Markus Wick1-0/+1
2020-04-24Fix -Werror=conversion error.Markus Wick2-2/+2
2020-04-24vi: Don't let uninitialized data pass as a response for SetBufferCountDavid Marcec1-1/+9
Currently SetBufferCount doesn't write to the out buffer which then contains uninitialized data. This leads to non-zero data which leads to responding with different error codes
2020-04-24physical_core: Make use of std::make_unique instead of std::make_shared in ctorLioncash4-8/+15
We can also allow unicorn to be constructed in 32-bit mode or 64-bit mode to satisfy the need for both interpreter instances. Allows this code to compile successfully of non x86-64 architectures.
2020-04-24shared_memory: Amend doxygen referenceLioncash2-5/+5
Amends the parameter to match the documentation reference. Resolves a -Wdocumentation warning with clang.
2020-04-24svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemoryLioncash1-2/+138
These were lost in the re-implementation of the virtual memory manager.
2020-04-23svc: Remove unused variableLioncash1-3/+0
Since the VMM refactor, this is no longer used or needed.
2020-04-23page_table: Remove unused capturesLioncash1-2/+2
Any time the lambda function is called, the permission being used in the capture would be passed in as an argument to the lambda, so the capture is unnecessary.
2020-04-23decode/arithmetic_half: Fix HADD2 and HMUL2 absolute and negation bitsReinUsesLisp2-16/+37
The encoding for negation and absolute value was wrong. Extracting is now done manually. Similar instructions having different encodings is the rule, not the exception. To keep sanity and readability I preferred to extract the desired bit manually. This is implemented against nxas: https://github.com/ReinUsesLisp/nxas/blob/8dbc38995711cc12206aa370145a3a02665fd989/table.h#L68 That is itself tested against nvdisasm (Nvidia's official disassembler).
2020-04-23shader/texture: Support multiple unknown sampler propertiesReinUsesLisp2-62/+87
This allows deducing some properties from the texture instruction before asking the runtime. By doing this we can handle type mismatches in some instructions from the renderer instead of the shader decoder. Fixes texelFetch issues with games using 2D texture instructions on a 1D sampler.
2020-04-23shader_ir: Turn classes into data structuresReinUsesLisp13-299/+197
2020-04-23vk_rasterizer: Fix framebuffer creation validation errorsReinUsesLisp1-2/+4
Framebuffer creation was ignoring the number of color attachments.
2020-04-23vk_pipeline_cache: Unify pipeline cache keys into a single operationReinUsesLisp5-47/+59
This allows us to call Common::CityHash and std::memcmp only once for GraphicsPipelineCacheKey. While we are at it, do the same for compute.
2020-04-23vk_renderpass_cache: Pack renderpass cache key to 12 bytesReinUsesLisp4-84/+59
2020-04-23kernel: memory: Improve implementation of device shared memory. (#3707)bunnei6-16/+110
* kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory.
2020-04-23Clang Format.Fernando Sahmkow6-11/+19
2020-04-23GPU: Add Fast GPU Time Option.Fernando Sahmkow7-1/+21
2020-04-23Maxwell3D: Process Macros on MultiMethod.Fernando Sahmkow1-25/+47
2020-04-23DMAPusher: Propagate multimethod writes into the engines.Fernando Sahmkow14-14/+164
2020-04-23Update src/yuzu/main.cpp with missing constBen Russell1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2020-04-23Dump RomFS command to include UpdatesBen Russell1-1/+3
Patch the RomFS with the selected updates before dumping. Previously the resulting RomFS only contained data from the original title. To dump the RomFS without updates the user can disable the update under Properties before choosing Dump RomFS.
2020-04-23Edit modifier_scale with the deadzone sliderKewlan3-30/+52
2020-04-23Fix format error in performance statisticsH27CK1-3/+4
Formatting
2020-04-23vk_pipeline_cache: Fix unintentional memcpy into optionalReinUsesLisp1-2/+4
The intention behind this was to assign a float to from an uint32_t, but it was unintentionally being copied directly into the std::optional. Copy to a temporary and assign that temporary to std::optional. This can be replaced with std::bit_cast<float> once we are in C++20.
2020-04-23GL_Fence_Manager: use GL_TIMEOUT_IGNORED instead of a loop,Fernando Sahmkow1-2/+1
2020-04-22Add missing ;H27CK1-1/+1
2020-04-22Address Feedback.Fernando Sahmkow3-24/+18
2020-04-22Async GPU: Correct flushing behavior to be similar to old async GPU behavior.Fernando Sahmkow3-0/+11
2020-04-22MaxwellDMA: Correct copying on accuracy level.Fernando Sahmkow1-2/+7
2020-04-22ShaderCache/PipelineCache: Cache null shaders.Fernando Sahmkow4-8/+31
2020-04-22Address Feedback.Fernando Sahmkow13-132/+117
2020-04-22Fix GCC error.Fernando Sahmkow2-6/+5
2020-04-22Correct Linux Compile Error.Fernando Sahmkow2-7/+10
2020-04-22Clang format.Fernando Sahmkow1-1/+2
2020-04-22QueryCache: Only do async flushes on async gpu.Fernando Sahmkow1-1/+4
2020-04-22Async GPU: Only do reactive flushing on Extreme Level.Fernando Sahmkow1-1/+1
2020-04-22vk_fence_manager: Initial implementationReinUsesLisp8-12/+222
2020-04-22QueryCache: Implement Async Flushes.Fernando Sahmkow5-12/+77
2020-04-22OpenGL: Guarantee writes to Buffers.Fernando Sahmkow3-4/+2
2020-04-22GPU: Implement Flush Requests for Async mode.Fernando Sahmkow6-8/+70
2020-04-22FenceManager: Manage syncpoints and rename fences to semaphores.Fernando Sahmkow11-25/+123
2020-04-22BufferCache: Refactor async managing.Fernando Sahmkow2-10/+27
2020-04-22FenceManager: Implement async buffer cache flushes on High settingsFernando Sahmkow6-10/+69
2020-04-22Rasterizer: Document SignalFence & ReleaseFences and setup skeletons on Vulkan.Fernando Sahmkow5-4/+35
2020-04-22GPU: Fix rebase errors.Fernando Sahmkow2-4/+4
2020-04-22Rasterizer: Disable fence managing in synchronous gpu.Fernando Sahmkow2-1/+11
2020-04-22ThreadManager: Sync async reads on accurate gpu.Fernando Sahmkow9-8/+48
2020-04-22FenceManager: Implement should wait.Fernando Sahmkow2-2/+17
2020-04-22GPU: Implement a Fence Manager.Fernando Sahmkow6-23/+208
2020-04-22OpenGL: Implement Fencing backend.Fernando Sahmkow12-19/+94
2020-04-22TextureCache: Flush linear textures after finishing rendering.Fernando Sahmkow1-2/+8
2020-04-22GPU: Delay Fences.Fernando Sahmkow6-2/+20
2020-04-22BufferCache: Implement OnCPUWrite and SyncGuestHostFernando Sahmkow6-7/+67
2020-04-22GPU: Refactor synchronization on Async GPUFernando Sahmkow11-7/+56
2020-04-22Texture Cache: Implement OnCPUWrite and SyncGuestHostFernando Sahmkow2-3/+63
2020-04-22UI: Replasce accurate GPU option for GPU Accuracy LevelFernando Sahmkow12-28/+77
2020-04-22Add a trailing separator to the string pathMorph1-1/+1
Fixes #3643
2020-04-22Init SDL info structure and add dummy contextH27CK2-1/+4
2020-04-22vk_memory_manager: Remove unified memory model flagReinUsesLisp5-35/+6
All drivers (even Intel) seem to have a device local memory type that is not host visible. Remove this flag so all devices follow the same path. This fixes a crash when trying to map to host device local memory on integrated devices.
2020-04-22vk_rasterizer: Add lazy default buffer maker and use it for empty buffersReinUsesLisp3-4/+40
Introduce a default buffer getter that lazily constructs an empty buffer. This is intended to match OpenGL's buffer 0. Use this for disabled vertex and uniform buffers. While we are at it, include vertex buffer usages for staging buffers to silence validation errors.
2020-04-22gl_rasterizer: Fix buffers without sizeReinUsesLisp3-8/+13
On NVN buffers can be enabled but have no size. According to deko3d and the behavior we see in Animal Crossing: New Horizons these buffers get the special address of 0x1000 and limit themselves to 0xfff. Implement buffers without a size by binding a null buffer to OpenGL without a side. https://github.com/devkitPro/deko3d/blob/1d1930beea093b5a663419e93b0649719a3ca5da/source/maxwell/gpu_3d_vbo.cpp#L62-L63
2020-04-21audio_renderer: Preliminary BehaviorInfo (#3736)David7-13/+249
* audio_renderer: Preliminary BehaviorInfo * clang format * Fixed IsRevisionSupported * fixed IsValidRevision * Fixed logic error & spelling errors & crash * Addressed issues
2020-04-21shader/arithmetic_integer: Fix LEA_IMM encodingReinUsesLisp1-2/+2
The operand order in LEA_IMM was flipped compared to nvdisasm. Fix that using nxas as reference: https://github.com/ReinUsesLisp/nxas/blob/8dbc38995711cc12206aa370145a3a02665fd989/table.h#L122
2020-04-21loader: nro: Fix process initialization using ProgramMetadata default.bunnei2-11/+14
2020-04-21loader: elf: Fix process initialization using ProgramMetadata default.bunnei1-0/+5
2020-04-21file_sys: program_metadata: Add a helper function for generating reasonable default metadata.bunnei2-1/+16
- We need this for homebrew process initialization.
2020-04-20service: Update function tablesLioncash19-7/+108
Keeps the service function tables up to date. Updated based off information on SwitchBrew.
2020-04-20npad: Lower log level for VibrateController to DebugFearlessTobi1-1/+1
2020-04-20audren: Lower log level for RequestUpdateImpl to DebugFearlessTobi1-1/+1
2020-04-20dynarmic: Add option to disable CPU JIT optimizationsMerryMage7-2/+26
2020-04-20yuzu: Option to hide mouse on inactivityFearlessTobi7-0/+78
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2020-04-20Initialize quad_indexed_pass before uint8_passAmit Prakash Ambasta1-1/+1
Fixes Werror=reorder in gcc
2020-04-19service/time: Remove reliance on the global system accessorLioncash1-24/+26
Eliminates usages of the global system accessor and instead passes the existing system instance into the interfaces.
2020-04-19dma_pusher: Remove reliance on the global system instanceLioncash3-6/+11
With this, the video core is now has no calls to the global system instance at all.
2020-04-19thread: FPCR.FZ is likely not 1MerryMage1-2/+1
2020-04-19core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page.bunnei1-0/+11
2020-04-19renderer_vulkan: assume X11 if not Windows/macOS after bf1d66b7c074Jan Beich1-3/+3
Render.Vulkan <Error> video_core/renderer_vulkan/renderer_vulkan.cpp:CreateInstance:131: Presentation not supported on this platform Render.Vulkan <Error> video_core/renderer_vulkan/renderer_vulkan.cpp:CreateSurface:378: Presentation not supported on this platform Core <Critical> core/core.cpp:Load:199: Failed to initialize system (Error 5)!
2020-04-19vulkan/wrapper: Sort physical devicesReinUsesLisp1-1/+20
Sort discrete GPUs over the rest, Nvidia over AMD, AMD over Intel, Intel over the rest. This gives us a somewhat consistent order when Optimus is removed (renderdoc does this when it's attached). This can break the configuration of users with an Intel GPU that manually remove Optimus on yuzu. That said, it's a very unlikely to happen.
2020-04-19fixed_pipeline_state: Hash and compare the whole structureReinUsesLisp2-105/+9
Pad FixedPipelineState's size to 384 bytes to be a multiple of 16. Compare the whole struct with std::memcmp and hash with CityHash. Using CityHash instead of a naive hash should reduce the number of collisions. Improve used type traits to ensure this operation is safe. With these changes the improvements to the hashable pipeline state are: Optimized structure Hash: 89 ns Comparison: 103 ns Construction*: 164 ns Struct size: 384 bytes Original structure Hash: 148 ns Equal: 174 ns Construction*: 281 ns Size: 1384 bytes * Attribute state initialization is not measured These measures are averages taken with std::chrono::high_accuracy_clock on MSVC shipped on Visual Studio 16.6.0 Preview 2.1.
2020-04-19fixed_pipeline_state: Pack blending stateReinUsesLisp3-98/+227
Reduce FixedPipelineState's size to 364 bytes.
2020-04-19fixed_pipeline_state: Pack rasterizer stateReinUsesLisp4-163/+155
Reduce FixedPipelineState's size to 600 bytes.
2020-04-19fixed_pipeline_state: Pack depth stencil stateReinUsesLisp3-97/+140
Reduce FixedPipelineState's size to 632 bytes.
2020-04-19fixed_pipeline_state: Pack attribute stateReinUsesLisp6-101/+85
Reduce FixedPipelineState's size from 1384 to 664 bytes
2020-04-18video_core: gl_shader_decompiler: Fix implicit fallthrough errors.bunnei1-0/+1
2020-04-18service: hid: npad: Fix implicit fallthrough errors.bunnei1-0/+2
2020-04-18gl_shader_decompiler: Avoid copies where applicableLioncash1-3/+3
Avoids unnecessary reference count increments where applicable and also avoids reallocating a vector. Unlikely to make a huge difference, but given how trivial of an amendment it is, why not?
2020-04-18time/system_clock_core: Remove unnecessary initializerLioncash1-1/+1
This is already initialized within the class body.
2020-04-18service/time: Mark IsStandardNetworkSystemClockAccuracySufficient as constLioncash1-1/+1
This doesn't modify internal member state.
2020-04-18service/time: Add virtual destructors where applicableLioncash3-2/+3
Many of these implementations are used to implement a polymorphic interface. While not directly used polymorphically, this prevents virtual destruction from ever becoming an issue.
2020-04-18service: Remove unused RequestParser instancesLioncash2-3/+0
These aren't used, so they should be removed to reduce compilation warnings.
2020-04-18memory/slab_heap: Make use of static_cast over reinterpret_castLioncash1-2/+2
Casting from void* with static_cast is permitted by the standard, so we can just make use of that instead.
2020-04-18loader/nso: Resolve moves not occurring in DecompressSegmentLioncash1-1/+1
Given the std::vector was const, an automatic move out of the function could not occur. We can allow automatic return value optimizations to occur by making the buffer non-const.
2020-04-18am: Resolve ineffective movesLioncash1-2/+2
Previously const objects were being std::moved, which results in no move actually occurring. This resolves that.
2020-04-17video_code: Fix implicit switch fallthrough.Markus Wick1-0/+2
Since yesterday, this breaks the build on linux. So let's fix it.
2020-04-17vk_stream_buffer: Fix out of memory on boot on recent Nvidia driversReinUsesLisp2-33/+48
Nvidia recently introduced a new memory type for data streaming (awesome!), but yuzu was assuming that all heaps had enough memory for the assumed stream buffer size (256 MiB). This worked fine on AMD but Nvidia's new memory heap was smaller than 256 MiB. This commit changes this assumption and allocates a bit less than the size of the preferred heap, with a maximum of 256 MiB (to avoid allocating all system memory on integrated devices). - Fixes a crash on NVIDIA 450.82.0.0
2020-04-17Revert "gl_shader_cache: Use CompileDepth::FullDecompile on GLSL"Rodrigo Locatti1-3/+1
2020-04-17core: hle: Address various feedback & code cleanup.bunnei11-251/+153
- Should be no functional changes.
2020-04-17core: device_memory: Remove incorrect usage of constexpr.bunnei1-2/+6
2020-04-17memory: Add copyright notice for Atmosphere where applicable.bunnei6-0/+18
2020-04-17kernel: Remove old VMManager class.bunnei3-1973/+0
2020-04-17loader: nso: Fix loader size and arguments.bunnei3-25/+47
2020-04-17loader: elf/kip/nro: Updates for new VMM.bunnei3-5/+7
2020-04-17service: ldr: Updates for new VMM.bunnei1-150/+215
- Includes removing some service impls. that are untested.
2020-04-17kernel: memory: page_table: Simplify GetPhysicalAddr impl.bunnei4-19/+6
2020-04-17kernel: svc: Updates for new VMM.bunnei1-488/+116
- Includes removing some SVC impls. that are untested.
2020-04-17core: memory: Fix memory access on page boundaries.bunnei1-6/+39
- Fixes Super Smash Bros. Ultimate.
2020-04-17video_core: memory_manager: Updates for Common::PageTable changes.bunnei2-67/+34
2020-04-17core: memory: Updates for new VMM.bunnei2-114/+53
2020-04-17common: page_table: Update to use VirtualBuffer and simplify.bunnei2-53/+18
2020-04-17core: gdbstub: Updates for new VMM.bunnei1-2/+2
2020-04-17core: reporter: Updates for new VMM.bunnei1-3/+5
2020-04-17memory: cheat_engine: Updates for new VMM.bunnei1-5/+8
2020-04-17arm_test_common: Updates for new VMM.bunnei1-6/+2
2020-04-17kernel: process: Updates for new VMM.bunnei2-79/+151
2020-04-17service: pl_u: Update for new shared memory layout.bunnei1-7/+5
2020-04-17service: time: Update for new shared memory layout.bunnei1-3/+2
2020-04-17service: hid: Update for new shared memory layout.bunnei1-3/+2
2020-04-17service: irs: Update for new shared memory layout.bunnei1-3/+3
2020-04-17kernel: resource_limit: Reserve physical memory.bunnei1-1/+6
2020-04-17kernel: Initialize memory layout for new VMM.bunnei2-0/+159
2020-04-17core: system: Rename GetDeviceManager -> DeviceManager.bunnei3-7/+7
- More consistent with other system components.
2020-04-17kernel: transfer_memory: Refactor for new VMM.bunnei2-130/+16
2020-04-17core: Construct/Destruct DeviceMemory on Init/Shutdown.bunnei1-4/+7
2020-04-17kernel: shared_memory: Refactor for new VMM.bunnei2-220/+58
2020-04-17core: device_memory: Update to use VirtualBuffer class.bunnei2-39/+12
2020-04-17common: Add VirtualBuffer class, to abstract memory virtualization.bunnei3-0/+112
2020-04-17kernel: errors: Add ERR_OUT_OF_RESOURCES.bunnei1-0/+1
2020-04-17kernel: process_capability: Update to use Memory::PageTable.bunnei2-23/+25
2020-04-17kernel: memory: Add PageTable class, to manage process address space.bunnei3-0/+1510
2020-04-17kernel: memory: Add MemoryLayout class, to build physical memory layout.bunnei2-0/+74
2020-04-17kernel: memory: Add MemoryManager class, to manage page heaps.bunnei3-0/+276
2020-04-17kernel: memory: Add MemoryBlockManager class, to manage memory blocks.bunnei3-0/+256
2020-04-17kernel: memory: Add PageHeap class, to manage a heap of pages.bunnei3-0/+483
2020-04-17kernel: memory: Add PageLinkedList class, to manage a list of pages.bunnei2-0/+94
2020-04-17kernel: memory: Add system_control code, which will be used for ASLR support.bunnei3-0/+61
2020-04-17physical_memory: Add missing include for <vector>.bunnei1-0/+2
2020-04-17kernel: memory: Add MemoryBlock class, for managing memory blocks and their state.bunnei2-0/+316
2020-04-17kernel: memory: Add memory_types.h, for things that are commonly used in memory code.bunnei2-0/+19
2020-04-17kernel: memory: Add SlabHeap class, for managing memory heaps.bunnei2-0/+162
- This will be used for TLS pages, among other things.
2020-04-17kernel: memory: Add AddressSpaceInfo class, for managing the memory address space.bunnei3-0/+166
2020-04-17core: device_manager: Add a simple class to manage device RAM.bunnei5-1/+118
2020-04-17dynarmic: Enable strict alignment checks.bunnei1-1/+4
- Also add a missing include.
2020-04-17common: scope_exit: Implement mechanism for canceling a scope exit.bunnei1-1/+8
2020-04-17core: memory: Move to Core::Memory namespace.bunnei37-98/+100
- helpful to disambiguate Kernel::Memory namespace.
2020-04-17common: alignment: Add a helper function for generic alignment checking.bunnei1-0/+7
2020-04-17core: kernel: Add svc_types header to include SVC-specific types.bunnei3-0/+70
2020-04-17core: kernel: Move SVC to its own namesapce.bunnei5-9/+9
2020-04-17kernel: resource_limit: Improvements to implementation.bunnei2-12/+50
2020-04-17loader: nso: Fix loading of static objects to be properly sized and aligned.bunnei1-19/+9
2020-04-17common: common_funcs: Add a macro for defining enum flag operators.bunnei1-0/+32
2020-04-17process: SetupMainThread: Zero out argument on process start.bunnei1-0/+2
2020-04-17arm_interface: Ensure ThreadContext is zero'd out.bunnei1-16/+16
2020-04-17CMakeLists: Make missing declarations a compile-time errorLioncash1-0/+1
Ensures that our code always has its linkage explicit.
2020-04-17General: Resolve warnings related to missing declarationsLioncash9-24/+25
2020-04-17gdbstub: Fix some gdbstub jankinessMerryMage1-4/+3
1. Ensure that register information available to gdbstub is most up-to-date. 2. There's no reason to check for current_thread == thread when emitting a trap. Doing this results in random hangs whenever a step happens upon a thread switch.
2020-04-17key_manager: Resolve missing field initializer warningLioncash1-1/+2
2020-04-17decode/memory: Resolve unused variable warningLioncash1-1/+1
Only the first element of the returned pair is ever used.
2020-04-17decode/texture: Resolve unused variable warnings.Lioncash1-5/+7
Some variables aren't used, so we can remove these. Unfortunately, diagnostics are still reported on structured bindings even when annotated with [[maybe_unused]], so we need to unpack the elements that we want to use manually.
2020-04-17decode/texture: Collapse loop down into std::generateLioncash1-3/+1
Same behavior, less code.
2020-04-17decode/texture: Eliminate trivial missing field initializer warningsLioncash1-3/+4
We can just specify the initializers.
2020-04-17time_zone_manager: Resolve sign conversion warningsLioncash1-2/+2
ttis and ats will never exceed the length of INT32_MAX in our case, so this is safe.
2020-04-17CMakeLists: Enable -Wmissing-declarations on Linux buildsLioncash1-0/+1
Allows catching cases where internal linkage isn't specified for helper functions when they should be marked as such.
2020-04-17hle_ipc: Remove std::size_t casts where applicableLioncash2-21/+23
These were added in the change that enabled -Wextra on linux builds so as not to introduce interface changes in the same change as a build-system flag addition. Now that the flags are enabled, we can freely change the interface to make these unnecessary.
2020-04-17maxwell_3d: Initialize format attributes constant as oneReinUsesLisp1-0/+4
nouveau expects this to be true but it doesn't set it.
2020-04-17vk_compute_pass: Implement indexed quadsReinUsesLisp5-12/+280
Implement indexed quads (GL_QUADS used with glDrawElements*) with a compute pass conversion. The compute shader converts from uint8/uint16/uint32 indices to uint32. The format is passed through push constants to avoid having different variants of the same shader. - Used by Fast RMX - Used by Xenoblade Chronicles 2 (it still has graphical due to synchronization issues on Vulkan)
2020-04-16externals: Move LibreSSL linking to httplib.Markus Wick2-11/+3
Neither core nor web_services use OpenSSL nor LibreSSL. However they need to link them as it's a requirement of httplib. So let's declare this within httplib instead of core and web_services.
2020-04-16input_common: Use the CMake target instead of the variable.Markus Wick1-1/+1
2020-04-16buffer_cache: Return handles instead of pointer to handlesReinUsesLisp14-228/+90
The original idea of returning pointers is that handles can be moved. The problem is that the implementation didn't take that in mind and made everything harder to work with. This commit drops pointer to handles and returns the handles themselves. While it is still true that handles can be invalidated, this way we get an old handle instead of a dangling pointer. This problem can be solved in the future with sparse buffers.
2020-04-16decode/shift: Remove unused variable within Shift()Lioncash1-1/+0
Removes a redundant variable that is already satisfied by the IsFull() utility function.
2020-04-16surface_view: Add missing operator!= to ViewParamsLioncash2-0/+5
Provides logical symmetry to the interface.
2020-04-16surface_base: Make IsInside() a const member functionLioncash1-2/+2
This doesn't modify internal state, so this can be made const.
2020-04-16texture_cache/format_lookup_table: Fix incorrect green, blue, and alpha indicesLioncash1-3/+3
Previously these were all using the red component to derive the indices, which is definitely not intentional.
2020-04-16control_flow: Make use of std::move in TryInspectAddress()Lioncash1-3/+3
Eliminates redundant atomic reference count increments and decrements.
2020-04-16video_core: Amend doxygen comment referencesLioncash2-5/+5
Fixes broken documentation references.
2020-04-16decode/image: Fix typo in assert in GetComponentSize()Lioncash1-3/+3
2020-04-16gl_query_cache: Resolve use-after-move in CachedQuery move assignment operatorLioncash1-1/+1
Avoids potential invalid junk data from being read.
2020-04-16decoder/image: Fix incorrect G24R8 component sizes in GetComponentSize()Lioncash1-2/+2
The components' sizes were mismatched. This corrects that.
2020-04-16gl_device: Mark stage_swizzle as constexprLioncash1-1/+1
Previously this was mutable even though it shouldn't be.
2020-04-16track: Eliminate redundant copiesLioncash1-5/+6
Two variables can be references, while two others can be std::moved. Makes for 4 less atomic reference count increments and decrements.
2020-04-16CMakeLists: Specify -Wextra on linux buildsLioncash26-70/+93
Allows reporting more cases where logic errors may exist, such as implicit fallthrough cases, etc. We currently ignore unused parameters, since we currently have many cases where this is intentional (virtual interfaces). While we're at it, we can also tidy up any existing code that causes warnings. This also uncovered a few bugs as well.
2020-04-15file_util: Early-exit in WriteArray and ReadArray if specified lengths are zeroLioncash2-9/+33
It's undefined behavior to pass a null pointer to std::fread and std::fwrite, even if the length passed in is zero, so we must perform the precondition checking ourselves. A common case where this can occur is when passing in the data of an empty std::vector and size, as an empty vector will typically have a null internal buffer. While we're at it, we can move the implementation out of line and add debug checks against passing in nullptr to std::fread and std::fwrite.
2020-04-15CMakeLists: Make -Wreorder a compile-time errorLioncash4-5/+7
This can result in silent logic bugs within code, and given the amount of times these kind of warnings are caused, they should be flagged at compile-time so no new code is submitted with them.
2020-04-15kernel/thread: Resolve -Wswitch warningsLioncash1-0/+2
2020-04-15Texture Cache: Read current data when flushing a 3D segment.Fernando Sahmkow1-0/+6
This PR corrects flushing of 3D segments when data of other segments is mixed, this aims to preserve the data in place.
2020-04-15maxwell_to_vk: Add uint16 vertex formatsReinUsesLisp1-0/+8
2020-04-15maxwell_to_vk: Add missing breaksReinUsesLisp1-0/+2
Avoid invalid fallbacks.
2020-04-15vk_blit_screen: Initialize all members in VkPipelineViewportStateCreateInfoReinUsesLisp1-0/+2
When the dynamic state is specified, pViewports and pScissors are ignored, quoting the specification: pViewports is a pointer to an array of VkViewport structures, defining the viewport transforms. If the viewport state is dynamic, this member is ignored. That said, AMD's proprietary driver itself seem to read it regardless of what the specification says.
2020-04-15Texture Cache: Only do buffer copies on accurate GPU. (#3634)Fernando Sahmkow1-1/+3
This is a simple optimization as Buffer Copies are mostly used for texture recycling. They are, however, useful when games abuse undefined behavior but most 3D APIs forbid it.
2020-04-15service: time: Implement CalculateStandardUserSystemClockDifferenceByUser.bunnei3-1/+25
- Used by Animal Crossing: New Horizons.
2020-04-15Revert "gl_shader_decompiler: Implement merges with bitfieldInsert"ReinUsesLisp1-2/+4
This reverts commit 05cf27083608bebd3ee4c38f2f948c8f2030f881. Apparently the first approach using floats instead of bitfieldInert worked better for Fire Emblem: Three Houses. Reverting to get that behavior back.
2020-04-15shader/arithmetic: Add FCMP_CR variantReinUsesLisp2-3/+6
Adds another variant of FCMP.
2020-04-14gl_rasterizer: Implement constant vertex attributesReinUsesLisp2-2/+6
Credits go to gdkchan from Ryujinx for finding constant attributes are used in retail games.
2020-04-14file_sys: patch_manager: Return early when there are no layers to apply.bunnei1-0/+6
2020-04-14service: friend: Stub IFriendService::GetBlockedUserListIds.bunnei1-1/+10
- This is safe to stub, as there should be no adverse consequences from reporting no blocked users.
2020-04-14vk_rasterizer: Default to 1 viewports with a size of 0ReinUsesLisp1-3/+6
Silence validation layer errors.
2020-04-14gl_shader_cache: Use CompileDepth::FullDecompile on GLSLReinUsesLisp1-1/+3
From my testing on a Splatoon 2 shader that takes 3800ms on average to compile changing to FullDecompile reduces it to 900ms on average. The shader decoder will automatically fallback to a more naive method if it can't use full decompile.
2020-04-14renderer_vulkan: Integrate Nvidia Nsight Aftermath on WindowsReinUsesLisp9-22/+360
Adds optional support for Nsight Aftermath. It is enabled through ENABLE_NSIGHT_AFTERMATH in cmake. A path to the SDK has to be provided by the environment variable NSIGHT_AFTERMATH_SDK. Nsight Aftermath allows an application to generate "minidumps" of the GPU state when a device loss happens. By analysing these on Nsight we can know what a game was doing and why it triggered a device loss. The dump is generated inside %APPDATA%\yuzu\log\gpucrash and this directory is deleted every time a new instance is initialized with Nsight enabled. To enable it on yuzu there has a to be a driver and device capable of running Nsight Aftermath on Vulkan. That means only Turing based GPUs on the latest stable driver, beta drivers won't work for now. It is manually enabled in Configuration>Debug>Enable Graphics Debugging because when using all debugging capabilities there is a runtime cost.
2020-04-14yuzu/main: Add better popup texts and remove duplicated actionsFearlessTobi3-64/+18
Makes popup texts more compact and clear and also links our quickstart guide now. Also removes OnMenuSelectEmulatedDirectory from the File dropdown, as the action already exists in the Filesystem tab and provides better visual feedback there.
2020-04-13gl_texture_cache: Fix layered texture attachment base levelReinUsesLisp1-1/+1
The base level is already included in the texture view. If we specify the base level in the texture again, this will end up in the incorrect level and potentially out of bounds.
2020-04-13renderer_vulkan: Remove Nvidia checkpointsReinUsesLisp4-34/+0
2020-04-13renderer_vulkan: Catch device losses in more placesReinUsesLisp3-21/+29
2020-04-13gl_rasterizer: Implement line widths and smooth linesReinUsesLisp5-2/+33
Implements "legacy" features from OpenGL present on hardware such as smooth lines and line width.
2020-04-13gl_shader_decompiler: Implement merges with bitfieldInsertReinUsesLisp1-4/+2
This also fixes Turing issues but it avoids doing more bitcasts. This should improve the generated code while also avoiding more points where compilers can flush floats.
2020-04-12gl_shader_decompiler: Improve generated code in HMergeH*ReinUsesLisp1-6/+8
Avoiding bitwise expressions, this fixes Turing issues in shaders using half float merges that affected several games.
2020-04-12shader/video: Partially implement VMNMXReinUsesLisp3-0/+116
Implements the common usages for VMNMX. Inputs with a different size than 32 bits are not supported and sign mismatches aren't supported either. VMNMX works as follows: It grabs Ra and Rb and applies a maximum/minimum on them (this is defined by .MX), having in mind the input sign. This result can then be saturated. After the intermediate result is calculated, it applies another operation on it using Rc. These operations are merges, accumulations or another min/max pass. This instruction allows to implement with a more flexible approach GCN's min3 and max3 instructions (for instance).
2020-04-12video_core: Add MSAA registers in 3D engine and TICReinUsesLisp2-6/+76
This adds the registers used for multisampling. It doesn't implement anything for now.
2020-04-11texture_cache: Remove preserve_contentsReinUsesLisp3-47/+31
preserve_contents was always true. We can't assume we don't have to preserve clears because scissored and color masked clears exist. This removes preserve_contents and assumes it as true at all times.
2020-04-11renderer_vulkan: Drop Vulkan-HppReinUsesLisp51-2272/+2881
2020-04-10Buffer queue: Correct behavior of free buffer.Fernando Sahmkow2-9/+33
This corrects the behavior of free buffer after witnessing it in an unrelated hardware test. I haven't found any games affected by it but in name of better accuracy we'll correct such behavior.
2020-04-10service/vi: Partially implement BufferQueue disconnectReinUsesLisp3-10/+44
2020-04-10shader/texture: Remove type mismatches management from shader decoderReinUsesLisp1-14/+0
Since commit e22816a5bb we handle type mismatches from the CPU. We don't need to hack our shader decoder due to game bugs anymore. Removed in this commit.
2020-04-09astc: Hard code bit depth changes to 8 and use fast replicateReinUsesLisp1-21/+15
2020-04-09common/file_util: Allow access to files on network sharesBen Russell1-1/+8
On Windows, network shares use paths like \\server\share\file which were being broken by FileUtil::SanitizePath() removing double slashes. Changed the code in SanitizePath to permit a double-backslash if it occurs at the start of a filepath (on Windows only).
2020-04-09astc: Use boost's static_vector to avoid heap allocationsReinUsesLisp1-10/+14
2020-04-09astc: Implement a fast precompiled alternative for ReplicateReinUsesLisp1-2/+57
2020-04-09astc: Move Replicate to a constexpr LUT when possibleReinUsesLisp1-8/+38
2020-04-09astc: Make InputBitStream constexprReinUsesLisp1-11/+11
2020-04-09astc: OutputBitStream style changes and make it constexprReinUsesLisp1-32/+26
2020-04-09gl_texture_cache: Attach view instead of base texture for layered attachmentsReinUsesLisp1-2/+2
This way we are not ignoring the base layer of the current texture.
2020-04-09VkRasterizer: Eliminate Legacy code.Fernando Sahmkow1-1/+0
2020-04-09Memory: Correct GCC errors.Fernando Sahmkow2-2/+3
2020-04-08Memory: Address Feedback.Fernando Sahmkow4-4/+75
2020-04-08GPUMemoryManager: Improve safety of memory reads.Fernando Sahmkow3-55/+47
2020-04-08Place SL and SR in the right most column.Kewlan1-2/+2
2020-04-08qt/bootmanager: Remove unnecessary glBindFramebufferReinUsesLisp1-1/+0
Presentation context always has GL_DRAW_FRAMEBUFFER_BINDING as zero. There is no need to bind the default framebuffer constantly. According to Nsight this was using ~0.7ms per frame and it broke renderdoc captures.
2020-04-08video_core/textures: Move GetMaxAnisotropy to cpp fileReinUsesLisp2-19/+23
2020-04-08video_core/texture: Use a LUT to convert sRGB texture bordersReinUsesLisp3-9/+61
This is a reversed look up table extracted from https://gist.github.com/rygorous/2203834#file-gistfile1-cpp-L41-L62 that is used in https://github.com/devkitPro/deko3d/blob/04d4e9e587fa3dc5447b43d273bc45f440226e41/source/maxwell/tsc_generate.cpp#L38 Games usually bind 0xFD expecting a float texture border of 1.0f. The conversion previous to this commit was multiplying the uint8 sRGB texture border color by 255. This is close to 1.0f but when that difference matters, some graphical glitches appear. This look up table is manually changed in the edges, clamping towards 0.0f and 1.0f. While we are at it, move this logic to its own translation unit.
2020-04-07Addressed feedback: switched to snake case and fixed clang-format errorsSilverBeamx2-5/+6
2020-04-07Addressed feedback: removed CMake hack in favor of building the necessary strings via the supplied title formatSilverBeamx2-2/+14
2020-04-07yuzu: Drop SDL2 and Qt frontend Vulkan requirementsReinUsesLisp16-314/+371
Create Vulkan instances and surfaces from the Vulkan backend.
2020-04-07address nit.Nguyen Dac Nam1-1/+1
2020-04-07renderer_vulkan: Query device names from the backendReinUsesLisp4-35/+79
2020-04-07common/dynamic_library: Import and adapt helper from DolphinReinUsesLisp3-0/+183
2020-04-07shader/conversion: Implement I2I sign extension, saturation and selectionReinUsesLisp2-14/+101
Reimplements I2I adding sign extension, saturation (clamp source value to the destination), selection and destination sizes that are not 32 bits wide. It doesn't implement CC yet.
2020-04-07Apply suggestions from code reviewNguyen Dac Nam1-9/+9
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
2020-04-07file_sys: fix LayeredFS error when loading some games made with… (#3602)enler1-1/+2
* fix LayeredFS error when loading some games made with the Unity
2020-04-06Clang Format.Fernando Sahmkow1-6/+3
2020-04-06Shader/Pipeline Cache: Use VAddr instead of physical memory for addressing.Fernando Sahmkow7-87/+62
2020-04-06Query Cache: Use VAddr instead of physical memory for adressing.Fernando Sahmkow3-23/+22
2020-04-06Buffer Cache: Use vAddr instead of physical memory.Fernando Sahmkow12-106/+254
2020-04-06Texture Cache: Use vAddr instead of physical memory for caching.Fernando Sahmkow5-130/+81
2020-04-06GPU: Setup Flush/Invalidate to use VAddr instead of CacheAddrFernando Sahmkow14-67/+77
2020-04-06shader_decode: SULD.D using std::pair instead of out parameternamkazy2-19/+15
2020-04-06shader_decode: SULD.D avoid duplicate code block.namkazy1-39/+2
2020-04-06shader_decode: SULD.D fix conversion error.namkazy1-3/+3
2020-04-06shader_decode: SULD.D implement bits64 and reverse shader ir init method to removed shader stage.namkazy5-46/+105
2020-04-06shader/memory: Implement RED.E.ADDReinUsesLisp5-28/+99
Implements a reduction operation. It's an atomic operation that doesn't return a value. This commit introduces another primitive because some shading languages might have a primitive for reduction operations.
2020-04-06shader/memory: Add "using std::move"ReinUsesLisp1-11/+13
2020-04-06shader/memory: Minor fixes in ATOMReinUsesLisp1-32/+30
2020-04-06yuzu: Fixes to game list sortingFearlessTobi2-8/+22
Should fix citra-emu/citra#4593. As the issue might not be entirely clear, I'll offer a short explanation from what I understood from it and found from experimentation. Currently yuzu offers the user the option to change the text that's displayed in the "Name" column in the game list. Generally, it is expected that the items are sorted based on the displayed text, but yuzu would sort them by title instead. Made it so that an access to SortRole returns the same as DisplayRole. There shouldn't be any UI changes, only change in behaviour. Also fixes a bug with directory sorting, where having the directories out of order would enable you to try to "move up" to the addDirectory button, which would crash the emulator. Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2020-04-05silent warning (conversion error)namkazy1-3/+2
2020-04-05shader_decode: SULD.D -> SINT actually same as UNORM.namkazy1-5/+4
2020-04-05shader_decode: SULD.D fix decode SNORM componentnamkazy1-10/+9
2020-04-05clang-formatnamkazy1-2/+2
2020-04-05shader_decode: get sampler descriptor from registry.namkazy1-77/+93
2020-04-05yuzu/configuration: Only assert that all buttons exist when we are handling the click for a button deviceFearlessTobi2-14/+16
This fixes failed assertions that were present in yuzu master code for 18 months.
2020-04-05yuzu/configure_input_simple: Fix "Docked Joycons" controller profileFearlessTobi1-4/+5
This was incorrectly using PlayerIndex 1 when calling the ConfigureDialog.
2020-04-05tweaking.namkazy1-3/+3
2020-04-05clang-formatNguyen Dac Nam1-2/+1
2020-04-05cleanup unuse paramsnamkazy1-8/+6
2020-04-05cleanup debug code.namkazy1-14/+3
2020-04-05reimplement get component type, uncomment mistaken codenamkazy1-18/+93
2020-04-05remove disable optimizenamkazy1-2/+0
2020-04-05[wip] reimplement SULD.Dnamkazy1-22/+229
2020-04-05add shader stage when init shader irnamkazy4-9/+12
2020-04-05clang-fixNguyen Dac Nam1-1/+1
2020-04-05shader: image - import PredConditionNguyen Dac Nam1-0/+1
2020-04-05shader: SULD.D bits32 implement more complexer method.Nguyen Dac Nam1-4/+28
2020-04-05shader: SULD.D import StoreTypeNguyen Dac Nam1-0/+1
2020-04-05shader: implement SULD.D bits32Nguyen Dac Nam1-11/+27
2020-04-04shader/other: Add error message for some S2R registersReinUsesLisp1-0/+6
2020-04-04shader_bytecode: Rename MOV_SYS to S2RReinUsesLisp2-5/+5
2020-04-04shader_bytecode: Add encoding for BARReinUsesLisp1-0/+2
2020-04-04shader_ir: Add error message for EXIT.FCSM_TRReinUsesLisp1-0/+3
2020-04-04shader_bytecode: Add encoding for VOTE.VTGReinUsesLisp1-0/+2
2020-04-04Revert "Merge pull request #3499 from ReinUsesLisp/depth-2d-array"ReinUsesLisp1-4/+2
This reverts commit 41905ee467b24172ba93e3fcd665bb4e4806a45a, reversing changes made to 35145bd529c3517e2c366efc764a762092d96edf. It causes regressions in several games.
2020-04-02shader/memory: Silence no return value warningReinUsesLisp1-0/+3
Silences a warning about control paths not all returning a value.
2020-04-02shader_decompiler: Remove FragCoord.w hack and change IPA implementationReinUsesLisp4-68/+74
Credits go to gdkchan and Ryujinx. The pull request used for this can be found here: https://github.com/Ryujinx/Ryujinx/pull/1082 yuzu was already using the header for interpolation, but it was missing the FragCoord.w multiplication described in the linked pull request. This commit finally removes the FragCoord.w == 1.0f hack from the shader decompiler. While we are at it, this commit renames some enumerations to match Nvidia's documentation (linked below) and fixes component declaration order in the shader program header (z and w were swapped). https://github.com/NVIDIA/open-gpu-doc/blob/master/Shader-Program-Header/Shader-Program-Header.html
2020-04-01gl_texture_cache: Fix software ASTC fallbackReinUsesLisp1-7/+12
2020-04-01vk_device: Add missing ASTC queriesReinUsesLisp1-14/+29
2020-04-01video_core: Use native ASTC when availableReinUsesLisp10-281/+176
2020-04-01gl_device: Detect if ASTC is reported and expose itReinUsesLisp2-0/+31
2020-04-01common: Port some changes from dolphin (#5127)Vitor K2-15/+16
* IOFile: Make the move constructor and move assignment operator noexcept Certain parts of the standard library try to determine whether or not a transfer operation should either be a copy or a move. The prevalent notion of move constructors/assignment operators is that they should not throw, they simply move an already existing resource somewhere else. This is typically done with 'std::move_if_noexcept'. Like the name says, if a type's move constructor is noexcept, then the functions retrieves an r-value reference (for move semantics), or an l-value (for copy semantics) if it is not noexcept. As IOFile deletes the copy constructor and copy assignment operators, using IOFile with certain parts of the standard library can fail in unexcepted ways (especially when used with various container implementations). This prevents that. * fix various instances of -1 being assigned to unsigned types * do not assign in conditional statements * File/IOFile: Check _tfopen_s properly * common/file_util.cpp: address review comments Co-authored-by: Lioncash <mathew1800@gmail.com> Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com> Co-authored-by: Sepalani <sepalani@hotmail.fr>
2020-04-01renderer_vulkan/wrapper: Add vkEnumerateInstanceExtensionProperties wrapperReinUsesLisp2-0/+17
2020-04-01renderer_vulkan/wrapper: Add command buffer handleReinUsesLisp1-0/+192
2020-04-01renderer_vulkan/wrapper: Add physical device handleReinUsesLisp2-0/+123
2020-04-01renderer_vulkan/wrapper: Add device handleReinUsesLisp2-0/+277
2020-04-01renderer_vulkan/wrapper: Add swapchain handleReinUsesLisp2-0/+15
2020-04-01renderer_vulkan/wrapper: Add fence handleReinUsesLisp1-0/+17
2020-04-01renderer_vulkan/wrapper: Add device memory handleReinUsesLisp1-0/+15
2020-04-01renderer_vulkan/wrapper: Add pool handlesReinUsesLisp2-0/+47
2020-04-01renderer_vulkan/wrapper: Add buffer and image handlesReinUsesLisp2-0/+24
2020-04-01renderer_vulkan/wrapper: Add queue handleReinUsesLisp2-0/+36
2020-04-01renderer_vulkan/wrapper: Add instance handleReinUsesLisp2-0/+87
2020-04-01capsrv: Split Capture services into individual files and stub GetAlbumContentsFileListForApplication (#3571)Morph15-151/+536
* Organize capture services into individual files * Stub GetAlbumContentsFileListForApplication * Address feedback
2020-03-31gl_rasterizer: Mark cleared textures as dirtyReinUsesLisp1-2/+5
Fixes a potential edge case where cleared textures read from the CPU were not flushed.
2020-03-31clang-formatNguyen Dac Nam1-2/+1
2020-03-31shader_decode: fix by suggestionNguyen Dac Nam1-27/+22
2020-03-30Frontend: Don't call DoneCurrent if the context isnt already currentJames Rowe2-2/+13
2020-03-30clang-formatnamkazy1-3/+3
2020-03-30gl_decompiler: min/max op not implement yetnamkazy1-0/+4
2020-03-30shader_decode: ATOM/ATOMS: add function to avoid code repetitionnamkazy2-70/+53
2020-03-30shader_decode: merge GlobalAtomicOp to AtomicOpnamkazy1-13/+1
2020-03-30shader_decode: implement ATOM operation for S32 and U32Nguyen Dac Nam1-6/+39
2020-03-30clang-formatnamkazy1-3/+3
2020-03-30shader_decode: implement ATOMS instr partial.Nguyen Dac Nam1-10/+42
2020-03-30vk_decompiler: add atomic op and handler function.Nguyen Dac Nam1-6/+25
2020-03-30gl_decompiler: add atomic opNguyen Dac Nam1-0/+16
2020-03-30shader: node - update correct commentNguyen Dac Nam1-15/+15
2020-03-30shader_decode: add Atomic op for common usageNguyen Dac Nam1-1/+15
2020-03-29Re-order the shoulder buttons both in the configuration menu, and in the code.Kewlan1-36/+36
2020-03-28shader_bytecode: Fix I2I_IMM encodingReinUsesLisp1-1/+1
2020-03-28renderer_vulkan/wrapper: Address feedbackReinUsesLisp1-3/+24
2020-03-28shader/lea: Simplify generated LEA codeReinUsesLisp1-3/+2
2020-03-28yuzu: fix the stuck in fullscreen mode bugFearlessTobi1-0/+8
Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>
2020-03-27shader/lea: Fix op_a and op_b usagesReinUsesLisp1-2/+2
They were swapped.
2020-03-27shader/lea: Remove const and use move when possibleReinUsesLisp1-11/+5
2020-03-27Set render window to also accept focus via tabbing (Qt::StrongFocus) (#5089)Vitor K1-1/+1
2020-03-27services: hid: Stub InitializeSevenSixAxisSensor.bunnei2-1/+9
- Used by Super Smash Bros. Ultimate v7.0.0.
2020-03-27services: time: Implement CalculateSpanBetween.bunnei3-1/+31
- Used by Super Smash Bros. Ultimate.
2020-03-27am: Implement VR related APIsperillamint2-3/+42
Implement (and stub) VR related APIs in AM sysmodule. This fixes issue #2938
2020-03-27renderer_vulkan/wrapper: Add owning handlesReinUsesLisp1-0/+18
2020-03-27renderer_vulkan/wrapper: Add pool allocations owning templated classReinUsesLisp1-0/+81
2020-03-27renderer_vulkan/wrapper: Add owning handle templated classReinUsesLisp1-0/+144
2020-03-27renderer_vulkan/wrapper: Add destroy and free overload setReinUsesLisp2-0/+133
2020-03-27renderer_vulkan/wrapper: Add dispatch table and loadersReinUsesLisp2-0/+283
2020-03-27renderer_vulkan/wrapper: Add exception classReinUsesLisp2-0/+34
2020-03-27renderer_vulkan/wrapper: Add ToString function for VkResultReinUsesLisp3-0/+91
2020-03-27renderer_vulkan/wrapper: Add Vulakn wrapper and a span helperReinUsesLisp2-0/+84
The intention behind a Vulkan wrapper is to drop Vulkan-Hpp. The issues with Vulkan-Hpp are: - Regular breaks of the API. - Copy constructors that do the same as the aggregates (fixed recently) - External dynamic dispatch that is hard to remove - Alias KHR handles with non-KHR handles making it impossible to use smart handles on Vulkan 1.0 instances with extensions that were included on Vulkan 1.1. - Dynamic dispatchers silently change size depending on preprocessor definitions. Different files will have different dispatch definitions, generating all kinds of hard to debug memory issues. In other words, Vulkan-Hpp is not "production ready" for our needs and this wrapper aims to replace it without losing RAII and exception safety.
2020-03-27engines/const_buffer_engine_interface: Store image format typeReinUsesLisp1-4/+10
This information is required to properly implement SULD.B. It might also be handy for all image operations, since it would allow us to implement them on devices that require the image format to be specified (on desktop, this would be AMD on OpenGL and Intel on OpenGL and Vulkan).
2020-03-27maxwell_to_vk: implement signedscaled vertex formatsDan1-0/+20
2020-03-26services: ldr: Fix MemoryState for read/write regions of NROs.bunnei1-5/+15
- Fixes #3541, used by Final Fantasy VIII Remastered.
2020-03-26Address review and fix broken yuzu-tester buildJames Rowe11-102/+83
2020-03-26shader/conversion: Fix F2F rounding operations with different sizesReinUsesLisp1-5/+10
Rounding operations only matter when the conversion size of source and destination is the same, i.e. .F16.F16, .F32.F32 and .F64.F64. When there is a mismatch (.F16.F32), these bits are used for IEEE rounding, we don't emulate this because GLSL and SPIR-V don't support configuring it per operation.
2020-03-26gl_rasterizer: Update stencil test regardless of it being disabledReinUsesLisp1-5/+1
2020-03-26gl_rasterizer: Synchronize stencil testing on clearsReinUsesLisp1-0/+1
2020-03-25Frontend/GPU: Refactor context managementJames Rowe29-418/+361
Changes the GraphicsContext to be managed by the GPU core. This eliminates the need for the frontends to fool around with tricky MakeCurrent/DoneCurrent calls that are dependent on the settings (such as async gpu option). This also refactors out the need to use QWidget::fromWindowContainer as that caused issues with focus and input handling. Now we use a regular QWidget and just access the native windowHandle() directly. Another change is removing the debug tool setting in FrameMailbox. Instead of trying to block the frontend until a new frame is ready, the core will now take over presentation and draw directly to the window if the renderer detects that its hooked by NSight or RenderDoc Lastly, since it was in the way, I removed ScopeAcquireWindowContext and replaced it with a simple subclass in GraphicsContext that achieves the same result
2020-03-23sm/controller: Increase PointerBufferSizeFearlessTobi1-1/+1
This increases the PointerBufferSize as a lager one is required by some services. This change is still not hw-accurate, but it is proven to work in Ryujinx. Instead of using a hardcoded size, we should figure out the specific values for each service in the future. Some of them can be taken from Atmosphere: https://github.com/Atmosphere-NX/Atmosphere/search?q=PointerBufferSize.
2020-03-23audio_core: Accept Audren REV8FearlessTobi1-1/+1
According to Ryujinx, REV8 only added changes on Performance buffer and Wavebuffer DSP command generation. As we don't support any of those, we can just increment the revision number for now.
2020-03-23xmad: fix clang build errormakigumo1-4/+5
2020-03-22apply replay logic to all writes. remove replay from MacroInterpreter::Send (@fincs)namkazy2-12/+9
2020-03-22core/web_browser: Allow WebApplet to exit gracefully when an error occursFearlessTobi1-0/+6
Currently, yuzu just freezes when an error occurs while Initializing the WebApplet. From a user perspective, this obviously isn't great as the game just softlocks. With this change, yuzu will call the Finalize method, so to the game it seems like as the user just exited the WebApplet normally. This works around https://github.com/yuzu-emu/yuzu/issues/2852.
2020-03-22maxwell_3d: change declaration ordernamkazy1-1/+3
2020-03-22maxwell_3d: init shadow_statenamkazy1-0/+2
2020-03-22gl_rasterizer: Use transformed viewport for depth rangesReinUsesLisp1-4/+6
Implement depth ranges using the transformed viewport instead of the generic one. This matches the current Vulkan implementation but doesn't support negative depth ranges. An update to glad is required for this.
2020-03-22maxwell_3d: this seem more correct.namkazy1-2/+2
2020-03-22maxwell_3d: update comments for shadow ram usagenamkazy3-2/+6
2020-03-22marco_interpreter: write hw value when shadow ram requestedNguyen Dac Nam1-0/+6
2020-03-22maxwell_3d: track shadow ram ctrl and hw reg valueNguyen Dac Nam1-0/+10
2020-03-22maxwell_3d: implement MME shadow RAMNguyen Dac Nam1-1/+14
2020-03-19set: implement GetRegionCodeDan8-9/+72
2020-03-19vk_texture_cache: Silence misc warningsReinUsesLisp1-3/+3
2020-03-19vk_staging_buffer_pool: Silence unused constant warningReinUsesLisp1-1/+1
2020-03-19vk_rasterizer: Remove unused variableReinUsesLisp1-2/+0
2020-03-19vk_pipeline_cache: Remove unused variableReinUsesLisp1-1/+0
2020-03-19maxwell_to_vk: Sielence -Wswitch warningReinUsesLisp1-0/+2
2020-03-19gl_shader_decompiler: Remove deprecated function and its usagesReinUsesLisp1-11/+8
2020-03-19gl_rasterizer: Silence misc warningsReinUsesLisp1-7/+2
2020-03-19kepler_compute: Remove unused variablesReinUsesLisp1-8/+0
2020-03-18time_zone_content_manager: Fix out of bounds readReinUsesLisp1-1/+1
There were cases where raw_data didn't contain enough space to hold the zero terminator. This was caught with -fsanitize=address.
2020-03-18input_common/udp: Fix clang build issuesReinUsesLisp1-1/+2
2020-03-18astc: Fix clang build issuesReinUsesLisp1-12/+12
2020-03-18gl_shader_decompiler: Don't redeclare gl_VertexID and gl_InstanceIDReinUsesLisp1-8/+0
2020-03-17yuzu: Save sound output mode and set it to Stereo by defaultFearlessTobi3-0/+7
2020-03-17bcat: Disable Boxcat backend by defaultFearlessTobi2-2/+2
This commit disables the Boxcat backend by default for new users of yuzu. There's several reasons as to why this is done: 1. Boxcat currently only actually has an impact on 3 games and doesn't influence any core mechanics of them 2. It causes a plethora of issues when enabled such as games like Crash Team Racing, Diablo 3 and Tales of Vesperia not booting at all or hanging 3. It causes https://github.com/yuzu-emu/yuzu/issues/2957 to happen. This makes the configuration menu totally unusable for many Linux users of yuzu I think those points show that currently the negative impact of Boxcat outweighs its benefits and should therefore be disabled by default. For users who are eager to use the extra features provided by it, they can still just turn it on in the settings.
2020-03-17input_common/udp: Fix Linux build by using a backwards compatible way of error checkingFearlessTobi1-1/+1
Should fix https://github.com/yuzu-emu/yuzu/issues/3487. error_code::failed is a function which has been introduced in Boost 1.69. This version of boost hasn't landed in most major distros yet.
2020-03-17gdbstub: small logic bug fix with defer_startGauvain "GovanifY" Roussel-Tarbouriech1-2/+4
2020-03-17gdbstub: Ensure gdbstub doesn't drop packets crucial to initializationGauvain "GovanifY" Roussel-Tarbouriech3-2/+16
2020-03-16renderer_opengl: Move some logic to an anonymous namespaceReinUsesLisp1-151/+151
2020-03-16renderer_opengl: Detect Nvidia Nsight as a debugging toolReinUsesLisp3-7/+22
Use getenv to detect Nsight.
2020-03-16gl_shader_decompiler: Implement legacy varyingsReinUsesLisp1-6/+57
Legacy varyings are special attributes carried over in hardware from the OpenGL 1 and OpenGL 2 days. These were generally used instead of the generic attributes we use today. They are deprecated or removed from most APIs, but Nvidia still ships them in hardware. To implement these, this commit maps them 1:1 to OpenGL compatibility.
2020-03-16shader/shader_ir: Track usage in input attribute and of legacy varyingsReinUsesLisp3-34/+64
2020-03-16shader/shader_ir: Fix clip distance usage storesReinUsesLisp1-2/+1
2020-03-16shader/shader_ir: Change declare output attribute to a switchReinUsesLisp1-9/+9
2020-03-15maxwell_to_vk: Implement RG32 and RGB32 integer vertex formatsReinUsesLisp1-0/+4
2020-03-15vk_rasterizer: Implement layered clearsReinUsesLisp1-2/+2
2020-03-15vk_shader_decompiler: fix linux buildmakigumo1-1/+1
2020-03-15vk_rasterizer: Fix vertex range assertReinUsesLisp1-1/+1
End can be equal to start in CalculateVertexArraysSize. This is quite common when the vertex size is zero.
2020-03-15vk_rasterizer: Reimplement clears with vkCmdClearAttachmentsReinUsesLisp4-45/+53
2020-03-14renderer_opengl: Keep presentation frames in lock-step when GPU debugging.bunnei1-1/+32
- Fixes renderdoc with OpenGL renderer.
2020-03-14gl_device: Add option to check GL_EXT_debug_tool.bunnei2-0/+6
2020-03-14DirtyFlags: relax need to set render_targets as dirty Fernando Sahmkow4-13/+0
The texture cache already takes care of setting a render target to dirty when invalidated.
2020-03-14PageTable: move backing addresses to a children class as the CPU page table does not need them.Fernando Sahmkow3-4/+25
This PR aims to reduce the memory usage in the CPU page table by moving GPU specific parameters into a child class. This saves 1Gb of Memory for most games.
2020-03-14astc: Fix typos from search and replaceReinUsesLisp1-3/+3
2020-03-14astc: Minor changes to InputBitStreamReinUsesLisp1-28/+34
2020-03-14astc: Pass val in Replicate by copyReinUsesLisp1-1/+1
2020-03-14astc: Call std::vector:reserve on decodedClolorValues to avoid reallocatingReinUsesLisp1-0/+2
2020-03-14clang-formatNguyen Dac Nam1-2/+1
2020-03-14nitNguyen Dac Nam1-1/+1
2020-03-14astc: Call std::vector::reserve on texelWeightValues to avoid reallocatingReinUsesLisp1-0/+2
2020-03-14astc: Create a LUT at compile time for encoding valuesReinUsesLisp1-7/+19
2020-03-14astc: Make IntegerEncodedValue a trivial structureReinUsesLisp1-212/+177
2020-03-14astc: Make IntegerEncodedValue constructor constexprReinUsesLisp1-5/+6
2020-03-14astc: Make IntegerEncodedValue trivially copyableReinUsesLisp1-9/+2
2020-03-14astc: Rename C types to common_typesReinUsesLisp1-79/+78
2020-03-14astc: Move Popcnt to an anonymous namespace and make it constexprReinUsesLisp1-9/+13
2020-03-14astc: Use common types instead of stdint.h integer typesReinUsesLisp1-284/+282
2020-03-14astc: Use 'enum class' instead of 'enum' for EIntegerEncodingReinUsesLisp1-25/+25
2020-03-13vk/gl_shader_decompiler: Silence assertion on computeReinUsesLisp2-6/+12
2020-03-13vk_shader_decompiler: Fix default varying regressionReinUsesLisp1-2/+6
2020-03-13maxwell_3d: Add padding words to XFB entriesReinUsesLisp1-2/+4
Use INSERT_UNION_PADDING_WORDS instead of alignas to ensure a size requirement.
2020-03-13gl_shader_decompiler: Fix implicit conversion errorsReinUsesLisp1-3/+3
2020-03-13vk_shader_decompiler: Fix implicit type conversionRodrigo Locatti1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2020-03-13vk_rasterizer: Implement transform feedback binding zeroReinUsesLisp2-0/+46
2020-03-13vk_shader_decompiler: Add XFB decorations to generic varyingsReinUsesLisp1-16/+89
2020-03-13vk_device: Enable VK_EXT_transform_feedback when availableReinUsesLisp2-7/+40
2020-03-13vk_device: Shrink formatless capability name sizeReinUsesLisp3-26/+23
2020-03-13shader/transform_feedback: Expose buffer strideReinUsesLisp3-1/+4
2020-03-13vk_shader_decompiler: Use registry for specializationReinUsesLisp4-31/+37
2020-03-13gl_rasterizer: Implement transform feedback bindingsReinUsesLisp3-10/+83
2020-03-13gl_shader_decompiler: Decorate output attributes with XFB layoutReinUsesLisp1-29/+105
We sometimes have to slice attributes in different parts. This is needed for example in instances where the game feedbacks 3 components but writes 4 from the shader (something that is possible with GL_NV_transform_feedback).
2020-03-13shader/transform_feedback: Add host API friendly TFB builderReinUsesLisp4-0/+140
2020-03-13nit & remove some optional paramNguyen Dac Nam1-10/+11
2020-03-13shader_decode: implement XMAD mode CSfuNguyen Dac Nam1-9/+41
2020-03-13fix formattingmakigumo1-1/+1
2020-03-13maxwell_to_vk: add vertex format eA2B10G10R10UnormPack32makigumo1-1/+3
2020-03-13clang-formatNguyen Dac Nam1-4/+8
2020-03-13Apply suggestions from code reviewNguyen Dac Nam1-5/+5
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2020-03-13shader_decode: BFE add ref of reverse parallel method.Nguyen Dac Nam1-0/+3
2020-03-13shader_decode: implement BREV on BFENguyen Dac Nam1-6/+25
Implement reverse parallel follow: https://graphics.stanford.edu/~seander/bithacks.html#ReverseParallel
2020-03-13shader_bytecode: update BFE instructions struct.Nguyen Dac Nam1-8/+3
2020-03-13node_helper: add IBitfieldExtract caseNguyen Dac Nam1-0/+2
2020-03-13shader_decode: Reimplement BFE instructionsNguyen Dac Nam1-25/+27
2020-03-13gl_shader_decompiler: Initialize gl_Position on vertex shadersReinUsesLisp1-0/+4
2020-03-13gl_shader_decompiler: Add missing {} on smem GLSL emissionReinUsesLisp1-1/+1
2020-03-13video_core: Implement RGBA16_SNORMReinUsesLisp8-69/+84
Implement RGBA16_SNORM with the current API. Nothing special here.
2020-03-12texture_cache: Report incompatible textures as blackReinUsesLisp1-2/+39
Some games bind incompatible texture types to certain types. For example Astral Chain binds a 2D texture with 1 layer (non-array) to a cubemap slot (that's how it's used in the shader). After testing this in hardware, the expected "undefined behavior" is to report all pixels as black. We already have a path for reporting black textures in the texture cache. When textures types are incompatible, this commit binds these kind of textures. This is done on the API agnostic texture cache so no extra code has to be inserted on OpenGL or Vulkan. As a side effect, this fixes invalidations of ASTC textures on Astral Chain. This happened because yuzu detected a cube texture and forced 6 faces, generating a texture larger than what the TIC reported.
2020-03-12texture_cache/surface_params: Force depth=1 on 2D texturesReinUsesLisp1-2/+4
Sometimes games will sample a 2D array TIC with a 2D access in the shader. This causes bad interactions with the rest of the texture cache. To emulate what the game wants to do, force a depth=1 on 2D textures (not 2D arrays) and let the texture cache handle the rest.
2020-03-12gl_shader_decompiler: Add layer component to texelFetchReinUsesLisp1-6/+9
TexelFetch was not emitting the array component generating invalid GLSL.
2020-03-12NVFlinger: Do the microprofile Flip after processing a valid frame.Fernando Sahmkow1-2/+2
2020-03-12gl_shader_decompiler: Fix regression in render target declarationsReinUsesLisp1-12/+2
A previous commit introduced a way to declare as few render targets as possible. Turns out this introduced a regression in some games.
2020-03-11framebuffer_layout.h: drop the use of enum for screen dimensions.Vitor Kiguchi2-10/+10
+clang format
2020-03-11gl_shader_manager: Fix interaction between graphics and computeReinUsesLisp4-29/+39
After a compute shader was set to the pipeline, no graphics shader was invoked again. To address this use glUseProgram to bind compute shaders (without state tracking) and call glUseProgram(0) when transitioning out of it back to the graphics pipeline.
2020-03-10gl_rasterizer: Implement polygon modes and fill rectanglesReinUsesLisp7-2/+99
2020-03-09engines/maxwell_3d: Add TFB registers and store them in shader registryReinUsesLisp4-6/+45
2020-03-09shader/registry: Address feedbackReinUsesLisp3-13/+18
2020-03-09gl_shader_decompiler: Add identifier to decompiled codeReinUsesLisp3-8/+16
2020-03-09gl_shader_decompiler: Roll back to GLSL core 430ReinUsesLisp1-1/+1
RenderDoc won't build shaders if we use GLSL compatibility.
2020-03-09const_buffer_engine_interface: Store component typesReinUsesLisp4-46/+27
This is required for Vulkan. Sampling integer textures with float handles is illegal.
2020-03-09yuzu/loading_screen: Remove unused shader progress modeReinUsesLisp2-17/+1
2020-03-09gl_shader_cache: Reduce registry consistency to debug assertReinUsesLisp1-3/+1
Registry consistency is something that practically can't happen and it has a measurable runtime cost. Reduce it to a DEBUG_ASSERT.
2020-03-09shader/registry: Cache tessellation stateReinUsesLisp3-3/+10
2020-03-09shader/registry: Store graphics and compute metadataReinUsesLisp8-75/+176
Store information GLSL forces us to provide but it's dynamic state in hardware (workgroup sizes, primitive topology, shared memory size).
2020-03-09video_core: Rename "const buffer locker" to "registry"ReinUsesLisp16-95/+100
2020-03-09gl_shader_cache: Rework shader cache and remove post-specializationsReinUsesLisp18-1094/+544
Instead of pre-specializing shaders and then post-specializing them, drop the later and only "specialize" the shader while decoding it.
2020-03-08textures: Fix anisotropy hackReinUsesLisp1-14/+16
Previous code could generate an anisotropy value way higher than x16.
2020-03-08cubeb_sink: Don't discard other channels when performing downmixingFearlessTobi1-3/+17
Previously, when performing downmixing, we would discard all channels except the left and right one. This implementation respects them when mixing down to Stereo. It is taken from this document: http://www.atsc.org/wp-content/uploads/2015/03/A52-201212-17.pdf. Fixes Luigis Mansion 3 cutscene and Bayonetta audio.
2020-03-08vk_reasterizer: fix mistype on SetupGraphicsImagesNguyen Dac Nam1-1/+1
This should use Maxwell3D engine. Fixed some GPU error on Kirby and maybe other games.
2020-03-06vk_rasterizer: Support disabled uniform buffersReinUsesLisp2-1/+9
2020-03-06maxwell_to_vk: Remove Storage capability for A1B5G5R5UReinUsesLisp1-1/+1
2020-03-04input/udp - Add minor error handling to prevent bad input from crashingJames Rowe1-4/+13
2020-03-04Frontend/SDL - Provide proper default for UDP inputJames Rowe1-1/+1
When the default file is read in, the settings default value is only used when the key is missing. As it was, the key existed, but the value was empty string causing it to accept that as a value to pass into the core
2020-03-04input/udp - Dont log on invalid packet receivedJames Rowe1-1/+0
2020-03-03core: hle: Implement separate A32/A64 SVC interfaces.bunnei2-107/+380
2020-03-03core: Implement separate A32/A64 ARM interfaces.bunnei21-122/+454
2020-03-03core: loader: Remove check for 32-bit.bunnei1-6/+0
2020-03-03core: dynarmic: Add CP15 from Citra.bunnei3-0/+234
2020-02-29nit: move comment to right place.Nguyen Dac Nam1-2/+2
2020-02-28video_core/dirty_flags: Address feedbackReinUsesLisp1-4/+4
2020-02-28renderer_opengl: Fix edge-case where alpha testing might cull presentationReinUsesLisp2-0/+7
2020-02-28gl_texture_cache: Remove blending disable on blitsReinUsesLisp1-5/+0
Blending doesn't affect blits. Rasterizer discard does, update the commentaries.
2020-02-28gl_rasterizer: Don't disable blending on clearsReinUsesLisp1-4/+0
Blending doesn't affect clears.
2020-02-28dirty_flags: Deduplicate code between OpenGL and VulkanReinUsesLisp5-77/+73
2020-02-28vk_rasterizer: Pass Maxwell registers to dynamic updatesReinUsesLisp2-26/+21
2020-02-28state_tracker: Remove type traits with named structuresReinUsesLisp4-18/+22
2020-02-28vk_state_tracker: Implement dirty flags for stencil propertiesReinUsesLisp3-0/+21
2020-02-28vk_state_tracker: Implement dirty flags for depth boundsReinUsesLisp3-0/+14
2020-02-28vk_state_tracker: Implement dirty flags for blend constantsReinUsesLisp3-0/+14
2020-02-28vk_state_tracker: Implement dirty flags for depth biasReinUsesLisp3-0/+17
2020-02-28vk_state_tracker: Implement dirty flags for scissorsReinUsesLisp3-0/+14
2020-02-28vk_state_tracker: Initial implementationReinUsesLisp10-52/+198
Add support for render targets and viewports.
2020-02-28gl_rasterizer: Remove num vertex buffers magic numberReinUsesLisp1-2/+4
2020-02-28gl_rasterizer: Only apply polygon offset clamp if enabledReinUsesLisp1-3/+6
2020-02-28gl_state_tracker: Implement dirty flags for depth clamp enablingReinUsesLisp3-3/+15
2020-02-28gl_rasterizer: Disable scissor 0 when scissor is not used on clearReinUsesLisp1-0/+3
2020-02-28gl_rasterizer: Notify depth mask changes on clearReinUsesLisp2-1/+6
2020-02-28gl_rasterizer: Minor sort changes to clearingReinUsesLisp1-11/+9
2020-02-28maxwell_3d: Use two tables instead of three for dirty flagsReinUsesLisp1-1/+1
2020-02-28gl_state_tracker: Track state of index buffersReinUsesLisp4-5/+23
2020-02-28gl_state_tracker: Implement dirty flags for clip controlReinUsesLisp5-15/+31
2020-02-28gl_state_tracker: Implement dirty flags for point sizesReinUsesLisp3-4/+25
2020-02-28gl_state_tracker: Implement dirty flags for fragment color clampReinUsesLisp3-2/+14
2020-02-28gl_state_tracker: Implement dirty flags for logic opReinUsesLisp4-2/+22
2020-02-28gl_state_tracker: Implement dirty flags for sRGBReinUsesLisp5-2/+21
2020-02-28gl_state_tracker: Implement dirty flags for rasterize enableReinUsesLisp5-2/+21
2020-02-28gl_state_tracker: Implement dirty flags for multisampleReinUsesLisp3-0/+13
2020-02-28gl_state_tracker: Implement dirty flags for alpha testingReinUsesLisp4-6/+24
2020-02-28gl_state_tracker: Implement dirty flags for polygon offsetsReinUsesLisp4-2/+24
2020-02-28gl_state_tracker: Implement dirty flags for primitive restartReinUsesLisp3-5/+19
2020-02-28gl_state_tracker: Implement dirty flags for stencil testingReinUsesLisp4-3/+29
2020-02-28gl_state_tracker: Implement depth dirty flagsReinUsesLisp4-6/+31
2020-02-28gl_state_tracker: Implement dirty flags for front face and cullingReinUsesLisp4-7/+38
2020-02-28gl_state_tracker: Implement dirty flags for blendingReinUsesLisp5-14/+67
2020-02-28gl_state_tracker: Implement dirty flags for clip distances and shadersReinUsesLisp7-14/+43
2020-02-28gl_state_tracker: Add dirty flags for buffers and divisorsReinUsesLisp4-22/+56
2020-02-28maxwell_3d: Change write dirty flags to a bitsetReinUsesLisp3-16/+16
2020-02-28gl_state_tracker: Implement dirty flags for vertex formatsReinUsesLisp4-9/+44
2020-02-28gl_state_tracker: Implement dirty flags for color masksReinUsesLisp4-9/+53
2020-02-28gl_state_tracker: Implement dirty flags for scissorsReinUsesLisp5-10/+58
2020-02-28gl_state_tracker: Implement dirty flags for viewportsReinUsesLisp4-9/+54
2020-02-28renderer_opengl: Reintroduce dirty flags for render targetsReinUsesLisp9-13/+195
2020-02-28maxwell_3d: Flatten cull and front face registersReinUsesLisp8-50/+47
2020-02-28video_core: Reintroduce dirty flags infrastructureReinUsesLisp10-1/+72
2020-02-28gl_state: Remove completelyReinUsesLisp13-152/+4
2020-02-28gl_state: Remove program trackingReinUsesLisp9-94/+62
2020-02-28gl_state: Remove framebuffer trackingReinUsesLisp7-82/+23
2020-02-28gl_state: Remove image trackingReinUsesLisp5-24/+12
2020-02-28gl_state: Remove texture and sampler trackingReinUsesLisp5-60/+8
2020-02-28gl_state: Remove blend state trackingReinUsesLisp5-104/+28
2020-02-28gl_state: Remove stencil test trackingReinUsesLisp4-92/+18
2020-02-28gl_state: Remove clip control trackingReinUsesLisp5-19/+8
2020-02-28gl_state: Remove clip distances trackingReinUsesLisp4-29/+3
2020-02-28gl_state: Remove rasterizer disable trackingReinUsesLisp6-13/+8
2020-02-28gl_state: Remove viewport and depth range trackingReinUsesLisp7-101/+39
2020-02-28gl_state: Remove scissor test trackingReinUsesLisp6-69/+12
2020-02-28gl_state: Remove color mask trackingReinUsesLisp4-40/+12
2020-02-28gl_state: Remove clamp framebuffer color trackingReinUsesLisp3-17/+6
This commit doesn't reset it for screen draws because clamping doesn't change anything there.
2020-02-28gl_state: Remove multisample trackingReinUsesLisp3-16/+2
2020-02-28gl_state: Remove framebuffer sRGB trackingReinUsesLisp6-21/+25
2020-02-28gl_state: Remove VAO cache and trackingReinUsesLisp10-153/+53
2020-02-28gl_state: Remove depth clamp trackingReinUsesLisp4-25/+13
2020-02-28gl_state: Remove depth trackingReinUsesLisp4-34/+7
2020-02-28gl_state: Remove primitive restart trackingReinUsesLisp3-18/+2
2020-02-28gl_state: Remove logic op trackerReinUsesLisp4-24/+5
2020-02-28gl_state: Remove blend color trackingReinUsesLisp3-18/+1
2020-02-28gl_state: Remove polygon offset trackingReinUsesLisp4-39/+7
2020-02-28gl_state: Remove alpha test trackingReinUsesLisp4-21/+4
2020-02-28gl_state: Remove cull mode trackingReinUsesLisp4-19/+4
2020-02-28gl_state: Remove front face trackingReinUsesLisp4-6/+5
2020-02-28gl_state: Remove point size trackingReinUsesLisp3-22/+4
2020-02-28gl_rasterizer: Add oglEnablei helperReinUsesLisp1-0/+4
2020-02-28gl_rasterizer: Add OpenGL enable/disable helperReinUsesLisp1-0/+4
2020-02-28gl_rasterizer: Remove dirty flagsReinUsesLisp18-457/+7
2020-02-28common/math_util: Support float type rectanglesReinUsesLisp1-2/+14
2020-02-28renderer_opengl: Fix SRGB presentation frame tracking.bunnei2-5/+2
- Fixes SRGB in Super Smash Bros. Ultimate.
2020-02-28shader_decode: Fix LD, LDG when track constant bufferNguyen Dac Nam1-4/+12
2020-02-28shader_decode: keep it search on all codeNguyen Dac Nam1-4/+12
It fixed opcode LD, LDG on Pokemon Sword that can't find the constant buffer. Not sure if it helps any on visual.
2020-02-28Create an "Advanced" tab in the graphics configuration tab and add anisotropic filtering levels.Morph16-35/+245
2020-02-28renderer_opengl: Reduce swap chain size to 3.bunnei1-3/+2
2020-02-27AM/ICommonStateGetter: Stub SetLcdBacklighOffEnabled (#3454)Morph2-2/+14
* Stub SetLcdBacklighOffEnabled Used by Super Smash Bros. Ultimate We require backlight services to be implemented to turn on/off the backlight. * Address feedback
2020-02-27shader: FMUL switch to using LUT (#3441)Nguyen Dac Nam1-19/+14
* shader: add FmulPostFactor LUT table * shader: FMUL apply LUT * Update src/video_core/engines/shader_bytecode.h Co-Authored-By: Mat M. <mathew1800@gmail.com> * nit: mistype * clang-format & add missing import * shader: remove post factor LUT. * shader: move post factor LUT to function and fix incorrect order. * clang-format * shader: FMUL: add static to post factor LUT * nit: typo Co-authored-by: Mat M. <mathew1800@gmail.com>
2020-02-27renderer_opengl: Use more concise lock syntax.bunnei1-4/+4
2020-02-27renderer_opengl: Move Frame/FrameMailbox to OpenGL namespace.bunnei3-77/+42
2020-02-26vk_swapchain: Silence TOCTOU race conditionReinUsesLisp1-9/+12
It's possible that the window is resized from the moment we ask for its size to the moment a swapchain is created, causing validation issues. To workaround this Vulkan issue request the capabilities again just before creating the swapchain, making the race condition less likely.
2020-02-26ARM_Interface: Cache the JITs instead of deleting/recreating.Fernando Sahmkow2-4/+19
This was a bug inherited from citra which was fixed by then at some time. This commit corrects such bug and ensures JITs are correctly recycled.
2020-02-26renderer_opengl: Create gl_framebuffer_data if empty.bunnei1-1/+2
2020-02-26frontend: qt: bootmanager: Acquire a shared context in main emu thread.bunnei2-12/+12
2020-02-26frontend: qt: bootmanager: Vulkan: Restore support for VK backend.bunnei5-113/+145
2020-02-26frontend: qt: bootmanager: OpenGL: Implement separate presentation thread.bunnei2-222/+254
2020-02-26frontent: qt: main: Various updates/refactoring for separate presentation thread.bunnei2-29/+27
2020-02-26core: frontend: Refactor scope_acquire_window_context to scope_acquire_context.bunnei7-29/+32
2020-02-26frontend: sdl2: emu_window: Implement separate presentation thread.bunnei10-62/+79
2020-02-26renderer_opengl: Add texture mailbox support for presenter thread.bunnei4-35/+269
2020-02-26renderer_opengl: Add OGLRenderbuffer to resource/state management.bunnei4-0/+62
2020-02-26core: frontend: emu_window: Add TextureMailbox class.bunnei1-0/+41
2020-02-26core: settings: Add setting to enable vsync, which is on by default.bunnei8-0/+25
2020-02-25video_core/surface: Add R32_SINT render target formatReinUsesLisp2-0/+3
2020-02-25video_core/gpu: Remove unused functionsReinUsesLisp2-71/+0
2020-02-24yuzu: Remove exit lock for game pausingFearlessTobi1-5/+0
This removes the "exit lock" popup from yuzu when pausing a game. Motivation The exit lock feature is broken in many ways and doesn't work properly in a lot of games, causing it to appear every time you want to pause the game or stop it, even in places where it wouldn't on Switch. Additionally, the feature of pausing a game doesn't exist like this on Switch and yuzu should be guaranteed to be deterministic anyway, so pausing the emulation shouldn't be able to interrupt any critical processes in any way.
2020-02-24vk_shader_decompiler: Implement indexed texturesReinUsesLisp6-54/+99
Implement accessing textures through an index. It uses the same interface as OpenGL, the main difference is that Vulkan bindings are forced to be arrayed (the binding index doesn't change for stacked textures in SPIR-V).
2020-02-24shader: Simplify indexed sampler usagesReinUsesLisp2-20/+8
2020-02-24video_core: Implement more scaler attribute formatsReinUsesLisp3-4/+40
While changing this, fix assert in vk_shader_decompiler. We now know scaled formats are expected to be float in shaders attributes.
2020-02-23audio_core: interpolate: Improvements to fix audio crackling.bunnei2-23/+38
- Fixes audio crackling in Crash Team Racing Nitro-Fueled, Super Mario Odyssey, and others. - Addresses followup issues from #3310.
2020-02-22Scheduler: Inline global scheduler in Scheduler Lock.Fernando Sahmkow1-4/+2
2020-02-22Kernel: Correct pending feedback.Fernando Sahmkow1-3/+4
2020-02-22System: Expose Host thread registering routines from kernel.Fernando Sahmkow2-0/+14
2020-02-22Kernel: Address Feedback.Fernando Sahmkow6-30/+47
2020-02-22Kernel: Implement Scheduler locksFernando Sahmkow2-0/+89
2020-02-22Kernel: Implement Time Manager.Fernando Sahmkow5-1/+98
2020-02-22Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel.Fernando Sahmkow5-24/+107
2020-02-22Kernel: Make global scheduler depend on KernelCoreFernando Sahmkow4-8/+24
2020-02-22audio_core: interpolate: Fix include for climits (Linux build break).bunnei1-1/+1
2020-02-21shader/texture: Fix illegal 3D texture assertReinUsesLisp1-1/+1
Fix typo in the illegal 3D texture assert logic. We care about catching arrayed 3D textures or 3D shadow textures, not regular 3D textures.
2020-02-21nit: add const to where it need.Nguyen Dac Nam1-14/+14
2020-02-21shader: implement LOP3 fast replace for old functionNguyen Dac Nam1-36/+58
ref: https://devtalk.nvidia.com/default/topic/1070081/cuda-programming-and-performance/reverse-lut-for-lop3-lut/
2020-02-21vk_device: remove left over from other branchNguyen Dac Nam1-1/+0
2020-02-20clang-formatNguyen Dac Nam1-1/+1
2020-02-20shader_decompiler: only add StorageImageReadWithoutFormat when availableNguyen Dac Nam1-1/+4
2020-02-20video_core: memory_manager: Flush/invalidate asynchronously on Unmap.bunnei1-1/+10
- Minor perf improvement.
2020-02-19shader_decompiler: add check in case of device not support ShaderStorageImageReadWithoutFormatNguyen Dac Nam1-0/+4
2020-02-19vk_device: setup shaderStorageImageReadWithoutFormatNguyen Dac Nam1-0/+5
2020-02-19vk_device: add check for shaderStorageImageReadWithoutFormatNguyen Dac Nam1-0/+7
2020-02-19shader_conversion: I2F : add Assert for case src_size is ShortNguyen Dac Nam1-0/+3
2020-02-19fix warningNguyen Dac Nam1-1/+1
2020-02-19clang-format fixNguyen Dac Nam1-1/+1
2020-02-19shader_conversion: add conversion I2F for ShortNguyen Dac Nam1-9/+6
2020-02-19vk_shader: add Capability StorageImageReadWithoutFormatNguyen Dac Nam1-0/+1
2020-02-19httplib compatibilityBrian Clinkenbeard2-7/+7
2020-02-19vk_shader: Implement function ImageLoad (Used by Kirby Start Allies)Nguyen Dac Nam1-2/+6
Please enter the commit message for your changes. Lines starting
2020-02-18fixups mistake auto commit.Nguyen Dac Nam1-9/+0
2020-02-18Update code structureNguyen Dac Nam1-0/+7
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2020-02-18add vertex UnsignedInt size RGBANguyen Dac Nam1-0/+2
2020-02-18add eBc2SrgbBlock to formatsNguyen Dac Nam1-0/+1
2020-02-18vulkan: add DXT23_SRGBNguyen Dac Nam1-1/+1
2020-02-18renderer_vulkan: Add the rest of case for TryConvertBorderColorNguyen Dac Nam1-3/+10
2020-02-18analog_from_button get direction implementationCJBok2-5/+19
2020-02-16texture_cache: Implement layered framebuffer attachmentsReinUsesLisp8-51/+74
Layered framebuffer attachments is a feature that allows applications to write attach layered textures to a single attachment. What layer the fragments are written to is decided from the shader using gl_Layer.
2020-02-16vk_shader_decompiler: Implement Layer output attributeReinUsesLisp1-6/+30
SPIR-V's Layer is GLSL's gl_Layer. It lets the application choose from a shader stage (vertex, tessellation or geometry) which framebuffer layer write the output fragments to.
2020-02-16texture_cache: Avoid matches in 3D texturesReinUsesLisp1-8/+11
Code before this commit was trying to match 3D textures with another target. Fix that.
2020-02-16surface_base: Implement texture buffer flushesReinUsesLisp2-0/+11
Implement downloads to guest memory from texture buffers on the generic cache and OpenGL.
2020-02-16IUserLocalCommunicationService: add function Initialize2Nguyen Dac Nam1-1/+9
2020-02-16HLE: correct function name of IUserLocalCommunicationServiceNguyen Dac Nam1-1/+1
402: function name should be Initialize2 (7.0.0+) not SetOperationMode Follow by: https://switchbrew.org/wiki/LDN_services#IUserLocalCommunicationService
2020-02-16nvhost_gpu: implement ChannelSetTimeslicenamkazy2-0/+20
2020-02-15Revert "video_core: memory_manager: Use GPU interface for cache functions."bunnei3-9/+14
2020-02-15texture: Implement R32IReinUsesLisp6-34/+46
2020-02-15shader/texture: Allow 2D shadow arrays and simplify codeReinUsesLisp1-43/+28
Shadow sampler 2D arrays are supported on OpenGL, so there's no reason to forbid these. Enable textureLod usage on these. Minor style changes.
2020-02-14maxwell_3d: Unify draw methodsReinUsesLisp6-36/+6
Pass instanced state of a draw invocation as an argument instead of having two separate virtual methods.
2020-02-14query_cache: Address feedbackReinUsesLisp2-16/+18
2020-02-14query_cache: Fix ambiguity in CacheAddr getterReinUsesLisp1-4/+5
2020-02-14query_cache: Add a recursive mutex for concurrent usageReinUsesLisp1-0/+6
2020-02-14vk_query_cache: Implement generic query cache on VulkanReinUsesLisp11-20/+327
2020-02-14query_cache: Abstract OpenGL implementationReinUsesLisp4-339/+394
Abstract the current OpenGL implementation into the VideoCommon namespace and reimplement it on top of that. Doing this avoids repeating code and logic in the Vulkan implementation.
2020-02-14gl_query_cache: Optimize query cacheReinUsesLisp6-79/+217
Use a custom cache instead of relying on a ranged cache.
2020-02-14gl_query_cache: Implement host queries using a deferred cacheReinUsesLisp7-86/+328
Instead of waiting immediately for executed commands, defer the query until the guest CPU reads it. This way we get closer to what the guest program is doing. To archive this we have to build a dependency queue, because host APIs (like OpenGL and Vulkan) use ranged queries instead of counters like NVN. Waiting for queries implicitly uses fences and this requires a command being queued, otherwise the driver will lock waiting until a timeout. To fix this when there are no commands queued, we explicitly call glFlush.
2020-02-14gl_rasterizer: Sort method declarationsReinUsesLisp1-16/+15
2020-02-14gl_rasterizer: Add queued commands counterReinUsesLisp2-0/+16
Keep track of the queued OpenGL commands that can signal a fence if waited on. As a side effect, we avoid calls to glFlush when no commands are queued.
2020-02-14maxwell_3d: Slow implementation of passed samples (query 21)ReinUsesLisp8-17/+201
Implements GL_SAMPLES_PASSED by waiting immediately for queries.
2020-02-14Add 4:3 aspect ratio and address feedbackMorph5-12/+20
2020-02-14Core: Correct compilition in GCCFernando Sahmkow1-0/+2
2020-02-14Address feedbackMorph2-18/+26
2020-02-14Use enumeration instead of magic numbersMorph2-5/+11
2020-02-14Add following aspect ratios: 16:9, 21:9, Stretch to WindowMorph9-2/+62
Available as a drop down within the configure graphics tab.
2020-02-14gl_resource_manager: Add managed query classReinUsesLisp2-0/+42
2020-02-14gl_rasterizer: Use the least generic OpenGL draw function possibleReinUsesLisp1-8/+28
This may help some implementations.
2020-02-14vk_shader_decompiler: Fix vertex id and instance idReinUsesLisp1-4/+13
Vulkan's VertexIndex and InstanceIndex don't match with hardware. This is because Nvidia implements gl_VertexID and gl_InstanceID. The math that relates these is: gl_VertexIndex = gl_BaseVertex + gl_VertexID gl_InstanceIndex = gl_InstanceIndex + gl_InstanceID To emulate it using what Vulkan's SPIR-V offers (the *Index variants) this commit substracts gl_Base* from gl_*Index to obtain the OpenGL and hardware's equivalent.
2020-02-14Core: Address FeedbackFernando Sahmkow6-24/+50
2020-02-13GPU: Address Feedback.Fernando Sahmkow2-11/+10
2020-02-12address_arbiter: Collapse loops in InsertThread() and RemoveThread()Lioncash1-19/+17
Same behavior, but without the need to explicitly loop through everything manually.
2020-02-12address_arbiter: Simplify GetThreadsWaitingOnAddress()Lioncash2-10/+9
Simplifies the overall function and also allows for it to become a const-qualified member function.
2020-02-12bcat/backend: Make formatting of passphrase consistent in NullBackend::SetPassphrase()Lioncash1-1/+1
Aligns the '=' to be consistent with the rest of the logs within this source file.
2020-02-12bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear()Lioncash1-1/+1
A formatting specifier within Clear wasn't being used, which will cause fmt to throw an exception. This fixes that.
2020-02-12kernel/thread: Remove trivial usages of the global system accessorLioncash1-2/+2
We can just use the kernel member variable directly instead of going through the system to obtain the same thing.
2020-02-12Core: Set all hardware emulation constants in a single file.Fernando Sahmkow17-53/+88
2020-02-11Kernel: Refactor synchronization to better match REFernando Sahmkow23-80/+212
2020-02-11update hwopus DecodeInterleaved for FW 7.0.0+makigumo1-2/+4
trivial change, see https://switchbrew.org/wiki/Audio_services#IHardwareOpusDecoder
2020-02-11Kernel: Change WaitObject to Synchronization object. In order to better reflect RE.Fernando Sahmkow22-98/+110
2020-02-10GPU: Implement GPU Clock correctly.Fernando Sahmkow3-2/+17
2020-02-10Maxwell3D: Correct query reporting.Fernando Sahmkow2-51/+58
2020-02-09Remove option "Show files with type 'Unknown'"Morph5-15/+1
2020-02-08hle: services: Use std::shared_ptr instead of copy by value.bunnei9-50/+52
2020-02-08gpu_thread: Use MPSCQueue for GPU commands.bunnei1-1/+1
- Necessary for multiple service threads.
2020-02-08video_core: memory_manager: Use GPU interface for cache functions.bunnei3-14/+9
2020-02-06kernel: transfer_memory: Properly reserve and reset memory region.bunnei5-40/+116
2020-02-06wait_object: Make wait behavior only require one object to signal.Zach Hilman1-11/+2
- This was holdover from citra.
2020-02-06am: Correct IPC object count mismatch.bunnei1-6/+4
2020-02-06services: am: Clear events on PopOutData and PopInteractiveOutData.bunnei1-0/+2
2020-02-06am: Refactor IStorage interface.bunnei7-43/+81
2020-02-06applets: software_keyboard: Signal state change on end of interactive session.bunnei1-0/+1
2020-02-06applets: software_keyboard: Minor cleanup.bunnei1-2/+2
2020-02-06services: prepo: Fix IPC interface with SaveReport/SaveReportWithUser.bunnei1-15/+15
2020-02-06hle_ipc: Add error checking to read/write buffer access.bunnei1-8/+42
2020-02-05shader/decode: Fix constant buffer offsetsReinUsesLisp3-5/+5
Some instances were using cbuf34.offset instead of cbuf34.GetOffset(). This returned the an invalid offset. Address those instances and rename offset to "shifted_offset" to avoid future bugs.
2020-02-05maxwell_to_gl: Implement R8G8_USCALEDReinUsesLisp1-0/+8
2020-02-05maxwell_to_gl: Reduce unimplemented formats to LOG_ERRORReinUsesLisp1-8/+4
2020-02-04vk_rasterizer: Use noexcept variants of std::bitsetReinUsesLisp1-4/+5
Removes bounds checking from "texceptions" instances.
2020-02-04gl_rasterizer: Implement GL_POINT_SPRITEReinUsesLisp4-1/+9
OpenGL core defaults to GL_POINT_SPRITE, meanwhile on OpenGL compatibility we have to explicitly enable it. This fixes gl_PointCoord's behaviour.
2020-02-03input_common/udp: Ensure that UDP is shut down within Shutdown()Lioncash1-0/+1
Previously the UDP backend would never actually get shut down.
2020-02-03input_common/udp: Add missing override specifiersLioncash1-2/+2
Prevents trivial warnings and ensures interfaces are properly maintained between the base class.
2020-02-03input_common/udp: std::move SocketCallback instances where applicableLioncash1-2/+2
std::function is allowed to heap allocate if the size of the captures associated with each lambda exceed a certain threshold. This prevents potentially unnecessary reallocations from occurring.
2020-02-03input_common/udp: std::move shared_ptr within Client constructorLioncash1-1/+1
Gets rid of a trivially avoidable atomic reference count increment and decrement.
2020-02-03udp/client: Replace deprecated from_string() call with make_address_v4()Lioncash1-2/+2
Future-proofs code if boost is ever updated.
2020-02-03input_common/udp: Silence -Wreorder warning for SocketLioncash1-4/+3
Amends the constructor initializer list to specify the order of its elements in the same order that initialization would occur.
2020-02-03input_common/udp: Remove unnecessary inclusionsLioncash4-8/+4
2020-02-03input_common/udp: Add missing header guardLioncash1-0/+2
2020-02-02maxwell_3d: Fix stencil back maskReinUsesLisp1-3/+3
2020-02-02shader: Remove curly braces initializers on shared pointersReinUsesLisp5-12/+12
2020-02-02shader/shift: Implement SHIFT_RIGHT_{IMM,R}ReinUsesLisp1-26/+58
Shifts a pair of registers to the right and returns the low register.
2020-02-02shader/shift: Implement SHF_LEFT_{IMM,R}ReinUsesLisp2-10/+89
Shifts a pair of registers to the left and returns the high register.
2020-01-31Revert "system_archive: Fix Korean and Chinese fonts"bunnei5-880167/+27164
2020-01-31core/arm: Remove usage of global GetCurrentThread()Lioncash2-2/+4
Now both CPU backends go through their referenced system instance to obtain the current thread.
2020-01-31kernel/physical_core: Make use of std::unique_ptrLioncash2-4/+10
shared_ptr was used in 2d1984c20c75e03ec79eeb3806b12efa1679b977 due to a misunderstanding of how the language generates move constructors and move assignment operators. If a destructor is user-provided, then the compiler won't generate the move constructor and move assignment operators by default--they must be explicitly opted into. The reason for the compilation errors is due to the fact that the language will fall back to attempting to use the copy constructor/copy assignment operators if the respective move constructor or move assignment operator is unavailable. Given that we explicitly opt into them now, the the move constructor and move assignment operators will be generated as expected.
2020-01-31core/cpu_manager: Remove unused includesLioncash1-2/+0
Nothing from these headers are used within this source file, so we can remove them.
2020-01-31kernel/physical_core: Remove unused kernel reference member variableLioncash3-11/+7
This isn't used within the class, so it can be removed to simplify the overall interface. While we're in the same area, we can simplify a unique_ptr reset() call.
2020-01-30gl_rasterizer: Fix instanced draw arraysReinUsesLisp2-106/+28
glDrawArrays was being used when the draw had a base instance specified. This commit removes the draw parameters abstraction and fixes the mentioned issue.
2020-01-29yuzu/bootmanager: Define Vulkan widget only when enabledReinUsesLisp1-0/+2
2020-01-29yuzu_cmd: Fix memcpy on Vulkan handlersReinUsesLisp2-9/+10
2020-01-29yuzu: Implement Vulkan frontendReinUsesLisp24-171/+1089
Adds a Qt and SDL2 frontend for Vulkan. It also finishes the missing bits on Vulkan initialization.
2020-01-29web_service/telemetry_json: Report USER_CONFIGReinUsesLisp1-0/+1
2020-01-29settings: Add settings for graphics backendReinUsesLisp6-3/+48
2020-01-29core: Only wait for idle on gpu_core when it was initializedReinUsesLisp1-1/+3
This fixes crashes when a Vulkan device fails to initialize.
2020-01-29shader/other: Fix skips for SYNC and BRKReinUsesLisp1-2/+2
2020-01-29shader/other: Stub S2R LaneIdReinUsesLisp1-1/+4
2020-01-29buffer_cache: Delay buffer destructionsReinUsesLisp1-1/+4
Delay buffer destruction some extra frames to avoid destroying buffers that are still being used from older frames. This happens on Nvidia's driver with mailbox.
2020-01-29clangCJBok1-2/+2
2020-01-29minor correctionsCJBok1-2/+2
2020-01-28GUI: Togglable graphics settings buttons in status barCJBok2-7/+95
2020-01-28gl_shader_decompiler: Remove UNIMPLEMENTED for gl_PointSizeReinUsesLisp1-1/+0
This was implemented by a previous commit and it's no longer required.
2020-01-28gl_texture_cache: Silence implicit sign cast warningsReinUsesLisp1-3/+6
2020-01-27System: Address FeedbackFernando Sahmkow11-24/+30
2020-01-27shader/bfi: Implement register-constant buffer variantReinUsesLisp2-2/+7
It's the same as the variant that was implemented, but it takes the operands from another source.
2020-01-27shader/arithmetic: Implement FCMPReinUsesLisp2-1/+17
Compares the third operand with zero, then selects between the first and second.
2020-01-27texture_cache/surface_base: Fix layered break downReinUsesLisp1-1/+1
Layered break downs was passing "layer" as a "depth" parameter. This commit addresses that.
2020-01-27gl_texture_cache: Properly implement depth/stencil samplingReinUsesLisp1-4/+27
This addresses the long standing issue of compatibility vs. core profiles on OpenGL, properly implementing depth vs. stencil sampling depending on the texture swizzle.
2020-01-26System: Correct PrepareReschedule.Fernando Sahmkow1-1/+1
2020-01-26Kernel: Remove a few global instances from the kernel.Fernando Sahmkow2-2/+2
2020-01-26Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager.Fernando Sahmkow15-128/+115
This commit instends on better naming the new purpose of this classes.
2020-01-26ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce.Fernando Sahmkow3-16/+24
2020-01-26shader/memory: Implement ATOM.ADDReinUsesLisp5-39/+86
ATOM operates atomically on global memory. For now only add ATOM.ADD since that's what was found in commercial games. This asserts for ATOM.ADD.S32 (handling the others as unimplemented), although ATOM.ADD.U32 shouldn't be any different. This change forces us to change the default type on SPIR-V storage buffers from float to uint. We could also alias the buffers, but it's simpler for now to just use uint. While we are at it, abstract the code to avoid repetition.
2020-01-25Core: Refactor CPU Management.Fernando Sahmkow10-224/+168
This commit moves ARM Interface and Scheduler handling into the kernel.
2020-01-25Shader_IR: Address feedback.Fernando Sahmkow10-36/+40
2020-01-25shader/memory: Implement STL.S16 and STS.S16ReinUsesLisp1-3/+10
2020-01-25shader/memory: Implement unaligned LDL.S16 and LDS.S16ReinUsesLisp1-5/+3
2020-01-25shader/memory: Move unaligned load/store to functionsReinUsesLisp1-18/+27
2020-01-25shader/memory: Implement LDL.S16 and LDS.S16ReinUsesLisp1-12/+23
2020-01-25bsd: Stub several more functions.bunnei2-4/+48
- Required for Little Town Hero to boot further.
2020-01-24Disable clang-format for font filesFearlessTobi3-0/+6
2020-01-24Shader_IR: Change name of TrackSampler function so it does not confuse with the type.Fernando Sahmkow3-7/+10
2020-01-24Shader_IR: Corrections, styling and extras.Fernando Sahmkow1-2/+4
2020-01-24Shader_IR: Correct Custom Variable assignment.Fernando Sahmkow2-0/+4
2020-01-24Shader_IR: Propagate bindless index into the GL compiler.Fernando Sahmkow5-24/+54
2020-01-24Shader_IR: Implement Injectable Custom Variables to the IR.Fernando Sahmkow5-1/+70
2020-01-24GL Backend: Introduce indexed samplers into the GL backendFernando Sahmkow2-10/+39
2020-01-24Shader_IR: deduce size of indexed samplersFernando Sahmkow4-8/+60
2020-01-24Shader_IR: Setup Indexed Samplers on the IRFernando Sahmkow1-20/+46
2020-01-24Shader_IR: Implement initial code for tracking indexed samplers.Fernando Sahmkow4-0/+139
2020-01-24Shader_IR: Address FeedbackFernando Sahmkow5-35/+37
2020-01-24Shader_IR: Allow constant access of guest driver.Fernando Sahmkow7-1/+18
2020-01-24Shader_IR: Address FeedbackFernando Sahmkow4-21/+29
2020-01-24Guest_driver: Correct compiling errors in GCC.Fernando Sahmkow2-1/+5
2020-01-24Shader_IR: Store Bound buffer on Shader UsageFernando Sahmkow5-5/+41
2020-01-24GPU: Implement guest driver profile and deduce texture handler sizes.Fernando Sahmkow13-0/+127
2020-01-24Kernel: Implement Physical Core.Fernando Sahmkow2-0/+81
2020-01-24vk_shader_decompiler: Disable default values on unwritten render targetsReinUsesLisp3-19/+16
Some games like The Legend of Zelda: Breath of the Wild assign render targets without writing them from the fragment shader. This generates Vulkan validation errors, so silence these I previously introduced a commit to set "vec4(0, 0, 0, 1)" for these attachments. The problem is that this is not what games expect. This commit reverts that change.
2020-01-24audio_core: Switch to a faster interpolation techniqueFearlessTobi2-48/+159
2020-01-24yuzu/configuration: create UI tab and move gamelist settings thereFearlessTobi8-104/+76
2020-01-23common/logging: don't use regex for path trimmingBreadFish644-36/+23
2020-01-23Replace GetString with Get functionFearlessTobi1-2/+2
This should hopefully fix compilation errors.
2020-01-23Address second part of review commentsFearlessTobi4-14/+18
2020-01-23Address review commentsFearlessTobi4-65/+72
2020-01-23Input: UDP Client to provide motion and touch controlsfearlessTobi13-4/+897
An implementation of the cemuhook motion/touch protocol, this adds the ability for users to connect several different devices to citra to send direct motion and touch data to citra. Co-Authored-By: jroweboy <jroweboy@gmail.com>
2020-01-23service: time: Implement ToPosixTimeWithMyRule.bunnei4-1/+34
- Used by Pokemon Mystery Dungeon.
2020-01-23loader: provide default arguments (zero byte) to NSOsMichael Scire2-3/+10
Certain newer unity games (Terraria, Pokemon Mystery Dungeon) require that the argument region be populated. Failure to do so results in an integer underflow in argument count, and eventually an unmapped read at 0x800000000. Providing this default fixes this. Note that the behavior of official software is as yet unverified, arguments-wise.
2020-01-22GUI: fix minor issues with dark themesBartosz Kaszubowski1-3/+3
GUI: rename and reorder themes
2020-01-21gl_shader_cache: Disable fastmath on NvidiaReinUsesLisp1-0/+4
2020-01-20vk_blit_screen: Address feedbackReinUsesLisp4-22/+25
2020-01-20time: Fix month off-by-one error.bunnei1-2/+2
- Fixes timestamp in ZLA and Astral Chain saves.
2020-01-20yuzu_qt: config: Move audio to its own tab.bunnei1-3/+3
- We have some important audio settings, makes them more discoverable.
2020-01-20vk_blit_screen: Initial implementationReinUsesLisp3-0/+745
This abstraction takes care of presenting accelerated and non-accelerated or "framebuffer" images to the Vulkan swapchain.
2020-01-19GUI/gamelist: add "None" as an option for second row and remove dynamically duplicate row options (#3309)Bartosz Kaszubowski3-14/+53
* GUI/gamelist: add "None" as an option for second row and remove duplicated row options * fix clang-format warnings
2020-01-19vk_shader_decompiler: Implement UAtomicAdd (ATOMS) on SPIR-VReinUsesLisp1-3/+11
Also updates sirit to include atomic instructions.
2020-01-19system_archive: Fix Chinese fontFearlessTobi2-13582/+694524
Adds the proper OSS font for the Chinese language.
2020-01-19system_archive: Fix Korean fontFearlessTobi2-13582/+185637
Fixes Korean fonts when using Open-source system archives.
2020-01-19CMake: Create thin archives on LinuxLéo Lam1-0/+9
This significantly reduces unnecessary disk writes and space usage when building Citra. libcore.a is now only ~1MB rather than several hundred megabytes.
2020-01-18gl_state: Use bool instead of GLbooleanReinUsesLisp2-3/+3
This fixes template resolution considering GLboolean an integer instead of a bool.
2020-01-18vk_graphics_pipeline: Set front facing properlyReinUsesLisp2-2/+2
Front face was being forced to a certain value when cull face is disabled. Set a default value on initialization and drop the forcefully set front facing value with culling disabled.
2020-01-18core/memory: Create a special MapMemoryRegion for physical memory.Markus Wick4-4/+31
This allows us to create a fastmem arena within the memory.cpp helpers.
2020-01-18core/hle: Simplify PhysicalMemory usage in vm_manager.Markus Wick1-23/+11
2020-01-18core/loaders: Simplify PhysicalMemory usage.Markus Wick3-8/+12
It is currently a std::vector, however we might want to replace it with a more fancy allocator. So we can't use the C++ iterators any more.
2020-01-18Remove unused CPU Vendor string and telemtry fieldJames Rowe3-114/+0
The information is duplicated in the brand string and the telemetry field is unused
2020-01-18vk_rasterizer: Address feedbackReinUsesLisp2-25/+32
2020-01-18gl_shader_decompiler: Fix decompilation of condition codesReinUsesLisp1-27/+5
Use Visit instead of reimplementing it. Fixes unimplemented negations for condition codes.
2020-01-18Add headbar icon on LinuxTotalCaesar6591-1/+1
2020-01-17vk_rasterizer: Implement Vulkan's rasterizerReinUsesLisp3-1/+1386
This abstraction is Vulkan's equivalent to OpenGL's rasterizer. It takes care of joining all parts of the backend and rendering accordingly on demand.
2020-01-17renderer_vulkan: Add header as placeholderReinUsesLisp2-0/+73
2020-01-16vk_texture_cache: Address feedbackReinUsesLisp2-22/+8
2020-01-16shader/memory: Implement ATOMS.ADD.U32ReinUsesLisp5-3/+74
2020-01-16format_lookup_table: Fix ZF32_X24S8 component typesReinUsesLisp1-1/+1
Component types for ZF32_X24S8 were using UNORM. Drivers will set FLOAT, UINT, UNORM, UNORM; causing a format mismatch. This commit addresses that.
2020-01-16vk_texture_cache: Fix typo in commentaryRodrigo Locatti1-1/+1
Co-Authored-By: MysticExile <30736337+MysticExile@users.noreply.github.com>
2020-01-16maxwell_3d: Make dirty_pointers privateLioncash1-2/+2
This isn't used outside of the class itself, so we can make it private for the time being.
2020-01-16Fix git version in scm_rev.cppJames Rowe1-0/+5
2020-01-15gl_state: Implement PROGRAM_POINT_SIZEReinUsesLisp4-2/+13
For gl_PointSize to have effect we have to activate GL_PROGRAM_POINT_SIZE.
2020-01-15renderer_opengl/utils: Remove unused header inclusionsLioncash1-3/+0
Nothing from these headers are used, so they can be removed.
2020-01-15renderer_opengl/utils: Forward declare private structsLioncash2-12/+16
Keeps the definitions hidden and allows changes to the structs without needing to recompile all users of classes containing said structs.
2020-01-15Moved analog direction logic to sdl_implCJBok3-9/+48
2020-01-14Corrected directional states sensitivityCJBok1-9/+9
2020-01-14gl_texture_cache: Use local variables to simplify DownloadTextureReinUsesLisp1-6/+4
2020-01-14gl_texture_cache: Fix format for RGBX16FReinUsesLisp1-1/+1
2020-01-14gl_texture_cache: Use Snorm internal format for RG8SReinUsesLisp1-1/+1
2020-01-14gl_texture_cache: Use Snorm internal format for ABGR8SReinUsesLisp1-1/+1
2020-01-14control_flow: Silence -Wreorder warning for CFGRebuildStateLioncash1-1/+1
Organizes the initializer list in the same order that the variables would actually be initialized in.
2020-01-14gl_shader_cache: Remove unused STAGE_RESERVED_UBOS constantLioncash1-3/+0
Given this isn't used, this can be removed entirely.
2020-01-14gl_shader_cache: std::move entries in CachedShader constructorLioncash1-3/+4
Avoids several reallocations of std::vector instances where applicable.
2020-01-14gl_shader_cache: Remove unused entries variable in BuildShader()Lioncash1-1/+0
Eliminates a few unnecessary constructions of std::vectors.
2020-01-14vk_texture_cache: Implement generic texture cache on VulkanReinUsesLisp4-1/+733
It currently ignores PBO linearizations since these should be dropped as soon as possible on OpenGL.
2020-01-14texture_cache/surface_params: Make GetNumLayers publicReinUsesLisp1-4/+5
2020-01-13GUI: add few missing hotkeys to main menuBartosz Kaszubowski2-0/+17
2020-01-12GUI/configure: resize hotkeys column to contentBartosz Kaszubowski1-0/+1
2020-01-11core/kernel: Fix GetTotalPhysicalMemoryUsed.Markus Wick1-2/+2
module._memory was already moved over to a new shared_ptr. So code_memory_size was not increased at all. This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB. This fixes a regression of c0a01f3adc466d07fc27020048e82cca60988970
2020-01-11vk_compute_pass: Address feedbackRodrigo Locatti1-0/+2
Comment hardcoded SPIR-V modules.
2020-01-10maxwell_to_vk: Implement GL_CLAMP hacking Nvidia's driverReinUsesLisp3-6/+11
Nvidia's driver defaults invalid enumerations to GL_CLAMP. Vulkan doesn't expose GL_CLAMP through its API, but we can hack it on Nvidia's driver using the internal driver defaults.
2020-01-09shader_ir/texture: Simplify AOFFI codeReinUsesLisp1-10/+6
2020-01-09shader_ir/memory: Implement u16 and u8 for STG and LDGReinUsesLisp2-34/+52
Using the same technique we used for u8 on LDG, implement u16. In the case of STG, load memory and insert the value we want to set into it with bitfieldInsert. Then set that value.
2020-01-09hid: Fix analog sticks directional statesCJBok1-12/+12
2020-01-08vk_compute_pass: Add compute passes to emulate missing Vulkan featuresReinUsesLisp3-0/+416
This currently only supports quad arrays and u8 indices. In the future we can remove quad arrays with a table written from the CPU, but this was used to bootstrap the other passes helpers and it was left in the code. The blob code is generated from the "shaders/" directory. Read the instructions there to know how to generate the SPIR-V.
2020-01-08vk_shader_util: Add helper to build SPIR-V shadersReinUsesLisp3-0/+53
2020-01-07vk_pipeline_cache: Initial implementationReinUsesLisp2-1/+460
Given a pipeline key, this cache returns a pipeline abstraction (for graphics or compute).
2020-01-07vk_graphics_pipeline: Initial implementationReinUsesLisp4-0/+395
This abstractio represents the state of the 3D engine at a given draw. Instead of changing individual bits of the pipeline how it's done in APIs like D3D11, OpenGL and NVN; on Vulkan we are forced to put everything together into a single, immutable object. It takes advantage of the few dynamic states Vulkan offers.
2020-01-07vk_compute_pipeline: Initial implementationReinUsesLisp4-0/+219
This abstraction represents a Vulkan compute pipeline.
2020-01-07vk_pipeline_cache: Add file and define descriptor update template fillerReinUsesLisp3-0/+67
This function allows us to share code between compute and graphics pipelines compilation.
2020-01-07fixed_pipeline_state: Add depth clampReinUsesLisp2-10/+18
2020-01-07vk_rasterizer: Add placeholderReinUsesLisp2-0/+14
2020-01-06vk_renderpass_cache: Initial implementationReinUsesLisp3-0/+199
The renderpass cache is used to avoid creating renderpasses on each draw. The hashed structure is not currently optimized.
2020-01-06vk_update_descriptor: Initial implementationReinUsesLisp3-1/+146
The update descriptor is used to store in flat memory a large chunk of staging data used to update descriptor sets through templates. It provides a push interface to easily insert descriptors following the current pipeline. The order used in the descriptor update template has to be implicitly followed. We can catch bugs here using validation layers.
2020-01-06vk_stream_buffer/vk_buffer_cache: Avoid halting and use generic cacheReinUsesLisp4-62/+340
The stream buffer before this commit once it was full (no more bytes to write before looping) waiting for all previous operations to finish. This was a temporary solution and had a noticeable performance penalty in performance (from what a profiler showed). To avoid this mark with fences usages of the stream buffer and once it loops wait for them to be signaled. On average this will never wait. Each fence knows where its usage finishes, resulting in a non-paged stream buffer. On the other side, the buffer cache is reimplemented using the generic buffer cache. It makes use of the staging buffer pool and the new stream buffer.
2020-01-06vk_memory_manager: Misc changesReinUsesLisp2-88/+142
* Allocate memory in discrete exponentially increasing chunks until the 128 MiB threshold. Allocations larger thant that increase linearly by 256 MiB (depending on the required size). This allows to use small allocations for small resources. * Move memory maps to a RAII abstraction. To optimize for debugging tools (like RenderDoc) users will map/unmap on usage. If this ever becomes a noticeable overhead (from my profiling it doesn't) we can transparently move to persistent memory maps without harming the API, getting optimal performance for both gameplay and debugging. * Improve messages on exceptional situations. * Fix typos "requeriments" -> "requirements". * Small style changes.
2020-01-06vk_buffer_cache: Temporarily remove buffer cacheReinUsesLisp2-226/+0
This is intended for a follow up commit to avoid circular dependencies.
2020-01-06yuzu/bootmanager: Remove {glx,wgl}MakeCurrent on SwapBuffersReinUsesLisp1-9/+2
MakeCurrent is a costly (according to Nsight's profiler it takes a tenth of a millisecond to complete), and we don't have a reason to call it because: - Qt no longer signals a warning if it's not called - yuzu no longer supports macOS
2020-01-05service: time: Implement GetStandardLocalSystemClock.bunnei3-1/+9
2020-01-04time: Remove overflow error checking (currently breaks ADO builds).bunnei2-18/+2
2020-01-04service: time: Implement GetClockSnapshotFromSystemClockContext.bunnei3-3/+27
2020-01-04service: time: Implement IsStandardNetworkSystemClockAccuracySufficient.bunnei5-1/+51
2020-01-04system_archive: Add a basic HLE implementation for time zone binary.bunnei4-1/+675
2020-01-04service: time: Rewrite implementation of glue services.bunnei35-444/+2834
2020-01-04Shader_IR: Address FeedbackFernando Sahmkow5-38/+19
2020-01-04core: Initialize several structs that make use of Common::UUID.bunnei5-100/+101
2020-01-04Shader_IR: Implement TXD Array.Fernando Sahmkow1-5/+12
This commit extends the compilation of TXD to support array samplers on TXD.
2020-01-04service: vi: Implement CloseLayer.bunnei5-11/+48
- Needed for Undertale.
2020-01-03Update src/video_core/renderer_vulkan/vk_descriptor_pool.cppRodrigo Locatti1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2020-01-03const correctionCJBok1-1/+1
2020-01-03clangCJBok1-22/+22
2020-01-03Update configure_input_player.cppCJBok1-23/+23
2020-01-03Added deadzone controls for sdl engine at input settingsCJBok3-24/+129
2020-01-03yuzu: Remove Maxwell debuggerReinUsesLisp14-640/+0
This was carried from Citra and wasn't really used on yuzu. It also adds some runtime overhead. This commit removes it from yuzu's codebase.
2020-01-01vk_descriptor_pool: Initial implementationReinUsesLisp3-0/+147
Create a large descriptor pool where we allocate all our descriptors from. It has to be wide enough to support any pipeline, hence its large numbers. If the descritor pool is filled, we allocate more memory at that moment. This way we can take advantage of permissive drivers like Nvidia's that allocate more descriptors than what the spec requires.
2020-01-01core/memory + arm/dynarmic: Use a global offset within our arm page table.Markus Wick2-9/+17
This saves us two x64 instructions per load/store instruction. TODO: Clean up our memory code. We can use this optimization here as well.
2019-12-30Shader_IR: add the ability to amend code in the shader ir.Fernando Sahmkow5-3/+72
This commit introduces a mechanism by which shader IR code can be amended and extended. This useful for track algorithms where certain information can derived from before the track such as indexes to array samplers.
2019-12-30vk_image: Avoid unnecesary equalsRodrigo Locatti1-1/+1
2019-12-30video_core: Block in WaitFence.Markus Wick3-5/+9
This function is called rarely and blocks quite often for a long time. So don't waste power and let the CPU sleep. This might also increase the performance as the other cores might be allowed to clock higher.
2019-12-29vk_staging_buffer_pool: Initialize last epoch to zeroRodrigo Locatti1-1/+1
2019-12-26gl_rasterizer: Allow rendering without fragment shaderReinUsesLisp2-0/+7
Rendering without a fragment shader is usually used in depth-only passes.
2019-12-25vk_staging_buffer_pool: Add a staging pool for temporary operationsReinUsesLisp3-0/+212
The job of this abstraction is to provide staging buffers for temporary operations. Think of image uploads or buffer uploads to device memory. It automatically deletes unused buffers.
2019-12-25vk_image: Add an image object abstractionReinUsesLisp3-0/+192
This object's job is to contain an image and manage its transitions. Since Nvidia hardware doesn't know what a transition is but Vulkan requires them anyway, we have to state track image subresources individually. To avoid the overhead of tracking each subresource in images with many subresources (think of cubemap arrays with several mipmaps), this commit tracks when subresources have diverged. As long as this doesn't happen we can check the state of the first subresource (that will be shared with all subresources) and update accordingly. Image transitions are deferred to the scheduler command buffer.
2019-12-25NvServices: Correct Ioctl Remap.Fernando Sahmkow2-3/+5
This commit corrects a padding value in Ioctl Remap that was actually an offset to the mapping address.
2019-12-24fixed_pipeline_state: Define symetric operator!= and mark as noexceptReinUsesLisp2-40/+92
Marks as noexcept Hash, operator== and operator!= for consistency.
2019-12-23fixed_pipeline_state: Define structure and loadersReinUsesLisp3-0/+528
The intention behind this hasheable structure is to describe the state of fixed function pipeline state that gets compiled to a single graphics pipeline state object. This is all dynamic state in OpenGL but Vulkan wants it in an immutable state, even if hardware can edit it freely. In this commit the structure is defined in an optimized state (it uses booleans, has paddings and many data entries that can be packed to single integers). This is intentional as an initial implementation that is easier to debug, implement and review. It will be optimized in later stages, or it might change if Vulkan gets more dynamic states.
2019-12-23maxwell_3d: Add depth bounds registersReinUsesLisp1-6/+14
2019-12-23maxwell_to_gl: Implement missing primitive topologiesReinUsesLisp1-4/+18
Many of these topologies are exclusively available in OpenGL.
2019-12-22Texture Cache: Improve documentationFernando Sahmkow2-4/+5
2019-12-22Texture Cache: Address FeedbackFernando Sahmkow2-11/+11
2019-12-22Texture Cache: Add HLE methods for building 3D textures within the GPU in certain scenarios.Fernando Sahmkow4-1/+143
This commit adds a series of HLE methods for handling 3D textures in general. This helps games that generate 3D textures on every frame and may reduce loading times for certain games.
2019-12-21gl_shader_cache: Update commentary for shared memoryReinUsesLisp1-9/+6
Remove false commentary. Not dividing by 4 the size of shared memory is not a hack; it describes the number of integers, not bytes. While we are at it sort the generated code to put preprocessor lines on the top.
2019-12-21gl_shader_cache: Remove unused entry in GetPrimitiveDescriptionReinUsesLisp1-11/+9
2019-12-21vk_shader_decompiler: Use Visit instead of reimplementing itReinUsesLisp1-23/+1
ExprCondCode visit implements the generic Visit. Use this instead of that one. As an intended side effect this fixes unwritten memory usages in cases when a negation of a condition code is used.
2019-12-20shader/p2r: Implement P2R PrReinUsesLisp1-1/+15
P2R dumps predicate or condition codes state to a register. This is useful for unit testing.
2019-12-20shader/r2p: Refactor P2R to support P2RReinUsesLisp2-17/+33
2019-12-19vk_resource_manager: Add entry to VKFence to test its usageReinUsesLisp1-0/+8
2019-12-19vk_reosurce_manager: Add assert for releasing fencesReinUsesLisp1-0/+1
Notify the programmer when a request to release a fence is invalid because the fence is already free.
2019-12-19vk_resource_manager: Implement VKFenceWatch move constructorReinUsesLisp2-0/+32
This allows us to put VKFenceWatch inside a std::vector without storing it in heap. On move we have to signal the fences where the new protected resource is, adding some overhead.
2019-12-19vk_device: Add entry to catch device lossesReinUsesLisp3-1/+40
VK_NV_device_diagnostic_checkpoints allows us to push data to a Vulkan queue and then query it even after a device loss. This allows us to push the current pipeline object and see what was the call that killed the device.
2019-12-19vk_shader_decompiler: Fix full decompilationReinUsesLisp1-3/+5
When full decompilation was enabled, labels were not being inserted and instructions were misused. Fix these bugs.
2019-12-19vk_shader_decompiler: Skip NDC correction when it is nativeReinUsesLisp2-1/+2
Avoid changing gl_Position when the NDC used by the game is [0, 1] (Vulkan's native).
2019-12-19vk_shader_decompiler: Normalize output fragment attachmentsReinUsesLisp2-12/+12
Some games write from fragment shaders to an unexistant framebuffer attachment or they don't write to one when it exists in the framebuffer. Fix this by skipping writes or adding zeroes.
2019-12-19vk_device: Add query for RGBA8UintReinUsesLisp1-0/+1
2019-12-19vk_shader_decompiler: Update sirit and implement Texture AOFFIReinUsesLisp1-22/+30
2019-12-18gl_rasterizer: Implement RASTERIZE_ENABLEReinUsesLisp6-4/+28
RASTERIZE_ENABLE is the opposite of GL_RASTERIZER_DISCARD. Implement it naturally using this. NVN games expect rasterize to be enabled by default, reflect that in our initial GPU state.
2019-12-18shader/memory: Implement LDG.U8 and unaligned U8 loadsReinUsesLisp1-6/+32
LDG can load single bytes instead of full integers or packs of integers. These have the advantage of loading bytes that are not aligned to 4 bytes. To emulate these this commit gets the byte being referenced (by doing "address & 3" and then using that to extract the byte from the loaded integer: result = bitfieldExtract(loaded_integer, (address % 4) * 8, 8)
2019-12-18shader/conversion: Implement byte selector in I2FReinUsesLisp1-2/+13
I2F's byte selector is used to choose what bytes to convert to float. e.g. if the input is 0xaabbccdd and the selector is ".B3" it will convert 0xaa. The default (when it's not shown in nvdisasm) is ".B0", in that example the default would convert 0xdd to float.
2019-12-18shader/texture: Properly shrink unused entries in size mismatchesReinUsesLisp1-4/+9
When a image format mismatches we were inserting zeroes to the texture itself. This was not handling cases were the mismatch uses less coordinates than the guest shader code. Address that by resizing the vector.
2019-12-18gl_shader_decompiler: Add missing DeclareImagesReinUsesLisp1-0/+1
2019-12-18shader_bytecode: Fix TLD4S encodingReinUsesLisp1-1/+1
2019-12-17common: SPSCQueue: Notify after incrementing queue size.bunnei1-2/+9
2019-12-16renderer_vulkan/shader: Add helper GLSL shadersReinUsesLisp4-0/+122
These shaders are used to specify code that is not dynamically generated in the Vulkan backend. Instead of packing it inside the build system, it's manually built and copied to the C++ file to avoid adding unnecessary build time dependencies. quad_array should be dropped in the future since it can be emulated with a memory pool generated from the CPU.
2019-12-16shader/texture: Implement TLD4.PTPReinUsesLisp5-56/+120
2019-12-16shader/texture: Enable arrayed TLD4ReinUsesLisp1-1/+0
2019-12-16gl_shader_decompiler: Rename "sepparate" to "separate"ReinUsesLisp1-3/+3
2019-12-16shader/texture: Implement AOFFI for TLD4SReinUsesLisp1-13/+18
2019-12-16shader/texture: Remove unnecesary parenthesisReinUsesLisp1-2/+2
2019-12-13maxwell_to_vk: Improve image format table and add more formatsReinUsesLisp2-89/+127
A1B5G5R5 uses A1R5G5B5. This is flipped with image view swizzles; flushing is still not properly implemented on Vulkan for this particular format.
2019-12-13maxwell_to_vk: Implement more vertex formatsReinUsesLisp1-7/+81
2019-12-13maxwell_to_vk: Implement more primitive topologiesReinUsesLisp2-2/+11
Add an extra argument to query device capabilities in the future. The intention behind this is to use native quads, quad strips, line loops and polygons if these are released for Vulkan.
2019-12-13maxwell_to_vk: Approach GL_CLAMP closer to the GL specReinUsesLisp3-9/+17
The OpenGL spec defines GL_CLAMP's formula similarly to CLAMP_TO_EDGE and CLAMP_TO_BORDER depending on the filter mode used. It doesn't exactly behave like this, but it's the closest we can get with what Vulkan offers without emulating it by injecting shader code.
2019-12-13maxwell_to_vk: Use VK_EXT_index_type_uint8 when availableReinUsesLisp2-4/+7
2019-12-13vk_scheduler: Delegate commands to a worker thread and state trackReinUsesLisp2-37/+311
Introduce a worker thread approach for delegating Vulkan work derived from dxvk's approach. https://github.com/doitsujin/dxvk Now that the scheduler is what handles all Vulkan work related to command streaming, store state tracking in itself. This way we can know when to reupload Vulkan dynamic state to the queue (since this one is invalidated between command buffers unlike NVN). We can also store the renderpass state and graphics pipeline bound to avoid redundant binds and renderpass begins/ends.
2019-12-12Shader_IR: Correct TLD4S Depth Compare.Fernando Sahmkow2-9/+16
2019-12-12Shader_Ir: Correct TLD4S encoding and implement f16 flag.Fernando Sahmkow3-11/+15
2019-12-12Gl_Shader_compiler: Correct Depth Compare for Texture Gather operations.Fernando Sahmkow1-8/+21
2019-12-12Shader_Ir: default failed tracks on bindless samplers to null values.Fernando Sahmkow2-24/+77
2019-12-11Gl_Rasterizer: Skip Tesselation Control and Eval stages as they are un implemented.Fernando Sahmkow1-0/+8
This commit ensures the OGL backend does not execute tesselation shader stages as they are currently unimplemented.
2019-12-11Added missing includeJoel Holdsworth1-0/+1
2019-12-11Kernel: Correct behavior of Address Arbiter threads. (#3165)Fernando Sahmkow3-24/+67
* Kernel: Correct behavior of Address Arbiter threads. This corrects arbitration threads to behave just like in Horizon OS. They are added into a container and released according to what priority they had when added. Horizon OS does not reorder them if their priority changes. * Kernel: Address Feedback.
2019-12-11kernel/svc: Correct function signature of SignalProcessWideKeyLioncash2-9/+6
This function doesn't actually return a result code, so we can amend the signature of it to match.
2019-12-11gl_device: Enable compute shaders for Intel Mesa driversReinUsesLisp1-1/+4
Previously we naively checked for "Intel" in GL_VENDOR, but this includes both Intel's proprietary driver and the mesa driver. Re-enable compute shaders for mesa.
2019-12-11gl_shader_cache: Add missing new-line on emitted GLSLReinUsesLisp1-2/+2
Add missing new-line. This caused shaders using local memory and shared memory to inject a preprocessor GLSL line after an expression (resulting in invalid code). It looked like this: shared uint smem[8];#define LOCAL_MEMORY_SIZE 16 It should look like this (addressed by this commit): shared uint smem[8]; \#define LOCAL_MEMORY_SIZE 16
2019-12-11Maxwell3D: Implement Depth Mode.Fernando Sahmkow4-8/+15
This commit finishes adding depth mode that was reverted before due to other unresolved issues.
2019-12-10shader: Implement MEMBAR.GLReinUsesLisp5-1/+46
Implement using memoryBarrier in GLSL and OpMemoryBarrier on SPIR-V.
2019-12-10vk_shader_decompiler: Fix build issues on old gcc versionsReinUsesLisp1-2/+3
2019-12-10vk_shader_decompiler: Reduce YNegate's severityReinUsesLisp1-1/+1
2019-12-10shader_ir/other: Implement S2R InvocationIdReinUsesLisp4-0/+9
2019-12-10vk_shader_decompiler: Misc changesReinUsesLisp2-697/+1648
Update Sirit and its usage in vk_shader_decompiler. Highlights: - Implement tessellation shaders - Implement geometry shaders - Implement some missing features - Use native half float instructions when available.
2019-12-10shader: Keep track of shaders using warp instructionsReinUsesLisp2-0/+8
2019-12-10shader_ir/memory: Implement patch storesReinUsesLisp4-20/+38
2019-12-09vk_device: Misc changesReinUsesLisp2-117/+276
- Setup more features and requirements. - Improve logging for missing features. - Collect telemetry parameters. - Add queries for more image formats. - Query push constants limits. - Optionally enable some extensions.
2019-12-09externals: Update Vulkan-HeadersReinUsesLisp2-2/+14
2019-12-08kernel: Remove unnecessary includesLioncash15-11/+17
Over the course of the changes to the kernel code, a few includes are no longer necessary, particularly with the change over to std::shared_ptr from Boost's intrusive_ptr.
2019-12-08kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNewLioncash2-2/+24
These are fairly trivial to implement, we can just do nothing. This also provides a spot for us to potentially dump out any relevant info in the future (e.g. for debugging purposes with homebrew, etc). While we're at it, we can also correct the names of both of these supervisor calls.
2019-12-07vk_swapchain: Add support for swapping sRGBReinUsesLisp2-24/+31
We don't know until the game is running if it's using an sRGB color space or not. Add support for hot-swapping swapchain surface formats.
2019-12-07maxwell_3d: Add tessellation tess level registersReinUsesLisp1-1/+6
2019-12-07maxwell_3d: Add tessellation mode registerReinUsesLisp1-1/+28
2019-12-07maxwell_3d: Add patch vertices registerReinUsesLisp1-1/+4
2019-12-07shader_bytecode: Remove corrupted characterReinUsesLisp1-1/+1
2019-12-05CpuCore: Clear exclusive state after doing a run in dynarmic.Fernando Sahmkow2-1/+2
This commit corrects an error in which a Core could remain with an exclusive state after running, leaving space for possible race conditions between changing cores.
2019-12-02telemetry_session: Report renderer backendReinUsesLisp1-0/+1
We only have OpenGL as an option for now. Hardcode the entry.
2019-12-02telemetry_session: Use temporary to avoid writing the same enumReinUsesLisp1-16/+11
2019-11-29texture_cache/surface_base: Fix out of bounds texture viewsReinUsesLisp1-7/+4
Some texture views were being created out of bounds (with more layers or mipmaps than what the original texture has). This is because of a miscalculation in mipmap bounding. end_layer and end_mipmap are out of bounds (e.g. layer 6 in a cubemap), there's no need to add one more there. Fixes OpenGL errors and Vulkan crashes on Splatoon 2.
2019-11-29gl_framebuffer_cache: Optimize framebuffer keyReinUsesLisp3-46/+60
Pack color attachment enumerations into a single u32. To determine the number of buffers, the highest color attachment with a shared pointer that doesn't point to null is used.
2019-11-29gl_rasterizer: Re-enable framebuffer cache for clear buffersReinUsesLisp3-32/+15
2019-11-29renderer_opengl: Make ScreenRectVertex's constructor constexprReinUsesLisp1-12/+7
2019-11-29renderer_opengl: Remove C castsReinUsesLisp1-4/+5
2019-11-29renderer_opengl: Use explicit binding for presentation shadersReinUsesLisp2-34/+20
2019-11-29renderer_opengl: Drop macros for message decorationsReinUsesLisp1-21/+26
2019-11-29renderer_opengl: Move static definitions to anonymous namespaceReinUsesLisp1-62/+66
2019-11-29renderer_opengl: Move commentaries to header fileReinUsesLisp2-20/+13
2019-11-28kernel: Implement a more accurate IPC dispatch.bunnei19-167/+246
2019-11-28patch_manager: Adds check for disabled cheats to prevent them from being enabled (#3178)Morph1-5/+11
* Adds check for disabled cheats to prevent them from being added to the CheatList * Address feedback
2019-11-27video_core/gpu_thread: Tidy up SwapBuffers()Lioncash1-2/+1
We can just use std::nullopt and std::make_optional to make this a little bit less noisy.
2019-11-27video_core/const_buffer_locker: Make use of std::tie in HasEqualKeys()Lioncash1-2/+3
Tidies it up a little bit visually.
2019-11-27video_core/const_buffer_locker: Remove unused includesLioncash2-2/+2
2019-11-27video_core/const_buffer_locker: Remove #pragma once from cpp fileLioncash1-2/+0
Silences a compiler warning.
2019-11-27filesys/romfs: Remove unused includesLioncash2-4/+2
These inclusions aren't used at all within the public interface, so they can be removed.
2019-11-27filesys/romfs: Make ProcessFile and ProcessDirectory internally linkedLioncash1-2/+3
These functions aren't used outside of this file, so we can place them within an anonymous namespace.
2019-11-27file_sys/directory: Make EntryType an enum classLioncash2-3/+3
This can trivially be an enum class rather than a regular enum, making it more strongly typed.
2019-11-27core/memory; Migrate over SetCurrentPageTable() to the Memory classLioncash3-26/+34
Now that literally every other API function is converted over to the Memory class, we can just move the file-local page table into the Memory implementation class, finally getting rid of global state within the memory code.
2019-11-27core/memory: Migrate over GetPointerFromVMA() to the Memory classLioncash1-36/+36
Now that everything else is migrated over, this is essentially just code relocation and conversion of a global accessor to the class member variable. All that remains is to migrate over the page table.
2019-11-27core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory classLioncash14-153/+298
The Write functions are used slightly less than the Read functions, which make these a bit nicer to move over. The only adjustments we really need to make here are to Dynarmic's exclusive monitor instance. We need to keep a reference to the currently active memory instance to perform exclusive read/write operations.
2019-11-27core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory classLioncash19-178/+305
With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.
2019-11-27core/memory: Migrate over ZeroBlock() and CopyBlock() to the Memory classLioncash2-91/+161
These currently aren't used anywhere in the codebase, so these are very trivial to move over to the Memory class.
2019-11-27core/memory: Migrate over RasterizerMarkRegionCached() to the Memory classLioncash3-70/+79
This is only used within the accelerated rasterizer in two places, so this is also a very trivial migration.
2019-11-27core/memory: Migrate over ReadCString() to the Memory classLioncash3-18/+40
This only had one usage spot, so this is fairly straightforward to convert over.
2019-11-27core/memory: Migrate over GetPointer()Lioncash7-25/+53
With all of the interfaces ready for migration, it's trivial to migrate over GetPointer().
2019-11-27core: Prepare various classes for memory read/write migrationLioncash24-61/+108
Amends a few interfaces to be able to handle the migration over to the new Memory class by passing the class by reference as a function parameter where necessary. Notably, within the filesystem services, this eliminates two ReadBlock() calls by using the helper functions of HLERequestContext to do that for us.
2019-11-27core/memory: Move memory read/write implementation functions into an anonymous namespaceLioncash1-97/+98
These will eventually be migrated into the main Memory class, but for now, we put them in an anonymous namespace, so that the other functions that use them, can be migrated over separately.
2019-11-27core/memory: Migrate over address checking functions to the new Memory classLioncash6-39/+70
A fairly straightforward migration. These member functions can just be mostly moved verbatim with minor changes. We already have the necessary plumbing in places that they're used. IsKernelVirtualAddress() can remain a non-member function, since it doesn't rely on class state in any form.
2019-11-27core/memory: Migrate over memory mapping functions to the new Memory classLioncash6-128/+180
Migrates all of the direct mapping facilities over to the new memory class. In the process, this also obsoletes the need for memory_setup.h, so we can remove it entirely from the project.
2019-11-27core/memory: Introduce skeleton of Memory classLioncash4-3/+56
Currently, the main memory management code is one of the remaining places where we have global state. The next series of changes will aim to rectify this. This change simply introduces the main skeleton of the class that will contain all the necessary state.
2019-11-27core_timing: Use better reference tracking for EventType. (#3159)bunnei17-161/+103
* core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.
2019-11-26gl_shader_decompiler: Fix casts from fp32 to f16ReinUsesLisp1-1/+2
Casts from f32 to f16 zeroes the higher half of the target register.
2019-11-26kernel: Fix reference management for client/server session.bunnei3-20/+18
- Fixes shutdown crash and crash in Pokemon SwSh.
2019-11-25gl_device: Deduce indexing bug from device instead of heuristicReinUsesLisp2-48/+2
The heuristic to detect AMD's driver was not working properly since it also included Intel. Instead of using heuristics to detect it, compare the GL_VENDOR string.
2019-11-25kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154)bunnei74-378/+377
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
2019-11-24gl_texture_cache: Apply sRGB on blitsReinUsesLisp1-0/+1
glBlitFramebuffer keeps in mind GL_FRAMEBUFFER_SRGB's state. Enable this depending on the target surface pixel format.
2019-11-23Update svc.cppbunnei1-0/+1
2019-11-23svc: GetSystemTick should return cntpct_el0, not core ticks.bunnei1-1/+3
2019-11-23gpu_thread: Don't spin wait if there are no GPU commands.bunnei1-17/+15
2019-11-23fix clang-format and lambda captureWeiyi Wang1-1/+2
2019-11-23unfold UNREACHABLE implementation for dumb compilersWeiyi Wang1-2/+2
We relies on UNREACHABLE's noreturn attribute to eliminate parent's "no return value" warning. However, this was wrapped in a `if(!false)` block, which compilers may not unfold to recognize the noreturn nature.
2019-11-23gl_device: Reserve base bindings on limited devicesReinUsesLisp1-36/+76
SSBOs and other resources are limited per pipeline on Intel and AMD. Heuristically reserve resources per stage having in mind the reported OpenGL limits.
2019-11-23gl_state: Skip null texture bindsReinUsesLisp1-1/+5
glBindTextureUnit doesn't support null textures. Skip binding these.
2019-11-23gl_rasterizer: Disable compute shaders on IntelReinUsesLisp3-0/+12
Intel's proprietary driver enters in a corrupt state when compute shaders are executed. For now, disable these.
2019-11-23gl_shader_cache: Hack shared memory sizeReinUsesLisp1-2/+3
The current shared memory size seems to be smaller than what the game actually uses. This makes Nvidia's driver consistently blow up; in the case of FE3H it made it explode on Qt's SwapBuffers while SDL2 worked just fine. For now keep this hack since it's still progress over the previous hardcoded shared memory size.
2019-11-23gl_shader_decompiler: Normalize image bindingsReinUsesLisp3-33/+19
2019-11-23gl_shader_decompiler: Normalize cbuf bindingsReinUsesLisp2-10/+6
Stage and compute shaders were using a different binding counter. Normalize these.
2019-11-23gl_rasterizer: Add missing cbuf counter reset on computeReinUsesLisp1-0/+2
2019-11-23gl_shader_cache: Remove dynamic BaseBinding specializationReinUsesLisp16-192/+200
2019-11-23video_core: Unify ProgramType and ShaderStage into ShaderTypeReinUsesLisp22-289/+262
2019-11-23gl_rasterizer: Bind graphics images to draw commandsReinUsesLisp4-33/+54
Images were not being bound to draw invocations because these would require a cache invalidation.
2019-11-23gl_shader_cache: Specialize local memory size for compute shadersReinUsesLisp6-21/+32
Local memory size in compute shaders was stubbed with an arbitary size. This commit specializes local memory size from guest GPU parameters.
2019-11-23gl_shader_cache: Specialize shared memory sizeReinUsesLisp5-29/+25
Shared memory was being declared with an undefined size. Specialize from guest GPU parameters the compute shader's shared memory size.
2019-11-23gl_shader_cache: Specialize shader workgroupReinUsesLisp6-68/+74
Drop the usage of ARB_compute_variable_group_size and specialize compute shaders instead. This permits compute to run on AMD and Intel proprietary drivers.
2019-11-23shader/texture: Handle TLDS texture type mismatchesReinUsesLisp1-1/+10
Some games like "Fire Emblem: Three Houses" bind 2D textures to offsets used by instructions of 1D textures. To handle the discrepancy this commit uses the the texture type from the binding and modifies the emitted code IR to build a valid backend expression. E.g.: Bound texture is 2D and instruction is 1D, the emitted IR samples a 2D texture in the coordinate ivec2(X, 0).
2019-11-23shader/texture: Deduce texture buffers from lockerReinUsesLisp9-174/+107
Instead of specializing shaders to separate texture buffers from 1D textures, use the locker to deduce them while they are being decoded.
2019-11-21Kernel: Optimize condition variable threads management.Fernando Sahmkow4-24/+21
2019-11-21Kernel: Correct SignalProcessWideKeyFernando Sahmkow1-6/+2
When the target is 0, all threads must be processed.
2019-11-21Kernel: Correct behavior of Condition Variables to be more similar to real hardware.Fernando Sahmkow5-15/+74
This commit ensures cond var threads act exactly as they do in the real console. The original implementation uses an RBTree and the behavior of cond var threads is that at the same priority level they act like a FIFO.
2019-11-20buffer_cache: Remove brace initialized for objects with default constructorReinUsesLisp1-10/+10
2019-11-20Texture_Cache: Redo invalid Surfaces handling.Fernando Sahmkow3-32/+101
This commit aims to redo the full setup of invalid textures and guarantee correct behavior across backends in the case of finding one by using black dummy textures that match the target of the expected texture.
2019-11-20shader/other: Reduce DEPBAR log severityReinUsesLisp1-1/+1
While DEPBAR is stubbed it doesn't change anything from our end. Shading languages handle what this instruction does implicitly. We are not getting anything out fo this log except noise.
2019-11-20gl_shader_gen: Apply default value to gl_PositionReinUsesLisp1-0/+1
Nvidia has sane default output values for varyings, but the other vendors don't apply these. To properly emulate this we would have to analyze the shader header. For the time being, apply the same default Nvidia applies so we get the same behaviour on non-Nvidia drivers.
2019-11-19citra_qt/main.ui: remove unused actions "Load Symbol Map..." and...Tobias1-13/+0
..."Select Game Directory..." Co-authored-by: vvanelslande <vvanelslandedev@gmail.com>
2019-11-18Shader_IR: Address FeedbackFernando Sahmkow3-11/+9
2019-11-16Kernel: Correct Cancel Synchronization.Fernando Sahmkow3-2/+19
This commit corrects the behavior of cancel synchronization when the thread is running/ready and ensures the next wait is cancelled as it's suppose to.
2019-11-16Revert "common/bit_field: Silence sign-conversion warnings"Rodrigo Locatti1-3/+2
2019-11-15common/logging: Silence no return value warningsReinUsesLisp1-2/+6
2019-11-15common/bit_field: Silence sign-conversion warningsLioncash1-2/+3
We can just use numeric_limits instead of relying on wraparound behavior here.
2019-11-15format_lookup_table: Address feedbackReinUsesLisp2-30/+24
format_lookup_table: Drop bitfields format_lookup_table: Use std::array for definition table format_lookup_table: Include <limits> instead of <numeric>
2019-11-15texture_cache: Use a table instead of switch for texture formatsReinUsesLisp9-261/+290
Use a large flat array to look up texture formats. This allows us to properly implement formats with different component types. It should also be faster.
2019-11-14common_funcs: Remove semicolons from INSERT_PADDING_* macrosLioncash1-4/+6
Makes code that uses the macros consistent by requiring the lines to be terminated with a semicolon.
2019-11-14service/am: Remove unnecessary Skip callsLioncash1-8/+16
We can simplify these by wrapping the necessary members in structs and then simply reading out the whole struct.
2019-11-14texture_cache: Drop abstracted ComponentTypeReinUsesLisp8-294/+158
Abstracted ComponentType was not being used in a meaningful way. This commit drops its usage. There is one place where it was being used to test compatibility between two cached surfaces, but this one is implied in the pixel format. Removing the component type test doesn't change the behaviour.
2019-11-14am: Stub QueryApplicationPlayStatisticsLioncash2-5/+14
Maintains implementation parity between QueryApplicationPlayStatistics and QueryApplicationPlayStatisticsByUid. These function the same behaviorally underneath the hood, with the only difference being that one allows specifying a UID.
2019-11-14correct the implementation of RGBA16UIgreggameplayer1-0/+2
2019-11-14Shader_IR: Implement TXD instruction.Fernando Sahmkow5-8/+120
2019-11-14Shader_IR: Implement FLO instruction.Fernando Sahmkow5-0/+35
2019-11-14Shader_Bytecode: Add encodings for FLO, SHF and TXDFernando Sahmkow1-0/+18
2019-11-13common/hash: Remove unused HashableStructLioncash1-35/+0
This is unused, so it can be removed. There's better ways of ensuring zeroed out padding bits, like using zero-initialization, anyhow.
2019-11-13maxwell_3d: Fix stencil_back_func_mask offsetReinUsesLisp1-3/+3
stencil_back_func_mask and stencil_back_mask were misplaced. This commit addresses that issue.
2019-11-13xts_archive: Remove redundant std::string constructorLioncash1-2/+1
We can just call the .data() member of path instead of constructing a completely new string.
2019-11-13common_funcs: silence sign-conversion warnings in MakeMagic()Lioncash1-1/+1
We can trivially resolve these by casting the characters to unsigned values and then shifting the bits.
2019-11-12service: Update function tablesLioncash33-7/+192
Keeps the function tables up to date. Updated based off information from Switchbrew.
2019-11-12key_manager: Make use of IOFile in WriteKeyToFile()Lioncash1-11/+15
This properly handles unicode-based paths on Windows, while opening a raw stream doesn't out-of-the-box. Prevents file creation from potentially failing on Windows PCs that make use of unicode characters in their save paths (e.g. writing to a user's AppData folder, where the user has a name with non-ASCII characters).
2019-11-12core: Migrate off deprecated mbedtls functionsLioncash7-12/+12
These functions are marked for deprecation and it's recommended that the *_ret variants be used instead.
2019-11-12externals: Update httplibLioncash1-1/+1
Since the introduction of this library, numerous improvements have been made. Notably, many of the warnings we would get by simply including the library header have now been fixed. This makes it much easier to make conversion warning an error.
2019-11-12service: Resolve sign conversion errorsLioncash15-58/+55
These are fairly trivial to resolve and most of the changes entail using RESULT_UNKNOWN over ResultCode(-1).
2019-11-12perf_stats: Resolve implicit int to double conversion errorLioncash1-1/+1
We simply need to turn the literal argument to std::accumulate into a double, rather than an int.
2019-11-12loader; Resolve sign conversion/truncation errorsLioncash3-6/+6
2019-11-12gdbstub: Resolve sign conversion errorsLioncash1-1/+2
2019-11-12kernel: Resolve sign conversion warningsLioncash4-72/+60
Uncovered a bug within Thread's SetCoreAndAffinityMask() where an unsigned variable (ideal_core) was being compared against "< 0", which would always be a false condition. We can also get rid of an unused function (GetNextProcessorId) which contained a sign mismatch warning.
2019-11-12file_sys: Resolve sign conversion warningsLioncash4-12/+10
Resolves a few trivial sign conversion/mismatch errors.
2019-11-12result: Add default error code for the ResultCode(-1) caseLioncash1-1/+9
Will be used to reduce the overall duplication of the same magic value all over the codebase in following changes.
2019-11-12crypto: Resolve sign-conversion warningsLioncash2-11/+12
2019-11-12result: Resolve sign-coversion warningsLioncash1-1/+1
The constructor was implicitly using signed->unsigned conversions to produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.
2019-11-12arm_unicorn: Resolve sign conversion warningsLioncash3-8/+10
While we're at it, this also resolves a type truncation warning as well, given the code was truncating from a 64-bit value to a 32-bit one.
2019-11-12CMakeLists: Make most implicit type conversion warnings errors on MSVCLioncash1-0/+17
Quite frequently there have been cases where code has been merged into the core that produces warning. In order to prevent this from occurring, we can make the compiler flag these cases and allow our CI to flag down any code that would generate these warnings. This is beneficial given silent conversions from signed/unsigned can result in logic bugs. This forces one writing changes to be explicit about when signedness conversions are desirable, rather than leaving it up to readers' interpretation. Currently the codebase isn't in a state where it will build successfully with this change applied, but this will be addressed in subsequent follow-up changes. This set of changes will focus on making it build properly with these changes for MSVC as a starting point for basic coverage.
2019-11-11video_core: Enable sign conversion warningsRodrigo Locatti1-1/+1
Enable sign conversion warnings but don't treat them as errors.
2019-11-11Implement stub for QueryApplicationPlayStatisticsByUidMichael Scire2-0/+10
2019-11-09web-service: Port citra's updated web_backend code.bunnei2-18/+57
2019-11-09yuzu: configure_web: Use Base64 encoded token for simplifying user experience.bunnei2-32/+53
2019-11-08video_core: Treat implicit conversions as errorsReinUsesLisp1-0/+6
2019-11-08video_core: Silence implicit conversion warningsReinUsesLisp9-53/+62
2019-11-08gl_shader_cache: Fix locker constructorsReinUsesLisp1-2/+4
Properly pass engine when a shader is being constructed from memory.
2019-11-08gl_shader_cache: Enable extensions only when availableReinUsesLisp1-6/+14
Silence GLSL compilation warnings.
2019-11-08gl_shader_decompiler: Add safe fallbacks when ARB_shader_ballot is not availableReinUsesLisp3-5/+28
2019-11-08shader_ir/warp: Implement FSWZADDReinUsesLisp5-0/+44
2019-11-08gl_shader_decompiler: Reimplement shuffles with platform agnostic intrinsicsReinUsesLisp5-122/+49
2019-11-07GLSLDecompiler: Correct Texture Gather Offset.Fernando Sahmkow1-1/+1
This commit corrects the argument ordering in textureGatherOffset.
2019-11-07buffer_cache: Add missing includes (#3079)Morph1-0/+4
`boost::make_iterator_range` is available when `boost/range/iterator_range.hpp` is included. Also include `boost/icl/interval_map.hpp` and `boost/icl/interval_set.hpp`.
2019-11-07gl_rasterizer: Remove front facing hackReinUsesLisp1-12/+0
2019-11-07gl_shader_decompiler: Fix typo "y_negate"->"y_direction"ReinUsesLisp1-1/+1
2019-11-07gl_shader_manager: Remove unused variable in SetFromRegsReinUsesLisp1-1/+0
2019-11-07yuzu_cmd: Use string_view instead of string for extensionsReinUsesLisp1-3/+3
Avoids potential allocations due to the usage of std::string on strings that we know at compile time. Most of these might fit in SSO, but it adds complexity that can be easily avoided with string views.
2019-11-07gl_rasterizer: Emulate viewport flipping with ARB_clip_controlReinUsesLisp9-76/+57
Emulates negative y viewports with ARB_clip_control. This allows us to more easily emulated pipelines with tessellation and/or geometry shader stages. It also avoids corrupting games with transform feedbacks and negative viewports (gl_Position.y was being modified).
2019-11-07shader/control_flow: Specify constness on caller lambdasRodrigo Locatti1-11/+12
Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com> Update src/video_core/shader/control_flow.cpp Co-Authored-By: Mat M. <mathew1800@gmail.com>
2019-11-07shader/control_flow: Use callable template instead of std::functionReinUsesLisp1-6/+5
2019-11-07shader/control_flow: Abstract repeated code chunks in BRX trackingReinUsesLisp1-93/+101
Remove copied and pasted for cycles into a common templated function.
2019-11-07shader/control_flow: Silence Intellisense cast warningsReinUsesLisp1-1/+1
2019-11-07shader/control_flow: Remove brace initializer in std containersReinUsesLisp1-9/+9
These containers have a default constructor.
2019-11-07shader/decode: Reduce severity of arithmetic rounding warningsReinUsesLisp6-15/+17
2019-11-07shader/arithmetic: Reduce RRO stub severityReinUsesLisp1-1/+2
2019-11-07shader/texture: Remove NODEP warningsReinUsesLisp1-35/+0
These warnings don't offer meaningful information while decoding shaders. Remove them.
2019-11-07nifm: Only return that there's an internet connection when there's a BCATServerFernando Sahmkow1-3/+17
This helps games that need internet for other purposes boot as the rest of our internet infrastructure is incomplete.
2019-11-06ci: Populate build repository from Azure environmentZach Hilman1-11/+2
2019-11-04common_func: Use std::array for INSERT_PADDING_* macros.bunnei14-158/+166
- Zero initialization here is useful for determinism.
2019-11-03Revert "common_func: Use std::array for INSERT_PADDING_* macros."bunnei1-3/+2
2019-11-03common_func: Use std::array for INSERT_PADDING_* macros.bunnei1-2/+3
- Zero initialization here is useful for determinism.
2019-11-03kernel: readable_event: Signal only once.bunnei1-2/+4
2019-11-03kernel: events: Remove ResetType::Automatic.bunnei25-109/+48
- This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp
2019-11-03kernel: readable_event: Initialize members.bunnei1-1/+1
2019-11-03common/bit_field: Remove FORCE_INLINE calls Tobias1-2/+2
See bunneis comment here https://github.com/citra-emu/citra/pull/4629#discussion_r258533167. They were supposed to be removed by him, but he missed them.
2019-11-03core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibilityFearlessTobi2-3/+31
These commands require Screenshots to be implemented anyway, so they are safe to stub for now.
2019-11-03citra_qt: add amiibo drag and drop supportFearlessTobi2-4/+18
Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>
2019-11-02gl_rasterizer: Re-enable stream buffer memory due to global memoryReinUsesLisp1-14/+8
Global memory is still using the stream buffer when it shouldn't. As a temporary fix re-enable the stream buffer on compute.
2019-11-02gl_rasterizer: Upload constant buffers with glNamedBufferSubDataReinUsesLisp6-19/+84
Nvidia's OpenGL driver maps gl(Named)BufferSubData with some requirements to a fast. This path has an extra memcpy but updates the buffer without orphaning or waiting for previous calls. It can be seen as a better model for "push constants" that can upload a whole UBO instead of 256 bytes. This path has some requirements established here: http://on-demand.gputechconf.com/gtc/2014/presentations/S4379-opengl-44-scene-rendering-techniques.pdf#page=24 Instead of using the stream buffer, this commits moves constant buffers uploads to calls of glNamedBufferSubData and from my testing it brings a performance improvement. This is disabled when the vendor is not Nvidia since it brings performance regressions.
2019-10-31Shader_IR: Fix regression on TLD4Fernando Sahmkow2-5/+4
Originally on the last commit I thought TLD4 acted the same as TLD4S and didn't have a mask. It actually does have a component mask. This commit corrects that.
2019-10-30Shader_IR: Fix TLD4 and add Bindless Variant.Fernando Sahmkow3-11/+55
This commit fixes an issue where not all 4 results of tld4 were being written, the color component was defaulted to red, among other things. It also implements the bindless variant.
2019-10-30gl_state: Use std::array::fill instead of std::fillRodrigo Locatti1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2019-10-30gl_state: Move dirty checks to individual apply calls instead of ApplyReinUsesLisp2-66/+74
This requires removing constness from some methods, but for consistency it's removed in all methods.
2019-10-30gl_state: Remove ApplyDefaultStateReinUsesLisp3-17/+1
OpenGL has defaults values we can trust. Remove these.
2019-10-30gl_state: Change SetDefaultViewports to use default constructorReinUsesLisp1-13/+2
2019-10-30gl_state: Minor style changesReinUsesLisp1-3/+5
2019-10-30gl_state: Remove unused Citra TextureUnitsReinUsesLisp1-23/+0
2019-10-30gl_state: Move initializers from constructor to class declarationReinUsesLisp2-170/+75
2019-10-30shader/node: Unpack bindless texture encodingReinUsesLisp8-142/+116
Bindless textures were using u64 to pack the buffer and offset from where they come from. Drop this in favor of separated entries in the struct. Remove the usage of std::set in favor of std::list (it's not std::vector to avoid reference invalidations) for samplers and images.
2019-10-28scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as constLioncash2-5/+5
This is only compared against, so it can be made const.
2019-10-28maxwell_3d/kepler_compute: Remove unused arguments in GetTextureReinUsesLisp5-37/+20
2019-10-28video_core/textures: Remove unused index entry in FullTextureInfoReinUsesLisp2-2/+0
2019-10-28maxwell_3d: Remove unused method GetStageTexturesReinUsesLisp2-42/+0
2019-10-28scheduler: Silence sign conversion warningsLioncash1-5/+5
2019-10-28scheduler: Initialize class members directly where applicableLioncash2-6/+4
Reduces the overall amount of code.
2019-10-28scheduler: Amend documentation commentsLioncash2-75/+59
Adjusts the formatting of a few of the comments an ensures they get recognized as proper Doxygen comments.
2019-10-27Video_Core: Implement texture format E5B9G9R9_SHAREDEXP.Fernando Sahmkow4-5/+22
This commit implements the E5B9G9R9 Texture format into the general system and OpenGL backend.
2019-10-27maxwell_3d: Silence implicit conversion warningsReinUsesLisp2-24/+25
While we are at it, unify types for dirty reg pointers.
2019-10-27rasterizer_accelerated: Add intermediary for GPU rasterizersReinUsesLisp5-45/+98
Add an intermediary class that implements common functions across GPU accelerated rasterizers. This avoids code repetition on different backends.
2019-10-27astc: Silence implicit conversion warningsReinUsesLisp1-7/+8
2019-10-26Shader_IR: Address Feedback.Fernando Sahmkow9-56/+66
2019-10-25Shader_IR: Clang formatFernando Sahmkow1-2/+1
2019-10-25gl_shader_cache: Implement locker variants invalidationReinUsesLisp4-44/+104
2019-10-25gl_shader_disk_cache: Store and load fast BRXReinUsesLisp6-50/+210
2019-10-25const_buffer_locker: Minor style changesReinUsesLisp2-152/+76
2019-10-25gl_shader_decompiler: Move entries to a separate functionReinUsesLisp15-722/+420
2019-10-25Shader_IR: Implement Fast BRX and allow multi-branches in the CFG.Fernando Sahmkow1-1/+1
2019-10-25Shader_IR: Correct typo in Consistent method.Fernando Sahmkow2-2/+2
2019-10-25Shader_IR: allow lookup of texture samplers within the shader_ir for instructions that don't provide itFernando Sahmkow9-46/+363
2019-10-25Shader_IR: Implement Fast BRX and allow multi-branches in the CFG.Fernando Sahmkow7-130/+258
2019-10-25Shader_Cache: setup connection of ConstBufferLockerFernando Sahmkow10-43/+82
2019-10-25VideoCore: Unify const buffer accessing along engines and provide ConstBufferLocker class to shaders.Fernando Sahmkow12-13/+183
2019-10-25Shader_IR: Implement BRX tracking.Fernando Sahmkow1-0/+113
2019-10-24shader_bytecode: Make Matcher constexpr capableLioncash1-13/+13
Greatly shrinks the amount of generated code for GetDecodeTable(). Collapses an assembly output of 9000+ lines down to ~3621 with Clang, and 6513 down to ~2616 with GCC, given it's now allowed to construct all the entries as a sequence of constant data.
2019-10-24shader_ir: Use std::array with pair instead of unordered_mapLioncash1-53/+67
Given the overall size of the maps are very small, we can use arrays of pairs here instead of always heap allocating a new map every time the functions are called. Given the small size of the maps, the difference in container lookups are negligible, especially given the entries are already sorted.
2019-10-24video_core/shader: Resolve instances of variable shadowingLioncash6-11/+12
Silences a few -Wshadow warnings.
2019-10-22savedata_factory: Automatically create certain savedataZach Hilman1-0/+12
After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use. In these 3 specific instances, the save is created automatically for the game if it doesn't exist.
2019-10-22Shader_Ir: Fix TLD4S from using a component mask.Fernando Sahmkow2-5/+5
TLD4S always outputs 4 values, the previous code checked a component mask and omitted those values that weren't part of it. This commit corrects that and makes sure all 4 values are set.
2019-10-22shader_ir/memory: Ignore global memory when tracking failsReinUsesLisp2-18/+26
Ignore global memory operations instead of invoking undefined behaviour when constant buffer tracking fails and we are blasting through asserts, ignore the operation. In the case of LDG this means filling the destination registers with zeroes; for STG this means ignore the instruction as a whole. The default behaviour is still to abort execution on failure.
2019-10-20maxwell_3d: Reduce FlushMMEInlineDraw logging to TraceReinUsesLisp1-1/+1
2019-10-19core: Fix clang-format errors.bunnei1-9/+10
2019-10-18Fix null pointer deref.Nicolae-Andrei Cociorba1-10/+12
2019-10-18video_core/shader/ast: Make ShowCurrentState() and SanityCheck() const member functionsLioncash2-5/+5
These can also trivially be made const member functions, with the addition of a few consts.
2019-10-18video_core/shader/ast: Make ASTManager::Print a const member functionLioncash2-3/+3
Given all visiting functions never modify the nodes, we can trivially make this a const member function.
2019-10-18video_core/shader/ast: Make ExprPrinter members privateLioncash1-1/+2
This member already has an accessor, so there's no need for it to be public.
2019-10-18video_core/shader/ast: Make Indent() return a string_viewLioncash1-14/+24
The returned string is simply a substring of our constexpr tabs string_view, so we can just use a string_view here as well, since the original string_view is guaranteed to always exist. Now the function is fully non-allocating.
2019-10-18video_core/shader/ast: Make Indent() privateLioncash1-9/+9
It's never used outside of this class, so we can narrow its scope down.
2019-10-18video_core/shader/ast: Rename Ident() to Indent()Lioncash1-13/+13
This can be confusing, given "ident" is generally used as a shorthand for "identifier".
2019-10-18video_core/shader/ast: Make use of fmt where applicableLioncash1-14/+14
Makes a few strings nicer to read and also eliminates a bit of string churn with operator+.
2019-10-18vk_shader_decompiler: Mark operator() function parameters as const referencesLioncash1-21/+23
These parameters aren't actually modified in any way, so they can be made const references.
2019-10-18dmnt_cheat_vm: Correct register Restore and ClearRegs behaviorLioncash1-2/+2
Previously these were performing the same behavior as the Save and ClearSaved opcode types.
2019-10-18Fermi2D: Use a different formula for delimiting blit areas.Fernando Sahmkow1-14/+28
2019-10-18hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers()Lioncash1-1/+1
We should be setting the connection state to true, otherwise we aren't actually making the controllers connected like the function name indicates.
2019-10-18hid/npad: Add missing break in default caseLioncash1-0/+1
While not an issue, it does prevent fallthrough from occurring if anything is ever added after this case (unlikely to occur, but this turns a trivial "should not cause issues" into a definite "won't cause issues).
2019-10-18hid/npad: Replace std::for_each with ranged for loopsLioncash1-13/+12
Performs the same behavior, but is built into the core language itself. No functional change.
2019-10-18hid/npad: Remove redundant non-const variant of IsControllerSupported()Lioncash2-34/+5
The const qualified variant can also be called in non-const contexts, so we can remove the non-const variant to eliminate a bit of code duplication.
2019-10-18hid/npad: Move function declarationsLioncash1-5/+6
Clearly separate these from the variable declarations to make them more visible.
2019-10-17video_core/macro_interpreter: Make definitions of most private enums/unions hiddenLioncash2-72/+79
This allows the implementation of these types to change without requiring a rebuild of everything that includes the macro interpreter header.
2019-10-17core/core: Resolve -Wreorder warningsLioncash1-2/+2
Amends the initializer lists to be ordered in the same manner that they're declared within the class.
2019-10-17core/memory/cheat_engine: Resolve -Wreorder warningsLioncash1-4/+3
Amends the initializer lists to be ordered in the same manner that they're declared within the class.
2019-10-17apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a mapLioncash1-14/+34
While a map is an OK way to do lookups (and usually recommended in most cases), this is a map that lives for the entire duration of the program and only deallocates its contents when the program terminates. Given the total size of the map is quite small, we can simply use a std::array of pairs and utilize std::find_if to perform the same behavior without loss of performance. This eliminates a static constructor and places the data into the read-only segment. While we're at it, we can also handle malformed inputs instead of directly dereferencing the resulting iterator.
2019-10-17apm/controller: Make GetCurrentPerformanceMode() a const member functionLioncash2-2/+2
This doesn't modify instance state, so it can be made const qualified.
2019-10-17Fermi2D: limit blit area to only available areaFernando Sahmkow1-4/+14
Normaly OpenGL does not care if the areas exceed the texture regions but other backends such as Vulkan do care about the limits of this areas. This PR crops the areas of the blit in order that they don't surpass the limits of the textures. This should help Vulkan and faulty OpenGL drivers
2019-10-16video_core/surface: Add missing break in PixelFormatFromTextureFormat()Lioncash1-0/+1
Prevents fallthrough into the following case.
2019-10-16vk_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator()Lioncash1-0/+3
This would previously result in NeverExecute and UnusedIndex being treated as regular predicates.
2019-10-16gl_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator()Lioncash1-0/+3
This would previously result in NeverExecute and UnusedIndex being treated as regular predicates.
2019-10-16texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface()Lioncash1-2/+2
We can take these by const reference and avoid making unnecessary copies, preventing some atomic reference count increments and decrements.
2019-10-16control_flow: Silence truncation warningsLioncash2-4/+4
This can be trivially fixed by making the input size a size_t. CFGRebuildState's constructor parameter is already a std::size_t, so this just makes the size type fully conform with it.
2019-10-16gl_shader_decompiler: Make ExprDecompiler's GetResult() a const member functionLioncash1-1/+1
This is only ever used to read, but not write, the resulting string, so we can enforce this by making it a const member function.
2019-10-16gl_shader_decompiler: Use a std::string_view with GetDeclarationWithSuffix()Lioncash1-1/+1
This allows the function to be completely non-allocating for inputs of all sizes (i.e. there's no heap cost for an input to convert to a std::string_view).
2019-10-16gl_shader_decompiler: Fold flow_var constant into GetFlowVariable()Lioncash1-3/+1
This is only ever used within this function, so we can narrow it's scope down.
2019-10-16gl_shader_decompiler: Mark ASTDecompiler/ExprDecompiler parameters as const references where applicableLioncash1-21/+21
These member functions don't actually modify the input parameter, so we can make this explicit with the use of const.
2019-10-16gl_shader_decompiler: Pass by reference to GenerateTextureArgument()Lioncash1-2/+2
Avoids an unnecessary atomic reference count increment and decrement.
2019-10-16gl_shader_decompiler: Use std::holds_alternative within GenerateTexture()Lioncash1-1/+1
This only ever queries if the type exists within the variant, but doesn't actually do anything with the return value. We can just use std::holds_alternative for this use case.
2019-10-16shader/node: std::move Meta instance within OperationNode constructorLioncash1-1/+1
Allows usages of the constructor to avoid an unnecessary copy.
2019-10-16gl_shader_decompiler: Avoid unnecessary copies of MetaImageLioncash1-4/+4
MetaImage contains a std::vector, so copying here could result in unnecessary reallocations. Given the operation lives throughout the entire scope, this is safe to do.
2019-10-15maxwell_3d: Silence truncation warningsLioncash1-1/+2
A trivial warning caused by not using size_t as the argument types instead of u32.
2019-10-15video_core/gpu: Remove use of the global system accessorLioncash1-1/+1
We can just make use of the reference member variable instead of accessing the global system instance.
2019-10-15bcat: Remove use of global system accessorsLioncash6-29/+55
Removes all uses of the global system accessor within the BCAT interface.
2019-10-15video_core/texture_cache: Amend Doxygen referencesLioncash1-57/+78
Amends the doxygen comments so that they properly resolve. While we're at it, we can correct some typos and fix up some of the comments' formatting in order to make them slightly nicer to read.
2019-10-15common/algorithm: Add description comment indicating intended algorithmsLioncash1-0/+5
Makes it explicit that the header is intended for iterator-based algorithms that can ideally operate on any type.
2019-10-15common: Rename binary_find.h to algorithm.hLioncash4-4/+5
Makes the header more general for other potential algorithms in the future. While we're at it, include a missing <functional> include to satisfy the use of std::less.
2019-10-15Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE.Fernando Sahmkow2-4/+1
2019-10-15Kernel: Address Feedback 2Fernando Sahmkow2-9/+6
2019-10-15Kernel: Clang FormatFernando Sahmkow2-5/+5
2019-10-15Kernel: Reverse global accessor removal.Fernando Sahmkow4-23/+9
2019-10-15Kernel: Address Feedback.Fernando Sahmkow6-67/+98
2019-10-15Kernel Scheduler: Make sure the global scheduler shutdowns correctly.Fernando Sahmkow7-0/+31
2019-10-15Kernel_Thread: Eliminate most global accessors.Fernando Sahmkow1-11/+11
2019-10-15KernelSVC: Assert that condition variable address is aligned to 4 bytes.Fernando Sahmkow1-0/+4
2019-10-15Kernel: Correct Paused schedulingFernando Sahmkow1-3/+1
2019-10-15Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel.Fernando Sahmkow3-3/+4
2019-10-15Kernel: Correct redundant yields to only advance time forward.Fernando Sahmkow1-3/+5
2019-10-15Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqualFernando Sahmkow1-5/+13
2019-10-15Kernel: Correct Results in Condition Variables and MutexesFernando Sahmkow3-24/+17
2019-10-15Kernel: Clang FormatFernando Sahmkow2-2/+3
2019-10-15Kernel: Remove global system accessor from WaitObjectFernando Sahmkow4-2/+17
2019-10-15Scheduler: Implement Yield Count and Core migration on Thread Preemption.Fernando Sahmkow2-5/+85
2019-10-15Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection.Fernando Sahmkow2-8/+8
2019-10-15Kernel: Initial implementation of thread preemption.Fernando Sahmkow3-0/+30
2019-10-15Scheduler: Add protections for Yield bombingFernando Sahmkow5-24/+31
In case of redundant yields, the scheduler will now idle the core for it's timeslice, in order to avoid continuously yielding the same thing over and over.
2019-10-15Kernel: Style and CorrectionsFernando Sahmkow12-96/+137
2019-10-15Correct PrepareRescheduleFernando Sahmkow6-38/+29
2019-10-15Comment and reorganize the schedulerFernando Sahmkow2-98/+104
2019-10-15Add PrepareReschedule where required.Fernando Sahmkow3-16/+18
2019-10-15Correct compiling errors and addapt to the new interface.Fernando Sahmkow3-27/+15
2019-10-15Correct Supervisor Calls to work with the new scheduler,Fernando Sahmkow1-26/+41
2019-10-15Redesign CPU Cores to work with the new schedulerFernando Sahmkow2-13/+12
2019-10-15Add interfacing to the Global SchedulerFernando Sahmkow4-0/+34
2019-10-15Addapt thread class to the new SchedulerFernando Sahmkow2-60/+237
2019-10-15Implement a new Core SchedulerFernando Sahmkow2-258/+411
2019-10-13card_image: Implement system update commands in XCIZach Hilman2-3/+37
2019-10-13pl_u: Fix mismatched rebase size error in font encryptionZach Hilman3-19/+17
2019-10-13pl_u: Use kernel physical memoryZach Hilman2-4/+8
2019-10-13pl_u: Remove excess static qualifierZach Hilman1-1/+1
2019-10-13pl_u: Use OSS system archives if real archives don't existZach Hilman2-112/+48
2019-10-13system_archive: Synthesize shared fonts system archivesZach Hilman3-5/+101
2019-10-13externals: Move OSS font data to file_sys in coreZach Hilman13-1/+73324
2019-10-12nvflinger/buffer_queue: Remove use of a global system accessorLioncash3-4/+8
2019-10-12Core_Timing: Address Remaining feedback.Fernando Sahmkow1-5/+4
2019-10-12Core_Timing: Fix tests.Fernando Sahmkow1-2/+2
2019-10-11Core_Timing: Address Feedback and suppress warnings.Fernando Sahmkow5-13/+12
2019-10-11AsyncGpu: Address FeedbackFernando Sahmkow2-2/+2
2019-10-10fixed clang format & addressed feedbackFreddyFunk1-26/+24
2019-10-10yuzu/configure_input_player: Fix input handling for ZL and ZR from controllers with analog triggersFreddyFunk1-7/+23
2019-10-09Surfaces: Implement R4G4B4A4U format.Fernando Sahmkow4-24/+41
2019-10-09Surfaces: Implement ASTC 6x6 10x10 12x12 8x6 6x5Fernando Sahmkow4-70/+185
2019-10-09Core Timing: Correct Idle and remove lefting pragmaFernando Sahmkow1-2/+1
2019-10-09Core Timing: General corrections and added tests.Fernando Sahmkow3-7/+165
2019-10-09Tests: Eliminate old Core Timing TestsFernando Sahmkow1-193/+0
2019-10-09Core Timing: Rework Core Timing to run all cores evenly.Fernando Sahmkow6-38/+89
2019-10-07shader/half_set_predicate: Fix HSETP2 for constant buffersReinUsesLisp1-0/+2
HSETP2 when used with a constant buffer parses the second operand type as F32. This is not configurable.
2019-10-07shader/half_set_predicate: Reduce DEBUG_ASSERT to LOG_DEBUGReinUsesLisp1-1/+2
2019-10-07hid: Implement DeactivateNpadMorph2-1/+13
Makes use of the already existing DeactivateController function.
2019-10-07hid: Stub SetNpadJoyAssignmentModeSingle and reorganize service commandsMorph2-92/+126
2019-10-07alignment: Resolve allocator construction issues on debugLioncash1-0/+5
This was related to the source allocator being passed into the constructor potentially having a different type than allocator being constructed. We simply need to provide a constructor to handle this case. This resolves issues related to the allocator causing debug builds on MSVC to fail.
2019-10-07alignment: Specify trait definitions within the allocatorLioncash1-0/+5
Allows containers and other data structures to consider optimizations based off of them. We satisfy all of these requirements anyways.
2019-10-06gl_shader_disk_cache: Properly ignore existing cacheReinUsesLisp2-16/+17
Previously old entries where appended to the file even if the shader cache was ignored at boot. Address that issue.
2019-10-06bcat/module: Silence truncation warningsLioncash1-3/+3
We need to perform explicit casts here, otherwise we're implicitly truncating a 64-bit type to a 32-bit one.
2019-10-06bcat: Take std::function instance by value in NullBackend's constructorLioncash2-2/+2
Without this, the std::move within the constructor initializer list won't be able to actually perform a move.
2019-10-06bcat: In-class initialize ProgressServiceBackend's impl memberLioncash2-2/+2
Allows us to remove a constructor initializer list.
2019-10-06bcat: Make ProgressServiceBackend's constructor take a std::string_viewLioncash2-3/+7
Given the string is appended to another, we can make it a view so a redundant full copy of the string isn't made.
2019-10-06qt: Fix game name format errorZach Hilman1-2/+2
2019-10-06bcat: Make ProgressServiceBackend's GetEvent() constLioncash2-2/+2
This member function doesn't modify internal member state, so it can be marked const.
2019-10-06boxcat: Silence an unused variable warningLioncash1-1/+2
On parse errors, we can log out the explanatory string indicating what the parsing error was, rather than just ignoring the variable and returning an overly broad error code.
2019-10-06core/core: Remove unused headerLioncash1-1/+0
This isn't used anywhere in either the cpp or header file.
2019-10-06core: Remove Core::CurrentProcess()Lioncash5-13/+11
This only encourages the use of the global system instance (which will be phased out long-term). Instead, we use the direct system function call directly to remove the appealing but discouraged short-hand.
2019-10-06hle/service: Replace global system instance calls with instance-based onesLioncash14-51/+76
Migrates the HLE service code off the use of directly accessing the global system instance where trivially able to do so. This removes all usages of Core::CurrentProcess from the service code, only 8 occurrences of this function exist elsewhere. There's still quite a bit of "System::GetInstance()" being used, however this was able to replace a few instances.
2019-10-05video_core/control_flow: Eliminate variable shadowing warningsLioncash1-6/+6
2019-10-05video_core/control_flow: Eliminate pessimizing movesLioncash1-5/+8
These can inhibit the ability of a compiler to perform RVO.
2019-10-05video_core/ast: Unindent most of IsFullyDecompiled() by one levelLioncash1-12/+12
2019-10-05video_core/ast: Make ShowCurrentState() take a string_view instead of std::stringLioncash2-2/+2
Allows the function to be non-allocating in terms of the output string.
2019-10-05video_core/ast: Eliminate variable shadowing warningsLioncash1-3/+3
2019-10-05video_core/ast: Replace std::string with a constexpr std::string_viewLioncash1-3/+1
Same behavior, but without the need to heap allocate
2019-10-05video_core/ast: Default the move constructor and assignment operatorLioncash2-26/+2
This is behaviorally equivalent and also fixes a bug where some members weren't being moved over.
2019-10-05video_core/{ast, expr}: Organize forward declarationLioncash2-10/+10
Keeps them alphabetically sorted for readability.
2019-10-05video_core/expr: Supply operator!= along with operator==Lioncash2-1/+32
Provides logical symmetry to the interface.
2019-10-05video_core/{ast, expr}: Use std::move where applicableLioncash4-45/+47
Avoids unnecessary atomic reference count increments and decrements.
2019-10-05video_core/ast: Supply const accessors for data where applicableLioncash2-37/+41
Provides const equivalents of data accessors for use within const contexts.
2019-10-05qt: Change titlebar formattingZach Hilman1-6/+15
2019-10-05common: Add additional SCM revision fieldsZach Hilman3-0/+21
2019-10-05maxwell_3d: Add dirty flags for depth bounds valuesReinUsesLisp2-1/+10
This is useful in Vulkan where we want to update depth bounds without caring if it's enabled or disabled through vkCmdSetDepthBounds.
2019-10-05GL_Renderer: Remove lefting snippet.Fernando Sahmkow1-2/+0
2019-10-05NvFlinger: Remove leftover from corrections and clang format.Fernando Sahmkow1-4/+0
2019-10-05Gl_Rasterizer: Protect CPU Memory mapping from multiple threads.Fernando Sahmkow2-0/+4
2019-10-05Core: Wait for GPU to be idle before shutting down.Fernando Sahmkow7-0/+19
2019-10-05Nvdrv: Correct Event setup in NvdrvFernando Sahmkow2-23/+14
Events are supposed to be cleared on quering. This fixes that issue.
2019-10-05NVFlinger: Reverse the change that only signaled events on buffer acquire.Fernando Sahmkow2-20/+1
This has been hardware tested and it seems that NVFlinger will still signal even if there are no buffers to present.
2019-10-05Nvdrv: Do framelimiting only in the CPU ThreadFernando Sahmkow2-3/+4
2019-10-05NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu.Fernando Sahmkow1-1/+3
2019-10-05GPU_Async: Correct fences, display events and more.Fernando Sahmkow6-21/+38
This commit uses guest fences on vSync event instead of an articial fake fence we had. It also corrects to keep signaling display events while loading the game as the OS is suppose to send buffers to vSync during that time.
2019-10-05Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncsFernando Sahmkow2-3/+9
2019-10-05audio/audout_u: Change formatting for old clang-format versionsReinUsesLisp1-1/+1
2019-10-05yuzu/game_list_worker: Silence warningsReinUsesLisp2-8/+9
2019-10-05yuzu/game_list: Silence -Wswitch and -Wunused-variableReinUsesLisp2-5/+12
2019-10-05yuzu/configure_service: Silence -WswitchReinUsesLisp1-0/+2
2019-10-05yuzu_tester: Remove unused variableReinUsesLisp1-1/+0
2019-10-05service/nvdrv: Silence -WswitchReinUsesLisp4-4/+10
2019-10-05service/nfp: Silence -Wunused and -WswitchReinUsesLisp1-4/+5
2019-10-05service/hid: Silence -Wunused and -WswitchReinUsesLisp15-23/+18
2019-10-05service/am: Silence -WreorderReinUsesLisp1-2/+1
2019-10-05service/hid: Remove unused system referenceReinUsesLisp2-2/+1
2019-10-05service/friend: Remove unused fieldReinUsesLisp1-1/+0
2019-10-05service/filesystem: Silence -Wunused-variableReinUsesLisp1-1/+1
2019-10-05service/bcat: Silence -Wreorder and -WunusedReinUsesLisp2-2/+2
2019-10-05service/audio: Silence -WunusedReinUsesLisp1-1/+1
2019-10-05service/apm: Silence -Wunused and -WreorderReinUsesLisp2-4/+5
2019-10-05common/file_util: Silence -WswitchReinUsesLisp1-1/+2
2019-10-05Texture_Cache: Blit Deduction corrections and simplifications.Fernando Sahmkow1-18/+20
2019-10-05TextureCache: Add the ability to deduce if two textures are depth on blit.Fernando Sahmkow1-2/+142
2019-10-05Shader_ir: Address feedbackFernando Sahmkow6-65/+24
2019-10-05Shader_Ir: Address Feedback and clang format.Fernando Sahmkow4-68/+68
2019-10-05vk_shader_decompiler: Correct Branches inside conditionals.Fernando Sahmkow1-1/+11
2019-10-05vk_shader_decompiler: Clean code and be const correct.Fernando Sahmkow2-8/+6
2019-10-05Shader_IR: clean up AST handling and add documentation.Fernando Sahmkow1-2/+6
2019-10-05Shader_IR: Correct OutwardMoves for IfsFernando Sahmkow1-22/+11
2019-10-05vk_shader_compiler: Don't enclose branches with if(true) to avoid crashing AMDFernando Sahmkow1-16/+33
2019-10-05gl_shader_decompiler: Refactor and address feedback.Fernando Sahmkow1-17/+18
2019-10-05Shader_IR: corrections and clang-formatFernando Sahmkow2-70/+64
2019-10-05vk_shader_compiler: Correct SPIR-V AST DecompilingFernando Sahmkow1-4/+11
2019-10-05Shader_IR: allow else derivation to be optional.Fernando Sahmkow7-10/+18
2019-10-05vk_shader_compiler: Implement the decompiler in SPIR-VFernando Sahmkow3-23/+301
2019-10-05Shader_IR: mark labels as unused for partial decompile.Fernando Sahmkow2-3/+9
2019-10-05Shader_Ir: Refactor Decompilation process and allow multiple decompilation modes.Fernando Sahmkow14-82/+336
2019-10-05gl_shader_decompiler: Implement AST decompilingFernando Sahmkow11-63/+358
2019-10-05shader_ir: Declare Manager and pass it to appropiate programs.Fernando Sahmkow7-104/+214
2019-10-05shader_ir: Corrections to outward movements and misc stuffsFernando Sahmkow7-58/+310
2019-10-05shader_ir: Add basic goto eliminationFernando Sahmkow2-38/+484
2019-10-05shader_ir: Initial Decompile SetupFernando Sahmkow6-5/+510
2019-10-05SDL: Fix missing headerFernando Sahmkow1-0/+1
This fixes linux and mingw builds.
2019-10-02[crypto] Use IsAllZeroArray helper functionvperus1-1/+1
2019-10-02qt: Add service dialogZach Hilman5-17/+20
2019-10-01boxcat: Use updated game-asset API URL and tagsZach Hilman1-6/+6
2019-10-01bcat: Add FSC accessors for BCAT dataZach Hilman10-31/+51
Ports BCAT to use FSC interface
2019-10-01gl_rasterizer: Fix polygon offset unitsReinUsesLisp1-1/+3
For some reason hardware divides polygon offset units by two. This is visible since drivers multiply the application requested polygon offset by two.
2019-09-30boxcat: Implement events global fieldZach Hilman6-30/+43
2019-09-30bcat: Implement DeliveryCacheProgressImpl structureZach Hilman6-88/+314
Huge thanks to lioncash for re-ing this for me.
2019-09-30boxcat: Use Etag header names for file digestZach Hilman2-24/+21
2019-09-30boxcat: Add downloading and client for launch parameter dataZach Hilman2-16/+77
2019-09-30bcat: Add backend function for BCAT Indirect (launch parameter)Zach Hilman2-0/+11
Returns the data that should be returned by PopLaunchParameter kind=ApplicationSpecific.
2019-09-30bcat: Expose CreateBackendFromSettings helper functionZach Hilman2-2/+2
2019-09-30am: Unstub PopLaunchParameter and add bcat connection for app-specific dataZach Hilman2-16/+52
Previously we were simply returning the account-preselect structure all times but if passed with a different mode the game expects application-specific data. This also adds a hook for BCAT into this allowing us to send the launch parameter through bcat,
2019-09-30configure_service: Allow Qt to open external linksZach Hilman1-0/+3
2019-09-30yuzu: Add UI tab to configure BCAT servicesZach Hilman6-0/+302
Also displays current events if boxcat is selected.
2019-09-30bcat: Implement cmd 90201 ClearDeliveryCacheStorageZach Hilman1-1/+23
Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.
2019-09-30bcat: Implement cmd 30100 SetPassphraseZach Hilman1-1/+33
Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.
2019-09-30bcat: Implement cmd RequestSyncDeliveryCache and variantZach Hilman1-2/+70
Variant also supports only updating a single directory. These just both invoke backend commands.
2019-09-30bcat: Implement IDeliveryCacheProgressService commandsZach Hilman1-0/+131
Used to query completion status and events for the current delivery task.
2019-09-30bcat: Implement IDeliveryCacheFileService commandsZach Hilman1-0/+117
Used to read the contents of files and access their metadata.
2019-09-30bcat: Implement IDeliveryCacheDirectoryService commandsZach Hilman1-0/+99
Used to list and get directories at the root level.
2019-09-30bcat: Implement IDeliveryCacheStorageService commandsZach Hilman1-0/+58
Used to create subclasses to manage files and directories and to list directories.
2019-09-30bcat: Add commands to create IDeliveryCacheStorageServiceZach Hilman3-2/+32
Used to access contents of download.
2019-09-30module: Create BCAT backend based upon Settings value on constructionZach Hilman3-1/+36
2019-09-30bcat: Add BCAT backend for Boxcat serviceZach Hilman2-0/+407
Downloads content from yuzu servers and unpacks it into the temporary directory provided. Fully supports all Backend features except passphrase.
2019-09-30bcat: Add backend class to generify the functions of BCATZach Hilman2-0/+100
Provides the most abstract simplified functions of BCAT as functions. Also includes a NullBackend class which is just a no-op.
2019-09-30settings: Add option to set BCAT backendZach Hilman6-0/+34
2019-09-30nifm: Signal to applications that internet access is availableZach Hilman1-3/+10
2019-09-30core/loader: Track the NSO build ID of the current processZach Hilman3-0/+14
2019-09-30applets: Add accessor for AppletFrontendSetZach Hilman2-0/+6
Allows other services to call applets without using LLE.
2019-09-30filesystem: Add getter for BCAT temporary directoryZach Hilman3-0/+16
2019-09-30vfs: Add function to extract ZIP file into virtual filesystemZach Hilman2-0/+96
2019-09-30Revert "arm_dynarmic: Check if jit is nullptr when preparing reschedule"bunnei1-3/+0
2019-09-29Services::ES fix casting warningsFreddyFunk1-6/+6
2019-09-26yuzu: Pause when in backgroundFearlessTobi6-0/+38
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2019-09-24Signal styleset changes at a better timeDavid Marcec1-8/+2
We should signal when a net controller is added and our event should be manual, not automatic.
2019-09-24gl_shader_decompiler: Add tailing return for HUnpack2ReinUsesLisp1-0/+2
2019-09-24gl_shader_decompiler: Fix clang build issuesReinUsesLisp1-26/+23
2019-09-23card_image: Add accessors for raw partitions in XCIZach Hilman2-0/+36
2019-09-23card_image: Lazily load partitions in XCIZach Hilman2-26/+41
2019-09-23pfs: Provide accessors for file sizes and offsetsZach Hilman2-0/+17
2019-09-22cmake: Add SCM detection for AzureZach Hilman1-0/+3
2019-09-22lm: Flush manager output on core shutdownZach Hilman5-11/+15
2019-09-22lm: Rename Initialize to Log and implement with manager/reporterZach Hilman1-140/+22
Allows saving and clearer output of data.
2019-09-22lm: Implement manager class to output to reporterZach Hilman2-0/+233
2019-09-22core: Add LM::Manager to systemZach Hilman6-19/+39
Allows centralized control over logging mechanisms.
2019-09-22reporter: Add log output for packaged lm log dataZach Hilman2-0/+69
Takes the vector from head to tail of log data and saves it.
2019-09-22qt_themes: add two colorful themesFearlessTobi2-1/+3
These two colorful themes are based on the Default and Dark themes, and contain icons that are colored rather than black and white. These icons come from icons8.com and they have been slightly revised by me. I'm pretty sure I was licensed to use them for Citra. Co-Authored-By: Pengfei Zhu <zhupengfei321@sina.cn>
2019-09-22main: Use const on all variable initializationsZach Hilman1-2/+2
2019-09-22Add FPS to SDL title barjroweboy3-2/+17
Also fix a small issue with incorrect shutdown ordering in SDL. Previously the system would still be running so the telemetry task didn't launch and detached_tasks would assert(count == 0)
2019-09-22Add missing includeFearlessTobi1-0/+1
2019-09-22removed commentDavid Marcec1-1/+0
2019-09-22RebasedDavid Marcec3-11/+19
2019-09-22service/acc: Lower log severity from INFO to DEBUGFearlessTobi1-7/+7
According to ogniK, this should have always been Debug and not Info.
2019-09-22Maxwell3D: Corrections and refactors to MME instance refactorFernando Sahmkow4-44/+46
2019-09-22removed unneeded semicolonDavid Marcec1-1/+1
2019-09-22Revert "Merge pull request #2709 from DarkLordZach/oss-ext-fonts-1"David Marcec18-73477/+123
This reverts commit fa1c60c33ef88c6cd0b72da46842dc9098db712d, reversing changes made to e34899067b60a69bca02761bd1290c6824bb559a.
2019-09-22Removed reference to core timing to nvflinger and used system insteadDavid Marcec1-1/+1
2019-09-22marked controller constructors as explicitDavid Marcec8-8/+8
2019-09-22RebaseDavid Marcec25-62/+75
2019-09-22RebaseDavid Marcec5-20/+21
2019-09-22Deglobalize System: ViDavid Marcec3-8/+8
2019-09-22Deglobalize System: TimeDavid Marcec4-14/+21
2019-09-22RebaseDavid Marcec2-8/+12
2019-09-22Deglobalize System: NvFlingerDavid Marcec2-6/+7
2019-09-22RebaseDavid Marcec4-8/+12
2019-09-22Deglobalize System: NimDavid Marcec2-7/+12
2019-09-22Deglobalize System: NifmDavid Marcec2-13/+23
2019-09-22Deglobalize System: NFPDavid Marcec4-14/+16
2019-09-22Deglobalize System: LDRDavid Marcec2-6/+7
2019-09-22Deglobalize System: IRSDavid Marcec3-5/+6
2019-09-22Deglobalize System: HidDavid Marcec20-37/+44
2019-09-22Deglobalize System: FriendDavid Marcec4-22/+24
2019-09-22Deglobalize System: FatalDavid Marcec6-20/+29
2019-09-22Deglobalize System: BtmDavid Marcec2-7/+13
2019-09-22Deglobalize System: BtdrvDavid Marcec2-5/+9
2019-09-22Deglobalize System: AocDavid Marcec2-11/+13
2019-09-22Deglobalize System: AmDavid Marcec1-1/+1
2019-09-22pl_u: Use kernel physical memoryZach Hilman2-4/+8
2019-09-22qt: Prompt user for confirmation if exit lock is activeZach Hilman3-1/+44
2019-09-22dmnt_cheat_vm: Default initialize structure valuesZach Hilman3-89/+88
2019-09-22server side clang format fix2David Marcec1-18/+18
2019-09-22am: Implement ISelfController ExitLock commandsZach Hilman1-2/+6
2019-09-22am: Implement ISelfController ExitZach Hilman4-4/+20
Closes the current application.
2019-09-22am: Add RequestExit event to AppletMessageQueueZach Hilman2-0/+6
Tested against libnx, signals to games to begin cleanup.
2019-09-22core: Track system exit lock statusZach Hilman2-0/+15
Used to determine if yuzu should confirm before pausing or stopping a game.
2019-09-22Use clang-format provided by build serverDavid Marcec1-20/+18
2019-09-22pl_u: Remove excess static qualifierZach Hilman1-1/+1
2019-09-22pl_u: Use OSS system archives if real archives don't existZach Hilman3-111/+42
2019-09-22dmnt_cheat_vm: Make Cheat VM compliant to code styleZach Hilman4-870/+862
2019-09-22core: Initialize cheats after load to avoid VMManager crashZach Hilman1-0/+5
This used to occur due to the VMManager being nullptr at the time cheats were registered (during load, but before it was done). This is bypassed by not accessing the VMManager for offset data until load is complete,
2019-09-22core: Update RegisterCheatList for new VMZach Hilman2-11/+16
2019-09-22patch_manager: Update cheat parsing for new VMZach Hilman2-15/+20
2019-09-22nso: Pass build ID directlyZach Hilman1-2/+1
As opposed to converting to string and then back to hex array
2019-09-22cheat_engine: Move to memory and strip VMZach Hilman5-728/+325
This is to go with the Atmosphere VM port, now it just contains the callbacks needed for the interface between DmntCheatVm and yuzu, along with the cheat parsers.
2019-09-22memory: Port Atmosphere's DmntCheatVmZach Hilman3-0/+1598
This was done because the current VM contained many inaccuracies and this also allows cheats to have identical behavior between hardware and yuzu.
2019-09-22log: Add logging class for Cheat EngineZach Hilman2-0/+2
This is better than just using something like Common.Filesystem or Common.Memory
2019-09-22Fix clang-formatFearlessTobi2-2/+2
2019-09-22fermi_2d: Lower surface copy log severity to DEBUGFearlessTobi1-1/+1
2019-09-22video_core: Implement RGBX16F PixelFormatFearlessTobi7-22/+37
2019-09-22system_archive: Synthesize shared fonts system archivesZach Hilman3-5/+101
2019-09-22pl_u: Expose method to encrypt TTF to BFTTFZach Hilman2-14/+14
2019-09-22externals: Move OSS font data to file_sys in coreZach Hilman13-1/+73324
2019-09-22prepo: Remove system global accessorsZach Hilman3-15/+18
2019-09-22prepo: Implement SaveReport New and System variantsZach Hilman1-15/+71
2019-09-22reporter: Differentiate between Old, New, and System play reportsZach Hilman2-5/+15
2019-09-22configure_debug: Move reporting option to loggingZach Hilman15-63/+64
2019-09-21config: Remove Dump options from configure_debugZach Hilman4-47/+39
2019-09-21filesystem: Add const qualification to various accessorsZach Hilman10-83/+94
2019-09-21yuzu: Add UI to manage filesystem paths and sizesZach Hilman6-1/+627
2019-09-21core: Store FileSystemController in coreZach Hilman2-0/+32
2019-09-21settings: Add options for managing gamecard emulationZach Hilman4-2/+67
2019-09-21settings: Add options for setting storage sizesZach Hilman3-1/+57
2019-09-21yuzu: Port old usages of Filesystem namespace to FilesystemControllerZach Hilman14-46/+106
2019-09-21settings: Update LogSettings to show NAND/SDMC paths from FileUtilZach Hilman1-2/+3
2019-09-21card_image: Add accessors for gamecard certificateZach Hilman2-0/+9
Used by fsp-srv/IDeviceOperator
2019-09-21card_image: Add functions to query gamecard update partitionZach Hilman2-0/+24
Includes version and meta title ID, used by fsp-srv/IDeviceOperator
2019-09-21content_archive: Add accessors for Rights ID and SDK VersionZach Hilman2-0/+10
2019-09-21partition_data_manager: Add accessor for decrypted PRODINFO partitionZach Hilman2-0/+5
2019-09-21services: Pass FileSystemController as reference to services that need itZach Hilman11-20/+47
2019-09-21am: Unstub IApplicationFunctions EnsureSaveData (20)Zach Hilman1-8/+14
Creates a default save data for the application given a user ID.
2019-09-21filesystem: Pass Size Getter functions to IFileSystem for sizesZach Hilman3-20/+31
2019-09-21sdmc_factory: Add SD Card size gettersZach Hilman2-0/+12
2019-09-21bis_factory: Add getters for NAND partition sizesZach Hilman2-0/+38
2019-09-21filesystem: Add FileSystemController to deglobalize FS servicesZach Hilman2-58/+359
2019-09-21submisson_package: Fix edge case with improperly sized filenamesZach Hilman1-1/+2
Prevents a crash if the filename is less than 9 characters long.
2019-09-21sdmc_factory: Add accessor for SDMC Album directoryZach Hilman2-0/+6
2019-09-21sdmc_factory: Add accessor for SDMC PlaceholderCacheZach Hilman2-1/+10
2019-09-21sdmc_factory: Add accessor for content directoryZach Hilman2-0/+7
2019-09-21savedata_factory: Implement savedata creation and don't create dir on openZach Hilman2-26/+40
Matches hardware behavior and eliminates some nasty behavior we were doing that wasn't hw-accurate at all.
2019-09-21patch_manager: Add short-circuit edge-case to GetPatchVersionNamesZach Hilman1-0/+2
If title ID is 0, there are no add ons, prevents wasting time looking for them.
2019-09-21patch_manager: Add error checking to load dir to prevent crashesZach Hilman1-0/+15
Prevents a crash if the load dir would be nullptr, instead logs an error and returns appropriately.
2019-09-21registered_cache: Process *.cnmt.nca filesZach Hilman1-16/+23
Needed to use the RegisteredCache/PlaceholderCache on gamecards.
2019-09-21registered_cache: Implement PlaceholderCache to manage placeholder and installing contentZach Hilman2-0/+175
2019-09-21bis_factory: Fix mod loader edge-case with homebrew title IDsZach Hilman1-1/+1
Fixes a bug where homebrew that has a title ID with the update bit set can cause issues with the PatchManager
2019-09-21bis_factory: Add accessors for BIS placeholder cachesZach Hilman2-1/+20
2019-09-21bis_factory: Add accessor for NAND Image DirectoryZach Hilman2-0/+6
2019-09-21bis_factory: Add accessors for BIS content directoriesZach Hilman2-0/+11
2019-09-21bis_factory: Add accessors for BIS partitionsZach Hilman2-0/+61
2019-09-21gl_shader_decompiler: Use uint for images and fix SUATOMReinUsesLisp7-188/+93
In the process remove implementation of SUATOM.MIN and SUATOM.MAX as these require a distinction between U32 and S32. These have to be implemented with imageCompSwap loop.
2019-09-21shader/image: Implement SULD and remove irrelevant codeReinUsesLisp10-47/+110
* Implement SULD as float. * Remove conditional declaration of GL_ARB_shader_viewport_layer_array.
2019-09-21shader_bytecode: Add SULD encodingReinUsesLisp1-0/+2
2019-09-21Shader_IR: ICMP corrections and fixesFernando Sahmkow2-6/+11
2019-09-21Added Host CPU and OS to logpbarilla1-0/+8
2019-09-21Swapped TID and Game name to make it easier to parseDavid Marcec1-1/+1
2019-09-21Log the current title id and game name which is bootingDavid Marcec1-3/+3
Spit out a LOG_INFO of the current game name and it's title id in the log. This helps to read log files and figure out which games have which issues
2019-09-21Used revision 5 instead of 7, marked constexpr as staticDavid Marcec1-2/+2
2019-09-21Mark DrawArrays as LOG_TRACEDavid Marcec1-1/+1
There's no reason to clog logs with DrawArray.
2019-09-21Mark KickOffPb & SubmitGPFIFO as traceDavid Marcec1-4/+4
These functions are not stubbed and are called fairly often. Due to the nature of how often they're called, we should keep them marked as LOG_TRACE instead of LOG_DEBUG or LOG_WARNING
2019-09-20Rasterizer: Correct introduced bug where a conditional render wouldn't stop a draw call from executingFernando Sahmkow1-10/+16
2019-09-20Shader_IR: Implement ICMP.Fernando Sahmkow2-0/+37
2019-09-20Added frame_count for REV7 audio rendererDavid Marcec2-11/+24
Added framecount
2019-09-20disable clang-format tempDavid Marcec1-0/+2
2019-09-19Rasterizer: Refactor and simplify DrawBatch Interface.Fernando Sahmkow4-35/+16
2019-09-19Rasterizer: Address Feedback and conscerns.Fernando Sahmkow1-11/+11
2019-09-19Rasterizer: Refactor draw calls, remove deadcode and clean up.Fernando Sahmkow3-106/+68
2019-09-19VideoCore: Corrections to the MME Inliner and removal of hacky instance management.Fernando Sahmkow6-31/+81
2019-09-19Video Core: initial Implementation of InstanceDraw PackagingFernando Sahmkow7-11/+192
2019-09-19Initial implementation of Ioctl2 & Ioctl3David Marcec24-63/+143
Purpose of Ioctl2 and Ioctl3 is to prevent the passing of raw pointers through ioctls
2019-09-19Core/Memory: Only FlushAndInvalidate GPU if the page is marked as RasterizerCachedMemoryFernando Sahmkow1-2/+7
This commit avoids Invalidating and Flushing the GPU if the page is not marked as a RasterizerCache Page.
2019-09-17shader_ir/warp: Implement SHFLReinUsesLisp6-9/+182
2019-09-17maxwell_to_gl: Fix mipmap filteringReinUsesLisp1-2/+2
OpenGL texture filters follow GL_<texture_filter>_MIPMAP_<mipmap_filter> but we were using them in the opposite way.
2019-09-17gl_rasterizer: Remove unused code paths from ConfigureFramebuffersReinUsesLisp4-121/+33
2019-09-17When docked mode is checked, uncheck "joycons docked"Morph1-0/+2
2019-09-15maxwell_3d: Update firmware 4 call stub commentaryRodrigo Locatti1-1/+2
2019-09-13vk_device: Add miscellaneous features and minor style changesReinUsesLisp3-111/+258
* Increase minimum Vulkan requirements * Require VK_EXT_vertex_attribute_divisor * Require depthClamp, samplerAnisotropy and largePoints features * Search and expose VK_KHR_uniform_buffer_standard_layout * Search and expose VK_EXT_index_type_uint8 * Search and expose native float16 arithmetics * Track current driver with VK_KHR_driver_properties * Query and expose SSBO alignment * Query more image formats * Improve logging overall * Minor style changes * Minor rephrasing of commentaries
2019-09-13video_core/surface: Add function to detect sRGB surfacesReinUsesLisp2-0/+22
This is required for proper conversion to RGBA8_UNORM or RGBA8_SRGB surfaces when a backend can target both native and converted ASTC.
2019-09-11renderer_opengl: Fix rebase mistakeReinUsesLisp1-1/+1
2019-09-11shader/image: Implement SUATOM and fix SUSTReinUsesLisp7-69/+329
2019-09-11gl_rasterizer: Correct sRGB Fix regressionFernando Sahmkow1-0/+12
2019-09-11renderer_opengl: Fix sRGB blitsReinUsesLisp6-43/+10
Removes the sRGB hack of tracking if a frame used an sRGB rendertarget to apply at least once to blit the final texture as sRGB. Instead of doing this apply sRGB if the presented image has sRGB. Also enable sRGB by default on Maxwell3D registers as some games seem to assume this.
2019-09-10Address review commentsFearlessTobi2-6/+9
2019-09-10Add frametime logging for tracking performance over timefearlessTobi7-10/+90
Co-Authored-By: jroweboy <jroweboy@gmail.com>
2019-09-07nro: Implement ReadControlDataNick Renieris2-0/+10
With this, the "Developer" field in the Properties for homebrew is now populated. Signed-off-by: Nick Renieris <velocityra@gmail.com>
2019-09-06gl_shader_decompiler: Avoid writing output attribute when unimplementedReinUsesLisp1-10/+14
2019-09-06gl_shader_decompiler: Keep track of written images and mark them as modifiedReinUsesLisp7-62/+92
2019-09-06texture_cache: Minor changesReinUsesLisp4-19/+17
2019-09-06gl_rasterizer: Apply textures and images stateReinUsesLisp1-0/+2
2019-09-06gl_rasterizer: Add samplers to compute dispatchesReinUsesLisp2-3/+36
2019-09-06gl_rasterizer: Minor code changesReinUsesLisp2-20/+31
2019-09-06gl_state: Split textures and samplers into two arraysReinUsesLisp4-91/+39
2019-09-06gl_rasterizer: Implement image bindingsReinUsesLisp5-32/+106
2019-09-06gl_state: Add support for glBindImageTexturesReinUsesLisp2-0/+24
2019-09-06texture_cache: Pass TIC to texture cacheReinUsesLisp4-27/+25
2019-09-06kepler_compute: Implement texture queriesReinUsesLisp5-5/+99
2019-09-06gl_rasterizer: Split SetupTexturesReinUsesLisp2-22/+38
2019-09-05gl_shader_decompiler: Implement shared memoryReinUsesLisp1-0/+23
2019-09-05shader_ir: Implement LD_SReinUsesLisp1-10/+13
Loads from shared memory.
2019-09-05shader_ir: Implement ST_SReinUsesLisp4-11/+45
This instruction writes to a memory buffer shared with threads within the same work group. It is known as "shared" memory in GLSL.
2019-09-05Address review commentsFearlessTobi1-1/+4
2019-09-05service/am: Remove usages of global system accessorsLioncash17-97/+143
Avoids the use of global accessors, removing the reliance on global state. This also makes dependencies explicit in the interface, as opposed to being hidden
2019-09-05yuzu/configure: move speed limiter to generalFearlessTobi4-33/+36
The speed limiter being a frame limiter is an implmentation detail and can be changed in the future. What user care about is that it limit the emulation speed in genenral (not just graphics but also audio+input) Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
2019-09-05kernel/vm_manager: Correct doxygen comment parameter tags for MapPhysicalMemory/UnmapPhysicalMemoryLioncash1-4/+4
Corrects the parameter names within the doxygen comments so that they resolve properly.
2019-09-05kernel/vm_manager: Move variables closer to usage spots in MapPhysicalMemory/UnmapPhysicalMemoryLioncash1-16/+10
Narrows the scope of variables down to where they're only necessary.
2019-09-04gl_shader_decompiler: Fixup slow pathReinUsesLisp1-1/+1
2019-09-04AM: Stub IApplicationFunctions::GetGpuErrorDetectedSystemEvent (#2827)mailwl2-0/+16
* AM: Implement IApplicationFunctions::GetGpuErrorDetectedSystemEvent * Remove unneeded event clear * Fix event name
2019-09-04configure_dialog: reverse tab map to avoid logic based on user-facing/translatable textfearlessTobi1-20/+24
Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
2019-09-04Fix clang-formatEthan1-1/+1
2019-09-04Fix uisettings includefearlessTobi1-1/+1
2019-09-04Limit the size of directory icons, fix text when icon size is nonefearlessTobi2-4/+3
2019-09-04Change QList to QVectorfearlessTobi5-16/+19
2019-09-04Separate UserNand and Sdmc directoriesfearlessTobi5-32/+59
2019-09-04Address more trivial review commentsfearlessTobi4-25/+18
2019-09-04Address trivial review commentsfearlessTobi7-53/+59
2019-09-04yuzu: Add support for multiple game directoriesfearlessTobi12-195/+666
Ported from https://github.com/citra-emu/citra/pull/3617.
2019-09-04dittoMorph19841-1/+1
Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
2019-09-04IsVibrationEnabled() as a const member funcMorph19841-1/+1
2019-09-04clang-formatMorph19841-2/+2
2019-09-04Update npad.hMorph19841-0/+1
2019-09-04Update npad.cppMorph19841-0/+6
2019-09-04Update hid.hMorph19841-0/+2
2019-09-04Update hid.cppMorph19841-2/+23
2019-09-04gl_rasterizer: Fix stencil testingReinUsesLisp1-11/+11
* Fix stencil dirty flags tracking when stencil is disabled * Attach stencil on clears (previously it only attached depth) * Attach stencil on drawing regardless of stencil testing being enabled
2019-09-04Revert "Revert #2466" and stub FirmwareCall 4ReinUsesLisp3-4/+19
2019-09-04shader/shift: Implement SHR wrapped and clamped variantsReinUsesLisp2-6/+17
Nvidia defaults to wrapped shifts, but this is undefined behaviour on OpenGL's spec. Explicitly mask/clamp according to what the guest shader requires.
2019-09-04maxwell_3d: Avoid moving macro_paramsReinUsesLisp4-12/+24
2019-09-04gl_shader_cache: Remove special casing for geometry shadersReinUsesLisp2-80/+9
Now that ProgramVariants holds the primitive topology we no longer need to keep track of individual geometry shaders topologies.
2019-09-04half_set_predicate: Fix predicate assignmentsReinUsesLisp1-10/+9
2019-09-04gl_device: Disable precise in fragment shaders on bugged driversReinUsesLisp3-15/+43
2019-09-04gl_shader_decompiler: Fixup AMD's slow path typeReinUsesLisp1-1/+1
2019-09-04gl_shader_decompiler: Rework GLSL decompiler type systemReinUsesLisp1-416/+505
GLSL decompiler type system was broken. We converted all return values to float except for some cases where returning we couldn't and implicitly broke the rule of returning floats (e.g. for bools or bool pairs). Instead of doing this introduce class Expression that knows what type a return value has and when a consumer wants to use the string it asks for it with a required type, emitting a runtime error if types are incompatible. This has the disadvantage that there's more C++ code, but we can emit better GLSL code that's easier to read.
2019-09-04Add Kernel::EventPair audio_input_device_switch_event;Morph19841-0/+1
2019-09-04remove <f32>Morph19841-1/+1
We can remove this since its already a f32 value
2019-09-04audren_u: Stub IAudioDevice::QueryAudioDeviceInputEventMorph19841-1/+14
2019-09-04explicitly represent 1 as a float (1.0f instead of 1)Morph19841-1/+1
2019-09-04Change u32 -> f32Morph19841-1/+1
Volume is a f32 value. (SwIPC describes it as a u32, but it is actually f32 as corroborated by switchbrew docs and SetAudioDeviceOutputVolume) ```cpp const f32 volume = rp.Pop<f32>(); ```
2019-09-04configuration/config: Add missing screenshot path readfearlessTobi1-0/+1
I missed this in my original PR (https://github.com/yuzu-emu/yuzu/pull/1886).
2019-09-03Fix to Windows sleep issuesfearlessTobi2-0/+22
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2019-09-03Add cancel option to analog stick configurationfearlessTobi1-7/+10
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
2019-09-03service/audio/audren_u: Stub IAudioDevice::GetAudioDeviceOutputVolumeMorph19841-2/+15
2019-09-01maxwell_3d: Fix macro binding cursorReinUsesLisp2-10/+4
2019-08-30video_core: Silent miscellaneous warnings (#2820)Rodrigo Locatti23-48/+22
* texture_cache/surface_params: Remove unused local variable * rasterizer_interface: Add missing documentation commentary * maxwell_dma: Remove unused rasterizer reference * video_core/gpu: Sort member declaration order to silent -Wreorder warning * fermi_2d: Remove unused MemoryManager reference * video_core: Silent unused variable warnings * buffer_cache: Silent -Wreorder warnings * kepler_memory: Remove unused MemoryManager reference * gl_texture_cache: Add missing override * buffer_cache: Add missing include * shader/decode: Remove unused variables
2019-08-30kernel/vm_manager: Correct behavior in failure case of UnmapPhysicalMemory()Lioncash1-0/+2
If an unmapping operation fails, we shouldn't be decrementing the amount of memory mapped and returning that the operation was successful. We should actually be returning the error code in this case.
2019-08-30kernel/vm_manager: Reserve memory ahead of time for slow path in MergeAdjacentVMALioncash1-1/+4
Avoids potentially expensive (depending on the size of the memory block) allocations by reserving the necessary memory before performing both insertions. This avoids scenarios where the second insert may cause a reallocation to occur.
2019-08-30kernel/vm_manager: std::move shared_ptr instance in MergeAdjacentVMALioncash1-1/+1
Avoids an unnecessary atomic reference count increment and decrement.
2019-08-30kernel/vm_manager: Deduplicate iterator creation in MergeAdjacentVMALioncash1-7/+10
Avoids needing to read the same long sequence of code in both code paths. Also makes it slightly nicer to read and debug, as the locals will be able to be shown in the debugger.
2019-08-30kernel/vm_manager: Simplify some std::vector constructor callsLioncash1-2/+2
Same behavior, one less magic constant to read.
2019-08-30kernel/vm_manager: Simplify some assertion messagesLioncash1-10/+10
Assertions already log out the function name, so there's no need to manually include the function name in the assertion strings.
2019-08-30gl_buffer_cache: Add missing includeReinUsesLisp1-0/+1
RasterizerInterface was considered an incomplete object by clang.
2019-08-29accommodate for fmt updateEthan2-2/+2
2019-08-28shader_ir/conversion: Split int and float selector and implement F2F H1ReinUsesLisp2-19/+24
2019-08-28shader_ir/conversion: Implement F2I F16 Ra.H1ReinUsesLisp2-6/+17
2019-08-28float_set_predicate: Add missing negation bit for the second operandReinUsesLisp2-4/+6
2019-08-22Guard unistd.h with MacOS only macroWeiyi Wang1-1/+3
Fix compile error on Windows caused by #4877 Weird, I thought I saw this guard during the code review...
2019-08-22citra_qt: on osx chdir to bundle dir to allow detection of user folderB3n301-0/+6
2019-08-21shader_ir: Implement VOTEReinUsesLisp12-1/+163
Implement VOTE using Nvidia's intrinsics. Documentation about these can be found here https://developer.nvidia.com/reading-between-threads-shader-intrinsics Instead of using portable ARB instructions I opted to use Nvidia intrinsics because these are the closest we have to how Tegra X1 hardware renders. To stub VOTE on non-Nvidia drivers (including nouveau) this commit simulates a GPU with a warp size of one, returning what is meaningful for the instruction being emulated: * anyThreadNV(value) -> value * allThreadsNV(value) -> value * allThreadsEqualNV(value) -> true ballotARB, also known as "uint64_t(activeThreadsNV())", emits VOTE.ANY Rd, PT, PT; on nouveau's compiler. This doesn't match exactly to Nvidia's code VOTE.ALL Rd, PT, PT; Which is emulated with activeThreadsNV() by this commit. In theory this shouldn't really matter since .ANY, .ALL and .EQ affect the predicates (set to PT on those cases) and not the registers.
2019-08-21Buffer Cache: Adress Feedback.Fernando Sahmkow2-7/+6
2019-08-21Buffer_Cache: Implement flushing.Fernando Sahmkow2-1/+30
2019-08-21Buffer_Cache: Implement barriers.Fernando Sahmkow1-0/+4
2019-08-21Buffer_Cache: Optimize and track written areas.Fernando Sahmkow2-12/+104
2019-08-21BufferCache: Rework mapping caching.Fernando Sahmkow2-49/+76
2019-08-21Buffer_Cache: Fixes and optimizations.Fernando Sahmkow2-68/+38
2019-08-21Video_Core: Implement a new Buffer CacheFernando Sahmkow9-327/+560
2019-08-21renderer_opengl: Implement RGB565 framebuffer formatReinUsesLisp3-3/+9
2019-08-21renderer_opengl: Use block linear swizzling for CPU framebuffersReinUsesLisp3-150/+33
2019-08-21renderer_opengl: Use VideoCore pixel formatReinUsesLisp3-23/+11
2019-08-21gpu: Change optional<reference_wrapper<T>> to T* for FramebufferConfigReinUsesLisp11-32/+22
2019-08-17Fixup! #2772 missed this one fileJames Rowe1-1/+1
2019-08-09yuzu/CMakeLists: Remove qt5_wrap_ui macro usageLioncash16-44/+39
We can simply enable CMAKE_AUTOUIC and let CMake take care of handling the UI code generation for targets. As part of letting CMake automatically handle the header file parsing, we must not name includes with "ui_*" unless they're related to the output of the Qt UIC compiler. Because of this, we need to rename ui_settings, given it would conflict with this restriction.
2019-08-04shader_ir: Implement NOPReinUsesLisp2-0/+13
2019-08-04half_set_predicate: Fix HSETP2_C constant buffer offsetReinUsesLisp1-1/+1
2019-08-02Qt: Fixed behaviour of buttons by connecting functors to correct signalsSilent7-21/+21
Following screens got fixes: - Configure/Debug - Configure/Input
2019-07-30yuzu-tester/yuzu: Correct format stringLioncash1-1/+1
Prevents an invalid formatting exception from being thrown.
2019-07-30yuzu-tester/yuzu: Remove unused variableLioncash1-1/+0
Gets rid of a compilation warning.
2019-07-26GPU: Flush commands on every dma pusher step.Fernando Sahmkow6-0/+15
This commit ensures that the host gpu is constantly fed with commands to work with, while the guest gpu keeps producing the rest of the commands. This reduces syncing time between host and guest gpu.
2019-07-26decode/half_set_predicate: Fix predicatesReinUsesLisp1-3/+3
2019-07-26MaxwellDMA: Fixes, corrections and relaxations.Fernando Sahmkow3-23/+36
This commit fixes offsets on Linear -> Tiled copies, corrects z pos fortiled->linear copies, corrects bytes_per_pixel calculation in tiled -> linear copies and relaxes some limitations set by latest dma fixes refactors.
2019-07-22shader/decode: Implement S2R TicReinUsesLisp3-0/+15
2019-07-20Shader_Ir: Implement F16 Variants of F2F, F2I, I2F.Fernando Sahmkow5-18/+75
This commit takes care of implementing the F16 Variants of the conversion instructions and makes sure conversions are done.
2019-07-20Maxwell3D: Reorganize and address feedbackFernando Sahmkow3-20/+33
2019-07-20Shader_Ir: Change Debug Asserts for Log WarningsFernando Sahmkow3-10/+17
2019-07-20Common/Alignment: Add noexcept where required.Fernando Sahmkow1-5/+5
2019-07-20shader/half_set_predicate: Fix HSETP2 implementationReinUsesLisp4-44/+23
2019-07-20shader/half_set_predicate: Implement missing HSETP2 variantsReinUsesLisp2-19/+49
2019-07-19Kernel: Address FeedbackFernando Sahmkow3-6/+11
2019-07-19Common: Correct alignment allocator to work on C++14 or higher.Fernando Sahmkow1-37/+19
2019-07-19VM_Manager: Align allocated memory to 256bytesFernando Sahmkow15-36/+131
This commit ensures that all backing memory allocated for the Guest CPU is aligned to 256 bytes. This due to how gpu memory works and the heavy constraints it has in the alignment of physical memory.
2019-07-19service/audren_u: Handle audio USB output revision queries in ListAudioDeviceName()Lioncash2-16/+45
Audio devices use the supplied revision information in order to determine if USB audio output is able to be supported. In this case, we can only really handle using this revision information in ListAudioDeviceName(), where it checks if USB audio output is supported before supplying it as a device name. A few other scenarios exist where the revision info is checked, such as: - Early exiting from SetAudioDeviceOutputVolume if USB audio is attempted to be set when that device is unsupported. - Early exiting and returning 0.0f in GetAudioDeviceOutputVolume when USB output volume is queried and it's an unsupported device. - Falling back to AHUB headphones in GetActiveAudioDeviceName when the device type is USB output, but is unsupported based off the revision info. In order for these changes to also be implemented, a few other changes to the interface need to be made. Given we now properly handle everything about ListAudioDeviceName(), we no longer need to describe it as a stubbed function.
2019-07-19service/audren_u: Move revision testing code out of AudRenULioncash2-63/+63
The revision querying facilities are used by more than just audren. e.g. audio devices can use this to test whether or not USB audio output is supported. This will be used within the following change.
2019-07-19service/audio: Remove global system accessorsLioncash7-34/+54
Trims out the lingering reliance on global state out of the audio code.
2019-07-19service/audren_u: Remove unnecessary return value from GetActiveAudioDeviceName()Lioncash1-2/+1
This service function only ever returns a result and nothing more.
2019-07-19service/audren_u: Report proper device namesLioncash1-6/+29
AudioDevice and AudioInterface aren't valid device names on the Switch. We should also be returning consistent names in GetActiveAudioDeviceName(). While we're at it, we can also handle proper name output in ListAudioDeviceName, by returning all the available devices on the Switch.
2019-07-19video_core/control_flow: Provide operator!= for types with operator==Lioncash1-4/+21
Provides operational symmetry for the respective structures.
2019-07-19video_core/control_flow: Prevent sign conversion in TryGetBlock()Lioncash1-1/+1
The return value is a u32, not an s32, so this would result in an implicit signedness conversion.
2019-07-19video_core/control_flow: Remove unnecessary BlockStack copy constructorLioncash1-2/+1
This is the default behavior of the copy constructor, so it doesn't need to be specified. While we're at it we can make the other non-default constructor explicit.
2019-07-19video_core/control_flow: Use std::move where applicableLioncash1-10/+15
Results in less work being done where avoidable.
2019-07-19video_core/control_flow: Use the prefix variant of operator++ for iteratorsLioncash1-2/+2
Same thing, but potentially allows a standard library implementation to pick a more efficient codepath.
2019-07-19video_core/control_flow: Use empty() member function for checking emptinessLioncash1-2/+2
It's what it's there for.
2019-07-19video_core: Resolve -Wreorder warningsLioncash2-4/+3
Ensures that the constructor members are always initialized in the order that they're declared in.
2019-07-19video_core/control_flow: Make program_size for ScanFlow() a std::size_tLioncash2-5/+4
Prevents a truncation warning from occurring with MSVC. Also the internal data structures already treat it as a size_t, so this is just a discrepancy in the interface.
2019-07-19video_core/control_flow: Place all internally linked types/functions within an anonymous namespaceLioncash1-1/+2
Previously, quite a few functions were being linked with external linkage.
2019-07-19video_core/shader/decode: Prevent sign-conversion warningsLioncash1-2/+2
Makes it explicit that the conversions here are intentional.
2019-07-18Shader_Ir: correct clang formatFernando Sahmkow1-2/+2
2019-07-18GPU: Add missing puller methods.Fernando Sahmkow2-14/+15
This adds some missing puller methods. We don't assert them as these are nop operations for us.
2019-07-18MaxwellDMA/KeplerCopy: Downgrade DMA log message to Trace.Fernando Sahmkow1-1/+1
This log was just to know which games used DMA. It's no longer important.
2019-07-18Gl_Texture_Cache: Remove assert on component type in GetFormatTupleFernando Sahmkow1-1/+0
Textures can have different components types in different orders. This assert was completely inprecise and the effectiveness of such is better handled by case and within the texture cache.
2019-07-18Shader_Ir: Downgrade precision and rounding asserts to debug asserts.Fernando Sahmkow5-10/+10
This commit reduces the sevirity of asserts for FP precision and rounding as this are well known and have little to no consequences in gpu's accuracy.
2019-07-18gl_shader_decompiler: Rename bufferImage to imageBufferReinUsesLisp1-1/+1
The online OpenGL documentation is wrong. The type definition is imageBuffer.
2019-07-18gl_shader_cache: Fix newline on buffer preprocessor definitionsReinUsesLisp1-2/+6
2019-07-18textures: Fix texture buffer size calculationReinUsesLisp1-1/+1
2019-07-18gl_texture_cache: Do not set texture parameters to buffersReinUsesLisp1-0/+3
2019-07-18gl_texture_cache: Add missing break in CreateTextureReinUsesLisp1-0/+1
2019-07-18Kernel: Downgrade WaitForAddress and SignalToAddress messages to Trace.Fernando Sahmkow1-4/+4
This messages were originally set as warnning since few games used these svcs and it was needed for debugging. This is no longer the case.
2019-07-17GL_State: Feedback and fixesFernando Sahmkow4-14/+27
2019-07-17Maxwell3D: Address FeedbackFernando Sahmkow5-17/+13
2019-07-17Texture_Cache: Rebase FixesFernando Sahmkow1-6/+0
2019-07-17GL_Rasterizer: Corrections to Clearing.Fernando Sahmkow4-12/+28
2019-07-17Maxwell3D: Correct marking dirtiness on CB uploadFernando Sahmkow1-0/+1
2019-07-17GL_Rasterizer: Rework RenderTarget/DepthBuffer clearingFernando Sahmkow3-7/+63
2019-07-17Maxwell3D: Implement State Dirty Flags.Fernando Sahmkow6-44/+199
2019-07-17Maxwell3D: Rework CBData UploadFernando Sahmkow2-8/+45
2019-07-17Maxwell3D: Rework the dirty system to be more consistant and scaleableFernando Sahmkow10-80/+211
2019-07-17maxwell3d: Implement Conditional RenderingFernando Sahmkow3-2/+100
Conditional Rendering takes care of conditionaly clearing or drawing depending on a set of queries. This PR implements the query checks to stablish if things can be rendered or not.
2019-07-17shader_ir: std::move Node instance where applicableLioncash4-60/+67
These are std::shared_ptr instances underneath the hood, which means copying them isn't as cheap as a regular pointer. Particularly so on weakly-ordered systems. This avoids atomic reference count increments and decrements where they aren't necessary for the core set of operations.
2019-07-17shader_ir: Rename Get/SetTemporal to Get/SetTemporaryLioncash5-36/+36
This is more accurate in terms of describing what the functions are actually doing. Temporal relates to time, not the setting of a temporary itself.
2019-07-17shader_ir: Remove unused includesLioncash1-3/+0
Removes unnecessary header dependencies.
2019-07-16Shader_Ir: Correct tracking to track from right to leftFernando Sahmkow1-2/+2
2019-07-16shader/decode/other: Correct branch indirect argument within BRA handlingLioncash1-1/+1
This appears to have been a copy/paste error introduced within 8a6fc529a968e007f01464abadd32f9b5eb0a26c
2019-07-16gl_shader_cache: Fix clang-format issuesReinUsesLisp2-4/+2
2019-07-15gl_shader_decompiler: Stub local memory sizeReinUsesLisp1-8/+14
2019-07-15gl_shader_cache: Address review commentariesReinUsesLisp4-13/+12
2019-07-15gl_shader_cache: Address CI issuesReinUsesLisp2-3/+3
2019-07-15gl_rasterizer: Implement compute shadersReinUsesLisp15-136/+350
2019-07-15shader: Allow tracking of indirect buffers without variable offsetReinUsesLisp6-35/+36
While changing this code, simplify tracking code to allow returning the base address node, this way callers don't have to manually rebuild it on each invocation.
2019-07-14Texture_Cache: Address FeedbackFernando Sahmkow3-13/+17
2019-07-14Texture_Cache: Remove some unprecise fallback case and clang formatFernando Sahmkow2-13/+5
2019-07-14Texture_Cache: Force Framebuffer reset if an active render target is unregistered.Fernando Sahmkow3-10/+36
2019-07-14GPU: Add a microprofile for macro interpreterFernando Sahmkow2-1/+6
2019-07-14GL_State: Add a microprofile timer to OpenGL state.Fernando Sahmkow1-0/+4
2019-07-14Gl_Texture_Cache: Measure Buffer Copy TimesFernando Sahmkow1-0/+2
2019-07-14Texture_Cache: Correct Linear Structural Match.Fernando Sahmkow1-3/+6
2019-07-13core: Remove CurrentArmInterface() global accessorLioncash2-7/+6
Replaces the final usage of the global accessor function and removes it. Removes one more enabler of global state.
2019-07-12Clang formatDavid Marcec3-4/+8
2019-07-12Addressed issuesDavid Marcec2-2/+2
2019-07-12"AudioRenderer" thread should have a unique nameDavid Marcec4-7/+8
Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
2019-07-12Remove unicorn mappings/unmappingsMichael Scire1-19/+0
2019-07-11gl_shader_decompiler: Fix gl_PointSize redeclarationReinUsesLisp1-1/+1
2019-07-11service/am: Implement IsAutoSleepDisabledLioncash2-1/+10
This simply queries whether or not auto-sleep facilities are disabled and has no special handling. It's a basic getter function.
2019-07-11service/am: Implement SetAutoSleepDisabledLioncash2-1/+23
Provides a basic implementation of SetAutoSleepDisabled. Until idle handling is implemented, this is about the best we can do. In the meantime, provide a rough documenting of specifics that occur when this function is called on actual hardware.
2019-07-11yuzu: Remove setting for using UnicornLioncash9-29/+6
The JIT is mature enough that this setting can be removed, falling back to Unicorn only on unsupported architectures. Any missing features from Unicorn (of which there are extremely few), are mostly developer-oriented, which most users don't care about. Features should be coordinated with the JIT, not the interpreter, anyhow.
2019-07-11core/arm: Remove obsolete Unicorn memory mappingLioncash6-51/+0
This was initially necessary when AArch64 JIT emulation was in its infancy and all memory-related instructions weren't implemented. Given the JIT now has all of these facilities implemented, we can remove these functions from the CPU interface.
2019-07-11Restore memory perms on svcUnmapMemory/UnloadNroMichael Scire2-7/+34
Prior to PR, Yuzu did not restore memory to RW- on unmap of mirrored memory or unloading of NRO. (In fact, in the NRO case, the memory was unmapped instead of reprotected to --- on Load, so it was actually lost entirely...) This PR addresses that, and restores memory to RW- as it should. This fixes a crash in Super Smash Bros when creating a World of Light save for the first time, and possibly other games/circumstances.
2019-07-11gl_shader_decompiler: Fix conditional usage of GL_ARB_shader_viewport_layer_arrayReinUsesLisp1-2/+3
2019-07-10system_archive: Add open-source reimplementation of MiiModel dataZach Hilman4-1/+63
2019-07-10mii: Handle logging of unknown database sourceZach Hilman1-0/+4
2019-07-09shader_ir: Add comments on missing instruction.Fernando Sahmkow2-2/+9
Also shows Nvidia's address space on comments.
2019-07-09prefer system reference over global accessorMichael Scire3-9/+13
2019-07-09shader_ir: limit explorastion to best known program size.Fernando Sahmkow1-1/+1
2019-07-09control_flow: Correct block breaking algorithm.Fernando Sahmkow1-17/+17
2019-07-09control_flow: Assert shaders bigger than limit.Fernando Sahmkow1-0/+2
2019-07-09control_flow: Address feedback.Fernando Sahmkow1-89/+37
2019-07-09shader_ir: Correct parsing of scheduling instructions and correct sizingFernando Sahmkow2-13/+30
2019-07-09shader_ir: Correct max sizingFernando Sahmkow2-2/+2
2019-07-09shader_ir: Remove unnecessary constructors and use optional for ScanFlow resultFernando Sahmkow3-28/+17
2019-07-09shader_ir: Corrections, documenting and asserting control_flowFernando Sahmkow3-52/+54
2019-07-09shader_ir: Unify blocks in decompiled shaders.Fernando Sahmkow7-58/+85
2019-07-09shader_ir: Decompile Flow StackFernando Sahmkow4-11/+206
2019-07-09shader_ir: propagate shader size to the IRFernando Sahmkow6-17/+28
2019-07-09shader_ir: Implement BRX & BRA.CCFernando Sahmkow6-4/+76
2019-07-09shader_ir: Remove the old scanner.Fernando Sahmkow2-77/+0
2019-07-09shader_ir: Implement a new shader scannerFernando Sahmkow5-16/+475
2019-07-09IFriendService::GetFriendListDavid Marcec1-1/+34
We don't have any friends implemented in Yuzu yet so it doesn't make sense to return any friends. For now we'll be returning 0 friends however the information provided will allow a proper implementation of this cmd when needed.
2019-07-09gl_rasterizer: Amend documentation comment for ConfigureFramebuffers()Lioncash1-7/+9
must_reconfigure isn't a parameter for this function any more, so it can be replaced with current_state. While we're at it, we can make the parameters of the declaration match the same name as the ones in the definition.
2019-07-09Prevent merging of device mapped memory blocks.Michael Scire2-1/+28
This sets the DeviceMapped attribute for GPU-mapped memory blocks, and prevents merging device mapped blocks. This prevents memory mapped from the gpu from having its backing address changed by block coalesce.
2019-07-08addressed issuesDavid Marcec1-6/+7
2019-07-08addressed issueDavid Marcec1-1/+1
2019-07-08key_manager: Convert Ticket union to std::variantZach Hilman3-57/+88
2019-07-08es: Populate/synthesize tickets on constructionZach Hilman3-15/+17
2019-07-08key_manager: Add structure for Ticket parsingZach Hilman3-44/+194
2019-07-08es: Implement ETicket GetPersonalizedTicketData (17)Zach Hilman1-1/+21
Copies the raw personal ticket data into the buffer provided.
2019-07-08es: Implement ETicket GetCommonTicketData (16)Zach Hilman1-1/+20
Copies the raw common ticket data for the specified rights ID into the buffer provided.
2019-07-08es: Implement ETicket GetPersonalizedTicketSize (15)Zach Hilman1-1/+17
Returns the size of the buffer needed to hold the personal ticket associated with the rights ID.
2019-07-08es: Implement ETicket GetCommonTicketSize (14)Zach Hilman1-1/+17
Returns the size of the buffer needed to hold the common ticket associated with the rights ID.
2019-07-08es: Implement ETicket ListPersonalizedTicket (12)Zach Hilman1-1/+24
Returns an application-specific number of entries of personal tickets, starting at offset 0.
2019-07-08es: Implement ETicket ListCommonTicket (11)Zach Hilman1-1/+24
Returns an application specified count of entries of common tickets, starting at offset 0.
2019-07-08es: Implement ETicket CountPersonalizedTicket (10)Zach Hilman1-1/+12
Returns the number of personalized (console/user-unique) tickets in the KeyManager.
2019-07-08es: Implement ETicket CountCommonTicket (9)Zach Hilman1-1/+12
Returns the number of common (non-console-unique) tickets in the KeyManager.
2019-07-08es: Implement ETicket GetTitleKey (8)Zach Hilman1-1/+27
Takes a rights ID as input and returns the associated title key, if it exists.
2019-07-08es: Implement ETicket ImportTicket (1)Zach Hilman1-1/+45
Takes a ticket and certificate and installs it to the KeyManager.
2019-07-08key_manager: Add accessors/helpers for ticket managementZach Hilman2-14/+100
2019-07-08key_manager: Add equality operator for RSAKeyPairZach Hilman1-0/+7
2019-07-08gl_shader_decompiler: Implement gl_ViewportIndex and gl_Layer in vertex shadersReinUsesLisp10-40/+136
This commit implements gl_ViewportIndex and gl_Layer in vertex and geometry shaders. In the case it's used in a vertex shader, it requires ARB_shader_viewport_layer_array. This extension is available on AMD and Nvidia devices (mesa and proprietary drivers), but not available on Intel on any platform. At the moment of writing this description I don't know if this is a hardware limitation or a driver limitation. In the case that ARB_shader_viewport_layer_array is not available, writes to these registers on a vertex shader are ignored, with the appropriate logging.
2019-07-07Remove unused member function declarationMichael Scire1-9/+0
2019-07-07physmem: add helpers, cleanup logic.Michael Scire2-171/+170
2019-07-07Delete decode_integer_set.cppTobias1-0/+0
2019-07-07clang-format fixesMichael Scire2-3/+3
2019-07-07shader/texture: Add F16 support for TLDSReinUsesLisp2-2/+9
2019-07-07address review commentaryMichael Scire5-36/+42
2019-07-07Implement MapPhysicalMemory/UnmapPhysicalMemoryMichael Scire8-21/+475
This implements svcMapPhysicalMemory/svcUnmapPhysicalMemory for Yuzu, which can be used to map memory at a desired address by games since 3.0.0. It also properly parses SystemResourceSize from NPDM, and makes information available via svcGetInfo. This is needed for games like Super Smash Bros. and Diablo 3 -- this PR's implementation does not run into the "ASCII reads" issue mentioned in the comments of #2626, which was caused by the following bugs in Yuzu's memory management that this PR also addresses: * Yuzu's memory coalescing does not properly merge blocks. This results in a polluted address space/svcQueryMemory results that would be impossible to replicate on hardware, which can lead to game code making the wrong assumptions about memory layout. * This implements better merging for AllocatedMemoryBlocks. * Yuzu's implementation of svcMirrorMemory unprotected the entire virtual memory range containing the range being mirrored. This could lead to games attempting to map data at that unprotected range/attempting to access that range after yuzu improperly unmapped it. * This PR fixes it by simply calling ReprotectRange instead of Reprotect.
2019-07-07kernel/process: Allocate the process' TLS region during initializationLioncash3-3/+14
Prior to execution within a process beginning, the process establishes its own TLS region for uses (as far as I can tell) related to exception handling. Now that TLS creation was decoupled from threads themselves, we can add this behavior to our Process class. This is also good, as it allows us to remove a stub within svcGetInfo, namely querying the address of that region.
2019-07-07kernel/process: Move main thread stack allocation to its own functionLioncash2-12/+17
Keeps this particular set of behavior isolated to its own function.
2019-07-07vk_sampler_cache: Remove unused includesLioncash1-3/+0
These are no longer used within this header, so they can be removed.
2019-07-07video_core: Add missing override specifiersLioncash2-4/+4
2019-07-07yuzu/main: Make error messages within OnCoreError more localization-friendlyLioncash1-7/+8
Previously, a translated string was being appended onto another string in a manner that doesn't allow the translator to control where the appended text is placed. This can be a nuisance for languages where grammar and text ordering differs from English. We now append the strings via the format strings themselves, which allows translators to reorder where the text will be placed.
2019-07-07vk_scheduler: Drop execution context in favor of viewsReinUsesLisp6-50/+60
Instead of passing by copy an execution context through out the whole Vulkan call hierarchy, use a command buffer view and fence view approach. This internally dereferences the command buffer or fence forcing the user to be unable to use an outdated version of it on normal usage. It is still possible to keep store an outdated if it is casted to VKFence& or vk::CommandBuffer. While changing this file, add an extra parameter for Flush and Finish to allow releasing the fence from this calls.
2019-07-07mii: Implement IDatabaseService SetInterfaceVersionZach Hilman1-1/+15
Appears to set a member variable used to affect the API that games access, and the method used to store data.
2019-07-06clang-format fixesMichael Scire1-4/+5
2019-07-06am: Implement GetAccumulatedSuspendedTickValueMichael Scire2-7/+19
2019-07-06memory: Remove unused includesLioncash1-2/+0
These aren't used within the central memory management code, so they can be removed.
2019-07-06memory: Remove unused PageTable forward declarationLioncash1-4/+0
This isn't used by anything in the header file, so it can be removed.
2019-07-06kernel/vm_manager: Rename 'new map' to 'stack'Lioncash3-37/+37
Provides a more accurate name for the memory region and also disambiguates between the map and new map regions of memory, making it easier to understand.
2019-07-06buffer_cache: Avoid [[nodiscard]] to make clang-format happyReinUsesLisp1-5/+4
2019-07-06buffer_cache: Try to fix MinGW buildReinUsesLisp1-1/+1
2019-07-06gl_rasterizer: Fix nullptr dereference on disabled buffersReinUsesLisp3-5/+5
2019-07-06gl_rasterizer: Minor style changesReinUsesLisp4-32/+22
2019-07-06gl_rasterizer: Fix vertex and index data invalidationsReinUsesLisp4-8/+67
2019-07-06gl_buffer_cache: Implement with generic buffer cacheReinUsesLisp8-291/+92
2019-07-06buffer_cache: Implement a generic buffer cacheReinUsesLisp2-0/+301
Implements a templated class with a similar approach to our current generic texture cache. It is designed to be compatible with Vulkan and OpenGL,
2019-07-06gl_buffer_cache: Remove global system gettersReinUsesLisp3-9/+14
2019-07-06gl_device: Query SSBO alignmentReinUsesLisp2-0/+6
2019-07-06gl_buffer_cache: Implement flushingReinUsesLisp2-2/+11
2019-07-06gl_rasterizer: Drop gl_global_cache in favor of gl_buffer_cacheReinUsesLisp7-206/+35
2019-07-06gl_buffer_cache: Rework to support internalized buffersReinUsesLisp3-65/+174
2019-07-06gl_buffer_cache: Store in CachedBufferEntry the used buffer handleReinUsesLisp2-23/+30
2019-07-06gl_buffer_cache: Return used buffer from Upload functionReinUsesLisp4-36/+35
2019-07-06gl_rasterizer: Add some commentariesReinUsesLisp1-0/+5
2019-07-06gl_rasterizer: Make DrawParameters rasterizer instance constReinUsesLisp1-1/+1
2019-07-06gl_rasterizer: Move index buffer uploading to its own methodReinUsesLisp2-7/+18
2019-07-06kernel/vm_manager: Handle stack/TLS IO region placement betterLioncash1-2/+13
Handles the placement of the stack a little nicer compared to the previous code, which was off in a few ways. e.g. The stack (new map) region, shouldn't be the width of the entire address space if the size of the region calculation ends up being zero. It should be placed at the same location as the TLS IO region and also have the same size. In the event the TLS IO region contains a size of zero, we should also be doing the same thing. This fixes our memory layout a little bit and also resolves some cases where assertions can trigger due to the memory layout being incorrect.
2019-07-05core/reporter: Allow moves into SaveToFile()Lioncash1-1/+1
Taking the json instance as a constant reference, makes all moves into the parameter non-functional, resulting in copies. Taking it by value allows moves to function.
2019-07-05core/reporter: Add missing includes and forward declarationsLioncash2-1/+9
Adds missing inclusions to prevent potential compilation issues.
2019-07-05core/reporter: Remove unnecessary namespace qualifiersLioncash2-3/+3
The Reporter class is part of the Core namespace, so the System class doesn't need to be qualified.
2019-07-05core/reporter: Remove pessimizing move in GetHLERequestContextData()Lioncash1-1/+1
This can inhibit copy-elision, so we can remove this redundant move.
2019-07-05core/reporter: Make bracing consistentLioncash1-8/+18
Makes all control statements braced, regardless of their size, making code more uniform.
2019-07-05core/reporter: Return in error case in SaveToFile()Lioncash1-1/+3
If the path couldn't be created, then we shouldn't be attempting to save the file.
2019-07-05NVServices: Correct delayed responses.Fernando Sahmkow1-24/+19
2019-07-05Nv_Host_Ctrl: Correct difference calculationFernando Sahmkow1-5/+7
2019-07-05NVServices: Address FeedbackFernando Sahmkow8-21/+38
2019-07-05NVServices: Styling, define constructors as explicit and correctionsFernando Sahmkow24-65/+73
2019-07-05NVFlinger: Correct GCC compile errorFernando Sahmkow8-23/+22
2019-07-05NVServices: Make NVEvents Automatic according to documentation.Fernando Sahmkow4-7/+13
2019-07-05NVServices: Correct CtrlEventWaitSync to block the ipc until timeout.Fernando Sahmkow23-31/+104
2019-07-05GPU: Correct Interrupts to interrupt on syncpt/value instead of event, mirroring hardwareFernando Sahmkow12-48/+45
2019-07-05nvflinger: Make the force 30 fps still force 30 fpsFernando Sahmkow1-1/+1
2019-07-05nv_services: Fixes to event liberation.Fernando Sahmkow1-6/+14
2019-07-05nvflinger: Acquire buffers in the same order as they were queued.Fernando Sahmkow2-3/+11
2019-07-05nv_services: Deglobalize NvServicesFernando Sahmkow23-51/+65
2019-07-05gpu_asynch: Simplify synchronization to a simpler consumer->producer scheme.Fernando Sahmkow2-47/+3
2019-07-05nv_host_ctrl: Make Sync GPU variant always return synced result.Fernando Sahmkow5-5/+16
2019-07-05Async GPU: do invalidate as synced operationFernando Sahmkow1-6/+1
Async GPU: Always invalidate synced.
2019-07-05Gpu: use an std mutex instead of a spin_lock to guard syncpointsFernando Sahmkow2-6/+6
2019-07-05nvhost_ctrl: Corrections to event handlingFernando Sahmkow2-8/+12
2019-07-05Gpu: Mark areas as protected.Fernando Sahmkow3-0/+19
2019-07-05nv_services: Stub CtrlEventSignalFernando Sahmkow4-13/+48
2019-07-05Gpu: Implement Hardware Interrupt Manager and manage GPU interruptsFernando Sahmkow13-13/+90
2019-07-05nv_services: Implement NvQueryEvent, NvCtrlEventWait, NvEventRegister, NvEventUnregisterFernando Sahmkow7-17/+192
2019-07-05nv_services: Create GPU channels correctlyFernando Sahmkow2-2/+5
2019-07-05video_core: Implement GPU side SyncpointsFernando Sahmkow6-9/+84
2019-07-05nv_services: Correct buffer queue fencing and GPFifo fencingFernando Sahmkow8-57/+70
2019-07-05nvflinger: Implement swap intervalsFernando Sahmkow5-8/+21
2019-07-05texture_cache: Address FeedbackFernando Sahmkow7-22/+35
2019-07-05texture_cache: Correct Texture Buffer UploadingFernando Sahmkow3-2/+18
2019-07-04yuzu: Remove CPU Jit setting from the UIfearlessTobi11-36/+12
A normal user shouldn't change this, as it will slow down the emulation and can lead to bugs or crashes. The renaming is done in order to prevent users from leaving this on without a way to turn it off from the UI.
2019-07-04gl_shader_cache: Make CachedShader constructor privateZach Hilman2-5/+5
Fixes missing review comments introduced.
2019-07-04kernel/process: Default initialize all member variablesLioncash1-2/+2
Ensures a Process instance is always created with a deterministic initial state.
2019-07-04kernel/process: Decouple TLS handling from threadsLioncash4-66/+97
Extracts out all of the thread local storage management from thread instances themselves and makes the owning process handle the management of the memory. This brings the memory management slightly more in line with how the kernel handles these allocations. Furthermore, this also makes the TLS page management a little more readable compared to the lingering implementation that was carried over from Citra.
2019-07-04kernel/vm_manager: Add overload of FindFreeRegion() that operates on a boundaryLioncash2-13/+49
This will be necessary for making our TLS slot management slightly more straightforward. This can also be utilized for other purposes in the future. We can implement the existing simpler overload in terms of this one anyways, we just pass the beginning and end of the ASLR region as the boundaries.
2019-07-03acc_su: Implement GetProfileEditor (205)Zach Hilman3-1/+13
Takes a UUID of a user and provides and interface that allows RW access to user data/settings.
2019-07-03acc: Implement IProfileEditor-specific commands 'Store' and 'StoreWithImage'Zach Hilman1-1/+73
Verified with IDA
2019-07-03profile_manager: Add setter for ProfileBase and ProfileDataZach Hilman2-0/+13
Needed by IProfileEditor 'Store' and 'StoreWithImage'
2019-07-03acc: Add IProfileCommon for IProfile and IProfileEditorZach Hilman1-8/+31
Since 2/3 of the commands are shared, this is likely how its done on HW.
2019-07-02file_sys: Rename other ContentRecordType membersBakugo5-7/+8
2019-07-01audren: Only manage wave buffers with a sizeDavid Marcec1-3/+5
We shouldn't be incrementing if wave buffers are empty. They are considered invalid/unused wave buffers. This fixes the issue of certain sounds looping when they shouldn't
2019-07-01rasterizer_cache: Protect inherited caches from submission levelFernando Sahmkow3-1/+5
2019-07-01IAudioDevice::QueryAudioDeviceOutputEventDavid Marcec1-3/+16
The event should only be signaled when an output audio device gets changed. Example, Speaker to USB headset. We don't identify different devices internally yet so there's no need to signal the event yet.
2019-07-01file_sys/registered_cache: Improve missing metadata errorBakugo1-2/+2
This can happen when installing NSPs too, not just XCIs.
2019-07-01file_sys/submission_package: Don't warn about missing DeltaFragment NCAsBakugo1-4/+7
DeltaFragments are not useful to us and are often not included in patch NSPs.
2019-07-01file_sys/registered_cache: Ignore DeltaFragment NCAs during installationBakugo1-0/+3
DeltaFragments are only used to download and apply partial patches on a real console, and are not useful to us at all. Most patch NSPs do not include them, and when they do, it's a waste of space to install them.
2019-07-01file_sys: Rename ContentRecordType::Patch to DeltaFragmentBakugo1-1/+1
Avoids potential confusion, since patches and DeltaFragments are not the same thing. Actual full patches are listed under the Program type.
2019-07-01hid:StartLrAssignmentMode, hid:StopLrAssignmentMode, hid:SwapNpadAssignmentDavid Marcec6-3/+99
StartLrAssignmentMode and StopLrAssignmentMode don't require any implementation as it's just used for showing the screen of changing the controller orientation if the user wishes to do so. Ever since #1634 this has not been needed as users can specify the controller orientation from the config and swap at any time. We store a private member just in case this gets used for anything extra in the future
2019-06-30texture_cache: Pack sibling queries inside a methodReinUsesLisp1-6/+8
2019-06-30texture_cache: Use std::vector reservation for sampled_texturesReinUsesLisp1-17/+10
2019-06-30texture_cache: Style changesReinUsesLisp3-17/+13
2019-06-29texture_cache: Use std::array for siblings_tableReinUsesLisp1-10/+13
2019-06-29texture_cache: Address feedbackReinUsesLisp4-30/+13
2019-06-29am: Implement SetCpuBoostMode in terms of APMZach Hilman5-13/+26
2019-06-29core: Keep instance of APM ControllerZach Hilman2-0/+20
2019-06-29apm: Implement SetCpuBoostModeZach Hilman2-0/+14
2019-06-29apm: Add getters for performance config and modeZach Hilman2-33/+49
2019-06-29apm: Add apm:am serviceZach Hilman2-11/+9
8.0.0+ identical version of apm
2019-06-29apm: Add Controller class to manage speed data and applicationZach Hilman3-0/+140
2019-06-29fsp-srv: Implement GetAccessLogVersionInfoZach Hilman2-3/+14
Returns some misc. data about logging to help the game determine if it should log.
2019-06-29reporter: Add report class for filesystem access logsZach Hilman2-0/+25
2019-06-29fsp-srv: Implement OutputAccessLogToSdCardZach Hilman7-27/+62
Allows games to log data to the SD.
2019-06-29set: Implement GetQuestFlagZach Hilman2-1/+10
Simply returns a true/false value indicating if the system is a kiosk system. This has been mapped to a config option for the purposes of yuzu.
2019-06-29settings: Add config option for kiosk (quest) modeZach Hilman6-1/+26
2019-06-28Attemp clang format fix?David Marcec1-1/+0
Seems to be an issue with clang format
2019-06-28Added errors.h to cmakelistDavid Marcec1-0/+1
2019-06-28Addressed issuesDavid Marcec2-13/+13
2019-06-28Addressed issuesDavid Marcec2-17/+12
2019-06-27Implemented InitializeApplicationInfo & InitializeApplicationInfoRestrictedDavid Marcec4-6/+114
InitializeApplicationInfoRestricted will need further implementation as it's checking for other user requirements about the game. As we're emulating, we're assuming the user owns the game so we skip these checks currently, implementation will need to be added further on
2019-06-27pm: Implement pm:shell and pm:dmnt GetApplicationPidZach Hilman3-7/+33
Returns the process ID of the current application or 0 if no app is running.
2019-06-27pm: Implement pm:dmnt GetTitlePidZach Hilman1-7/+36
Takes a title ID and searches for a matching process, returning error if it doesn't exist, otherwise the process ID.
2019-06-27pm: Implement pm:info GetTitleIdZach Hilman1-2/+47
Searches the process list for a process with the specified ID, returning the title ID if it exists.
2019-06-26Addressed issuesDavid Marcec5-37/+53
2019-06-26glue: Correct missing bytes in ApplicationLaunchParameterZach Hilman7-37/+71
2019-06-26texture_cache: Correct variable naming.Fernando Sahmkow1-3/+3
2019-06-26gl_texture_cache: Correct assertsFernando Sahmkow2-2/+2
2019-06-26texture_cache: Corrections, documentation and assertsFernando Sahmkow1-42/+42
2019-06-26surface_params: Corrections, asserts and documentation.Fernando Sahmkow2-43/+58
2019-06-25copy_params: use constexpr for constructorFernando Sahmkow1-3/+4
2019-06-25gl_texture_cache: Corrections and fixesFernando Sahmkow2-13/+9
2019-06-25gl_resource_manager: Correct MakeStreamCopyFernando Sahmkow2-3/+2
2019-06-25texture_cache: Query MemoryManager from the systemFernando Sahmkow5-20/+7
2019-06-25Implement Time::GetSharedMemoryNativeHandleDavid Marcec8-29/+245
This PR attempts to implement the shared memory provided by GetSharedMemoryNativeHandle. There is still more work to be done however that requires a rehaul of the current time module to handle clock contexts. This PR is mainly to get the basic functionality of the SharedMemory working and allow the use of addition to it whilst things get improved on. Things to note: Memory Barriers are used in the SharedMemory and a better solution would need to be done to implement this. Currently in this PR I’m faking the memory barriers as everything is sync and single threaded. They work by incrementing the counter and just populate the two data slots. On data reading, it will read the last added data. Specific values in the shared memory would need to be updated periodically. This isn't included in this PR since we don't actively do this yet. In a later PR when time is refactored this should be done. Finally, as we don't handle clock contexts. When time is refactored, we will need to update the shared memory for specific contexts. This PR does this already however since the contexts are all identical and not separated. We're just updating the same values for each context which in this case is empty. Tiime:SetStandardUserSystemClockAutomaticCorrectionEnabled, Time:IsStandardUserSystemClockAutomaticCorrectionEnabled are also partially implemented in this PR. The reason the implementation is partial is because once again, a lack of clock contexts. This will be improved on in a future PR. This PR closes issue #2556
2019-06-25SizedNotificationInfo should be 0x10 bytes, user_uuid is incorrect, this should be the users account idDavid Marcec1-1/+3
2019-06-25fixed spelling errors and fixed issue with Pop not returning the SizedNotificationInfoDavid Marcec1-6/+8
2019-06-25applets: Pass current process title ID to appletsZach Hilman11-41/+59
Avoids using system accessor to get current process in applet code.
2019-06-25general_frontend: Add documentation for parental controls and ecommerce appletsZach Hilman5-27/+55
2019-06-25web_browser: Only delete temporary directory if it was createdZach Hilman1-1/+3
Prevents crashes with ShopN applet occasionally.
2019-06-25web_browser: Take ECommerce applet frontend optionally in constructorZach Hilman1-1/+6
If it is needed but wasn't passed (or passed nullptr), the Shop handling code will alert and throw an error.
2019-06-25frontend: Add base class and default impl for ECommerce applet frontendZach Hilman2-0/+102
2019-06-25web_browser: Use function tables for execute and initializeZach Hilman2-7/+285
Allows easy handling of multiple shim types, as they have enough in common to be the same backend but not enough to share init/exec.
2019-06-25web_browser: Correct structures and properly parse TLVs/ShimKindZach Hilman2-61/+168
Much, much more HW-accurate and allows us to easily support all of the different web 'shim' types.
2019-06-25yuzu: Accept default applets for Parental Controls and ECommerceZach Hilman1-5/+7
2019-06-25applets: Track ECommerce and Parental Control applet frontendsZach Hilman2-7/+29
2019-06-25web_browser: Rename OpenPage to OpenPageLocalZach Hilman4-11/+11
This is more representative of what actually occurs, as web does support remote URLs which wouldn't need a romfs callback. This paves for easy future support of this with a call like 'OpenPageRemote' or similar.
2019-06-25frontend: Add base class and default impl of parent controls applet frontendZach Hilman2-1/+52
2019-06-25applets: Implement Auth applet backendZach Hilman2-0/+146
This is responsible for parental controls and supports verifying, changing, and registering PIN codes.
2019-06-25core: Keep track of ARPManager and register current application on bootZach Hilman2-0/+76
2019-06-25glue: Implement arp:w and arp:r servicesZach Hilman3-2/+330
These keep track of running process' launch properties and control properties and allows for issuing and reading them by process and title ID.
2019-06-25glue: Add errors for glue/arp servicesZach Hilman4-2/+65
2019-06-25glue: Add scaffolding for bgtc:t and bgtc:sc servicesZach Hilman2-0/+73
2019-06-25arp: Move to glue servicesZach Hilman2-91/+0
Glue is the name of the sysmodule that contains both arp and bgtc.
2019-06-25glue: Add manager to keep track of application registryZach Hilman3-0/+121
Manages mapping between title IDs and application launch and control properties.
2019-06-25registered_cache: Add getter to determine source slot in content provider unionZach Hilman2-0/+17
Used to determine StorageId source for application data.
2019-06-25patch_manager: Add getter for title versionZach Hilman2-2/+14
2019-06-24texture_cache: Include "core/core.h"ReinUsesLisp1-4/+1
2019-06-24gl_texture_cache: Explicitly add indirect includeReinUsesLisp1-0/+1
2019-06-24texture_cache/surface_view: Address feedbackReinUsesLisp1-1/+0
2019-06-24texture_cache/surface_base: Address feedbackReinUsesLisp2-2/+10
2019-06-24video_core/surface: Address feedbackReinUsesLisp1-2/+2
2019-06-24decode/texture: Address feedbackReinUsesLisp1-0/+1
2019-06-24renderer_opengl/utils: Remove unused includes and unused forward declarationReinUsesLisp1-4/+0
2019-06-24gl_texture_cache: Address some feedbackReinUsesLisp1-2/+4
2019-06-24gl_shader_disk_cache: Address feedbackReinUsesLisp2-4/+8
2019-06-24gl_shader_decompiler: Address feedbackReinUsesLisp1-11/+12
2019-06-24shader_bytecode: Include missing <array>ReinUsesLisp1-0/+1
2019-06-24common/alignment: Address feedbackReinUsesLisp1-2/+3
2019-06-24Implemented INotificationServiceDavid Marcec5-1/+127
2019-06-22Update reporter.cppThomas May1-5/+5
2019-06-21service/acc: Silence truncation warningsLioncash1-3/+3
The sanitizing function ensures that the returned type is always the correct type. This eliminates warnings without extra casts.
2019-06-21texture_cache: Style and CorrectionsFernando Sahmkow7-71/+75
2019-06-21shader_cache: Correct versioning and size calculation.Fernando Sahmkow2-2/+7
2019-06-21texture_cache: Eliminate linear textures fallthroughFernando Sahmkow1-4/+0
2019-06-21texture_cache: Correct format R16U as siblingFernando Sahmkow2-1/+2
2019-06-21texture_cache: Implement texception detection and texture barriers.Fernando Sahmkow2-7/+40
2019-06-21texture_cache: Corrections to buffers and shadow formats use.Fernando Sahmkow1-10/+34
2019-06-21texture_cache: Implement Irregular Views in surfacesFernando Sahmkow2-4/+24
2019-06-21surface: Correct format S8Z24Fernando Sahmkow4-9/+5
2019-06-21texture_cache: Initialize all siblings to invalid pixel format.Fernando Sahmkow1-6/+15
2019-06-21gl_texture_cache: Use Stream Buffers instead of Persistant for Buffer Copies.Fernando Sahmkow3-5/+4
2019-06-21gl_texture_cache: Correct Image BlitFernando Sahmkow1-1/+1
2019-06-21decoders: correct block calculationFernando Sahmkow7-29/+41
2019-06-21texture_cache: Use siblings textures on Rebuild and fix possible error on blittingFernando Sahmkow2-11/+24
2019-06-21texture_cache: Remove old rasterizer cacheFernando Sahmkow2-1956/+0
2019-06-21texture_cache: Implement siblings texture formats.Fernando Sahmkow2-12/+31
2019-06-21fermi2d: Correct Origin ModeFernando Sahmkow1-5/+10
2019-06-21texture_cache: correct texture buffer on surface paramsFernando Sahmkow1-4/+11
2019-06-21texture_cache: eliminate accelerated depth->color/color->depth copies due to driver instability.Fernando Sahmkow4-22/+6
2019-06-21texture_cache: correct mutex locksFernando Sahmkow1-4/+4
2019-06-21shader_ir: Fix image copy rebase issuesFernando Sahmkow1-2/+7
2019-06-21texture_cache: Don't Image Copy if component types differFernando Sahmkow1-1/+2
2019-06-21texture_cache: move some large methods to cpp filesFernando Sahmkow4-139/+135
2019-06-21texture_cache: Optimize GetSurface and use references on functions that don't change a surface.Fernando Sahmkow3-12/+12
2019-06-21texture_cache: Implement Buffer Copy and detect Turing GPUs Image CopiesFernando Sahmkow8-12/+148
2019-06-21texture_cache uncompress-compress is untopological.Fernando Sahmkow5-19/+53
This makes conflicts between non compress and compress textures to be auto recycled. It also limits the amount of mipmaps a texture can have if it goes above it's limit.
2019-06-21texture_cache: Correct copying between compressed and uncompressed formatsFernando Sahmkow3-10/+27
2019-06-21texture_cache: Only load on recycle with accurate GPU.Fernando Sahmkow1-2/+3
Testing so far has proven this to be quite safe as texture memory read added a 2-5ms load to the current cache.
2019-06-21Fix rebase errorsFernando Sahmkow3-3/+13
2019-06-21texture_cache: Handle uncontinuous surfaces.Fernando Sahmkow4-21/+82
2019-06-21texture_cache: return null surface on invalid addressFernando Sahmkow1-0/+12
2019-06-21texture_cache: Add checks for texture buffers.Fernando Sahmkow1-2/+16
2019-06-21texture_cache: Fermi2D reform and implement View MirageFernando Sahmkow11-77/+125
This also does some fixes on compressed textures reinterpret and on the Fermi2D engine in general.
2019-06-21gl_shader_decompiler: Implement image binding settingsReinUsesLisp5-24/+52
2019-06-21shader: Implement bindless imagesReinUsesLisp3-2/+40
2019-06-21shader: Decode SUST and implement backing image functionalityReinUsesLisp9-3/+283
2019-06-21gl_rasterizer: Track texture buffer usageReinUsesLisp6-74/+119
2019-06-21video_core: Make ARB_buffer_storage a required extensionReinUsesLisp5-8/+12
2019-06-21gl_rasterizer_cache: Use texture buffers to emulate texture buffersReinUsesLisp5-11/+35
2019-06-21maxwell_3d: Partially implement texture buffers as 1D texturesReinUsesLisp4-10/+24
2019-06-21gl_shader_decompiler: Allow 1D textures to be texture buffersReinUsesLisp1-4/+38
2019-06-21shader: Implement texture buffersReinUsesLisp3-0/+62
2019-06-21texture_cache: loose TryReconstructSurface when accurate GPU is not on.Fernando Sahmkow3-4/+20
Also corrects some asserts.
2019-06-21texture_cache: Document the most important methods.Fernando Sahmkow1-8/+87
2019-06-21texture_cache: Try to Reconstruct Surface on bigger than overlap.Fernando Sahmkow1-4/+11
This fixes clouds in SMO Cap Kingdom and lens on Cloud Kingdom. Also moved accurate_gpu setting check to Pick Strategy
2019-06-21texture_cache: Implement Guard mechanismFernando Sahmkow2-1/+12
2019-06-21texture_cache: General FixesFernando Sahmkow8-47/+170
Fixed ASTC mipmaps loading Fixed alignment on openGL upload/download Fixed Block Height Calculation Removed unalign_height
2019-06-21surface_params: Ensure pitch is always written to avoid surface leaksReinUsesLisp1-0/+2
2019-06-21gl_framebuffer_cache: Use a hashed struct to cache framebuffersReinUsesLisp6-62/+148
2019-06-21texture_cache return invalid buffer on deactivated color_maskFernando Sahmkow2-2/+9
2019-06-21engine_upload: Addapt to new Texture CacheFernando Sahmkow2-5/+5
2019-06-21surface_params: Optimize CreateForTextureReinUsesLisp2-72/+76
Instead of using Common::AlignUp, use Common::AlignBits to align the texture compression factor.
2019-06-21gl_texture_cache: Make main views be proxy textures instead of a full view.Fernando Sahmkow2-11/+25
2019-06-21texture_cache: Add ASync ProtectionsFernando Sahmkow1-0/+10
2019-06-21Remove Framebuffer reconfiguration and restrict rendertarget protectionFernando Sahmkow4-39/+27
2019-06-21texture_cache: Implement GPU Dirty FlagsFernando Sahmkow1-15/+22
2019-06-21texture_cache: Optimize GetMipBlockHeight and GetMipBlockDepthFernando Sahmkow2-13/+50
2019-06-21texture_cache: Implement L1_Inner_cacheFernando Sahmkow1-13/+30
2019-06-21video_core: Use un-shifted block sizes to avoid integer divisionsReinUsesLisp10-60/+78
Instead of storing all block width, height and depths in their shifted form: block_width = 1U << block_shift; Store them like they are provided by the emulated hardware (their block_shift form). This way we can avoid doing the costly Common::AlignUp operation to align texture sizes and drop CPU integer divisions with bitwise logic (defined in Common::AlignBits).
2019-06-21texture_cache: Change internal cache from lists to vectorsReinUsesLisp1-6/+7
2019-06-21Reduce amount of size calculations.Fernando Sahmkow8-88/+97
2019-06-21texture_cache: Correct premature texceptionsFernando Sahmkow4-14/+51
Due to our current infrastructure, it is possible for a mipmap to be set on as a render target before a texception of that mipmap's superset be set afterwards. This is problematic as we rely on texture views to set up texceptions and protecting render targets targets for 3D texture rendering. One simple solution is to configure framebuffers after texture setup but this brings other problems. This solution, forces a reconfiguration of the framebuffers after such event happens.
2019-06-21texture_cache: Implement guest flushingFernando Sahmkow3-10/+29
2019-06-21Fixes to mipmap's process and reconstruct processFernando Sahmkow2-3/+3
2019-06-21surface_base: Add parenthesis to EmplaceOverview's predicateReinUsesLisp1-3/+2
2019-06-21Texture Cache: Implement Blitting and Fermi CopiesFernando Sahmkow7-100/+93
2019-06-21surface_view: Add constructor for ViewParamsReinUsesLisp3-39/+23
2019-06-21surface_base: Split BreakDown into layered and non-layered variantsReinUsesLisp1-45/+48
2019-06-21surface_base: Silence truncation warnings and minor renames and reorderingReinUsesLisp2-32/+37
2019-06-21copy_params: Use constructor instead of C-like initializationReinUsesLisp3-47/+39
2019-06-21Correct Mipmaps View method in Texture CacheFernando Sahmkow3-32/+29
2019-06-21Change texture_cache chaching from GPUAddr to CacheAddrFernando Sahmkow7-101/+60
This also reverses the changes to make invalidation and flushing through the GPU address.
2019-06-21Corrections to Structural MatchingFernando Sahmkow2-24/+53
The texture will now be reconstructed if the width only matches on GoB alignment.
2019-06-21Implement Texture Cache V2Fernando Sahmkow6-381/+568
2019-06-21Correct Surface Base and Views for new Texture CacheFernando Sahmkow7-380/+466
2019-06-21Add OGLTextureViewFernando Sahmkow2-0/+43
2019-06-21Deglobalize Memory Manager on texture cahe and Implement Invalidation and Flushing using GPUVAddrFernando Sahmkow4-1/+20
2019-06-21texture_cache: Remove execution context copies from the texture cacheReinUsesLisp7-168/+59
This is done to simplify the OpenGL implementation, it is needed for Vulkan.
2019-06-21gl_texture_cache: Implement fermi copiesReinUsesLisp5-2/+105
2019-06-21texture_cache: Split texture cache into different filesReinUsesLisp12-876/+965
2019-06-21texture_cache: Move staging buffer into a generic implementationReinUsesLisp4-181/+211
2019-06-21texture_cache: Flush 3D textures in the order they are drawnReinUsesLisp5-19/+44
2019-06-21gl_texture_cache: Minor changesReinUsesLisp5-140/+185
2019-06-21gl_texture_cache: Add copy from multiple overlaps into a single surfaceReinUsesLisp3-6/+84
2019-06-21gl_texture_cache: Attach surface textures instead of viewsReinUsesLisp3-20/+32
2019-06-21gl_texture_cache: Add fast copy pathReinUsesLisp4-7/+60
2019-06-21gl_texture_cache: Initial implementationReinUsesLisp9-47/+809
2019-06-21freezer: Update documentationZach Hilman1-1/+8
2019-06-21core: Move Freezer class to tools namespaceZach Hilman4-17/+17
2019-06-21freezer: Add documentation for methodsZach Hilman2-30/+49
2019-06-21memory: Add class to manage and enforce memory freezingZach Hilman4-0/+248
2019-06-20Revert PR 2590.Fernando Sahmkow1-1/+1
Even though it has been proven that IAudioRenderer:SystemEvent is actually an automatic event. The current implementation of such event is all thought to be manual. Thus it's implementation needs to be corrected when doing such change. As it is right now this PR introduced a series of regressions on softlocks on multiple games. Therefore, this pr reverts such change until a correct implementation is made.
2019-06-20Update content_archive.cppjonsn0w1-2/+2
log clutter in debug logs when theres really no need
2019-06-19Change to a more descriptive nameTobias1-1/+1
2019-06-19yuzu/configure_input: Add missing space in window nameTobias1-1/+1
2019-06-19Added missing space between two wordsAlex Subaric1-1/+1
Added missing whitespace character between two words in the "Warning Missing Derivation Components" warning message box.
2019-06-18core: Remove unused CiTrace source filesLioncash5-399/+0
These source files have been unused for the entire lifecycle of the project. They're a hold-over from Citra and only add to the build time of the project, so they can be removed. There's also likely no way this would ever work in yuzu in its current form without revamping quite a bit of it, given how different the GPU on the Switch is compared to the 3DS.
2019-06-18service/audio/audren_u: Correct event reset type for the system eventLioncash1-1/+1
This is actually an auto-reset event in the audio service itself, not a manual one.
2019-06-17Addressed issuesDavid Marcec4-9/+14
2019-06-16Core_Timing: Make core_timing threadsafe by default.Fernando Sahmkow5-60/+25
The old implementation had faulty Threadsafe methods where events could be missing. This implementation unifies unsafe/safe methods and makes core timing thread safe overall.
2019-06-16Signalled accumulated_suspended_tick_changed_event on creation based on REDavid Marcec1-0/+1
2019-06-16CleanupDavid Marcec12-30/+39
2019-06-16Impl'd IsUserAccountSwitchLocked, SetAudioOutVolume, GetAudioOutVolume & Partial impl of GetAccumulatedSuspendedTickChangedEventDavid Marcec10-11/+93
IPC-100 was changed to InitializeApplicationInfoOld instead of InitializeApplicationInfo. IPC-150 makes an indentical call to IPC-100 however does extra processing. They should not have the same name as it's quite confusing to debug.
2019-06-13file_sys/ips_layer: Remove unnecessary reserve() callLioncash1-1/+0
Given 'replace' is assigned to on the following line, this isn't necessary, given the underlying data is going to be overwritten entirely.
2019-06-12common/hex_util: Reserve std::string memory ahead of timeLioncash1-0/+5
Avoids potentially performing multiple reallocations (depending on the size of the input data) by reserving the necessary amount of memory ahead of time. This is trivially doable, so there's no harm in it.
2019-06-12common/hex_util: Combine HexVectorToString() and HexArrayToString()Lioncash11-39/+40
These can be generified together by using a concept type to designate them. This also has the benefit of not making copies of potentially very large arrays.
2019-06-12file_sys/card_image: Remove obsolete TODOLioncash1-1/+1
We already support Rev 1+.
2019-06-12kernel/vm_manager: Remove redundant Reset call in destructorLioncash1-3/+1
This is performing more work than would otherwise be necessary during VMManager's destruction. All we actually want to occur in this scenario is for any allocated memory to be freed, which will happen automatically as the VMManager instance goes out of scope. Anything else being done is simply unnecessary work.
2019-06-12gl_device: Fix TestVariableAoffi testReinUsesLisp1-1/+2
This test is intended to be invalid GLSL, but it was being invalid in two points instead of one. The intention is to use a non-immediate parameter in a textureOffset like function. The problem is that this shader was being compiled as a separable shader object and the text was writting to gl_Position without a redeclaration, being invalid GLSL. Address that issue by using a user-defined output attribute.
2019-06-11file_sys/nca_metadata: Update CNMT structuresLioncash1-2/+7
Names a few more entries in relevant structures. Information based off SwitchBrew and my own RE.
2019-06-11file_sys/card_image: Deduplicate casts within AddNCAFromPartition()Lioncash1-3/+6
Makes for nicer reading.
2019-06-11file_sys/card_image: Make bracing consistentLioncash1-4/+8
Makes for more consistent reading.
2019-06-11file_sys/card_image: Assign collapsed NCA contents directly to ncas memberLioncash1-3/+1
Same thing, significantly less noisy.
2019-06-11file_sys/card_image: Deduplicate type castLioncash1-4/+6
Same thing, less duplication. We can also std::move raw into the PartitionFilesystem constructor.
2019-06-11file_sys/card_image: Get rid of a magic numberLioncash1-1/+1
We can just use the size of the array to dehardcode it.
2019-06-11file_sys/card_image: Use std::array deduction guidesLioncash1-1/+6
Same thing, less code.
2019-06-10yuzutest: Add minor commentsZach Hilman2-8/+9
2019-06-10kernel: Differentiate kernel and user processes when picking IDZach Hilman6-10/+29
This allows kernel internal type processes to be assigned IDs in the KIP range while userland processes are assigned in the user range.
2019-06-10nsp: Correct status codes for extracted NSPsZach Hilman2-13/+17
Avoids all extracted NSPs being marked as error file type because they don't have program NCAs.
2019-06-10nsp: Use title ID from NPDM metadata for extracted type NSPsZach Hilman2-1/+22
Avoids 0 being used as title ID for all extracted NSPs.
2019-06-10arm_dynarmic: Check if jit is nullptr when preparing rescheduleZach Hilman1-0/+3
Prevents crash with multiprocess loading.
2019-06-10yuzu_tester: Display results in table formatZach Hilman3-12/+50
2019-06-10yuzutest: Support multiple tests per executableZach Hilman4-33/+41
2019-06-10yuzu_tester: Add 'yuzutest' serviceZach Hilman2-0/+123
2019-06-10yuzu_tester: Add SDL2-based EmuWindow that doesn't show the windowZach Hilman2-0/+164
2019-06-10yuzu_tester: Use config, icon, and main from yuzu-cmdZach Hilman6-0/+624
2019-06-10yuzu_tester: Add project subdirectoryZach Hilman2-0/+35
2019-06-10kernel/process: Make Create()'s name parameter be taken by valueLioncash2-2/+2
Makes the interface more flexible in terms of how Create() may be called, while still allowing the parameter itself to be moved into.
2019-06-10kernel/svc: Implement TotalMemoryUsedWithoutMmHeap/TotalMemoryAvailableWithoutMmHeapLioncash3-2/+42
Given we don't currently implement the personal heap yet, the existing memory querying functions are essentially doing what the memory querying types introduced in 6.0.0 do. So, we can build the necessary machinery over the top of those and just use them as part of info types.
2019-06-10kernel/svc: Amend naming for TotalMemoryUsage in svcGetInfo()Lioncash3-6/+6
Disambiguates and makes the name a little more consistent with TotalPhysicalMemoryUsed.
2019-06-10kernel/svc: Remove duplicate enum entry in svcGetInfo()Lioncash1-2/+1
2019-06-09GPUVM: Correct GPU VM virtual address spaceFernando Sahmkow1-2/+2
2019-06-08kepler_compute: Use std::array for cbuf infoReinUsesLisp1-2/+3
2019-06-08kepler_compute: Fix block_dim_x encodingReinUsesLisp1-1/+1
2019-06-08gl_shader_cache: Use static constructors for CachedShader initializationReinUsesLisp2-52/+53
2019-06-08gl_rasterizer: Remove unused parameters in descriptor uploadsReinUsesLisp2-8/+6
2019-06-08video_core/engines: Move ConstBufferInfo out of Maxwell3DReinUsesLisp6-49/+64
2019-06-07constants: Extract backup JPEG used by account servicesZach Hilman5-28/+43
2019-06-07shader: Split SSY and PBK stackReinUsesLisp4-27/+78
Hardware testing revealed that SSY and PBK push to a different stack, allowing code like this: SSY label1; PBK label2; SYNC; label1: PBK; label2: EXIT;
2019-06-07kernel_executable: Optimize BLZ decompressionZach Hilman2-10/+13
2019-06-07cmake: Add missing shader hash file entriesReinUsesLisp1-0/+3
2019-06-07shader/node: Minor changesReinUsesLisp1-50/+54
Reflect std::shared_ptr nature of Node on initializers and remove constant members in nodes. Add some commentaries.
2019-06-07shader: Move Node declarations out of the shader IR headerReinUsesLisp4-493/+518
Analysis passes do not have a good reason to depend on shader_ir.h to work on top of nodes. This splits node-related declarations to their own file and leaves the IR in shader_ir.h
2019-06-06yuzu/configuration: Make all widgets and dialogs aware of language changesLioncash31-58/+326
To prepare for translation support, this makes all of the widgets cognizant of the language change event that occurs whenever installTranslator() is called and automatically retranslates their text where necessary. This is important as calling the backing UI's retranslateUi() is often not enough, particularly in cases where we add our own strings that aren't controlled by it. In that case we need to manually refresh the strings ourselves.
2019-06-06shader: Use shared_ptr to store nodes and move initialization to fileReinUsesLisp35-248/+296
Instead of having a vector of unique_ptr stored in a vector and returning star pointers to this, use shared_ptr. While changing initialization code, move it to a separate file when possible. This is a first step to allow code analysis and node generation beyond the ShaderIR class.
2019-06-05service/ns: Add missing override specifiersLioncash1-9/+9
2019-06-05yuzu/CMakeLists: Disable implicit QString->QUrl conversionsLioncash1-0/+3
Enforces the use of the proper URL resolution functions. e.g. url = some_local_path_string; should actually be: url = QUrl::fromLocalPath(some_local_path_string); etc. This makes it harder to cause bugs when operating with both strings and URLs at the same time.
2019-06-05yuzu/CMakeLists: Disable unsafe overloads of QProcess' start() functionLioncash1-0/+3
Other overloads of start() are considerably much safer to use if we ever need this in the future and need to pass arguments to the program, given it contains separate parameters for the program path and the arguments themselves, whereas this unsafe overload contains both as a single string. Given the alternatives are much safer, we can disable this.
2019-06-05yuzu/CMakeLists: Disable implicit type narrowing in connect() callsLioncash1-0/+3
Prevents hard-to-diagnose bugs from potentially occurring and requires any type narrowing to be explicitly performed by our code.
2019-06-05yuzu/configuration: Make function naming consistentLioncash33-213/+234
2019-06-05kernel/process: Remove unused boost header includeLioncash1-1/+0
Boost headers typically include a lot of other headers, so removing this can prevent a bit of unnecessary compiler churn when building.
2019-06-05game_list: Accept *.kip as a file extension of executablesZach Hilman2-3/+2
2019-06-05loader: Add recognition for KIP file typeZach Hilman2-0/+11
2019-06-05loader: Add KIP and INI file parser-specific errorsZach Hilman2-1/+9
2019-06-05loader: Add AppLoader_KIP for KIP filesZach Hilman3-0/+135
2019-06-05program_metadata: Add function to load meta from raw parametersZach Hilman2-0/+20
Needed for KIP loading as KIPs do not have an NPDM but do have the essential parts of the data within.
2019-06-05partition_data_manager: Remove KIP processing and use FileSysZach Hilman1-118/+13
Previously, this TU contained the necessary headers to parse KIP/INI but now it should just use the FileSys class.
2019-06-05file_sys: Add classes to parse KIP1 and INI1 filesZach Hilman3-0/+330
2019-06-05core/core_timing_util: Amend casing of cyclesTo* functionsLioncash3-6/+6
Makes the casing consistent with all of our general function naming conventions.
2019-06-05core/core_timing_util: Use std::chrono types for specifying time unitsLioncash7-36/+43
Makes the interface more type-safe and consistent in terms of return values.
2019-06-05core/core_timing_utils: Simplify overload setLioncash2-49/+2
Removes unused overloads, simplifying the overall interface, deduplicating some code.
2019-06-04shader_bytecode: Mark EXIT as flow instructionFernando Sahmkow1-1/+1
2019-06-03input_common/sdl/sdl_impl: Correct logging string in SDLState constructorLioncash1-1/+1
If this path was ever taken, a runtime exception would occur due to the lack of a formatting specifier to insert the error code into the format string.
2019-06-03input_common/sdl/sdl_impl: Move documentation comments to header where applicableLioncash2-7/+6
Places the documentation comments with the rest of SDLState's member function documentation.
2019-06-03input_common/sdl/sdl_impl: Amend names for axes for SDLAnalogPollerLioncash1-13/+13
Adds another underscore to clearly indicate the axis names.
2019-06-03input_common/sdl/sdl_impl: Mark variables const where applicableLioncash1-10/+11
Make it explicit that these aren't modified elsewhere (either through functions by reference, or by other operations).
2019-06-03input_common/sdl/sdl_impl: Mark SDLEventToButtonParamPackage() as staticLioncash1-1/+1
Its prototype declared at the top of the translation unit contains the static qualifier, so the function itself should also contain it to make it a proper internally linked function.
2019-06-03input_common/sdl/sdl_impl: Convert reinterpret_cast into a static_castLioncash1-2/+4
It's valid to static_cast a void pointer back into its proper type.
2019-06-03input_common/sdl/sdl_impl: Use insert_or_assign() where applicableLioncash1-3/+3
Same behavior, but without a potential need to unnecessarily default construct a value.
2019-06-03input_common/sdl/sdl_impl: Simplify SDL_Joystick deleter handlingLioncash1-15/+14
The deleter can just be set in the constructor and maintained throughout the lifetime of the object. If a contained pointer is null, then the deleter won't execute, so this is safe to do. We don't need to swap it out with a version of a deleter that does nothing.
2019-06-03input_common/sdl/sdl_impl: Resolve two sign conversion warningsLioncash1-10/+16
Silences the final two warnings in SDL code.
2019-06-03input_common/sdl: Remove unused header includes and forward declarationsLioncash3-11/+5
Gets rid of a few unnecessary inclusion dependencies. It also uncovered a few indirect inclusion dependencies being relied upon.
2019-06-03input_common/sdl/sdl_impl: Use nested namespace specifiers where applicableLioncash1-5/+2
2019-06-03yuzu/bootmanager: Log out screenshot destination pathLioncash1-6/+11
We can make this message more meaningful by indicating the location the screenshot has been saved to. We can also log out whenever a screenshot could not be saved (e.g. due to filesystem permissions or some other reason).
2019-06-03yuzu/bootmanager: Treat the resolution factor as a u32Lioncash4-16/+25
Treating it as a u16 can result in a sign-conversion warning when performing arithmetic with it, as u16 promotes to an int when aritmetic is performed on it, not unsigned int. This also makes the interface more uniform, as the layout interface now operates on u32 across the board.
2019-06-03yuzu/bootmanager: Default EmuThread's destructor in the cpp fileLioncash2-1/+4
This class contains non-trivial members, so we should default the destructor's definition within the cpp file.
2019-06-03yuzu/bootmanager: unsigned -> u32Lioncash2-11/+11
Same thing (for platforms we support), less reading.
2019-06-03yuzu/bootmanager: Change false literal to 0 for setSwapInterval()Lioncash1-1/+1
This function is defined as taking an int, not a bool.
2019-06-03yuzu/bootmanager: Remove pointer downcast in GRenderWindow's constructorLioncash2-4/+3
We can just pass a pointer to GMainWindow directly and make it a requirement of the interface. This makes the interface a little safer, since this would technically otherwise allow any random QWidget to be the parent of a render window, downcasting it to GMainWindow (which is undefined behavior).
2019-06-03yuzu/bootmanager: Remove unnecessary pointer castsLioncash1-5/+6
We can just invoke these functions by qualifying the object name before the function.
2019-06-03gl_shader_decompiler: Remove guest "position" varyingReinUsesLisp2-36/+21
"position" was being written but not read anywhere besides geometry shaders, where it had the same value as gl_Position. This commit replaces "position" with gl_Position, reducing the complexity of our code and the emitted GLSL code.
2019-05-31input_common/sdl/sdl_impl: Silence sign conversion warningsLioncash1-3/+3
Makes the conversions explicit, as opposed to implicit.
2019-05-31common/math_util: Provide a template deduction guide for Common::RectangleLioncash1-0/+3
Allows for things such as: auto rect = Common::Rectangle{0, 0, 0, 0}; as opposed to being required to explicitly write out the underlying type, such as: auto rect = Common::Rectangle<int>{0, 0, 0, 0}; The only requirement for the deduction is that all constructor arguments be the same type.
2019-05-31game_list_worker: Use QFile over our own IOFile instance or std streamsLioncash1-28/+24
Stays consistent in our code with using Qt's provided mechanisms, and also properly handles Unicode paths (which file streams on Windows don't do very well).
2019-05-31game_list_worker: Remove template specializationsLioncash1-8/+2
This is equivalent to specifying two separate functions, so we can just do that.
2019-05-30gl_shader_cache: Store a system class and drop global accessorsReinUsesLisp2-7/+9
2019-05-30gl_shader_cache: Add commentaries explaining the intention in shaders creationReinUsesLisp1-0/+2
2019-05-30gl_shader_cache: Flip if condition in GetStageProgram to reduce indentationReinUsesLisp1-25/+26
2019-05-30gl_buffer_cache: Remove unused ReserveMemory methodReinUsesLisp2-13/+0
2019-05-30maxwell_to_gl: Use GL_CLAMP to emulate Clamp wrap modeReinUsesLisp3-7/+4
2019-05-30gl_rasterizer: Move alpha testing to the OpenGL pipelineReinUsesLisp8-71/+33
Removes the alpha testing code from each fragment shader invocation.
2019-05-30gl_rasterizer: Use GL_QUADS to emulate quads renderingReinUsesLisp6-132/+5
2019-05-30rasterizer_opengl: Remove OpenGL core profileReinUsesLisp8-29/+3
2019-05-30main: Remove extraneous commentZach Hilman1-1/+0
2019-05-30qt: Silence name collision warningsReinUsesLisp3-15/+15
2019-05-29yuzu: Remove unused birthday settingfearlessTobi3-170/+44
Fixes #2522.
2019-05-29yuzu/software_keyboard: Remove unnecessary GetStatus() member functionLioncash3-10/+1
Like with the profile selection dialog, we can just use the result of QDialog's exec() function to determine whether or not a dialog was accepted.
2019-05-29profile_select: Remove unnecessary GetStatus() member functionLioncash3-18/+8
This behavior is already provided by the built-in exec() function. We just need to check the return value of it.
2019-05-29profile_select: Return int instead of u32 for GetIndex()Lioncash3-8/+9
Qt uses a signed value to represent indices. We should follow this convention where applicable to avoid unnecessary sign-conversion warnings, as well as making it easier to interoperate with other aspects of Qt. While we're at it, we can also make a sign-conversion explicit.
2019-05-29core/core: Remove unnecessary includesLioncash3-13/+37
The contents of these includes aren't used anywhere in this translation unit.
2019-05-29yuzu_cmd/yuzu: Correct formatting specifierLioncash1-1/+1
Amends the formatting specifier to obey libfmt. Prevents the application from terminating due to a formatting issue in the error case.
2019-05-29core/loader: Remove LoadKernelSystemModeLioncash5-29/+0
This is a hold-over from Citra and doesn't apply to yuzu.
2019-05-29core/telemetry_session: Remove unnecessary web service nulling out in destructorLioncash1-2/+1
This will automatically occur when the backend instance goes out of scope at the end of the destructor's execution.
2019-05-29core/telemetry_session: Remove usages of the global system accessorLioncash3-30/+54
Makes the dependency explicit in the TelemetrySession's interface instead of making it a hidden dependency. This also revealed a hidden issue with the way the telemetry session was being initialized. It was attempting to retrieve the app loader and log out title-specific information. However, this isn't always guaranteed to be possible. During the initialization phase, everything is being constructed. It doesn't mean an actual title has been selected. This is what the Load() function is for. This potentially results in dead code paths involving the app loader. Instead, we explicitly add this information when we know the app loader instance is available.
2019-05-29core/telemetry_session: Explicitly delete copy and move constructorsLioncash1-1/+7
NonCopyable is misleading here. It also makes the class non-moveable as well, so we can be explicit about this.
2019-05-29core/telemetry_session: Remove unused includeLioncash1-1/+0
2019-05-27gl_device: Add commentary to AOFFI unit test source codeReinUsesLisp1-0/+1
The intention behind this commit is to hint someone inspecting an apitrace dump to ignore this ill-formed GLSL code.
2019-05-27gl_shader_gen: Always declare extensions after the version declarationReinUsesLisp2-7/+5
This addresses a bug on geometry shaders where code was being written before all #extension declarations were done. Ref to #2523
2019-05-27ncm: Implement LR OpenAddOnContentLocationResolver (2)Zach Hilman1-24/+21
Returns an object of type IAddOnContentLocationResolver for the provided StorageId.
2019-05-27ncm: Implement LR OpenRegisteredLocationResolver (1)Zach Hilman1-0/+27
Returns an object of type IRegisteredLocationResolver for the StorageId.
2019-05-27ncm: Implement LR OpenLocationResolver (0)Zach Hilman1-0/+50
Returns an object of type ILocationResolver with the provided StorageId.
2019-05-26game_list_worker: Add better error handling to cachingZach Hilman2-23/+42
2019-05-26yuzu: Clear partial/full game list cache when data is updatedZach Hilman2-0/+13
2019-05-26game_list: Implement caching for game listZach Hilman1-7/+99
Preserves list of add ons and the icon, which are the two costliest parts of game list population.
2019-05-26ui_settings: Add option to cache game listZach Hilman2-0/+3
2019-05-26loader: Move NSO module tracking to AppLoaderZach Hilman22-81/+148
Also cleanup of general stuff
2019-05-26vk_device: Let formats array type be deducedReinUsesLisp1-33/+33
2019-05-26vk_shader_decompiler: Misc fixesReinUsesLisp2-45/+67
Fix missing OpSelectionMerge instruction. This caused devices loses on most hardware, Intel didn't care. Fix [-1;1] -> [0;1] depth conversions. Conditionally use VK_EXT_scalar_block_layout. This allows us to use non-std140 layouts on UBOs. Update external Vulkan headers.
2019-05-26vk_device: Enable features when available and misc changesReinUsesLisp2-43/+151
Keeps track of native ASTC support, VK_EXT_scalar_block_layout availability and SSBO range. Check for independentBlend and vertexPipelineStorageAndAtomics as a required feature. Always enable it. Use vk::to_string format to log Vulkan enums. Style changes.
2019-05-26emu_window: Pass OnMinimalClientAreaChangeRequest argument by copyReinUsesLisp5-10/+5
There's no performance improvement in passing an unsigned pair by reference.
2019-05-25core_timing_util: Silence sign-comparison warningsLioncash1-4/+4
We can just make the conversion explicit instead of implicit here to silence -Wsign-compare warnings.
2019-05-25loader/nso: Silence sign-comparison warningLioncash1-1/+1
This was previously performing a size_t == int comparison. Silences a -Wsign-compare warning.
2019-05-25yuzu_cmd: Split emu_window OpenGL implementation into its own fileReinUsesLisp6-176/+211
2019-05-25prepo: Save reports from PlayReport serviceZach Hilman1-2/+23
Logs a lot of seemingly innocuous telemetry games generate.
2019-05-25fatal: Save report on fatal:u callZach Hilman1-21/+5
Matches offical behavior with creport and replaces old log/text based report system.
2019-05-25service: Save report on unimplemented function callZach Hilman1-0/+3
2019-05-25applets/error: Save report on error appletZach Hilman1-5/+14
This matches official behavior with the erpt/eclct/eupld service chain.
2019-05-25applets: Save report on stubbed appletZach Hilman4-15/+49
This also reworks the applet data storage to be peekable.
2019-05-25svc: Save report on call to svcBreakZach Hilman1-1/+7
2019-05-25core: Add Reporter class to take/save reportsZach Hilman5-1/+416
2019-05-25qt: Make UI option for 'Reporting Services' temporaryZach Hilman2-0/+24
Reports are unnecessary for normal users and this is to prevent 'power' users from enabling the feature by accident.
2019-05-25settings: Add 'Reporting Services' config optionZach Hilman3-10/+13
Full enable/disable for all reports.
2019-05-25arm_interface: Expand backtrace generationZach Hilman2-7/+194
Returns results as a vector of entries for further processing. Logs addresses, offsets, and mangled name.
2019-05-25core: Track load offsets of NSO modulesZach Hilman3-0/+18
Needed for backtrace decomposition
2019-05-25configure_hotkeys: Remove unnecessary Settings::Apply() callLioncash1-1/+0
Nothing from the hotkeys dialog relies on this call occurring, and is already called from the dialog that calls applyConfiguration().
2019-05-25configure_hotkeys: Tidy up key sequence conflict error stringLioncash1-2/+2
Avoids mentioning the user and formalizes the error itself.
2019-05-25configure_hotkeys: Change critical error dialog into a warning dialogLioncash1-2/+2
critical() is intended for critical/fatal errors that threaten the overall stability of an application. A user entering a conflicting key sequence is neither of those.
2019-05-25configure_hotkeys: Move conflict detection logic to IsUsedKey()Lioncash2-14/+15
We don't need to extract the entire set of hotkeys into a list and then iterate through it. We can traverse the list and early-exit if we're able to.
2019-05-25configure_hotkeys: Remove unused EmitHotkeysChanged()Lioncash3-13/+0
1. This is something that should be solely emitted by the hotkey dialog itself 2. This is functionally unused, given there's nothing listening for the signal.
2019-05-25sequence_dialog: Reorganize the constructorLioncash1-4/+8
The previous code was all "smushed" together wasn't really grouped together that well. This spaces things out and separates them by relation to one another, making it easier to visually parse the individual sections of code that make up the constructor.
2019-05-25sequence_dialog: Remove unnecessary horizontal specifierLioncash1-2/+1
QDialogButtonBoxes are horizontal by default.
2019-05-25renderer_opengl/utils: Use a std::string_view with LabelGLObject()Lioncash2-10/+10
Uses a std::string_view instead of a std::string, given the pointed to string isn't modified and is only used in a formatting operation. This is nice because a few usages directly supply a string literal to the function, allowing these usages to otherwise not heap allocate, unlike the std::string overloads. While we're at it, we can combine the address formatting into a single formatting call.
2019-05-25yuzu/configuration/configure_graphics: Eliminate type narrowing in a connect callLioncash1-6/+5
A checkbox is able to be tri-state, giving it three possible activity types, so in the connect call here, it would actually be truncating an int into a bool. Instead, we can just listen on the toggled() signal, which passes along a bool, not an int.
2019-05-25yuzu/CMakeLists: Disable implicit QString conversionsLioncash1-0/+4
Now that all of our code is compilable with implicit QString conversions, we can enforce it at compile-time by disabling them.
2019-05-25yuzu/applets/software_keyboard: Remove unused assert headerLioncash1-1/+0
This isn't actually used anywhere, so it can be removed.
2019-05-25yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()Lioncash1-1/+1
Given the std::optional can contain an object type that heap allocates, we can use std::move to avoid an unnecessary copy/allocation from occurring.
2019-05-25yuzu/applets/software_keyboard: Resolve sign mismatch comparisonLioncash1-1/+1
Qt uses a signed value to represent container sizes, so this was causing a sign mismatch warning.
2019-05-25yuzu/applets/software_keyboard: Specify string conversions explicitlyLioncash2-10/+18
Allows the software keyboard applet code to compile with implicit string conversions disabled.
2019-05-25yuzu/applets/error: Specify string conversions explicitlyLioncash1-2/+3
Allows the error applet to build successfully with implicit string conversions disabled.
2019-05-25yuzu/main: Specify string conversions where applicableLioncash1-115/+145
2019-05-24gl_shader_decompiler: Use an if based cbuf indexing for broken driversReinUsesLisp1-3/+20
The following code is broken on AMD's proprietary GLSL compiler: ```glsl uint idx = ...; vec4 values = ...; float some_value = values[idx & 3]; ``` It index the wrong components, to fix this the following pessimized code is emitted when that bug is present: ```glsl uint idx = ...; vec4 values = ...; float some_value; if ((idx & 3) == 0) some_value = values.x; if ((idx & 3) == 1) some_value = values.y; if ((idx & 3) == 2) some_value = values.z; if ((idx & 3) == 3) some_value = values.w; ```
2019-05-24gl_device: Add test to detect broken component indexingReinUsesLisp2-0/+60
Component indexing on AMD's proprietary driver is broken. This commit adds a test to detect when we are on a driver that can't successfully manage component indexing. It dispatches a dummy draw with just one vertex shader that writes to an indexed SSBO from the GPU with data sent through uniforms, it then reads that data from the CPU and compares the expected output.
2019-05-23common/file_util: Remove unnecessary return at end of void StripTailDirSlashes()Lioncash1-6/+8
While we're at it, also invert the conditional into a guard clause.
2019-05-23common/file_util: Make GetCurrentDir() return a std::optionalLioncash2-3/+4
nullptr was being returned in the error case, which, at a glance may seem perfectly OK... until you realize that std::string has the invariant that it may not be constructed from a null pointer. This means that if this error case was ever hit, then the application would most likely crash from a thrown exception in std::string's constructor. Instead, we can change the function to return an optional value, indicating if a failure occurred.
2019-05-23common/file_util: Remove duplicated documentation commentsLioncash1-25/+0
These are already present within the header, so they don't need to be repeated in the cpp file.
2019-05-23common/file_util: Make ReadFileToString and WriteStringToFile consistentLioncash3-7/+7
Makes the parameter ordering consistent, and also makes the filename parameter a std::string. A std::string would be constructed anyways with the previous code, as IOFile's only constructor with a filepath is one taking a std::string. We can also make WriteStringToFile's string parameter utilize a std::string_view for the string, making use of our previous changes to IOFile.
2019-05-23common/file_util: Remove unnecessary c_str() callsLioncash1-2/+2
The file stream open functions have supported std::string overloads since C++11, so we don't need to use c_str() here. Same behavior, less code.
2019-05-23common/file_util: Make IOFile's WriteString take a std::string_viewLioncash1-2/+2
We don't need to force the usage of a std::string here, and can instead use a std::string_view, which allows writing out other forms of strings (e.g. C-style strings) without any unnecessary heap allocations.
2019-05-23Fix bitmask logic inversionMichael Scire1-2/+1
2019-05-23fix introduced clang-format errorsMichael Scire1-3/+2
2019-05-23Address review commentsMichael Scire6-47/+120
2019-05-23clang-format fixesMichael Scire4-31/+32
2019-05-23Implement IApplicationFunctions::GetDesiredLanguageMichael Scire9-403/+1010
2019-05-23shader/shader_ir: Make Comment() take a std::string by valueLioncash2-3/+3
This allows for forming comment nodes without making unnecessary copies of the std::string instance. e.g. previously: Comment(fmt::format("Base address is c[0x{:x}][0x{:x}]", cbuf->GetIndex(), cbuf_offset)); Would result in a copy of the string being created, as CommentNode() takes a std::string by value (a const ref passed to a value parameter results in a copy). Now, only one instance of the string is ever moved around. (fmt::format returns a std::string, and since it's returned from a function by value, this is a prvalue (which can be treated like an rvalue), so it's moved into Comment's string parameter), we then move it into the CommentNode constructor, which then moves the string into its member variable).
2019-05-23shader/decode/*: Add missing newline to files lacking themLioncash18-18/+18
Keeps the shader code file endings consistent.
2019-05-23shader/decode/*: Eliminate indirect inclusionsLioncash6-1/+5
Amends cases where we were using things that were indirectly being satisfied through other headers. This way, if those headers change and eliminate dependencies on other headers in the future, we don't have cascading compilation errors.
2019-05-23service/aoc: Avoid allocating and discarding dataLioncash1-8/+8
Previously, the code was accumulating data into a std::vector and then tossing all of it away if a setting was disabled. Instead, we can just check if it's disabled and do no work at all if possible. If it's enabled, then we can append to the vector and allocate. Unlikely to impact usage much, but it is slightly less sloppy with resources.
2019-05-23service/aoc: Remove unnecessary includesLioncash1-2/+0
Removes two header dependencies related to file handling that aren't actually used within the source file.
2019-05-23service/aoc: Pop all passed values where applicableLioncash1-12/+45
A few of the aoc service stubs/implementations weren't fully popping all of the parameters passed to them. This ensures that all parameters are popped and, at minimum, logged out.
2019-05-22shader/decode/memory: Remove left in debug pragmaLioncash1-2/+0
2019-05-21renderer_opengl/gl_shader_decompiler: Remove redundant name specification in format stringLioncash1-1/+1
This accidentally slipped through a rebase.
2019-05-21gl_shader_cache: Fix clang strict standard build issuesReinUsesLisp3-9/+13
2019-05-21gl_shader_cache: Use shared contexts to build shaders in parallelReinUsesLisp7-56/+112
2019-05-21shader/memory: Implement ST (generic memory)ReinUsesLisp2-21/+36
2019-05-21shader/memory: Implement LD (generic memory)ReinUsesLisp3-15/+38
2019-05-21yuzu/configuration/config: Make default hotkeys an internally-linked array in the cpp fileLioncash2-4/+2
Given the array is a private static array, we can just make it internally linked to hide it from external code. This also allows us to remove an inclusion within the header.
2019-05-21yuzu/configuration/config: Specify string conversions explicitlyLioncash1-30/+42
Allows the configuration code to build successfully with implicit string conversions disabled.
2019-05-20shader: Implement S2R Tid{XYZ} and CtaId{XYZ}ReinUsesLisp4-15/+69
2019-05-20gl_shader_decompiler: Make GetSwizzle constexprReinUsesLisp1-7/+7
2019-05-20yuzu/game_list: Specify string conversions explicitlyLioncash2-50/+55
Allows the game list code to compile successfully with implicit string conversions disabled.
2019-05-20yuzu/game_list_worker: Specify string conversions explicitlyLioncash1-2/+2
Allows the game list worker code to compile successfully with implicit string conversions disabled.
2019-05-20yuzu/game_list_p: Amend mentions of SMDH in commentsLioncash1-3/+3
SMDH is a metadata format used in some executable formats for the Nintendo 3DS. Switch executables don't utilize this metadata format, so this just a holdover from Citra and can be corrected.
2019-05-20yuzu/game_list_p: Specify string conversions explicitlyLioncash1-10/+9
Allows the game list item code to build with implicit string conversions disabled.
2019-05-20yuzu/loading_screen: Specify string conversions explicitlyLioncash1-9/+9
Allows the loading screen code to compile with implicit string conversions disabled. While we're at it remove unnecessary const usages, and add it to nearby variables where appropriate.
2019-05-20yuzu/bootmanager: Specify string conversions explicitlyLioncash1-2/+4
Allows the bootmanager code to compile with implicit string conversions disabled.
2019-05-20yuzu/util: Specify string conversions explicitlyLioncash1-8/+10
Allows the util code to build with implicit string conversions disabled.
2019-05-20gl_shader_decompiler: Tidy up minor remaining cases of unnecessary std::string concatenationLioncash1-21/+20
2019-05-20gl_shader_decompiler: Replace individual overloads with the fmt-based oneLioncash1-28/+16
Gets rid of the need to special-case brace handling depending on the overload used, and makes it consistent across the board with how fmt handles them. Strings with compile-time deducible strings are directly forwarded to std::string's constructor, so we don't need to worry about the performance difference here, as it'll be identical.
2019-05-20gl_shader_decompiler: Utilize fmt overload of AddLine() where applicableLioncash1-136/+152
2019-05-19Revert #2466Fernando Sahmkow1-1/+3
This reverts a tested behavior on delay slots not exiting if the exit flag is set. Currently new tests are required in order to ensure this behavior.
2019-05-19gl_shader_decompiler: Add AddLine() overload that forwards to fmtLioncash1-0/+11
In a lot of places throughout the decompiler, string concatenation via operator+ is used quite heavily. This is usually fine, when not heavily used, but when used extensively, can be a problem. operator+ creates an entirely new heap allocated temporary string and given we perform expressions like: std::string thing = a + b + c + d; this ends up with a lot of unnecessary temporary strings being created and discarded, which kind of thrashes the heap more than we need to. Given we utilize fmt in some AddLine calls, we can make this a part of the ShaderWriter's API. We can make an overload that simply acts as a passthrough to fmt. This way, whenever things need to be appended to a string, the operation can be done via a single string formatting operation instead of discarding numerous temporary strings. This also has the benefit of making the strings themselves look nicer and makes it easier to spot errors in them.
2019-05-19yuzu/configuration/configure_web: Specify string conversions explicitlyLioncash1-8/+16
Allows the web config code to compile with implicit string conversions disabled. We can also deduplicate the calls to create the pixmap.
2019-05-19yuzu/configuration/configure_system: Specify string conversions explicitlyLioncash1-2/+3
Allows the system config code to build successfully with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_profile_manager: Mark UI string as translatableLioncash1-1/+1
This is a user-facing string, so it should be marked as translatable.
2019-05-19yuzu/configuration/configure_per_general: Specify string conversions explicitlyLioncash1-6/+8
Allows the per-game configuration to be successfully built with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_mouse_advanced: Clean up array accessesLioncash1-19/+22
Deduplicates array accesses and uses a named variable where appropriate.
2019-05-19yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitlyLioncash1-11/+23
Allows the advanced mouse configuration code to build with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_input_player: Clean up array accessesLioncash1-32/+48
Rather than repeatedly index arrays that have quite a large array index, we can just use a named variable instead.
2019-05-19yuzu/configuration/configure_input_player: Specify string conversions explicitlyLioncash1-24/+49
Allows the player input configuration code to compile with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_input: Mark controller type names as translateableLioncash1-5/+8
These are user-facing strings, so they should be localizable.
2019-05-19yuzu/configuration/configure_general: Specify string conversions explicitlyLioncash1-1/+2
Allows the general configuration code to successfully compile with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_gamelist: Specify string conversions explicitlyLioncash1-3/+5
Allows the gamelist configuration code to compile with implicit string conversions disabled.
2019-05-19yuzu/configuration/configure_audio: Store power on query into a variableLioncash1-2/+3
Avoids using the system accessor more than necessary, and ensures that both dialog boxes see the same power on state.
2019-05-19yuzu/configuration/configure_audio: Tidy up function castLioncash1-2/+1
We can just use qOverload here to tidy up the function cast.
2019-05-19yuzu/configuration/configure_audio: Specify string conversions explicitlyLioncash1-3/+3
Allows the audio configuration code to build with implicit string conversions disabled.
2019-05-19Dma_pusher: ASSERT on empty command_listFernando Sahmkow1-0/+7
This is a measure to avoid crashes on command list reading as an empty command_list is considered a NOP.
2019-05-19shader/shader_ir: Remove unnecessary inline specifiersLioncash1-2/+2
constexpr internally links by default, so the inline specifier is unnecessary.
2019-05-19shader/shader_ir: Simplify constructors for OperationNodeLioncash1-15/+6
Many of these constructors don't even need to be templated. The only ones that need to be templated are the ones that actually make use of the parameter pack. Even then, since std::vector accepts an initializer list, we can supply the parameter pack directly to it instead of creating our own copy of the list, then copying it again into the std::vector.
2019-05-19shader/shader_ir: Remove unnecessary template parameter packs from Operation() overloads where applicableLioncash1-2/+0
These overloads don't actually make use of the parameter pack, so they can be turned into regular non-template function overloads.
2019-05-19shader/shader_ir: Mark tracking functions as const member functionsLioncash2-8/+11
These don't actually modify instance state, so they can be marked as const member functions
2019-05-19yuzu/util: Remove unused spinbox.cpp/.hLioncash3-366/+0
This has been left unused since the removal of the vestigial surface viewer. Given it has no uses left, this can be removed as well.
2019-05-19shader/shader_ir: Place implementations of constructor and destructor in cpp fileLioncash2-5/+9
Given the class contains quite a lot of non-trivial types, place the constructor and destructor within the cpp file to avoid inlining construction and destruction code everywhere the class is used.
2019-05-19gl_shader_gen: std::move objects where applicableLioncash1-7/+7
Avoids performing copies into the pair being returned. Instead, we can just move the resources into the pair, avoiding the need to make copies of both the std::string and ShaderEntries struct.
2019-05-19gl_shader_disk_cache: in-class initialize virtual file offset of ShaderDiskCacheOpenGLLioncash2-5/+3
Given the offset is assigned a fixed value in the constructor, we can just assign it directly and get rid of the need to write the name of the variable again in the constructor initializer list.
2019-05-19gl_shader_disk_cache: Default ShaderDiskCacheOpenGL's destructor in the cpp fileLioncash2-0/+3
Given the disk shader cache contains non-trivial types, we should default it in the cpp file in order to prevent inlining of the complex destruction logic.
2019-05-19gl_shader_disk_cache: Make hash specializations noexceptLioncash1-2/+2
The standard library expects hash specializations that don't throw exceptions. Make this explicit in the type to allow selection of better code paths if possible in implementations.
2019-05-19gl_shader_disk_cache: Remove redundant code string construction in LoadDecompiledEntry()Lioncash1-2/+2
We don't need to load the code into a vector and then construct a string over the data. We can just create a string with the necessary size ahead of time, and read the data directly into it, getting rid of an unnecessary heap allocation.
2019-05-19gl_shader_disk_cache: Make variable non-const in decompiled entry caseLioncash1-1/+1
std::move does nothing when applied to a const variable. Resources can't be moved if the object is immutable. With this change, we don't end up making several unnecessary heap allocations and copies.
2019-05-19gl_shader_disk_cache: Special-case boolean handlingLioncash2-24/+37
Booleans don't have a guaranteed size, but we still want to have them integrate into the disk cache system without needing to actually use a different type. We can do this by supplying non-template overloads for the bool type. Non-template overloads always have precedence during function resolution, so this is safe to provide. This gets rid of the need to smatter ternary conditionals, as well as the need to use u8 types to store the value in.
2019-05-19yuzu/applets/profile_select: Mark header string as translatableLioncash1-2/+2
This is a user-facing string, so it should be marked as translatable.
2019-05-19yuzu/debugger/graphics/graphics_breakpoints: Specify string conversions explicitlyLioncash1-1/+1
Allows the graphics breakpoints to compile with implicit string conversions disabled.
2019-05-19yuzu/debugger/profiler: Specify string conversions explicitlyLioncash1-2/+2
This allows the microprofile widget to compile with implicit string conversions disabled.
2019-05-19yuzu/debugger/wait_tree: Specify string conversions explicitlyLioncash1-14/+17
Allows compiling the wait tree widget with implicit string conversions disabled.
2019-05-19ipc_helpers: Amend floating-point type in Pop<double> specializationLioncash1-1/+1
Currently, this overload isn't used, so this wasn't actually hit in any code, only the float overload is used.
2019-05-19Address review commentTobias1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2019-05-19kernel/svc: Mark GetThreadList() and UnmapProcessCodeMemory() as internally linkedLioncash1-4/+4
These are only used from within this translation unit, so they don't need to have external linkage. They were intended to be marked with this anyways to be consistent with the other service functions.
2019-05-19service/am: Add missing return in error case for IStorageAccessor's Read()/Write().Lioncash1-0/+2
Previously this would fall through and return successfully, despite being an out of bounds read or write.
2019-05-18core/kernel/object: Rename ResetType enum membersLioncash19-35/+36
Renames the members to more accurately indicate what they signify. "OneShot" and "Sticky" are kind of ambiguous identifiers for the reset types, and can be kind of misleading. Automatic and Manual communicate the kind of reset type in a clearer manner. Either the event is automatically reset, or it isn't and must be manually cleared. The "OneShot" and "Sticky" terminology is just a hold-over from Citra where the kernel had a third type of event reset type known as "Pulse". Given the Switch kernel only has two forms of event reset types, we don't need to keep the old terminology around anymore.
2019-05-18HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThreadWeiyi Wang4-9/+10
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
2019-05-18gl_rasterizer: Limit OpenGL point size to a minimum of 1ReinUsesLisp1-1/+3
2019-05-18maxwell_to_gl: Add TriangleFan primitive topologyReinUsesLisp1-0/+2
2019-05-17gl_rasterizer: Pass the right number of array quad vertices countReinUsesLisp1-2/+2
2019-05-17qt/configure_graphics: Shadow options at runtimeReinUsesLisp1-2/+6
Compatibility profile and the disk shader cache settings shouldn't be changed at runtime. This aims to address that shadowing those options.
2019-05-17yuzu_cmd: Use OpenGL compat when asked in the settingsReinUsesLisp1-1/+5
2019-05-17yuzu_cmd: Make OpenGL's context currentReinUsesLisp1-0/+1
The SDL2 frontend never bound the OpenGL context, resulting on a white screen and no-ops all over the backend.
2019-05-17yuzu/bootmanager: Explicitly enable deprecated OpenGL features on compatReinUsesLisp1-0/+1
Nvidia's proprietary driver creates a real OpenGL compatibility profile without this option, meanwhile Intel (and probably AMD, I haven't tested it) require that QSurfaceFormat::FormatOption::DeprecatedFunctions is explicitly enabled.
2019-05-14maxwell_3d: reduce sevirity of different component formats assert.Fernando Sahmkow1-1/+1
This was reduced due to happening on most games and at such constant rate that it affected performance heavily for the end user. In general, we are well aware of the assert and an implementation is already planned.
2019-05-14video_core/engines/engine_upload: Amend constructor initializer list orderLioncash1-1/+1
Silences a -Wreorder warning.
2019-05-14video_core/engines/engine_upload: Default destructor in the cpp fileLioncash2-1/+3
Avoids inlining destruction logic where applicable, and also makes forward declarations not cause unexpected compilation errors depending on where the State class is used.
2019-05-14video_core/engines/engine_upload: Remove unnecessary const on parameters in function declarationsLioncash1-2/+2
These only apply in the definition of the function. They can be omitted from the declaration.
2019-05-14video_core/engines/engine_upload: Remove unnecessary includesLioncash2-2/+2
2019-05-14video_core/engines/maxwell3d: Get rid of three magic values in CallMethod()Lioncash1-3/+3
We can use the named constant instead of using 32 directly.
2019-05-14video_core/engines/maxwell_3d: Simplify for loops into ranged for loops within InitializeRegisterDefaults()Lioncash1-15/+15
Lessens the amount of code that needs to be read, and gets rid of the need to introduce an indexing variable. Instead, we just operate on the objects directly.
2019-05-14video_core/engines/maxwell_3d: Add is_trivially_copyable_v check for RegsLioncash1-0/+2
std::memset is used to clear the entire register structure, which requires that the Regs struct be trivially copyable (otherwise undefined behavior is invoked). This prevents the case where a non-trivial type is potentially added to the struct.
2019-05-14yuzu: Remove explicit types from locks where applicableLioncash3-3/+3
With C++17's deduction guides, the type doesn't need to be explicitly specified within locking primitives anymore.
2019-05-14video_core/gpu_thread: Remove redundant copy constructor for CommandDataContainerLioncash1-6/+0
std::move within a copy constructor (on a data member that isn't mutable) will always result in a copy. Because of that, the behavior of this copy constructor is identical to the one that would be generated automatically by the compiler, so we can remove it.
2019-05-12GPU/MMEInterpreter: Ignore the 'exit' flag when it's executed inside a delay slot.Sebastian Valle1-3/+3
It seems instructions marked with the 'exit' flag will not cause an exit when executed within a delay slot. This was hwtested by fincs.
2019-05-10service/set: Correct and simplify behavior related to copying language codesLioncash1-34/+22
This corrects cases where it was possible to write more entries into the write buffer than were requested. Now, we check the size of the buffer before actually writing into them. We were also returning the wrong value for GetAvailableLanguageCodeCount2(). This was previously returning 64, but only 17 should have been returned. 64 entries is the size of the static array used in MakeLanguageCode() within the service binary itself, but isn't the actual total number of language codes present.
2019-05-10video_core/memory_manager: Mark IsBlockContinuous() as a const member functionLioncash2-4/+4
Corrects the typo in its name and marks the function as a const member function, given it doesn't actually modify memory manager state.
2019-05-10video_core/memory_manager: Mark the constructor as explicitLioncash1-1/+1
Prevents implicit converting constructions of the memory manager.
2019-05-10video_core/memory_manager: Default the destructor within the cpp fileLioncash2-0/+3
Makes the class less surprising when it comes to forward declaring the type, and also prevents inlining the destruction code of the class, given it contains non-trivial types.
2019-05-10video_core/memory_manager: Amend doxygen commentsLioncash1-7/+7
Corrects references to non-existent parameters and corrects typos.
2019-05-10video_core/memory_manager: Remove superfluous const from function declarationsLioncash1-7/+7
These are able to be omitted from the declaration of functions, since they don't do anything at the type system level. The definitions of the functions can retain the use of const though, since they make the variables immutable in the implementation of the function where they're used.
2019-05-10video_core/renderer_opengl/gl_shader_cache: Correct member initialization orderLioncash1-1/+1
Silences a -Wreorder warning.
2019-05-10video_core/shader/decode/texture: Remove unused variable from GetTld4Code()Lioncash1-1/+0
2019-05-10renderer_vulkan/vk_shader_decompiler: Remove unused variable from DeclareInternalFlags()Lioncash1-1/+0
2019-05-10video_core/renderer_opengl/gl_shader_decompiler: Remove unused Composite() functionLioncash1-11/+0
This isn't used at all, so it can be removed.
2019-05-10video_core/renderer_opengl/gl_rasterizer_cache: Remove unused variable in UploadGLMipmapTexture()Lioncash1-1/+0
This variable is unused entirely, so it can be removed.
2019-05-10video_core/gpu_thread: Remove unused local variableLioncash1-1/+1
Instead of retrieving the data from the std::variant instance, we can just check if the variant contains that type of data. This is essentially the same behavior, only it returns a bool indicating whether or not the type in the variant is currently active, instead of actually retrieving the data.
2019-05-10video_core/textures/astc: Remove unused variablesLioncash1-6/+2
Silences a few compilation warnings.
2019-05-09CMakeLists: Specify /volatile:iso for MSVCLioncash1-0/+2
By default, MSVC doesn't use standards-compliant volatile semantics. This makes it behave in a standards-compliant manner, making expectations more uniform across compilers.
2019-05-09configure_dialog: Remove the Whats This? button from the dialogLioncash1-0/+4
2019-05-09yuzu/hotkeys: Remove unnecessary constructorLioncash1-2/+0
The behavior of the Hotkey constructor is already accomplished via in-class member initializers, so the constructor is superfluous here.
2019-05-09yuzu/main: Move window title updating logic to its own functionLioncash2-7/+19
For similar reasons to the previous change, we move this to a single function, so we don't need to duplicate the conversion logic in several places within main.cpp.
2019-05-09yuzu/about_dialog: Specify string conversions explicitlyLioncash1-4/+4
Specifies the conversions explicitly to avoid implicit conversions from const char* to QString. This makes it easier to disable implicit QString conversions in the future. In this case, the implicit conversion was technically wrong as well. The implicit conversion treats the input strings as ASCII characters. This would result in an incorrect conversion being performed in the rare case a branch name was created with a non-ASCII Unicode character, likely resulting in junk being displayed.
2019-05-09yuzu/compatdb: Remove unnecessary qualifiersLioncash1-3/+3
Keeps the code consistent in regards to how the buttons are referred to.
2019-05-09configuration/config: Move config loading and saving to functions based off groupsLioncash2-315/+573
Over time our config values have grown quite numerous in size. Unfortunately it also makes the single functions we have for loading and saving values more error prone. For example, we were loading the core settings twice when they only should have been loaded once. In another section, a variable was shadowing another variable used to load settings from a completely different section. Finally, in one other case, there was an extraneous endGroup() call used that didn't need to be done. This was essentially dead code and also a bug waiting to happen. This separates the section loading code into its own separate functions. This keeps variables only visible to the code that actually needs it, and makes it much easier to visually see the end of each individual configuration group. It also makes it much easier to visually catch bugs during code review. While we're at it, this also uses QStringLiteral instead of raw string literals, which both avoids constructing a lot of QString instances, but also makes it much easier to disable implicit ASCII to QString and vice-versa in the future via setting QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII as compilation flags.
2019-05-07src/CMakeLists: Add /Zc:externConstexpr to the MSVC build flagsLioncash1-8/+10
The C++ standard allows constexpr variables declared with the extern keyword to have external linkage. Previously MSVC wasn't abiding by this. This just makes the compiler more standards compliant during builds. Given we currently don't make use of anything that would break by this, this is safe to enable.
2019-05-07src/CMakeLists: Vertically order compilation flagsLioncash1-9/+19
Makes it much nicer to visually scan the options. This also starts the flag descriptions from the same column for the same reason.
2019-05-07core/memory: Remove unused FlushMode enumLioncash1-9/+0
Recent changes to memory-related code resulted in this being unused, so we can remove it.
2019-05-07Correct possible error on Rasterizer CachesFernando Sahmkow1-1/+2
There was a weird bug that could happen if the object died directly and the cache address wasn't stored.
2019-05-04core/telemetry_session: Only create the backend when we really need itzhupengfei2-9/+9
The backend is not used until we decide to submit the testcase/telemetry, and creating it early prevents users from updating the credentials properly while the games are running.
2019-05-04shader/decode/texture: Remove unused variableLioncash1-1/+0
This isn't used anywhere, so we can get rid of it.
2019-05-04CMakeLists: Explicitly specify -Wall for the non-MSVC caseLioncash1-1/+4
Ensures that -Wall is always active as a compilation flag.
2019-05-04gl_rasterizer: Silence unused variable warningLioncash1-2/+2
Makes use of src, so it's not considered unused.
2019-05-04common/zstd_compression: Remove #pragma once directive from source fileLioncash1-2/+0
Introduced in 72477731ed20c56a4d6f18a22f43224fab667cef. This is only necessary within header files.
2019-05-04core/frontend/emu_window: Make GraphicsContext's destructor virtualLioncash2-0/+4
This class is used in a polymorphic context, so destruction of the context will lead to undefined behavior if the destructor isn't virtual.
2019-05-03shader_ir/other: Implement IPA.IDXReinUsesLisp2-5/+9
2019-05-03gl_shader_decompiler: Skip physical unused attributesReinUsesLisp1-18/+27
2019-05-03shader_ir/memory: Assert on non-32 bits ALD.PHYSReinUsesLisp1-0/+3
2019-05-03shader: Add physical attributes commentariesReinUsesLisp4-4/+8
2019-05-03gl_shader_decompiler: Implement GLSL physical attributesReinUsesLisp2-66/+101
2019-05-03shader_ir/memory: Implement physical input attributesReinUsesLisp4-6/+32
2019-05-03gl_shader_decompiler: Abstract generic attribute operationsReinUsesLisp1-29/+26
2019-05-03gl_shader_decompiler: Declare all possible varyings on physical attribute usageReinUsesLisp4-27/+88
2019-05-03shader: Remove unused AbufNode Ipa modeReinUsesLisp6-35/+14
2019-05-03shader_ir/memory: Emit AL2P IRReinUsesLisp2-0/+22
2019-05-03shader_bytecode: Add AL2P decodingReinUsesLisp1-2/+15
2019-05-01Refactors and name corrections.Fernando Sahmkow6-35/+35
2019-05-01service/audren_u: Handle variadic command buffers in GetWorkBufferSize()Lioncash2-17/+93
Also introduced in REV5 was a variable-size audio command buffer. This also affects how the size of the work buffer should be determined, so we can add handling for this as well. Thankfully, no other alterations were made to how the work buffer size is calculated in 7.0.0-8.0.0. There were indeed changes made to to how some of the actual audio commands are generated though (particularly in REV7), however they don't apply here.
2019-05-01service/audren_u: Handle version 2 of performance frame info in GetWorkBufferSize()Lioncash2-6/+13
Introduced in REV5. This is trivial to add support for, now that everything isn't a mess of random magic constant values. All this is, is a change in data type sizes as far as this function cares.
2019-05-01service/audren_u: Clean up work buffer calculationsLioncash1-49/+214
"Unmagics" quite a few magic constants within this code, making it much easier to understand. Particularly given this factors out specific sections into their own self-contained lambda functions.
2019-05-01gl_shader_disk_cache: Skip stored shader variants instead of assertingReinUsesLisp1-1/+4
Instead of asserting on already stored shader variants, silently skip them. This shouldn't be happening but when a shader is invalidated and it is not stored in the shader cache, this assert would hit and save that shader anyways when the asserts are disabled.
2019-05-01Fix Layered ASTC TexturesFernando Sahmkow1-1/+3
By adding the missing layer offset in ASTC compression.
2019-05-01loader/nso: Remove left-in debug pragmaLioncash1-2/+0
Unintentionally introduced in 552d5071fa171165e4054392d8bb6bf2ecc924e2
2019-04-29kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug logLioncash1-4/+4
These are actually quite important indicators of thread lifetimes, so they should be going into the debug log, rather than being treated as misc info and delegated to the trace log.
2019-04-29kernel/svc: Reorganize svcSetThreadCoreMask()Lioncash1-32/+39
Makes the code much nicer to follow in terms of behavior and control flow. It also fixes a few bugs in the implementation. Notably, the thread's owner process shouldn't be accessed in order to retrieve the core mask or ideal core. This should be done through the current running process. The only reason this bug wasn't encountered yet is because we currently only support running one process, and thus every owner process will be the current process. We also weren't checking against the process' CPU core mask to see if an allowed core is specified or not. With this out of the way, it'll be less noisy to implement proper handling of the affinity flags internally within the kernel thread instances.
2019-04-29kernel/thread: Update thread processor ID flagsLioncash2-7/+16
Adds the missing flags to the enum and documents them.
2019-04-28service/audctl: Update documentation comments to be relative to 8.0.0Lioncash1-2/+2
The state of these service calls are still the same in version 8.0.0.
2019-04-26shader_ir: Move Sampler index entry in operand< to sort declarationsReinUsesLisp1-2/+2
2019-04-26shader_ir: Add missing entry to Sampler operand< comparisonReinUsesLisp1-2/+3
2019-04-26shader_ir/texture: Fix sampler const buffer key shiftReinUsesLisp1-1/+1
2019-04-25mii_manager: Fix incorrect loop condition in mii UUID generation codeZach Hilman3-2/+3
2019-04-25profile_select: Port Service::Account::UUID to Common::UUIDZach Hilman9-29/+27
2019-04-25mii: Implement Delete and Destroy fileZach Hilman4-13/+122
2019-04-25mii: Implement IsUpdated command (IPC 0)Zach Hilman3-9/+34
2019-04-25mii_manager: Cleanup and optimizationZach Hilman5-39/+55
2019-04-25mii: Implement IDatabaseService commands using MiiManagerZach Hilman2-15/+244
Since the MiiManager was designed around the IPC interface, this is quite easy. Only functions that were clearly defined were implemented.
2019-04-25mii: Add MiiManager class to manage Mii databaseZach Hilman2-0/+622
Provides serialization/deserialization to the database in system save files, accessors for database state and proper handling of both major Mii formats (MiiInfo and MiiStoreData)
2019-04-25common: Extract UUID to its own classZach Hilman6-78/+108
Since the Mii database uses UUIDs very similar to the Accounts database, it makes no sense to not share code between them.
2019-04-23Re added new lines at the end of filesFreddyFunk2-2/+2
2019-04-23gl_shader_disk_cache: Compress precompiled shader cache file with Zstandardunknown1-6/+10
2019-04-23gl_shader_disk_cache: Use VectorVfsFile for the virtual precompiled shader cache fileunknown3-101/+168
2019-04-23gl_shader_disk_cache: Remove per shader compressionunknown2-45/+11
2019-04-23Fixes and Corrections to DMA EngineFernando Sahmkow2-37/+57
2019-04-23Add Swizzle Parameters to the DMA engineFernando Sahmkow2-2/+27
2019-04-23Add Documentation Headers to all the GPU EnginesFernando Sahmkow5-0/+29
2019-04-23Corrections and stylingFernando Sahmkow5-6/+9
2019-04-23Implement Maxwell3D Data UploadFernando Sahmkow2-3/+32
2019-04-23Introduce skeleton of the GPU Compute Engine.Fernando Sahmkow3-8/+202
2019-04-23Revamp Kepler Memory to use a subegine to manage uploadsFernando Sahmkow6-93/+134
2019-04-21Rasterizer Cache: Use a temporal storage for Surfaces loading/flushing.Fernando Sahmkow4-18/+30
This PR should heavily reduce memory usage since temporal buffers are no longer stored per Surface but instead managed by the Rasterizer Cache.
2019-04-21Corrections Half Float operations on const buffers and implement saturation.Fernando Sahmkow2-15/+16
2019-04-20Allow picking a Compatibility Profile for OpenGL.Fernando Sahmkow7-1/+21
This option allows picking the compatibility profile since a lot of bugs are fixed in it. We devs will use this option to easierly debug current problems in our Core implementation.:wq
2019-04-20Apply Position Y DirectionFernando Sahmkow1-0/+3
2019-04-20RasterizerCache Redesign: Flush Fernando Sahmkow6-17/+26
flushing is now responsability of children caches instead of the cache object. This change will allow the specific cache to pass extra parameters on flushing and will allow more flexibility.
2019-04-20make ReadBlockunsafe and WriteBlockunsafe, ignore invalid pages.Fernando Sahmkow1-4/+12
2019-04-19gl_state: Fix samplers memory corruptionReinUsesLisp1-3/+5
It was possible for "samplers" to be read without being written. This addresses that.
2019-04-19kernel/svc: Name supervisor call 0x36Lioncash1-1/+1
This call was added to the SVC handlers in the 8.0.0 kernel, so we can finally give it a name.
2019-04-18service/audctl: Implement GetTargetVolumeMin() and GetTargetVolumeMax()Lioncash2-2/+32
These two service functions are literally hardcoded to always return these values without any other error checking.
2019-04-18video_core: Silent -Wswitch warningsReinUsesLisp10-77/+106
2019-04-17web_browser: Make OpenPage non-constZach Hilman13-25/+30
2019-04-17main: Add GMainWindow hooks for Error displayZach Hilman4-3/+11
2019-04-17main: Switch to AppletManager for frontendZach Hilman1-3/+9
2019-04-17qt: Add dialog implementation of Error appletZach Hilman3-0/+94
2019-04-17general_backend: Move StubApplet and add backend PhotoViewerZach Hilman2-1/+102
2019-04-17general_frontend: Add frontend scaffold for PhotoViewer appletZach Hilman2-0/+55
2019-04-17frontend: Add frontend receiver for Error appletZach Hilman3-2/+79
2019-04-17applets: Add Error appletZach Hilman3-24/+224
Responsible for displaying error codes and messages
2019-04-17applets: Port current applets to take frontend in constructorZach Hilman6-14/+16
As opposed to using Core::System::GetInstance()
2019-04-17web_browser: Make OpenPage constZach Hilman4-7/+7
2019-04-17core: Remove specific applets in favor of AppletManagerZach Hilman2-47/+32
2019-04-17am: Delegate applet creation to AppletManagerZach Hilman1-24/+3
2019-04-17applets: Add AppletManager class to control lifetimeZach Hilman2-0/+137
2019-04-17kernel/thread: Unify wait synchronization typesLioncash7-45/+38
This is a holdover from Citra, where the 3DS has both WaitSynchronization1 and WaitSynchronizationN. The switch only has one form of wait synchronizing (literally WaitSynchonization). This allows us to throw out code that doesn't apply at all to the Switch kernel. Because of this unnecessary dichotomy within the wait synchronization utilities, we were also neglecting to properly handle waiting on multiple objects. While we're at it, we can also scrub out any lingering references to WaitSynchronization1/WaitSynchronizationN in comments, and change them to WaitSynchronization (or remove them if the mention no longer applies).
2019-04-17kernel/svc: Migrate svcCancelSynchronization behavior to a thread functionLioncash3-7/+17
The actual behavior of this function is slightly more complex than what we're currently doing within the supervisor call. To avoid dumping most of this behavior in the supervisor call itself, we can migrate this to another function.
2019-04-17kernel/wait_object: Make GetHighestPriorityReadyThread() a const member functionLioncash2-2/+2
This doesn't actually modify internal state of a wait object, so it can be const qualified.
2019-04-17yuzu/bootmanager: Replace unnnecessary constructor initializer list member of GGLContextLioncash1-2/+2
The default constructor will always run, even when not specified, so this is redundant. However, the context member can indeed be initialized in the constructor initializer list.
2019-04-17yuzu/bootmanager: Remove unnecessary includesLioncash1-1/+0
This include isn't used anymore so it can be removed.
2019-04-17yuzu/bootmanager: Resolve constructor initializer list warningsLioncash1-2/+1
Resolves -Wreorder warnings. These will automatically be initialized to nullptr anyways, so these were redundant.
2019-04-17CMakeLists: Ensure we specify Unicode as the codepage on WindowsLioncash2-4/+9
Previously we were building with MBCS, which is pretty undesirable. We want the application to be Unicode-aware in general. Currently, we make the command line variant of yuzu use ANSI variants of the non-standard getopt functions that we link in for Windows, given we only have an ANSI option-set. We should really replace getopt with a library that we make all build types of yuzu link in, but this will have to do for the time being.
2019-04-17kernel/vm_manager: Remove usages of global system accessorsLioncash3-7/+11
Makes the dependency on the system instance explicit within VMManager's interface.
2019-04-17Implement IsBlockContinousFernando Sahmkow2-2/+13
This detects when a GPU Memory Block is not continous within host cpu memory.
2019-04-16Apply Const correctness to SwizzleKepler and replace u32 for size_t on iterators.Fernando Sahmkow2-9/+12
2019-04-16Use ReadBlockUnsafe for fetyching DMA CommandListsFernando Sahmkow2-4/+2
2019-04-16Document unsafe versions and add BlockCopyUnsafeFernando Sahmkow3-16/+45
2019-04-16Use ReadBlockUnsafe for Shader CacheFernando Sahmkow1-5/+7
2019-04-16Use ReadBlockUnsafe on TIC and TSC readingFernando Sahmkow2-2/+4
Use ReadBlockUnsafe on TIC and TSC reading as memory is never flushed from host GPU there.
2019-04-16GPU MemoryManager: Implement ReadBlockUnsafe and WriteBlockUnsafeFernando Sahmkow2-0/+34
2019-04-16Use WriteBlock and ReadBlock.Fernando Sahmkow1-10/+6
2019-04-16Implement Block Linear copies in Kepler Memory.Fernando Sahmkow3-5/+38
2019-04-16vk_shader_decompiler: Add missing operationsReinUsesLisp1-0/+7
2019-04-16shader_ir/decode: Fix half float pre-operations and remove MetaHalfArithmeticReinUsesLisp9-85/+72
Operations done before the main half float operation (like HAdd) were managing a packed value instead of the unpacked one. Adding an unpacked operation allows us to drop the per-operand MetaHalfArithmetic entry, simplifying the code overall.
2019-04-16gl_shader_decompiler: Fix MrgH0 decompilationReinUsesLisp1-2/+2
GLSL decompilation for HMergeH0 was wrong. This addresses that issue.
2019-04-16shader_ir/decode: Implement half float saturationReinUsesLisp5-8/+31
2019-04-16shader_ir/decode: Reduce severity of unimplemented half-float FTZReinUsesLisp3-3/+9
2019-04-16renderer_opengl: Implement half float NaN comparisonsReinUsesLisp3-36/+59
2019-04-16shader_ir: Avoid using static on heap-allocated objectsReinUsesLisp1-5/+4
Using static here might be faster at runtime, but it adds a heap allocation called before main.
2019-04-16Do some corrections in conversion shader instructions.Fernando Sahmkow2-23/+73
Corrects encodings for I2F, F2F, I2I and F2I Implements Immediate variants of all four conversion types. Add assertions to unimplemented stuffs.
2019-04-15CMakeLists: Define QT_USE_QSTRINGBUILDER for the Qt targetLioncash2-1/+7
This is a compile definition introduced in Qt 4.8 for reducing the total potential number of strings created when performing string concatenation. This allows for less memory churn. This can be read about here: https://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/ For a change that isn't source-compatible, we only had one occurrence that actually need to have its type clarified, which is pretty good, as far as transitioning goes.
2019-04-15svc: Specify handle value in thread's nameLioncash2-2/+10
Allows the handle to be seen alongside the entry point.
2019-04-15Correct Kepler Memory on Linear Pushes.Fernando Sahmkow2-16/+48
2019-04-15Support compressed formats on linear textures.Fernando Sahmkow1-2/+5
2019-04-15common/{lz4_compression, zstd_compression}: Add missing header guardsLioncash2-0/+4
These two files were missing the #pragma once directive.
2019-04-15Correct Pitch in Fermi2DFernando Sahmkow1-4/+1
2019-04-15kernel/thread: Remove BoostPriority()Lioncash2-11/+0
This is a holdover from Citra that currently remains unused, so it can be removed from the Thread interface.
2019-04-14kernel/thread: Remove unused guest_handle member variableLioncash3-16/+7
This member variable is entirely unused. It was only set but never actually utilized. Given that, we can remove it to get rid of noise in the thread interface.
2019-04-14gl_shader_decompiler: Use variable AOFFI on supported hardwareReinUsesLisp10-71/+102
2019-04-14shader_ir: Implement STG, keep track of global memory usage and flushReinUsesLisp11-89/+186
2019-04-13kernel/svc: Implement svcUnmapProcessCodeMemoryLioncash3-1/+143
Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps the aliasing region first, then restores the general traits of the aliased memory. What this entails, is: - Restoring Read/Write permissions to the VMA. - Restoring its memory state to reflect it as a general heap memory region. - Clearing the memory attributes on the region.
2019-04-13kernel/svc: Implement svcMapProcessCodeMemoryLioncash4-1/+131
This is utilized for mapping code modules into memory. Notably, the ldr service would call this in order to map objects into memory.
2019-04-12Fix Clang FormatFreddyFunk2-5/+10
2019-04-12common/swap: Improve codegen of the default swap fallbacksLioncash1-3/+7
Uses arithmetic that can be identified more trivially by compilers for optimizations. e.g. Rather than shifting the halves of the value and then swapping and combining them, we can swap them in place. e.g. for the original swap32 code on x86-64, clang 8.0 would generate: mov ecx, edi rol cx, 8 shl ecx, 16 shr edi, 16 rol di, 8 movzx eax, di or eax, ecx ret while GCC 8.3 would generate the ideal: mov eax, edi bswap eax ret now both generate the same optimal output. MSVC used to generate the following with the old code: mov eax, ecx rol cx, 8 shr eax, 16 rol ax, 8 movzx ecx, cx movzx eax, ax shl ecx, 16 or eax, ecx ret 0 Now MSVC also generates a similar, but equally optimal result as clang/GCC: bswap ecx mov eax, ecx ret 0 ==== In the swap64 case, for the original code, clang 8.0 would generate: mov eax, edi bswap eax shl rax, 32 shr rdi, 32 bswap edi or rax, rdi ret (almost there, but still missing the mark) while, again, GCC 8.3 would generate the more ideal: mov rax, rdi bswap rax ret now clang also generates the optimal sequence for this fallback as well. This is a case where MSVC unfortunately falls short, despite the new code, this one still generates a doozy of an output. mov r8, rcx mov r9, rcx mov rax, 71776119061217280 mov rdx, r8 and r9, rax and edx, 65280 mov rax, rcx shr rax, 16 or r9, rax mov rax, rcx shr r9, 16 mov rcx, 280375465082880 and rax, rcx mov rcx, 1095216660480 or r9, rax mov rax, r8 and rax, rcx shr r9, 16 or r9, rax mov rcx, r8 mov rax, r8 shr r9, 8 shl rax, 16 and ecx, 16711680 or rdx, rax mov eax, -16777216 and rax, r8 shl rdx, 16 or rdx, rcx shl rdx, 16 or rax, rdx shl rax, 8 or rax, r9 ret 0 which is pretty unfortunate.
2019-04-12core/core: Move process execution start to System's Load()Lioncash20-107/+144
This gives us significantly more control over where in the initialization process we start execution of the main process. Previously we were running the main process before the CPU or GPU threads were initialized (not good). This amends execution to start after all of our threads are properly set up.
2019-04-12core/process: Remove unideal page table setting from LoadFromMetadata()Lioncash1-5/+0
Initially required due to the split codepath with how the initial main process instance was initialized. We used to initialize the process like: Init() { main_process = Process::Create(...); kernel.MakeCurrentProcess(main_process.get()); } Load() { const auto load_result = loader.Load(*kernel.GetCurrentProcess()); if (load_result != Loader::ResultStatus::Success) { // Handle error here. } ... } which presented a problem. Setting a created process as the main process would set the page table for that process as the main page table. This is fine... until we get to the part that the page table can have its size changed in the Load() function via NPDM metadata, which can dictate either a 32-bit, 36-bit, or 39-bit usable address space. Now that we have full control over the process' creation in load, we can simply set the initial process as the main process after all the loading is done, reflecting the potential page table changes without any special-casing behavior. We can also remove the cache flushing within LoadModule(), as execution wouldn't have even begun yet during all usages of this function, now that we have the initialization order cleaned up.
2019-04-12core/core: Move main process creation into Load()Lioncash1-4/+3
Now that we have dependencies on the initialization order, we can move the creation of the main process to a more sensible area: where we actually load in the executable data. This allows localizing the creation and loading of the process in one location, making the initialization of the process much nicer to trace.
2019-04-12video_core/gpu: Create threads separately from initializationLioncash10-25/+51
Like with CPU emulation, we generally don't want to fire off the threads immediately after the relevant classes are initialized, we want to do this after all necessary data is done loading first. This splits the thread creation into its own interface member function to allow controlling when these threads in particular get created.
2019-04-12core/cpu_core_manager: Create threads separately from initialization.Lioncash11-39/+58
Our initialization process is a little wonky than one would expect when it comes to code flow. We initialize the CPU last, as opposed to hardware, where the CPU obviously needs to be first, otherwise nothing else would work, and we have code that adds checks to get around this. For example, in the page table setting code, we check to see if the system is turned on before we even notify the CPU instances of a page table switch. This results in dead code (at the moment), because the only time a page table switch will occur is when the system is *not* running, preventing the emulated CPU instances from being notified of a page table switch in a convenient manner (technically the code path could be taken, but we don't emulate the process creation svc handlers yet). This moves the threads creation into its own member function of the core manager and restores a little order (and predictability) to our initialization process. Previously, in the multi-threaded cases, we'd kick off several threads before even the main kernel process was created and ready to execute (gross!). Now the initialization process is like so: Initialization: 1. Timers 2. CPU 3. Kernel 4. Filesystem stuff (kind of gross, but can be amended trivially) 5. Applet stuff (ditto in terms of being kind of gross) 6. Main process (will be moved into the loading step in a following change) 7. Telemetry (this should be initialized last in the future). 8. Services (4 and 5 should ideally be alongside this). 9. GDB (gross. Uses namespace scope state. Needs to be refactored into a class or booted altogether). 10. Renderer 11. GPU (will also have its threads created in a separate step in a following change). Which... isn't *ideal* per-se, however getting rid of the wonky intertwining of CPU state initialization out of this mix gets rid of most of the footguns when it comes to our initialization process.
2019-04-12common/swap: Mark byte swapping free functions with [[nodiscard]] and noexceptLioncash1-11/+11
Allows the compiler to inform when the result of a swap function is being ignored (which is 100% a bug in all usage scenarios). We also mark them noexcept to allow other functions using them to be able to be marked as noexcept and play nicely with things that potentially inspect "nothrowability".
2019-04-12common/swap: Simplify swap function ifdefsLioncash1-48/+15
Including every OS' own built-in byte swapping functions is kind of undesirable, since it adds yet another build path to ensure compilation succeeds on. Given we only support clang, GCC, and MSVC for the time being, we can utilize their built-in functions directly instead of going through the OS's API functions. This shrinks the overall code down to just if (msvc) use msvc's functions else if (clang or gcc) use clang/gcc's builtins else use the slow path
2019-04-12common/swap: Remove 32-bit ARM pathLioncash1-13/+0
We don't plan to support host 32-bit ARM execution environments, so this is essentially dead code.
2019-04-12common/scope_exit: Replace std::move with std::forward in ScopeExit()Lioncash1-1/+1
The template type here is actually a forwarding reference, not an rvalue reference in this case, so it's more appropriate to use std::forward to preserve the value category of the type being moved.
2019-04-11kernel: Make handle type declarations constexprLioncash10-10/+10
Some objects declare their handle type as const, while others declare it as constexpr. This makes the const ones constexpr for consistency, and prevent unexpected compilation errors if these happen to be attempted to be used within a constexpr context.
2019-04-11ui_settings: Rename game directory variablesFreddyFunk5-20/+20
2019-04-11gl_rasterizer_cache: Relax restrictions on FastCopySurface and FastLayeredCopySurfaceFernando Sahmkow1-4/+10
2019-04-11service: Update service function tablesLioncash27-57/+262
Updates function tables based off information from SwitchBrew.
2019-04-11gl_shader_manager: Move code to source file and minor clean upReinUsesLisp2-34/+61
2019-04-10gl_rasterizer: Apply just the needed state on ClearReinUsesLisp1-4/+4
2019-04-10ldr: Mark IsValidNROHash() as a const member functionLioncash1-5/+4
This doesn't modify instance state, so it can be made const.
2019-04-10ldr: Amend parameters for LoadNro/UnloadNro LoadNrr/UnloadNrrLioncash1-60/+81
The initial two words indicate a process ID. Also UnloadNro only specifies one address, not two.
2019-04-10gl_device: Implement interface and add uniform offset alignmentReinUsesLisp5-13/+70
2019-04-10vk_shader_decompiler: Implement flow primitivesReinUsesLisp1-5/+82
2019-04-10vk_shader_decompiler: Implement most common texture primitivesReinUsesLisp1-8/+65
2019-04-10vk_shader_decompiler: Implement texture decompilation helper functionsReinUsesLisp1-0/+32
2019-04-10vk_shader_decompiler: Implement Assign and LogicalAssignReinUsesLisp1-2/+64
2019-04-10vk_shader_decompiler: Implement non-OperationCode visitsReinUsesLisp1-7/+129
2019-04-10vk_shader_decompiler: Implement OperationCode decompilation interfaceReinUsesLisp1-1/+411
2019-04-10vk_shader_decompiler: Implement VisitReinUsesLisp1-1/+50
2019-04-10vk_shader_decompiler: Implement labels tree and flowReinUsesLisp1-0/+71
2019-04-10vk_shader_decompiler: Implement declarationsReinUsesLisp1-3/+457
2019-04-10vk_shader_decompiler: Declare and stub interface for a SPIR-V decompilerReinUsesLisp3-0/+127
2019-04-10video_core: Add sirit as optional dependency with VulkanReinUsesLisp1-1/+4
sirit is a runtime assembler for SPIR-V
2019-04-10fsp_srv: Remove unnecessary parameter popping in IDirectory's Read()Lioncash1-4/+1
IDirectory's Read() function doesn't take any input parameters. It only uses the output parameters that we already provide.
2019-04-10fsp_srv: Log out option values in IFile's Read and Write functionsLioncash1-4/+6
These indicate options that alter how a read/write is performed. Currently we don't need to handle these, as the only one that seems to be used is for writes, but all the custom options ever seem to do is immediate flushing, which we already do by default.
2019-04-10kernel/server_session: Remove obsolete TODOsLioncash1-7/+2
These are holdovers from Citra.
2019-04-10configure_hotkeys: Pass the dialog as a parent to SequenceDialog()Lioncash1-1/+1
Without passing in a parent, this can result in focus being stolen from the dialog in certain cases. Example: On Windows, if the logging window is left open, the logging Window will potentially get focus over the hotkey dialog itself, since it brings all open windows for the application into view. By specifying a parent, we only bring windows for the parent into view (of which there are none, aside from the hotkey dialog).
2019-04-10configure_hotkeys: Avoid dialog memory leak within Configure()Lioncash1-3/+3
Without a parent, this dialog won't have its memory freed when it happens to get destroyed.
2019-04-10Remove bounding in LD_CFernando Sahmkow1-2/+1
2019-04-10configure_hotkeys: Mark member variables as const where applicable in Configure()Lioncash1-7/+7
2019-04-10configure_hotkeys: Make comparison check a little more self-documentingLioncash1-1/+2
This is checking if an index is valid or not and returning early if it isn't.
2019-04-10configure_dialog: Amend constructor initializer list orderLioncash1-1/+1
Avoids a -Wreorder compiler warning.
2019-04-10configure_hotkey: Remove unnecessary includeLioncash1-1/+0
Avoids dumping all of the core settings machinery into whatever files include this header. Nothing inside the header itself actually made use of anything in settings.h anyways.
2019-04-10configure_hotkey: Make IsUsedKey() a const member functionLioncash2-2/+2
This doesn't actually modify instance state of the dialog, so this can be made const.
2019-04-09Correct Fermi Copy on Linear Textures.Fernando Sahmkow1-0/+4
2019-04-09kernel/process: Set page table when page table resizes occur.Lioncash1-0/+2
We need to ensure dynarmic gets a valid pointer if the page table is resized (the relevant pointers would be invalidated in this scenario). In this scenario, the page table can be resized depending on what kind of address space is specified within the NPDM metadata (if it's present).
2019-04-09Implement Texture Format ZF32_X24S8.Fernando Sahmkow1-0/+2
2019-04-09Correct depth compare with color formats for R32FFernando Sahmkow1-2/+17
2019-04-09yuzu/loading_screen: Resolve runtime Qt string formatting warningsLioncash1-1/+6
In our error console, when loading a game, the strings: QString::arg: Argument missing: "Loading...", 0 QString::arg: Argument missing: "Launching...", 0 would occasionally pop up when the loading screen was running. This was due to the strings being assumed to have formatting indicators in them, however only two out of the four strings actually have them. This only applies the arguments to the strings that have formatting specifiers provided, which avoids these warnings from occurring.
2019-04-09added a toggle to force 30fps modezarroboogs5-6/+23
2019-04-08gl_backend: Align Pixel StorageFernando Sahmkow2-4/+12
This commit makes sure GL reads on the correct pack size for the respective texture buffer.
2019-04-08Correct LOP_IMN encodingFernando Sahmkow1-1/+1
2019-04-08Correct XMAD mode, psl and high_b on different encodings.Fernando Sahmkow2-9/+33
2019-04-08Adapt Bindless to work with AOFFIFernando Sahmkow1-7/+18
2019-04-08Move ConstBufferAccessor to Maxwell3d, correct mistakes and clang format.Fernando Sahmkow9-44/+25
2019-04-08Fix bad rebaseFernando Sahmkow1-2/+1
2019-04-08Fix TMMLFernando Sahmkow1-5/+7
2019-04-08Simplify ConstBufferAccessorFernando Sahmkow5-53/+22
2019-04-08Refactor GetTextureCode and GetTexCode to use an optional instead of optional parametersFernando Sahmkow2-34/+33
2019-04-08Implement TXQ_BFernando Sahmkow2-2/+10
2019-04-08Implement TMML_BFernando Sahmkow1-5/+10
2019-04-08Corrections to TEX_BFernando Sahmkow2-4/+37
2019-04-08Fixes to Const Buffer Accessor and FormattingFernando Sahmkow3-10/+10
2019-04-08Implement Bindless Handling on SetupTextureFernando Sahmkow4-18/+34
2019-04-08Unify both sampler types.Fernando Sahmkow4-22/+48
2019-04-08Implement Bindless Samplers and TEX_B in the IR.Fernando Sahmkow4-16/+77
2019-04-08Implement Const Buffer AccessorFernando Sahmkow5-2/+65
2019-04-08kernel/svc: Deglobalize the supervisor call handlersLioncash8-364/+413
Adjusts the interface of the wrappers to take a system reference, which allows accessing a system instance without using the global accessors. This also allows getting rid of all global accessors within the supervisor call handling code. While this does make the wrappers themselves slightly more noisy, this will be further cleaned up in a follow-up. This eliminates the global system accessors in the current code while preserving the existing interface.
2019-04-07Permit a Null Shader in case of a bad host_ptr.Fernando Sahmkow2-0/+22
2019-04-07core/memory: Remove unused enum constantsLioncash1-10/+0
These are holdovers from Citra and can be removed.
2019-04-07core/memory: Remove GetCurrentPageTable()Lioncash2-6/+1
Now that nothing actually touches the internal page table aside from the memory subsystem itself, we can remove the accessor to it.
2019-04-07arm/arm_dynarmic: Remove unnecessary current_page_table memberLioncash2-8/+0
Given the page table will always be guaranteed to be that of whatever the current process is, we no longer need to keep this around.
2019-04-07kernel: Handle page table switching within MakeCurrentProcess()Lioncash4-6/+3
Centralizes the page table switching to one spot, rather than making calling code deal with it everywhere.
2019-04-06kernel/server_session: Return a std::pair from CreateSessionPair()Lioncash4-11/+8
Keeps the return type consistent with the function name. While we're at it, we can also reduce the amount of boilerplate involved with handling these by using structured bindings.
2019-04-06kernel/server_port: Return a std::pair from CreatePortPair()Lioncash2-7/+7
Returns the same type that the function name describes.
2019-04-06maxwell_3d: Reduce severity of ProcessSyncPointReinUsesLisp1-2/+2
2019-04-06video_core/textures/convert: Replace include with a forward declarationLioncash2-1/+5
Avoids dragging in a direct dependency in a header.
2019-04-06video_core/texures/texture: Remove unnecessary includesLioncash6-2/+5
Nothing in this header relies on common_funcs or the memory manager. This gets rid of reliance on indirect inclusions in the OpenGL caches.
2019-04-06yuzu/debugger: Remove graphics surface viewerLioncash5-622/+0
This doesn't actually work anymore, and given how long it's been left in that state, it's unlikely anyone actually seriously used it. Generally it's preferable to use RenderDoc or Nsight to view surfaces.
2019-04-06memory_manager: Improved implementation of read/write/copy block.bunnei3-12/+84
- Fixes graphical issues with Chocobo's Mystery Dungeon EVERY BUDDY! - Fixes a crash with Mario Tennis Aces
2019-04-06video_core/macro_interpreter: Remove assertion within FetchParameter()Lioncash1-2/+1
We can just use .at(), which essentially does the same thing, but with less code.
2019-04-06video_core/macro_interpreter: Simplify GetRegister()Lioncash1-11/+6
Given we already ensure nothing can set the zeroth register in SetRegister(), we don't need to check if the index is zero and special case it. We can just access the register normally, since it's already going to be zero. We can also replace the assertion with .at() to perform the equivalent behavior inline as part of the API.
2019-04-06video_core/memory_manager: Make Read() a const qualified member functionLioncash2-6/+6
Given this doesn't actually alter internal state, this can be made a const member function.
2019-04-06video_core/memory_manager: Make ReadBlock() a const qualifier member functionLioncash2-2/+2
Now, since we have a const qualified variant of GetPointer(), we can put it to use in ReadBlock() to retrieve the source pointer that is passed into memcpy. Now block reading may be done from a const context.
2019-04-06video_core/memory_manager: Add a const qualified variant of GetPointer()Lioncash2-2/+17
Allows retrieving read-only pointers from a const context externally.
2019-04-06video_core/memory_manager: Make FindFreeRegion() a const member functionLioncash2-10/+11
This doesn't modify internal state, so it can be made a const member function.
2019-04-06video_core/memory_manager: Make GpuToCpuAddress() a const member functionLioncash2-3/+3
This doesn't modify any internal state, so it can be made a const member function to allow its use in const contexts.
2019-04-06yuzu/debugger/graphics_surface: Display error messages for file I/O errorsLioncash1-7/+25
2019-04-06yuzu/debugger/graphics_surface: Tidy up SaveSurfaceLioncash1-15/+14
- Use QStringLiteral where applicable. - Use const where applicable - Remove unnecessary precondition check (we already assert the pixbuf being non null)
2019-04-06yuzu/debugger/graphics_surface: Clean up connection overload deductionLioncash1-12/+10
We can utilize qOverload with the signal connections to make the function deducing a little less ugly.
2019-04-06Implement SyncPoint Register in the GPU.Fernando Sahmkow2-1/+27
2019-04-06yuzu/debugger/graphics_surface: Fill in missing surface format listingsLioncash1-43/+84
Fills in the missing surface types that were marked as unknown. The order corresponds with the TextureFormat enum within video_core/texture.h. We also don't need to all of these strings as translatable (only the first string, as it's an English word).
2019-04-06video_core/gpu_thread: Silence truncation warning in ThreadManager's constructorLioncash1-1/+1
Since c5d41fd812d7eb1a04f36b76c08fe971cee0868c callback parameters were changed to use an s64 to represent late cycles instead of an int, so this was causing a truncation warning to occur here. Changing it to s64 is sufficient to silence the warning.
2019-04-06video_core/engines: Make memory manager members privateLioncash9-13/+14
These aren't used externally by anything, so they can be made private data members.
2019-04-06video_core/engines: Remove unnecessary inclusions where applicableLioncash10-9/+25
Replaces header inclusions with forward declarations where applicable and also removes unused headers within the cpp file. This reduces a few more dependencies on core/memory.h
2019-04-06renderer_opengl/utils: Skip empty bindsReinUsesLisp1-0/+3
2019-04-06gl_rasterizer: Use ARB_multi_bind to update SSBOsReinUsesLisp2-9/+9
2019-04-06gl_rasterizer: Use ARB_multi_bind to update UBOs across stagesReinUsesLisp4-22/+58
2019-04-05hle/result: Remove unnecessary bitfield entry for ResultCodeLioncash1-4/+0
This is a hold over from the 3DS error codes in Citra.
2019-04-05file_sys/program_metadata: Remove obsolete TODOsLioncash2-15/+14
BitField has been trivially copyable since e99a14862841841d74be8d0ea9426c2d23546b5e, so we can eliminate these TODO comments and use ReadObject() directly instead of memcpying the data.
2019-04-05common/multi_level_queue: Silence truncation warning in iterator operator++Lioncash1-1/+1
2019-04-05common/bit_util: Make CountLeading/CountTrailing functions have the same return typesLioncash1-8/+8
Makes the return type consistently uniform (like the intrinsics we're wrapping). This also conveniently silences a truncation warning within the kernel multi_level_queue.
2019-04-05file_sys/nca_metadata: Remove unnecessary comparison operators for TitleTypeLioncash2-11/+0
enum class elements from the same enum can already be compared against one another without the need for explicitly defined comparison operators.
2019-04-05file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash()Lioncash1-1/+3
The given string instance doesn't need to be copied entirely, we can just use a view instead.
2019-04-05service/fsp_srv: Don't pass SaveDataDescriptor instances by value.Lioncash4-6/+6
Passing around a 64 byte data struct by value is kind of wasteful, instead pass a reference to the struct.
2019-04-05service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystemLioncash1-7/+8
The unknown member here is actually padding due to being passed as a struct. We can do the same, and remove the need to pop a padding word.
2019-04-05service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structsLioncash3-4/+15
I realized that I updated the documentation on SwitchBrew a while ago, but never actually updated the structs within yuzu.
2019-04-05filesystem: Use a std::string_view in OpenFile()Lioncash1-5/+8
Rather than make a full copy of the path, we can just use a string view and truncate the viewed portion of the string instead of creating a totally new truncated string.
2019-04-05gl_shader_decompiler: Rename GenerateTemporal() to GenerateTemporary()Lioncash1-12/+12
Temporal generally indicates a relation to time, but this is just creating a temporary, so this isn't really an accurate name for what the function is actually doing.
2019-04-05gl_shader_decompiler: Fix TXQ typesReinUsesLisp1-2/+3
TXQ returns integer types. Shaders usually do: R0 = TXQ(); // => int R0 = static_cast<float>(R0); If we don't treat it as an integer, it will cast a binary float value as float - resulting in a corrupted number.
2019-04-04hle/service: Resolve unused variable warningsLioncash8-62/+58
In several places, we have request parsers where there's nothing to really parse, simply because the HLE function in question operates on buffers. In these cases we can just remove these instances altogether. In the other cases, we can retrieve the relevant members from the parser and at least log them out, giving them some use.
2019-04-04core: Add missing override specifiers where applicableLioncash13-23/+9
Applies the override specifier where applicable. In the case of destructors that are defaulted in their definition, they can simply be removed. This also removes the unnecessary inclusions being done in audin_u and audrec_u, given their close proximity.
2019-04-04video_core/renderer_opengl: Remove unnecessary includesLioncash13-24/+4
Quite a few unused includes have built up over time, particularly on core/memory.h. Removing these includes means the source files including those files will no longer need to be rebuilt if they're changed, making compilation slightly faster in this scenario.
2019-04-04yuzu/main: Remove unnecessary includesLioncash1-5/+8
While we're at it, don't use <QtGui> and <QtWidgets> and instead include exactly which headers we actually need.
2019-04-04yuzu/main: Use QStringLiteral where applicable within OnTransferableShaderCacheOpenFile()Lioncash1-2/+2
Allows these strings to have no allocation cost when used at runtime.
2019-04-04yuzu/main: Tidy up the error dialog string in OnTransferableShaderCacheOpenFile()Lioncash1-3/+2
Rather than scream that the file doesn't exist, we can clearly state what specifically doesn't exist, to avoid ambiguity, and make it easier to understand for non-primary English speakers/readers.
2019-04-04yuzu/main: Remove unnecessary string concatenation in OnTransferableShaderCacheOpenFile()Lioncash1-1/+1
We can just make the trailing portion of the string part of the formatting, getting rid of the need to make another temporary string.
2019-04-04yuzu/main: Make open_target a QStringLioncash1-4/+2
Simplifies the amount of string conversions necessary. We also don't need to log out what occurs here.
2019-04-04yuzu/main: Use static variant of QFile's exists()Lioncash1-1/+1
There's no need to construct a QFile instance just to check for its existence.
2019-04-04common/lz4_compression: Remove #pragma once directive from the cpp fileLioncash1-2/+0
Introduced within 798d76f4c7018174e58702fb06a042dc8c84f0be, this only really has an effect within header files. Silences a -Wpragma-once-outside-header warning with clang.
2019-04-04file_sys/control_metadata: Amend naming of membersLioncash2-12/+24
Quite a bit of these were out of sync with Switchbrew (and in some cases entirely wrong). While we're at it, also expand the section of named members. A segment within the control metadata is used to specify maximum values for the user, device, and cache storage max sizes and journal sizes. These appear to be generally used by the am service (e.g. in CreateCacheStorage, etc).
2019-04-04kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomicLioncash1-0/+14
We need to be checking whether or not the given address is within the kernel address space or if the given address isn't word-aligned and bail in these scenarios instead of trashing any kernel state.
2019-04-04gl_state: Rework to enable individual appliesReinUsesLisp3-339/+324
2019-04-03service/am: Correct behavior of CreateTransferMemoryStorage()Lioncash1-6/+6
For whatever reason, shared memory was being used here instead of transfer memory, which (quite clearly) will not work based off the name of the function. This corrects this wonky usage of shared memory.
2019-04-03kernel/transfer_memory: Add accessors to data and sizesLioncash2-11/+31
Also amend erroneous use of size_t. We should be using u64 here.
2019-04-03shader_ir/memory: Reduce severity of LD_L cache management and log itReinUsesLisp2-2/+9
2019-04-03shader_ir/memory: Reduce severity of ST_L cache management and log itReinUsesLisp2-3/+11
2019-04-03gl_shader_decompiler: Return early when an operation is invalidReinUsesLisp1-1/+6
2019-04-03yuzu/applets/software_keyboard: Use QDialogButtonBox standard buttons instead of custom buttonsLioncash1-7/+7
Like the previous change, this allows Qt to handle proper translations of the UI buttons, rather than us needing to handle it.
2019-04-03yuzu/applets/profile_select: Use QDialogButtonBox standard buttons instead of custom buttonsLioncash1-4/+1
Makes for shorter code, while also not requiring the buttons to be directly translated, they'll be handled by Qt itself.
2019-04-03kernel/server_session: Provide a GetName() overrideLioncash1-0/+4
Given server sessions can be given a name, we should allow retrieving it instead of using the default implementation of GetName(), which would just return "[UNKNOWN KERNEL OBJECT]".
2019-04-03kernel/object: Remove unused handle type entryLioncash2-2/+0
The AddressArbiter type isn't actually used, given the arbiter itself isn't a direct kernel object (or object that implements the wait object facilities). Given this, we can remove the enum entry entirely.
2019-04-03yuzu/debugger/profiler: Remove unnecessary includesLioncash2-4/+6
Moves includes into the cpp file where necessary. This way, microprofile-related stuff isn't dumped into other UI-related code when the dialog header gets included.
2019-04-02gl_sampler_cache: Port sampler cache to OpenGLReinUsesLisp5-123/+82
2019-04-02video_core: Abstract vk_sampler_cache into a templated classReinUsesLisp5-58/+101
2019-04-02kernel/svc: Implement svcGetThreadListLioncash4-1/+70
Similarly like svcGetProcessList, this retrieves the list of threads from the current process. In the kernel itself, a process instance maintains a list of threads, which are used within this function. Threads are registered to a process' thread list at thread initialization, and unregistered from the list upon thread destruction (if said thread has a non-null owning process). We assert on the debug event case, as we currently don't implement kernel debug objects.
2019-04-02kernel/svc: Implement svcGetProcessListLioncash4-1/+53
This service function simply copies out a specified number of kernel process IDs, while simultaneously reporting the total number of processes.
2019-04-02process: Fix up compilationReinUsesLisp1-1/+1
2019-04-02gpu_thread: Improve synchronization by using CoreTiming.bunnei3-51/+65
2019-04-02kernel/thread: Make AllWaitObjectsReady() a const qualified member functionLioncash2-2/+2
Now that ShouldWait() is a const qualified member function, this one can be made const qualified as well, since it can handle passing a const qualified this pointer to ShouldWait().
2019-04-02kernel/wait_object: Make ShouldWait() take thread members by pointer-to-constLioncash11-11/+11
Given this is intended as a querying function, it doesn't make sense to allow the implementer to modify the state of the given thread.
2019-04-01kernel/thread: Avoid sign conversion within GetCommandBufferAddress()Lioncash1-2/+2
Previously this was performing a u64 + int sign conversion. When dealing with addresses, we should generally be keeping the arithmetic in the same signedness type. This also gets rid of the static lifetime of the constant, as there's no need to make a trivial type like this potentially live for the entire duration of the program.
2019-04-01kernel/thread: Make parameter of GetWaitObjectIndex() const qualifiedLioncash2-3/+3
The pointed to member is never actually modified, so it can be made const.
2019-04-01kernel/resource_limit: Remove the name member from resource limitsLioncash3-14/+6
This doesn't really provide any benefit to the resource limit interface. There's no way for callers to any of the service functions for resource limits to provide a custom name, so all created instances of resource limits other than the system resource limit would have a name of "Unknown". The system resource limit itself is already trivially identifiable from its limit values, so there's no real need to take up space in the object to identify one object meaningfully out of N total objects.
2019-04-01general: Use deducation guides for std::lock_guard and std::unique_lockLioncash23-75/+77
Since C++17, the introduction of deduction guides for locking facilities means that we no longer need to hardcode the mutex type into the locks themselves, making it easier to switch mutex types, should it ever be necessary in the future.
2019-03-31gl_shader_decompiler: Hide local definitions inside an anonymous namespaceReinUsesLisp1-6/+8
2019-03-31shader_ir/decode: Silent implicit sign conversion warningMat M1-2/+2
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-03-30kernel/scheduler: Remove unused parameter to AddThread()Lioncash3-4/+4
This was made unused in b404fcdf1443b91ac9994c05ad1fe039fcd9675e, but the parameter itself wasn't removed.
2019-03-30kernel/scheduler: Use deduction guides on mutex locksLioncash1-8/+8
Since C++17, we no longer need to explicitly specify the type of the mutex within the lock_guard. The type system can now deduce these with deduction guides.
2019-03-30service/fatal: Mark local variables as const where applicableLioncash1-6/+6
2019-03-30service/fatal: Remove unnecessary semicolonLioncash1-1/+1
Resolves a -Wextra-semi warning.
2019-03-30service/fatal: Name FatalInfo structure membersLioncash1-31/+44
Based off RE, most of these structure members are register values, which makes, sense given this service is used to convey fatal errors. One member indicates the program entry point address, one is a set of bit flags used to determine which registers to print, and one member indicates the architecture type. The only member that still isn't determined is the final member within the data structure.
2019-03-30gl_shader_decompiler: Add AOFFI backing implementationReinUsesLisp1-38/+85
2019-03-30shader_ir/decode: Implement AOFFI for TEX and TLD4ReinUsesLisp2-27/+94
2019-03-30shader_ir: Implement immediate register trackingReinUsesLisp2-1/+19
2019-03-29kernel/shared_memory: Remove unused core/memory.h includeLioncash1-1/+0
Nothing from this header is used, so we can remove this include, getting rid of a dependency on it.
2019-03-29kernel/shared_memory: Sanitize supplied size when unmappingLioncash3-4/+18
The kernel makes sure that the given size to unmap is always the same size as the entire region managed by the shared memory instance, otherwise it returns an error code signifying an invalid size. This is similarly done for transfer memory (which we already check for).
2019-03-29common/thread: Remove unused functionsLioncash2-41/+0
Many of these functions are carried over from Dolphin (where they aren't used anymore). Given these have no use (and we really shouldn't be screwing around with OS-specific thread scheduler handling from the emulator, these can be removed. The function for setting the thread name is left, however, since it can have debugging utility usages.
2019-03-29common/zstd_compression: simplify decompression interfaceunknown3-13/+11
2019-03-29gl_shader_disk_cache: Fixup clang formatunknown1-2/+3
2019-03-29gl_shader_disk_cache: Use Zstandard for compressionunknown1-6/+6
2019-03-29common/zstd_compression: Add Zstandard wrapperunknown3-0/+98
2019-03-29common: Link libzstd_staticunknown1-1/+1
2019-03-29Addressed feedbackunknown1-1/+0
2019-03-29core: Do not link LZ4 to core. Use common/data_compression for nso segment decompression instead.unknown1-0/+1
2019-03-29gl_shader_disk_cache: Use LZ4HC with compression level 9 instead of compression level 12 for less compression timeunknown1-3/+3
2019-03-29Addressed feedbackunknown7-91/+145
2019-03-29core: Do not link LZ4 to core. Use common/data_compression for nso segment decompression instead.unknown2-11/+8
2019-03-29gl_shader_disk_cache: Use better compression for transferable and precompiled shader disk chache filesunknown3-10/+26
2019-03-29data_compression: Move LZ4 compression from video_core/gl_shader_disk_cache to common/data_compressionunknown5-39/+75
2019-03-29core/yuzu: Remove enable_nfc settingfearlessTobi7-28/+1
This was initially added to prevent problems from stubbed/not implemented NFC services, but as we never encountered such and as it's only used in a deprecated function anyway, I guess we can just remove it to prevent more clutter of the settings.
2019-03-29vk_swapchain: Implement a swapchain managerReinUsesLisp3-1/+305
2019-03-29kernel/process: Report total physical memory used to svcGetInfoLioncash3-4/+11
Reports the (mostly) correct size through svcGetInfo now for queries to total used physical memory. This still doesn't correctly handle memory allocated via svcMapPhysicalMemory, however, we don't currently handle that case anyways.
2019-03-29kernel/process: Store the total size of the code memory loadedLioncash2-0/+5
This will be necessary to properly report the used memory size in svcGetInfo.
2019-03-28kernel/process: Store the main thread stack size to a data memberLioncash2-4/+7
This will be necessary in order to properly report memory usage within svcGetInfo.
2019-03-28kernel/process: Make Run's stack size parameter a u64Lioncash2-2/+2
This will make operating with the process-related SVC commands much nicer in the future (the parameter representing the stack size in svcStartProcess is a 64-bit value).
2019-03-28kernel/process: Ensure that given stack size is always page-alignedLioncash1-0/+4
The kernel always makes sure that the given stack size is aligned to page boundaries.
2019-03-28gl_shader_manager: Remove unnecessary gl_shader_manager inclusionLioncash1-2/+0
This isn't used at all in the OpenGL shader cache, so we can remove it's include here, meaning one less file needs to be recompiled if any changes ever occur within that header. core/memory.h is also not used within this file at all, so we can remove it as well.
2019-03-28gl_shader_manager: Move using statement into the cpp fileLioncash2-4/+4
Avoids introducing Maxwell3D into the namespace for everything that includes the header.
2019-03-28gl_shader_manager: Remove reliance on global accessor within MaxwellUniformData::SetFromRegs()Lioncash3-9/+9
We can just pass in the Maxwell3D instance instead of going through the system class to get at it. This also lets us simplify the interface a little bit. Since we pass in the Maxwell3D context now, we only really need to pass the shader stage index value in.
2019-03-28patch_manager: Dump NSO name with build IDZach Hilman4-9/+11
2019-03-27Fixes and corrections on formatting.Fernando Sahmkow5-41/+30
2019-03-27Fixes to multilevelqueue's iterator.Fernando Sahmkow1-1/+5
2019-03-27Use MultiLevelQueue instead of old ThreadQueueListFernando Sahmkow3-31/+34
2019-03-27Add MultiLevelQueue TestsFernando Sahmkow2-0/+56
2019-03-27Implement intrinsics CountTrailingZeroes and test it.Fernando Sahmkow3-12/+76
2019-03-27Implement a MultiLevelQueueFernando Sahmkow3-0/+349
2019-03-27gl_shader_manager: Amend Doxygen string for MaxwellUniformDataLioncash1-3/+3
Previously only one line of the whole comment was in proper Doxygen formatting.
2019-03-27gpu_thread: Remove unused dma_pusher class member variable from ThreadManagerLioncash2-5/+2
The pusher instance is only ever used in the constructor of the ThreadManager for creating the thread that the ThreadManager instance contains. Aside from that, the member is unused, so it can be removed.
2019-03-27gl_rasterizer: Remove unused reference member variable from RasterizerOpenGLLioncash3-9/+5
This member variable is no longer being used, so it can be removed, removing a dependency on EmuWindow from the rasterizer's interface"
2019-03-27video_core: Amend constructor initializer list order where applicableLioncash6-14/+14
Specifies the members in the same order that initialization would take place in. This also silences -Wreorder warnings.
2019-03-27video_core: Add missing override specifiersLioncash3-4/+4
Ensures that the signatures will always match with the base class. Also silences a few compilation warnings.
2019-03-27video_core/gpu: Amend typo in GPU member variable nameLioncash2-7/+8
smaphore -> semaphore
2019-03-27game_list: Register content with ContentProviderZach Hilman8-91/+102
2019-03-27core: Port current uses of RegisteredCache to ContentProviderZach Hilman8-27/+32
2019-03-27core: Store system-wide ContentProvider for the emulatorZach Hilman2-0/+40
2019-03-27file_sys: Create ContentProvider interface and default implementationsZach Hilman2-152/+279
2019-03-26service/am: Implement EnterFatalSection and LeaveFatalSectionLioncash2-2/+29
These functions act in tandem similar to how a lock or mutex require a balanced lock()/unlock() sequence. EnterFatalSection simply increments a counter for how many times it has been called, while LeaveFatalSection ensures that a previous call to EnterFatalSection has occured. If a previous call has occurred (the counter is not zero), then the counter gets decremented as one would expect. If a previous call has not occurred (the counter is zero), then an error code is returned.
2019-03-26service/am: Sort ISelfController's member functions according to table orderLioncash2-36/+36
Makes the declaration order of the handling functions consistent with the handler table itself.
2019-03-25bootmanager: Bypass input focus issuesReinUsesLisp4-55/+78
2019-03-25bootmanager: Bypass resizing issueReinUsesLisp1-7/+12
2019-03-25bootmanager: Delete container to avoid crash on game restartingReinUsesLisp2-14/+10
While we are at it, remove nullptr checks for deletion, since the C++ standard defines that delete does it by its own
2019-03-24core/cheat_engine: Make MemoryReadImpl and MemoryWriteImpl internally linkedLioncash1-0/+2
These don't need to be visible outside of the translation unit, so they can be enclosed within an anonymous namespace.
2019-03-24core/core_timing: Make callback parameters consistentLioncash7-12/+12
In some cases, our callbacks were using s64 as a parameter, and in other cases, they were using an int, which is inconsistent. To make all callbacks consistent, we can just use an s64 as the type for late cycles, given it gets rid of the need to cast internally. While we're at it, also resolve some signed/unsigned conversions that were occurring related to the callback registration.
2019-03-24kernel/kernel: Remove unnecessary forward declarationLioncash1-3/+0
This is no longer necessary, as ResultVal isn't used anywhere in the header.
2019-03-24kernel/process: Remove unused AddressMapping structLioncash1-8/+0
Another leftover from citra that's now no longer necessary.
2019-03-24kernel/vm_manager: Handle shrinking of the heap size within SetHeapSize()Lioncash2-24/+46
One behavior that we weren't handling properly in our heap allocation process was the ability for the heap to be shrunk down in size if a larger size was previously requested. This adds the basic behavior to do so and also gets rid of HeapFree, as it's no longer necessary now that we have allocations and deallocations going through the same API function. While we're at it, fully document the behavior that this function performs.
2019-03-24kernel/vm_manager: Rename HeapAllocate to SetHeapSizeLioncash3-4/+3
Makes it more obvious that this function is intending to stand in for the actual supervisor call itself, and not acting as a general heap allocation function. Also the following change will merge the freeing behavior of HeapFree into this function, so leaving it as HeapAllocate would be misleading.
2019-03-24kernel/vm_manager: Handle case of identical calls to HeapAllocateLioncash1-0/+5
In cases where HeapAllocate is called with the same size of the current heap, we can simply do nothing and return successfully. This avoids doing work where we otherwise don't have to. This is also what the kernel itself does in this scenario.
2019-03-24kernel/vm_manager: Remove unused class variablesLioncash1-3/+0
Over time these have fallen out of use due to refactoring, so these can be removed.
2019-03-24kernel/vm_manager: Remove unnecessary heap_used data memberLioncash3-13/+2
This isn't required anymore, as all the kernel ever queries is the size of the current heap, not the total usage of it.
2019-03-24kernel/vm_manager: Tidy up heap allocation codeLioncash3-27/+37
Another holdover from citra that can be tossed out is the notion of the heap needing to be allocated in different addresses. On the switch, the base address of the heap will always be managed by the memory allocator in the kernel, so this doesn't need to be specified in the function's interface itself. The heap on the switch is always allocated with read/write permissions, so we don't need to add specifying the memory permissions as part of the heap allocation itself either. This also corrects the error code returned from within the function. If the size of the heap is larger than the entire heap region, then the kernel will report an out of memory condition.
2019-03-22kernel/codeset: Make CodeSet's memory data member a regular std::vectorLioncash5-7/+8
The use of a shared_ptr is an implementation detail of the VMManager itself when mapping memory. Because of that, we shouldn't require all users of the CodeSet to have to allocate the shared_ptr ahead of time. It's intended that CodeSet simply pass in the required direct data, and that the memory manager takes care of it from that point on. This means we just do the shared pointer allocation in a single place, when loading modules, as opposed to in each loader.
2019-03-22loader/nso: Place translation unit specific functions into an anonymous namespaceLioncash1-20/+21
Makes it impossible to indirectly violate the ODR in some other translation unit due to these existing.
2019-03-22file_sys/cheat_engine: Silence truncation and sign-conversion warningsLioncash2-5/+6
2019-03-22file_sys/cheat_engine: Remove use of global system accessorsLioncash6-43/+51
Instead, pass in the core timing instance and make the dependency explicit in the interface.
2019-03-22loader/nso: Clean up use of magic constantsLioncash1-4/+6
Now that the NSO header has the proper size, we can just use sizeof on it instead of having magic constants.
2019-03-22file_sys/patch_manager: Deduplicate NSO headerLioncash3-64/+65
This source file was utilizing its own version of the NSO header. Instead of keeping this around, we can have the patch manager also use the version of the header that we have defined in loader/nso.h
2019-03-22loader/nso: Fix definition of the NSO header structLioncash1-3/+15
The total struct itself is 0x100 (256) bytes in size, so we should be providing that amount of data. Without the data, this can result in omitted data from the final loaded NSO file.
2019-03-22file_sys/patch_manager: Remove two magic valuesLioncash1-2/+5
These correspond to the NSOBuildHeader.
2019-03-22video_core: Implement API agnostic view based texture cacheReinUsesLisp3-0/+974
Implements an API agnostic texture view based texture cache. Classes defined here are intended to be inherited by the API implementation and used in API-specific code. This implementation exposes protected virtual functions to be called from the implementer. Before executing any surface copies methods (defined in API-specific code) it tries to detect if the overlapping surface is a superset and if it is, it creates a view. Views are references of a subset of a surface, it can be a superset view (the same as referencing the whole texture). Current code manages 1D, 1D array, 2D, 2D array, cube maps and cube map arrays with layer and mipmap level views. Texture 3D slices views are not implemented. If the view attempt fails, the fast path is invoked with the overlapping textures (defined in the implementer). If that one fails (returning nullptr) it will flush and reload the texture.
2019-03-22Revert "Devirtualize Register/Unregister and use a wrapper instead."bunnei3-8/+12
- Fixes graphical issues from transitions in Super Mario Odyssey.
2019-03-21service/am: Add function table for IDebugFunctionsLioncash1-1/+15
We already have the service related stuff set up for this, however, it's missing the function table.
2019-03-21kernel/vm_manager: Rename CodeStatic/CodeMutable to Code and CodeData respectivelyLioncash4-22/+20
Makes it more evident that one is for actual code and one is for actual data. Mutable and static are less than ideal terms here, because read-only data is technically not mutable, but we were mapping it with that label.
2019-03-21kernel/vm_manager: Amend flag values for CodeMutableLioncash1-1/+1
This should actually be using the data flags, rather than the code flags.
2019-03-21core/memory: Remove unnecessary includesLioncash1-3/+0
In 93da8e0abfcdcc6e3cb5488a0db12373429f1377, the page table construct was moved to the common library (which utilized these inclusions). Since the move, nothing requires these headers to be included within the memory header.
2019-03-21common/bit_util: Fix bad merge duplicating the copy constructorLioncash1-2/+0
Introduced as a result of #2090, we already define the copy constructor further down below, so this isn't needed.
2019-03-21memory_manager: Cleanup FindFreeRegion.bunnei2-12/+6
2019-03-21memory_manager: Use Common::AlignUp in public interface as needed.bunnei1-11/+22
2019-03-21common/uint128: Add missing header guardLioncash1-0/+2
2019-03-21common/uint128: Add missing top-file source textLioncash2-0/+7
2019-03-21memory_manager: Bug fixes and further cleanup.bunnei2-73/+72
2019-03-21memory: Check that core is powered on before attempting to use GPU.bunnei1-1/+1
- GPU will be released on shutdown, before pages are unmapped. - On subsequent runs, current_page_table will be not nullptr, but GPU might not be valid yet.
2019-03-21maxwell_dma: Check for valid source in destination before copy.bunnei1-0/+10
- Avoid a crash in Octopath Traveler.
2019-03-21memory_manager: Add protections for invalid GPU addresses.bunnei2-22/+43
- Avoid a crash in Xenoblade Chronicles 2.
2019-03-21gl_rasterizer_cache: Check that backing memory is valid before creating a surface.bunnei2-15/+12
- Fixes a crash in Puyo Puyo Tetris.
2019-03-21gpu: Rewrite virtual memory manager using PageTable.bunnei13-212/+481
2019-03-21gpu: Move GPUVAddr definition to common_types.bunnei17-39/+31
2019-03-21common/CMakeLists: Amend boost dependencyLioncash1-1/+1
When #2247 was created, thread_queue_list.h was the only user of boost-related code, however #2252 moved the page table struct into common, which makes use of Boost.ICL, so we need to add the dependency to the common library's link interface again.
2019-03-20kernel/process: Make MapSegment lambda reference parameter constLioncash1-1/+1
The segment itself isn't actually modified.
2019-03-20kernel: Move CodeSet structure to its own source filesLioncash8-44/+110
Given this is utilized by the loaders, this allows avoiding inclusion of the kernel process definitions where avoidable. This also keeps the loading format for all executable data separate from the kernel objects.
2019-03-20Fix crash caused by 2238.Fernando Sahmkow1-1/+2
2019-03-20Fix small bug that kept a thread as a condvar thread after being signalled.Fernando Sahmkow2-6/+8
2019-03-20loader: Remove Linker classLioncash3-185/+0
Given the class is now currently unused, it can be removed.
2019-03-20loader: Remove Linker inheritance from NRO and NSO loadersLioncash2-4/+4
Neither the NRO or NSO loaders actually make use of the functions or members provided by the Linker interface, so we can just remove the inheritance altogether.
2019-03-20Add CondVar Thread State.Fernando Sahmkow5-4/+10
2019-03-20Small fixes to address_arbiter to better match the IDB.Fernando Sahmkow2-5/+5
2019-03-19Fix getopt on systems where char is unsigned by defaultxperia641-2/+2
2019-03-19file_sys/content_archive: Amend name of Data_Unknown5 enum entryLioncash2-2/+15
While we're at it, give each entry some documentation.
2019-03-18input_common/sdl: Correct return values within implementations of GetPollers()Lioncash2-2/+6
In both cases, we weren't actually returning anything, which is undefined behavior.
2019-03-18input_common/sdl: Use a type alias to shorten declaration of GetPollersLioncash3-11/+9
Just makes the definitions a little bit more tidy.
2019-03-18fsp_srv: Unstub SetCurrentProcessLioncash2-1/+5
This just acts as a basic setter for a given PID value and performs no further checking, so we can just store the passed in value.
2019-03-18service/am: Add basic implementation of ChangeMainAppletMasterVolumeLioncash2-1/+29
All this does is supply a new volume level and a fade time in nanoseconds for the volume transition to occur within.
2019-03-18service/am: Unstub SetTransparentVolumeRate()Lioncash2-1/+17
Like the other volume setter, this mainly just sets a data member within the service, nothing too special.
2019-03-18service/am: Unstub SetExpectedMasterVolume()Lioncash2-11/+27
This function passes in the desired main applet and library applet volume levels. We can then just pass those values back within the relevant volume getter functions, allowing us to unstub those as well. The initial values for the library and main applet volumes differ. The main applet volume is 0.25 by default, while the library applet volume is initialized to 1.0 by default in the services themselves.
2019-03-17CMakeLists: Move off of modifying CMAKE_*-related flagsLioncash1-20/+12
Modifying CMAKE_* related flags directly applies those changes to every single CMake target. This includes even the targets we have in the externals directory. So, if we ever increased our warning levels, or enabled particular ones, or enabled any other compilation setting, then this would apply to externals as well, which is often not desirable. This makes our compilation flag setup less error prone by only applying our settings to our targets and leaving the externals alone entirely. This also means we don't end up clobbering any provided flags on the command line either, allowing users to specifically use the flags they want.
2019-03-17input_common/sdl_impl: Make lambda capture more specific in SDLState constructorLioncash1-1/+1
We don't need to universally capture by reference. We specifically just need to capture the this pointer.
2019-03-17input_common/sdl_impl: Remove unnecessary std::chrono::duration constructionLioncash1-1/+1
Specifying the time unit itself is sufficient here.
2019-03-17input_common/sdl_impl: Remove unused variable in SDLState constructorLioncash1-1/+0
2019-03-17CMakeLists: Move compilation flags into the src directoryLioncash1-0/+69
We generally shouldn't be hijacking CMAKE_CXX_FLAGS, etc as a means to append flags to the targets, since this adds the compilation flags to everything, including our externals, which can result in weird issues and makes the build hierarchy fragile. Instead, we want to just apply these compilation flags to our targets, and let those managing external libraries to properly specify their compilation flags. This also results in us not getting as many warnings, as we don't raise the warning level on every external target.
2019-03-17core: Move PageTable struct into Common.bunnei16-171/+215
2019-03-17gl_rasterizer: Skip zero addr/sized regions on flush/invalidate.bunnei1-0/+6
2019-03-16ipc_helpers: Allow pushing and popping floating-point valuesLioncash1-0/+30
Certain values that are passed through the IPC buffer are actually floating point values, not solely integral values.
2019-03-16common/thread_queue_list: Remove unnecessary dependency on boostLioncash2-4/+4
We really don't need to pull in several headers of boost related machinery just to perform the erase-remove idiom (particularly with C++20 around the corner, which adds universal container std::erase and std::erase_if, which we can just use instead). With this, we don't need to link in anything boost-related into common.
2019-03-16kernel/thread: Actually remove the definition of ExitCurrentThread()Lioncash1-6/+0
This was intended to be removed in 51d7f6bffcc0498a47abc7de27bf0906fc523dae, but I guess I forgot to actually save the file like a dingus.
2019-03-16memory: Simplify rasterizer cache operations.bunnei3-68/+22
2019-03-16video_core: Refactor to use MemoryManager interface for all memory access.bunnei20-189/+196
# Conflicts: # src/video_core/engines/kepler_memory.cpp # src/video_core/engines/maxwell_3d.cpp # src/video_core/morton.cpp # src/video_core/morton.h # src/video_core/renderer_opengl/gl_global_cache.cpp # src/video_core/renderer_opengl/gl_global_cache.h # src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
2019-03-16kernel/thread: Move thread exiting logic from ExitCurrentThread to svcExitThreadLioncash2-8/+7
Puts the operation on global state in the same places as the rest of the svc calls.
2019-03-16kernel/thread: Migrate WaitCurrentThread_Sleep into the Thread interfaceLioncash4-25/+24
Rather than make a global accessor for this sort of thing. We can make it a part of the thread interface itself. This allows getting rid of a hidden global accessor in the kernel code.
2019-03-16kernel/thread: Expand documentation of nominal_priority and current_priorityLioncash2-3/+11
Aims to disambiguate why each priority instance exists a little bit. While we're at it, also add an explanatory comment to UpdatePriority().
2019-03-16kernel/thread: Make bracing consistent within UpdatePriority()Lioncash1-2/+4
2019-03-16kernel/thread: Amend condition within UpdatePriority()Lioncash1-3/+3
This condition was checking against the nominal thread priority, whereas the kernel itself checks against the current priority instead. We were also assigning the nominal priority, when we should be assigning current_priority, which takes priority inheritance into account. This can lead to the incorrect priority being assigned to a thread. Given we recursively update the relevant threads, we don't need to go through the whole mutex waiter list. This matches what the kernel does as well (only accessing the first entry within the waiting list).
2019-03-16kernel/thread: Maintain priority ordering of added mutex waiting threadsLioncash1-14/+24
The kernel keeps the internal waiting list ordered by priority. This is trivial to do with std::find_if followed by an insertion.
2019-03-16yuzu: Make hotkeys configurable via the GUIAdityarup Laha23-208/+426
* Adds a new Hotkeys tab in the Controls group. * Double-click a Hotkey to rebind it.
2019-03-15gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB. (#4651)Dimitri A3-4/+5
* gdbstub: fix IsMemoryBreak() returning false while connected to client As a result, the only existing codepath for a memory watchpoint hit to break into GDB (InterpeterMainLoop, GDB_BP_CHECK, ARMul_State::RecordBreak) is finally taken, which exposes incorrect logic* in both RecordBreak and ServeBreak. * a blank BreakpointAddress structure is passed, which sets r15 (PC) to NULL * gdbstub: DynCom: default-initialize two members/vars used in conditionals * gdbstub: DynCom: don't record memory watchpoint hits via RecordBreak() For now, instead check for GDBStub::IsMemoryBreak() in InterpreterMainLoop and ServeBreak. Fixes PC being set to a stale/unhit breakpoint address (often zero) when a memory watchpoint (rwatch, watch, awatch) is handled in ServeBreak() and generates a GDB trap. Reasons for removing a call to RecordBreak() for memory watchpoints: * The``breakpoint_data`` we pass is typed Execute or None. It describes the predicted next code breakpoint hit relative to PC; * GDBStub::IsMemoryBreak() returns true if a recent Read/Write operation hit a watchpoint. It doesn't specify which in return, nor does it trace it anywhere. Thus, the only data we could give RecordBreak() is a placeholder BreakpointAddress at offset NULL and type Access. I found the idea silly, compared to simply relying on GDBStub::IsMemoryBreak(). There is currently no measure in the code that remembers the addresses (and types) of any watchpoints that were hit by an instruction, in order to send them to GDB as "extended stop information." I'm considering an implementation for this. * gdbstub: Change an ASSERT to DEBUG_ASSERT I have never seen the (Reg[15] == last_bkpt.address) assert fail in practice, even after several weeks of (locally) developping various branches around GDB. Only leave it inside Debug builds.
2019-03-15frontend: qt: fix a freeze where if you click on entry in the game list too fast, citra will hangliushuyu1-3/+1
2019-03-15gpu: Use host address for caching instead of guest address.bunnei26-294/+394
2019-03-15core/hle/kernel/mutex: Remove usages of global system accessorsLioncash1-11/+15
Removes the use of global system accessors, and instead uses the explicit interface provided.
2019-03-15core/hle/kernel: Make Mutex a per-process class.Lioncash5-18/+47
Makes it an instantiable class like it is in the actual kernel. This will also allow removing reliance on global accessors in a following change, now that we can encapsulate a reference to the system instance in the class.
2019-03-13video_core/morton: Use enum to describe MortonCopyPixels128 modeReinUsesLisp3-7/+10
2019-03-13video_core/morton: Remove unused parameter in MortonSwizzleReinUsesLisp3-8/+7
2019-03-13video_core/morton: Remove clang-format off when it's not neededReinUsesLisp1-133/+129
2019-03-13video_core/morton: Remove unused functionsReinUsesLisp1-39/+0
2019-03-13core/hle/kernel/svc: Implement svcUnmapTransferMemoryLioncash1-1/+48
Similarly, like svcMapTransferMemory, we can also implement svcUnmapTransferMemory fairly trivially as well.
2019-03-13core/hle/kernel/svc: Implement svcMapTransferMemoryLioncash1-1/+57
Now that transfer memory handling is separated from shared memory, we can implement svcMapTransferMemory pretty trivially.
2019-03-13core/hle/kernel: Split transfer memory handling out into its own classLioncash6-4/+177
Within the kernel, shared memory and transfer memory facilities exist as completely different kernel objects. They also have different validity checking as well. Therefore, we shouldn't be treating the two as the same kind of memory. They also differ in terms of their behavioral aspect as well. Shared memory is intended for sharing memory between processes, while transfer memory is intended to be for transferring memory to other processes. This breaks out the handling for transfer memory into its own class and treats it as its own kernel object. This is also important when we consider resource limits as well. Particularly because transfer memory is limited by the resource limit value set for it. While we currently don't handle resource limit testing against objects yet (but we do allow setting them), this will make implementing that behavior much easier in the future, as we don't need to distinguish between shared memory and transfer memory allocations in the same place.
2019-03-13video_core/texture: Fix up sampler lod biasReinUsesLisp1-1/+1
2019-03-13vk_sampler_cache: Use operator== instead of memcmpMat M1-1/+1
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-03-13vk_sampler_cache: Implement a sampler cacheReinUsesLisp4-1/+140
2019-03-13kernel/process: Remove use of global system accessorsLioncash2-8/+9
Now that we pass in a reference to the system instance, we can utilize it to eliminate the global accessors in Process-related code.
2019-03-12video_core/texture: Add a raw representation of TSCEntryReinUsesLisp1-24/+29
2019-03-11renderer_opengl/gl_global_cache: Replace indexing for assignment with insert_or_assignLioncash2-3/+3
The previous code had some minor issues with it, really not a big deal, but amending it is basically 'free', so I figured, "why not?". With the standard container maps, when: map[key] = thing; is done, this can cause potentially undesirable behavior in certain scenarios. In particular, if there's no value associated with the key, then the map constructs a default initialized instance of the value type. In this case, since it's a std::shared_ptr (as a type alias) that is the value type, this will construct a std::shared_pointer, and then assign over it (with objects that are quite large, or actively heap allocate this can be extremely undesirable). We also make the function take the region by value, as we can avoid a copy (and by extension with std::shared_ptr, a copy causes an atomic reference count increment), in certain scenarios when ownership isn't a concern (i.e. when ReserveGlobalRegion is called with an rvalue reference, then no copy at all occurs). So, it's more-or-less a "free" gain without many downsides.
2019-03-11renderer_opengl/gl_global_cache: Append missing override specifiersLioncash1-2/+2
Two of the functions here are overridden functions, so we can append these specifiers to make it explicit.
2019-03-11set_sys: Move constants to anonymous namespaceZach Hilman1-1/+1
2019-03-11kernel/server_port: Make data members privateLioncash4-14/+36
With this, all kernel objects finally have all of their data members behind an interface, making it nicer to reason about interactions with other code (as external code no longer has the freedom to totally alter internals and potentially messing up invariants).
2019-03-11hwopus: Leverage multistream API for decoding regular Opus packetsLioncash1-34/+48
After doing a little more reading up on the Opus codec, it turns out that the multistream API that is part of libopus can handle regular packets. Regular packets are just a degenerate case of multistream Opus packets, and all that's necessary is to pass the number of streams as 1 and provide a basic channel mapping, then everything works fine for that case. This allows us to get rid of the need to use both APIs in the future when implementing multistream variants in a follow-up PR, greatly simplifying the code that needs to be written.
2019-03-11gl_rasterizer: Use system instance passed from argumentReinUsesLisp2-29/+31
2019-03-11set_sys: Use official nintendo version stringZach Hilman4-19/+25
2019-03-11system_version: Correct sizes on VectorVfsFile constructionZach Hilman1-4/+4
2019-03-11set_sys: Use correct error codes in GetFirmwareVersion*Zach Hilman1-21/+41
2019-03-10core/hle/result: Remove now-unnecessary manually defined copy assignment operatorLioncash1-5/+0
Previously this was required, as BitField wasn't trivially copyable. BitField has since been made trivially copyable, so now this isn't required anymore.
2019-03-10core/hle/result: Amend error in comment description for ResultCodeLioncash1-1/+1
Gets rid of another holdover from Citra, and describes the OS on the Switch instead.
2019-03-10core/hle/result: Remove now-unused constructor for ResultCodeLioncash1-10/+0
Now that the final stray ErrorDescription member was relocated, we can finally remove it and its relevant constructor in the ResultCode union.
2019-03-10core/hle/result: Relocate IPC error code to ipc_helpersLioncash3-3/+4
Relocates the error code to where it's most related, similar to how all the other error codes are. Previously we were including a non-generic error in the main result code header.
2019-03-10service/service: Remove unncessary calls to c_str()Lioncash1-4/+3
These can just be passed regularly, now that we use fmt instead of our old logging system. While we're at it, make the parameters to MakeFunctionString std::string_views.
2019-03-10set_sys: Implement GetFirmwareVersion(2) for libnx hosversionZach Hilman6-3/+128
Uses the synthesized system archive 9 (SystemVersion) and reports v5.1.0-0.0
2019-03-10audio_core/cubeb_sink: Convert _MSC_VER ifdefs to _WIN32Lioncash2-4/+4
This behavior also needs to be visible for MinGW builds as well.
2019-03-09clang fixHexagon121-1/+2
2019-03-09Log 2 new setting valuesHexagon121-0/+2
2019-03-09gl_rasterizer: Encapsulate sampler queries into methodsReinUsesLisp3-64/+72
2019-03-09yuzu_cmd/config: Replace C casts with static_castReinUsesLisp1-4/+5
2019-03-09yuzu_cmd/config: Silent implicit cast warningReinUsesLisp1-1/+1
2019-03-09gl_rasterizer: Minor logger changesReinUsesLisp1-19/+13
2019-03-08dma_pusher: Store command_list_header by copyReinUsesLisp1-1/+1
Instead of holding a reference that will get invalidated by dma_pushbuffer.pop(), hold it as a copy. This doesn't have any performance cost since CommandListHeader is 8 bytes long.
2019-03-08kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optionalLioncash4-47/+47
There's no real need to use a shared lifetime here, since we don't actually expose them to anything else. This is also kind of an unnecessary use of the heap given the objects themselves are so small; small enough, in fact that changing over to optionals actually reduces the overall size of the HLERequestContext struct (818 bytes to 808 bytes).
2019-03-08kernel: Make the address arbiter instance per-processLioncash8-28/+35
Now that we have the address arbiter extracted to its own class, we can fix an innaccuracy with the kernel. Said inaccuracy being that there isn't only one address arbiter. Each process instance contains its own AddressArbiter instance in the actual kernel. This fixes that and gets rid of another long-standing issue that could arise when attempting to create more than one process.
2019-03-08kernel/svc: Move address arbiter signaling behind a unified API functionLioncash3-22/+26
Similar to how WaitForAddress was isolated to its own function, we can also move the necessary conditional checking into the address arbiter class itself, allowing us to hide the implementation details of it from public use.
2019-03-08kernel/svc: Move address arbiter waiting behind a unified API functionLioncash3-19/+24
Rather than let the service call itself work out which function is the proper one to call, we can make that a behavior of the arbiter itself, so we don't need to directly expose those implementation details.
2019-03-07common/bit_field: Make BitField trivially copyableLioncash1-9/+7
This makes the class much more flexible and doesn't make performing copies with classes that contain a bitfield member a pain. Given BitField instances are only intended to be used within unions, the fact the full storage value would be copied isn't a big concern (only sizeof(union_type) would be copied anyways). While we're at it, provide defaulted move constructors for consistency.
2019-03-07video_core/gpu_thread: Remove unimplemented WaitForIdle function prototypeLioncash1-3/+0
This function didn't have a definition, so we can remove it to prevent accidentally attempting to use it.
2019-03-07video_core/gpu_thread: Amend constructor initializer list orderLioncash1-2/+2
Moves the data members to satisfy the order they're declared as in the constructor initializer list. Silences a -Wreorder warning.
2019-03-07video_core/gpu: Make GPU's destructor virtualLioncash3-3/+3
Because of the recent separation of GPU functionality into sync/async variants, we need to mark the destructor virtual to provide proper destruction behavior, given we use the base class within the System class. Prior to this, it was undefined behavior whether or not the destructor in the derived classes would ever execute.
2019-03-07citra_qt: Settings (configuration) reworkzhupengfei2-203/+250
2019-03-07service/audio/hwopus: Move decoder state to its own classLioncash1-50/+85
Moves the non-multistream specific state to its own class. This will be necessary to support the multistream variants of opus decoding.
2019-03-07service/audio/hwopus: Provide a name for the second word of OpusPacketHeaderLioncash1-2/+4
This indicates the entropy coder's final range.
2019-03-07service/audio/hwopus: Move Opus packet header out of the IHardwareOpusDecoderManagerLioncash1-17/+17
This will be utilized by more than just that class in the future. This also renames it from OpusHeader to OpusPacketHeader to be more specific about what kind of header it is.
2019-03-07service/audio/hwopus: Enclose internals in an anonymous namespaceLioncash1-2/+3
Makes it impossible to violate the ODR, as well as providing a place for future changes.
2019-03-07service/audio/audout_u: Only actually stop the audio stream in StopAudioOut if the stream is playingLioncash1-1/+3
The service itself only does further actions if the stream is playing. If the stream is already stopped, then it just exits successfully.
2019-03-07gpu_thread: Fix deadlock with threading idle state check.bunnei2-7/+11
2019-03-07gpu_thread: (HACK) Ignore flush on FlushAndInvalidateRegion.bunnei1-3/+1
2019-03-07gpu: Always flush.bunnei2-13/+6
2019-03-07gpu: Refactor a/synchronous implementations into their own classes.bunnei8-65/+162
2019-03-07gpu: Move command processing to another thread.bunnei9-15/+358
2019-03-07bootmanager: Ensure that we have a context for shader loading.bunnei1-4/+6
2019-03-07gpu: Refactor command and swap buffers interface for asynch.bunnei5-17/+26
2019-03-07gpu: Refactor to take RendererBase instead of RasterizerInterface.bunnei3-18/+23
2019-03-07settings: Add new graphics setting for use_asynchronous_gpu_emulation.bunnei7-0/+24
2019-03-07core: Set is_powered_on before GPU is initialized.bunnei1-1/+3
2019-03-06yuzu: add a hotkey to switch between undocked and docked modefearlessTobi1-0/+8
2019-03-06hle/service/audio/audout_u: Correct lack of return in failure case of AppendAudioOutBufferImpl()Lioncash1-0/+1
Previously we were overwriting the error case with a success code further down (which is definitely not what we should be doing here).
2019-03-06yuzu/debugger/wait_tree: Remove use of global CurrentProcess accessorLioncash2-5/+6
We already have the thread instance that was created under the current process, so we can just pass the handle table of it along to retrieve the owner of the mutex.
2019-03-06video_core/engines: Remove unnecessary includesLioncash10-11/+11
Removes a few unnecessary dependencies on core-related machinery, such as the core.h and memory.h, which reduces the amount of rebuilding necessary if those files change. This also uncovered some indirect dependencies within other source files. This also fixes those.
2019-03-06kernel/server_session: Make data members privateLioncash5-32/+73
Makes it much nicer to locally reason about server session behavior, as part of its functionality isn't placed around other classes.
2019-03-06kernel/client_session: Make data members privateLioncash1-4/+5
These can be made private, as they aren't accessed in contexts that require them to be public.
2019-03-05hle/service/audio: Extract audio error codes to a headerLioncash4-10/+21
Places all error codes in an easily includable header. This also corrects the unsupported error code (I accidentally used the hex value when I meant to use the decimal one).
2019-03-05kernel/address_arbiter: Pass in system instance to constructorLioncash6-26/+45
Allows getting rid of reliance on the global accessor functions and instead operating on the provided system instance.
2019-03-05kernel/address_arbiter: Minor tidying upLioncash1-18/+18
- Invert conditions into guard clases where applicable. - Mark std::vector parameter of WakeThreads as const
2019-03-05kernel/address_arbiter: Convert the address arbiter into a classLioncash5-82/+135
Places all of the functions for address arbiter operation into a class. This will be necessary for future deglobalizing efforts related to both the memory and system itself.
2019-03-05video_core/surface: Remove obsolete TODO in PixelFormatFromRenderTargetFormat()Lioncash1-2/+0
This isn't needed anymore, according to Hexagon
2019-03-05vm_manager: Remove cheat-specific ranges from VMManagerZach Hilman10-77/+56
2019-03-05kernel/thread: Remove obsolete TODO in Create()Lioncash1-2/+0
This is a TODO carried over from Citra that doesn't apply here.
2019-03-05core/hle/ipc: Remove unnecessary includesLioncash6-8/+12
Removes a few inclusion dependencies from the headers or replaces existing ones with ones that don't indirectly include the required headers. This allows removing an inclusion of core/memory.h, meaning that if the memory header is ever changed in the future, it won't result in rebuilding the entirety of the HLE services (as the IPC headers are used quite ubiquitously throughout the HLE service implementations).
2019-03-05core: Add support for registering and controlling ownership of CheatEngineZach Hilman2-0/+13
2019-03-05cheat_engine: Add parser and interpreter for game cheatsZach Hilman3-0/+715
2019-03-05loader/nso: Set main code region in VMManagerZach Hilman3-2/+21
For rom directories (and by extension, XCI/NSP/NAX/NCA) this is for the NSO with name 'main', for regular NSOs, this is the NSO.
2019-03-05vm_manager: Add support for storing and getting main code regionZach Hilman2-0/+28
Used as root for one region of cheats, set by loader
2019-03-05patch_manager: Display cheats in game list add-onsZach Hilman1-0/+2
2019-03-05patch_manager: Add support for loading cheats listsZach Hilman2-0/+56
Uses load/<title_id>/<mod_name>/cheats as root dir, file name is all upper or lower hex first 8 bytes build ID.
2019-03-05controllers/npad: Add accessor for current press stateZach Hilman1-0/+1
Allows frontend/features to access pressed buttons conveniently as possible
2019-03-05web_browser: Add shortcut to Enter key to exit appletZach Hilman2-0/+7
Addresses issues where a user in fullscreen could not exit some web applets without leaving fullscreen.
2019-03-04vm_manager: Use range helpers in HeapAlloc() and HeapFree()Lioncash1-4/+2
Significantly tidies up two guard conditionals.
2019-03-04vm_manager: Provide address range checking functions for other memory regionsLioncash2-4/+35
Makes the interface uniform when it comes to checking various memory regions.
2019-03-04kernel/scheduler: Pass in system instance in constructorLioncash5-17/+23
Avoids directly relying on the global system instance and instead makes an arbitrary system instance an explicit dependency on construction. This also allows removing dependencies on some global accessor functions as well.
2019-03-04kernel/shared_memory: Get rid of the use of global accessor functions within Create()Lioncash1-3/+2
Given we already pass in a reference to the kernel that the shared memory instance is created under, we can just use that to check the current process, rather than using the global accessor functions. This allows removing direct dependency on the system instance entirely.
2019-03-04svc: Migrate address range checking functions to VMManagerLioncash3-23/+30
Provides a bit of a more proper interface for these functions.
2019-03-04core/core: Remove the global telemetry accessor functionLioncash1-4/+0
With all usages converted off of it, this function can be removed.
2019-03-04yuzu: Remove usage of the global telemetry accessorLioncash2-3/+3
In these cases the system object is nearby, and in the other, the long-form of accessing the telemetry instance is already used, so we can get rid of the use of the global accessor.
2019-03-04yuzu-cmd/yuzu: Replace direct usage of the global system telemetry accessor in main()Lioncash1-1/+1
We already have the system instance around, so we can use that instead of the accessor.
2019-03-04core/core: Replace direct usage of the global system telemetry accessor from Shutdown()Lioncash1-7/+7
The telemetry instance is actually a member of the class itself, so we can access it directly instead of going through the global accessor.
2019-03-04video_core/renderer_opengl: Replace direct usage of global system object accessorsLioncash2-11/+17
We already pass a reference to the system object to the constructor of the renderer, so we can just use that instead of using the global accessor functions.
2019-03-04maxwell_to_vk: Initial implementationReinUsesLisp4-3/+553
2019-03-02web_service: Remove unnecessary inclusionsLioncash2-3/+0
Reduces the potential amount of rebuilding necessary if any headers change. In particular, we were including a header from the core library when we don't even link the core library to the web_service library, so this also gets rid of an indirect dependency.
2019-03-02logging/backend: Make time_origin a class variable instead of a local staticLioncash1-2/+1
Moves local global state into the Impl class itself and initializes it at the creation of the instance instead of in the function. This makes it nicer for weakly-ordered architectures, given the CreateEntry() class won't need to have atomic loads executed for each individual call to the CreateEntry class.
2019-03-02logging/backend: Move CreateEntry into the Impl classLioncash2-29/+26
This function is only ever used within this source file and makes it easier to remove static state in the following change.
2019-03-02fixup! Joystick: Allow for background events; Add deadzone to SDLAnalogB3n301-6/+17
2019-03-02input/sdl: lock map mutex after SDL callWeiyi Wang1-11/+17
Any SDL invocation can call the even callback on the same thread, which can call GetSDLJoystickBySDLID and eventually cause double lock on joystick_map_mutex. To avoid this, lock guard should be placed as closer as possible to the object accessing code, so that any SDL invocation is with the mutex unlocked
2019-03-02Input: Remove global variables from SDL InputJames Rowe9-809/+206
Changes the interface as well to remove any unique methods that frontends needed to call such as StartJoystickEventHandler by conditionally starting the polling thread only if the frontend hasn't started it already. Additionally, moves all global state into a single SDLState class in order to guarantee that the destructors are called in the proper order
2019-03-02Input: Copy current SDL.h/cpp files to implJames Rowe2-0/+680
This should make reviewing much easier as you can then see what changed happened between the old file and the new one
2019-03-02citra_qt/main: make SPEED_LIMIT_STEP static constexprfearlessTobi1-1/+4
MSVC does not seem to like using constexpr values in a lambda that were declared outside of it. Previously on MSVC build the hotkeys to inc-/decrease the speed limit were not working correctly because in the lambda the SPEED_LIMIT_STEP had garbage values. After googling around a bit I found: https://github.com/codeplaysoftware/computecpp-sdk/issues/95 which seems to be a similar issue. Trying the suggested fix to make the variable static constexpr also fixes the bug here.
2019-03-02Memory: don't lock hle mutex in memory read/writeWeiyi Wang1-6/+0
The comment already invalidates itself: neither MMIO nor rasterizer cache belongsHLE kernel state. This mutex has a too large scope if MMIO or cache is included, which is prone to dead lock when multiple thread acquires these resource at the same time. If necessary, each MMIO component or rasterizer should have their own lock.
2019-03-02vk_buffer_cache: Fix clang-formatReinUsesLisp1-3/+3
2019-03-02fuck git for ruining my day, I will learn but I will not forgivebunnei1-1/+1
2019-03-01vk_buffer_cache: Implement a buffer cacheReinUsesLisp3-0/+205
This buffer cache is just like OpenGL's buffer cache with some minor style changes. It uses VKStreamBuffer.
2019-03-01service/audio/audren_u: Implement OpenAudioRendererAutoLioncash2-7/+20
This currently has the same behavior as the regular OpenAudioRenderer API function, so we can just move the code within OpenAudioRenderer to an internal function that both service functions call.
2019-03-01service/audio: Provide an implementation of ExecuteAudioRendererRenderingLioncash1-1/+12
This service function appears to do nothing noteworthy on the switch. All it does at the moment is either return an error code or abort the system. Given we obviously don't want to kill the system, we just opt for always returning the error code.
2019-02-28gl_rasterizer: Remove texture unbinding after dispatching a draw callReinUsesLisp1-12/+0
Unbinding was required when OpenGL delete operations didn't unbind a resource if it was bound. This is no longer needed and can be removed.
2019-02-28gl_state: Fixup multibind bugReinUsesLisp1-2/+2
2019-02-28Devirtualize Register/Unregister and use a wrapper instead.Fernando Sahmkow3-12/+8
2019-02-28Corrections and redesign.Fernando Sahmkow2-51/+51
2019-02-28Fix linux compile error.Fernando Sahmkow1-1/+1
2019-02-28Remove NotifyFrameBuffer as we are doing a texception pass every drawcall.Fernando Sahmkow2-25/+0
2019-02-28Remove certain optimizations that caused texception to fail in certain scenarios.Fernando Sahmkow3-24/+1
2019-02-28Bug fixes and formattingFernando Sahmkow2-3/+4
2019-02-28rasterizer_cache_gl: Implement Texception PassFernando Sahmkow3-0/+51
2019-02-28rasterizer_cache_gl: Implement Partial Reinterpretation of Surfaces.Fernando Sahmkow2-0/+100
2019-02-28rasterizer_cache: mark reinterpreted surfaces and add ability to reload marked surfaces on next use.Fernando Sahmkow2-0/+78
2019-02-28rasterizer_cache_gl: Notify on framebuffer changeFernando Sahmkow2-4/+23
2019-02-28rasterizer_cache: Expose FlushObject to Child classes and allow redefining of Register and UnregisterFernando Sahmkow1-11/+11
2019-02-27Speed up memory page mapping (#2141)Annomatg1-6/+11
- Memory::MapPages total samplecount was reduced from 4.6% to 1.06%. - From main menu into the game from 1.03% to 0.35%
2019-02-27audio_core/cubeb_sink: Ensure COM is initialized on Windows prior to calling cubeb_initLioncash2-0/+19
cubeb now requires that COM explicitly be initialized on the thread prior to calling cubeb_init.
2019-02-27gl_rasterizer_cache: Create texture views for array discrepanciesReinUsesLisp3-32/+42
When a texture is sampled in a shader with a different array mode than the cached state, create a texture view and bind that to the shader instead.
2019-02-27service/hid: Amend forward declaration of ServiceManagerLioncash1-1/+1
The SM namespace is within the Service namespace, so this was forward declaring a type that didn't exist.
2019-02-27yuzu/compatdb: Remove unused lambda captureLioncash1-1/+1
Silences a compiler warning with clang.
2019-02-27vk_memory_manager: Reorder constructor initializer list in terms of member declaration orderLioncash1-1/+1
Reorders members in the order that they would actually be initialized in. Silences a -Wreorder warning.
2019-02-27gl_rasterizer: Reorder constructor initializer list in terms of member declaration orderLioncash1-2/+2
Orders the members in the order they would actually be initialized in. Silences a -Wreorder warning.
2019-02-27gl_shader_disk_cache: Remove #pragma once from cpp fileLioncash1-2/+0
This is only necessary in headers. Silences a warning with clang.
2019-02-27core/frontend/emu_window: Make ClipToTouchScreen a const member functionLioncash2-2/+2
This member function doesn't modify instance state, so it can have the const specifier applied to it.
2019-02-27audio_core/audio_renderer: Name previously unknown parameters of AudioRendererParameterLioncash2-19/+21
Provides names for previously unknown entries (aside from the two u8 that appear to be padding bytes, and a single word that also appears to be reserved or padding). This will be useful in subsequent changes when unstubbing behavior related to the audio renderer services.
2019-02-27common/math_util: Move contents into the Common namespaceLioncash18-40/+40
These types are within the common library, so they should be within the Common namespace.
2019-02-27common/vector_math: Move Vec[x] types into the Common namespaceLioncash6-38/+38
These types are within the common library, so they should be using the Common namespace.
2019-02-27common/quaternion: Move Quaternion into the Common namespaceLioncash2-6/+6
Quaternion is within the common library, so it should be using the Common namespace.
2019-02-27service/vi: Unstub GetDisplayServiceLioncash5-11/+49
This function is also supposed to check its given policy type with the permission of the service itself. This implements the necessary machinery to unstub these functions. Policy::User seems to just be basic access (which is probably why vi:u is restricted to that policy), while the other policy seems to be for extended abilities regarding which displays can be managed and queried, so this is assumed to be for a background compositor (which I've named, appropriately, Policy::Compositor).
2019-02-27core/ipc_helper: Allow popping all signed value types with RequestParserLioncash1-0/+15
There's no real reason this shouldn't be allowed, given some values sent via a request can be signed. This also makes it less annoying to work with popping enum values, given an enum class with no type specifier will work out of the box now. It's also kind of an oversight to allow popping s64 values, but nothing else.
2019-02-27gl_rasterizer_cache: Move format conversion to its own fileReinUsesLisp7-136/+175
2019-02-27decoders: Minor style changesReinUsesLisp2-14/+8
2019-02-26service/vi: Remove use of a module classLioncash8-46/+99
This didn't really provide much benefit here, especially since the subsequent change requires that the behavior for each service's GetDisplayService differs in a minor detail. This also arguably makes the services nicer to read, since it gets rid of an indirection in the class hierarchy.
2019-02-26renderer_opengl: Update pixel format trackingReinUsesLisp1-0/+1
2019-02-26maxwell_3d: Use std::bitset to manage dirty flagsReinUsesLisp4-52/+51
2019-02-26vk_stream_buffer: Remove copy code pathReinUsesLisp2-53/+18
2019-02-26shader/decode: Remove extras from MetaTextureReinUsesLisp4-40/+65
2019-02-26shader/decode: Split memory and texture instructions decodingReinUsesLisp7-501/+538
2019-02-25kernel/handle_table: Make local variables as const where applicableLioncash1-4/+5
Makes immutable state explicit.
2019-02-25kernel/handle_table: Allow process capabilities to limit the handle table sizeLioncash6-10/+54
The kernel allows restricting the total size of the handle table through the process capability descriptors. Until now, this functionality wasn't hooked up. With this, the process handle tables become properly restricted. In the case of metadata-less executables, the handle table will assume the maximum size is requested, preserving the behavior that existed before these changes.
2019-02-25kernel/handle-table: In-class initialize data membersLioncash2-3/+2
Directly initializes members where applicable.
2019-02-25kernel/handle_table: Resolve truncation warningsLioncash1-2/+2
Avoids implicit truncation warnings from u32 -> u16 (the truncation is desirable behavior here).
2019-02-25audio_core/cubeb_sink: Initialize CubebSinkStream's last_frame data memberLioncash1-1/+1
Ensures that all member variables are initialized in a deterministic manner across the board.
2019-02-25audio_core/cubeb_sink: Add override specifier to destructorLioncash1-1/+1
CubebSinkStream inherits from a base class with a virtual destructor, so override can be appended to CubebSinkStream's destructor.
2019-02-25audio_core/cubeb_sink: Resolve variable shadowing warnings in SamplesInQueueLioncash1-2/+2
The name of the parameter was shadowing the member variable of the same name. Instead, alter the name of the parameter to prevent said shadowing.
2019-02-25audio_core/codec: Resolve truncation warnings within DecodeADPCMLioncash1-2/+2
The assignments here were performing an implicit truncation from int to s16. Make it explicit that this is desired behavior.
2019-02-25shader/track: Resolve variable shadowing warningsLioncash1-5/+5
2019-02-25service/vi: Update IManagerDisplayService's function tableLioncash1-0/+1
Amends it to add the 7.0.0+ CreateStrayLayer function.
2019-02-25file_sys/vfs_vector: Fix ignored offset on WriteFrederic L1-1/+1
2019-02-24Remove GCC version checkstgsm1-3/+3
Citra can't be compiled using GCC <7 because of required C++17 support, so these version checks don't need to exist anymore.
2019-02-24vk_stream_buffer: Implement a stream bufferReinUsesLisp3-1/+200
This manages two kinds of streaming buffers: one for unified memory models and one for dedicated GPUs. The first one skips the copy from the staging buffer to the real buffer, since it creates an unified buffer. This implementation waits for all fences to finish their operation before "invalidating". This is suboptimal since it should allocate another buffer or start searching from the beginning. There is room for improvement here. This could also handle AMD's "pinned" memory (a heap with 256 MiB) that seems to be designed for buffer streaming.
2019-02-24vk_resource_manager: Minor VKFenceWatch changesReinUsesLisp2-7/+7
2019-02-24vk_memory_manager: Fixup commit interval allocationReinUsesLisp1-2/+1
VKMemoryCommitImpl was using as the end of its interval "begin + end". That ended up wasting memory.
2019-02-24gl_rasterizer_cache: Fixup parameter order in layered swizzleReinUsesLisp1-1/+1
2019-02-22vk_scheduler: Implement a schedulerReinUsesLisp3-1/+132
The scheduler abstracts command buffer and fence management with an interface that's able to do OpenGL-like operations on Vulkan command buffers. It returns by value a command buffer and fence that have to be used for subsequent operations until Flush or Finish is executed, after that the current execution context (the pair of command buffers and fences) gets invalidated a new one must be fetched. Thankfully validation layers will quickly detect if this is skipped throwing an error due to modifications to a sent command buffer.
2019-02-22service/nvflinger: Store BufferQueue instances as regular data membersLioncash7-36/+39
The NVFlinger service is already passed into services that need to guarantee its lifetime, so the BufferQueue instances will already live as long as they're needed. Making them std::shared_ptr instances in this case is unnecessary.
2019-02-21service/vi/vi_layer: Convert Layer struct into a classLioncash6-10/+43
Like the previous changes made to the Display struct, this prepares the Layer struct for changes to its interface. Given Layer will be given more invariants in the future, we convert it into a class to better signify that.
2019-02-21service/nvflinger: Move display specifics over to vi_displayLioncash4-35/+141
With the display and layer structures relocated to the vi service, we can begin giving these a proper interface before beginning to properly support the display types. This converts the display struct into a class and provides it with the necessary functions to preserve behavior within the NVFlinger class.
2019-02-21Fixes Unicode Key File Directories (#2120)Jungy1-1/+2
* Fixes Unicode Key File Directories Adds code so that when loading a file it converts to UTF16 first, to ensure the files can be opened. Code borrowed from FileUtil::Exists. * Update src/core/crypto/key_manager.cpp Co-Authored-By: Jungorend <Jungorend@users.noreply.github.com> * Update src/core/crypto/key_manager.cpp Co-Authored-By: Jungorend <Jungorend@users.noreply.github.com> * Using FileUtil instead to be cleaner. * Update src/core/crypto/key_manager.cpp Co-Authored-By: Jungorend <Jungorend@users.noreply.github.com>
2019-02-20service/nvflinger: Relocate definitions of Layer and Display to the vi serviceLioncash7-57/+123
These are more closely related to the vi service as opposed to the intermediary nvflinger. This also places them in their relevant subfolder, as future changes to these will likely result in subclassing to represent various displays and services, as they're done within the service itself on hardware. The reasoning for prefixing the display and layer source files is to avoid potential clashing if two files with the same name are compiled (e.g. if 'display.cpp/.h' or 'layer.cpp/.h' is added to another service at any point), which MSVC will actually warn against. This prevents that case from occurring. This also presently coverts the std::array introduced within f45c25aabacc70861723a7ca1096a677bd987487 back to a std::vector to allow the forward declaration of the Display type. Forward declaring a type within a std::vector is allowed since the introduction of N4510 (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4510.html) by Zhihao Yuan.
2019-02-19video_core/dma_pusher: Simplyfy Step() logic.Markus Wick2-81/+77
As fetching command list headers and and the list of command headers is a fixed 1:1 relation now, they can be implemented within a single call. This cleans up the Step() logic quite a bit.
2019-02-19video_core/dma_pusher: The full list of headers at once.Markus Wick2-48/+58
Fetching every u32 from memory leads to a big overhead. So let's fetch all of them as a block if possible. This reduces the Memory::* calls by the dma_pusher by a factor of 10.
2019-02-19vk_memory_manager: Implement memory managerReinUsesLisp3-0/+342
A memory manager object handles the memory allocations for a device. It allocates chunks of Vulkan memory objects and then suballocates.
2019-02-16Corrections, documenting and fixes.Fernando Sahmkow4-13/+14
2019-02-16audio_core/buffer: Make const and non-const getter for samples consistentLioncash2-2/+2
This way proper const/non-const selection can occur.
2019-02-16address_arbiter: Use nested namespaces where applicableLioncash2-8/+4
A fairly trivial change. Other sections of the codebase use nested namespaces instead of separate namespaces here. This one must have just been overlooked.
2019-02-16video_core: Remove usages of System::GetInstance() within the enginesLioncash9-23/+49
Avoids the use of the global accessor in favor of explicitly making the system a dependency within the interface.
2019-02-16Use u128 on Clock Cycles calculation.Fernando Sahmkow5-27/+32
2019-02-16Implement 128 bits Unsigned Integer Multiplication and Division.Fernando Sahmkow3-0/+50
2019-02-16Correct CNTPCT to use Clock Cycles instead of Cpu Cycles.Fernando Sahmkow3-2/+13
2019-02-16core_timing: Convert core timing into a classLioncash53-412/+548
Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
2019-02-15Adressed review commentsB3n302-7/+9
2019-02-15threadsafe_queue: Add WaitIfEmpty and use it in loggingB3n303-14/+26
2019-02-15renderer_opengl: respect the sRGB colorspace for the screenshot featurefearlessTobi1-1/+2
Previously, we were completely ignoring for screenshots whether the game uses RGB or sRGB. This resulted in screenshot colors that looked off for some titles.
2019-02-15gl_state: Synchronize gl_state even when state is disabledReinUsesLisp1-83/+61
There are some potential edge cases where gl_state may fail to track the state if a related state changes while the toggle is disabled or it didn't change. This addresses that.
2019-02-14vk_resource_manager: Implement a command buffer pool with VKFencedPoolReinUsesLisp2-1/+59
2019-02-14vk_resource_manager: Add VKFencedPool interfaceReinUsesLisp2-0/+83
Handles a pool of resources protected by fences. Manages resource overflow allocating more resources. This class is intended to be used through inheritance.
2019-02-14vk_resource_manager: Implement VKResourceManager and fence allocatorReinUsesLisp2-0/+85
CommitFence iterates a pool of fences until one is found. If all fences are being used at the same time, allocate more.
2019-02-14vk_resource_manager: Implement VKFenceWatchReinUsesLisp2-0/+68
A fence watch is used to keep track of the usage of a fence and protect a resource or set of resources without having to inherit from their handlers.
2019-02-14vk_resource_manager: Implement VKFenceReinUsesLisp2-0/+131
Fences take ownership of objects, protecting them from GPU-side or driver-side concurrent access. They must be commited from the resource manager. Their usage flow is: commit the fence from the resource manager, protect resources with it and use them, send the fence to an execution queue and Wait for it if needed and then call Release. Used resources will automatically be signaled when they are free to be reused.
2019-02-14vk_resource_manager: Add VKResource interfaceReinUsesLisp3-1/+43
VKResource is an interface that gets signaled by a fence when it is free to be reused.
2019-02-14shader_decompiler: Improve Accuracy of Attribute Interpolation.Fernando Sahmkow6-38/+74
2019-02-13rasterizer_cache_gl: Only do fast layered copy on the same format. AsFernando Sahmkow1-1/+5
glCopyImageSubData does not support different formats.
2019-02-13Make bitfield assignment operator publicfearlessTobi1-6/+2
This change needs to be made to get the code compiling again. It was suggested after a conversation with Lioncash. The conversation can be seen here: https://user-images.githubusercontent.com/20753089/45064197-b6107800-b0b2-11e8-9db8-f696299fb86a.PNG
2019-02-13threadsafe_queue: Use std::size_t for representing sizeLioncash1-7/+6
Makes it consistent with the regular standard containers in terms of size representation. This also gets rid of dependence on our own type aliases, removing the need for an include.
2019-02-13threadsafe_queue: Remove NeedSize template parameterLioncash2-15/+13
The necessity of this parameter is dubious at best, and in 2019 probably offers completely negligible savings as opposed to just leaving this enabled. This removes it and simplifies the overall interface.
2019-02-13core_timing: Make EmptyTimedCallback a local variableLioncash1-3/+3
Given this is only used in one place, it can be moved closest to its usage site.
2019-02-13vk_device: Abstract device handling into a classReinUsesLisp3-1/+351
VKDevice contains all the data required to manage and initialize a physical device. Its intention is to be passed across Vulkan objects to query device-specific data (for example the logical device and the dispatch loader).
2019-02-13renderer_opengl: Remove reference to global system instanceLioncash1-3/+3
We already store a reference to the system instance that the renderer is created with, so we don't need to refer to the system instance via Core::System::GetInstance()
2019-02-12gl_rasterizer_cache: Remove unnecessary newlineLioncash1-2/+0
2019-02-12gl_rasterizer_cache: Get rid of variable shadowingLioncash1-6/+14
Avoids shadowing the members of the struct itself, which results in a -Wshadow warning.
2019-02-12renderer_vulkan: Add declarations fileReinUsesLisp2-0/+52
This file is intended to be included instead of vulkan/vulkan.hpp. It includes declarations of unique handlers using a dynamic dispatcher instead of a static one (which would require linking to a Vulkan library).
2019-02-12logging: Add Vulkan backend logging class typeReinUsesLisp2-0/+2
2019-02-12gl_shader_decompiler: Re-implement TLDS lodReinUsesLisp2-22/+35
2019-02-12core_timing: Rename CoreTiming namespace to Core::TimingLioncash35-174/+172
Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
2019-02-11Corrected F2I None mode to RoundEven.Fernando Sahmkow2-4/+4
2019-02-11Fix incorrect value for CC bit in IADDFernando Sahmkow1-2/+2
2019-02-10kepler_compute: Fixup assert and rename enginesReinUsesLisp6-52/+59
When I originally added the compute assert I used the wrong documentation. This addresses that. The dispatch register was tested with homebrew against hardware and is triggered by some games (e.g. Super Mario Odyssey). What exactly is missing to get a valid program bound by this engine requires more investigation.
2019-02-09Implement BGRA8 framebuffer formatgreggameplayer3-0/+4
2019-02-09Implement linear textures (#2089)Fernando Sahmkow2-5/+39
2019-02-08gl_rasterizer_cache: Fixup texture view parametersReinUsesLisp1-2/+2
These parameters were declared as constants and passed to glTextureView but then they were removed on a rabase. This addresses that mistake.
2019-02-08nvdisp_disp0: change drawing message log level from Warning to TraceTobias1-3/+3
This is a leftover from the early yuzu days. We shouldn't log every time when we are drawing by default, so let's change the log level to Trace.
2019-02-08Use QString instead of std::string where applicableunknown1-17/+11
2019-02-08Use constexpr char array instead of string where applicableMat M1-1/+1
Co-Authored-By: FreddyFunk <frederic.laing.development@gmail.com>
2019-02-08frontend: Open transferable shader cache for a selected game in the gamelistunknown4-0/+50
2019-02-07shader_ir: Remove F4 prefix to texture operationsReinUsesLisp3-26/+25
This was originally included because texture operations returned a vec4. These operations now return a single float and the F4 prefix doesn't mean anything.
2019-02-07shader_ir: Clean texture management codeReinUsesLisp3-133/+104
Previous code relied on GLSL parameter order (something that's always ill-formed on an IR design). This approach passes spatial coordiantes through operation nodes and array and depth compare values in the the texture metadata. It still contains an "extra" vector containing generic nodes for bias and component index (for example) which is still a bit ill-formed but it should be better than the previous approach.
2019-02-07gl_rasterizer_cache: Mark surface copy destinations as modified.bunnei2-4/+18
2019-02-07gl_rasterizer: Implement a more accurate fermi 2D copy.bunnei7-68/+188
- This is a blit, use the blit registers.
2019-02-07cmake: Fix title bar issueReinUsesLisp1-1/+14
2019-02-07gl_shader_disk_cache: Check LZ4 size limitFrederic L1-0/+4
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-02-07gl_shader_disk_cache: Consider compressed size zero as an errorFrederic L1-2/+2
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-02-07cmake: Use CMAKE_COMMAND instead of "cmake"Frederic L1-1/+1
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-02-07gl_shader_disk_cache: Use unordered containersReinUsesLisp4-56/+64
2019-02-07gl_shader_cache: Fixup GLSL unique identifiersReinUsesLisp2-3/+3
2019-02-07loading_screen: Unchunk progress barReinUsesLisp1-1/+3
2019-02-07gl_shader_cache: Link loading screen with disk shader cache loadReinUsesLisp10-12/+62
2019-02-07gl_shader_cache: Set GL_PROGRAM_SEPARABLE to dumped shadersReinUsesLisp1-0/+1
i965 (and probably all mesa drivers) require GL_PROGRAM_SEPARABLE when using glProgramBinary. This is probably required by the standard but it's ignored by permisive proprietary drivers.
2019-02-07gl_shader_disk_cache: Pass core system as argument and guard against games without title idsReinUsesLisp11-18/+58
2019-02-07gl_shader_disk_cache: Guard reads and writes against failureReinUsesLisp2-216/+339
2019-02-07gl_shader_disk_cache: Address miscellaneous feedbackReinUsesLisp5-43/+57
2019-02-07gl_shader_disk_cache: Pass return values returning instead of by parametersReinUsesLisp3-39/+37
2019-02-07gl_shader_disk_cache: Compress program binaries using LZ4ReinUsesLisp1-7/+28
2019-02-07gl_shader_disk_cache: Compress GLSL code using LZ4ReinUsesLisp2-6/+57
2019-02-07gl_shader_disk_cache: Save GLSL and entries into the precompiled fileReinUsesLisp9-135/+234
2019-02-07settings: Hide shader cache behind a settingReinUsesLisp8-0/+42
2019-02-07gl_shader_disk_cache: Invalidate shader cache changes with CMake hashReinUsesLisp4-46/+72
2019-02-07gl_shader_cache: Refactor to support disk shader cacheReinUsesLisp2-121/+388
2019-02-07gl_shader_disk_cache: Add transferable cache invalidationReinUsesLisp2-0/+8
2019-02-07gl_shader_disk_cache: Add precompiled loadReinUsesLisp2-0/+45
2019-02-07gl_shader_disk_cache: Add precompiled saveReinUsesLisp2-0/+57
2019-02-07gl_shader_disk_cache: Add transferable loadReinUsesLisp2-0/+56
2019-02-07gl_shader_disk_cache: Add transferable storesReinUsesLisp2-0/+194
2019-02-07gl_shader_disk_cache: Add ShaderDiskCacheOpenGL class and helpersReinUsesLisp2-0/+76
2019-02-07gl_shader_disk_cache: Add file and move BaseBindings declarationReinUsesLisp4-10/+58
2019-02-07gl_shader_decompiler: Remove name entriesReinUsesLisp2-28/+10
2019-02-07gl_shader_util: Add parameter to handle retrievable programsReinUsesLisp3-6/+10
2019-02-07rasterizer_interface: Add disk cache entry for the rasterizerReinUsesLisp6-0/+17
2019-02-07file_util: Add shader directoryReinUsesLisp3-0/+3
2019-02-07shader_decode: Implement LDG and basic cbuf trackingReinUsesLisp1-0/+33
2019-02-06gdbstub: only let Execute breakpoints write/restore BKPT opcodes into target memoryDimitri ALBORA1-4/+10
2019-02-06remove all occurance of specifying endianness inside BitFieldWeiyi Wang6-96/+96
This commit it automatically generated by command in zsh: sed -i -- 's/BitField<\(.*\)_le>/BitField<\1>/g' **/*(D.) BitField is now aware to endianness and default to little endian. It expects a value representation type without storage specification for its template parameter.
2019-02-06common/bitfield: make it endianness-awareWeiyi Wang3-3/+100
2019-02-06common/swap: remove default value for swap type internal storageWeiyi Wang1-1/+1
This is compromise for swap type being used in union. A union has deleted default constructor if it has at least one variant member with non-trivial default constructor, and no variant member of T has a default member initializer. In the use case of Bitfield, all variant members will be the swap type on endianness mismatch, which would all have non-trivial default constructor if default value is specified, and non of them can have member initializer
2019-02-06common/swap: use template and tag for LE/BE specificationWeiyi Wang1-39/+91
The tag can be useful for other type-generic templates like BitFields to forward the endianness specification
2019-02-06common/swap: add swap template for enumWeiyi Wang1-0/+52
2019-02-06QT: Fix the loading screen 'H' switch logo to not glitch outJames Rowe1-1/+4
2019-02-06service/nvflinger,service/vi: Handle failure cases with exposed APILioncash4-47/+133
Converts many of the Find* functions to return a std::optional<T> as opposed to returning the raw return values directly. This allows removing a few assertions and handles error cases like the service itself does.
2019-02-05Fix crash when no files are selectedxperia641-6/+6
2019-02-05Add file extension to screenshot filename if not providedxperia641-3/+7
2019-02-05service/nvflinger: Mark FindVsyncEvent() as a const member functionLioncash2-2/+2
This member function doesn't actually modify instance state, so it can be marked as a const member function.
2019-02-05service/nvflinger: Rename GetVsyncEvent() to FindVsyncEvent()Lioncash3-3/+3
This was missed within #2075. Renames the member function to make it consistent with the rest of the Find* functions.
2019-02-05video_core/texture: Fix BitField size for depth_minus_oneReinUsesLisp1-1/+1
2019-02-04Update src/video_core/engines/shader_bytecode.hMat M1-1/+1
Co-Authored-By: FernandoS27 <fsahmkow27@gmail.com>
2019-02-03Fix TXQ not using the component mask.Fernando Sahmkow2-6/+13
2019-02-03shader_ir/memory: Add ST_L 64 and 128 bits storesReinUsesLisp1-3/+11
2019-02-03shader/track: Search inside of conditional nodesReinUsesLisp1-0/+11
Some games search conditionally use global memory instructions. This allows the heuristic to search inside conditional nodes for the source constant buffer.
2019-02-03shader_ir: Rename BasicBlock to NodeBlockReinUsesLisp30-122/+120
It's not always used as a basic block. Rename it for consistency.
2019-02-03shader_ir: Pass decoded nodes as a whole instead of per basic blocksReinUsesLisp27-57/+62
Some games call LDG at the top of a basic block, making the tracking heuristic to fail. This commit lets the heuristic the decoded nodes as a whole instead of per basic blocks. This may lead to some false positives but allows it the heuristic to track cases it previously couldn't.
2019-02-03video_core: Assert on invalid GPU to CPU address queriesReinUsesLisp8-47/+67
2019-02-03maxwell_3d: Allow sampler handles with TSC id zeroReinUsesLisp1-10/+6
2019-02-03maxwell_3d: Allow texture handles with TIC id zeroReinUsesLisp3-21/+7
Also remove "enabled" field from Tegra::Texture::FullTextureInfo because it would become unused.
2019-02-03memory_manager: Check for reserved page statusReinUsesLisp1-1/+2
2019-02-03shader_ir/memory: Add LD_L 128 bits loadsReinUsesLisp1-7/+19
2019-02-03shader_bytecode: Rename BytesN enums to BitsNReinUsesLisp2-7/+7
2019-02-03shader_ir/memory: Add LD_L 64 bits loadsReinUsesLisp1-6/+17
2019-02-01rasterizer_interface: Remove unused AccelerateFill operationReinUsesLisp3-11/+0
2019-02-01video_core: Remove unused Fill surface typeReinUsesLisp2-6/+1
2019-02-01kernel: Remove the Timer classLioncash9-259/+0
A holdover from citra, the Horizon kernel on the switch has no prominent kernel object that functions as a timer. At least not to the degree of sophistication that this class provided. As such, this can be removed entirely. This class also wasn't used at all in any meaningful way within the core, so this was just code sitting around doing nothing. This also allows removing a few things from the main KernelCore class that allows it to use slightly less resources overall (though very minor and not anything really noticeable).
2019-01-30gl_rasterizer_cache: Fixup test clauseReinUsesLisp1-6/+5
2019-01-30gl_rasterizer_cache: Guard clause swizzle testingMat M1-1/+3
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-01-30gl_state: Remove texture target trackingReinUsesLisp2-5/+0
2019-01-30gl_rasterizer_cache: Move swizzling to textures instead of stateReinUsesLisp6-28/+35
2019-01-30gl_state: Use DSA and multi bind to update texture bindingsReinUsesLisp1-8/+22
2019-01-30gl_rasterizer: Use DSA for texturesReinUsesLisp5-185/+105
2019-01-30kernel/wait_object: Devirtualize functions related to manipulating the thread list directlyLioncash1-3/+3
No inheritors of the WaitObject class actually make use of their own implementations of these functions, so they can be made non-virtual. It's also kind of sketchy to allow overriding how the threads get added to the list anyways, given the kernel itself on the actual hardware doesn't seem to customize based off this.
2019-01-30kernel/timer: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2-6/+0
This implementation just calls the base class variant of the function, so this isn't necessary.
2019-01-30kernel/readable_event: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2-6/+0
This just calls the base variant of the function, so it can be removed.
2019-01-30video_core/dma_pusher: Silence C4828 warningsLioncash1-1/+1
This was previously causing: warning C4828: The file contains a character starting at offset 0xa33 that is illegal in the current source character set (codepage 65001). warnings on Windows when compiling yuzu.
2019-01-30hwopus: Implement DecodeInterleavedLioncash1-4/+35
This functions almost identically to DecodeInterleavedWithPerfOld, however this function also has the ability to reset the decoder context. This is documented as a potentially desirable thing in the libopus manual in some circumstances as it says for the OPUS_RESET_STATE ctl: "This should be called when switching streams in order to prevent the back to back decoding from giving different result from one at a time decoding."
2019-01-30service/nvflinger: Make FindBufferQueueId() a const member functionLioncash2-2/+26
This member function doesn't actually modify instance state, so it can be const-qualified.
2019-01-30service/nvflinger: Rename Get prefix on function to FindLioncash3-23/+23
This more accurately describes what the function is actually attempting to do (it's not a simple trivial getter).
2019-01-30shader_ir: Unify constant buffer offset valuesReinUsesLisp17-25/+36
Constant buffer values on the shader IR were using different offsets if the access direct or indirect. cbuf34 has a non-multiplied offset while cbuf36 does. On shader decoding this commit multiplies it by four on cbuf34 queries.
2019-01-30hwopus: Deduplicate the decoding code within DecodeInterleavedOld and DecodeInterleavedWithPerfOldLioncash1-19/+14
Keeps the logic in one spot for use by both functions.
2019-01-30hwopus: Replace std::optional<std::reference_wrapper<u64>> with u64*Lioncash1-9/+6
This doesn't really offer anything over the use of a direct pointer, so we can just use that instead.
2019-01-30hwopus: Mark local variables as const where applicableLioncash1-8/+16
Makes non-mutable state more explicit.
2019-01-30hwopus: Fill in the rest of the unknown service function namesLioncash1-9/+11
Filled in via information provided by SwitchBrew.
2019-01-30service/ns: Update function tablesLioncash1-14/+20
Updates function tables based off information provided by SwitchBrew
2019-01-30service/ncm: Update function tablesLioncash1-4/+4
Updates function tables based off information provided by SwitchBrew
2019-01-30service/audio: Update function tablesLioncash4-8/+23
Updates function tables based off information provided by SwitchBrew.
2019-01-30service/am/applet_ae: Update function tablesLioncash1-1/+2
Updates function tables based off information provided by SwitchBrew.
2019-01-30service/fsp-srv: Update function tablesLioncash2-17/+25
Updates function tables based off information provided by SwitchBrew.
2019-01-30service/btm: Update function tablesLioncash1-55/+97
Updates function tables based off information provided by SwitchBrew
2019-01-30service/btdrv: Update function tablesLioncash1-46/+101
Updates function tables based off information provided by SwitchBrew.
2019-01-30gl_shader_cache: Use explicit bindingsReinUsesLisp7-249/+194
2019-01-30gl_rasterizer: Implement global memory managementReinUsesLisp6-4/+140
2019-01-30shader_decode: Implement LDG and basic cbuf trackingReinUsesLisp7-10/+240
2019-01-30video_core/GPU Implemented the GPU PFIFO puller semaphore operations. (#1908)Kevin2-12/+242
* Implemented the puller semaphore operations. * Nit: Fix 2 style issues * Nit: Add Break to default case. * Fix style. * Update for comments. Added ReferenceCount method * Forgot to remove GpuSmaphoreAddress union. * Fix the clang-format issues. * More clang formatting. * two more white spaces for the Clang formatting. * Move puller members into the regs union * Updated to use Memory::WriteBlock instead of Memory::Write* * Fix clang style issues * White space clang error * Removing unused funcitons and other pr comment * Removing unused funcitons and other pr comment * More union magic for setting regs value. * union magic refcnt as well * Remove local var * Set up the regs and regs_assert_positions up properly * Fix clang error
2019-01-30gl_shader_cache: Fix texture view for cubemaps as cubemap arraysReinUsesLisp4-3/+28
Cubemaps are considered layered and to create a texture view the texture mustn't be a layered texture, resulting in cubemaps being bound as cubemap arrays. To fix this issue this commit introduces an extra surface parameter called "is_array" and uses this to query for texture view creation. Now that texture views for cubemaps are actually being created, this also fixes the number of layers created for the texture view (since they have to be 6 to create a texture view of cubemaps).
2019-01-30gl_rasterizer: Workaround invalid zeta clearsReinUsesLisp2-14/+19
Some games (like Xenoblade Chronicles 2) clear both depth and stencil buffers while there's a depth-only texture attached (e.g. D16 Unorm). This commit reads the zeta format of the bound surface on ConfigureFramebuffers and returns if depth and/or stencil attachments were set. This is ignored on DrawArrays but on Clear it's used to just clear those attachments, bypassing an OpenGL error.
2019-01-30service/psc: Update function tablesLioncash1-8/+9
Updates the function tables based off information on SwitchBrew. Gets rid of a swath of unknown names.
2019-01-30nvflinger: Add the Null displayLioncash1-1/+2
In addition to the default, external, EDID, and internal displays, there's also a null display provided as well, which as the name suggests, does nothing but discard all commands given to it. This is provided for completeness.
2019-01-30nvflinger: Change log message in OpenDisplay to be a debug log instead of a warningLioncash1-1/+1
Opening a display isn't really a thing to warn about. It's an expected thing, so this can be a debug log. This also alters the string to indicate the display name better. Opening "Default" display reads a little nicer compared to Opening display Default.
2019-01-30nvflinger: Remove unnecessary header inclusionsLioncash1-2/+0
2019-01-30nvflinger: Mark locals const where applicableLioncash1-11/+11
Makes non-mutable state more explicit.
2019-01-30nvflinger: Use a std::array for the available displays instead of std::vectorLioncash2-7/+7
The built-in set of displays is fixed, so we can utilize an array instead of a vector here.
2019-01-30hle/ipc_helpers: Fix clang-format warningsLioncash1-1/+0
2019-01-29hle/ipc_helpers: Allow pushing signed valuesLioncash1-0/+22
This is kind of a large hole in the API, given we allow popping signed values. This fixes that.
2019-01-28service/pm: Implement SetMaintenanceBoot()Lioncash1-1/+10
This quite literally functions as a basic setter. No other error checking or anything (since there's nothing to really check against). With this, it completes the pm:bm interface in terms of functionality.
2019-01-28service/pm: Tidy up functionality related to SystemBootModeLioncash2-2/+9
Just minor tidying of interfaces.
2019-01-28service/vi: Remove stubbed notifier from SetLayerVisibilityLioncash1-2/+3
This appears to be a vestigial API function that's only kept around for compatibility's sake, given the function only returns a success error code and exits. Since that's the case, we can remove the stubbed notification from the log, since doing nothing is technically the correct behavior in this case.
2019-01-28shader/shader_ir: Amend three comment typosLioncash1-3/+3
Given we're in the area, these are three trivial typos that can be corrected.
2019-01-28shader/shader_ir: Amend constructor initializer ordering for AbufNodeLioncash1-2/+2
Orders the class members in the same order that they would actually be initialized in. Gets rid of two compiler warnings.
2019-01-28shader/decode: Avoid a pessimizing std::move within DecodeRange()Lioncash1-1/+1
std::moveing a local variable in a return statement has the potential to prevent copy elision from occurring, so this can just be converted into a regular return.
2019-01-27kernel/svc: Log out uncaught C++ exceptions from svcBreakLioncash1-0/+4
Looking into the implementation of the C++ standard facilities that seem to be within all modules, it appears that they use 7 as a break reason to indicate an uncaught C++ exception. This was primarily found via the third last function called within Horizon's equivalent of libcxxabi's demangling_terminate_handler(), which passes the value 0x80000007 to svcBreak.
2019-01-26dsp_interface: fix sound being played while volume is 0fearlessTobi1-1/+1
According to documentation, if the argument of std::exp is zero, one is returned. However we want the return value to be also zero in this case so no audio is played.
2019-01-26Use QPixmap/QIcon for background color selection buttonxperia642-7/+15
2019-01-26video_core: Silent implicit conversion warningReinUsesLisp1-3/+4
2019-01-24frontend: Refactor ScopeAcquireWindowContext out of renderer_opengl.bunnei7-36/+54
2019-01-22citra_qt: Log settings on launchzhupengfei5-0/+35
2019-01-22maxwell_3d: Set rt_separate_frag_data to 1 by defaultReinUsesLisp2-4/+6
Commercial games assume that this value is 1 but they never set it. On the other hand nouveau manually sets this register. On ConfigureFramebuffers we were asserting for what we are actually implementing (according to envytools).
2019-01-22QT: Hide GLWidget immediately after showing.James Rowe1-0/+2
With the loading screen merged, we don't want to actually show at this point, but it still needs to be shown to actually create the context. Turns out you can just show and hide it immediately and it'll work.
2019-01-22SDL Frontend: Add shared context supportJames Rowe2-1/+38
2019-01-22QT Frontend: Migrate to QOpenGLWindowJames Rowe4-30/+113
2019-01-21Change const char* to const char[]James Rowe1-4/+4
2019-01-21Fix mingw compile error and warningsJames Rowe2-6/+6
2019-01-21Add fade out effect to the loading screenJames Rowe4-94/+158
2019-01-21Set Minimum Size to the same as renderwindowJames Rowe1-0/+1
2019-01-21Remove blue box around loading screenJames Rowe1-1/+0
2019-01-21Change the background color of Stage Complete to yuzu blueJames Rowe1-1/+1
2019-01-21Rename step 1 and step 2 to be a little more descriptiveJames Rowe2-8/+8
2019-01-21Prevent estimated time from flashing after slow shader compilation startsJames Rowe1-1/+1
2019-01-21Move progress bar style into constexpr stringsJames Rowe1-28/+32
2019-01-20Hide progress bar on Prepare stepJames Rowe1-7/+8
2019-01-20QT: Upgrade the Loading Bar to look much betterJames Rowe4-11/+201
2019-01-20Add a workaround if QMovie isn't availableJames Rowe2-1/+20
2019-01-20QT Frontend: Add a Loading screen with progressbarJames Rowe8-10/+239
With shader caches on the horizon, one requirement is to provide visible feedback for the progress. The shader cache reportedly takes several minutes to load for large caches that were invalidated, and as such we should provide a loading screen with progress. Adds a loading screen widget that will be shown until the first frame of the game is swapped. This was chosen in case shader caches are not being used, several games still take more than a few seconds to launch and could benefit from a loading screen.
2019-01-18file_sys/directory: Remove unused DirectoryBackend classLioncash1-23/+0
This isn't used at all, so we can just get rid of it.
2019-01-18gl_rasterizer: Silent unsafe mix warningReinUsesLisp1-1/+1
2019-01-17yuzu/configuration/configure_input_player: Forward declare types where applicableLioncash2-2/+7
Allows removing the inclusion of the main input common header from the UI config header.
2019-01-17yuzu/configuration/configure_touchscreen_advanced: Remove unnecessary header inclusionsLioncash1-2/+0
2019-01-17yuzu/configuration/configure_per_general: Remove unused header inclusionsLioncash2-4/+3
2019-01-17yuzu/configuration/configure_debug: Remove unused header inclusionsLioncash1-1/+0
2019-01-17yuzu/configuration/configure_system: Remove unused header inclusionsLioncash1-8/+4
2019-01-17yuzu/configuration/configure_web: Remove an unused lambda captureLioncash1-5/+4
'this' isn't actually used within the lambda, since what we need from the class is already assigned within the capture section of the lambda.
2019-01-17yuzu/configuration/configure_web: Use an ellipsis with 'Verifying' textLioncash1-1/+1
It's a common UI pattern to use an ellipsis to indicate an ongoing action, rather than just specifying the word by itself.
2019-01-17core/frontend/applets/web_browser: Include missing headersLioncash1-2/+8
Gets rid of a few indirect inclusions.
2019-01-17core/frontend/applets/web_browser: Make OpenPage() non-constLioncash7-20/+25
This is a function that definitely doesn't always have a non-modifying behavior across all implementations, so this should be made non-const. This gets rid of the need to mark data members as mutable to work around the fact mutating data members needs to occur.
2019-01-17yuzu/web_browser: std::move std::function instances in OpenPage()Lioncash1-2/+2
Avoids the need to potentially reallocate the contained callbacks.
2019-01-17yuzu/web_browser: Make slot functions privateLioncash1-2/+1
These currently aren't used by anything other than the QtWebBrowser class itself, and can be made private.
2019-01-16shader_ir: Fixup clang buildReinUsesLisp1-4/+6
2019-01-15loader: Propagate NCA logo section to ReadBanner and ReadLogoZach Hilman9-0/+61
2019-01-15content_archive: Add getter for logo section of NCAZach Hilman2-0/+16
2019-01-15gl_shader_decompiler: replace std::get<> with std::get_if<> for macOS compatibilityReinUsesLisp1-44/+58
2019-01-15gl_shader_decompiler: Inline textureGather componentReinUsesLisp1-15/+16
2019-01-15shader_decode: Fixup XMADReinUsesLisp1-1/+1
2019-01-15shader_ir: Pass to decoder functions basic block's codeReinUsesLisp27-82/+83
2019-01-15shader_decode: Improve zero flag implementationReinUsesLisp15-75/+79
2019-01-15shader_ir: Remove composite primitives and use temporals insteadReinUsesLisp4-241/+224
2019-01-15gl_shader_decompiler: Fixup AssignCompositeHalfReinUsesLisp1-1/+1
2019-01-15shader_decode: Use proper primitive namesReinUsesLisp4-25/+21
2019-01-15shader_decode: Use BitfieldExtract instead of shift + andReinUsesLisp8-48/+37
2019-01-15shader_ir: Remove Ipa primitiveReinUsesLisp3-13/+2
2019-01-15gl_shader_decompiler: Use rasterizer's UBO size limitReinUsesLisp1-1/+3
2019-01-15gl_shader_gen: Fixup code formattingReinUsesLisp2-18/+22
2019-01-15video_core: Rename glsl_decompiler to gl_shader_decompilerReinUsesLisp7-7/+7
2019-01-15shader_ir: Remove RZ and use Register::ZeroIndex insteadReinUsesLisp3-12/+16
2019-01-15shader_decode: Implement TEXS.F16ReinUsesLisp3-15/+57
2019-01-15shader_decode: Fixup R2PReinUsesLisp1-2/+3
2019-01-15glsl_decompiler: Fixup TLDSReinUsesLisp1-1/+0
2019-01-15glsl_decompiler: Fixup geometry shadersReinUsesLisp2-15/+17
2019-01-15shader_decode: Fixup WriteLogicOperation zero comparisonReinUsesLisp1-1/+1
2019-01-15glsl_decompiler: Fixup permissive member function declarationsReinUsesLisp1-133/+133
2019-01-15shader_decode: Fixup PSETReinUsesLisp1-2/+3
2019-01-15shader_decode: Fixup clang-formatReinUsesLisp2-2/+4
2019-01-15video_core: Implement IR based geometry shadersReinUsesLisp4-10/+102
2019-01-15shader_decode: Implement VMAD and VSETPReinUsesLisp5-2/+129
2019-01-15shader_decode: Implement HSET2ReinUsesLisp3-1/+50
2019-01-15shader_decode: Rework HSETP2ReinUsesLisp4-47/+57
2019-01-15shader_decode: Implement R2PReinUsesLisp1-1/+28
2019-01-15shader_decode: Implement CSETPReinUsesLisp1-14/+37
2019-01-15shader_decode: Implement PSETReinUsesLisp1-1/+16
2019-01-15shader_decode: Implement HFMA2ReinUsesLisp4-5/+60
2019-01-15glsl_decompiler: Remove HNegate inliningReinUsesLisp1-10/+0
2019-01-15shader_decode: Implement POPCReinUsesLisp4-1/+22
2019-01-15shader_decode: Implement TLDS (untested)ReinUsesLisp3-10/+92
2019-01-15shader_decode: Update TLD4 reflecting #1862 changesReinUsesLisp2-52/+52
2019-01-15shader_ir: Fixup TEX and TEXS and partially fix TLD4 decompilingReinUsesLisp3-60/+72
2019-01-15shader_decode: Fixup FSETReinUsesLisp1-2/+2
2019-01-15shader_decode: Implement IADD32IReinUsesLisp1-0/+11
2019-01-15shader_decode: Fixup clang-formatReinUsesLisp1-1/+1
2019-01-15video_core: Return safe values after an assert hitsReinUsesLisp8-8/+19
2019-01-15shader_decode: Implement FFMAReinUsesLisp1-1/+36
2019-01-15video_core: Address feedbackReinUsesLisp4-13/+16
2019-01-15shader_ir: Fixup file inclusions and clang-formatReinUsesLisp3-2/+2
2019-01-15shader_ir: Move comment node stringMat M1-2/+2
Co-Authored-By: ReinUsesLisp <reinuseslisp@airmail.cc>
2019-01-15shader_ir: Address feedback to avoid UB in bit castingReinUsesLisp1-2/+4
2019-01-15shader_decode: Fixup clang-formatReinUsesLisp2-3/+2
2019-01-15shader_decode: Implement LEAReinUsesLisp1-0/+55
2019-01-15shader_decode: Implement IADD3ReinUsesLisp1-0/+61
2019-01-15shader_decode: Implement LOP3ReinUsesLisp2-0/+62
2019-01-15shader_decode: Implement ST_LReinUsesLisp1-0/+17
2019-01-15shader_decode: Implement LD_LReinUsesLisp1-0/+18
2019-01-15shader_decode: Implement HSETP2ReinUsesLisp1-1/+37
2019-01-15shader_decode: Implement HADD2 and HMUL2ReinUsesLisp1-1/+48
2019-01-15shader_decode: Implement HADD2_IMM and HMUL2_IMMReinUsesLisp1-1/+28
2019-01-15shader_decode: Implement MOV_SYSReinUsesLisp1-0/+27
2019-01-15shader_decode: Implement IMNMXReinUsesLisp1-0/+16
2019-01-15shader_decode: Implement F2F_CReinUsesLisp1-2/+10
2019-01-15shader_decode: Implement I2IReinUsesLisp1-0/+26
2019-01-15shader_decode: Implement BRA internal flagReinUsesLisp1-4/+8
2019-01-15shader_decode: Implement ISCADDReinUsesLisp1-0/+15
2019-01-15shader_decode: Implement XMADReinUsesLisp1-1/+85
2019-01-15shader_decode: Implement PBK and BRKReinUsesLisp1-1/+22
2019-01-15shader_decode: Implement LOPReinUsesLisp1-0/+15
2019-01-15shader_decode: Implement SELReinUsesLisp1-0/+8
2019-01-15shader_decode: Implement IADDReinUsesLisp1-1/+28
2019-01-15shader_decode: Implement ISETPReinUsesLisp1-1/+30
2019-01-15shader_decode: Implement BFIReinUsesLisp1-1/+22
2019-01-15shader_decode: Implement ISETReinUsesLisp1-1/+27
2019-01-15shader_decode: Implement LD_CReinUsesLisp1-0/+31
2019-01-15shader_decode: Implement SHLReinUsesLisp1-0/+8
2019-01-15shader_decode: Implement SHRReinUsesLisp1-1/+26
2019-01-15shader_decode: Implement LOP32IReinUsesLisp2-1/+72
2019-01-15shader_decode: Implement BFEReinUsesLisp1-1/+25
2019-01-15shader_decode: Implement FSETReinUsesLisp1-1/+36
2019-01-15shader_decode: Implement F2IReinUsesLisp1-0/+37
2019-01-15shader_decode: Implement I2FReinUsesLisp1-0/+23
2019-01-15shader_decode: Implement F2FReinUsesLisp1-1/+37
2019-01-15shader_decode: Stub DEPBARReinUsesLisp1-0/+4
2019-01-15shader_decode: Implement SSY and SYNCReinUsesLisp1-0/+19
2019-01-15shader_decode: Implement PSETPReinUsesLisp1-1/+21
2019-01-15shader_decode: Implement TMMLReinUsesLisp1-3/+45
2019-01-15shader_decode: Implement TEX and TXQReinUsesLisp2-0/+223
2019-01-15shader_decode: Implement TEXS (F32)ReinUsesLisp2-0/+217
2019-01-15shader_decode: Implement FSETPReinUsesLisp1-1/+33
2019-01-15shader_decode: Partially implement BRAReinUsesLisp1-0/+12
2019-01-15shader_decode: Implement IPAReinUsesLisp1-0/+12
2019-01-15shader_decode: Implement EXITReinUsesLisp1-1/+32
2019-01-15shader_decode: Implement ST_AReinUsesLisp1-0/+30
2019-01-15shader_decode: Implement LD_AReinUsesLisp1-1/+39
2019-01-15shader_decode: Implement FADD32IReinUsesLisp1-0/+12
2019-01-15shader_decode: Implement FMUL32_IMMReinUsesLisp1-0/+10
2019-01-15shader_decode: Implement MOV32_IMMReinUsesLisp1-1/+9
2019-01-15shader_decode: Stub RRO_C, RRO_R and RRO_IMMReinUsesLisp1-0/+9
2019-01-15shader_decode: Implement FMNMX_C, FMNMX_R and FMNMX_IMMReinUsesLisp1-0/+18
2019-01-15shader_decode: Implement MUFUReinUsesLisp1-0/+29
2019-01-15shader_decode: Implement FADD_C, FADD_R and FADD_IMMReinUsesLisp1-0/+15
2019-01-15shader_decode: Implement FMUL_C, FMUL_R and FMUL_IMMReinUsesLisp1-0/+42
2019-01-15shader_decode: Implement MOV_C and MOV_RReinUsesLisp1-1/+23
2019-01-15video_core: Replace gl_shader_decompilerReinUsesLisp8-4185/+57
2019-01-15glsl_decompiler: ImplementationReinUsesLisp3-0/+1483
2019-01-15shader_ir: Add condition code helperReinUsesLisp2-0/+13
2019-01-15shader_ir: Add predicate combiner helperReinUsesLisp2-0/+15
2019-01-15shader_ir: Add comparison helpersReinUsesLisp2-0/+106
2019-01-15shader_ir: Add half float helpersReinUsesLisp2-0/+44
2019-01-15shader_ir: Add integer helpersReinUsesLisp2-0/+40
2019-01-15shader_ir: Add float helpersReinUsesLisp2-0/+24
2019-01-15shader_ir: Add settersReinUsesLisp2-0/+24
2019-01-15shader_ir: Add local memory gettersReinUsesLisp2-0/+7
2019-01-15shader_ir: Add internal flag gettersReinUsesLisp2-0/+10
2019-01-15shader_ir: Add attribute gettersReinUsesLisp2-0/+26
2019-01-15shader_ir: Add constant buffer gettersReinUsesLisp2-0/+25
2019-01-15shader_ir: Add register getterReinUsesLisp2-0/+9
2019-01-15shader_ir: Add immediate node constructorsReinUsesLisp2-1/+34
2019-01-15shader_ir: Initial implementationReinUsesLisp30-0/+1573
2019-01-15shader_bytecode: Fixup encodingReinUsesLisp1-1/+1
2019-01-15shader_header: Make local memory size getter constantReinUsesLisp1-1/+1
2019-01-14audio_core: remove unnecessary spaces on commentsOtávio Pace1-2/+2
2019-01-09gl_rasterizer: Workaround Intel VAO DSA bugReinUsesLisp3-7/+16
There is a bug on Intel's blob driver where it fails to properly build a vertex array object if it's not bound even after creating it with glCreateVertexArrays. This workaround binds it after creating it to bypass the issue.
2019-01-08gl_global_cache: Add dummy global cache managerReinUsesLisp5-3/+96
2019-01-08settings: Fix comment structureZach Hilman2-5/+7
2019-01-08settings: Use std::chrono::seconds instead of s64 for RTCZach Hilman6-17/+21
2019-01-08time: Use custom RTC settings if applicable for gameZach Hilman2-8/+12
2019-01-08core: Set custom RTC differential on game bootZach Hilman1-0/+7
2019-01-08qt: Provide UI to edit custom RTC settingsZach Hilman2-28/+66
2019-01-08settings: Add custom RTC settingsZach Hilman4-4/+30
Stored as signed seconds since epoch.
2019-01-07gl_rasterizer: Skip framebuffer configuration if rendertargets have not been changedReinUsesLisp2-1/+31
2019-01-07gl_rasterizer_cache: Use dirty flags for the depth bufferReinUsesLisp4-3/+23
2019-01-07gl_rasterizer_cache: Use dirty flags for color buffersReinUsesLisp4-4/+24
2019-01-07gl_shader_cache: Use dirty flags for shadersReinUsesLisp5-2/+23
2019-01-06gl_stream_buffer: Use DSA for buffer managementReinUsesLisp3-17/+14
2019-01-06gl_rasterizer: Use DSA for vertex array objectsReinUsesLisp6-79/+53
2019-01-06gl_state: Drop uniform buffer state trackingReinUsesLisp3-10/+0
2019-01-05gl_rasterizer_cache: Use GL_STREAM_COPY for PBOsReinUsesLisp1-1/+1
Since the data is doing the path CPU -> GPU -> GPU copy is the most approximate hint. Using GL_STREAM_DRAW generated a performance warning on Nvidia's stack. Changing this hint removed the warning.
2019-01-05service/vi: Correct scaling mode conversionsLioncash1-15/+13
These values are not equivalent, based off RE. The internal value is put into a lookup table with the following values: [3, 0, 1, 2, 4] So the values absolutely do not map 1:1 like the comment was indicating.
2019-01-05service/vi: Factor out scaling mode conversions from the IPC function itselfLioncash1-17/+21
Avoids entangling the IPC buffer appending with the actual operation of converting the scaling values over. This also inserts the proper error handling for invalid scaling values.
2019-01-05service/vi: Unstub IApplicationDisplayService' SetLayerScalingMode()Lioncash1-21/+38
This appears to only check if the scaling mode can actually be handled, rather than actually setting the scaling mode for the layer. This implements the same error handling performed on the passed in values.
2019-01-05service/vi: Correct reported dimensions from IApplicationDisplayService's GetDisplayResolution()Lioncash1-12/+8
Within the actual service, it makes no distinguishing between docked and undocked modes. This will always return the constants values reporting 1280x720 as the dimensions.
2019-01-04qt: Move profile manager to own UI tabZach Hilman9-427/+565
2019-01-04Removed pulse event typeDavid Marcec4-9/+0
Pulse is considered a hack and nothing should be using it. We should completely remove it
2019-01-04Return no application area when games try to open an application areaDavid Marcec1-4/+4
This will prompt CreateApplicationArea
2019-01-04Proper no message handling for AM::PopMessageDavid Marcec1-1/+10
When we have no messages, we should be returning an error code.
2019-01-03 Fixed botw deadlock(and possibly 30 fps games rendering too fast? needs testing to confirm)David Marcec1-1/+1
Upon investigating the issue with #1878, I found that games are the ones who handle the vsync event resetting and not us.
2019-01-03service/vi: Implement SetDisplayEnabled()Lioncash1-1/+10
This IPC command is simply a stub inside the actual service itself, and just returns a successful error code regardless of input. This is likely only retained in the service interface to not break older code that relied upon it succeeding in some way.
2019-01-03service/vi: Log more information where applicableLioncash1-63/+74
In many cases, we didn't bother to log out any of the popped data members. This logs them out to the console within the logging call to provide more contextual information.
2019-01-03service/vi: Implement OpenDefaultDisplay in terms of OpenDisplayLioncash1-4/+17
Internally within the vi services, this is essentially all that OpenDefaultDisplay does, so it's trivial to just do the same, and forward the default display string into the function.
2019-01-02service/vi: Correct initial width and height valuesLioncash1-2/+2
Based off RE, it appears that almost all display types seem to use 1920x1080 except for a few (null display, edid display).
2019-01-02service/vi: Document unknown DisplayInfo struct membersLioncash1-2/+13
It appears that the two members indicate whether a display has a bounded number of layers (and if set, the second member indicates the total number of layers).
2019-01-01yuzu/configure_general: Silence truncation warnings in loadConfiguration()Lioncash1-2/+2
The QPixmap API expects an unsigned int.
2019-01-01yuzu/config: Silence truncation warningsLioncash1-1/+1
2019-01-01core/kernel: Remove unnecessary inclusionsLioncash16-16/+22
Gets rid of a few unnecessary header dependencies in some source files.
2018-12-31kernel/svc: Correct misleading error message within CreateThread()Lioncash1-2/+3
This is a bounds check to ensure that the thread priority is within the valid range of 0-64. If it exceeds 64, that doesn't necessarily mean that an actual priority of 64 was expected (it actually means whoever called the function screwed up their math). Instead clarify the message to indicate the allowed range of thread priorities.
2018-12-31kernel/svc: Sanitize core number and thread priorities in CreateThread()Lioncash1-6/+17
Now that we handle the kernel capability descriptors we can correct CreateThread to properly check against the core and priority masks like the actual kernel does.
2018-12-31kernel/process: Rename GetAllowedProcessorMask() and GetAllowedThreadPriorityMask()Lioncash2-11/+11
Makes them consistent with their kernel capability counterparts.
2018-12-31kernel/svc: Simplify thread core ID sanitizing in CreateThreadLioncash1-7/+1
Rather than use a switch here, this can be collapsed into a simple range check, which is a little easier on the eyes.
2018-12-31arm_interface: Make include path relative for arm_interface.hLioncash1-1/+1
Makes it consistent with the rest of the includes.
2018-12-31arm_interface: Make LogBacktrace() a const member functionLioncash2-2/+2
This function doesn't modify instance state, so it can be made const.
2018-12-31arm_interface: Mark variables as const where applicable in LogBacktrace()Lioncash1-3/+4
Two of these variables have fixed values, so we can make that immediately obvious from the get-go.
2018-12-31arm_interface: Remove unnecessary semicolonLioncash1-1/+1
Namespaces don't require the use of a semicolon. Silences a -Wextra-semi warning.
2018-12-30gl_rasterizer_cache: Texture view if shader samples array but OGL is notReinUsesLisp3-14/+74
When a shader samples a texture array but that texture in OpenGL is created without layers, use a texture view to increase the texture hierarchy. For example, instead of binding a GL_TEXTURE_2D bind a GL_TEXTURE_2D_ARRAY view.
2018-12-30service/time: Minor cleanup to GetClockSnapshot()Lioncash1-7/+9
Moves some variables closer to their actual usage sites.
2018-12-30service/time: Fill in some structures and remove padding where not necessaryLioncash2-7/+9
2018-12-29Moved log backtrace to arm_interface.cpp. Added printing of error code to fatalDavid Marcec4-18/+36
2018-12-29travis: Use correct package for linux Qt5WebEngineZach Hilman3-4/+3
2018-12-29web_browser: Add bounds checking to applet interfaceZach Hilman10-146/+160
2018-12-28gpu: Remove PixelFormat G8R8U and G8R8S, as they do not seem to exist.bunnei4-79/+46
- Fixes UI rendering issues in The Legend of Zelda: Breath of the Wild.
2018-12-28main: Add main window integrations for QtWebBrowserAppletZach Hilman3-0/+168
2018-12-28qt: Implement Qt frontend to web browserZach Hilman2-0/+154
Using a custom reimplementation of QWebEngineView and an injector script.
2018-12-28core: Add getter and setter for WebBrowserApplet frontendZach Hilman4-2/+22
2018-12-28frontend: Add frontend responder for web browserZach Hilman2-0/+52
2018-12-28applets: Implement LibAppletOff (Web) appletZach Hilman4-0/+234
2018-12-28loader: Add accessor for Manual RomFSZach Hilman5-0/+30
2018-12-28hid: Make Hid service accessible and add GetPressStateZach Hilman4-459/+540
2018-12-28romfs: Add SingleDiscard extraction typeZach Hilman2-2/+6
Needed for manual RomFS extraction, as Full generates an extra directory and Truncated generates variable results.
2018-12-28am: Add size parameter to am:IStorage loggingZach Hilman1-4/+4
2018-12-28audio_core: Convert LOG_CRITICAL + UNREACHABLE over to UNIMPLEMENTED/UNIMPLEMENTED_MSGLioncash3-10/+6
These two macros being used in tandem were used prior to the introduction of UNIMPLEMENTED and UNIMPLEMENTED_MSG. This provides equivalent behavior, just with less typing/reading involved.
2018-12-28kernel/process: Start the main thread using the specified ideal coreLioncash1-2/+2
This matches kernel behavior in that processes are started using their specified ideal core, rather than always starting on core 0.
2018-12-28kernel: Rename 'default' CPU core to 'ideal' coreLioncash5-23/+23
This makes the naming more closely match its meaning. It's just a preferred core, not a required default core. This also makes the usages of this term consistent across the thread and process implementations.
2018-12-28kernel/thread: Move process thread initialization into process.cppLioncash3-36/+30
This function isn't a general purpose function that should be exposed to everything, given it's specific to initializing the main thread for a Process instance. Given that, it's a tad bit more sensible to place this within process.cpp, which keeps it visible only to the code that actually needs it.
2018-12-28file_sys/program_metadata: Print out more descriptive address space descriptionsLioncash1-3/+7
Provides extra information that makes it easier to tell if an executable being run is using a 36-bit address space or a 39-bit address space. While we don't support AArch32 executables yet, this also puts in distinguishing information for the 32-bit address space types as well.
2018-12-28Qt/Configure: Use sidebar to divide tabs into smaller groupsspycrab3-59/+124
2018-12-28kernel/process: Remove most allocation functions from Process' interfaceLioncash4-49/+35
In all cases that these functions are needed, the VMManager can just be retrieved and used instead of providing the same functions in Process' interface. This also makes it a little nicer dependency-wise, since it gets rid of cases where the VMManager interface was being used, and then switched over to using the interface for a Process instance. Instead, it makes all accesses uniform and uses the VMManager instance for all necessary tasks. All the basic memory mapping functions did was forward to the Process' VMManager instance anyways.
2018-12-27Add missing uintBitsToFloat to SetRegisterToHalfFloatRodolfo Bogado1-2/+2
2018-12-27am: Implement GetSaveDataSize and ExtendSaveDataZach Hilman6-8/+53
These functions come in a pair and are needed by Smash Ultimate, Minecraft, and Skyrim, amongst others.
2018-12-27filesystem: Populate save data sizes from control dataZach Hilman2-0/+53
2018-12-27savedata_factory: Partially implement IVFC save sizes using filesZach Hilman2-0/+38
This stores a file in the save directory called '.yuzu_save_size' which stores the two save sizes (normal area and journaled area) sequentially as u64s.
2018-12-27loader: Add accessor for game control dataZach Hilman5-9/+14
2018-12-27control_metadata: Update NACP fields with latest Switchbrew dataZach Hilman2-6/+29
2018-12-27control_metadata: Use value member instead of unique_ptr to store structZach Hilman2-10/+13
Serves no actual purpose in this instance besides making NACP's copy assignment deleted, which is not intended behavior.
2018-12-27vfs: Add reinterpret_casts to WriteArray and ObjectZach Hilman1-2/+2
Allows these functions to compile when T is not u8.
2018-12-27kernel/vm_manager: Reset region attributes when unmapping a VMALioncash1-0/+1
Like the other members related to memory regions, the attributes need to be reset back to their defaults as well.
2018-12-26configure_per_general: Mark UI strings as translatable in the constructorLioncash1-2/+2
These are user-facing strings, so they should be translatable.
2018-12-26configure_input_simple: Make input profile array constexprLioncash1-12/+7
Calling tr() from a file-scope array isn't advisable, since it can be executed before the Qt libraries are even fully initialized, which can lead to crashes. Instead, the translatable strings should be annotated, and the tr() function should be called at the string's usage site.
2018-12-26renderer_opengl: Correct forward declaration of FramebufferLayoutLioncash1-1/+1
This is actually a struct, not a class, which can lead to compilation warnings.
2018-12-26Apply CC test to the final value to be stored in the registerRodolfo Bogado1-9/+12
2018-12-26Fixed shader linking error due to TLDS (#1934)David1-1/+1
* Fixed shader linking error due to TLDS coord should be coords * Fix remaining coords
2018-12-26npad: Remove code to invert input in horizontal mode.bunnei1-46/+0
- This was incorrect, the game appears to handle this for us. - Fixes horizontal mode with Puyo Puyo Tetris and Super Mario Odyssey.
2018-12-26shader_bytecode: Fixup TEXS.F16 encodingReinUsesLisp1-1/+1
2018-12-25qt: Use ProfileSelectionDialog when selecting user for save dataZach Hilman1-22/+16
This allows us to present a much nicer UI to the user over a simple combo box and is made easy with the modular nature of the profile-selection applet frontend.
2018-12-25qt: Add setting to prompt for user on game bootZach Hilman6-0/+32
Using the QtProfileSelectorDialog, this implementation is trivial. This mimics the real switch behavior of asking which user on every game boot, but it is default disabled as that might get inconvenient.
2018-12-22Includde saturation in the evaluation of the control codeRodolfo Bogado1-3/+4
2018-12-22Handle RZ cases evaluating the expression instead of the register value.Rodolfo Bogado1-14/+22
2018-12-22complete emulation of ZeroFlagRodolfo Bogado1-100/+97
2018-12-21common/quaternion: Ensure that w is always initializedLioncash1-1/+1
Previously xyz was always being zero initialized due to its constructor, but w wasn't. Ensures that we always have a deterministic initial state.
2018-12-21hid: Fix SetNpadJoyHoldType and improve logging.bunnei1-44/+163
2018-12-21kernel/process: Hook up the process capability parser to the process itselfLioncash7-122/+44
While we're at it, we can also toss out the leftover capability parsing from Citra.
2018-12-21kernel/process_capability: Handle debug capability flagsLioncash2-1/+18
2018-12-21kernel/process_capability: Handle handle table capability flagsLioncash2-1/+11
This just specifies the handle table size. There's also a section of reserved bits that are checked against.
2018-12-21kernel/process_capability: Handle kernel version capability flagsLioncash2-1/+18
2018-12-21kernel/process_capability: Handle program capability flagsLioncash3-2/+29
2018-12-21kernel/process_capability: Handle interrupt capability flagsLioncash1-1/+21
Similar to the service capability flags, however, we currently don't emulate the GIC, so this currently handles all interrupts as being valid for the time being.
2018-12-21kernel/process_capability: Handle syscall capability flagsLioncash2-1/+29
2018-12-21kernel/process_capability: Handle the priority mask and core mask flagsLioncash2-1/+40
Handles the priority mask and core mask flags to allow building up the masks to determine the usable thread priorities and cores for a kernel process instance.
2018-12-21kernel/process: Introduce process capability parsing skeletonLioncash5-3/+468
We've had the old kernel capability parser from Citra, however, this is unused code and doesn't actually map to how the kernel on the Switch does it. This introduces the basic functional skeleton for parsing process capabilities.
2018-12-21common: Add basic bit manipulation utility function to CommonLioncash2-0/+62
2018-12-19kernel/svc: Handle thread handles within GetProcessIdLioncash1-10/+23
If a thread handle is passed to svcGetProcessId, the kernel attempts to access the process ID via the thread's instance's owning process. Technically, this function should also be handling the kernel debug objects as well, however we currently don't handle those kernel objects yet, so I've left a note via a comment about it to remind myself when implementing it in the future.
2018-12-19svc: Implement svcSetMemoryAttributeLioncash1-5/+46
With all the basic backing functionality implemented, we can now unstub svcSetMemoryAttribute.
2018-12-19vm_manager: Add member function for setting memory attributes across an address rangeLioncash2-0/+41
This puts the backing functionality for svcSetMemoryAttribute in place, which will be utilized in a following change.
2018-12-19vm_manager: Add member function for checking a memory range adheres to certain attributes, permissions and statesLioncash2-0/+100
2018-12-19kernel/kernel: Use correct initial PID for userland Process instancesLioncash2-4/+14
Starts the process ID counter off at 81, which is what the kernel itself checks against internally when creating processes. It's actually supposed to panic if the PID is less than 81 for a userland process.
2018-12-19kernel/svc: Correct output parameter for svcGetThreadIdLioncash1-1/+1
The service call uses a 64-bit value, just like svcGetProcessId. This amends the function signature accordingly.
2018-12-19kernel/thread: Make thread_id a 64-bit valueLioncash4-7/+7
The kernel uses a 64-bit value for the thread ID, so we shouldn't be using a 32-bit value.
2018-12-19kernel/svc: Correct output parameter for svcGetProcessIdLioncash2-2/+10
svcGetProcessId's out parameter is a pointer to a 64-bit value, not a 32-bit one.
2018-12-19kernel/process: Make process_id a 64-bit valueLioncash3-6/+6
In the actual kernel, this is a 64-bit value, so we shouldn't be using a 32-bit type to handle it.
2018-12-19Device handle should not be a random id, instead it's the current npad idDavid Marcec1-2/+2
Found during hardware testing
2018-12-19Moved backtrace to ArmInterfaceDavid Marcec8-47/+20
2018-12-19hopefully fix clang format issueDavid Marcec1-0/+1
2018-12-19Fixed uninitialized memory due to missing returns in canaryDavid Marcec14-3/+33
Functions which are suppose to crash on non canary builds usually don't return anything which lead to uninitialized memory being used.
2018-12-19service/sm: Improve debug log for RegisterServiceLioncash1-4/+5
Now it also indicates the name and max session count. This also gives a name to the unknown bool. This indicates if the created port is supposed to be using light handles or regular handles internally. This is passed to the respective svcCreatePort parameter internally.
2018-12-18yuzu, video_core: Screenshot functionalityzhupengfei15-43/+228
Allows capturing screenshot at the current internal resolution (native for software renderer), but a setting is available to capture it in other resolutions. The screenshot is saved to a single PNG in the current layout.
2018-12-18Texture format fixes: Flag RGBA16UI as GL_RGBA_INTEGER format, and interpret R16U as Z16 when depth_compare is enabled.heapo1-1/+11
2018-12-18kernel/thread: Set default fpcrMerryMage1-0/+3
2018-12-18arm_dynarmic: Set CNTFRQ valueMerryMage1-0/+1
2018-12-18shader_bytecode: Fixup half float's operator B encodingReinUsesLisp1-1/+1
2018-12-18service/am: Unstub GetAppletResourceUserIdLioncash1-2/+5
This is supposed to return the current process' ID. (0 indicates an invalid ID for both process IDs and ARU IDs).
2018-12-17Implement postfactor multiplication/division for fmul instructionsheapo2-5/+21
2018-12-17Fix arrayed shadow sampler array slice/depth comparison ordering, as well as invalid GLSL LOD selection.heapo1-16/+14
2018-12-16vm_manager: Rename meminfo_state to stateLioncash2-10/+9
This is shorter and more concise. This also removes the now-innaccurate comment, as it's not returned wholesale to svcQueryMemory anymore.
2018-12-16vm_manager: Add backing functionality for memory attributesLioncash2-1/+85
Adds the barebones enumeration constants and functions in place to handle memory attributes, while also essentially leaving the attribute itself non-functional.
2018-12-15nvhost_gpu: Skip empty GPU command lists.bunnei1-0/+4
2018-12-13audio_core: Make g_sink_details internally linkedLioncash7-36/+58
We can hide the direct array from external view and instead provide functions to retrieve the necessary info. This has the benefit of completely hiding the makeup of the SinkDetails structure from the rest of the code. Given that this makes the array hidden, we can also make the array constexpr by altering the members slightly. This gets rid of several static constructor calls related to std::vector and std::function. Now we don't have heap allocations here that need to occur before the program can even enter main(). It also has the benefit of saving a little bit of heap space, but this doesn't matter too much, since the savings in that regard are pretty tiny.
2018-12-13Fix Service object leak on emulation stopJens Schmer2-10/+12
Services created with the ServiceFramework base class install themselves as HleHandlers with an owning shared_ptr in the ServerPort ServiceFrameworkBase::port member variable, creating a cyclic ownership between ServiceFrameworkBase and the ServerPort, preventing deletion of the service objects. Fix that by removing the ServiceFrameworkBase::port member because that was only used to detect multiple attempts at installing a port. Instead store a flag if the port was already installed to achieve the same functionality.
2018-12-12svc: Enable svcQueryProcessMemoryLioncash2-1/+6
svcQueryProcessMemory is trivial to implement, given all the behavior necessary for it is present, it just needs a handler for it.
2018-12-12svc: Write out the complete MemoryInfo structure in QueryProcessMemoryLioncash1-0/+3
In the previous change, the memory writing was moved into the service function itself, however it still had a problem, in that the entire MemoryInfo structure wasn't being written out, only the first 32 bytes of it were being written out. We still need to write out the trailing two reference count members and zero out the padding bits. Not doing this can result in wrong behavior in userland code in the following scenario: MemoryInfo info; // Put on the stack, not quaranteed to be zeroed out. svcQueryMemory(&info, ...); if (info.device_refcount == ...) // Whoops, uninitialized read. This can also cause the wrong thing to happen if the user code uses std::memcmp to compare the struct, with another one (questionable, but allowed), as the padding bits are not guaranteed to be a deterministic value. Note that the kernel itself also fully zeroes out the structure before writing it out including the padding bits.
2018-12-12svc: Handle memory writing explicitly within QueryProcessMemoryLioncash2-26/+22
Moves the memory writes directly into QueryProcessMemory instead of letting the wrapper function do it. It would be inaccurate to allow the handler to do it because there's cases where memory shouldn't even be written to. For example, if the given process handle is invalid. HOWEVER, if the memory writing is within the wrapper, then we have no control over if these memory writes occur, meaning in an error case, 68 bytes of memory randomly get trashed with zeroes, 64 of those being written to wherever the memory info address points to, and the remaining 4 being written wherever the page info address points to. One solution in this case would be to just conditionally check within the handler itself, but this is kind of smelly, given the handler shouldn't be performing conditional behavior itself, it's a behavior of the managed function. In other words, if you remove the handler from the equation entirely, does the function still retain its proper behavior? In this case, no. Now, we don't potentially trash memory from this function if an invalid query is performed.
2018-12-12vm_manager: Correct ordering of last two struct members of MemoryInfoLioncash1-2/+2
These should be swapped.
2018-12-12svc_wrap: Correct register index for a wrapper specializationLioncash1-1/+1
This would result in svcSetMemoryAttribute getting the wrong value for its third parameter. This is currently fine, given the service function is stubbed, however this will be unstubbed in a future change, so this needs to change.
2018-12-12vm_manager: Amend the returned values for invalid memory queries in QueryMemory()Lioncash2-4/+7
The kernel returns a memory info instance with the base address set to the end of the address space, and the size of said block as 0 - address_space_end, it doesn't set both of said members to zero.
2018-12-12vm_manager: Migrate memory querying to the VMManager interfaceLioncash4-18/+33
Gets rid of the need to directly access the managed VMAs outside of the memory manager itself just for querying memory.
2018-12-12vm_manager: Migrate MemoryInfo and PageInfo to vm_manager.hLioncash3-17/+16
Gets the two structures out of an unrelated header and places them with the rest of the memory management code. This also corrects the structures. PageInfo appears to only contain a 32-bit flags member, and the extra padding word in MemoryInfo isn't necessary.
2018-12-12vm_manager: Amend MemoryState enum membersLioncash5-28/+111
Amends the MemoryState enum to use the same values like the actual kernel does. Also provides the necessary operators to operate on them. This will be necessary in the future for implementing svcSetMemoryAttribute, as memory block state is checked before applying the attribute.
2018-12-12Fix Process object leak on emulation stopJens Schmer3-13/+12
The Process object kept itself alive indefinitely because its handle_table contains a SharedMemory object which owns a reference to the same Process object, creating a circular ownership scenario. Break that up by storing only a non-owning pointer in the SharedMemory object.
2018-12-11patch_manager: Prevent use of a dangling pointer within PatchRomFSLioncash1-4/+3
fmt::format() returns a std::string instance by value, so calling .c_str() on it here is equivalent to doing: auto* ptr = std::string{}.c_str(); The data being pointed to isn't guaranteed to actually be valid anymore after that expression ends. Instead, we can just take the string as is, and provide the necessary formatting parameters.
2018-12-11gl_shader_cache: Dehardcode constant in CalculateProgramSize()Lioncash1-2/+2
This constant is related to the size of the instruction.
2018-12-11gl_shader_cache: Resolve truncation compiler warningLioncash1-1/+1
The previous code would cause a warning, as it was truncating size_t (64-bit) to a u32 (32-bit) implicitly.
2018-12-10fsp_srv: Implement IStorage::GetSizeZach Hilman1-2/+15
Takes no input and returns the size as a u64. Needed by Katamari Damacy Reroll to boot.
2018-12-10gl_shader_decompiler: IPA FrontFacing: the right value when is the front face is 0xFFFFFFFF.Marcos Vitali1-1/+1
2018-12-10service/fsp_srv: Correct returned value in GetGlobalAccessLogMode()Lioncash1-1/+10
Based off RE, the backing code only ever seems to use 0-2 as the range of values 1 being a generic log enable, with 2 indicating logging should go to the SD card. These are used as a set of flags internally. Given we only care about receiving the log in general, we can just always signify that we want logging in general.
2018-12-10applets: Correct usage of SignalStateChanged eventZach Hilman3-6/+4
This was causing some games (most notably Pokemon Quest) to softlock due to an event being fired when not supposed to. This also removes a hack wherein we were firing the state changed event when the game retrieves it, which is incorrect.
2018-12-09Implemented a shader unique identifier.Fernando Sahmkow4-0/+57
2018-12-09Add more info into textures' object labelsFernandoS272-2/+57
2018-12-08 web_service: move telemetry condition from TelemetrySession constructor to destructorfearlessTobi1-8/+4
Fixes an issue where Testcases couldn't be sent when Telemetry was disabled, because both things are tied closely together in the backend.
2018-12-08file_sys/save_data_factory: Update SaveDataSpaceId enumLioncash1-1/+3
Amends it with missing values deduced from RE (ProperSystem being from SwitchBrew for naming) (SdCardUser wasn't that difficult to discern given it's used alongside SdCardSystem when creating the save data indexer, based off the usage of the string "saveDataIxrDbSd" nearby).
2018-12-07gl_shader_decompiler: TLDS/TLD4/TLD4S Reworked reflecting the source registers, bugs fixed and modularize.Marcos Vitali1-106/+134
2018-12-07Backport review comment from citra-emu/citra#4418Tobias1-2/+2
Original reason: As Windows multi-byte character codec is unspecified while we always assume std::string uses UTF-8 in our code base, this can output gibberish when the string contains non-ASCII characters. ::OutputDebugStringW combined with Common::UTF8ToUTF16W is preferred here.
2018-12-07savedata_factory: Add support for CacheStorageZach Hilman1-0/+2
2018-12-07savedata_factory: Delete TemporaryStorage on startupZach Hilman1-1/+5
Mimics hardware behavior.
2018-12-06memory: Convert ASSERT into a DEBUG_ASSERT within GetPointerFromVMA()Lioncash1-1/+1
Given memory should always be expected to be valid during normal execution, this should be a debug assertion, rather than a check in regular builds.
2018-12-06vm_manager: Make vma_map privateLioncash5-28/+41
This was only ever public so that code could check whether or not a handle was valid or not. Instead of exposing the object directly and allowing external code to potentially mess with the map contents, we just provide a member function that allows checking whether or not a handle is valid. This makes all member variables of the VMManager class private except for the page table.
2018-12-06Avoid (expensive) audio interpolation when sample rates already matchheapo2-4/+8
2018-12-06system_archive: Implement open source NgWord2Zach Hilman3-1/+41
2018-12-06hle/service: Replace log + UNIMPLEMENTED with UNIMPLEMENTED_MSGLioncash1-2/+1
Combines the two into one, shortening the amount of code here.
2018-12-06hle/service: Remove unnecessary using declarationsLioncash1-5/+1
Only one usage of the specified objects made use of the lack of namespacing. Given the low usage, we can just remove these.
2018-12-06hle/service, hle/sm: Compress usages of MakeResult()Lioncash2-3/+3
These auto-deduce the result based off its arguments, so there's no need to do that work for the compiler, plus, the function return value itself already indicates what we're returning.
2018-12-06hle/service, hle/sm: Use structured bindings where applicableLioncash2-9/+3
Gets rid of the need to keep the variables separate from their actual initialization spots.
2018-12-06yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeTextLioncash2-2/+2
Just a trivial modernization that potentially avoids copying strings in certain scenarios.
2018-12-05yuzu/game_list_worker: Don't retrieve the file type twice in AddFstEntriesToGameList()Lioncash1-5/+9
Similarly, here we can avoid doing unnecessary work twice by retrieving the file type only once and comparing it against relevant operands, avoiding potential unnecessary object construction/destruction.
2018-12-05yuzu/game_list_worker: Don't retrieve file type and file type strings twice in MakeGameListEntry()Lioncash1-4/+6
While GetFileType() is indeed a getter function, that doesn't mean it's a trivial function, given some case require reading from the data or constructing other objects in the background. Instead, only do necessary work once.
2018-12-05loaders: Make GetFileType() a const qualified member functionLioncash10-10/+10
No implementations actually modify instance state (and it would be questionable to do that in the first place given the name), so we can make this a const member function.
2018-12-05Call shrink_to_fit after page-table vector resizing to cause crt to actually lower vector capacity. For 36-bit titles saves 800MB of commit.heapo1-0/+8
2018-12-05kernel/process: Set ideal core from metadataLioncash1-0/+1
A very trivial change. If metadata is available, the process should use it to retrieve the desired core for the process to run on.
2018-12-05configure_input_simple: Properly signal docked mode changeZach Hilman3-33/+31
2018-12-05configure_input: Add ConfigureInputSimple as default input UI configZach Hilman8-1/+293
Greatly simplifies the current input UI, while still allowing power users to tweak advanced settings. Adds 'input profiles', which are easy autoconfigurations to make getting started easy and fast. Also has a custom option which brings up the current, full UI.
2018-12-05configure_input: Convert into QDialogZach Hilman3-7/+47
2018-12-05configure: Use ConfigureInputSimple for Input tabZach Hilman1-26/+26
2018-12-05ui_settings: Add UI setting for input profile indexZach Hilman2-0/+5
2018-12-05configuration/config: Use an intermediary variable for accessing playersLioncash1-43/+38
Avoids typing the same long accessor just to retrieve player attributes.
2018-12-05ng_word: Deduplicate use of a constant valueLioncash1-1/+1
We've already given the constant to the vector itself, so we don't need to re-hardcode it in the array.
2018-12-05system_archive: Use a regular function pointer instead of std::function for file-scope system archive arrayLioncash1-3/+2
This allows the array to be constexpr. std::function is also allowed to allocate memory, which makes its constructor non-trivial, we definitely don't want to have all of these execute at runtime, taking up time before the application can actually load.
2018-12-05service/ldr: Deduplicate instruction cache clearing code in LoadNro()Lioncash1-8/+2
We don't need to specify all of the ARM interfaces explicitly.
2018-12-05service/ldr: Amend layout of the NRO headerLioncash1-3/+3
The first word is just a padding byte, it's not an actual entry instruction. Also renames the rest of the entries according to SwitchBrew.
2018-12-05gl_shader_decompiler: Implement TEXS.F16ReinUsesLisp2-13/+51
2018-12-05service/ldr: Corrent padding within the NRR header layoutLioncash1-1/+2
The padding after the magic signature value should be 12 bytes rather than 28 bytes. The other 16 should be placed after the title ID pattern.
2018-12-05gl_shader_decompiler: Fixup inverted ifReinUsesLisp1-6/+5
2018-12-05svc: Avoid incorrect fast yield conditionZach Hilman1-6/+1
2018-12-05kernel/svc: Correct behavior of svcResetSignal()Lioncash1-4/+11
While partially correct, this service call allows the retrieved event to be null, as it also uses the same handle to check if it was referring to a Process instance. The previous two changes put the necessary machinery in place to allow for this, so we can simply call those member functions here and be done with it.
2018-12-05kernel/process: Make Process a WaitObjectLioncash3-6/+68
Process instances can be waited upon for state changes. This is also utilized by svcResetSignal, which will be modified in an upcoming change. This simply puts all of the WaitObject related machinery in place.
2018-12-05kernel/readable_event: Add member function for enforcing a strict reset contractLioncash2-1/+22
svcResetSignal relies on the event instance to have already been signaled before attempting to reset it. If this isn't the case, then an error code has to be returned.
2018-12-05Improve msvc codegen for hot-path array LUTsheapo1-275/+277
In some constexpr functions, msvc is building the LUT at runtime (pushing each element onto the stack) out of an abundance of caution. Moving the arrays into be file-scoped constexpr's avoids this and turns the functions into simple look-ups as intended.
2018-12-05yuzu/game_list_worker: Move std::string construction after the termination check in callbacksLioncash1-7/+7
Avoids potentially allocating a std::string instance when it isn't needed.
2018-12-04kernel/svc: Remove unused header inclusionLioncash1-1/+0
2018-12-04kernel/svc: Implement svcSignalEvent()Lioncash1-1/+16
This function simply does a handle table lookup for a writable event instance identified by the given handle value. If a writable event cannot be found for the given handle, then an invalid handle error is returned. If a writable event is found, then it simply signals the event, as one would expect.
2018-12-04kernel/svc: Implement svcCreateEvent()Lioncash2-1/+42
svcCreateEvent operates by creating both a readable and writable event and then attempts to add both to the current process' handle table. If adding either of the events to the handle table fails, then the relevant error from the handle table is returned. If adding the readable event after the writable event to the table fails, then the writable event is removed from the handle table and the relevant error from the handle table is returned. Note that since we do not currently test resource limits, we don't check the resource limit table yet.
2018-12-04qt: Add Properties menu to game list right-clickZach Hilman9-22/+54
2018-12-04Rewrited TEX/TEXS (TEX Scalar). (#1826)Marcos1-259/+177
* Rewrited TEX/TEXS (TEX Scalar). * Style fixes. * Styles issues.
2018-12-04debugger: Set paused thread colorLuke Street1-1/+2
2018-12-04kernel/object: Amend handle types to distinguish between readable and writable eventsLioncash6-11/+20
Two kernel object should absolutely never have the same handle ID type. This can cause incorrect behavior when it comes to retrieving object types from the handle table. In this case it allows converting a WritableEvent into a ReadableEvent and vice-versa, which is undefined behavior, since the object types are not the same. This also corrects ClearEvent() to check both kernel types like the kernel itself does.
2018-12-04kernel/handle_table: Amend reference to CTR-OS in Create()Lioncash1-2/+3
Another hold-over from Citra.
2018-12-04kernel/svc: Implement the resource limit svcGetInfo optionLioncash4-9/+34
Allows a process to register the resource limit as part of its handle table.
2018-12-04svc: Implement SetThreadActivity (thread suspension)Luke Street5-6/+76
2018-12-04Removed unused file.Subv1-142/+0
This is a leftover from #1792
2018-12-04GPU: Don't try to route PFIFO methods (0-0x40) to the other engines.Subv1-0/+6
2018-12-04[Kernel::CreateThread] Match format specifiers to LOG_TRACE's argumentsV.Kalyuzhny1-1/+1
2018-12-04scheduler: Avoid manual Reschedule callZach Hilman2-11/+11
This will automatically occur anyway when PrepareReschedule is called
2018-12-03scheduler: Only work steal higher priority threads from other coresZach Hilman3-35/+24
2018-12-03applets: Correct event ResetTypes from OneShot to StickyZach Hilman5-14/+6
Fixes bugs relating to signalling in software keyboard.
2018-12-03qt: Implement GUI dialog frontend for ProfileSelectorZach Hilman6-0/+269
Presents profiles in a list, similar to switch.
2018-12-03am: Use ProfileSelect appletZach Hilman1-0/+4
2018-12-03applets: Implement ProfileSelect appletZach Hilman2-0/+130
Allows the player to select an emulated profile.
2018-12-03qt: Register to use Qt ProfileSelector instead of defaultZach Hilman1-0/+2
2018-12-03core: Add getter/setter for ProfileSelector in SystemZach Hilman2-0/+16
2018-12-03frontend: Add frontend applet for ProfileSelectZach Hilman3-0/+48
Responsible for selecting a profile and firing callback upon completion.
2018-12-03software_keyboard: Signal state changed event upon constructionZach Hilman1-1/+6
Previously, ILibraryAppletAccessor would signal upon creation of any applet, but this is incorrect. A flag inside of the applet code determines whether or not creation should signal state change and swkbd happens to be one of these applets.
2018-12-03qt: Add UI to display game properties and disable add-onsZach Hilman4-0/+501
2018-12-03loader: Add support for reading the name of game's developerZach Hilman5-0/+26
2018-12-03aoc_u: Obey disabled add-ons list when listing DLCZach Hilman1-0/+12
2018-12-03patch_manager: Obey disabled add-ons list when patching gameZach Hilman2-11/+50
2018-12-03core: Make GetGameFileFromPath function externally accessibleZach Hilman2-3/+9
2018-12-03config: Store and load disabled add-ons listZach Hilman3-0/+55
2018-12-03settings: Store list of disabled add-ons per title IDZach Hilman1-0/+5
2018-12-03game_list: Remove a reference of a referenceFrederic Laing1-2/+2
2018-12-03Moved backtrace to ArmInterfaceDavid Marcec6-14/+39
Added to both dynarmic and unicorn
2018-12-03Print backtrace on svcBreakDavid Marcec3-0/+24
When we get an svcBreak we get a backtrace now
2018-12-03loader/nso: Remove dependency on the System classLioncash3-8/+11
Similar to the NRO changes, we can also pass the process explicitly as a parameter from Load instead of indirecting through the System class.
2018-12-03loader/nro: Make the static LoadNro function internally linkedLioncash2-7/+5
This simply acts as a forwarding function for the Load() function, so this doesn't need to be directly exposed.
2018-12-03file_sys/directory: Amend path buffer size for directory entriesLioncash1-2/+2
The path buffer is actually 0x301 (769) characters in length, with the extra character being intended for the null-terminator.
2018-12-03loader/nro: Remove dependency on the System classLioncash2-10/+13
Load() is already given the process instance as a parameter, so instead of coupling the class to the System class, we can just forward that parameter to LoadNro()
2018-12-02service/usb: Update function tableLioncash1-1/+1
Updates the function table for IClientEpSession based off information provided by SwitchBrew.
2018-12-02service/erpt: Update function tableLioncash1-5/+7
Updates the function table according to information provided by SwitchBrew.
2018-12-02yuzu/configuration: Make slots private where applicableLioncash5-7/+2
These slots are only ever attached to event handling mechanisms within the class itself, they're never used externally. Because of this, we can make the functions private. This also removes redundant usages of the private access specifier.
2018-12-02yuzu/configuration: Add missing override specifiers to configuration-related classesLioncash7-7/+7
Resolves trivial compiler warnings.
2018-12-02yuzu/configuration/configure_input: Default destructor in the cpp fileLioncash2-0/+3
The previous code could potentially be a compilation issue waiting to occur, given we forward declare the type for a std::unique_ptr. If the complete definition of the forward declared type isn't visible in a translation unit that the class is used in, then it would fail to compile. Defaulting the destructor in a cpp file ensures the std::unique_ptr's destructor is only invoked where its complete type is known.
2018-12-02Fixed crash with SetNpadModeDavid Marcec1-2/+3
fixed crash due to handheld
2018-12-02svc: Use the current process' handle table for retrieving the process instance to act uponLioncash1-1/+2
The kernel uses the handle table of the current process to retrieve the process that should be used to retrieve certain information. To someone not familiar with the kernel, this might raise the question of "Ok, sounds nice, but doesn't this make it impossible to retrieve information about the current process?". No, it doesn't, because HandleTable instances in the kernel have the notion of a "pseudo-handle", where certain values allow the kernel to lookup objects outside of a given handle table. Currently, there's only a pseudo-handle for the current process (0xFFFF8001) and a pseudo-handle for the current thread (0xFFFF8000), so to retrieve the current process, one would just pass 0xFFFF8001 into svcGetInfo. The lookup itself in the handle table would be something like: template <typename T> T* Lookup(Handle handle) { if (handle == PSEUDO_HANDLE_CURRENT_PROCESS) { return CurrentProcess(); } if (handle == PSUEDO_HANDLE_CURRENT_THREAD) { return CurrentThread(); } return static_cast<T*>(&objects[handle]); } which, as is shown, allows accessing the current process or current thread, even if those two objects aren't actually within the HandleTable instance.
2018-12-02svc: Reorganize svcGetInfo, handle more error cases for existing implemented info categoriesLioncash1-50/+99
Our implementation of svcGetInfo was slightly incorrect in that we weren't doing proper error checking everywhere. Instead, reorganize it to be similar to how the kernel seems to do it.
2018-12-02svc: Avoid performance-degrading unnecessary rescheduleZach Hilman2-8/+6
2018-12-02service/audio/audout_u: Amend constructor initialization list orderLioncash1-2/+2
Orders the constructor initializer list the same way the members of the class are declared. Prevents -Wreorder warnings
2018-12-02file_sys/registered_cache: Eliminate variable shadowingLioncash1-27/+26
Also inverts if statements where applicable to allow unindenting code a little bit.
2018-12-02filesystem: De-globalize registered_cache_unionLioncash8-40/+26
We can just return a new instance of this when it's requested. This only ever holds pointers to the existing registed caches, so it's not a large object. Plus, this also gets rid of the need to keep around a separate member function just to properly clear out the union. Gets rid of one of five globals in the filesystem code.
2018-12-02yuzu/game_list_worker: Deduplicate game list entry creationLioncash1-47/+33
Avoids duplicating the same code twice verbatim.
2018-12-02yuzu/game_list_worker: Tidy up string handling in FillControlMap()Lioncash1-6/+7
We don't need to call out to our own file handling functions when we're going to construct a QFileInfo instance right after it. We also don't need to convert to a std::string again just to compare the file extension.
2018-12-02crypto/key_manager: Remove unused variable in GetTicketblob()Lioncash1-1/+0
2018-12-01Fix debug buildLioncash2-5/+3
A non-existent parameter was left in some formatting calls (the logging macro for which only does anything meaningful on debug builds)
2018-12-01file_sys: Override missing mutating functions to be stubbed out for ReadOnlyVfsDirectory by defaultLioncash2-0/+25
Ensures that read only indeed means read only.
2018-12-01service/fsp_srv: Implement CleanDirectoryRecursivelyLioncash5-5/+72
This is the same behavior-wise as DeleteDirectoryRecursively, with the only difference being that it doesn't delete the top level directory in the hierarchy, so given: root_dir/ - some_dir/ - File.txt - OtherFile.txt The end result is just: root_dir/
2018-11-30remove border from GameListBartosz Kaszubowski1-0/+1
2018-11-30Services/VI: Dereferencing an uninitialized std::optional is undefined behavior.Subv1-0/+2
Assert that it is not empty before using it in the DequeueBuffer wait callback.
2018-11-30service/set: Convert GetLanguageCode over to using PushEnum()Lioncash1-1/+1
This code was around prior to the introduction of PushEnum, so convert it over so we don't need to cast here.
2018-11-30service/set: Implement MakeLanguageCodeLioncash2-1/+19
This function simply converts a given index into a language code.
2018-11-30configure_input: Amend clang-format discrepanciesLioncash1-1/+1
2018-11-30gl_rasterizer_cache: Update AccurateCopySurface to flush complete source surface.bunnei1-1/+4
- Fixes issues with Breath of the Wild with use_accurate_gpu_emulation setting.
2018-11-29gl_rasterizer: Enable clip distances when set in register and in shaderReinUsesLisp5-13/+37
2018-11-29gl_rasterizer: Implement a framebuffer cacheReinUsesLisp2-40/+82
2018-11-29gl_shader_manager: Update pipeline when programs have changedReinUsesLisp1-4/+17
2018-11-29hle_ipc: Refactor SleepClientThread to avoid ReadableEventZach Hilman9-14/+14
2018-11-29kernel/event: Reference ReadableEvent from WritableEventZach Hilman32-317/+175
2018-11-29core: Port all current usages of Event to Readable/WritableEventZach Hilman29-164/+287
2018-11-29hle_ipc: Use event pair for SleepClientThreadZach Hilman2-19/+22
2018-11-29kernel: Add named event tableZach Hilman2-0/+30
Used to store ReadableEvents of all events on the system.
2018-11-29kernel: Divide Event into ReadableEvent and WritableEventZach Hilman6-61/+210
More hardware accurate. On the actual system, there is a differentiation between the signaler and signalee, they form a client/server relationship much like ServerPort and ClientPort.
2018-11-29kernel/object: Add descriptions to ResetTypesZach Hilman1-3/+3
2018-11-29gl_rasterizer_cache: Remove BlitSurface and replace with more accurate copy.bunnei1-144/+1
- BlitSurface with different texture targets is inherently broken. - When target is the same, we can just use FastCopySurface. - Fixes rendering issues with Breath of the Wild.
2018-11-29gl_shader_decompiler: Remove texture temporal in TLD4ReinUsesLisp1-3/+1
2018-11-29gl_shader_decompiler: Flip negated if else statementReinUsesLisp1-3/+3
2018-11-29gl_shader_decompiler: Use GLSL scope on instructions unrelated to texturesReinUsesLisp1-35/+10
2018-11-29gl_shader_decompiler: Move texture code generation into lambdasReinUsesLisp1-97/+78
2018-11-29gl_shader_decompiler: Clean up texture instructionsReinUsesLisp1-87/+56
2018-11-29gl_shader_decompiler: Scope GLSL variables with a scoped objectReinUsesLisp1-32/+72
2018-11-29gl_rasterizer: Signal UNIMPLEMENTED when rt_separate_frag_data is not zeroReinUsesLisp1-1/+1
2018-11-29gl_rasterizer_cache: Use brackets for two-line single-expresion blocksReinUsesLisp1-1/+2
2018-11-29gl_rasterizer: Remove unused struct declarationsReinUsesLisp1-14/+0
2018-11-29gl_rasterizer: Remove extension booleansReinUsesLisp4-16/+4
2018-11-28npad: Use NPadIdToIndex to prevent invalid array accessZach Hilman1-2/+2
2018-11-28dma_pushbuffer: Optimize to avoid loop and copy on Push.bunnei3-13/+23
2018-11-28gpu: Move command list profiling to DmaPusher::DispatchCalls.bunnei2-5/+5
2018-11-27npad: Fix copy/paste error with LED position assignmentsZach Hilman1-3/+3
2018-11-27yuzu/configure_input_player: Use std::size_t to represent the player index instead of u8Lioncash2-3/+3
Prevents compiler warnings related to truncation when invoking the dialog. It's also extremely suspect to use a u8 value here instead of a more general type to begin with.
2018-11-27yuzu/configure_input: Make CallConfigureDialog a non-member template functionLioncash3-21/+20
This doesn't depend on any part of the private interface, so it can be made a non-member internal function.
2018-11-27file_sys/registered_cache: Remove unused <map> includeLioncash1-1/+0
2018-11-27file_sys/registered_cache: Use regular const references instead of std::shared_ptr for InstallEntry()Lioncash3-32/+31
These parameters don't need to utilize a shared lifecycle directly in the interface. Instead, the caller should provide a regular reference for the function to use. This also allows the type system to flag attempts to pass nullptr and makes it more generic, since it can now be used in contexts where a shared_ptr isn't being used (in other words, we don't constrain the usage of the interface to a particular mode of memory management).
2018-11-27gl_shader_decompiler: Fixup clip distance indexReinUsesLisp1-1/+1
2018-11-27control_metadata: Correct typo in language name (Portugese -> Portuguese)Lioncash1-7/+17
While we're at it, organize the array linearly, since clang formats the array elements quite wide length-wise with the addition of the missing 'u'. Technically also fixes patch lookup and icon lookup with Portuguese, though I doubt anyone has actually run into this issue.
2018-11-27yuzu/configure_input_player: Use a lambda expression instead of std::bindLioncash1-1/+1
std::bind is the pre-C++11 way of doing this.
2018-11-27yuzu/configure_input_player: Amend constructor initializer list orderLioncash1-4/+3
Orders the elements the way they would actually be initialized in. Resolves compiler warnings with gcc and clang
2018-11-27yuzu/configure_input: Remove unused function MoveGridElementLioncash1-7/+0
2018-11-27yuzu/configure_input*: Move data members after function declarationsLioncash2-41/+42
The common pattern is to put the data members after the function interface where applicable.
2018-11-27yuzu/configure_input: Remove unnecessary includesLioncash3-17/+3
2018-11-27gl_rasterizer: Fixup for #1723.Markus Wick1-1/+1
On invalidating the streaming buffer, we need to reupload all vertex buffers. But we don't need to reconfigure the vertex format. This was a (silly) misstake in #1723. Thanks at Rodrigo for discovering the issue. Fun fact, as configuring the vertex format also invalidate the vertex buffer, this misstake had no affect on the behavior.
2018-11-27gpu: Rewrite GPU command list processing with DmaPusher class.bunnei18-108/+353
- More accurate impl., fixes Undertale (among other games).
2018-11-27remove viewport_transform_enabled as it seems to be inactive when valid transforms are used.Rodolfo Bogado1-12/+5
2018-11-27svc: Implement svcSetResourceLimitLimitValue()Lioncash1-1/+36
The opposite of the getter functions, this function sets the limit value for a particular ResourceLimit resource category, with the restriction that the new limit value must be equal to or greater than the current resource value. If this is violated, then ERR_INVALID_STATE is returned. e.g. Assume: current[Events] = 10; limit[Events] = 20; a call to this service function lowering the limit value to 10 would be fine, however, attempting to lower it to 9 in this case would cause an invalid state error.
2018-11-27svc: Implement svcGetResourceLimitCurrentValue()Lioncash1-16/+49
This kernel service function is essentially the exact same as svcGetResourceLimitLimitValue(), with the only difference being that it retrieves the current value for a given resource category using the provided resource limit handle, rather than retrieving the limiting value of that resource limit instance. Given these are exactly the same and only differ on returned values, we can extract the existing code for svcGetResourceLimitLimitValue() to handle both values.
2018-11-27morton: Fixup compiler warningReinUsesLisp1-1/+2
2018-11-27svc: Implement svcGetResourceLimitLimitValue()Lioncash2-2/+33
This kernel service function retrieves the maximum allowable value for a provided resource category for a given resource limit instance. Given we already have the functionality added to the resource limit instance itself, it's sufficient to just hook it up. The error scenarios for this are: 1. If an invalid resource category type is provided, then ERR_INVALID_ENUM is returned. 2. If an invalid handle is provided, then ERR_INVALID_HANDLE is returned (bad thing goes in, bad thing goes out, as one would expect). If neither of the above error cases occur, then the out parameter is provided with the maximum limit value for the given category and success is returned.
2018-11-27svc: Implement svcCreateResourceLimit()Lioncash2-1/+27
This function simply creates a ResourceLimit instance and attempts to create a handle for it within the current process' handle table. If the kernal fails to either create the ResourceLimit instance or create a handle for the ResourceLimit instance, it returns a failure code (OUT_OF_RESOURCE, and HANDLE_TABLE_FULL respectively). Finally, it exits by providing the output parameter with the handle value for the ResourceLimit instance and returning that it was successful. Note: We do not return OUT_OF_RESOURCE because, if yuzu runs out of available memory, then new will currently throw. We *could* allocate the kernel instance with std::nothrow, however this would be inconsistent with how all other kernel objects are currently allocated.
2018-11-27Added comment on Main memory size for more clarityDavid Marcec1-0/+1
2018-11-27Made svcSetHeapSize and svcCreateSharedMemory more readableDavid Marcec1-4/+4
2018-11-27Reworked svcs slightly, improved error messages in AM and fsp_srvDavid Marcec3-20/+30
2018-11-27gdbstub: Silence value truncation warning within FpuWrite()Lioncash1-1/+1
Previously this would cause an implicit truncation warning about assigning a u64 value to a u32 value without an explicit cast.
2018-11-27Implement depth clampRodolfo Bogado5-10/+58
2018-11-27Add support for Clip Distance enabled registerRodolfo Bogado3-3/+26
2018-11-27GPU States: Implement Polygon Offset. This is used in SMO all the time. (#1784)Marcos5-5/+107
* GPU States: Implement Polygon Offset. This is used in SMO all the time. * Clang Format fixes. * Initialize polygon_offset in the constructor.
2018-11-26profile_manager: Save and load ProfileData from diskZach Hilman3-17/+19
The ProfileData is a 0x80-sized structure that stores various pieces of miscellaneous data for the account.
2018-11-26Implemented Tile Width SpacingFernandoS278-36/+55
2018-11-26Fixed hwopus compile errorDavid Marcec1-1/+1
2018-11-26Improved error messages in AM, HwOpus and NvMapDavid Marcec3-26/+39
2018-11-26Improved error messages for SVCsDavid Marcec1-76/+170
2018-11-26Changed logging to be "Log before execution", Added more error logging, all services should now log on some levelDavid Marcec51-374/+726
2018-11-25svc: Return ERR_INVALID_ENUM_VALUE from svcGetInfoLuke Street1-1/+2
2018-11-25Limit the amount of viewports tested for state changes only to the usable onesRodolfo Bogado1-2/+10
2018-11-25gl_shader_decompiler: Implement S2R's Y_DIRECTIONReinUsesLisp5-16/+26
2018-11-25morton: Style changesReinUsesLisp1-12/+12
2018-11-25video_core: Move morton functions to their own fileReinUsesLisp6-345/+391
2018-11-24Fix Texture OverlappingFernandoS271-43/+70
2018-11-24Implemented BRA CC conditional and FSET CC SettingFernandoS271-4/+14
2018-11-24Add support for viewport_transfom_enable registerRodolfo Bogado2-6/+22
2018-11-24service/sm: Take std::string by const reference in UnregisterServiceLioncash2-2/+2
Avoids the need to create a copy of the std::string instance (potentially allocating). The only reason RegisterService takes its argument by value is because it's std::moved internally.
2018-11-24nvdrv: Implement/stub DumpGraphicsMemoryInfo and GetStatus.bunnei2-2/+18
- Used by Undertale.
2018-11-24Add support for clear_flags registerRodolfo Bogado5-28/+95
2018-11-24Fix TEXS Instruction encodingsFernandoS271-22/+48
2018-11-24Fix one encoding in TEX InstructionFernandoS271-3/+3
2018-11-24Corrected inputs indexing in TEX instructionFernandoS271-66/+85
2018-11-23memory_manager: Do not allow 0 to be a valid GPUVAddr.bunnei2-1/+9
- Fixes a bug with Undertale using 0 for a render target.
2018-11-23Added predicate comparison LessEqualWithNan (#1736)Hexagon122-5/+13
* Added predicate comparison LessEqualWithNan * oops * Clang fix
2018-11-23gl_shader_decompiler: Implement clip distancesReinUsesLisp3-21/+58
2018-11-23file_sys: Implement system archive synthesizer for NgWord (806)Zach Hilman5-6/+61
2018-11-22am: Return StubApplet instead of nullptr when AppletId not foundZach Hilman3-11/+11
2018-11-22gl_shader_decompiler: Add a message for unimplemented cc generationReinUsesLisp1-23/+46
2018-11-22correct clang-formatgreggameplayer1-1/+1
2018-11-22debug_pad: Avoid loading input for nonexistent buttons (Home and Screenshot)Zach Hilman1-2/+3
Prevents memory exceptions when the debug pad is enabled.
2018-11-22core: Relocate CPU core management to its own classLioncash4-97/+225
Keeps the CPU-specific behavior from being spread throughout the main System class. This will also act as the home to contain member functions that perform operations on all cores. The reason for this being that the following pattern is sort of prevalent throughout sections of the codebase: If clearing the instruction cache for all 4 cores is necessary: Core::System::GetInstance().ArmInterface(0).ClearInstructionCache(); Core::System::GetInstance().ArmInterface(1).ClearInstructionCache(); Core::System::GetInstance().ArmInterface(2).ClearInstructionCache(); Core::System::GetInstance().ArmInterface(3).ClearInstructionCache(); This is kind of... well, silly to copy around whenever it's needed. especially when it can be reduced down to a single line. This change also puts the basics in place to begin "ungrafting" all of the forwarding member functions from the System class that are used to access CPU state or invoke CPU-specific behavior. As such, this change itself makes no changes to the direct external interface of System. This will be covered by another changeset.
2018-11-22macro_interpreter: Implement AddWithCarry and SubtractWithBorrow.bunnei2-8/+25
- Used by Undertale.
2018-11-22audout_u: Add support for multiple IAudioOut streams.bunnei2-9/+22
- Used by Undertale.
2018-11-22maxwell_3d: Implement alternate blend equations.bunnei2-0/+12
- Used by Undertale.
2018-11-22common/thread: Drop Hungarian notation on SetCurrentThreadName's parameterLioncash1-7/+7
This is inconsistent with our coding style.
2018-11-22scheduler: Add explanations for YieldWith and WithoutLoadBalancingZach Hilman6-79/+141
2018-11-22common/thread: Make Barrier's 'count' member non-constLioncash1-1/+1
While admirable as a means to ensure immutability, this has the unfortunate downside of making the class non-movable. std::move cannot actually perform a move operation if the provided operand has const data members (std::move acts as an operation to "slide" resources out of an object instance). Given Barrier contains move-only types such as std::mutex, this can lead to confusing error messages if an object ever contained a Barrier instance and said object was attempted to be moved.
2018-11-22common/thread: Initialize class member variables where applicableLioncash1-6/+4
Simplifies the constructor interfaces for Barrier and Event classes.
2018-11-22common/thread: Group non-member functions togetherLioncash1-3/+2
Keeps the non-member interface in one spot instead of split into two places, making it nicer to locate functions.
2018-11-22common/thread: Remove SleepCurrentThread()Lioncash2-12/+0
This is also unused and superceded by standard functionality. The standard library provides std::this_thread::sleep_for(), which provides a much more flexible interface, as different time units can be used with it.
2018-11-22common/thread: Remove unused CurrentThreadId()Lioncash2-12/+0
This is an old function that's no longer necessary. C++11 introduced proper threading support to the language and a thread ID can be retrieved via std::this_thread::get_id() if it's ever needed.
2018-11-22common: Remove bit_set.hLioncash2-245/+0
This is an analog of BitSet from Dolphin that was introduced to allow iterating over a set of bits. Given it's currently unused, and given that std::bitset exists, we can remove this. If it's ever needed in the future it can be brought back.
2018-11-22applets: Add StubAppletZach Hilman3-0/+98
This will log all data it receives, log all calls to its methods and push dummy data into both channels on execution.
2018-11-22gl_shader_decompiler: Rename internal flag stringsReinUsesLisp1-15/+20
2018-11-22gl_shader_decompiler: Rename control codes to condition codesReinUsesLisp2-67/+50
2018-11-22Automatically disable joycons dockedgreggameplayer1-0/+4
when docked mode is enable
2018-11-22gl_shader_decompiler: Fix register overwriting on texture callsReinUsesLisp1-60/+78
2018-11-22kernel/handle_table: Move private static functions into the cpp fileLioncash2-7/+9
These don't depend on class state, and are effectively implementation details, so they can go into the cpp file .
2018-11-22kernel/handle_table: Restrict handle table size to 1024 entriesLioncash1-5/+2
The previous handle table size is a holdover from Citra. The actual handle table construct on Horizon only allows for a maximum of 1024 entries.
2018-11-22kernel/handle_table: Default destructor in the cpp fileLioncash2-0/+3
We don't need to potentially inline the teardown logic of all of the handle instances.
2018-11-21Properly Implemented TXQ InstructionFernandoS271-2/+12
2018-11-21gl_shader_decompiler: Implement BFI_IMM_RReinUsesLisp2-0/+23
2018-11-21nvhost_ctrl_gpu: Implement IoctlGetGpuTime.bunnei2-0/+19
- Used by Undertale.
2018-11-21Removed pre 4.3 ARB extensionsFernandoS277-48/+13
2018-11-21Update OpenGL's backend version from 3.3 to 4.3FernandoS273-4/+4
2018-11-21Use default values for unknown framebuffer pixel formatFernandoS272-0/+8
2018-11-21common: Remove dependency on xbyakLioncash3-274/+0
Xbyak is currently entirely unused. Rather than carting it along, remove it and get rid of a dependency. If it's ever needed in the future, then it can be re-added (and likely be more up to date at that point in time).
2018-11-21gl_shader_decompiler: Implement R2P_IMMReinUsesLisp2-0/+42
2018-11-21common/math_util: Simplify std::make_signed usages to std::make_signed_tLioncash1-2/+2
Gets rid of the need to use typename to access the ::type alias.
2018-11-21common/math_util: Make Rectangle's constructors constexprLioncash1-2/+2
Allows objects that contain rectangle instances to be constexpr constructible as well.
2018-11-21common/math_util: Remove unnecessary static from PILioncash1-1/+1
const/constexpr variables have internal linkage by default.
2018-11-21common/math_util: Remove unused IntervalsIntersect() functionLioncash1-6/+0
This hasn't been used since the project started, so we may as well get rid of it to keep it from bit rotting.
2018-11-21gl_shader_decompiler: Remove UNREACHABLE when setting RZReinUsesLisp1-2/+1
2018-11-21gl_shader_decompiler: Use UNIMPLEMENTED instead of LOG+UNREACHABLE when applicableReinUsesLisp1-371/+258
2018-11-21maxwell_3d: Initialize rasterizer color mask registers as enabled.bunnei1-0/+9
- Fixes rendering regression with Sonic Mania.
2018-11-21am: Correct build failureLioncash1-2/+2
The interface for shared memory was changed, but another commit was merged that relied on the (previously public) internals of SharedMemory. This amends that discrepancy.
2018-11-21patch_manager: Show LayeredExeFS patch in add-ons columnZach Hilman2-4/+15
The decision was made to name them LayeredExeFS instead of just LayeredFS to differentiate from normal RomFS-based mods. The name may be long/unweildy, but conveys the meaning well.
2018-11-21file_sys/card_image: Provide named members for the GamecardInfo structLioncash1-1/+12
Fills out the struct according to information provided by SwitchBrew
2018-11-21common/assert: Add UNIMPLEMENTED_IF and UNIMPLEMENTED_IF_MSG for conditional assertionsLioncash1-0/+3
Currently, there's no way to specify if an assertion should conditionally occur due to unimplemented behavior. This is useful when something is only partially implemented (e.g. due to ongoing RE work). In particular, this would be useful within the graphics code. The rationale behind this is it allows a dev to disable unimplemented feature assertions (which can occur in an unrelated work area), while still enabling regular assertions, which act as behavior guards for conditions or states which must not occur. Previously, the only way a dev could temporarily disable asserts, was to disable the regular assertion macros, which has the downside of also disabling, well, the regular assertions which hold more sanitizing value, as opposed to unimplemented feature assertions.
2018-11-20common/assert: Make the UNIMPLEMENTED macro properly assertLioncash1-1/+1
Currently, this was only performing a logging call, which doesn't actually invoke any assertion behavior. This is unlike UNIMPLEMENTED_MSG, which *does* assert. This makes the expected behavior uniform across both macros.
2018-11-20patch_manager: Apply LayeredExeFS patchesZach Hilman1-0/+25
This will scan the <mod>/exefs dir for all files and then layer those on top of the game's exefs and use this as the new exefs. This allows for overriding of the compressed NSOs or adding new files. This does use the same dir as IPS/IPSwitch patch, but since the loader will not look for those they are ignored.
2018-11-20settings: Add option to dump ExeFS of games upon launchZach Hilman7-0/+27
When enabled, all exefs(es) will be copied to yuzu/dump/<title_id>/exefs.
2018-11-20kernel/process: Move <random> include to the cpp fileLioncash2-1/+1
<random> isn't necesary directly within the header and can be placed in the cpp file where its needed. Avoids propagating random generation utilities via a header file.
2018-11-20shader_cache: Only lock covered instructions.Markus Wick4-8/+24
2018-11-20am/applets: Make the applet data broker part of the applet itself.Lioncash5-31/+36
The accessor should be doing just that, accessing, rather than retaining the lifetime of the data broker as well.
2018-11-20am/applets: Replace includes with forward declarations where applicableLioncash2-2/+9
Also resolve places where includes should have been provided, but weren't.
2018-11-20am/applets: Relocate comments above the relevant data member in AppletDataBrokerLioncash1-11/+18
Avoids wonky wrapping and makes it nicer to read.
2018-11-20yuzu/applets/software_keyboard: Override accept() and reject() instead of providing own differently named member functionsLioncash2-8/+8
Uses Qt's built-in interface instead of rolling our own separate one on top of it. This also fixes a bug in reject() where we were calling accept() instead of reject().
2018-11-20yuzu/applets/software_keyboard: std::move std::function instances where applicableLioncash1-2/+2
std::function instances can potentially allocate. std::moveing them prevents an avoidable allocation in that case.
2018-11-20yuzu/applets/software_keyboard: Make slots private functionsLioncash1-2/+1
These aren't required to be public.
2018-11-20Implemented Fast Layered CopyFernandoS272-2/+30
2018-11-20kernel/resource_limit: Clean up interfaceLioncash6-190/+81
Cleans out the citra/3DS-specific implementation details that don't apply to the Switch. Sets the stage for implementing ResourceLimit instances properly. While we're at it, remove the erroneous checks within CreateThread() and SetThreadPriority(). While these are indeed checked in some capacity, they are not checked via a ResourceLimit instance. In the process of moving out Citra-specifics, this also replaces the system ResourceLimit instance's values with ones from the Switch.
2018-11-20lm: Implement SetDestination by doing nothingLioncash1-1/+12
This service function was likely intended to be a way to redirect where the output of a log went. e.g. Firing a log over a network, dumping over a tunneling session, etc. Given we always want to see the log and not change its output. It's one of the lucky service functions where the easiest implementation is to just do nothing at all and return success.
2018-11-19software_keyboard: Fix erroneous extra PushNormalDataZach Hilman1-3/+2
2018-11-19software_keyboard: Return correct result code on user cancel operationZach Hilman3-5/+1
2018-11-19applet: Add AppletDataBroker to manage HLE to AM service interactionZach Hilman5-104/+194
This cleans up most of the callbacks and such in the Applets::Applet interface, while also properly implementing all four data channels.
2018-11-19software_keyboard: Use correct offset for inital text stringZach Hilman1-1/+2
2018-11-19kernel/shared_memory: Make Map() and Unmap() take the target process by reference rather than as a pointerLioncash3-12/+12
Both member functions assume the passed in target process will not be null. Instead of making this assumption implicit, we can change the functions to be references and enforce this at the type-system level.
2018-11-19kernel/shared_memory: Add a const qualified member function overload for GetPointer()Lioncash2-1/+12
Given this doesn't mutate instance state, we can provide a const-qualified variant as well.
2018-11-19kernel/shared_memory: Use 64-bit types for offset and size in CreateForAppletLioncash2-2/+2
Keeps the interface consistent with the regular Create() function.
2018-11-19kernel/shared_memory: Make GetPointer() take a std::size_t instead of a u32Lioncash2-2/+2
Makes the interface nicer to use in terms of 64-bit code, as it makes it less likely for one to get truncation warnings (and also makes sense in the context of the rest of the interface where 64-bit types are used for sizes and offsets
2018-11-19kernel/shared_memory: Make data members privateLioncash1-12/+17
Rather than allow unfettered access to the class internals, we hide all members by default and create and API that other code can operate against.
2018-11-19ldr: Clean up error codesLioncash1-29/+12
The separate enum isn't particularly necessary here, and the values can just be directly put into the ResultCode instances, given the names are also self-documenting here.
2018-11-19svc: Implement yield types 0 and -1Zach Hilman6-2/+130
2018-11-19filesystem: Clear registered union paths on factory creationZach Hilman2-0/+6
2018-11-19configure_input: Use Joycons Docked instead of Connected as labelZach Hilman1-1/+1
2018-11-19configure_input_player: Set minimum width on controlsZach Hilman2-23/+30
2018-11-19configure_input: Properly update UI components on removal of playerZach Hilman1-0/+2
2018-11-19configure_input: Make None a controller option instead of checkboxZach Hilman11-152/+148
2018-11-19hid: Use player-defined controller type as PREFERRED_CONTROLLERZach Hilman16-296/+234
2018-11-19qt: Move controller button config to separate dialogZach Hilman4-0/+1767
Handles button configuration for all controller layouts and debug pads. Configurable at construction.
2018-11-19qt: Add UI to configure touchscreen parametersZach Hilman4-0/+281
This allows adjusting the finger, diameter, and angle of the emulated touchscreen. It also provides a warning to the user about what changing these parameters can do.
2018-11-19qt: Add UI to configure mouse buttonsZach Hilman4-0/+542
Supports setting the five mouse buttons to any valid controller button/keyboard key (Left, Right, Middle, Foward, Back)
2018-11-19configure_input: Add support for multiplayer and controller typesZach Hilman3-998/+525
This moves the actual button configuration to a separate dialog and only has the enabled and type controls in the tab.
2018-11-19hid/npad: Update NPad to use player controller bindings and typeZach Hilman2-55/+108
2018-11-19hid/touchscreen: Update Touchscreen to use advanced parametersZach Hilman1-6/+6
Including finger ID, diamater x/y, and angle. Additionally, checks if the touchscreen is enabled.
2018-11-19hid: Add controller bindings for Mouse controllerZach Hilman2-4/+30
2018-11-19hid: Add keyboard bindings for Keyboard controllerZach Hilman2-2/+24
2018-11-19hid: Add controller bindings for DebugPad controllerZach Hilman2-21/+43
Used by developers to test games, not present on retail systems. Some games are known to respond to DebugPad input though, for example Kirby Star Allies.
2018-11-19yuzu/config: Add (de-)serialization for multiplayerZach Hilman2-21/+331
Defaults to full keyboard for keyboard -- It did not seem to be necessary to make the keyboard configurable (besides enabled/disabled).
2018-11-19yuzu_cmd/config: Add config deserialization for multiplayerZach Hilman1-37/+254
2018-11-19settings: Add settings for multiple players and controllersZach Hilman1-3/+48
Uses the PlayerInput struct to represent all of the data that constitutes a player.
2018-11-19settings: Add Native type for keyboardZach Hilman1-0/+210
2018-11-19settings: Add Native type for mouse buttonsZach Hilman2-0/+34
2018-11-19Added missing start/end touch attributes to touchscreenDavid Marcec2-1/+18
2018-11-19Added debugpad skeletonDavid Marcec2-2/+55
2018-11-19Added controller helper funcsDavid Marcec2-0/+35
2018-11-19Changed polling rate of hid and Right joycon rotationDavid Marcec1-2/+2
2018-11-19Left joycon rotation button remappingDavid Marcec2-7/+21
2018-11-19Added automatic npad switch based on supported stylesetsDavid Marcec2-4/+124
2018-11-19Added multi-input support and controller assignment at any portDavid Marcec2-122/+181
2018-11-19Removed hard coded values for width and heightDavid Marcec1-2/+4
2018-11-19software_keyboard: Check for UTF-8 config flagZach Hilman2-9/+23
2018-11-19Eliminated unnessessary memory allocation and copy (#1702)Frederic L3-9/+20
2018-11-19Correctly sets default system language for yuzu-CLI (#1727)Schplee1-0/+2
* Correctly sets default system language for yuzu-CLI A user reported that yuzu_cmd runs games in Japanese rather than the correct default of English (like yuzu-qt does correctly), this change fixes that. * fix clang issue deleted whitespace
2018-11-19gl_rasterizer: Remove default clip distanceReinUsesLisp1-2/+0
2018-11-18svc: ResetSignal is not stubbedTobias1-1/+1
https://user-images.githubusercontent.com/20753089/48677874-b8e01c80-eb7b-11e8-8043-b99faa29022c.PNG
2018-11-18software_keyboard: Add max and current length display to dialogZach Hilman2-1/+11
2018-11-18software_keyboard: Push all data over all channels on dialog completionZach Hilman1-18/+26
2018-11-18applet: Use std::queue instead of std::vector for storage stackZach Hilman5-18/+44
2018-11-18applet: Add operation completed callbackZach Hilman8-9/+34
2018-11-18software_keyboard: Push buffer size to offset 0x4 in output dataZach Hilman4-18/+39
2018-11-18software_keyboard: Make GetText asynchronousZach Hilman9-29/+64
a
2018-11-18am: Allow applets to push multiple and different channels of dataZach Hilman10-64/+62
2018-11-18am: Implement ILibraryAppletAccessor IsCompleted and GetResultZach Hilman2-4/+9
2018-11-18am: Implement text check software keyboard modeZach Hilman6-14/+120
Allows the game to verify and send a message to the frontend.
2018-11-18am: Deglobalize software keyboard appletZach Hilman17-100/+180
2018-11-18qt/main: Register Qt Software Keyboard frontend with AMZach Hilman3-0/+6
Allows using Qt provider over default.
2018-11-18am: Construct and use proper applets with ILibraryAppletAccessorZach Hilman1-1/+26
Allows use of software keyboard applet and future applets to be easily added by adding enum ID and a switch case.
2018-11-18qt/applets: Provide Qt frontend implementation of software keyboardZach Hilman3-0/+171
Implements all of the features of the keyboard, including length, default text, character validation, and UTF-16 character support.
2018-11-18am/applets: Add connector between frontend and AM applet classesZach Hilman3-0/+130
Provides a middleman between the Frontend provider class and the expected AM::Applets::Applet class needed by ILibraryAppletAccessor
2018-11-18frontend/applets: Add frontend software keyboard provider and defaultZach Hilman3-0/+63
Default implementation will return "yuzu" for any string. GUI clients (or CLI) can implement the Frontend::SoftwareKeyboardApplet class and register an instance to provide functionality.
2018-11-18am/applets: Add Applet superclass to describe a generic appletZach Hilman3-0/+77
Adds an Initialize and Execute methods which are used by the ILibraryAppletAccessor to start and control the applet.
2018-11-18am: Unstub ILibraryAppletAccessor::StartZach Hilman1-5/+17
Now starts the applet provided in constructor.
2018-11-18am: Implement PopInteractiveOutData and PushInteractiveInDataZach Hilman1-14/+24
Used by software keyboard applet for data transfer.
2018-11-18am: Convert storage stack to vectorZach Hilman1-27/+59
std::stack was no longer suitable for non-trivial operations
2018-11-18am: Move AM::IStorage to headerZach Hilman1-0/+16
Needs to be accessible by applet files.
2018-11-18am: Move IStorageAccessor to header and update backing bufferZach Hilman2-64/+62
Writes to an AM::IStorage object through an IStorageAccessor will now be preserved once the accessor is destroyed.
2018-11-18am: Implement CreateTransferMemoryStorageZach Hilman2-0/+26
Creates an AM::IStorage object with the contents of the transfer memory located at the handle provided.
2018-11-18string_util: Implement buffer to UTF-16 string helper functionZach Hilman2-0/+17
Needed as most all software keyboard functions use fixed-length UTF16 string buffers.
2018-11-18svc: Implement svcCreateTransferMemoryZach Hilman1-3/+33
Seems to be used and created identically to SharedMemory, so just reuse that.
2018-11-18drop support for non separate alpha as it seems to cause issues in some gamesRodolfo Bogado3-61/+35
2018-11-18ldr_ro: Add error check for memory allocation failureZach Hilman4-13/+27
2018-11-17fix sampler configuration, thanks to Marcos for his investigationRodolfo Bogado3-19/+57
2018-11-17small type fixRodolfo Bogado1-6/+6
2018-11-17small fix for alphaToOne bit locationRodolfo Bogado1-2/+2
2018-11-17fix for gcc compilationRodolfo Bogado1-60/+61
2018-11-17add AlphaToCoverage and AlphaToOneRodolfo Bogado5-1/+39
2018-11-17add support for fragment_color_clampRodolfo Bogado5-1/+24
2018-11-17add missing MirrorOnceBorder support where supportedRodolfo Bogado1-0/+6
2018-11-17set border color not depending on the wrap modeRodolfo Bogado1-9/+9
only enable color mask for the first framebuffer id independent blending is disabled
2018-11-17set default value for point size registerRodolfo Bogado2-5/+4
2018-11-17fix viewport and scissor behaviorRodolfo Bogado6-64/+89
2018-11-17vi: Implement TransactParcel for Disconnect and DetachBufferZach Hilman1-0/+22
Used by homebrew on exit. According to switchbrew, returns an empty response parcel with one zero in it.
2018-11-17Stubbed am:EnableApplicationCrashReportMysticExile2-10/+18
2018-11-17gl_rasterizer: Skip VB upload if the state is clean.Markus Wick9-6/+60
2018-11-17hwopus: DecodeInterleavedWithPerformance: Fix ordering of output parameters.bunnei1-1/+1
- Fixes audio issues with Pokemon: Let's Go Pikachu & Eevee.
2018-11-17Implemented CalculateStandardUserSystemClockDifferenceByUserDavid Marcec3-1/+18
Seems pokemon calls this sometimes and it caused "random crashes"
2018-11-17textures/decoders: Replace magic numbersFrederic Laing1-37/+33
2018-11-16kernel/errors: Clean up error codesLioncash2-62/+32
Similar to PR 1706, which cleans up the error codes for the filesystem code, but done for the kernel error codes. This removes the ErrCodes namespace and specifies the errors directly. This also fixes up any straggling lines of code that weren't using the named error codes where applicable.
2018-11-16Common/Bitfield: store value as unsigned typeWeiyi Wang1-9/+10
Storing signed type causes the following behaviour: extractValue can do overflow/negative left shift. Now it only relies on two implementation-defined behaviours (which are almost always defined as we want): unsigned->signed conversion and signed right shift
2018-11-16Added various bluetooth based cmds for palmaDavid Marcec2-1/+145
It seems palma is done through bluetooth, we need this for pokemon go however more research needs to be done when we actually get palma working. This is presumably used for transfering data between the controller and the console, it does not seem for actual input as far as I know.
2018-11-16Added SetIsPalmaAllConnectable, SetPalmaBoostModeDavid Marcec1-2/+14
Currently unclear what these do yet, will be researched at a later time when we want to implement palma.
2018-11-16Fixed switching operation modes when not running a gameDavid Marcec1-0/+3
The service manager seems to be a nullptr before a game boots
2018-11-16Report resolution scaling support for vi and amDavid Marcec3-60/+76
Specifying an internal resolution in yuzu now will report the scaled changes to vi and am.
2018-11-16file_sys/errors: Remove currently unused filesystem error codesLioncash1-10/+0
Rather than keeping around unused values, we can just introduce them as needed.
2018-11-16file_sys/errors: Get rid of the ErrCodes namespaceLioncash1-17/+5
There's no real point to keeping the separate enum around, especially given the name of the error code itself is supposed to document what the value actually represents.
2018-11-16file_sys/errors: Extract FS-related error codes to file_sys/errors.hLioncash4-14/+19
Keeps filesystem-related error codes in one spot.
2018-11-16Fixed priority switching edge case for handheld (#1675)David1-12/+46
* Fixed priority switching edge case for handheld We accidently used controller index instead of npad id * Moved NPadIdToIndex
2018-11-16fsp_srv: Add support for using open source archive if not found in NANDZach Hilman1-0/+10
2018-11-16file_sys: Add framework for synthesizing open source archivesZach Hilman3-0/+109
2018-11-16vfs_vector: Add VFS backend for std::arrayZach Hilman1-0/+52
Allows using constexpr/static const data with VFS.
2018-11-16csrng: Use random integer distribution instead of raw engineZach Hilman1-1/+2
Prevents returning the same value every single call.
2018-11-15textures/decoders: Minor cleanupFrederic Laing1-16/+16
2018-11-15gl_rasterizer_chache: Minor cleanupFrederic Laing1-3/+3
2018-11-15ldr_ro: Implement UnloadNro (command 1)Zach Hilman1-22/+85
Includes actual unmapping and address error checking.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 21:58:32 +0100