diff options
author | Kelvin Zhang <zhangkelvin@google.com> | 2020-06-26 17:06:00 +0200 |
---|---|---|
committer | Kelvin Zhang <zhangkelvin@google.com> | 2020-06-29 22:22:08 +0200 |
commit | e1ae78cd547d68192df7803a86bbffee6ed52703 (patch) | |
tree | db31bcae7f822837b313fb0cfe68b65cd07ce051 /install | |
parent | Merge "Track rename of adbd_system_binaries." (diff) | |
download | android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar.gz android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar.bz2 android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar.lz android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar.xz android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.tar.zst android_bootable_recovery-e1ae78cd547d68192df7803a86bbffee6ed52703.zip |
Diffstat (limited to 'install')
-rw-r--r-- | install/install.cpp | 26 |
1 files changed, 23 insertions, 3 deletions
diff --git a/install/install.cpp b/install/install.cpp index d404997dc..1c711f6b3 100644 --- a/install/install.cpp +++ b/install/install.cpp @@ -67,8 +67,11 @@ static_assert(kRecoveryApiVersion == RECOVERY_API_VERSION, "Mismatching recovery // Default allocation of progress bar segments to operations static constexpr int VERIFICATION_PROGRESS_TIME = 60; static constexpr float VERIFICATION_PROGRESS_FRACTION = 0.25; - +// The charater used to separate dynamic fingerprints. e.x. sargo|aosp-sargo +static const char* FINGERPRING_SEPARATOR = "|"; static std::condition_variable finish_log_temperature; +static bool isInStringList(const std::string& target_token, const std::string& str_list, + const std::string& deliminator); bool ReadMetadataFromPackage(ZipArchiveHandle zip, std::map<std::string, std::string>* metadata) { CHECK(metadata != nullptr); @@ -151,7 +154,8 @@ static bool CheckAbSpecificMetadata(const std::map<std::string, std::string>& me auto device_fingerprint = android::base::GetProperty("ro.build.fingerprint", ""); auto pkg_pre_build_fingerprint = get_value(metadata, "pre-build"); - if (!pkg_pre_build_fingerprint.empty() && pkg_pre_build_fingerprint != device_fingerprint) { + if (!pkg_pre_build_fingerprint.empty() && + !isInStringList(device_fingerprint, pkg_pre_build_fingerprint, FINGERPRING_SEPARATOR)) { LOG(ERROR) << "Package is for source build " << pkg_pre_build_fingerprint << " but expected " << device_fingerprint; return false; @@ -199,7 +203,8 @@ bool CheckPackageMetadata(const std::map<std::string, std::string>& metadata, Ot auto device = android::base::GetProperty("ro.product.device", ""); auto pkg_device = get_value(metadata, "pre-device"); - if (pkg_device != device || pkg_device.empty()) { + // device name can be a | separated list, so need to check + if (pkg_device.empty() || !isInStringList(device, pkg_device, FINGERPRING_SEPARATOR)) { LOG(ERROR) << "Package is for product " << pkg_device << " but expected " << device; return false; } @@ -699,3 +704,18 @@ bool SetupPackageMount(const std::string& package_path, bool* should_use_fuse) { } return true; } + +// Check if `target_token` is in string `str_list`, where `str_list` is expected to be a +// list delimited by `deliminator` +// E.X. isInStringList("a", "a|b|c|d", "|") => true +// E.X. isInStringList("abc", "abc", "|") => true +static bool isInStringList(const std::string& target_token, const std::string& str_list, + const std::string& deliminator) { + if (target_token.length() > str_list.length()) { + return false; + } else if (target_token.length() == str_list.length() || deliminator.length() == 0) { + return target_token == str_list; + } + auto&& list = android::base::Split(str_list, deliminator); + return std::find(list.begin(), list.end(), target_token) != list.end(); +} |