summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2018-09-07 01:19:35 +0200
committerGitHub <noreply@github.com>2018-09-07 01:19:35 +0200
commit9b50dca2bbabff87c78050372d992d088c897502 (patch)
treeca4e1c964c404a3ed7c85f93bdbfc198d5c587aa
parentMerge pull request #1255 from bunnei/minor-opt (diff)
parentgl_buffer_cache: Default initialize member variables (diff)
downloadyuzu-9b50dca2bbabff87c78050372d992d088c897502.tar
yuzu-9b50dca2bbabff87c78050372d992d088c897502.tar.gz
yuzu-9b50dca2bbabff87c78050372d992d088c897502.tar.bz2
yuzu-9b50dca2bbabff87c78050372d992d088c897502.tar.lz
yuzu-9b50dca2bbabff87c78050372d992d088c897502.tar.xz
yuzu-9b50dca2bbabff87c78050372d992d088c897502.tar.zst
yuzu-9b50dca2bbabff87c78050372d992d088c897502.zip
-rw-r--r--src/video_core/renderer_opengl/gl_buffer_cache.cpp6
-rw-r--r--src/video_core/renderer_opengl/gl_buffer_cache.h12
2 files changed, 10 insertions, 8 deletions
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.cpp b/src/video_core/renderer_opengl/gl_buffer_cache.cpp
index c85fbd306..0b5d18bcb 100644
--- a/src/video_core/renderer_opengl/gl_buffer_cache.cpp
+++ b/src/video_core/renderer_opengl/gl_buffer_cache.cpp
@@ -2,8 +2,10 @@
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.
+#include <cstring>
+#include <memory>
+
#include "common/alignment.h"
-#include "common/assert.h"
#include "core/core.h"
#include "core/memory.h"
#include "video_core/renderer_opengl/gl_buffer_cache.h"
@@ -75,7 +77,7 @@ void OGLBufferCache::Unmap() {
stream_buffer.Unmap(buffer_offset - buffer_offset_base);
}
-GLuint OGLBufferCache::GetHandle() {
+GLuint OGLBufferCache::GetHandle() const {
return stream_buffer.GetHandle();
}
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.h b/src/video_core/renderer_opengl/gl_buffer_cache.h
index 9c7ad27e6..6da862902 100644
--- a/src/video_core/renderer_opengl/gl_buffer_cache.h
+++ b/src/video_core/renderer_opengl/gl_buffer_cache.h
@@ -4,8 +4,8 @@
#pragma once
+#include <cstddef>
#include <memory>
-#include <unordered_map>
#include "common/common_types.h"
#include "video_core/rasterizer_cache.h"
@@ -31,7 +31,7 @@ struct CachedBufferEntry final {
class OGLBufferCache final : public RasterizerCache<std::shared_ptr<CachedBufferEntry>> {
public:
- OGLBufferCache(size_t size);
+ explicit OGLBufferCache(size_t size);
GLintptr UploadMemory(Tegra::GPUVAddr gpu_addr, size_t size, size_t alignment = 4,
bool cache = true);
@@ -41,7 +41,7 @@ public:
void Map(size_t max_size);
void Unmap();
- GLuint GetHandle();
+ GLuint GetHandle() const;
protected:
void AlignBuffer(size_t alignment);
@@ -49,9 +49,9 @@ protected:
private:
OGLStreamBuffer stream_buffer;
- u8* buffer_ptr;
- GLintptr buffer_offset;
- GLintptr buffer_offset_base;
+ u8* buffer_ptr = nullptr;
+ GLintptr buffer_offset = 0;
+ GLintptr buffer_offset_base = 0;
};
} // namespace OpenGL