diff options
author | bunnei <bunneidev@gmail.com> | 2018-12-15 06:30:10 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-12-15 06:30:10 +0100 |
commit | d1603a0abbff7ebeda0c68b728bcfe012ae6a58a (patch) | |
tree | 34397e9e02f167436279de3cd1f566dd065270ec /src/core/hle/service/service.cpp | |
parent | Merge pull request #1732 from DarkLordZach/yield-types (diff) | |
parent | Fix Service object leak on emulation stop (diff) | |
download | yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar.gz yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar.bz2 yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar.lz yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar.xz yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.tar.zst yuzu-d1603a0abbff7ebeda0c68b728bcfe012ae6a58a.zip |
Diffstat (limited to 'src/core/hle/service/service.cpp')
-rw-r--r-- | src/core/hle/service/service.cpp | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp index d41df3732..d25b80ab0 100644 --- a/src/core/hle/service/service.cpp +++ b/src/core/hle/service/service.cpp @@ -97,29 +97,33 @@ ServiceFrameworkBase::ServiceFrameworkBase(const char* service_name, u32 max_ses ServiceFrameworkBase::~ServiceFrameworkBase() = default; void ServiceFrameworkBase::InstallAsService(SM::ServiceManager& service_manager) { - ASSERT(port == nullptr); - port = service_manager.RegisterService(service_name, max_sessions).Unwrap(); + ASSERT(!port_installed); + + auto port = service_manager.RegisterService(service_name, max_sessions).Unwrap(); port->SetHleHandler(shared_from_this()); + port_installed = true; } void ServiceFrameworkBase::InstallAsNamedPort() { - ASSERT(port == nullptr); + ASSERT(!port_installed); auto& kernel = Core::System::GetInstance().Kernel(); auto [server_port, client_port] = Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); server_port->SetHleHandler(shared_from_this()); kernel.AddNamedPort(service_name, std::move(client_port)); + port_installed = true; } Kernel::SharedPtr<Kernel::ClientPort> ServiceFrameworkBase::CreatePort() { - ASSERT(port == nullptr); + ASSERT(!port_installed); auto& kernel = Core::System::GetInstance().Kernel(); auto [server_port, client_port] = Kernel::ServerPort::CreatePortPair(kernel, max_sessions, service_name); - port = MakeResult(std::move(server_port)).Unwrap(); + auto port = MakeResult(std::move(server_port)).Unwrap(); port->SetHleHandler(shared_from_this()); + port_installed = true; return client_port; } |