summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMerry <git@mary.rs>2023-02-10 21:43:34 +0100
committerMerry <git@mary.rs>2023-02-10 21:43:34 +0100
commit3c60bc36a15888c401f745641efe0170d0531e4f (patch)
treeb8e1c693c36da0e6dd3a63200a31dcb949be9b2e /src
parentbiquad_filter: Fix rounding in ApplyBiquadFilterInt (diff)
downloadyuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar.gz
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar.bz2
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar.lz
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar.xz
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.tar.zst
yuzu-3c60bc36a15888c401f745641efe0170d0531e4f.zip
Diffstat (limited to 'src')
-rw-r--r--src/audio_core/renderer/command/effect/biquad_filter.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/audio_core/renderer/command/effect/biquad_filter.cpp b/src/audio_core/renderer/command/effect/biquad_filter.cpp
index 52f775bfa..dea6423dc 100644
--- a/src/audio_core/renderer/command/effect/biquad_filter.cpp
+++ b/src/audio_core/renderer/command/effect/biquad_filter.cpp
@@ -20,8 +20,8 @@ namespace AudioCore::AudioRenderer {
void ApplyBiquadFilterFloat(std::span<s32> output, std::span<const s32> input,
std::array<s16, 3>& b_, std::array<s16, 2>& a_,
VoiceState::BiquadFilterState& state, const u32 sample_count) {
- constexpr s64 min{std::numeric_limits<s32>::min()};
- constexpr s64 max{std::numeric_limits<s32>::max()};
+ constexpr f64 min{std::numeric_limits<s32>::min()};
+ constexpr f64 max{std::numeric_limits<s32>::max()};
std::array<f64, 3> b{Common::FixedPoint<50, 14>::from_base(b_[0]).to_double(),
Common::FixedPoint<50, 14>::from_base(b_[1]).to_double(),
Common::FixedPoint<50, 14>::from_base(b_[2]).to_double()};
@@ -34,7 +34,7 @@ void ApplyBiquadFilterFloat(std::span<s32> output, std::span<const s32> input,
f64 in_sample{static_cast<f64>(input[i])};
auto sample{in_sample * b[0] + s[0] * b[1] + s[1] * b[2] + s[2] * a[0] + s[3] * a[1]};
- output[i] = static_cast<s32>(std::clamp(static_cast<s64>(sample), min, max));
+ output[i] = static_cast<s32>(std::clamp(sample, min, max));
s[1] = s[0];
s[0] = in_sample;